Simplify PasswordDropdownShown.* histograms in password/histograms.xml Change-Id: Id2cad6bf1b4cc4d1e001e1d8131c1d1d267e0c12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6578506 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Adem Derinel <derinel@google.com> Cr-Commit-Position: refs/heads/main@{#1464590}
diff --git a/tools/metrics/histograms/metadata/password/histograms.xml b/tools/metrics/histograms/metadata/password/histograms.xml index c217ef4d..f6062d90 100644 --- a/tools/metrics/histograms/metadata/password/histograms.xml +++ b/tools/metrics/histograms/metadata/password/histograms.xml
@@ -2867,8 +2867,10 @@ <owner>derinel@google.com</owner> <owner>markusheintz@google.com</owner> <summary> - Logs the number of passwords in the password dropdown when it's shown for a - WebAuthn request. + Logs the number of passwords in the password dropdown when it's shown. This + metric is only recorded when the field is not supporting WebAuthn + conditional UI, that is the field is not annotated with + autocomplete="webauthn". </summary> </histogram> @@ -2883,50 +2885,39 @@ </histogram> <histogram - name="PasswordManager.PasswordDropdownShown.WebAuthnRequest.PasskeyCount" - units="credentials" expires_after="2025-11-16"> - <owner>derinel@google.com</owner> - <owner>markusheintz@google.com</owner> - <summary> - Logs the number of passkeys in the password dropdown when it's shown for a - WebAuthn conditional get request. - </summary> -</histogram> - -<histogram - name="PasswordManager.PasswordDropdownShown.WebAuthnRequest.PasswordCount" - units="credentials" expires_after="2025-11-16"> - <owner>derinel@google.com</owner> - <owner>markusheintz@google.com</owner> - <summary> - Logs the number of passwords in the password dropdown when it's shown for a - WebAuthn conditional get request. - </summary> -</histogram> - -<histogram - name="PasswordManager.PasswordDropdownShown.WebAuthnRequest.TotalCount" - units="credentials" expires_after="2025-11-16"> - <owner>derinel@google.com</owner> - <owner>markusheintz@google.com</owner> - <summary> - Logs the total number of credentials in the password dropdown when it's - shown for a WebAuthn conditional get request. This is the sum of - "PasskeyCount" and "PasswordCount" with the same prefix. - </summary> -</histogram> - -<histogram name="PasswordManager.PasswordDropdownShown.WebAuthnRequest.UseAnotherDeviceShown" enum="Boolean" expires_after="2025-11-16"> <owner>derinel@google.com</owner> <owner>markusheintz@google.com</owner> <summary> Logs whether the password dropdown has the option to use another device for - a passkey sign in. This is emitted when the dropdown is displayed. + a passkey sign in. Recorded when the dropdown is displayed for a WebAuthn + conditional get request. </summary> </histogram> +<histogram + name="PasswordManager.PasswordDropdownShown.WebAuthnRequest{MetricType}" + units="credentials" expires_after="2025-11-16"> + <owner>derinel@google.com</owner> + <owner>markusheintz@google.com</owner> + <summary> + Logs details about the password dropdown when it's shown for a WebAuthn + conditional get request. Recorded when the dropdown is displayed. + {MetricType} + </summary> + <token key="MetricType"> + <variant name=".PasskeyCount" + summary="Logs the number of passkeys in the password dropdown."/> + <variant name=".PasswordCount" + summary="Logs the number of passwords in the password dropdown."/> + <variant name=".TotalCount" + summary="Logs the total number of credentials in the password + dropdown. This is the sum of PasskeyCount and PasswordCount + for WebAuthn requests."/> + </token> +</histogram> + <histogram name="PasswordManager.PasswordFilling.ReauthPromo" enum="PasswordFillingReauthPromoShown" expires_after="2026-03-28"> <owner>droger@chromium.org</owner>