blob: 121ec704c00350a69bfd90085063312a0c4ea38b [file] [log] [blame]
// Copyright 2011 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "cc/trees/layer_tree_host_impl.h"
#include <stddef.h>
#include <cmath>
#include <memory>
#include <utility>
#include "base/bind.h"
#include "base/callback_helpers.h"
#include "base/memory/memory_pressure_listener.h"
#include "base/memory/ptr_util.h"
#include "base/ranges/algorithm.h"
#include "base/run_loop.h"
#include "base/test/bind.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/threading/thread_task_runner_handle.h"
#include "base/time/time.h"
#include "build/build_config.h"
#include "cc/animation/animation.h"
#include "cc/animation/animation_host.h"
#include "cc/animation/animation_id_provider.h"
#include "cc/base/features.h"
#include "cc/base/histograms.h"
#include "cc/input/browser_controls_offset_manager.h"
#include "cc/input/input_handler.h"
#include "cc/input/main_thread_scrolling_reason.h"
#include "cc/input/page_scale_animation.h"
#include "cc/input/scroll_utils.h"
#include "cc/input/scrollbar_controller.h"
#include "cc/layers/append_quads_data.h"
#include "cc/layers/layer_impl.h"
#include "cc/layers/painted_overlay_scrollbar_layer_impl.h"
#include "cc/layers/painted_scrollbar_layer_impl.h"
#include "cc/layers/render_surface_impl.h"
#include "cc/layers/solid_color_layer_impl.h"
#include "cc/layers/solid_color_scrollbar_layer_impl.h"
#include "cc/layers/surface_layer_impl.h"
#include "cc/layers/video_layer_impl.h"
#include "cc/layers/viewport.h"
#include "cc/resources/ui_resource_bitmap.h"
#include "cc/resources/ui_resource_manager.h"
#include "cc/test/animation_test_common.h"
#include "cc/test/fake_frame_info.h"
#include "cc/test/fake_impl_task_runner_provider.h"
#include "cc/test/fake_layer_tree_frame_sink.h"
#include "cc/test/fake_layer_tree_host_impl.h"
#include "cc/test/fake_picture_layer_impl.h"
#include "cc/test/fake_raster_source.h"
#include "cc/test/fake_recording_source.h"
#include "cc/test/fake_video_frame_provider.h"
#include "cc/test/layer_test_common.h"
#include "cc/test/layer_tree_test.h"
#include "cc/test/mock_latency_info_swap_promise_monitor.h"
#include "cc/test/skia_common.h"
#include "cc/test/test_layer_tree_frame_sink.h"
#include "cc/test/test_paint_worklet_layer_painter.h"
#include "cc/test/test_task_graph_runner.h"
#include "cc/trees/clip_node.h"
#include "cc/trees/compositor_commit_data.h"
#include "cc/trees/draw_property_utils.h"
#include "cc/trees/effect_node.h"
#include "cc/trees/latency_info_swap_promise.h"
#include "cc/trees/layer_tree_impl.h"
#include "cc/trees/mutator_host.h"
#include "cc/trees/render_frame_metadata.h"
#include "cc/trees/render_frame_metadata_observer.h"
#include "cc/trees/scroll_node.h"
#include "cc/trees/transform_node.h"
#include "cc/view_transition/view_transition_request.h"
#include "components/viz/common/frame_sinks/begin_frame_args.h"
#include "components/viz/common/frame_sinks/copy_output_request.h"
#include "components/viz/common/frame_sinks/copy_output_result.h"
#include "components/viz/common/frame_timing_details.h"
#include "components/viz/common/quads/compositor_frame_metadata.h"
#include "components/viz/common/quads/compositor_render_pass_draw_quad.h"
#include "components/viz/common/quads/solid_color_draw_quad.h"
#include "components/viz/common/quads/texture_draw_quad.h"
#include "components/viz/common/quads/tile_draw_quad.h"
#include "components/viz/common/surfaces/frame_sink_id.h"
#include "components/viz/common/surfaces/region_capture_bounds.h"
#include "components/viz/service/display/skia_output_surface.h"
#include "components/viz/test/begin_frame_args_test.h"
#include "components/viz/test/fake_output_surface.h"
#include "components/viz/test/fake_skia_output_surface.h"
#include "gpu/GLES2/gl2extchromium.h"
#include "media/base/media.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/abseil-cpp/absl/types/optional.h"
#include "third_party/skia/include/core/SkMallocPixelRef.h"
#include "ui/events/types/scroll_input_type.h"
#include "ui/gfx/geometry/angle_conversions.h"
#include "ui/gfx/geometry/point_conversions.h"
#include "ui/gfx/geometry/size_conversions.h"
#include "ui/gfx/geometry/test/geometry_util.h"
#include "ui/gfx/geometry/transform_operations.h"
#include "ui/gfx/geometry/vector2d_conversions.h"
#include "ui/latency/latency_info.h"
#define EXPECT_SCOPED(statements) \
{ \
SCOPED_TRACE(""); \
statements; \
}
using media::VideoFrame;
using ::testing::_;
using ::testing::AnyNumber;
using ::testing::AtLeast;
using ::testing::Mock;
using ::testing::Return;
using ::testing::StrictMock;
using ScrollThread = cc::InputHandler::ScrollThread;
namespace cc {
namespace {
constexpr gfx::Size kDefaultLayerSize(100, 100);
viz::SurfaceId MakeSurfaceId(const viz::FrameSinkId& frame_sink_id,
uint32_t parent_id) {
return viz::SurfaceId(
frame_sink_id,
viz::LocalSurfaceId(parent_id,
base::UnguessableToken::Deserialize(0, 1u)));
}
struct TestFrameData : public LayerTreeHostImpl::FrameData {
TestFrameData() {
// Set ack to something valid, so DCHECKs don't complain.
begin_frame_ack = viz::BeginFrameAck::CreateManualAckWithDamage();
}
};
void ClearMainThreadDeltasForTesting(LayerTreeHostImpl* host) {
host->active_tree()->ApplySentScrollAndScaleDeltasFromAbortedCommit(
/* next_bmf */ false, /* main_frame_applied_deltas */ false);
}
} // namespace
class LayerTreeHostImplTest : public testing::Test,
public LayerTreeHostImplClient {
public:
LayerTreeHostImplTest()
: task_runner_provider_(base::ThreadTaskRunnerHandle::Get()),
always_main_thread_blocked_(&task_runner_provider_),
on_can_draw_state_changed_called_(false),
did_notify_ready_to_activate_(false),
did_request_commit_(false),
did_request_redraw_(false),
did_request_next_frame_(false),
did_request_prepare_tiles_(false),
did_prepare_tiles_(false),
did_complete_page_scale_animation_(false),
reduce_memory_result_(true),
did_request_impl_side_invalidation_(false) {
media::InitializeMediaLibrary();
}
LayerTreeSettings DefaultSettings() {
LayerListSettings settings;
settings.minimum_occlusion_tracking_size = gfx::Size();
settings.enable_smooth_scroll = true;
return settings;
}
// Settings with GPU rasterization disabled. New tests should test with GPU
// rasterization enabled by default.
LayerTreeSettings LegacySWSettings() {
LayerTreeSettings settings = DefaultSettings();
settings.gpu_rasterization_disabled = true;
return settings;
}
void SetUp() override {
CreateHostImpl(DefaultSettings(), CreateLayerTreeFrameSink());
// TODO(bokan): Mac wheel scrolls don't cause smooth scrolling in the real
// world. In tests, we force it on for consistency. Can be removed when
// https://crbug.com/574283 is fixed.
host_impl_->set_force_smooth_wheel_scrolling_for_testing(true);
}
void CreatePendingTree() {
host_impl_->CreatePendingTree();
LayerTreeImpl* pending_tree = host_impl_->pending_tree();
pending_tree->SetDeviceViewportRect(
host_impl_->active_tree()->GetDeviceViewport());
pending_tree->SetDeviceScaleFactor(
host_impl_->active_tree()->device_scale_factor());
// Normally a pending tree will not be fully painted until the commit has
// happened and any PaintWorklets have been resolved. However many of the
// unittests never actually commit the pending trees that they create, so to
// enable them to still treat the tree as painted we forcibly override the
// state here. Note that this marks a distinct departure from reality in the
// name of easier testing.
host_impl_->set_pending_tree_fully_painted_for_testing(true);
}
void TearDown() override {
if (host_impl_)
host_impl_->ReleaseLayerTreeFrameSink();
}
void DidLoseLayerTreeFrameSinkOnImplThread() override {}
void SetBeginFrameSource(viz::BeginFrameSource* source) override {}
void DidReceiveCompositorFrameAckOnImplThread() override {}
void OnCanDrawStateChanged(bool can_draw) override {
on_can_draw_state_changed_called_ = true;
}
void NotifyReadyToActivate() override {
did_notify_ready_to_activate_ = true;
host_impl_->ActivateSyncTree();
}
bool IsReadyToActivate() override {
// in NotifyReadyToActivate(), call ActivateSyncTree() directly
// so this is always false
return false;
}
void NotifyReadyToDraw() override {}
void SetNeedsRedrawOnImplThread() override { did_request_redraw_ = true; }
void SetNeedsOneBeginImplFrameOnImplThread() override {
did_request_next_frame_ = true;
}
void SetNeedsPrepareTilesOnImplThread() override {
did_request_prepare_tiles_ = true;
}
void SetNeedsCommitOnImplThread() override { did_request_commit_ = true; }
void SetVideoNeedsBeginFrames(bool needs_begin_frames) override {}
void SetDeferBeginMainFrameFromImpl(bool defer_begin_main_frame) override {}
bool IsInsideDraw() override { return false; }
void RenewTreePriority() override {}
void PostDelayedAnimationTaskOnImplThread(base::OnceClosure task,
base::TimeDelta delay) override {
animation_task_ = std::move(task);
requested_animation_delay_ = delay;
}
void DidActivateSyncTree() override {
// Make sure the active tree always has a valid LocalSurfaceId.
host_impl_->active_tree()->SetLocalSurfaceIdFromParent(
viz::LocalSurfaceId(1, base::UnguessableToken::Deserialize(2u, 3u)));
}
void WillPrepareTiles() override {}
void DidPrepareTiles() override { did_prepare_tiles_ = true; }
void DidCompletePageScaleAnimationOnImplThread() override {
did_complete_page_scale_animation_ = true;
}
void OnDrawForLayerTreeFrameSink(bool resourceless_software_draw,
bool skip_draw) override {
std::unique_ptr<TestFrameData> frame(new TestFrameData);
EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(frame.get()));
last_on_draw_render_passes_.clear();
viz::CompositorRenderPass::CopyAllForTest(frame->render_passes,
&last_on_draw_render_passes_);
host_impl_->DrawLayers(frame.get());
host_impl_->DidDrawAllLayers(*frame);
last_on_draw_frame_ = std::move(frame);
}
void NeedsImplSideInvalidation(bool needs_first_draw_on_activation) override {
did_request_impl_side_invalidation_ = true;
}
void NotifyImageDecodeRequestFinished() override {}
void DidPresentCompositorFrameOnImplThread(
uint32_t frame_token,
PresentationTimeCallbackBuffer::PendingCallbacks activated,
const viz::FrameTimingDetails& details) override {
// We don't call main thread callbacks in this test.
activated.main_callbacks.clear();
activated.main_successful_callbacks.clear();
host_impl_->NotifyDidPresentCompositorFrameOnImplThread(
frame_token, std::move(activated.compositor_successful_callbacks),
details);
}
void NotifyAnimationWorkletStateChange(AnimationWorkletMutationState state,
ElementListType tree_type) override {}
void NotifyPaintWorkletStateChange(
Scheduler::PaintWorkletState state) override {}
void NotifyThroughputTrackerResults(CustomTrackerResults results) override {}
void DidObserveFirstScrollDelay(
base::TimeDelta first_scroll_delay,
base::TimeTicks first_scroll_timestamp) override {
first_scroll_observed++;
}
bool IsInSynchronousComposite() const override { return false; }
void FrameSinksToThrottleUpdated(
const base::flat_set<viz::FrameSinkId>& ids) override {}
void ClearHistory() override {}
size_t CommitDurationSampleCountForTesting() const override { return 0; }
void NotifyTransitionRequestFinished(uint32_t sequence_id) override {}
void set_reduce_memory_result(bool reduce_memory_result) {
reduce_memory_result_ = reduce_memory_result;
}
AnimationHost* GetImplAnimationHost() const {
return static_cast<AnimationHost*>(host_impl_->mutator_host());
}
virtual bool CreateHostImpl(
const LayerTreeSettings& settings,
std::unique_ptr<LayerTreeFrameSink> layer_tree_frame_sink) {
if (host_impl_)
host_impl_->ReleaseLayerTreeFrameSink();
host_impl_.reset();
InitializeImageWorker(settings);
host_impl_ = LayerTreeHostImpl::Create(
settings, this, &task_runner_provider_, &stats_instrumentation_,
&task_graph_runner_,
AnimationHost::CreateForTesting(ThreadInstance::IMPL), nullptr, 0,
image_worker_ ? image_worker_->task_runner() : nullptr, nullptr);
InputHandler::Create(static_cast<CompositorDelegateForInput&>(*host_impl_));
layer_tree_frame_sink_ = std::move(layer_tree_frame_sink);
host_impl_->SetVisible(true);
bool init = host_impl_->InitializeFrameSink(layer_tree_frame_sink_.get());
host_impl_->active_tree()->SetDeviceViewportRect(gfx::Rect(10, 10));
host_impl_->active_tree()->PushPageScaleFromMainThread(1, 1, 1);
host_impl_->active_tree()->SetLocalSurfaceIdFromParent(
viz::LocalSurfaceId(1, base::UnguessableToken::Deserialize(2u, 3u)));
// Set the viz::BeginFrameArgs so that methods which use it are able to.
auto args = viz::CreateBeginFrameArgsForTesting(
BEGINFRAME_FROM_HERE, 0, 1, base::TimeTicks() + base::Milliseconds(1));
host_impl_->WillBeginImplFrame(args);
host_impl_->DidFinishImplFrame(args);
timeline_ =
AnimationTimeline::Create(AnimationIdProvider::NextTimelineId());
GetImplAnimationHost()->AddAnimationTimeline(timeline_);
return init;
}
template <typename T, typename... Args>
T* SetupRootLayer(LayerTreeImpl* layer_tree_impl,
const gfx::Size& viewport_size,
Args&&... args) {
const int kRootLayerId = 1;
DCHECK(!layer_tree_impl->root_layer());
DCHECK(!layer_tree_impl->LayerById(kRootLayerId));
layer_tree_impl->SetRootLayerForTesting(
T::Create(layer_tree_impl, kRootLayerId, std::forward<Args>(args)...));
auto* root = layer_tree_impl->root_layer();
root->SetBounds(viewport_size);
layer_tree_impl->SetDeviceViewportRect(
gfx::Rect(DipSizeToPixelSize(viewport_size)));
SetupRootProperties(root);
return static_cast<T*>(root);
}
LayerImpl* SetupDefaultRootLayer(
const gfx::Size& viewport_size = kDefaultLayerSize) {
return SetupRootLayer<LayerImpl>(host_impl_->active_tree(), viewport_size);
}
LayerImpl* root_layer() { return host_impl_->active_tree()->root_layer(); }
gfx::Size DipSizeToPixelSize(const gfx::Size& size) {
return gfx::ScaleToRoundedSize(
size, host_impl_->active_tree()->device_scale_factor());
}
void PushScrollOffsetsToPendingTree(
const base::flat_map<ElementId, gfx::PointF>& offsets) {
PropertyTrees property_trees(*host_impl_);
auto& scroll_tree =
host_impl_->active_tree()->property_trees()->scroll_tree_mutable();
if (auto* layer = InnerViewportScrollLayer()) {
property_trees.scroll_tree_mutable().SetBaseScrollOffset(
layer->element_id(),
scroll_tree.current_scroll_offset(layer->element_id()));
}
if (auto* layer = OuterViewportScrollLayer()) {
property_trees.scroll_tree_mutable().SetBaseScrollOffset(
layer->element_id(),
scroll_tree.current_scroll_offset(layer->element_id()));
}
for (auto& entry : offsets) {
property_trees.scroll_tree_mutable().SetBaseScrollOffset(entry.first,
entry.second);
}
host_impl_->sync_tree()
->property_trees()
->scroll_tree_mutable()
.PushScrollUpdatesFromMainThread(
property_trees, host_impl_->sync_tree(),
host_impl_->settings().commit_fractional_scroll_deltas);
}
void ClearNonScrollSyncTreeDeltasForTesting() {
auto* tree = host_impl_->sync_tree();
tree->page_scale_factor()->AbortCommit(
/* next_bmf */ false, /* main_frame_applied_deltas */ false);
tree->top_controls_shown_ratio()->AbortCommit(
/* next_bmf */ false, /* main_frame_applied_deltas */ false);
tree->bottom_controls_shown_ratio()->AbortCommit(
/* next_bmf */ false, /* main_frame_applied_deltas */ false);
tree->elastic_overscroll()->AbortCommit(
/* next_bmf */ false, /* main_frame_applied_deltas */ false);
}
static void ExpectClearedScrollDeltasRecursive(LayerImpl* root) {
for (auto* layer : *root->layer_tree_impl())
ASSERT_EQ(ScrollDelta(layer), gfx::Vector2d());
}
static ::testing::AssertionResult ScrollInfoContains(
const CompositorCommitData& commit_data,
ElementId id,
const gfx::Vector2dF& scroll_delta) {
int times_encountered = 0;
for (size_t i = 0; i < commit_data.scrolls.size(); ++i) {
if (commit_data.scrolls[i].element_id != id)
continue;
if (scroll_delta != commit_data.scrolls[i].scroll_delta) {
return ::testing::AssertionFailure()
<< "Expected " << scroll_delta.ToString() << ", not "
<< commit_data.scrolls[i].scroll_delta.ToString();
}
times_encountered++;
}
if (id == commit_data.inner_viewport_scroll.element_id) {
if (scroll_delta != commit_data.inner_viewport_scroll.scroll_delta) {
return ::testing::AssertionFailure()
<< "Expected " << scroll_delta.ToString() << ", not "
<< commit_data.inner_viewport_scroll.scroll_delta.ToString();
}
times_encountered++;
}
if (times_encountered != 1)
return ::testing::AssertionFailure() << "No scroll found with id " << id;
return ::testing::AssertionSuccess();
}
static void ExpectNone(const CompositorCommitData& commit_data,
ElementId id) {
int times_encountered = 0;
for (size_t i = 0; i < commit_data.scrolls.size(); ++i) {
if (commit_data.scrolls[i].element_id != id)
continue;
times_encountered++;
}
ASSERT_EQ(0, times_encountered);
}
template <typename T, typename... Args>
T* AddLayer(LayerTreeImpl* layer_tree_impl, Args&&... args) {
std::unique_ptr<T> layer = T::Create(layer_tree_impl, next_layer_id_++,
std::forward<Args>(args)...);
T* result = layer.get();
layer_tree_impl->AddLayer(std::move(layer));
return result;
}
LayerImpl* AddLayer() {
return AddLayer<LayerImpl>(host_impl_->active_tree());
}
void SetupViewportLayers(LayerTreeImpl* layer_tree_impl,
const gfx::Size& inner_viewport_size,
const gfx::Size& outer_viewport_size,
const gfx::Size& content_size) {
DCHECK(!layer_tree_impl->root_layer());
auto* root =
SetupRootLayer<LayerImpl>(layer_tree_impl, inner_viewport_size);
SetupViewport(root, outer_viewport_size, content_size);
host_impl_->SetVisualDeviceViewportSize(inner_viewport_size);
UpdateDrawProperties(layer_tree_impl);
layer_tree_impl->DidBecomeActive();
}
// Calls SetupViewportLayers() passing |content_size| as that function's
// |outer_viewport_size| and |content_size|, which makes the outer viewport
// not scrollable, and scrolls will be applied directly to the inner viewport.
void SetupViewportLayersInnerScrolls(const gfx::Size& inner_viewport_size,
const gfx::Size& content_size) {
const auto& outer_viewport_size = content_size;
SetupViewportLayers(host_impl_->active_tree(), inner_viewport_size,
outer_viewport_size, content_size);
}
// Calls SetupViewportLayers() passing |viewport_size| as that function's
// |inner_viewport_size| and |outer_viewport_size|, which makes the inner
// viewport not scrollable, and scrolls will be applied to the outer
// viewport only.
void SetupViewportLayersOuterScrolls(const gfx::Size& viewport_size,
const gfx::Size& content_size) {
SetupViewportLayers(host_impl_->active_tree(), viewport_size, viewport_size,
content_size);
}
LayerImpl* AddContentLayer() {
LayerImpl* scroll_layer = OuterViewportScrollLayer();
DCHECK(scroll_layer);
LayerImpl* layer = AddLayer();
layer->SetBounds(scroll_layer->bounds());
layer->SetDrawsContent(true);
CopyProperties(scroll_layer, layer);
return layer;
}
// Calls SetupViewportLayers() with the same |viewport_bounds|,
// |inner_scroll_bounds| and |outer_scroll_bounds|, which makes neither
// of inner viewport and outer viewport scrollable.
void SetupViewportLayersNoScrolls(const gfx::Size& bounds) {
SetupViewportLayers(host_impl_->active_tree(), bounds, bounds, bounds);
}
void CreateAndTestNonScrollableLayers(bool transparent_layer) {
LayerTreeImpl* layer_tree_impl = host_impl_->active_tree();
gfx::Size content_size = gfx::Size(360, 600);
gfx::Size scroll_content_size = gfx::Size(345, 3800);
gfx::Size scrollbar_size = gfx::Size(15, 600);
SetupViewportLayersNoScrolls(content_size);
LayerImpl* outer_scroll = OuterViewportScrollLayer();
LayerImpl* scroll =
AddScrollableLayer(outer_scroll, content_size, scroll_content_size);
auto* squash2 = AddLayer<LayerImpl>(layer_tree_impl);
squash2->SetBounds(gfx::Size(140, 300));
squash2->SetDrawsContent(true);
squash2->SetHitTestable(true);
CopyProperties(scroll, squash2);
squash2->SetOffsetToTransformParent(gfx::Vector2dF(220, 300));
auto* scrollbar = AddLayer<PaintedScrollbarLayerImpl>(
layer_tree_impl, ScrollbarOrientation::VERTICAL, false, true);
SetupScrollbarLayer(scroll, scrollbar);
scrollbar->SetBounds(scrollbar_size);
scrollbar->SetOffsetToTransformParent(gfx::Vector2dF(345, 0));
auto* squash1 = AddLayer<LayerImpl>(layer_tree_impl);
squash1->SetBounds(gfx::Size(140, 300));
CopyProperties(outer_scroll, squash1);
squash1->SetOffsetToTransformParent(gfx::Vector2dF(220, 0));
if (transparent_layer) {
CreateEffectNode(squash1).opacity = 0.0f;
// The transparent layer should still participate in hit testing even
// through it does not draw content.
squash1->SetHitTestable(true);
} else {
squash1->SetDrawsContent(true);
squash1->SetHitTestable(true);
}
UpdateDrawProperties(layer_tree_impl);
layer_tree_impl->DidBecomeActive();
// The point hits squash1 layer and also scroll layer, because scroll layer
// is not an ancestor of squash1 layer, we cannot scroll on impl thread
// (without at least a hit test on the main thread).
InputHandler::ScrollStatus status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(230, 150), gfx::Vector2dF(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
if (base::FeatureList::IsEnabled(features::kScrollUnification)) {
ASSERT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
ASSERT_TRUE(status.needs_main_thread_hit_test);
} else {
ASSERT_EQ(ScrollThread::SCROLL_ON_MAIN_THREAD, status.thread);
ASSERT_EQ(MainThreadScrollingReason::kFailedHitTest,
status.main_thread_scrolling_reasons);
}
// The point hits squash1 layer and also scrollbar layer.
status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(350, 150), gfx::Vector2dF(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
if (base::FeatureList::IsEnabled(features::kScrollUnification)) {
ASSERT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
ASSERT_TRUE(status.needs_main_thread_hit_test);
} else {
ASSERT_EQ(ScrollThread::SCROLL_ON_MAIN_THREAD, status.thread);
ASSERT_EQ(MainThreadScrollingReason::kFailedHitTest,
status.main_thread_scrolling_reasons);
}
// The point hits squash2 layer and also scroll layer, because scroll layer
// is an ancestor of squash2 layer, we should scroll on impl.
status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(230, 450), gfx::Vector2dF(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
ASSERT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
}
LayerImpl* AddScrollableLayer(LayerImpl* container,
const gfx::Size& scroll_container_bounds,
const gfx::Size& content_size) {
LayerImpl* layer = AddLayer<LayerImpl>(container->layer_tree_impl());
layer->SetElementId(LayerIdToElementIdForTesting(layer->id()));
layer->SetDrawsContent(true);
layer->SetBounds(content_size);
layer->SetHitTestable(true);
CopyProperties(container, layer);
CreateTransformNode(layer);
CreateScrollNode(layer, scroll_container_bounds);
return layer;
}
void SetupScrollbarLayerCommon(LayerImpl* scroll_layer,
ScrollbarLayerImplBase* scrollbar) {
auto* tree_impl = scroll_layer->layer_tree_impl();
scrollbar->SetScrollElementId(scroll_layer->element_id());
scrollbar->SetDrawsContent(true);
CopyProperties(scroll_layer, scrollbar);
if (scroll_layer == tree_impl->OuterViewportScrollLayerForTesting()) {
scrollbar->SetTransformTreeIndex(tree_impl->PageScaleTransformNode()->id);
scrollbar->SetScrollTreeIndex(
tree_impl->root_layer()->scroll_tree_index());
} else {
scrollbar->SetTransformTreeIndex(
GetTransformNode(scroll_layer)->parent_id);
scrollbar->SetScrollTreeIndex(GetScrollNode(scroll_layer)->parent_id);
}
}
void SetupScrollbarLayer(LayerImpl* scroll_layer,
SolidColorScrollbarLayerImpl* scrollbar) {
scrollbar->SetElementId(LayerIdToElementIdForTesting(scrollbar->id()));
SetupScrollbarLayerCommon(scroll_layer, scrollbar);
auto& effect = CreateEffectNode(scrollbar);
effect.opacity = 0;
effect.has_potential_opacity_animation = true;
}
void SetupScrollbarLayer(LayerImpl* scroll_layer,
PaintedScrollbarLayerImpl* scrollbar) {
SetupScrollbarLayerCommon(scroll_layer, scrollbar);
scrollbar->SetHitTestable(true);
CreateEffectNode(scrollbar).opacity = 1;
}
LayerImpl* InnerViewportScrollLayer() {
return host_impl_->active_tree()->InnerViewportScrollLayerForTesting();
}
LayerImpl* OuterViewportScrollLayer() {
return host_impl_->active_tree()->OuterViewportScrollLayerForTesting();
}
std::unique_ptr<ScrollState> BeginState(const gfx::Point& point,
const gfx::Vector2dF& delta_hint,
ui::ScrollInputType type) {
ScrollStateData scroll_state_data;
scroll_state_data.is_beginning = true;
scroll_state_data.position_x = point.x();
scroll_state_data.position_y = point.y();
scroll_state_data.delta_x_hint = delta_hint.x();
scroll_state_data.delta_y_hint = delta_hint.y();
scroll_state_data.is_direct_manipulation =
type == ui::ScrollInputType::kTouchscreen;
std::unique_ptr<ScrollState> scroll_state(
new ScrollState(scroll_state_data));
return scroll_state;
}
std::unique_ptr<ScrollState> UpdateState(const gfx::Point& point,
const gfx::Vector2dF& delta,
ui::ScrollInputType type) {
ScrollStateData scroll_state_data;
scroll_state_data.delta_x = delta.x();
scroll_state_data.delta_y = delta.y();
scroll_state_data.position_x = point.x();
scroll_state_data.position_y = point.y();
scroll_state_data.is_direct_manipulation =
type == ui::ScrollInputType::kTouchscreen;
std::unique_ptr<ScrollState> scroll_state(
new ScrollState(scroll_state_data));
return scroll_state;
}
std::unique_ptr<ScrollState> AnimatedUpdateState(
const gfx::Point& point,
const gfx::Vector2dF& delta) {
auto state = UpdateState(point, delta, ui::ScrollInputType::kWheel);
state->data()->delta_granularity = ui::ScrollGranularity::kScrollByPixel;
return state;
}
void DrawFrame() {
PrepareForUpdateDrawProperties(host_impl_->active_tree());
TestFrameData frame;
auto args = viz::CreateBeginFrameArgsForTesting(
BEGINFRAME_FROM_HERE, viz::BeginFrameArgs::kManualSourceId, 1,
base::TimeTicks() + base::Milliseconds(1));
host_impl_->WillBeginImplFrame(args);
EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame));
host_impl_->DrawLayers(&frame);
host_impl_->DidDrawAllLayers(frame);
host_impl_->DidFinishImplFrame(args);
}
RenderFrameMetadata StartDrawAndProduceRenderFrameMetadata() {
TestFrameData frame;
EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame));
return host_impl_->MakeRenderFrameMetadata(&frame);
}
void TestGPUMemoryForTilings(const gfx::Size& layer_size) {
std::unique_ptr<FakeRecordingSource> recording_source =
FakeRecordingSource::CreateFilledRecordingSource(layer_size);
PaintImage checkerable_image =
CreateDiscardablePaintImage(gfx::Size(500, 500));
recording_source->add_draw_image(checkerable_image, gfx::Point(0, 0));
recording_source->Rerecord();
scoped_refptr<FakeRasterSource> raster_source =
FakeRasterSource::CreateFromRecordingSource(recording_source.get());
// Create the pending tree.
host_impl_->BeginCommit(0, /*trace_id=*/1);
LayerTreeImpl* pending_tree = host_impl_->pending_tree();
LayerImpl* root = SetupRootLayer<FakePictureLayerImpl>(
pending_tree, layer_size, raster_source);
root->SetDrawsContent(true);
UpdateDrawProperties(pending_tree);
// CompleteCommit which should perform a PrepareTiles, adding tilings for
// the root layer, each one having a raster task.
host_impl_->CommitComplete();
// Activate the pending tree and ensure that all tiles are rasterized.
while (!did_notify_ready_to_activate_)
base::RunLoop().RunUntilIdle();
DrawFrame();
host_impl_->ReleaseLayerTreeFrameSink();
host_impl_ = nullptr;
}
void AllowedTouchActionTestHelper(float device_scale_factor,
float page_scale_factor) {
SetupViewportLayersInnerScrolls(gfx::Size(100, 100), gfx::Size(200, 200));
DrawFrame();
// Just hard code some random number, we care about the actual page scale
// factor on the active tree.
float min_page_scale_factor = 0.1f;
float max_page_scale_factor = 5.0f;
host_impl_->active_tree()->PushPageScaleFromMainThread(
page_scale_factor, min_page_scale_factor, max_page_scale_factor);
host_impl_->active_tree()->SetDeviceScaleFactor(device_scale_factor);
LayerImpl* child = AddLayer();
child->SetDrawsContent(true);
child->SetBounds(gfx::Size(25, 25));
CopyProperties(InnerViewportScrollLayer(), child);
TouchActionRegion root_touch_action_region;
root_touch_action_region.Union(TouchAction::kPanX, gfx::Rect(0, 0, 50, 50));
root_layer()->SetTouchActionRegion(root_touch_action_region);
TouchActionRegion child_touch_action_region;
child_touch_action_region.Union(TouchAction::kPanLeft,
gfx::Rect(0, 0, 25, 25));
child->SetTouchActionRegion(child_touch_action_region);
TouchAction touch_action = TouchAction::kAuto;
GetInputHandler().EventListenerTypeForTouchStartOrMoveAt(gfx::Point(10, 10),
&touch_action);
EXPECT_EQ(TouchAction::kPanLeft, touch_action);
touch_action = TouchAction::kAuto;
GetInputHandler().EventListenerTypeForTouchStartOrMoveAt(gfx::Point(30, 30),
&touch_action);
EXPECT_EQ(TouchAction::kPanX, touch_action);
TouchActionRegion new_child_region;
new_child_region.Union(TouchAction::kPanY, gfx::Rect(0, 0, 25, 25));
child->SetTouchActionRegion(new_child_region);
touch_action = TouchAction::kAuto;
GetInputHandler().EventListenerTypeForTouchStartOrMoveAt(gfx::Point(10, 10),
&touch_action);
EXPECT_EQ(TouchAction::kPanY, touch_action);
touch_action = TouchAction::kAuto;
GetInputHandler().EventListenerTypeForTouchStartOrMoveAt(gfx::Point(30, 30),
&touch_action);
EXPECT_EQ(TouchAction::kPanX, touch_action);
}
LayerImpl* CreateLayerForSnapping() {
SetupViewportLayersInnerScrolls(gfx::Size(50, 50), gfx::Size(100, 100));
gfx::Size overflow_size(400, 400);
LayerImpl* overflow = AddScrollableLayer(
OuterViewportScrollLayer(), gfx::Size(100, 100), overflow_size);
SnapContainerData container_data(
ScrollSnapType(false, SnapAxis::kBoth, SnapStrictness::kMandatory),
gfx::RectF(0, 0, 200, 200), gfx::PointF(300, 300));
SnapAreaData area_data(ScrollSnapAlign(SnapAlignment::kStart),
gfx::RectF(50, 50, 100, 100), false, ElementId(10));
container_data.AddSnapAreaData(area_data);
GetScrollNode(overflow)->snap_container_data.emplace(container_data);
DrawFrame();
return overflow;
}
absl::optional<SnapContainerData> GetSnapContainerData(LayerImpl* layer) {
return GetScrollNode(layer) ? GetScrollNode(layer)->snap_container_data
: absl::nullopt;
}
void ClearLayersAndPropertyTrees(LayerTreeImpl* layer_tree_impl) {
layer_tree_impl->SetRootLayerForTesting(nullptr);
layer_tree_impl->DetachLayers();
layer_tree_impl->property_trees()->clear();
layer_tree_impl->SetViewportPropertyIds(ViewportPropertyIds());
}
void pinch_zoom_pan_viewport_forces_commit_redraw(float device_scale_factor);
void pinch_zoom_pan_viewport_test(float device_scale_factor);
void pinch_zoom_pan_viewport_and_scroll_test(float device_scale_factor);
void pinch_zoom_pan_viewport_and_scroll_boundary_test(
float device_scale_factor);
void SetupMouseMoveAtWithDeviceScale(float device_scale_factor);
void SetupMouseMoveAtTestScrollbarStates(bool main_thread_scrolling);
scoped_refptr<AnimationTimeline> timeline() { return timeline_; }
protected:
virtual std::unique_ptr<LayerTreeFrameSink> CreateLayerTreeFrameSink() {
return FakeLayerTreeFrameSink::Create3dForGpuRasterization();
}
void DrawOneFrame() {
PrepareForUpdateDrawProperties(host_impl_->active_tree());
TestFrameData frame_data;
host_impl_->PrepareToDraw(&frame_data);
host_impl_->DidDrawAllLayers(frame_data);
}
static void SetScrollOffsetDelta(LayerImpl* layer_impl,
const gfx::Vector2dF& delta) {
if (layer_impl->layer_tree_impl()
->property_trees()
->scroll_tree_mutable()
.SetScrollOffsetDeltaForTesting(layer_impl->element_id(), delta))
layer_impl->layer_tree_impl()->DidUpdateScrollOffset(
layer_impl->element_id());
}
void BeginImplFrameAndAnimate(viz::BeginFrameArgs begin_frame_args,
base::TimeTicks frame_time) {
begin_frame_args.frame_time = frame_time;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
host_impl_->UpdateAnimationState(true);
host_impl_->DidFinishImplFrame(begin_frame_args);
}
void InitializeImageWorker(const LayerTreeSettings& settings) {
if (settings.enable_checker_imaging) {
image_worker_ = std::make_unique<base::Thread>("ImageWorker");
ASSERT_TRUE(image_worker_->Start());
} else {
image_worker_.reset();
}
}
InputHandler& GetInputHandler() { return host_impl_->GetInputHandler(); }
FakeImplTaskRunnerProvider task_runner_provider_;
DebugScopedSetMainThreadBlocked always_main_thread_blocked_;
TestTaskGraphRunner task_graph_runner_;
std::unique_ptr<LayerTreeFrameSink> layer_tree_frame_sink_;
std::unique_ptr<LayerTreeHostImpl> host_impl_;
FakeRenderingStatsInstrumentation stats_instrumentation_;
bool on_can_draw_state_changed_called_;
bool did_notify_ready_to_activate_;
bool did_request_commit_;
bool did_request_redraw_;
bool did_request_next_frame_;
bool did_request_prepare_tiles_;
bool did_prepare_tiles_;
bool did_complete_page_scale_animation_;
bool reduce_memory_result_;
bool did_request_impl_side_invalidation_;
base::OnceClosure animation_task_;
base::TimeDelta requested_animation_delay_;
std::unique_ptr<TestFrameData> last_on_draw_frame_;
viz::CompositorRenderPassList last_on_draw_render_passes_;
scoped_refptr<AnimationTimeline> timeline_;
std::unique_ptr<base::Thread> image_worker_;
int next_layer_id_ = 2;
int first_scroll_observed = 0;
};
// Allows parameterizing the above class on the scroll unification flag. We
// can't parameterize the base class itself because it serves as a base to
// other parameterized descendants. Can be removed when unification ships.
class ScrollUnifiedLayerTreeHostImplTest
: public LayerTreeHostImplTest,
public testing::WithParamInterface<bool> {
public:
ScrollUnifiedLayerTreeHostImplTest() {
if (GetParam()) {
scoped_feature_list.InitAndEnableFeature(features::kScrollUnification);
} else {
scoped_feature_list.InitAndDisableFeature(features::kScrollUnification);
}
}
class StubGpuBacking : public ResourcePool::GpuBacking {
public:
void OnMemoryDump(
base::trace_event::ProcessMemoryDump* pmd,
const base::trace_event::MemoryAllocatorDumpGuid& buffer_dump_guid,
uint64_t tracing_process_id,
int importance) const override {}
};
private:
base::test::ScopedFeatureList scoped_feature_list;
};
class CommitToPendingTreeLayerTreeHostImplTest : public LayerTreeHostImplTest {
public:
void SetUp() override {
LayerTreeSettings settings = DefaultSettings();
settings.commit_to_active_tree = false;
CreateHostImpl(settings, CreateLayerTreeFrameSink());
}
};
class OccludedSurfaceThrottlingLayerTreeHostImplTest
: public LayerTreeHostImplTest {
public:
void SetUp() override {
LayerTreeSettings settings = DefaultSettings();
settings.enable_compositing_based_throttling = true;
CreateHostImpl(settings, CreateLayerTreeFrameSink());
}
};
// A test fixture for new animation timelines tests.
class LayerTreeHostImplTimelinesTest : public LayerTreeHostImplTest {
public:
void SetUp() override {
CreateHostImpl(DefaultSettings(), CreateLayerTreeFrameSink());
// TODO(bokan): Mac wheel scrolls don't cause smooth scrolling in the real
// world. In tests, we force it on for consistency. Can be removed when
// https://crbug.com/574283 is fixed.
host_impl_->set_force_smooth_wheel_scrolling_for_testing(true);
}
};
class TestInputHandlerClient : public InputHandlerClient {
public:
TestInputHandlerClient()
: page_scale_factor_(0),
min_page_scale_factor_(-1),
max_page_scale_factor_(-1) {}
~TestInputHandlerClient() override = default;
// InputHandlerClient implementation.
void WillShutdown() override {}
void Animate(base::TimeTicks time) override {}
void ReconcileElasticOverscrollAndRootScroll() override {}
void SetPrefersReducedMotion(bool prefers_reduced_motion) override {}
void UpdateRootLayerStateForSynchronousInputHandler(
const gfx::PointF& total_scroll_offset,
const gfx::PointF& max_scroll_offset,
const gfx::SizeF& scrollable_size,
float page_scale_factor,
float min_page_scale_factor,
float max_page_scale_factor) override {
DCHECK(total_scroll_offset.x() <= max_scroll_offset.x());
DCHECK(total_scroll_offset.y() <= max_scroll_offset.y());
last_set_scroll_offset_ = total_scroll_offset;
max_scroll_offset_ = max_scroll_offset;
scrollable_size_ = scrollable_size;
page_scale_factor_ = page_scale_factor;
min_page_scale_factor_ = min_page_scale_factor;
max_page_scale_factor_ = max_page_scale_factor;
}
void DeliverInputForBeginFrame(const viz::BeginFrameArgs& args) override {}
void DeliverInputForHighLatencyMode() override {}
gfx::PointF last_set_scroll_offset() { return last_set_scroll_offset_; }
gfx::PointF max_scroll_offset() const { return max_scroll_offset_; }
gfx::SizeF scrollable_size() const { return scrollable_size_; }
float page_scale_factor() const { return page_scale_factor_; }
float min_page_scale_factor() const { return min_page_scale_factor_; }
float max_page_scale_factor() const { return max_page_scale_factor_; }
private:
gfx::PointF last_set_scroll_offset_;
gfx::PointF max_scroll_offset_;
gfx::SizeF scrollable_size_;
float page_scale_factor_;
float min_page_scale_factor_;
float max_page_scale_factor_;
};
INSTANTIATE_TEST_SUITE_P(All,
ScrollUnifiedLayerTreeHostImplTest,
testing::Bool());
TEST_P(ScrollUnifiedLayerTreeHostImplTest, LocalAndExternalPinchState) {
// PinchGestureBegin/End update pinch_gesture_active() properly.
EXPECT_FALSE(GetInputHandler().pinch_gesture_active());
GetInputHandler().PinchGestureBegin(gfx::Point(),
ui::ScrollInputType::kTouchscreen);
EXPECT_TRUE(GetInputHandler().pinch_gesture_active());
GetInputHandler().PinchGestureEnd(gfx::Point());
EXPECT_FALSE(GetInputHandler().pinch_gesture_active());
// set_external_pinch_gesture_active updates pinch_gesture_active() properly.
GetInputHandler().set_external_pinch_gesture_active(true);
EXPECT_TRUE(GetInputHandler().pinch_gesture_active());
GetInputHandler().set_external_pinch_gesture_active(false);
EXPECT_FALSE(GetInputHandler().pinch_gesture_active());
// Clearing external_pinch_gesture_active doesn't affect
// pinch_gesture_active() if it was set by PinchGestureBegin().
GetInputHandler().PinchGestureBegin(gfx::Point(),
ui::ScrollInputType::kTouchscreen);
EXPECT_TRUE(GetInputHandler().pinch_gesture_active());
GetInputHandler().set_external_pinch_gesture_active(false);
EXPECT_TRUE(GetInputHandler().pinch_gesture_active());
GetInputHandler().PinchGestureEnd(gfx::Point());
EXPECT_FALSE(GetInputHandler().pinch_gesture_active());
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, NotifyIfCanDrawChanged) {
// Note: It is not possible to disable the renderer once it has been set,
// so we do not need to test that disabling the renderer notifies us
// that can_draw changed.
EXPECT_FALSE(host_impl_->CanDraw());
on_can_draw_state_changed_called_ = false;
// Set up the root layer, which allows us to draw.
SetupViewportLayersInnerScrolls(gfx::Size(50, 50), gfx::Size(100, 100));
EXPECT_TRUE(host_impl_->CanDraw());
EXPECT_TRUE(on_can_draw_state_changed_called_);
on_can_draw_state_changed_called_ = false;
// Toggle the root layer to make sure it toggles can_draw
ClearLayersAndPropertyTrees(host_impl_->active_tree());
EXPECT_FALSE(host_impl_->CanDraw());
EXPECT_TRUE(on_can_draw_state_changed_called_);
on_can_draw_state_changed_called_ = false;
SetupViewportLayersInnerScrolls(gfx::Size(50, 50), gfx::Size(100, 100));
EXPECT_TRUE(host_impl_->CanDraw());
EXPECT_TRUE(on_can_draw_state_changed_called_);
on_can_draw_state_changed_called_ = false;
// Toggle the device viewport size to make sure it toggles can_draw.
host_impl_->active_tree()->SetDeviceViewportRect(gfx::Rect());
EXPECT_FALSE(host_impl_->CanDraw());
EXPECT_TRUE(on_can_draw_state_changed_called_);
on_can_draw_state_changed_called_ = false;
host_impl_->active_tree()->SetDeviceViewportRect(gfx::Rect(100, 100));
EXPECT_TRUE(host_impl_->CanDraw());
EXPECT_TRUE(on_can_draw_state_changed_called_);
on_can_draw_state_changed_called_ = false;
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ResourcelessDrawWithEmptyViewport) {
CreateHostImpl(DefaultSettings(), FakeLayerTreeFrameSink::CreateSoftware());
SetupViewportLayersInnerScrolls(gfx::Size(50, 50), gfx::Size(100, 100));
EXPECT_TRUE(host_impl_->CanDraw());
host_impl_->active_tree()->SetDeviceViewportRect(gfx::Rect());
EXPECT_FALSE(host_impl_->CanDraw());
auto* fake_layer_tree_frame_sink =
static_cast<FakeLayerTreeFrameSink*>(host_impl_->layer_tree_frame_sink());
EXPECT_EQ(fake_layer_tree_frame_sink->num_sent_frames(), 0u);
gfx::Transform identity;
gfx::Rect viewport(100, 100);
const bool resourceless_software_draw = true;
host_impl_->OnDraw(identity, viewport, resourceless_software_draw, false);
ASSERT_EQ(fake_layer_tree_frame_sink->num_sent_frames(), 1u);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollDeltaNoLayers) {
host_impl_->active_tree()->SetRootLayerForTesting(nullptr);
std::unique_ptr<CompositorCommitData> commit_data =
host_impl_->ProcessCompositorDeltas(
/* main_thread_mutator_host */ nullptr);
ASSERT_EQ(commit_data->scrolls.size(), 0u);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollDeltaTreeButNoChanges) {
LayerImpl* root = SetupDefaultRootLayer(gfx::Size(10, 10));
{
LayerImpl* child1 = AddLayer();
CopyProperties(root, child1);
LayerImpl* child2 = AddLayer();
CopyProperties(root, child2);
LayerImpl* grand_child1 = AddLayer();
CopyProperties(child2, grand_child1);
LayerImpl* grand_child2 = AddLayer();
CopyProperties(child2, grand_child2);
LayerImpl* great_grand_child = AddLayer();
CopyProperties(grand_child1, great_grand_child);
}
ExpectClearedScrollDeltasRecursive(root);
std::unique_ptr<CompositorCommitData> commit_data;
std::unique_ptr<AnimationHost> main_thread_animation_host(
AnimationHost::CreateForTesting(ThreadInstance::MAIN));
// Null mutator_host implies non-pipelined main frame
commit_data = host_impl_->ProcessCompositorDeltas(
/* main_thread_mutator_host */ nullptr);
ASSERT_EQ(commit_data->scrolls.size(), 0u);
ExpectClearedScrollDeltasRecursive(root);
// Non-null mutator_host implies pipelined main frame
commit_data =
host_impl_->ProcessCompositorDeltas(main_thread_animation_host.get());
ASSERT_EQ(commit_data->scrolls.size(), 0u);
ExpectClearedScrollDeltasRecursive(root);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollDeltaRepeatedScrolls) {
gfx::PointF scroll_offset(20, 30);
auto* root = SetupDefaultRootLayer(gfx::Size(110, 110));
root->SetHitTestable(true);
CreateScrollNode(root, gfx::Size(10, 10));
root->layer_tree_impl()
->property_trees()
->scroll_tree_mutable()
.UpdateScrollOffsetBaseForTesting(root->element_id(), scroll_offset);
UpdateDrawProperties(host_impl_->active_tree());
gfx::Vector2dF scroll_delta(11, -15);
std::unique_ptr<CompositorCommitData> commit_data1;
std::unique_ptr<AnimationHost> main_thread_animation_host(
AnimationHost::CreateForTesting(ThreadInstance::MAIN));
root->ScrollBy(scroll_delta);
// Null mutator_host implies non-pipelined main frame
commit_data1 = host_impl_->ProcessCompositorDeltas(
/* main_thread_mutator_host */ nullptr);
ASSERT_EQ(commit_data1->scrolls.size(), 1u);
EXPECT_TRUE(
ScrollInfoContains(*commit_data1, root->element_id(), scroll_delta));
std::unique_ptr<CompositorCommitData> commit_data2;
gfx::Vector2dF scroll_delta2(-5, 27);
root->ScrollBy(scroll_delta2);
// Non-null mutator_host implies pipelined main frame
commit_data2 =
host_impl_->ProcessCompositorDeltas(main_thread_animation_host.get());
ASSERT_EQ(commit_data2->scrolls.size(), 1u);
EXPECT_TRUE(
ScrollInfoContains(*commit_data2, root->element_id(), scroll_delta2));
// Simulate first commit by pushing base scroll offsets to pending tree
PushScrollOffsetsToPendingTree(
{{root->element_id(), gfx::PointAtOffsetFromOrigin(scroll_delta)}});
ClearNonScrollSyncTreeDeltasForTesting();
EXPECT_EQ(host_impl_->sync_tree()
->property_trees()
->scroll_tree()
.GetScrollOffsetDeltaForTesting(root->element_id()),
scroll_delta2);
// Simulate second commit by pushing base scroll offsets to pending tree
PushScrollOffsetsToPendingTree(
{{root->element_id(), gfx::PointAtOffsetFromOrigin(scroll_delta2)}});
EXPECT_EQ(host_impl_->sync_tree()
->property_trees()
->scroll_tree()
.GetScrollOffsetDeltaForTesting(root->element_id()),
gfx::Vector2dF(0, 0));
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, SyncedScrollAbortedCommit) {
LayerTreeSettings settings = DefaultSettings();
settings.commit_to_active_tree = false;
CreateHostImpl(settings, CreateLayerTreeFrameSink());
CreatePendingTree();
gfx::PointF scroll_offset(20, 30);
auto* root = SetupDefaultRootLayer(gfx::Size(110, 110));
auto& scroll_tree =
root->layer_tree_impl()->property_trees()->scroll_tree_mutable();
root->SetHitTestable(true);
std::unique_ptr<AnimationHost> main_thread_animation_host(
AnimationHost::CreateForTesting(ThreadInstance::MAIN));
// SyncedProperty should be created on the pending tree and then pushed to the
// active tree, to avoid bifurcation. Simulate commit by pushing base scroll
// offsets to pending tree.
PushScrollOffsetsToPendingTree({{root->element_id(), gfx::PointF(0, 0)}});
ClearNonScrollSyncTreeDeltasForTesting();
host_impl_->active_tree()
->property_trees()
->scroll_tree_mutable()
.PushScrollUpdatesFromPendingTree(
host_impl_->pending_tree()->property_trees(),
host_impl_->active_tree());
CreateScrollNode(root, gfx::Size(10, 10));
auto* synced_scroll = scroll_tree.GetSyncedScrollOffset(root->element_id());
ASSERT_TRUE(synced_scroll);
scroll_tree.UpdateScrollOffsetBaseForTesting(root->element_id(),
scroll_offset);
UpdateDrawProperties(host_impl_->active_tree());
gfx::Vector2dF scroll_delta(11, -15);
root->ScrollBy(scroll_delta);
EXPECT_EQ(scroll_delta, synced_scroll->UnsentDelta());
// Null mutator_host implies non-pipelined main frame
host_impl_->ProcessCompositorDeltas(/* mutator_host */ nullptr);
EXPECT_EQ(scroll_delta, synced_scroll->reflected_delta_in_main_tree());
EXPECT_EQ(gfx::Vector2dF(),
synced_scroll->next_reflected_delta_in_main_tree());
std::unique_ptr<CompositorCommitData> commit_data2;
gfx::Vector2dF scroll_delta2(-5, 27);
root->ScrollBy(scroll_delta2);
EXPECT_EQ(scroll_delta2, synced_scroll->UnsentDelta());
// Non-null mutator_host implies pipelined main frame
host_impl_->ProcessCompositorDeltas(main_thread_animation_host.get());
EXPECT_EQ(scroll_delta, synced_scroll->reflected_delta_in_main_tree());
EXPECT_EQ(scroll_delta2, synced_scroll->next_reflected_delta_in_main_tree());
// Simulate aborting the second main frame. Scroll deltas applied by the
// second frame should be combined with delta from first frame.
root->layer_tree_impl()->ApplySentScrollAndScaleDeltasFromAbortedCommit(
/* next_bmf */ true, /* main_frame_applied_deltas */ true);
EXPECT_EQ(scroll_delta + scroll_delta2,
synced_scroll->reflected_delta_in_main_tree());
EXPECT_EQ(gfx::Vector2dF(),
synced_scroll->next_reflected_delta_in_main_tree());
// Send a third main frame, pipelined behind the first.
gfx::Vector2dF scroll_delta3(-2, -13);
root->ScrollBy(scroll_delta3);
EXPECT_EQ(scroll_delta3, synced_scroll->UnsentDelta());
host_impl_->ProcessCompositorDeltas(main_thread_animation_host.get());
EXPECT_EQ(scroll_delta + scroll_delta2,
synced_scroll->reflected_delta_in_main_tree());
EXPECT_EQ(scroll_delta3, synced_scroll->next_reflected_delta_in_main_tree());
// Simulate commit of the first frame
PushScrollOffsetsToPendingTree(
{{root->element_id(), scroll_offset + scroll_delta + scroll_delta2}});
EXPECT_EQ(scroll_offset + scroll_delta + scroll_delta2,
synced_scroll->PendingBase());
EXPECT_EQ(scroll_delta3, synced_scroll->PendingDelta());
EXPECT_EQ(scroll_delta3, synced_scroll->reflected_delta_in_main_tree());
EXPECT_EQ(gfx::Vector2dF(),
synced_scroll->next_reflected_delta_in_main_tree());
}
TEST_F(CommitToPendingTreeLayerTreeHostImplTest,
GPUMemoryForSmallLayerHistogramTest) {
base::HistogramTester histogram_tester;
SetClientNameForMetrics("Renderer");
host_impl_->SetDownsampleMetricsForTesting(false);
// With default tile size being set to 256 * 256, the following layer needs
// one tile only which costs 256 * 256 * 4 / 1024 = 256KB memory.
TestGPUMemoryForTilings(gfx::Size(200, 200));
histogram_tester.ExpectBucketCount(
"Compositing.Renderer.GPUMemoryForTilingsInKb", 256, 1);
histogram_tester.ExpectTotalCount(
"Compositing.Renderer.GPUMemoryForTilingsInKb", 1);
}
TEST_F(CommitToPendingTreeLayerTreeHostImplTest,
GPUMemoryForLargeLayerHistogramTest) {
base::HistogramTester histogram_tester;
SetClientNameForMetrics("Renderer");
host_impl_->SetDownsampleMetricsForTesting(false);
// With default tile size being set to 256 * 256, the following layer needs
// 4 tiles which cost 256 * 256 * 4 * 4 / 1024 = 1024KB memory.
TestGPUMemoryForTilings(gfx::Size(500, 500));
histogram_tester.ExpectBucketCount(
"Compositing.Renderer.GPUMemoryForTilingsInKb", 1024, 1);
histogram_tester.ExpectTotalCount(
"Compositing.Renderer.GPUMemoryForTilingsInKb", 1);
}
// This test verifies that we drop a scroll (and don't crash) if a scroll is
// received before the root layer has been attached. https://crbug.com/895817.
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollBeforeRootLayerAttached) {
InputHandler::ScrollStatus status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(), gfx::Vector2dF(0, 1),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
EXPECT_EQ(ScrollThread::SCROLL_IGNORED, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kNoScrollingLayer,
status.main_thread_scrolling_reasons);
status = GetInputHandler().RootScrollBegin(
BeginState(gfx::Point(), gfx::Vector2dF(0, 1),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
EXPECT_EQ(ScrollThread::SCROLL_IGNORED, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kNoScrollingLayer,
status.main_thread_scrolling_reasons);
}
// Tests that receiving ScrollUpdate and ScrollEnd calls that don't have a
// matching ScrollBegin are just dropped and are a no-op. This can happen due
// to pre-commit input deferral which causes some input events to be dropped
// before the first commit in a renderer has occurred. See the flag
// kAllowPreCommitInput and how it's used.
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollUpdateAndEndNoOpWithoutBegin) {
SetupViewportLayersOuterScrolls(gfx::Size(100, 100), gfx::Size(1000, 1000));
// Simulate receiving a gesture mid-stream so that the Begin wasn't ever
// processed. This shouldn't cause any state change but we should crash or
// DCHECK.
{
EXPECT_FALSE(host_impl_->CurrentlyScrollingNode());
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), gfx::Vector2d(0, 10),
ui::ScrollInputType::kTouchscreen)
.get());
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), gfx::Vector2d(0, 10),
ui::ScrollInputType::kTouchscreen)
.get());
EXPECT_FALSE(host_impl_->CurrentlyScrollingNode());
GetInputHandler().ScrollEnd();
}
// Ensure a new gesture is now able to correctly scroll.
{
InputHandler::ScrollStatus status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(), gfx::Vector2dF(0, 10),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
EXPECT_TRUE(host_impl_->CurrentlyScrollingNode());
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), gfx::Vector2d(0, 10),
ui::ScrollInputType::kTouchscreen)
.get());
EXPECT_POINTF_EQ(gfx::PointF(0, 10),
CurrentScrollOffset(OuterViewportScrollLayer()));
GetInputHandler().ScrollEnd();
}
}
// Test that specifying a scroller to ScrollBegin (i.e. avoid hit testing)
// returns the correct status if the scroller cannot be scrolled on the
// compositor thread.
TEST_P(ScrollUnifiedLayerTreeHostImplTest, TargetMainThreadScroller) {
SetupViewportLayersOuterScrolls(gfx::Size(100, 100), gfx::Size(1000, 1000));
ScrollStateData scroll_state_data;
scroll_state_data.set_current_native_scrolling_element(
host_impl_->OuterViewportScrollNode()->element_id);
std::unique_ptr<ScrollState> scroll_state(new ScrollState(scroll_state_data));
// Try on a node that should scroll on the compositor. Confirm it works.
{
InputHandler::ScrollStatus status = GetInputHandler().ScrollBegin(
scroll_state.get(), ui::ScrollInputType::kWheel);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
EXPECT_EQ(host_impl_->OuterViewportScrollNode(),
host_impl_->CurrentlyScrollingNode());
GetInputHandler().ScrollEnd();
}
// Now add a MainThreadScrollingReason. Trying to target the node this time
// should result in a failed ScrollBegin with the appropriate return value,
// unless scroll unification is enabled - since all nodes can be scrolled
// from the compositor in that mode.
host_impl_->OuterViewportScrollNode()->main_thread_scrolling_reasons =
MainThreadScrollingReason::kThreadedScrollingDisabled;
{
InputHandler::ScrollStatus status = GetInputHandler().ScrollBegin(
scroll_state.get(), ui::ScrollInputType::kWheel);
if (base::FeatureList::IsEnabled(features::kScrollUnification)) {
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
EXPECT_FALSE(status.needs_main_thread_hit_test);
EXPECT_EQ(
MainThreadScrollingReason::kThreadedScrollingDisabled,
host_impl_->CurrentlyScrollingNode()->main_thread_scrolling_reasons);
} else {
EXPECT_EQ(ScrollThread::SCROLL_ON_MAIN_THREAD, status.thread);
EXPECT_EQ(
host_impl_->OuterViewportScrollNode()->main_thread_scrolling_reasons,
status.main_thread_scrolling_reasons);
EXPECT_FALSE(host_impl_->CurrentlyScrollingNode());
}
}
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollRootCallsCommitAndRedraw) {
SetupViewportLayersInnerScrolls(gfx::Size(50, 50), gfx::Size(100, 100));
DrawFrame();
InputHandler::ScrollStatus status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(), gfx::Vector2dF(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kNotScrollingOnMain,
status.main_thread_scrolling_reasons);
EXPECT_TRUE(host_impl_->CurrentlyScrollingNode());
GetInputHandler().ScrollUpdate(UpdateState(gfx::Point(), gfx::Vector2d(0, 10),
ui::ScrollInputType::kTouchscreen)
.get());
GetInputHandler().ScrollEnd();
EXPECT_FALSE(host_impl_->CurrentlyScrollingNode());
EXPECT_TRUE(did_request_redraw_);
EXPECT_TRUE(did_request_commit_);
}
// Ensure correct semantics for the GetActivelyScrollingType method. This
// method is used to determine scheduler policy so it wants to report true only
// when real scrolling is occurring (i.e. the compositor is consuming scroll
// delta, the page isn't handling the events itself).
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
ActivelyScrollingOnlyAfterScrollMovement) {
SetupViewportLayersOuterScrolls(gfx::Size(50, 50), gfx::Size(100, 100));
DrawFrame();
// Ensure a touch scroll reports true but only after some delta has been
// consumed.
{
InputHandler::ScrollStatus status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(), gfx::Vector2dF(0, 10),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kNotScrollingOnMain,
status.main_thread_scrolling_reasons);
EXPECT_EQ(host_impl_->GetActivelyScrollingType(),
ActivelyScrollingType::kNone);
// There is no extent upwards so the scroll won't consume any delta.
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), gfx::Vector2d(0, -10),
ui::ScrollInputType::kTouchscreen)
.get());
EXPECT_EQ(host_impl_->GetActivelyScrollingType(),
ActivelyScrollingType::kNone);
// This should scroll so ensure the bit flips to true.
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), gfx::Vector2d(0, 10),
ui::ScrollInputType::kTouchscreen)
.get());
EXPECT_EQ(host_impl_->GetActivelyScrollingType(),
ActivelyScrollingType::kPrecise);
GetInputHandler().ScrollEnd();
EXPECT_EQ(host_impl_->GetActivelyScrollingType(),
ActivelyScrollingType::kNone);
}
ASSERT_EQ(10, CurrentScrollOffset(OuterViewportScrollLayer()).y());
// Ensure an animated wheel scroll only causes the bit to flip when enabling
// smoothness mode (i.e. the value of GetParam().animate);
{
InputHandler::ScrollStatus status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(), gfx::Vector2dF(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
EXPECT_EQ(host_impl_->GetActivelyScrollingType(),
ActivelyScrollingType::kNone);
GetInputHandler().ScrollUpdate(
AnimatedUpdateState(gfx::Point(), gfx::Vector2dF(0, 10)).get());
EXPECT_EQ(host_impl_->GetActivelyScrollingType(),
ActivelyScrollingType::kAnimated);
base::TimeTicks cur_time = base::TimeTicks() + base::Milliseconds(100);
viz::BeginFrameArgs begin_frame_args =
viz::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, 0, 1);
#define ANIMATE(time_ms) \
cur_time += base::Milliseconds(time_ms); \
begin_frame_args.frame_time = (cur_time); \
begin_frame_args.frame_id.sequence_number++; \
host_impl_->WillBeginImplFrame(begin_frame_args); \
host_impl_->Animate(); \
host_impl_->UpdateAnimationState(true); \
host_impl_->DidFinishImplFrame(begin_frame_args);
// The animation is setup in the first frame so tick at least twice to
// actually animate it.
ANIMATE(0);
EXPECT_EQ(host_impl_->GetActivelyScrollingType(),
ActivelyScrollingType::kAnimated);
ANIMATE(200);
EXPECT_EQ(host_impl_->GetActivelyScrollingType(),
ActivelyScrollingType::kAnimated);
ANIMATE(1000);
EXPECT_EQ(host_impl_->GetActivelyScrollingType(),
ActivelyScrollingType::kAnimated);
#undef ANIMATE
ASSERT_EQ(20, CurrentScrollOffset(OuterViewportScrollLayer()).y());
GetInputHandler().ScrollEnd();
EXPECT_EQ(host_impl_->GetActivelyScrollingType(),
ActivelyScrollingType::kNone);
}
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollWithoutRootLayer) {
// We should not crash when trying to scroll an empty layer tree.
InputHandler::ScrollStatus status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(), gfx::Vector2dF(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
EXPECT_EQ(ScrollThread::SCROLL_IGNORED, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kNoScrollingLayer,
status.main_thread_scrolling_reasons);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollWithoutRenderer) {
auto gl_owned = std::make_unique<viz::TestGLES2Interface>();
gl_owned->LoseContextCHROMIUM(GL_GUILTY_CONTEXT_RESET_ARB,
GL_INNOCENT_CONTEXT_RESET_ARB);
// Initialization will fail.
EXPECT_FALSE(
CreateHostImpl(DefaultSettings(),
FakeLayerTreeFrameSink::Create3d(std::move(gl_owned))));
SetupViewportLayersInnerScrolls(gfx::Size(50, 50), gfx::Size(100, 100));
// We should not crash when trying to scroll after the renderer initialization
// fails.
InputHandler::ScrollStatus status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(), gfx::Vector2dF(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kNotScrollingOnMain,
status.main_thread_scrolling_reasons);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ReplaceTreeWhileScrolling) {
SetupViewportLayersInnerScrolls(gfx::Size(50, 50), gfx::Size(100, 100));
DrawFrame();
// We should not crash if the tree is replaced while we are scrolling.
gfx::Vector2dF scroll_delta(0, 10);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), scroll_delta,
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
ClearLayersAndPropertyTrees(host_impl_->active_tree());
SetupViewportLayersInnerScrolls(gfx::Size(50, 50), gfx::Size(100, 100));
auto* scroll_layer = InnerViewportScrollLayer();
// We should still be scrolling, because the scrolled layer also exists in the
// new tree.
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), scroll_delta, ui::ScrollInputType::kWheel)
.get());
GetInputHandler().ScrollEnd();
std::unique_ptr<CompositorCommitData> commit_data =
host_impl_->ProcessCompositorDeltas(
/* main_thread_mutator_host */ nullptr);
EXPECT_TRUE(ScrollInfoContains(*commit_data, scroll_layer->element_id(),
scroll_delta));
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
ActivateTreeScrollingNodeDisappeared) {
SetupViewportLayersOuterScrolls(gfx::Size(100, 100), gfx::Size(1000, 1000));
auto status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(30, 30), gfx::Vector2d(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kNotScrollingOnMain,
status.main_thread_scrolling_reasons);
GetInputHandler().ScrollUpdate(UpdateState(gfx::Point(), gfx::Vector2d(0, 10),
ui::ScrollInputType::kWheel)
.get());
EXPECT_TRUE(host_impl_->active_tree()->CurrentlyScrollingNode());
// Create the pending tree containing only the root layer.
CreatePendingTree();
PropertyTrees pending_property_trees(*host_impl_);
pending_property_trees.set_sequence_number(
host_impl_->active_tree()->property_trees()->sequence_number() + 1);
host_impl_->pending_tree()->SetPropertyTrees(pending_property_trees);
SetupRootLayer<LayerImpl>(host_impl_->pending_tree(), gfx::Size(100, 100));
host_impl_->ActivateSyncTree();
// The scroll should stop.
EXPECT_FALSE(host_impl_->active_tree()->CurrentlyScrollingNode());
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollBlocksOnWheelEventHandlers) {
SetupViewportLayersInnerScrolls(gfx::Size(50, 50), gfx::Size(100, 100));
auto* scroll = InnerViewportScrollLayer();
scroll->SetWheelEventHandlerRegion(Region(gfx::Rect(20, 20)));
DrawFrame();
// Wheel handlers determine whether mouse events block scroll.
host_impl_->active_tree()->set_event_listener_properties(
EventListenerClass::kMouseWheel, EventListenerProperties::kBlocking);
EXPECT_EQ(EventListenerProperties::kBlocking,
GetInputHandler().GetEventListenerProperties(
EventListenerClass::kMouseWheel));
// LTHI should know the wheel event handler region and only block mouse events
// in that region.
EXPECT_TRUE(
GetInputHandler().HasBlockingWheelEventHandlerAt(gfx::Point(10, 10)));
EXPECT_FALSE(
GetInputHandler().HasBlockingWheelEventHandlerAt(gfx::Point(30, 30)));
// But they don't influence the actual handling of the scroll gestures.
InputHandler::ScrollStatus status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(), gfx::Vector2d(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kNotScrollingOnMain,
status.main_thread_scrolling_reasons);
GetInputHandler().ScrollEnd();
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollBlocksOnTouchEventHandlers) {
SetupViewportLayersInnerScrolls(gfx::Size(50, 50), gfx::Size(100, 100));
DrawFrame();
LayerImpl* root = root_layer();
LayerImpl* scroll = InnerViewportScrollLayer();
LayerImpl* child = AddLayer();
child->SetDrawsContent(true);
child->SetBounds(gfx::Size(50, 50));
CopyProperties(scroll, child);
child->SetOffsetToTransformParent(gfx::Vector2dF(0, 20));
// Touch handler regions determine whether touch events block scroll.
TouchAction touch_action;
TouchActionRegion touch_action_region;
touch_action_region.Union(TouchAction::kPanLeft, gfx::Rect(0, 0, 100, 100));
touch_action_region.Union(TouchAction::kPanRight,
gfx::Rect(25, 25, 100, 100));
root->SetTouchActionRegion(std::move(touch_action_region));
EXPECT_EQ(InputHandler::TouchStartOrMoveEventListenerType::HANDLER,
GetInputHandler().EventListenerTypeForTouchStartOrMoveAt(
gfx::Point(10, 10), &touch_action));
EXPECT_EQ(TouchAction::kPanLeft, touch_action);
// But they don't influence the actual handling of the scroll gestures.
InputHandler::ScrollStatus status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(), gfx::Vector2d(0, 10),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kNotScrollingOnMain,
status.main_thread_scrolling_reasons);
GetInputHandler().ScrollEnd();
EXPECT_EQ(InputHandler::TouchStartOrMoveEventListenerType::HANDLER,
GetInputHandler().EventListenerTypeForTouchStartOrMoveAt(
gfx::Point(10, 30), &touch_action));
root->SetTouchActionRegion(TouchActionRegion());
EXPECT_EQ(InputHandler::TouchStartOrMoveEventListenerType::NO_HANDLER,
GetInputHandler().EventListenerTypeForTouchStartOrMoveAt(
gfx::Point(10, 30), &touch_action));
EXPECT_EQ(TouchAction::kAuto, touch_action);
touch_action_region = TouchActionRegion();
touch_action_region.Union(TouchAction::kPanX, gfx::Rect(0, 0, 50, 50));
child->SetTouchActionRegion(std::move(touch_action_region));
EXPECT_EQ(InputHandler::TouchStartOrMoveEventListenerType::HANDLER,
GetInputHandler().EventListenerTypeForTouchStartOrMoveAt(
gfx::Point(10, 30), &touch_action));
EXPECT_EQ(TouchAction::kPanX, touch_action);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ShouldScrollOnMainThread) {
SetupViewportLayersOuterScrolls(gfx::Size(50, 50), gfx::Size(100, 100));
host_impl_->OuterViewportScrollNode()->main_thread_scrolling_reasons =
MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects;
DrawFrame();
InputHandler::ScrollStatus status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(), gfx::Vector2d(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
if (base::FeatureList::IsEnabled(features::kScrollUnification)) {
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
EXPECT_FALSE(status.needs_main_thread_hit_test);
EXPECT_EQ(
MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects,
host_impl_->CurrentlyScrollingNode()->main_thread_scrolling_reasons);
} else {
EXPECT_EQ(ScrollThread::SCROLL_ON_MAIN_THREAD, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects,
status.main_thread_scrolling_reasons);
}
status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(), gfx::Vector2d(0, 10),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
if (base::FeatureList::IsEnabled(features::kScrollUnification)) {
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
EXPECT_FALSE(status.needs_main_thread_hit_test);
EXPECT_EQ(
MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects,
host_impl_->CurrentlyScrollingNode()->main_thread_scrolling_reasons);
} else {
EXPECT_EQ(ScrollThread::SCROLL_ON_MAIN_THREAD, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects,
status.main_thread_scrolling_reasons);
}
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
ScrollWithOverlappingNonScrollableLayer) {
CreateAndTestNonScrollableLayers(false);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
ScrollWithOverlappingTransparentNonScrollableLayer) {
CreateAndTestNonScrollableLayers(true);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
ScrolledOverlappingDrawnScrollbarLayer) {
LayerTreeImpl* layer_tree_impl = host_impl_->active_tree();
gfx::Size content_size = gfx::Size(360, 600);
gfx::Size scroll_content_size = gfx::Size(345, 3800);
gfx::Size scrollbar_size = gfx::Size(15, 600);
SetupViewportLayersNoScrolls(content_size);
LayerImpl* scroll = AddScrollableLayer(OuterViewportScrollLayer(),
content_size, scroll_content_size);
auto* drawn_scrollbar = AddLayer<PaintedScrollbarLayerImpl>(
layer_tree_impl, ScrollbarOrientation::VERTICAL, false, true);
SetupScrollbarLayer(scroll, drawn_scrollbar);
drawn_scrollbar->SetBounds(scrollbar_size);
drawn_scrollbar->SetOffsetToTransformParent(gfx::Vector2dF(345, 0));
LayerImpl* squash = AddLayer();
squash->SetBounds(gfx::Size(140, 300));
squash->SetDrawsContent(true);
squash->SetHitTestable(true);
CopyProperties(scroll, squash);
squash->SetOffsetToTransformParent(gfx::Vector2dF(220, 0));
UpdateDrawProperties(layer_tree_impl);
layer_tree_impl->DidBecomeActive();
// The point hits squash layer and also scrollbar layer, but because the
// scrollbar layer is a drawn scrollbar, we cannot scroll on the impl thread.
auto status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(350, 150), gfx::Vector2d(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
if (base::FeatureList::IsEnabled(features::kScrollUnification)) {
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kNotScrollingOnMain,
status.main_thread_scrolling_reasons);
EXPECT_TRUE(status.needs_main_thread_hit_test);
} else {
EXPECT_EQ(ScrollThread::SCROLL_ON_MAIN_THREAD, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kFailedHitTest,
status.main_thread_scrolling_reasons);
}
// The point hits the drawn scrollbar layer completely and should scroll on
// the impl thread.
status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(350, 500), gfx::Vector2d(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kNotScrollingOnMain,
status.main_thread_scrolling_reasons);
}
gfx::PresentationFeedback ExampleFeedback() {
auto feedback = gfx::PresentationFeedback(
base::TimeTicks() + base::Milliseconds(42), base::Microseconds(18),
gfx::PresentationFeedback::Flags::kVSync |
gfx::PresentationFeedback::Flags::kHWCompletion);
#if BUILDFLAG(IS_MAC)
feedback.ca_layer_error_code = gfx::kCALayerFailedQuadBlendMode;
#endif
return feedback;
}
class LayerTreeHostImplTestInvokePresentationCallbacks
: public LayerTreeHostImplTest {
public:
void DidPresentCompositorFrameOnImplThread(
uint32_t frame_token,
PresentationTimeCallbackBuffer::PendingCallbacks activated,
const viz::FrameTimingDetails& details) override {
host_impl_->NotifyDidPresentCompositorFrameOnImplThread(
frame_token, std::move(activated.compositor_successful_callbacks),
details);
for (auto& callback : activated.main_callbacks)
std::move(callback).Run(details.presentation_feedback);
for (auto& callback : activated.main_successful_callbacks)
std::move(callback).Run(details.presentation_feedback.timestamp);
}
};
// Tests that, when the LayerTreeHostImpl receives presentation feedback, the
// feedback gets routed to a properly registered callback.
TEST_F(LayerTreeHostImplTestInvokePresentationCallbacks,
PresentationFeedbackCallbacksFire) {
bool compositor_successful_callback_fired = false;
bool main_callback_fired = false;
bool main_successful_callback_fired = false;
base::TimeTicks compositor_successful_callback_presentation_timestamp;
gfx::PresentationFeedback main_callback_presentation_feedback;
base::TimeTicks main_successful_callback_presentation_timestamp;
constexpr uint32_t frame_token_1 = 1;
constexpr uint32_t frame_token_2 = 2;
constexpr uint32_t frame_token_3 = 3;
// Register a compositor-thread successful presentation callback to run when
// the frame for `frame_token_1` gets presented.
host_impl_
->RegisterCompositorThreadSuccessfulPresentationTimeCallbackForTesting(
frame_token_1,
base::BindLambdaForTesting(
[&](base::TimeTicks presentation_timestamp) {
DCHECK(compositor_successful_callback_presentation_timestamp
.is_null());
DCHECK(!presentation_timestamp.is_null());
compositor_successful_callback_fired = true;
compositor_successful_callback_presentation_timestamp =
presentation_timestamp;
}));
// Register a main-thread presentation callback to run when the presentation
// feedback for `frame_token_2` is received.
host_impl_->RegisterMainThreadPresentationTimeCallbackForTesting(
frame_token_2, base::BindLambdaForTesting(
[&](const gfx::PresentationFeedback& feedback) {
main_callback_fired = true;
main_callback_presentation_feedback = feedback;
}));
// Register a main-thread successful presentation callback to run when the
// frame for `frame_token_2` gets presented.
host_impl_->RegisterMainThreadSuccessfulPresentationTimeCallbackForTesting(
frame_token_2,
base::BindLambdaForTesting([&](base::TimeTicks presentation_timestamp) {
DCHECK(main_successful_callback_presentation_timestamp.is_null());
DCHECK(!presentation_timestamp.is_null());
main_successful_callback_fired = true;
main_successful_callback_presentation_timestamp =
presentation_timestamp;
}));
// Present frame for `frame_token_1` successfully.
viz::FrameTimingDetails mock_details;
mock_details.presentation_feedback = ExampleFeedback();
host_impl_->DidPresentCompositorFrame(frame_token_1, mock_details);
// Only callbacks registered for `frame_token_1` should be called.
EXPECT_TRUE(compositor_successful_callback_fired);
EXPECT_FALSE(main_callback_fired);
EXPECT_FALSE(main_successful_callback_fired);
EXPECT_EQ(compositor_successful_callback_presentation_timestamp,
mock_details.presentation_feedback.timestamp);
EXPECT_EQ(main_callback_presentation_feedback, gfx::PresentationFeedback());
EXPECT_TRUE(main_successful_callback_presentation_timestamp.is_null());
// Fail presentation of frame for `frame_token_2`.
mock_details.presentation_feedback = gfx::PresentationFeedback::Failure();
host_impl_->DidPresentCompositorFrame(frame_token_2, mock_details);
// Only callbacks that are allowed to run on failed presentations should be
// called.
EXPECT_TRUE(main_callback_fired);
EXPECT_FALSE(main_successful_callback_fired);
EXPECT_EQ(main_callback_presentation_feedback,
mock_details.presentation_feedback);
EXPECT_TRUE(main_successful_callback_presentation_timestamp.is_null());
// Present frame for `frame_token_2` successfully.
mock_details.presentation_feedback = ExampleFeedback();
host_impl_->DidPresentCompositorFrame(frame_token_3, mock_details);
// Now the callbacks for successful presentation should be called, too.
EXPECT_TRUE(main_successful_callback_fired);
EXPECT_EQ(main_successful_callback_presentation_timestamp,
mock_details.presentation_feedback.timestamp);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, NonFastScrollableRegionBasic) {
SetupViewportLayersInnerScrolls(gfx::Size(100, 100), gfx::Size(200, 200));
LayerImpl* outer_scroll = OuterViewportScrollLayer();
outer_scroll->SetNonFastScrollableRegion(gfx::Rect(0, 0, 50, 50));
DrawFrame();
// All scroll types inside the non-fast scrollable region should fail. When
// scroll unification is enabled, these scrolls succeed but request a main
// thread hit test.
InputHandler::ScrollStatus status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(25, 25), gfx::Vector2d(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
if (base::FeatureList::IsEnabled(features::kScrollUnification)) {
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kNotScrollingOnMain,
status.main_thread_scrolling_reasons);
EXPECT_TRUE(status.needs_main_thread_hit_test);
} else {
EXPECT_EQ(ScrollThread::SCROLL_ON_MAIN_THREAD, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kNonFastScrollableRegion,
status.main_thread_scrolling_reasons);
}
status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(25, 25), gfx::Vector2d(0, 10),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
if (base::FeatureList::IsEnabled(features::kScrollUnification)) {
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kNotScrollingOnMain,
status.main_thread_scrolling_reasons);
EXPECT_TRUE(status.needs_main_thread_hit_test);
} else {
EXPECT_EQ(ScrollThread::SCROLL_ON_MAIN_THREAD, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kNonFastScrollableRegion,
status.main_thread_scrolling_reasons);
}
// All scroll types outside this region should succeed.
status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(75, 75), gfx::Vector2d(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kNotScrollingOnMain,
status.main_thread_scrolling_reasons);
GetInputHandler().ScrollUpdate(UpdateState(gfx::Point(), gfx::Vector2d(0, 10),
ui::ScrollInputType::kWheel)
.get());
GetInputHandler().ScrollEnd();
status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(75, 75), gfx::Vector2d(0, 10),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kNotScrollingOnMain,
status.main_thread_scrolling_reasons);
GetInputHandler().ScrollUpdate(UpdateState(gfx::Point(), gfx::Vector2d(0, 10),
ui::ScrollInputType::kTouchscreen)
.get());
GetInputHandler().ScrollEnd();
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
NonFastScrollRegionInNonScrollingRoot) {
LayerImpl* root_layer = SetupDefaultRootLayer(gfx::Size(50, 50));
auto AddNewLayer = [&]() {
LayerImpl* layer = AddLayer();
layer->SetBounds(gfx::Size(50, 50));
layer->SetHitTestable(true);
CopyProperties(root_layer, layer);
return layer;
};
LayerImpl* layers[3] = {AddNewLayer(), AddNewLayer(), AddNewLayer()};
DrawFrame();
auto& input_handler = GetInputHandler();
std::unique_ptr<ScrollState> begin_state = BeginState(
gfx::Point(20, 20), gfx::Vector2dF(0, 10), ui::ScrollInputType::kWheel);
InputHandler::ScrollStatus status;
for (LayerImpl* layer : layers) {
layer->SetNonFastScrollableRegion(gfx::Rect(10, 10, 20, 20));
status = input_handler.ScrollBegin(begin_state.get(),
ui::ScrollInputType::kWheel);
input_handler.ScrollEnd();
layer->SetNonFastScrollableRegion(Region());
if (base::FeatureList::IsEnabled(features::kScrollUnification)) {
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kNotScrollingOnMain,
status.main_thread_scrolling_reasons);
EXPECT_TRUE(status.needs_main_thread_hit_test);
} else {
EXPECT_EQ(ScrollThread::SCROLL_ON_MAIN_THREAD, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kNonFastScrollableRegion,
status.main_thread_scrolling_reasons);
}
}
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, NonFastScrollableRegionWithOffset) {
SetupViewportLayersInnerScrolls(gfx::Size(100, 100), gfx::Size(200, 200));
LayerImpl* outer_scroll = OuterViewportScrollLayer();
outer_scroll->SetNonFastScrollableRegion(gfx::Rect(0, 0, 50, 50));
SetPostTranslation(outer_scroll, gfx::Vector2dF(-25, 0));
outer_scroll->SetDrawsContent(true);
DrawFrame();
// This point would fall into the non-fast scrollable region except that we've
// moved the layer left by 25 pixels.
InputHandler::ScrollStatus status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(40, 10), gfx::Vector2d(0, 1),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kNotScrollingOnMain,
status.main_thread_scrolling_reasons);
EXPECT_FALSE(status.needs_main_thread_hit_test);
GetInputHandler().ScrollUpdate(UpdateState(gfx::Point(), gfx::Vector2d(0, 1),
ui::ScrollInputType::kWheel)
.get());
GetInputHandler().ScrollEnd();
// This point is still inside the non-fast region.
status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(10, 10), gfx::Vector2d(0, 1),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
if (base::FeatureList::IsEnabled(features::kScrollUnification)) {
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kNotScrollingOnMain,
status.main_thread_scrolling_reasons);
EXPECT_TRUE(status.needs_main_thread_hit_test);
} else {
EXPECT_EQ(ScrollThread::SCROLL_ON_MAIN_THREAD, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kNonFastScrollableRegion,
status.main_thread_scrolling_reasons);
}
}
// Tests the following tricky case:
// - Scrolling Layer A with scrolling children:
// - Ordinary Layer B with NonFastScrollableRegion
// - Ordinary Layer C
//
// +---------+
// +---------| |+
// | Layer A | ||
// | +-----+-----+ ||
// | | Layer C | ||
// | +-----+-----+ ||
// | | Layer B ||
// +---------| |+
// +---------+
//
//
// Both B and C scroll with A but overlap each other and C appears above B. If
// we try scrolling over C, we need to check if we intersect the NFSR on B
// because C may not be fully opaque to hit testing (e.g. the layer may be for
// |pointer-events:none| or be a squashing layer with "holes").
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
LayerOverlapsNonFastScrollableRegionInLayer) {
SetupViewportLayersOuterScrolls(gfx::Size(100, 100), gfx::Size(200, 200));
// The viewport will be layer A in the description above.
LayerImpl* outer_scroll = OuterViewportScrollLayer();
// Layer B is a 50x50 layer filled with a non fast scrollable region. It
// occupies the right half of the viewport.
auto* layer_b = AddLayer<LayerImpl>(host_impl_->active_tree());
layer_b->SetBounds(gfx::Size(50, 100));
layer_b->SetDrawsContent(true);
layer_b->SetHitTestable(true);
CopyProperties(outer_scroll, layer_b);
layer_b->SetOffsetToTransformParent(gfx::Vector2dF(50, 0));
layer_b->SetNonFastScrollableRegion(gfx::Rect(0, 0, 50, 100));
// Do a sanity check - scrolling over layer b should cause main thread
// scrolling/hit testing because of the non fast scrolling region.
{
ASSERT_EQ(layer_b, host_impl_->active_tree()->FindLayerThatIsHitByPoint(
gfx::PointF(60, 50)));
InputHandler::ScrollStatus status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(60, 50), gfx::Vector2d(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
if (base::FeatureList::IsEnabled(features::kScrollUnification)) {
ASSERT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
ASSERT_EQ(MainThreadScrollingReason::kNotScrollingOnMain,
status.main_thread_scrolling_reasons);
ASSERT_TRUE(status.needs_main_thread_hit_test);
} else {
ASSERT_EQ(ScrollThread::SCROLL_ON_MAIN_THREAD, status.thread);
ASSERT_EQ(MainThreadScrollingReason::kNonFastScrollableRegion,
status.main_thread_scrolling_reasons);
}
GetInputHandler().ScrollEnd();
}
// Layer C is a 50x50 layer initially centered in the viewport. The right
// half overlaps Layer B.
auto* layer_c = AddLayer<LayerImpl>(host_impl_->active_tree());
layer_c->SetBounds(gfx::Size(50, 50));
layer_c->SetDrawsContent(true);
layer_c->SetHitTestable(true);
CopyProperties(outer_scroll, layer_c);
layer_c->SetOffsetToTransformParent(gfx::Vector2dF(25, 25));
// Do a sanity check - scrolling over layer c where it doesn't overlap B
// should cause scrolling on the viewport. It doesn't matter whether the
// point hits a "hit-test transparent" part of layer C because will cause
// scrolling in Layer A in either case since C scrolls with A.
{
ASSERT_EQ(layer_c, host_impl_->active_tree()->FindLayerThatIsHitByPoint(
gfx::PointF(40, 50)));
InputHandler::ScrollStatus status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(40, 50), gfx::Vector2d(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
ASSERT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
ASSERT_EQ(MainThreadScrollingReason::kNotScrollingOnMain,
status.main_thread_scrolling_reasons);
ASSERT_EQ(host_impl_->CurrentlyScrollingNode(),
host_impl_->OuterViewportScrollNode());
GetInputHandler().ScrollEnd();
}
// Now perform the real test - scrolling in the overlapping region should
// fallback to the main thread. In this case, we really do need to know
// whether the point hits a "hit-test transparent" part of Layer C because if
// it does it'll hit the NonFastScrollingRegion but if it doesn't it targets
// Layer C which scrolls the viewport.
{
ASSERT_EQ(layer_c, host_impl_->active_tree()->FindLayerThatIsHitByPoint(
gfx::PointF(60, 50)));
InputHandler::ScrollStatus status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(60, 50), gfx::Vector2d(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
if (base::FeatureList::IsEnabled(features::kScrollUnification)) {
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kNotScrollingOnMain,
status.main_thread_scrolling_reasons);
EXPECT_TRUE(status.needs_main_thread_hit_test);
} else {
EXPECT_EQ(ScrollThread::SCROLL_ON_MAIN_THREAD, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kNonFastScrollableRegion,
status.main_thread_scrolling_reasons);
}
GetInputHandler().ScrollEnd();
}
}
// Similar to the above test but this time layer B does not scroll with layer
// A. This is an edge case where the CSS painting algorithm allows a sibling of
// an overflow scroller to appear on top of the scroller itself but below some
// of the scroller's children. e.g. https://output.jsbin.com/tejulip/quiet.
//
// <div id="scroller" style="position:relative">
// <div id="child" style="position:relative; z-index:2"></div>
// </div>
// <div id="sibling" style="position:absolute; z-index: 1"></div>
//
// So we setup:
//
// - Scrolling Layer A with scrolling child:
// - Ordinary Layer C
// - Ordinary layer B with a NonFastScrollableRegion
//
// +---------+
// +---------| |+
// | Layer A | ||
// | +-----+-----+ ||
// | | Layer C | ||
// | +-----+-----+ ||
// | | Layer B ||
// +---------| |+
// +---------+
//
//
// Only C scrolls with A but C appears above B. If we try scrolling over C, we
// need to check if we intersect the NFSR on B because C may not be fully
// opaque to hit testing (e.g. the layer may be for |pointer-events:none| or be
// a squashing layer with "holes").
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
LayerOverlapsNonFastScrollableRegionInNonScrollAncestorLayer) {
// TODO(bokan): This fails without scroll unification.
// https://crbug.com/1098425.
if (!GetParam())
return;
SetupViewportLayersOuterScrolls(gfx::Size(100, 100), gfx::Size(200, 200));
LayerImpl* outer_scroll = OuterViewportScrollLayer();
LayerImpl* layer_a = AddScrollableLayer(outer_scroll, gfx::Size(100, 100),
gfx::Size(200, 200));
auto* layer_b = AddLayer<LayerImpl>(host_impl_->active_tree());
layer_b->SetBounds(gfx::Size(50, 100));
layer_b->SetDrawsContent(true);
layer_b->SetHitTestable(true);
CopyProperties(outer_scroll, layer_b);
layer_b->SetOffsetToTransformParent(gfx::Vector2dF(50, 0));
// Do a sanity check - scrolling over layer b should fallback to the main
// thread because the first hit scrolling layer is layer a which is not a
// scroll ancestor of b.
{
ASSERT_EQ(layer_b, host_impl_->active_tree()->FindLayerThatIsHitByPoint(
gfx::PointF(75, 50)));
InputHandler::ScrollStatus status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(75, 50), gfx::Vector2d(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
if (base::FeatureList::IsEnabled(features::kScrollUnification)) {
ASSERT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
ASSERT_EQ(MainThreadScrollingReason::kNotScrollingOnMain,
status.main_thread_scrolling_reasons);
ASSERT_TRUE(status.needs_main_thread_hit_test);
} else {
ASSERT_EQ(ScrollThread::SCROLL_ON_MAIN_THREAD, status.thread);
ASSERT_EQ(MainThreadScrollingReason::kFailedHitTest,
status.main_thread_scrolling_reasons);
}
GetInputHandler().ScrollEnd();
}
// Layer C is a 50x50 layer initially centered in the viewport. Layer C
// scrolls with Layer A and appears on top of Layer B. The right half of it
// overlaps Layer B.
auto* layer_c = AddLayer<LayerImpl>(host_impl_->active_tree());
layer_c->SetBounds(gfx::Size(50, 50));
layer_c->SetDrawsContent(true);
layer_c->SetHitTestable(true);
CopyProperties(layer_a, layer_c);
layer_c->SetOffsetToTransformParent(gfx::Vector2dF(25, 25));
// Do a sanity check - scrolling over layer c where it doesn't overlap B
// should cause scrolling of Layer A. It doesn't matter whether the
// point hits a "hit-test transparent" part of layer C because will cause
// scrolling in Layer A in either case since C scrolls with A.
{
ASSERT_EQ(layer_c, host_impl_->active_tree()->FindLayerThatIsHitByPoint(
gfx::PointF(40, 50)));
InputHandler::ScrollStatus status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(40, 50), gfx::Vector2d(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
ASSERT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
ASSERT_EQ(MainThreadScrollingReason::kNotScrollingOnMain,
status.main_thread_scrolling_reasons);
ASSERT_EQ(host_impl_->CurrentlyScrollingNode()->id,
layer_a->scroll_tree_index());
GetInputHandler().ScrollEnd();
}
// Now perform the real test - scrolling in the overlapping region should
// fallback to the main thread. In this case, we really do need to know
// whether the point hits a "hit-test transparent" part of Layer C because if
// it does it'll hit Layer B which scrolls the outer viewport but if it
// doesn't it targets Layer C which scrolls Layer A.
{
ASSERT_EQ(layer_c, host_impl_->active_tree()->FindLayerThatIsHitByPoint(
gfx::PointF(60, 50)));
InputHandler::ScrollStatus status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(60, 50), gfx::Vector2d(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
if (base::FeatureList::IsEnabled(features::kScrollUnification)) {
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kNotScrollingOnMain,
status.main_thread_scrolling_reasons);
EXPECT_TRUE(status.needs_main_thread_hit_test);
} else {
EXPECT_EQ(ScrollThread::SCROLL_ON_MAIN_THREAD, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kFailedHitTest,
status.main_thread_scrolling_reasons);
}
GetInputHandler().ScrollEnd();
}
}
// - Scrolling Layer A with scrolling child:
// - Ordinary Layer B with NonFastScrollableRegion
// - Fixed (scrolls with inner viewport) ordinary Layer C.
//
// +---------+---------++
// | Layer A | ||
// | +-----+-----+ ||
// | | Layer C | ||
// | +-----+-----+ ||
// | | Layer B ||
// +---------+---------++
//
//
// B scrolls with A but C, which is fixed, appears above B. If we try scrolling
// over C, we need to check if we intersect the NFSR on B because C may not be
// fully opaque to hit testing (e.g. the layer may be for |pointer-events:none|
// or be a squashing layer with "holes"). This is similar to the cases above
// but uses a fixed Layer C to exercise the case where we hit the viewport via
// the inner viewport.
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
FixedLayerOverlapsNonFastScrollableRegionInLayer) {
SetupViewportLayersOuterScrolls(gfx::Size(100, 100), gfx::Size(200, 200));
// The viewport will be layer A in the description above.
LayerImpl* outer_scroll = OuterViewportScrollLayer();
LayerImpl* inner_scroll = InnerViewportScrollLayer();
// Layer B is a 50x50 layer filled with a non fast scrollable region. It
// occupies the right half of the viewport.
auto* layer_b = AddLayer<LayerImpl>(host_impl_->active_tree());
layer_b->SetBounds(gfx::Size(50, 100));
layer_b->SetDrawsContent(true);
layer_b->SetHitTestable(true);
CopyProperties(outer_scroll, layer_b);
layer_b->SetOffsetToTransformParent(gfx::Vector2dF(50, 0));
layer_b->SetNonFastScrollableRegion(gfx::Rect(0, 0, 50, 100));
// Do a sanity check - scrolling over layer b should cause main thread
// scrolling/hit testing because of the non fast scrolling region.
{
ASSERT_EQ(layer_b, host_impl_->active_tree()->FindLayerThatIsHitByPoint(
gfx::PointF(60, 50)));
InputHandler::ScrollStatus status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(60, 50), gfx::Vector2d(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
if (base::FeatureList::IsEnabled(features::kScrollUnification)) {
ASSERT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
ASSERT_EQ(MainThreadScrollingReason::kNotScrollingOnMain,
status.main_thread_scrolling_reasons);
ASSERT_TRUE(status.needs_main_thread_hit_test);
} else {
ASSERT_EQ(ScrollThread::SCROLL_ON_MAIN_THREAD, status.thread);
ASSERT_EQ(MainThreadScrollingReason::kNonFastScrollableRegion,
status.main_thread_scrolling_reasons);
}
GetInputHandler().ScrollEnd();
}
// Layer C is a 50x50 layer initially centered in the viewport. The right
// half overlaps Layer B.
auto* layer_c = AddLayer<LayerImpl>(host_impl_->active_tree());
layer_c->SetBounds(gfx::Size(50, 50));
layer_c->SetDrawsContent(true);
layer_c->SetHitTestable(true);
CopyProperties(inner_scroll, layer_c);
layer_c->SetOffsetToTransformParent(gfx::Vector2dF(25, 25));
// Do a sanity check - scrolling over layer c where it doesn't overlap B
// should cause scrolling on the viewport. It doesn't matter whether the
// point hits a "hit-test transparent" part of layer C because will cause
// scrolling in Layer A in either case since C scrolls with A.
{
ASSERT_EQ(layer_c, host_impl_->active_tree()->FindLayerThatIsHitByPoint(
gfx::PointF(40, 50)));
InputHandler::ScrollStatus status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(40, 50), gfx::Vector2d(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
ASSERT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
ASSERT_EQ(MainThreadScrollingReason::kNotScrollingOnMain,
status.main_thread_scrolling_reasons);
ASSERT_EQ(host_impl_->CurrentlyScrollingNode(),
host_impl_->OuterViewportScrollNode());
GetInputHandler().ScrollEnd();
}
// Now perform the real test - scrolling in the overlapping region should
// fallback to the main thread. In this case, we really do need to know
// whether the point hits a "hit-test transparent" part of Layer C because if
// it does it'll hit the NonFastScrollingRegion but if it doesn't it targets
// Layer C which scrolls the viewport.
{
ASSERT_EQ(layer_c, host_impl_->active_tree()->FindLayerThatIsHitByPoint(
gfx::PointF(60, 50)));
InputHandler::ScrollStatus status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(60, 50), gfx::Vector2d(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
if (base::FeatureList::IsEnabled(features::kScrollUnification)) {
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kNotScrollingOnMain,
status.main_thread_scrolling_reasons);
EXPECT_TRUE(status.needs_main_thread_hit_test);
} else {
EXPECT_EQ(ScrollThread::SCROLL_ON_MAIN_THREAD, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kNonFastScrollableRegion,
status.main_thread_scrolling_reasons);
}
GetInputHandler().ScrollEnd();
}
}
// - Scrolling Layer A with scrolling child:
// - Ordinary Layer B
// - Fixed (scrolls with inner viewport) ordinary Layer C.
//
// +---------+---------++
// | Layer A | ||
// | +-----+-----+ ||
// | | Layer C | ||
// | +-----+-----+ ||
// | | Layer B ||
// +---------+---------++
//
// This test simply ensures that a scroll over the region where layer C and
// layer B overlap can be handled on the compositor thread. Both of these
// layers have the viewport as the first scrolling ancestor but C has the
// inner viewport while B has the outer viewport as an ancestor. Ensure we
// treat these as equivalent.
TEST_P(ScrollUnifiedLayerTreeHostImplTest, FixedLayerOverNonFixedLayer) {
SetupViewportLayersOuterScrolls(gfx::Size(100, 100), gfx::Size(200, 200));
// The viewport will be layer A in the description above.
LayerImpl* outer_scroll = OuterViewportScrollLayer();
LayerImpl* inner_scroll = InnerViewportScrollLayer();
// Layer B is a 50x50 layer filled with a non fast scrollable region. It
// occupies the right half of the viewport.
auto* layer_b = AddLayer<LayerImpl>(host_impl_->active_tree());
layer_b->SetBounds(gfx::Size(50, 100));
layer_b->SetDrawsContent(true);
layer_b->SetHitTestable(true);
CopyProperties(outer_scroll, layer_b);
layer_b->SetOffsetToTransformParent(gfx::Vector2dF(50, 0));
// Layer C is a 50x50 layer initially centered in the viewport. The right
// half overlaps Layer B.
auto* layer_c = AddLayer<LayerImpl>(host_impl_->active_tree());
layer_c->SetBounds(gfx::Size(50, 50));
layer_c->SetDrawsContent(true);
layer_c->SetHitTestable(true);
CopyProperties(inner_scroll, layer_c);
layer_c->SetOffsetToTransformParent(gfx::Vector2dF(25, 25));
// A scroll in the overlapping region should not fallback to the main thread
// since we'll scroll the viewport regardless which layer we really should
// hit.
{
ASSERT_EQ(layer_c, host_impl_->active_tree()->FindLayerThatIsHitByPoint(
gfx::PointF(60, 50)));
InputHandler::ScrollStatus status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(60, 50), gfx::Vector2d(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
ASSERT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
ASSERT_EQ(MainThreadScrollingReason::kNotScrollingOnMain,
status.main_thread_scrolling_reasons);
ASSERT_EQ(host_impl_->CurrentlyScrollingNode(),
host_impl_->OuterViewportScrollNode());
GetInputHandler().ScrollEnd();
}
// However, if we have a non-default root scroller, the inner and outer
// viewports really should be treated as separate scrollers (i.e. if you
// "bubble" up to the inner viewport, we shouldn't cause scrolling in the
// outer viewport because the outer viewport is not an ancestor of the
// scrolling Element so that would be unexpected). So now the scroll node to
// use for scrolling depends on whether Layer B or Layer C is actually hit so
// the main thread needs to decide.
{
GetScrollNode(InnerViewportScrollLayer())
->prevent_viewport_scrolling_from_inner = true;
ASSERT_EQ(layer_c, host_impl_->active_tree()->FindLayerThatIsHitByPoint(
gfx::PointF(60, 50)));
InputHandler::ScrollStatus status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(60, 50), gfx::Vector2d(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
if (base::FeatureList::IsEnabled(features::kScrollUnification)) {
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kNotScrollingOnMain,
status.main_thread_scrolling_reasons);
EXPECT_TRUE(status.needs_main_thread_hit_test);
} else {
EXPECT_EQ(ScrollThread::SCROLL_ON_MAIN_THREAD, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kFailedHitTest,
status.main_thread_scrolling_reasons);
}
GetInputHandler().ScrollEnd();
}
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollHandlerNotPresent) {
SetupViewportLayersInnerScrolls(gfx::Size(100, 100), gfx::Size(200, 200));
EXPECT_FALSE(host_impl_->active_tree()->have_scroll_event_handlers());
DrawFrame();
EXPECT_FALSE(host_impl_->ScrollAffectsScrollHandler());
GetInputHandler().ScrollBegin(BeginState(gfx::Point(), gfx::Vector2d(0, 10),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
EXPECT_FALSE(host_impl_->ScrollAffectsScrollHandler());
GetInputHandler().ScrollEnd();
EXPECT_FALSE(host_impl_->ScrollAffectsScrollHandler());
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollHandlerPresent) {
SetupViewportLayersInnerScrolls(gfx::Size(100, 100), gfx::Size(200, 200));
host_impl_->active_tree()->set_have_scroll_event_handlers(true);
DrawFrame();
EXPECT_FALSE(host_impl_->ScrollAffectsScrollHandler());
GetInputHandler().ScrollBegin(BeginState(gfx::Point(), gfx::Vector2d(0, 10),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
EXPECT_TRUE(host_impl_->ScrollAffectsScrollHandler());
GetInputHandler().ScrollEnd();
EXPECT_FALSE(host_impl_->ScrollAffectsScrollHandler());
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollUpdateReturnsCorrectValue) {
SetupViewportLayersInnerScrolls(gfx::Size(100, 100), gfx::Size(200, 200));
DrawFrame();
InputHandler::ScrollStatus status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(), gfx::Vector2d(-10, 0),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kNotScrollingOnMain,
status.main_thread_scrolling_reasons);
// Trying to scroll to the left/top will not succeed.
EXPECT_FALSE(
GetInputHandler()
.ScrollUpdate(UpdateState(gfx::Point(), gfx::Vector2d(-10, 0),
ui::ScrollInputType::kTouchscreen)
.get())
.did_scroll);
EXPECT_FALSE(
GetInputHandler()
.ScrollUpdate(UpdateState(gfx::Point(), gfx::Vector2d(0, -10),
ui::ScrollInputType::kTouchscreen)
.get())
.did_scroll);
EXPECT_FALSE(
GetInputHandler()
.ScrollUpdate(UpdateState(gfx::Point(), gfx::Vector2d(-10, -10),
ui::ScrollInputType::kTouchscreen)
.get())
.did_scroll);
// Scrolling to the right/bottom will succeed.
EXPECT_TRUE(GetInputHandler()
.ScrollUpdate(UpdateState(gfx::Point(), gfx::Vector2d(10, 0),
ui::ScrollInputType::kTouchscreen)
.get())
.did_scroll);
EXPECT_TRUE(GetInputHandler()
.ScrollUpdate(UpdateState(gfx::Point(), gfx::Vector2d(0, 10),
ui::ScrollInputType::kTouchscreen)
.get())
.did_scroll);
EXPECT_TRUE(GetInputHandler()
.ScrollUpdate(UpdateState(gfx::Point(), gfx::Vector2d(10, 10),
ui::ScrollInputType::kTouchscreen)
.get())
.did_scroll);
// Scrolling to left/top will now succeed.
EXPECT_TRUE(GetInputHandler()
.ScrollUpdate(UpdateState(gfx::Point(), gfx::Vector2d(-10, 0),
ui::ScrollInputType::kTouchscreen)
.get())
.did_scroll);
EXPECT_TRUE(GetInputHandler()
.ScrollUpdate(UpdateState(gfx::Point(), gfx::Vector2d(0, -10),
ui::ScrollInputType::kTouchscreen)
.get())
.did_scroll);
EXPECT_TRUE(
GetInputHandler()
.ScrollUpdate(UpdateState(gfx::Point(), gfx::Vector2d(-10, -10),
ui::ScrollInputType::kTouchscreen)
.get())
.did_scroll);
// Scrolling diagonally against an edge will succeed.
EXPECT_TRUE(
GetInputHandler()
.ScrollUpdate(UpdateState(gfx::Point(), gfx::Vector2d(10, -10),
ui::ScrollInputType::kTouchscreen)
.get())
.did_scroll);
EXPECT_TRUE(GetInputHandler()
.ScrollUpdate(UpdateState(gfx::Point(), gfx::Vector2d(-10, 0),
ui::ScrollInputType::kTouchscreen)
.get())
.did_scroll);
EXPECT_TRUE(
GetInputHandler()
.ScrollUpdate(UpdateState(gfx::Point(), gfx::Vector2d(-10, 10),
ui::ScrollInputType::kTouchscreen)
.get())
.did_scroll);
// Trying to scroll more than the available space will also succeed.
EXPECT_TRUE(
GetInputHandler()
.ScrollUpdate(UpdateState(gfx::Point(), gfx::Vector2d(5000, 5000),
ui::ScrollInputType::kTouchscreen)
.get())
.did_scroll);
}
// TODO(sunyunjia): Move scroll snap tests to a separate file.
// https://crbug.com/851690
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollSnapOnX) {
LayerImpl* overflow = CreateLayerForSnapping();
gfx::Point pointer_position(10, 10);
gfx::Vector2dF x_delta(20, 0);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(pointer_position, x_delta,
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(overflow));
EXPECT_EQ(TargetSnapAreaElementIds(),
GetSnapContainerData(overflow)->GetTargetSnapAreaElementIds());
GetInputHandler().ScrollUpdate(
UpdateState(pointer_position, x_delta, ui::ScrollInputType::kWheel)
.get());
EXPECT_EQ(TargetSnapAreaElementIds(),
GetSnapContainerData(overflow)->GetTargetSnapAreaElementIds());
viz::BeginFrameArgs begin_frame_args =
viz::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, 0, 1);
GetInputHandler().ScrollEnd(true);
// Snap target should not be set until the end of the animation.
EXPECT_TRUE(GetInputHandler().animating_for_snap_for_testing());
EXPECT_EQ(TargetSnapAreaElementIds(),
GetSnapContainerData(overflow)->GetTargetSnapAreaElementIds());
base::TimeTicks start_time = base::TimeTicks() + base::Milliseconds(100);
BeginImplFrameAndAnimate(begin_frame_args, start_time);
BeginImplFrameAndAnimate(begin_frame_args,
start_time + base::Milliseconds(50));
BeginImplFrameAndAnimate(begin_frame_args,
start_time + base::Milliseconds(1000));
EXPECT_FALSE(GetInputHandler().animating_for_snap_for_testing());
EXPECT_POINTF_EQ(gfx::PointF(50, 0), CurrentScrollOffset(overflow));
EXPECT_EQ(TargetSnapAreaElementIds(ElementId(10), ElementId()),
GetSnapContainerData(overflow)->GetTargetSnapAreaElementIds());
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollSnapOnY) {
LayerImpl* overflow = CreateLayerForSnapping();
gfx::Point pointer_position(10, 10);
gfx::Vector2dF y_delta(0, 20);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(pointer_position, y_delta,
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(overflow));
EXPECT_EQ(TargetSnapAreaElementIds(),
GetSnapContainerData(overflow)->GetTargetSnapAreaElementIds());
GetInputHandler().ScrollUpdate(
UpdateState(pointer_position, y_delta, ui::ScrollInputType::kWheel)
.get());
EXPECT_EQ(TargetSnapAreaElementIds(),
GetSnapContainerData(overflow)->GetTargetSnapAreaElementIds());
viz::BeginFrameArgs begin_frame_args =
viz::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, 0, 1);
GetInputHandler().ScrollEnd(true);
// Snap target should not be set until the end of the animation.
EXPECT_TRUE(GetInputHandler().animating_for_snap_for_testing());
EXPECT_EQ(TargetSnapAreaElementIds(),
GetSnapContainerData(overflow)->GetTargetSnapAreaElementIds());
base::TimeTicks start_time = base::TimeTicks() + base::Milliseconds(100);
BeginImplFrameAndAnimate(begin_frame_args, start_time);
BeginImplFrameAndAnimate(begin_frame_args,
start_time + base::Milliseconds(50));
BeginImplFrameAndAnimate(begin_frame_args,
start_time + base::Milliseconds(1000));
EXPECT_FALSE(GetInputHandler().animating_for_snap_for_testing());
EXPECT_POINTF_EQ(gfx::PointF(0, 50), CurrentScrollOffset(overflow));
EXPECT_EQ(TargetSnapAreaElementIds(ElementId(), ElementId(10)),
GetSnapContainerData(overflow)->GetTargetSnapAreaElementIds());
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollSnapOnBoth) {
LayerImpl* overflow = CreateLayerForSnapping();
gfx::Point pointer_position(10, 10);
gfx::Vector2dF delta(20, 20);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(pointer_position, delta,
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(overflow));
EXPECT_EQ(TargetSnapAreaElementIds(),
GetSnapContainerData(overflow)->GetTargetSnapAreaElementIds());
GetInputHandler().ScrollUpdate(
UpdateState(pointer_position, delta, ui::ScrollInputType::kWheel).get());
EXPECT_EQ(TargetSnapAreaElementIds(),
GetSnapContainerData(overflow)->GetTargetSnapAreaElementIds());
viz::BeginFrameArgs begin_frame_args =
viz::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, 0, 1);
GetInputHandler().ScrollEnd(true);
// Snap target should not be set until the end of the animation.
EXPECT_TRUE(GetInputHandler().animating_for_snap_for_testing());
EXPECT_EQ(TargetSnapAreaElementIds(),
GetSnapContainerData(overflow)->GetTargetSnapAreaElementIds());
base::TimeTicks start_time = base::TimeTicks() + base::Milliseconds(100);
BeginImplFrameAndAnimate(begin_frame_args, start_time);
BeginImplFrameAndAnimate(begin_frame_args,
start_time + base::Milliseconds(50));
BeginImplFrameAndAnimate(begin_frame_args,
start_time + base::Milliseconds(1000));
EXPECT_FALSE(GetInputHandler().animating_for_snap_for_testing());
EXPECT_POINTF_EQ(gfx::PointF(50, 50), CurrentScrollOffset(overflow));
EXPECT_EQ(TargetSnapAreaElementIds(ElementId(10), ElementId(10)),
GetSnapContainerData(overflow)->GetTargetSnapAreaElementIds());
}
// Simulate a ScrollBegin and ScrollEnd without any intervening ScrollUpdate.
// This test passes if it doesn't crash.
TEST_P(ScrollUnifiedLayerTreeHostImplTest, SnapAfterEmptyScroll) {
CreateLayerForSnapping();
gfx::Point pointer_position(10, 10);
gfx::Vector2dF y_delta(0, 20);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(pointer_position, y_delta,
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
GetInputHandler().ScrollEnd(true);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollSnapAfterAnimatedScroll) {
LayerImpl* overflow = CreateLayerForSnapping();
gfx::Point pointer_position(10, 10);
gfx::Vector2dF delta(20, 20);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(pointer_position, delta,
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
GetInputHandler().ScrollUpdate(
AnimatedUpdateState(pointer_position, delta).get());
GetInputHandler().ScrollEnd();
EXPECT_EQ(overflow->scroll_tree_index(),
host_impl_->CurrentlyScrollingNode()->id);
EXPECT_EQ(TargetSnapAreaElementIds(),
GetSnapContainerData(overflow)->GetTargetSnapAreaElementIds());
base::TimeTicks start_time = base::TimeTicks() + base::Milliseconds(100);
viz::BeginFrameArgs begin_frame_args =
viz::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, 0, 1);
BeginImplFrameAndAnimate(begin_frame_args, start_time);
// Animating for the wheel scroll.
BeginImplFrameAndAnimate(begin_frame_args,
start_time + base::Milliseconds(50));
EXPECT_FALSE(GetInputHandler().animating_for_snap_for_testing());
gfx::PointF current_offset = CurrentScrollOffset(overflow);
EXPECT_LT(0, current_offset.x());
EXPECT_GT(20, current_offset.x());
EXPECT_LT(0, current_offset.y());
EXPECT_GT(20, current_offset.y());
EXPECT_EQ(TargetSnapAreaElementIds(),
GetSnapContainerData(overflow)->GetTargetSnapAreaElementIds());
// The scroll animation is finished, so the snap animation should begin.
BeginImplFrameAndAnimate(begin_frame_args,
start_time + base::Milliseconds(1000));
// The snap target should not be set until the end of the animation.
EXPECT_TRUE(GetInputHandler().animating_for_snap_for_testing());
EXPECT_EQ(TargetSnapAreaElementIds(),
GetSnapContainerData(overflow)->GetTargetSnapAreaElementIds());
// Finish the animation.
BeginImplFrameAndAnimate(begin_frame_args,
start_time + base::Milliseconds(1500));
EXPECT_POINTF_EQ(gfx::PointF(50, 50), CurrentScrollOffset(overflow));
EXPECT_FALSE(GetInputHandler().animating_for_snap_for_testing());
EXPECT_EQ(TargetSnapAreaElementIds(ElementId(10), ElementId(10)),
GetSnapContainerData(overflow)->GetTargetSnapAreaElementIds());
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, SnapAnimationTargetUpdated) {
LayerImpl* overflow = CreateLayerForSnapping();
gfx::Point pointer_position(10, 10);
gfx::Vector2dF y_delta(0, 20);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(pointer_position, y_delta,
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(overflow));
GetInputHandler().ScrollUpdate(
UpdateState(pointer_position, y_delta, ui::ScrollInputType::kWheel)
.get());
EXPECT_FALSE(GetInputHandler().animating_for_snap_for_testing());
viz::BeginFrameArgs begin_frame_args =
viz::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, 0, 1);
GetInputHandler().ScrollEnd(true);
base::TimeTicks start_time = base::TimeTicks() + base::Milliseconds(100);
BeginImplFrameAndAnimate(begin_frame_args, start_time);
// Finish smooth wheel scroll animation which starts a snap animation.
BeginImplFrameAndAnimate(begin_frame_args,
start_time + base::Milliseconds(100));
EXPECT_TRUE(GetInputHandler().animating_for_snap_for_testing());
EXPECT_EQ(TargetSnapAreaElementIds(),
GetSnapContainerData(overflow)->GetTargetSnapAreaElementIds());
gfx::PointF current_offset = CurrentScrollOffset(overflow);
EXPECT_GT(50, current_offset.y());
EXPECT_LT(20, current_offset.y());
// Update wheel scroll animation target. This should no longer be considered
// as animating a snap scroll, which should happen at the end of this
// animation.
GetInputHandler().ScrollUpdate(
AnimatedUpdateState(gfx::Point(10, 10), gfx::Vector2dF(0, -10)).get());
EXPECT_FALSE(GetInputHandler().animating_for_snap_for_testing());
// Finish the smooth scroll animation for wheel.
const int scroll_animation_duration_ms =
features::IsImpulseScrollAnimationEnabled() ? 300 : 150;
BeginImplFrameAndAnimate(
begin_frame_args,
start_time + base::Milliseconds(scroll_animation_duration_ms));
// At the end of the previous scroll animation, a new animation for the
// snapping should have started.
EXPECT_TRUE(GetInputHandler().animating_for_snap_for_testing());
// Finish the snap animation.
BeginImplFrameAndAnimate(begin_frame_args,
start_time + base::Milliseconds(1000));
EXPECT_FALSE(GetInputHandler().animating_for_snap_for_testing());
// At the end of snap animation we should have updated the
// TargetSnapAreaElementIds.
EXPECT_EQ(TargetSnapAreaElementIds(ElementId(), ElementId(10)),
GetSnapContainerData(overflow)->GetTargetSnapAreaElementIds());
EXPECT_POINTF_EQ(gfx::PointF(0, 50), CurrentScrollOffset(overflow));
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, SnapAnimationCancelledByScroll) {
LayerImpl* overflow = CreateLayerForSnapping();
gfx::Point pointer_position(10, 10);
gfx::Vector2dF x_delta(20, 0);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(pointer_position, x_delta,
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(overflow));
GetInputHandler().ScrollUpdate(
UpdateState(pointer_position, x_delta, ui::ScrollInputType::kWheel)
.get());
EXPECT_FALSE(GetInputHandler().animating_for_snap_for_testing());
viz::BeginFrameArgs begin_frame_args =
viz::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, 0, 1);
GetInputHandler().ScrollEnd(true);
base::TimeTicks start_time = base::TimeTicks() + base::Milliseconds(100);
BeginImplFrameAndAnimate(begin_frame_args, start_time);
// Animating for the snap.
BeginImplFrameAndAnimate(begin_frame_args,
start_time + base::Milliseconds(100));
EXPECT_TRUE(GetInputHandler().animating_for_snap_for_testing());
EXPECT_EQ(TargetSnapAreaElementIds(),
GetSnapContainerData(overflow)->GetTargetSnapAreaElementIds());
gfx::PointF current_offset = CurrentScrollOffset(overflow);
EXPECT_GT(50, current_offset.x());
EXPECT_LT(20, current_offset.x());
EXPECT_EQ(0, current_offset.y());
// Interrupt the snap animation with ScrollBegin.
auto begin_state =
BeginState(pointer_position, x_delta, ui::ScrollInputType::kWheel);
begin_state->data()->delta_granularity =
ui::ScrollGranularity::kScrollByPrecisePixel;
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(begin_state.get(), ui::ScrollInputType::kWheel)
.thread);
EXPECT_FALSE(GetInputHandler().animating_for_snap_for_testing());
EXPECT_EQ(TargetSnapAreaElementIds(),
GetSnapContainerData(overflow)->GetTargetSnapAreaElementIds());
BeginImplFrameAndAnimate(begin_frame_args,
start_time + base::Milliseconds(150));
EXPECT_POINTF_EQ(current_offset, CurrentScrollOffset(overflow));
BeginImplFrameAndAnimate(begin_frame_args,
start_time + base::Milliseconds(1000));
// Ensure that the snap target was not updated at the end of the scroll
// animation.
EXPECT_EQ(TargetSnapAreaElementIds(),
GetSnapContainerData(overflow)->GetTargetSnapAreaElementIds());
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
SnapAnimationShouldNotStartWhenScrollEndsAtSnapTarget) {
LayerImpl* overflow = CreateLayerForSnapping();
gfx::Point pointer_position(10, 10);
gfx::Vector2dF x_delta(50, 0);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(pointer_position, x_delta,
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(overflow));
// There is a snap target at 50, scroll to it directly.
GetInputHandler().ScrollUpdate(
UpdateState(pointer_position, x_delta, ui::ScrollInputType::kWheel)
.get());
EXPECT_FALSE(GetInputHandler().animating_for_snap_for_testing());
viz::BeginFrameArgs begin_frame_args =
viz::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, 0, 1);
GetInputHandler().ScrollEnd(true);
// No animation is created, but the snap target should be updated.
EXPECT_FALSE(GetInputHandler().animating_for_snap_for_testing());
EXPECT_EQ(TargetSnapAreaElementIds(ElementId(10), ElementId()),
GetSnapContainerData(overflow)->GetTargetSnapAreaElementIds());
base::TimeTicks start_time = base::TimeTicks() + base::Milliseconds(100);
BeginImplFrameAndAnimate(begin_frame_args, start_time);
// We are already at a snap target so we should not animate for snap.
EXPECT_FALSE(GetInputHandler().animating_for_snap_for_testing());
// Verify that we are not actually animating by running one frame and ensuring
// scroll offset has not changed.
BeginImplFrameAndAnimate(begin_frame_args,
start_time + base::Milliseconds(100));
EXPECT_FALSE(GetInputHandler().animating_for_snap_for_testing());
EXPECT_POINTF_EQ(gfx::PointF(50, 0), CurrentScrollOffset(overflow));
EXPECT_EQ(TargetSnapAreaElementIds(ElementId(10), ElementId()),
GetSnapContainerData(overflow)->GetTargetSnapAreaElementIds());
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
GetSnapFlingInfoAndSetAnimatingSnapTargetWhenZoomed) {
LayerImpl* overflow = CreateLayerForSnapping();
// Scales the page to its 1/5.
host_impl_->active_tree()->PushPageScaleFromMainThread(0.2f, 0.1f, 5);
// Should be (10, 10) in the scroller's coordinate.
gfx::Point pointer_position(2, 2);
gfx::Vector2dF delta(4, 4);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(pointer_position, delta,
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(overflow));
// Should be (20, 20) in the scroller's coordinate.
InputHandlerScrollResult result = GetInputHandler().ScrollUpdate(
UpdateState(pointer_position, delta, ui::ScrollInputType::kWheel).get());
EXPECT_POINTF_EQ(gfx::PointF(20, 20), CurrentScrollOffset(overflow));
EXPECT_POINTF_EQ(gfx::PointF(4, 4), result.current_visual_offset);
gfx::PointF initial_offset, target_offset;
EXPECT_TRUE(GetInputHandler().GetSnapFlingInfoAndSetAnimatingSnapTarget(
gfx::Vector2dF(10, 10), &initial_offset, &target_offset));
EXPECT_TRUE(GetInputHandler().animating_for_snap_for_testing());
EXPECT_POINTF_EQ(gfx::PointF(4, 4), initial_offset);
EXPECT_POINTF_EQ(gfx::PointF(10, 10), target_offset);
// Snap targets shouldn't be set until the fling animation is complete.
EXPECT_EQ(TargetSnapAreaElementIds(),
GetSnapContainerData(overflow)->GetTargetSnapAreaElementIds());
GetInputHandler().ScrollEndForSnapFling(true /* did_finish */);
EXPECT_FALSE(GetInputHandler().animating_for_snap_for_testing());
EXPECT_EQ(TargetSnapAreaElementIds(ElementId(10), ElementId(10)),
GetSnapContainerData(overflow)->GetTargetSnapAreaElementIds());
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
SnapFlingAnimationEndWithoutFinishing) {
LayerImpl* overflow = CreateLayerForSnapping();
// Scales the page to its 1/5.
host_impl_->active_tree()->PushPageScaleFromMainThread(0.2f, 0.1f, 5.f);
// Should be (10, 10) in the scroller's coordinate.
gfx::Point pointer_position(2, 2);
gfx::Vector2dF delta(4, 4);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(pointer_position, delta,
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(overflow));
// Should be (20, 20) in the scroller's coordinate.
InputHandlerScrollResult result = GetInputHandler().ScrollUpdate(
UpdateState(pointer_position, delta, ui::ScrollInputType::kWheel).get());
EXPECT_POINTF_EQ(gfx::PointF(20, 20), CurrentScrollOffset(overflow));
EXPECT_POINTF_EQ(gfx::PointF(4, 4), result.current_visual_offset);
gfx::PointF initial_offset, target_offset;
EXPECT_TRUE(GetInputHandler().GetSnapFlingInfoAndSetAnimatingSnapTarget(
gfx::Vector2dF(10, 10), &initial_offset, &target_offset));
EXPECT_TRUE(GetInputHandler().animating_for_snap_for_testing());
EXPECT_POINTF_EQ(gfx::PointF(4, 4), initial_offset);
EXPECT_POINTF_EQ(gfx::PointF(10, 10), target_offset);
// Snap targets shouldn't be set until the fling animation is complete.
EXPECT_EQ(TargetSnapAreaElementIds(),
GetSnapContainerData(overflow)->GetTargetSnapAreaElementIds());
// The snap targets should not be set if the snap fling did not finish.
GetInputHandler().ScrollEndForSnapFling(false /* did_finish */);
EXPECT_FALSE(GetInputHandler().animating_for_snap_for_testing());
EXPECT_EQ(TargetSnapAreaElementIds(),
GetSnapContainerData(overflow)->GetTargetSnapAreaElementIds());
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
OverscrollBehaviorPreventsPropagation) {
const gfx::Size kViewportSize(100, 100);
const gfx::Size kContentSize(200, 200);
SetupViewportLayersOuterScrolls(kViewportSize, kContentSize);
LayerImpl* scroll_layer = OuterViewportScrollLayer();
gfx::Size overflow_size(400, 400);
LayerImpl* overflow = AddScrollableLayer(OuterViewportScrollLayer(),
gfx::Size(100, 100), overflow_size);
SetScrollOffset(scroll_layer, gfx::PointF(30, 30));
DrawFrame();
gfx::Point pointer_position(50, 50);
gfx::Vector2dF x_delta(-10, 0);
gfx::Vector2dF y_delta(0, -10);
gfx::Vector2dF diagonal_delta(-10, -10);
// OverscrollBehaviorTypeAuto shouldn't prevent scroll propagation.
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(pointer_position, x_delta,
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
EXPECT_POINTF_EQ(gfx::PointF(30, 30), CurrentScrollOffset(scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(overflow));
GetInputHandler().ScrollUpdate(
UpdateState(pointer_position, x_delta, ui::ScrollInputType::kWheel)
.get());
GetInputHandler().ScrollEnd();
EXPECT_POINTF_EQ(gfx::PointF(20, 30), CurrentScrollOffset(scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(overflow));
GetScrollNode(overflow)->overscroll_behavior = OverscrollBehavior(
OverscrollBehavior::Type::kContain, OverscrollBehavior::Type::kAuto);
DrawFrame();
// OverscrollBehaviorContain on x should prevent propagations of scroll
// on x.
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(pointer_position, x_delta,
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
EXPECT_POINTF_EQ(gfx::PointF(20, 30), CurrentScrollOffset(scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(overflow));
GetInputHandler().ScrollUpdate(
UpdateState(pointer_position, x_delta, ui::ScrollInputType::kWheel)
.get());
GetInputHandler().ScrollEnd();
EXPECT_POINTF_EQ(gfx::PointF(20, 30), CurrentScrollOffset(scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(overflow));
// OverscrollBehaviorContain on x shouldn't prevent propagations of
// scroll on y.
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(pointer_position, y_delta,
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
EXPECT_POINTF_EQ(gfx::PointF(20, 30), CurrentScrollOffset(scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(overflow));
GetInputHandler().ScrollUpdate(
UpdateState(pointer_position, y_delta, ui::ScrollInputType::kWheel)
.get());
GetInputHandler().ScrollEnd();
EXPECT_POINTF_EQ(gfx::PointF(20, 20), CurrentScrollOffset(scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(overflow));
// A scroll update with both x & y delta will adhere to the most restrictive
// case.
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(pointer_position, diagonal_delta,
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
EXPECT_POINTF_EQ(gfx::PointF(20, 20), CurrentScrollOffset(scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(overflow));
GetInputHandler().ScrollUpdate(
UpdateState(pointer_position, diagonal_delta, ui::ScrollInputType::kWheel)
.get());
GetInputHandler().ScrollEnd();
EXPECT_POINTF_EQ(gfx::PointF(20, 20), CurrentScrollOffset(scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(overflow));
// Changing scroll-boundary-behavior to y axis.
GetScrollNode(overflow)->overscroll_behavior = OverscrollBehavior(
OverscrollBehavior::Type::kAuto, OverscrollBehavior::Type::kContain);
DrawFrame();
// OverscrollBehaviorContain on y shouldn't prevent propagations of
// scroll on x.
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(pointer_position, x_delta,
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
EXPECT_POINTF_EQ(gfx::PointF(20, 20), CurrentScrollOffset(scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(overflow));
GetInputHandler().ScrollUpdate(
UpdateState(pointer_position, x_delta, ui::ScrollInputType::kWheel)
.get());
GetInputHandler().ScrollEnd();
EXPECT_POINTF_EQ(gfx::PointF(10, 20), CurrentScrollOffset(scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(overflow));
// OverscrollBehaviorContain on y should prevent propagations of scroll
// on y.
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(pointer_position, y_delta,
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
EXPECT_POINTF_EQ(gfx::PointF(10, 20), CurrentScrollOffset(scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(overflow));
GetInputHandler().ScrollUpdate(
UpdateState(pointer_position, y_delta, ui::ScrollInputType::kWheel)
.get());
GetInputHandler().ScrollEnd();
EXPECT_POINTF_EQ(gfx::PointF(10, 20), CurrentScrollOffset(scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(overflow));
// A scroll update with both x & y delta will adhere to the most restrictive
// case.
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(pointer_position, diagonal_delta,
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
EXPECT_POINTF_EQ(gfx::PointF(10, 20), CurrentScrollOffset(scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(overflow));
GetInputHandler().ScrollUpdate(
UpdateState(pointer_position, diagonal_delta, ui::ScrollInputType::kWheel)
.get());
GetInputHandler().ScrollEnd();
EXPECT_POINTF_EQ(gfx::PointF(10, 20), CurrentScrollOffset(scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(overflow));
// Gesture scroll should latch to the first scroller that has non-auto
// overscroll-behavior.
GetScrollNode(overflow)->overscroll_behavior = OverscrollBehavior(
OverscrollBehavior::Type::kContain, OverscrollBehavior::Type::kContain);
DrawFrame();
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(pointer_position, x_delta,
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
EXPECT_POINTF_EQ(gfx::PointF(10, 20), CurrentScrollOffset(scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(overflow));
GetInputHandler().ScrollUpdate(
UpdateState(pointer_position, x_delta, ui::ScrollInputType::kWheel)
.get());
GetInputHandler().ScrollUpdate(
UpdateState(pointer_position, -x_delta, ui::ScrollInputType::kWheel)
.get());
GetInputHandler().ScrollUpdate(
UpdateState(pointer_position, y_delta, ui::ScrollInputType::kWheel)
.get());
GetInputHandler().ScrollUpdate(
UpdateState(pointer_position, -y_delta, ui::ScrollInputType::kWheel)
.get());
GetInputHandler().ScrollEnd();
EXPECT_POINTF_EQ(gfx::PointF(10, 20), CurrentScrollOffset(scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(10, 10), CurrentScrollOffset(overflow));
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollWithUserUnscrollableLayers) {
const gfx::Size kViewportSize(100, 100);
const gfx::Size kContentSize(200, 200);
SetupViewportLayersOuterScrolls(kViewportSize, kContentSize);
LayerImpl* scroll_layer = OuterViewportScrollLayer();
gfx::Size overflow_size(400, 400);
LayerImpl* overflow =
AddScrollableLayer(scroll_layer, gfx::Size(100, 100), overflow_size);
DrawFrame();
gfx::Point scroll_position(10, 10);
gfx::Vector2dF scroll_delta(10, 10);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(scroll_position, scroll_delta,
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(overflow));
GetInputHandler().ScrollUpdate(
UpdateState(scroll_position, scroll_delta, ui::ScrollInputType::kWheel)
.get());
GetInputHandler().ScrollEnd();
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(10, 10), CurrentScrollOffset(overflow));
GetScrollNode(overflow)->user_scrollable_horizontal = false;
DrawFrame();
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(scroll_position, scroll_delta,
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(10, 10), CurrentScrollOffset(overflow));
GetInputHandler().ScrollUpdate(
UpdateState(scroll_position, scroll_delta, ui::ScrollInputType::kWheel)
.get());
GetInputHandler().ScrollEnd();
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(10, 20), CurrentScrollOffset(overflow));
GetScrollNode(overflow)->user_scrollable_vertical = false;
DrawFrame();
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(scroll_position, scroll_delta,
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(10, 20), CurrentScrollOffset(overflow));
GetInputHandler().ScrollUpdate(
UpdateState(scroll_position, scroll_delta, ui::ScrollInputType::kWheel)
.get());
GetInputHandler().ScrollEnd();
EXPECT_POINTF_EQ(gfx::PointF(10, 10), CurrentScrollOffset(scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(10, 20), CurrentScrollOffset(overflow));
}
// Test that if a scroll node doesn't have an associated Layer, scrolling
// is forced to the main thread. With scroll unification, this kind of scroll
// is now handled on the impl thread but will force a repaint on each scroll.
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollNodeWithoutScrollLayer) {
SetupViewportLayersInnerScrolls(gfx::Size(100, 100), gfx::Size(200, 200));
ScrollNode* scroll_node = host_impl_->OuterViewportScrollNode();
// Change the scroll node so that it no longer has an associated layer.
scroll_node->element_id = ElementId(42);
DrawFrame();
InputHandler::ScrollStatus status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(25, 25), gfx::Vector2dF(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
if (base::FeatureList::IsEnabled(features::kScrollUnification)) {
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kNotScrollingOnMain,
status.main_thread_scrolling_reasons);
// We don't have a layer for the scroller but we didn't hit a non-fast
// scrolling region or fail hit testing the layer - we don't need a main
// thread hit test in this case.
EXPECT_FALSE(status.needs_main_thread_hit_test);
} else {
EXPECT_EQ(ScrollThread::SCROLL_ON_MAIN_THREAD, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kNoScrollingLayer,
status.main_thread_scrolling_reasons);
}
}
TEST_F(CommitToPendingTreeLayerTreeHostImplTest,
AnimationSchedulingPendingTree) {
EXPECT_FALSE(host_impl_->CommitToActiveTree());
CreatePendingTree();
auto* root =
SetupRootLayer<LayerImpl>(host_impl_->pending_tree(), gfx::Size(50, 50));
root->SetNeedsPushProperties();
auto* child = AddLayer<LayerImpl>(host_impl_->pending_tree());
child->SetBounds(gfx::Size(10, 10));
child->SetDrawsContent(true);
child->SetNeedsPushProperties();
host_impl_->pending_tree()->SetElementIdsForTesting();
CopyProperties(root, child);
CreateTransformNode(child);
scoped_refptr<Animation> animation =
Animation::Create(AnimationIdProvider::NextAnimationId());
timeline()->AttachAnimation(animation);
animation->AttachElement(child->element_id());
AddAnimatedTransformToAnimation(animation.get(), 10.0, 3, 0);
animation->GetKeyframeModel(TargetProperty::TRANSFORM)
->set_affects_active_elements(false);
UpdateDrawProperties(host_impl_->pending_tree());
EXPECT_FALSE(did_request_next_frame_);
EXPECT_FALSE(did_request_redraw_);
EXPECT_FALSE(did_request_commit_);
host_impl_->AnimatePendingTreeAfterCommit();
// An animation exists on the pending layer. Doing
// AnimatePendingTreeAfterCommit() requests another frame.
// In reality, animations without has_set_start_time() == true do not need to
// be continuously ticked on the pending tree, so it should not request
// another animation frame here. But we currently do so blindly if any
// animation exists.
EXPECT_TRUE(did_request_next_frame_);
// The pending tree with an animation does not need to draw after animating.
EXPECT_FALSE(did_request_redraw_);
EXPECT_FALSE(did_request_commit_);
did_request_next_frame_ = false;
did_request_redraw_ = false;
did_request_commit_ = false;
host_impl_->ActivateSyncTree();
// When the animation activates, we should request another animation frame
// to keep the animation moving.
EXPECT_TRUE(did_request_next_frame_);
// On activation we don't need to request a redraw for the animation,
// activating will draw on its own when it's ready.
EXPECT_FALSE(did_request_redraw_);
EXPECT_FALSE(did_request_commit_);
}
TEST_F(CommitToPendingTreeLayerTreeHostImplTest,
AnimationSchedulingActiveTree) {
EXPECT_FALSE(host_impl_->CommitToActiveTree());
LayerImpl* root = SetupDefaultRootLayer(gfx::Size(50, 50));
LayerImpl* child = AddLayer();
child->SetBounds(gfx::Size(10, 10));
child->SetDrawsContent(true);
host_impl_->active_tree()->SetElementIdsForTesting();
CopyProperties(root, child);
CreateTransformNode(child);
// Add a translate from 6,7 to 8,9.
gfx::TransformOperations start;
start.AppendTranslate(6, 7, 0);
gfx::TransformOperations end;
end.AppendTranslate(8, 9, 0);
AddAnimatedTransformToElementWithAnimation(child->element_id(), timeline(),
4.0, start, end);
UpdateDrawProperties(host_impl_->active_tree());
base::TimeTicks now = base::TimeTicks::Now();
host_impl_->WillBeginImplFrame(
viz::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, 0, 2, now));
// TODO(crbug.com/551134): We always request a new frame and a draw for
// animations that are on the pending tree, but we don't need to do that
// unless they are waiting for some future time to start.
EXPECT_TRUE(did_request_next_frame_);
EXPECT_TRUE(did_request_redraw_);
EXPECT_FALSE(did_request_commit_);
did_request_next_frame_ = false;
did_request_redraw_ = false;
did_request_commit_ = false;
host_impl_->ActivateAnimations();
// On activating an animation, we should request another frame so that we'll
// continue ticking the animation.
EXPECT_TRUE(did_request_next_frame_);
EXPECT_FALSE(did_request_redraw_);
EXPECT_FALSE(did_request_commit_);
did_request_next_frame_ = false;
did_request_redraw_ = false;
did_request_commit_ = false;
// The next frame after activating, we'll tick the animation again.
host_impl_->Animate();
// An animation exists on the active layer. Doing Animate() requests another
// frame after the current one.
EXPECT_TRUE(did_request_next_frame_);
// The animation should cause us to draw at the frame's deadline.
EXPECT_TRUE(did_request_redraw_);
EXPECT_FALSE(did_request_commit_);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
AnimationSchedulingCommitToActiveTree) {
EXPECT_TRUE(host_impl_->CommitToActiveTree());
auto* root = SetupDefaultRootLayer(gfx::Size(50, 50));
auto* child = AddLayer();
child->SetBounds(gfx::Size(10, 10));
child->SetDrawsContent(true);
host_impl_->active_tree()->SetElementIdsForTesting();
CopyProperties(root, child);
CreateTransformNode(child);
AddAnimatedTransformToElementWithAnimation(child->element_id(), timeline(),
10.0, 3, 0);
// Set up the property trees so that UpdateDrawProperties will work in
// CommitComplete below.
UpdateDrawProperties(host_impl_->active_tree());
EXPECT_FALSE(did_request_next_frame_);
EXPECT_FALSE(did_request_redraw_);
EXPECT_FALSE(did_request_commit_);
host_impl_->CommitComplete();
// Animations on the active tree should be started and ticked, and a new frame
// should be requested to continue ticking them.
EXPECT_TRUE(did_request_next_frame_);
EXPECT_TRUE(did_request_redraw_);
EXPECT_FALSE(did_request_commit_);
// Delete the LayerTreeHostImpl before the TaskRunnerProvider goes away.
host_impl_->ReleaseLayerTreeFrameSink();
host_impl_ = nullptr;
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
AnimationSchedulingOnLayerDestruction) {
LayerImpl* root = SetupDefaultRootLayer(gfx::Size(50, 50));
LayerImpl* child = AddLayer();
child->SetBounds(gfx::Size(10, 10));
child->SetDrawsContent(true);
host_impl_->active_tree()->SetElementIdsForTesting();
CopyProperties(root, child);
CreateTransformNode(child);
// Add a translate animation.
gfx::TransformOperations start;
start.AppendTranslate(6, 7, 0);
gfx::TransformOperations end;
end.AppendTranslate(8, 9, 0);
scoped_refptr<Animation> animation =
Animation::Create(AnimationIdProvider::NextAnimationId());
timeline()->AttachAnimation(animation);
animation->AttachElement(child->element_id());
int keyframe_model_id =
AddAnimatedTransformToAnimation(animation.get(), 4.0, start, end);
UpdateDrawProperties(host_impl_->active_tree());
base::TimeTicks now = base::TimeTicks::Now();
host_impl_->WillBeginImplFrame(
viz::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, 0, 2, now));
EXPECT_TRUE(did_request_next_frame_);
did_request_next_frame_ = false;
host_impl_->ActivateAnimations();
// On activating an animation, we should request another frame so that we'll
// continue ticking the animation.
EXPECT_TRUE(did_request_next_frame_);
did_request_next_frame_ = false;
// The next frame after activating, we'll tick the animation again.
host_impl_->Animate();
// An animation exists on the active layer. Doing Animate() requests another
// frame after the current one.
EXPECT_TRUE(did_request_next_frame_);
did_request_next_frame_ = false;
// In the real code, animations are removed at the same time as their property
// tree nodes are.
animation->RemoveKeyframeModel(keyframe_model_id);
host_impl_->ActivateAnimations();
EXPECT_FALSE(did_request_next_frame_);
// In the real code, you cannot remove a child on LayerImpl, but a child
// removed on Layer will force a full tree sync which will rebuild property
// trees without that child's property tree nodes. Clear active_tree (which
// also clears property trees) to simulate the rebuild that would happen
// before/during the commit.
host_impl_->active_tree()->property_trees()->clear();
// Updating state requires no animation update.
host_impl_->UpdateAnimationState(true);
EXPECT_FALSE(did_request_next_frame_);
// Doing Animate() doesn't request any frames after the animation is removed.
host_impl_->Animate();
EXPECT_FALSE(did_request_next_frame_);
}
class MissingTilesLayer : public LayerImpl {
public:
static std::unique_ptr<MissingTilesLayer> Create(LayerTreeImpl* tree_impl,
int id) {
return base::WrapUnique(new MissingTilesLayer(tree_impl, id));
}
MissingTilesLayer(LayerTreeImpl* layer_tree_impl, int id)
: LayerImpl(layer_tree_impl, id) {}
void AppendQuads(viz::CompositorRenderPass* render_pass,
AppendQuadsData* append_quads_data) override {
append_quads_data->num_missing_tiles += 10;
append_quads_data->checkerboarded_no_recording_content_area += 200;
append_quads_data->visible_layer_area += 200;
}
};
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
CurrentScrollCheckerboardsDueToNoRecording) {
LayerTreeSettings settings = DefaultSettings();
CreateHostImpl(settings, CreateLayerTreeFrameSink());
host_impl_->active_tree()->PushPageScaleFromMainThread(1, 0.25f, 4);
const gfx::Size content_size(1000, 1000);
const gfx::Size viewport_size(500, 500);
SetupViewportLayersOuterScrolls(viewport_size, content_size);
LayerImpl* outer_scroll_layer = OuterViewportScrollLayer();
outer_scroll_layer->SetDrawsContent(true);
LayerImpl* inner_scroll_layer = InnerViewportScrollLayer();
inner_scroll_layer->SetDrawsContent(true);
// Add layer that draws content and has checkerboarded areas.
auto* scroll_layer = AddLayer<MissingTilesLayer>(host_impl_->active_tree());
CopyProperties(inner_scroll_layer, scroll_layer);
scroll_layer->SetBounds(gfx::Size(500, 500));
scroll_layer->SetDrawsContent(true);
scroll_layer->SetHitTestable(false);
host_impl_->active_tree()->SetElementIdsForTesting();
UpdateDrawProperties(host_impl_->active_tree());
DrawFrame();
// No scroll has taken place so this should be false.
EXPECT_FALSE(host_impl_->CurrentScrollCheckerboardsDueToNoRecording());
// Send scroll begin.
GetInputHandler().ScrollBegin(
BeginState(gfx::Point(250, 250), gfx::Vector2dF(),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
DrawFrame();
// Even though a ScrollBegin has been processed, we still don't consider the
// interaction to be "actively scrolling". Expect this to be false.
EXPECT_FALSE(host_impl_->CurrentScrollCheckerboardsDueToNoRecording());
gfx::Vector2dF scroll_delta(0, 10);
// Send scroll update.
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(10, 10), scroll_delta, ui::ScrollInputType::kWheel)
.get());
host_impl_->SetFullViewportDamage();
DrawFrame();
// Now that a scroll update has been processed and the latest
// CalculateRenderPasses run has computed significant visible checkerboarding,
// expect this flag to be true.
EXPECT_TRUE(host_impl_->CurrentScrollCheckerboardsDueToNoRecording());
GetInputHandler().ScrollEnd();
// Expect state to be reset after a scroll end.
EXPECT_FALSE(host_impl_->CurrentScrollCheckerboardsDueToNoRecording());
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ImplPinchZoom) {
SetupViewportLayersInnerScrolls(gfx::Size(50, 50), gfx::Size(100, 100));
DrawFrame();
LayerImpl* scroll_layer = InnerViewportScrollLayer();
EXPECT_EQ(gfx::Size(50, 50), root_layer()->bounds());
float min_page_scale = 1, max_page_scale = 4;
float page_scale_factor = 1;
// The impl-based pinch zoom should adjust the max scroll position.
{
host_impl_->active_tree()->PushPageScaleFromMainThread(
page_scale_factor, min_page_scale, max_page_scale);
host_impl_->active_tree()->SetPageScaleOnActiveTree(page_scale_factor);
SetScrollOffsetDelta(scroll_layer, gfx::Vector2d());
float page_scale_delta = 2;
// TODO(bokan): What are the delta_hints for a GSB that's sent for a pinch
// gesture that doesn't cause (initial) scrolling?
// https://crbug.com/1030262
GetInputHandler().ScrollBegin(
BeginState(gfx::Point(50, 50), gfx::Vector2dF(),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
GetInputHandler().PinchGestureBegin(gfx::Point(50, 50),
ui::ScrollInputType::kWheel);
GetInputHandler().PinchGestureUpdate(page_scale_delta, gfx::Point(50, 50));
GetInputHandler().PinchGestureEnd(gfx::Point(50, 50));
GetInputHandler().ScrollEnd();
EXPECT_FALSE(did_request_next_frame_);
EXPECT_TRUE(did_request_redraw_);
EXPECT_TRUE(did_request_commit_);
EXPECT_EQ(gfx::Size(50, 50), root_layer()->bounds());
std::unique_ptr<CompositorCommitData> commit_data =
host_impl_->ProcessCompositorDeltas(
/* main_thread_mutator_host */ nullptr);
EXPECT_EQ(commit_data->page_scale_delta, page_scale_delta);
EXPECT_EQ(gfx::PointF(75.0, 75.0), MaxScrollOffset(scroll_layer));
ClearMainThreadDeltasForTesting(host_impl_.get());
}
// Scrolling after a pinch gesture should always be in local space. The
// scroll deltas have the page scale factor applied.
{
host_impl_->active_tree()->PushPageScaleFromMainThread(
page_scale_factor, min_page_scale, max_page_scale);
host_impl_->active_tree()->SetPageScaleOnActiveTree(page_scale_factor);
SetScrollOffsetDelta(scroll_layer, gfx::Vector2d());
float page_scale_delta = 2;
GetInputHandler().ScrollBegin(BeginState(gfx::Point(), gfx::Vector2dF(),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
GetInputHandler().PinchGestureBegin(gfx::Point(),
ui::ScrollInputType::kWheel);
GetInputHandler().PinchGestureUpdate(page_scale_delta, gfx::Point());
GetInputHandler().PinchGestureEnd(gfx::Point());
GetInputHandler().ScrollEnd();
gfx::Vector2d scroll_delta(0, 10);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(5, 5), scroll_delta,
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), scroll_delta, ui::ScrollInputType::kWheel)
.get());
GetInputHandler().ScrollEnd();
std::unique_ptr<CompositorCommitData> commit_data =
host_impl_->ProcessCompositorDeltas(
/* main_thread_mutator_host */ nullptr);
EXPECT_TRUE(ScrollInfoContains(
*commit_data.get(), scroll_layer->element_id(),
gfx::Vector2dF(0, scroll_delta.y() / page_scale_delta)));
}
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ViewportScrollbarGeometry) {
// Tests for correct behavior of solid color scrollbars on unscrollable pages
// under tricky fractional scale/size issues.
// Nexus 6 viewport size.
const gfx::Size viewport_size(412, 604);
// The content size of a non-scrollable page we'd expect given Android's
// behavior of a 980px layout width on non-mobile pages (often ceiled to 981
// due to fractions resulting from DSF). Due to floating point error,
// viewport_size.height() / minimum_scale ~= 1438.165 < 1439. Ensure we snap
// correctly and err on the side of not showing the scrollbars.
const gfx::Size content_size(981, 1439);
const float minimum_scale =
viewport_size.width() / static_cast<float>(content_size.width());
// Since the page is unscrollable, the outer viewport matches the content
// size.
const gfx::Size outer_viewport_size = content_size;
// Setup
LayerTreeImpl* active_tree = host_impl_->active_tree();
active_tree->PushPageScaleFromMainThread(1, minimum_scale, 4);
// When Chrome on Android loads a non-mobile page, it resizes the main
// frame (outer viewport) such that it matches the width of the content,
// preventing horizontal scrolling. Replicate that behavior here.
SetupViewportLayersInnerScrolls(viewport_size, content_size);
LayerImpl* scroll = OuterViewportScrollLayer();
ASSERT_EQ(GetScrollNode(scroll)->container_bounds, outer_viewport_size);
scroll->SetHitTestable(true);
ClipNode* outer_clip = host_impl_->active_tree()->OuterViewportClipNode();
ASSERT_EQ(gfx::SizeF(outer_viewport_size), outer_clip->clip.size());
// Add scrollbars. They will always exist - even if unscrollable - but their
// visibility will be determined by whether the content can be scrolled.
auto* v_scrollbar = AddLayer<PaintedScrollbarLayerImpl>(
active_tree, ScrollbarOrientation::VERTICAL, false, true);
auto* h_scrollbar = AddLayer<PaintedScrollbarLayerImpl>(
active_tree, ScrollbarOrientation::HORIZONTAL, false, true);
SetupScrollbarLayer(scroll, v_scrollbar);
SetupScrollbarLayer(scroll, h_scrollbar);
host_impl_->active_tree()->DidBecomeActive();
// Zoom out to the minimum scale. The scrollbars shoud not be scrollable.
host_impl_->active_tree()->SetPageScaleOnActiveTree(0);
EXPECT_FALSE(v_scrollbar->CanScrollOrientation());
EXPECT_FALSE(h_scrollbar->CanScrollOrientation());
// Zoom in a little and confirm that they're now scrollable.
host_impl_->active_tree()->SetPageScaleOnActiveTree(minimum_scale * 1.05f);
EXPECT_TRUE(v_scrollbar->CanScrollOrientation());
EXPECT_TRUE(h_scrollbar->CanScrollOrientation());
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ViewportScrollOrder) {
LayerTreeSettings settings = DefaultSettings();
CreateHostImpl(settings, CreateLayerTreeFrameSink());
host_impl_->active_tree()->PushPageScaleFromMainThread(1, 0.25f, 4);
const gfx::Size content_size(1000, 1000);
const gfx::Size viewport_size(500, 500);
SetupViewportLayersOuterScrolls(viewport_size, content_size);
LayerImpl* outer_scroll_layer = OuterViewportScrollLayer();
outer_scroll_layer->SetDrawsContent(true);
LayerImpl* inner_scroll_layer = InnerViewportScrollLayer();
inner_scroll_layer->SetDrawsContent(true);
UpdateDrawProperties(host_impl_->active_tree());
EXPECT_POINTF_EQ(gfx::PointF(500, 500), MaxScrollOffset(outer_scroll_layer));
GetInputHandler().ScrollBegin(
BeginState(gfx::Point(250, 250), gfx::Vector2dF(),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
GetInputHandler().PinchGestureBegin(gfx::Point(),
ui::ScrollInputType::kWheel);
GetInputHandler().PinchGestureUpdate(2, gfx::Point(0, 0));
GetInputHandler().PinchGestureEnd(gfx::Point(0, 0));
GetInputHandler().ScrollEnd();
// Sanity check - we're zoomed in, starting from the origin.
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(outer_scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(inner_scroll_layer));
// Scroll down - only the inner viewport should scroll.
GetInputHandler().ScrollBegin(
BeginState(gfx::Point(0, 0), gfx::Vector2dF(100, 100),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
GetInputHandler().ScrollUpdate(UpdateState(gfx::Point(0, 0),
gfx::Vector2dF(100, 100),
ui::ScrollInputType::kTouchscreen)
.get());
GetInputHandler().ScrollEnd();
EXPECT_POINTF_EQ(gfx::PointF(50, 50),
CurrentScrollOffset(inner_scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(outer_scroll_layer));
// Scroll down - outer viewport should start scrolling after the inner is at
// its maximum.
GetInputHandler().ScrollBegin(
BeginState(gfx::Point(0, 0), gfx::Vector2dF(1000, 1000),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
GetInputHandler().ScrollUpdate(UpdateState(gfx::Point(0, 0),
gfx::Vector2dF(1000, 1000),
ui::ScrollInputType::kTouchscreen)
.get());
GetInputHandler().ScrollEnd();
EXPECT_POINTF_EQ(gfx::PointF(250, 250),
CurrentScrollOffset(inner_scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(300, 300),
CurrentScrollOffset(outer_scroll_layer));
}
// Make sure scrolls smaller than a unit applied to the viewport don't get
// dropped. crbug.com/539334.
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
ScrollViewportWithFractionalAmounts) {
host_impl_->active_tree()->PushPageScaleFromMainThread(1, 1, 2);
const gfx::Size content_size(1000, 1000);
const gfx::Size viewport_size(500, 500);
SetupViewportLayersOuterScrolls(viewport_size, content_size);
LayerImpl* outer_scroll_layer = OuterViewportScrollLayer();
outer_scroll_layer->SetDrawsContent(true);
LayerImpl* inner_scroll_layer = InnerViewportScrollLayer();
inner_scroll_layer->SetDrawsContent(true);
UpdateDrawProperties(host_impl_->active_tree());
// Sanity checks.
EXPECT_POINTF_EQ(gfx::PointF(500, 500), MaxScrollOffset(outer_scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(outer_scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(inner_scroll_layer));
// Scroll only the layout viewport.
GetInputHandler().ScrollBegin(
BeginState(gfx::Point(250, 250), gfx::Vector2dF(0.125f, 0.125f),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
GetInputHandler().ScrollUpdate(UpdateState(gfx::Point(250, 250),
gfx::Vector2dF(0.125f, 0.125f),
ui::ScrollInputType::kTouchscreen)
.get());
EXPECT_POINTF_EQ(gfx::PointF(0.125f, 0.125f),
CurrentScrollOffset(outer_scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(inner_scroll_layer));
GetInputHandler().ScrollEnd();
host_impl_->active_tree()->PushPageScaleFromMainThread(2, 1, 2);
// Now that we zoomed in, the scroll should be applied to the inner viewport.
GetInputHandler().ScrollBegin(
BeginState(gfx::Point(250, 250), gfx::Vector2dF(0.5f, 0.5f),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
GetInputHandler().ScrollUpdate(UpdateState(gfx::Point(250, 250),
gfx::Vector2dF(0.5f, 0.5f),
ui::ScrollInputType::kTouchscreen)
.get());
EXPECT_POINTF_EQ(gfx::PointF(0.125f, 0.125f),
CurrentScrollOffset(outer_scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(0.25f, 0.25f),
CurrentScrollOffset(inner_scroll_layer));
GetInputHandler().ScrollEnd();
}
// Tests that scrolls during a pinch gesture (i.e. "two-finger" scrolls) work
// as expected. That is, scrolling during a pinch should bubble from the inner
// to the outer viewport.
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollDuringPinchGesture) {
LayerTreeSettings settings = DefaultSettings();
CreateHostImpl(settings, CreateLayerTreeFrameSink());
host_impl_->active_tree()->PushPageScaleFromMainThread(1, 1, 2);
const gfx::Size content_size(1000, 1000);
const gfx::Size viewport_size(500, 500);
SetupViewportLayersOuterScrolls(viewport_size, content_size);
LayerImpl* outer_scroll_layer = OuterViewportScrollLayer();
outer_scroll_layer->SetDrawsContent(true);
LayerImpl* inner_scroll_layer = InnerViewportScrollLayer();
inner_scroll_layer->SetDrawsContent(true);
UpdateDrawProperties(host_impl_->active_tree());
EXPECT_POINTF_EQ(gfx::PointF(500, 500), MaxScrollOffset(outer_scroll_layer));
GetInputHandler().ScrollBegin(
BeginState(gfx::Point(250, 250), gfx::Vector2dF(),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
GetInputHandler().PinchGestureBegin(gfx::Point(250, 250),
ui::ScrollInputType::kWheel);
GetInputHandler().PinchGestureUpdate(2, gfx::Point(250, 250));
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(outer_scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(125, 125),
CurrentScrollOffset(inner_scroll_layer));
// Needed so that the pinch is accounted for in draw properties.
DrawFrame();
GetInputHandler().ScrollUpdate(UpdateState(gfx::Point(250, 250),
gfx::Vector2dF(10, 10),
ui::ScrollInputType::kTouchscreen)
.get());
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(outer_scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(130, 130),
CurrentScrollOffset(inner_scroll_layer));
DrawFrame();
GetInputHandler().ScrollUpdate(UpdateState(gfx::Point(250, 250),
gfx::Vector2dF(400, 400),
ui::ScrollInputType::kTouchscreen)
.get());
EXPECT_POINTF_EQ(gfx::PointF(80, 80),
CurrentScrollOffset(outer_scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(250, 250),
CurrentScrollOffset(inner_scroll_layer));
GetInputHandler().PinchGestureEnd(gfx::Point(250, 250));
GetInputHandler().ScrollEnd();
}
// Tests the "snapping" of pinch-zoom gestures to the screen edge. That is, when
// a pinch zoom is anchored within a certain margin of the screen edge, we
// should assume the user means to scroll into the edge of the screen.
TEST_P(ScrollUnifiedLayerTreeHostImplTest, PinchZoomSnapsToScreenEdge) {
LayerTreeSettings settings = DefaultSettings();
CreateHostImpl(settings, CreateLayerTreeFrameSink());
host_impl_->active_tree()->PushPageScaleFromMainThread(1, 1, 2);
const gfx::Size content_size(1000, 1000);
const gfx::Size viewport_size(500, 500);
SetupViewportLayersOuterScrolls(viewport_size, content_size);
int offsetFromEdge = Viewport::kPinchZoomSnapMarginDips - 5;
gfx::Point anchor(viewport_size.width() - offsetFromEdge,
viewport_size.height() - offsetFromEdge);
// Pinch in within the margins. The scroll should stay exactly locked to the
// bottom and right.
GetInputHandler().ScrollBegin(
BeginState(anchor, gfx::Vector2dF(), ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
GetInputHandler().PinchGestureBegin(anchor, ui::ScrollInputType::kWheel);
GetInputHandler().PinchGestureUpdate(2, anchor);
GetInputHandler().PinchGestureEnd(anchor);
GetInputHandler().ScrollEnd();
EXPECT_POINTF_EQ(gfx::PointF(250, 250),
CurrentScrollOffset(InnerViewportScrollLayer()));
// Reset.
host_impl_->active_tree()->SetPageScaleOnActiveTree(1);
SetScrollOffsetDelta(InnerViewportScrollLayer(), gfx::Vector2d());
SetScrollOffsetDelta(OuterViewportScrollLayer(), gfx::Vector2d());
// Pinch in within the margins. The scroll should stay exactly locked to the
// top and left.
anchor = gfx::Point(offsetFromEdge, offsetFromEdge);
GetInputHandler().ScrollBegin(
BeginState(anchor, gfx::Vector2dF(), ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
GetInputHandler().PinchGestureBegin(gfx::Point(100, 100),
ui::ScrollInputType::kWheel);
GetInputHandler().PinchGestureUpdate(2, anchor);
GetInputHandler().PinchGestureEnd(anchor);
GetInputHandler().ScrollEnd();
EXPECT_POINTF_EQ(gfx::PointF(0, 0),
CurrentScrollOffset(InnerViewportScrollLayer()));
// Reset.
host_impl_->active_tree()->SetPageScaleOnActiveTree(1);
SetScrollOffsetDelta(InnerViewportScrollLayer(), gfx::Vector2d());
SetScrollOffsetDelta(OuterViewportScrollLayer(), gfx::Vector2d());
// Pinch in just outside the margin. There should be no snapping.
offsetFromEdge = Viewport::kPinchZoomSnapMarginDips;
anchor = gfx::Point(offsetFromEdge, offsetFromEdge);
GetInputHandler().ScrollBegin(
BeginState(anchor, gfx::Vector2dF(), ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
GetInputHandler().PinchGestureBegin(anchor, ui::ScrollInputType::kWheel);
GetInputHandler().PinchGestureUpdate(2, anchor);
GetInputHandler().PinchGestureEnd(anchor);
GetInputHandler().ScrollEnd();
EXPECT_POINTF_EQ(gfx::PointF(50, 50),
CurrentScrollOffset(InnerViewportScrollLayer()));
// Reset.
host_impl_->active_tree()->SetPageScaleOnActiveTree(1);
SetScrollOffsetDelta(InnerViewportScrollLayer(), gfx::Vector2d());
SetScrollOffsetDelta(OuterViewportScrollLayer(), gfx::Vector2d());
// Pinch in just outside the margin. There should be no snapping.
offsetFromEdge = Viewport::kPinchZoomSnapMarginDips;
anchor = gfx::Point(viewport_size.width() - offsetFromEdge,
viewport_size.height() - offsetFromEdge);
GetInputHandler().ScrollBegin(
BeginState(anchor, gfx::Vector2dF(), ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
GetInputHandler().PinchGestureBegin(anchor, ui::ScrollInputType::kWheel);
GetInputHandler().PinchGestureUpdate(2, anchor);
GetInputHandler().PinchGestureEnd(anchor);
GetInputHandler().ScrollEnd();
EXPECT_POINTF_EQ(gfx::PointF(200, 200),
CurrentScrollOffset(InnerViewportScrollLayer()));
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
ImplPinchZoomWheelBubbleBetweenViewports) {
const gfx::Size content_size(200, 200);
const gfx::Size viewport_size(100, 100);
SetupViewportLayersOuterScrolls(viewport_size, content_size);
LayerImpl* outer_scroll_layer = OuterViewportScrollLayer();
LayerImpl* inner_scroll_layer = InnerViewportScrollLayer();
// Zoom into the page by a 2X factor
float min_page_scale = 1, max_page_scale = 4;
float page_scale_factor = 2;
host_impl_->active_tree()->PushPageScaleFromMainThread(
page_scale_factor, min_page_scale, max_page_scale);
host_impl_->active_tree()->SetPageScaleOnActiveTree(page_scale_factor);
// Scroll by a small amount, there should be no bubbling to the outer
// viewport.
GetInputHandler().ScrollBegin(
BeginState(gfx::Point(0, 0), gfx::Vector2dF(10, 20),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
GetInputHandler().ScrollUpdate(UpdateState(gfx::Point(0, 0),
gfx::Vector2dF(10, 20),
ui::ScrollInputType::kWheel)
.get());
GetInputHandler().ScrollEnd();
EXPECT_POINTF_EQ(gfx::PointF(5, 10), CurrentScrollOffset(inner_scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(outer_scroll_layer));
// Scroll by the inner viewport's max scroll extent, the remainder
// should bubble up to the outer viewport.
GetInputHandler().ScrollBegin(
BeginState(gfx::Point(0, 0), gfx::Vector2dF(100, 100),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
GetInputHandler().ScrollUpdate(UpdateState(gfx::Point(0, 0),
gfx::Vector2dF(100, 100),
ui::ScrollInputType::kWheel)
.get());
GetInputHandler().ScrollEnd();
EXPECT_POINTF_EQ(gfx::PointF(50, 50),
CurrentScrollOffset(inner_scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(5, 10), CurrentScrollOffset(outer_scroll_layer));
// Scroll by the outer viewport's max scroll extent, it should all go to the
// outer viewport.
GetInputHandler().ScrollBegin(
BeginState(gfx::Point(0, 0), gfx::Vector2dF(190, 180),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
GetInputHandler().ScrollUpdate(UpdateState(gfx::Point(0, 0),
gfx::Vector2dF(190, 180),
ui::ScrollInputType::kWheel)
.get());
GetInputHandler().ScrollEnd();
EXPECT_POINTF_EQ(gfx::PointF(100, 100),
CurrentScrollOffset(outer_scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(50, 50),
CurrentScrollOffset(inner_scroll_layer));
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollWithSwapPromises) {
ui::LatencyInfo latency_info;
latency_info.set_trace_id(5);
latency_info.AddLatencyNumber(ui::INPUT_EVENT_LATENCY_BEGIN_RWH_COMPONENT);
std::unique_ptr<SwapPromise> swap_promise(
new LatencyInfoSwapPromise(latency_info));
SetupViewportLayersInnerScrolls(gfx::Size(50, 50), gfx::Size(100, 100));
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), gfx::Vector2d(0, 10),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
GetInputHandler().ScrollUpdate(UpdateState(gfx::Point(), gfx::Vector2d(0, 10),
ui::ScrollInputType::kTouchscreen)
.get());
host_impl_->QueueSwapPromiseForMainThreadScrollUpdate(
std::move(swap_promise));
GetInputHandler().ScrollEnd();
std::unique_ptr<CompositorCommitData> commit_data =
host_impl_->ProcessCompositorDeltas(
/* main_thread_mutator_host */ nullptr);
EXPECT_EQ(1u, commit_data->swap_promises.size());
EXPECT_EQ(latency_info.trace_id(),
commit_data->swap_promises[0]->GetTraceId());
}
// Test that scrolls targeting a layer with a non-null scroll_parent() don't
// bubble up.
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollDoesntBubble) {
SetupViewportLayersInnerScrolls(gfx::Size(50, 50), gfx::Size(100, 100));
LayerImpl* viewport_scroll = InnerViewportScrollLayer();
// Set up two scrolling children of the root, one of which is a scroll parent
// to the other. Scrolls shouldn't bubbling from the child.
LayerImpl* scroll_parent =
AddScrollableLayer(viewport_scroll, gfx::Size(5, 5), gfx::Size(10, 10));
LayerImpl* scroll_child_clip = AddLayer();
// scroll_child_clip scrolls in scroll_parent, but under viewport_scroll's
// effect.
CopyProperties(scroll_parent, scroll_child_clip);
scroll_child_clip->SetEffectTreeIndex(viewport_scroll->effect_tree_index());
LayerImpl* scroll_child =
AddScrollableLayer(scroll_child_clip, gfx::Size(5, 5), gfx::Size(10, 10));
GetTransformNode(scroll_child)->post_translation = gfx::Vector2d(20, 20);
DrawFrame();
{
GetInputHandler().ScrollBegin(
BeginState(gfx::Point(21, 21), gfx::Vector2d(5, 5),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(21, 21), gfx::Vector2d(5, 5),
ui::ScrollInputType::kTouchscreen)
.get());
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(21, 21), gfx::Vector2d(100, 100),
ui::ScrollInputType::kTouchscreen)
.get());
GetInputHandler().ScrollEnd();
// The child should be fully scrolled by the first ScrollUpdate.
EXPECT_POINTF_EQ(gfx::PointF(5, 5), CurrentScrollOffset(scroll_child));
// The scroll_parent shouldn't receive the second ScrollUpdate.
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(scroll_parent));
// The viewport shouldn't have been scrolled at all.
EXPECT_POINTF_EQ(gfx::PointF(0, 0),
CurrentScrollOffset(InnerViewportScrollLayer()));
EXPECT_POINTF_EQ(gfx::PointF(0, 0),
CurrentScrollOffset(OuterViewportScrollLayer()));
}
{
GetInputHandler().ScrollBegin(
BeginState(gfx::Point(21, 21), gfx::Vector2d(3, 4),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(21, 21), gfx::Vector2d(3, 4),
ui::ScrollInputType::kTouchscreen)
.get());
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(21, 21), gfx::Vector2d(2, 1),
ui::ScrollInputType::kTouchscreen)
.get());
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(21, 21), gfx::Vector2d(2, 1),
ui::ScrollInputType::kTouchscreen)
.get());
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(21, 21), gfx::Vector2d(2, 1),
ui::ScrollInputType::kTouchscreen)
.get());
GetInputHandler().ScrollEnd();
// The ScrollUpdate's should scroll the parent to its extent.
EXPECT_POINTF_EQ(gfx::PointF(5, 5), CurrentScrollOffset(scroll_parent));
// The viewport shouldn't receive any scroll delta.
EXPECT_POINTF_EQ(gfx::PointF(0, 0),
CurrentScrollOffset(InnerViewportScrollLayer()));
EXPECT_POINTF_EQ(gfx::PointF(0, 0),
CurrentScrollOffset(OuterViewportScrollLayer()));
}
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, PinchGesture) {
SetupViewportLayersInnerScrolls(gfx::Size(50, 50), gfx::Size(100, 100));
DrawFrame();
LayerImpl* scroll_layer = InnerViewportScrollLayer();
DCHECK(scroll_layer);
float min_page_scale = 1;
float max_page_scale = 4;
// Basic pinch zoom in gesture
{
host_impl_->active_tree()->PushPageScaleFromMainThread(1, min_page_scale,
max_page_scale);
SetScrollOffsetDelta(scroll_layer, gfx::Vector2d());
float page_scale_delta = 2;
GetInputHandler().ScrollBegin(
BeginState(gfx::Point(50, 50), gfx::Vector2dF(),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
GetInputHandler().PinchGestureBegin(gfx::Point(50, 50),
ui::ScrollInputType::kWheel);
GetInputHandler().PinchGestureUpdate(page_scale_delta, gfx::Point(50, 50));
GetInputHandler().PinchGestureEnd(gfx::Point(50, 50));
GetInputHandler().ScrollEnd();
EXPECT_FALSE(did_request_next_frame_);
EXPECT_TRUE(did_request_redraw_);
EXPECT_TRUE(did_request_commit_);
std::unique_ptr<CompositorCommitData> commit_data =
host_impl_->ProcessCompositorDeltas(
/* main_thread_mutator_host */ nullptr);
EXPECT_EQ(commit_data->page_scale_delta, page_scale_delta);
ClearMainThreadDeltasForTesting(host_impl_.get());
}
// Zoom-in clamping
{
host_impl_->active_tree()->PushPageScaleFromMainThread(1, min_page_scale,
max_page_scale);
SetScrollOffsetDelta(scroll_layer, gfx::Vector2d());
float page_scale_delta = 10;
GetInputHandler().ScrollBegin(
BeginState(gfx::Point(50, 50), gfx::Vector2dF(),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
GetInputHandler().PinchGestureBegin(gfx::Point(50, 50),
ui::ScrollInputType::kWheel);
GetInputHandler().PinchGestureUpdate(page_scale_delta, gfx::Point(50, 50));
GetInputHandler().PinchGestureEnd(gfx::Point(50, 50));
GetInputHandler().ScrollEnd();
std::unique_ptr<CompositorCommitData> commit_data =
host_impl_->ProcessCompositorDeltas(
/* main_thread_mutator_host */ nullptr);
EXPECT_EQ(commit_data->page_scale_delta, max_page_scale);
ClearMainThreadDeltasForTesting(host_impl_.get());
}
// Zoom-out clamping
{
host_impl_->active_tree()->PushPageScaleFromMainThread(1, min_page_scale,
max_page_scale);
SetScrollOffsetDelta(scroll_layer, gfx::Vector2d());
scroll_layer->layer_tree_impl()
->property_trees()
->scroll_tree_mutable()
.CollectScrollDeltasForTesting();
ClearMainThreadDeltasForTesting(host_impl_.get());
scroll_layer->layer_tree_impl()
->property_trees()
->scroll_tree_mutable()
.UpdateScrollOffsetBaseForTesting(scroll_layer->element_id(),
gfx::PointF(50, 50));
float page_scale_delta = 0.1f;
GetInputHandler().ScrollBegin(BeginState(gfx::Point(), gfx::Vector2dF(),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
GetInputHandler().PinchGestureBegin(gfx::Point(),
ui::ScrollInputType::kWheel);
GetInputHandler().PinchGestureUpdate(page_scale_delta, gfx::Point());
GetInputHandler().PinchGestureEnd(gfx::Point());
GetInputHandler().ScrollEnd();
std::unique_ptr<CompositorCommitData> commit_data =
host_impl_->ProcessCompositorDeltas(
/* main_thread_mutator_host */ nullptr);
EXPECT_EQ(commit_data->page_scale_delta, min_page_scale);
EXPECT_TRUE(commit_data->scrolls.empty());
ClearMainThreadDeltasForTesting(host_impl_.get());
}
// Two-finger panning should not happen based on pinch events only
{
host_impl_->active_tree()->PushPageScaleFromMainThread(1, min_page_scale,
max_page_scale);
SetScrollOffsetDelta(scroll_layer, gfx::Vector2d());
scroll_layer->layer_tree_impl()
->property_trees()
->scroll_tree_mutable()
.CollectScrollDeltasForTesting();
ClearMainThreadDeltasForTesting(host_impl_.get());
scroll_layer->layer_tree_impl()
->property_trees()
->scroll_tree_mutable()
.UpdateScrollOffsetBaseForTesting(scroll_layer->element_id(),
gfx::PointF(20, 20));
float page_scale_delta = 1;
GetInputHandler().ScrollBegin(
BeginState(gfx::Point(10, 10), gfx::Vector2dF(),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
GetInputHandler().PinchGestureBegin(gfx::Point(10, 10),
ui::ScrollInputType::kWheel);
GetInputHandler().PinchGestureUpdate(page_scale_delta, gfx::Point(10, 10));
GetInputHandler().PinchGestureUpdate(page_scale_delta, gfx::Point(20, 20));
GetInputHandler().PinchGestureEnd(gfx::Point(20, 20));
GetInputHandler().ScrollEnd();
std::unique_ptr<CompositorCommitData> commit_data =
host_impl_->ProcessCompositorDeltas(
/* main_thread_mutator_host */ nullptr);
EXPECT_EQ(commit_data->page_scale_delta, page_scale_delta);
EXPECT_TRUE(commit_data->scrolls.empty());
ClearMainThreadDeltasForTesting(host_impl_.get());
}
// Two-finger panning should work with interleaved scroll events
{
host_impl_->active_tree()->PushPageScaleFromMainThread(1, min_page_scale,
max_page_scale);
SetScrollOffsetDelta(scroll_layer, gfx::Vector2d());
scroll_layer->layer_tree_impl()
->property_trees()
->scroll_tree_mutable()
.CollectScrollDeltasForTesting();
ClearMainThreadDeltasForTesting(host_impl_.get());
scroll_layer->layer_tree_impl()
->property_trees()
->scroll_tree_mutable()
.UpdateScrollOffsetBaseForTesting(scroll_layer->element_id(),
gfx::PointF(20, 20));
float page_scale_delta = 1;
GetInputHandler().ScrollBegin(
BeginState(gfx::Point(10, 10), gfx::Vector2dF(-10, -10),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
GetInputHandler().PinchGestureBegin(gfx::Point(10, 10),
ui::ScrollInputType::kWheel);
GetInputHandler().PinchGestureUpdate(page_scale_delta, gfx::Point(10, 10));
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(10, 10), gfx::Vector2d(-10, -10),
ui::ScrollInputType::kTouchscreen)
.get());
GetInputHandler().PinchGestureUpdate(page_scale_delta, gfx::Point(20, 20));
GetInputHandler().PinchGestureEnd(gfx::Point(20, 20));
GetInputHandler().ScrollEnd();
std::unique_ptr<CompositorCommitData> commit_data =
host_impl_->ProcessCompositorDeltas(
/* main_thread_mutator_host */ nullptr);
EXPECT_EQ(commit_data->page_scale_delta, page_scale_delta);
EXPECT_TRUE(ScrollInfoContains(*commit_data, scroll_layer->element_id(),
gfx::Vector2dF(-10, -10)));
ClearMainThreadDeltasForTesting(host_impl_.get());
}
// Two-finger panning should work when starting fully zoomed out.
{
host_impl_->active_tree()->PushPageScaleFromMainThread(0.5f, 0.5f, 4);
SetScrollOffsetDelta(scroll_layer, gfx::Vector2d());
scroll_layer->layer_tree_impl()
->property_trees()
->scroll_tree_mutable()
.CollectScrollDeltasForTesting();
ClearMainThreadDeltasForTesting(host_impl_.get());
scroll_layer->layer_tree_impl()
->property_trees()
->scroll_tree_mutable()
.UpdateScrollOffsetBaseForTesting(scroll_layer->element_id(),
gfx::PointF(0, 0));
GetInputHandler().ScrollBegin(BeginState(gfx::Point(0, 0), gfx::Vector2dF(),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
GetInputHandler().PinchGestureBegin(gfx::Point(0, 0),
ui::ScrollInputType::kWheel);
GetInputHandler().PinchGestureUpdate(2, gfx::Point(0, 0));
GetInputHandler().PinchGestureUpdate(1, gfx::Point(0, 0));
// Needed so layer transform includes page scale.
DrawFrame();
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(0, 0), gfx::Vector2d(10, 10),
ui::ScrollInputType::kTouchscreen)
.get());
GetInputHandler().PinchGestureUpdate(1, gfx::Point(10, 10));
GetInputHandler().PinchGestureEnd(gfx::Point(10, 10));
GetInputHandler().ScrollEnd();
std::unique_ptr<CompositorCommitData> commit_data =
host_impl_->ProcessCompositorDeltas(
/* main_thread_mutator_host */ nullptr);
EXPECT_EQ(commit_data->page_scale_delta, 2);
EXPECT_TRUE(ScrollInfoContains(*commit_data, scroll_layer->element_id(),
gfx::Vector2dF(10, 10)));
}
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, SyncSubpixelScrollDelta) {
SetupViewportLayersInnerScrolls(gfx::Size(50, 50), gfx::Size(100, 100));
DrawFrame();
LayerImpl* scroll_layer = InnerViewportScrollLayer();
DCHECK(scroll_layer);
float min_page_scale = 1;
float max_page_scale = 4;
host_impl_->active_tree()->PushPageScaleFromMainThread(1, min_page_scale,
max_page_scale);
SetScrollOffsetDelta(scroll_layer, gfx::Vector2d());
scroll_layer->layer_tree_impl()
->property_trees()
->scroll_tree_mutable()
.CollectScrollDeltasForTesting();
ClearMainThreadDeltasForTesting(host_impl_.get());
scroll_layer->layer_tree_impl()
->property_trees()
->scroll_tree_mutable()
.UpdateScrollOffsetBaseForTesting(scroll_layer->element_id(),
gfx::PointF(0, 20));
float page_scale_delta = 1;
GetInputHandler().ScrollBegin(BeginState(gfx::Point(10, 10), gfx::Vector2dF(),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
GetInputHandler().PinchGestureBegin(gfx::Point(10, 10),
ui::ScrollInputType::kWheel);
GetInputHandler().PinchGestureUpdate(page_scale_delta, gfx::Point(10, 10));
GetInputHandler().ScrollUpdate(UpdateState(gfx::Point(10, 10),
gfx::Vector2dF(0, -1.001f),
ui::ScrollInputType::kTouchscreen)
.get());
GetInputHandler().PinchGestureUpdate(page_scale_delta, gfx::Point(10, 9));
GetInputHandler().PinchGestureEnd(gfx::Point(10, 9));
GetInputHandler().ScrollEnd();
std::unique_ptr<CompositorCommitData> commit_data =
host_impl_->ProcessCompositorDeltas(
/* main_thread_mutator_host */ nullptr);
EXPECT_EQ(commit_data->page_scale_delta, page_scale_delta);
EXPECT_TRUE(ScrollInfoContains(*commit_data, scroll_layer->element_id(),
gfx::Vector2dF(0, -1)));
// Verify this scroll delta is consistent with the snapped position of the
// scroll layer.
draw_property_utils::ComputeTransforms(
&scroll_layer->layer_tree_impl()
->property_trees()
->transform_tree_mutable(),
scroll_layer->layer_tree_impl()->viewport_property_ids());
EXPECT_VECTOR2DF_EQ(gfx::Vector2dF(0, -19),
scroll_layer->ScreenSpaceTransform().To2dTranslation());
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
SyncSubpixelScrollFromFractionalActiveBase) {
SetupViewportLayersInnerScrolls(gfx::Size(50, 50), gfx::Size(100, 100));
DrawFrame();
LayerImpl* scroll_layer = InnerViewportScrollLayer();
DCHECK(scroll_layer);
SetScrollOffsetDelta(scroll_layer, gfx::Vector2d());
scroll_layer->layer_tree_impl()
->property_trees()
->scroll_tree_mutable()
.CollectScrollDeltasForTesting();
ClearMainThreadDeltasForTesting(host_impl_.get());
scroll_layer->layer_tree_impl()
->property_trees()
->scroll_tree_mutable()
.UpdateScrollOffsetBaseForTesting(scroll_layer->element_id(),
gfx::PointF(0, 20.5f));
GetInputHandler().ScrollBegin(
BeginState(gfx::Point(10, 10), gfx::Vector2dF(0, -1),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
GetInputHandler().ScrollUpdate(UpdateState(gfx::Point(10, 10),
gfx::Vector2dF(0, -1),
ui::ScrollInputType::kWheel)
.get());
GetInputHandler().ScrollEnd();
gfx::PointF active_base =
host_impl_->active_tree()
->property_trees()
->scroll_tree()
.GetScrollOffsetBaseForTesting(scroll_layer->element_id());
EXPECT_POINTF_EQ(active_base, gfx::PointF(0, 20.5));
// Fractional active base should not affect the scroll delta.
std::unique_ptr<CompositorCommitData> commit_data =
host_impl_->ProcessCompositorDeltas(
/* main_thread_mutator_host */ nullptr);
EXPECT_VECTOR2DF_EQ(gfx::Vector2dF(0, -1),
commit_data->inner_viewport_scroll.scroll_delta);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
PinchZoomTriggersPageScaleAnimation) {
SetupViewportLayersInnerScrolls(gfx::Size(50, 50), gfx::Size(100, 100));
DrawFrame();
float min_page_scale = 1;
float max_page_scale = 4;
float page_scale_delta = 1.04f;
base::TimeTicks start_time = base::TimeTicks() + base::Seconds(1);
base::TimeDelta duration = base::Milliseconds(200);
base::TimeTicks halfway_through_animation = start_time + duration / 2;
base::TimeTicks end_time = start_time + duration;
viz::BeginFrameArgs begin_frame_args =
viz::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, 0, 1);
// Zoom animation if page_scale is < 1.05 * min_page_scale.
{
host_impl_->active_tree()->PushPageScaleFromMainThread(1, min_page_scale,
max_page_scale);
did_request_redraw_ = false;
did_request_next_frame_ = false;
GetInputHandler().PinchGestureBegin(gfx::Point(50, 50),
ui::ScrollInputType::kWheel);
GetInputHandler().PinchGestureUpdate(page_scale_delta, gfx::Point(50, 50));
GetInputHandler().PinchGestureEnd(gfx::Point(50, 50));
host_impl_->ActivateSyncTree();
EXPECT_TRUE(did_request_redraw_);
EXPECT_TRUE(did_request_next_frame_);
did_request_redraw_ = false;
did_request_next_frame_ = false;
begin_frame_args.frame_time = start_time;
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
EXPECT_TRUE(did_request_redraw_);
EXPECT_TRUE(did_request_next_frame_);
host_impl_->DidFinishImplFrame(begin_frame_args);
did_request_redraw_ = false;
did_request_next_frame_ = false;
begin_frame_args.frame_time = halfway_through_animation;
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
EXPECT_TRUE(did_request_redraw_);
EXPECT_TRUE(did_request_next_frame_);
host_impl_->DidFinishImplFrame(begin_frame_args);
did_request_redraw_ = false;
did_request_next_frame_ = false;
did_request_commit_ = false;
begin_frame_args.frame_time = end_time;
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
EXPECT_TRUE(did_request_commit_);
EXPECT_FALSE(did_request_next_frame_);
host_impl_->DidFinishImplFrame(begin_frame_args);
std::unique_ptr<CompositorCommitData> commit_data =
host_impl_->ProcessCompositorDeltas(
/* main_thread_mutator_host */ nullptr);
EXPECT_EQ(commit_data->page_scale_delta, 1);
ClearMainThreadDeltasForTesting(host_impl_.get());
}
start_time += base::Seconds(10);
halfway_through_animation += base::Seconds(10);
end_time += base::Seconds(10);
page_scale_delta = 1.06f;
// No zoom animation if page_scale is >= 1.05 * min_page_scale.
{
host_impl_->active_tree()->PushPageScaleFromMainThread(1, min_page_scale,
max_page_scale);
did_request_redraw_ = false;
did_request_next_frame_ = false;
GetInputHandler().PinchGestureBegin(gfx::Point(50, 50),
ui::ScrollInputType::kWheel);
GetInputHandler().PinchGestureUpdate(page_scale_delta, gfx::Point(50, 50));
GetInputHandler().PinchGestureEnd(gfx::Point(50, 50));
host_impl_->ActivateSyncTree();
EXPECT_TRUE(did_request_redraw_);
EXPECT_FALSE(did_request_next_frame_);
did_request_redraw_ = false;
did_request_next_frame_ = false;
begin_frame_args.frame_time = start_time;
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
EXPECT_FALSE(did_request_redraw_);
EXPECT_FALSE(did_request_next_frame_);
host_impl_->DidFinishImplFrame(begin_frame_args);
did_request_redraw_ = false;
did_request_next_frame_ = false;
begin_frame_args.frame_time = halfway_through_animation;
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
EXPECT_FALSE(did_request_redraw_);
EXPECT_FALSE(did_request_next_frame_);
host_impl_->DidFinishImplFrame(begin_frame_args);
did_request_redraw_ = false;
did_request_next_frame_ = false;
did_request_commit_ = false;
begin_frame_args.frame_time = end_time;
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
EXPECT_FALSE(did_request_commit_);
EXPECT_FALSE(did_request_next_frame_);
host_impl_->DidFinishImplFrame(begin_frame_args);
std::unique_ptr<CompositorCommitData> commit_data =
host_impl_->ProcessCompositorDeltas(
/* main_thread_mutator_host */ nullptr);
EXPECT_EQ(commit_data->page_scale_delta, page_scale_delta);
}
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, PageScaleAnimation) {
SetupViewportLayersInnerScrolls(gfx::Size(50, 50), gfx::Size(100, 100));
DrawFrame();
LayerImpl* scroll_layer = InnerViewportScrollLayer();
DCHECK(scroll_layer);
float min_page_scale = 0.5f;
float max_page_scale = 4;
base::TimeTicks start_time = base::TimeTicks() + base::Seconds(1);
base::TimeDelta duration = base::Milliseconds(100);
base::TimeTicks halfway_through_animation = start_time + duration / 2;
base::TimeTicks end_time = start_time + duration;
viz::BeginFrameArgs begin_frame_args =
viz::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, 0, 1);
// Non-anchor zoom-in
{
host_impl_->active_tree()->PushPageScaleFromMainThread(1, min_page_scale,
max_page_scale);
scroll_layer->layer_tree_impl()
->property_trees()
->scroll_tree_mutable()
.UpdateScrollOffsetBaseForTesting(scroll_layer->element_id(),
gfx::PointF(50, 50));
did_request_redraw_ = false;
did_request_next_frame_ = false;
host_impl_->active_tree()->SetPendingPageScaleAnimation(
std::make_unique<PendingPageScaleAnimation>(gfx::Point(), false, 2,
duration));
host_impl_->ActivateSyncTree();
EXPECT_FALSE(did_request_redraw_);
EXPECT_TRUE(did_request_next_frame_);
did_request_redraw_ = false;
did_request_next_frame_ = false;
begin_frame_args.frame_time = start_time;
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
EXPECT_TRUE(did_request_redraw_);
EXPECT_TRUE(did_request_next_frame_);
host_impl_->DidFinishImplFrame(begin_frame_args);
did_request_redraw_ = false;
did_request_next_frame_ = false;
begin_frame_args.frame_time = halfway_through_animation;
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
EXPECT_TRUE(did_request_redraw_);
EXPECT_TRUE(did_request_next_frame_);
host_impl_->DidFinishImplFrame(begin_frame_args);
did_request_redraw_ = false;
did_request_next_frame_ = false;
did_request_commit_ = false;
begin_frame_args.frame_time = end_time;
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
EXPECT_TRUE(did_request_commit_);
EXPECT_FALSE(did_request_next_frame_);
host_impl_->DidFinishImplFrame(begin_frame_args);
std::unique_ptr<CompositorCommitData> commit_data =
host_impl_->ProcessCompositorDeltas(
/* main_thread_mutator_host */ nullptr);
EXPECT_EQ(commit_data->page_scale_delta, 2);
EXPECT_TRUE(ScrollInfoContains(*commit_data, scroll_layer->element_id(),
gfx::Vector2dF(-50, -50)));
ClearMainThreadDeltasForTesting(host_impl_.get());
}
start_time += base::Seconds(10);
halfway_through_animation += base::Seconds(10);
end_time += base::Seconds(10);
// Anchor zoom-out
{
host_impl_->active_tree()->PushPageScaleFromMainThread(1, min_page_scale,
max_page_scale);
scroll_layer->layer_tree_impl()
->property_trees()
->scroll_tree_mutable()
.UpdateScrollOffsetBaseForTesting(scroll_layer->element_id(),
gfx::PointF(50, 50));
did_request_redraw_ = false;
did_request_next_frame_ = false;
host_impl_->active_tree()->SetPendingPageScaleAnimation(
std::make_unique<PendingPageScaleAnimation>(gfx::Point(25, 25), true,
min_page_scale, duration));
host_impl_->ActivateSyncTree();
EXPECT_FALSE(did_request_redraw_);
EXPECT_TRUE(did_request_next_frame_);
did_request_redraw_ = false;
did_request_next_frame_ = false;
begin_frame_args.frame_time = start_time;
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
EXPECT_TRUE(did_request_redraw_);
EXPECT_TRUE(did_request_next_frame_);
host_impl_->DidFinishImplFrame(begin_frame_args);
did_request_redraw_ = false;
did_request_commit_ = false;
did_request_next_frame_ = false;
begin_frame_args.frame_time = end_time;
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
EXPECT_TRUE(did_request_redraw_);
EXPECT_FALSE(did_request_next_frame_);
EXPECT_TRUE(did_request_commit_);
host_impl_->DidFinishImplFrame(begin_frame_args);
std::unique_ptr<CompositorCommitData> commit_data =
host_impl_->ProcessCompositorDeltas(
/* main_thread_mutator_host */ nullptr);
EXPECT_EQ(commit_data->page_scale_delta, min_page_scale);
// Pushed to (0,0) via clamping against contents layer size.
EXPECT_TRUE(ScrollInfoContains(*commit_data, scroll_layer->element_id(),
gfx::Vector2dF(-50, -50)));
}
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, PageScaleAnimationNoOp) {
SetupViewportLayersInnerScrolls(gfx::Size(50, 50), gfx::Size(100, 100));
DrawFrame();
LayerImpl* scroll_layer = InnerViewportScrollLayer();
DCHECK(scroll_layer);
float min_page_scale = 0.5f;
float max_page_scale = 4;
base::TimeTicks start_time = base::TimeTicks() + base::Seconds(1);
base::TimeDelta duration = base::Milliseconds(100);
base::TimeTicks halfway_through_animation = start_time + duration / 2;
base::TimeTicks end_time = start_time + duration;
viz::BeginFrameArgs begin_frame_args =
viz::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, 0, 1);
// Anchor zoom with unchanged page scale should not change scroll or scale.
{
host_impl_->active_tree()->PushPageScaleFromMainThread(1, min_page_scale,
max_page_scale);
scroll_layer->layer_tree_impl()
->property_trees()
->scroll_tree_mutable()
.UpdateScrollOffsetBaseForTesting(scroll_layer->element_id(),
gfx::PointF(50, 50));
host_impl_->active_tree()->SetPendingPageScaleAnimation(
std::make_unique<PendingPageScaleAnimation>(gfx::Point(), true, 1,
duration));
host_impl_->ActivateSyncTree();
begin_frame_args.frame_time = start_time;
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
host_impl_->DidFinishImplFrame(begin_frame_args);
begin_frame_args.frame_time = halfway_through_animation;
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
EXPECT_TRUE(did_request_redraw_);
host_impl_->DidFinishImplFrame(begin_frame_args);
begin_frame_args.frame_time = end_time;
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
EXPECT_TRUE(did_request_commit_);
host_impl_->DidFinishImplFrame(begin_frame_args);
std::unique_ptr<CompositorCommitData> commit_data =
host_impl_->ProcessCompositorDeltas(
/* main_thread_mutator_host */ nullptr);
EXPECT_EQ(commit_data->page_scale_delta, 1);
ExpectNone(*commit_data, scroll_layer->element_id());
}
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
PageScaleAnimationTransferedOnSyncTreeActivate) {
CreatePendingTree();
host_impl_->pending_tree()->PushPageScaleFromMainThread(1, 1, 1);
SetupViewportLayers(host_impl_->pending_tree(), gfx::Size(50, 50),
gfx::Size(100, 100), gfx::Size(100, 100));
host_impl_->ActivateSyncTree();
DrawFrame();
LayerImpl* scroll_layer = InnerViewportScrollLayer();
DCHECK(scroll_layer);
float min_page_scale = 0.5f;
float max_page_scale = 4;
host_impl_->sync_tree()->PushPageScaleFromMainThread(1, min_page_scale,
max_page_scale);
host_impl_->ActivateSyncTree();
base::TimeTicks start_time = base::TimeTicks() + base::Seconds(1);
base::TimeDelta duration = base::Milliseconds(100);
base::TimeTicks third_through_animation = start_time + duration / 3;
base::TimeTicks halfway_through_animation = start_time + duration / 2;
base::TimeTicks end_time = start_time + duration;
float target_scale = 2;
viz::BeginFrameArgs begin_frame_args =
viz::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, 0, 1);
scroll_layer->layer_tree_impl()
->property_trees()
->scroll_tree_mutable()
.UpdateScrollOffsetBaseForTesting(scroll_layer->element_id(),
gfx::PointF(50, 50));
// Make sure TakePageScaleAnimation works properly.
host_impl_->sync_tree()->SetPendingPageScaleAnimation(
std::make_unique<PendingPageScaleAnimation>(gfx::Point(), false,
target_scale, duration));
std::unique_ptr<PendingPageScaleAnimation> psa =
host_impl_->sync_tree()->TakePendingPageScaleAnimation();
EXPECT_EQ(target_scale, psa->scale);
EXPECT_EQ(duration, psa->duration);
EXPECT_EQ(nullptr, host_impl_->sync_tree()->TakePendingPageScaleAnimation());
// Recreate the PSA. Nothing should happen here since the tree containing the
// PSA hasn't been activated yet.
did_request_redraw_ = false;
did_request_next_frame_ = false;
host_impl_->sync_tree()->SetPendingPageScaleAnimation(
std::make_unique<PendingPageScaleAnimation>(gfx::Point(), false,
target_scale, duration));
begin_frame_args.frame_time = halfway_through_animation;
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
EXPECT_FALSE(did_request_next_frame_);
EXPECT_FALSE(did_request_redraw_);
host_impl_->DidFinishImplFrame(begin_frame_args);
// Activate the sync tree. This should cause the animation to become enabled.
// It should also clear the pointer on the sync tree.
host_impl_->ActivateSyncTree();
EXPECT_EQ(nullptr,
host_impl_->sync_tree()->TakePendingPageScaleAnimation().get());
EXPECT_FALSE(did_request_redraw_);
EXPECT_TRUE(did_request_next_frame_);
start_time += base::Seconds(10);
third_through_animation += base::Seconds(10);
halfway_through_animation += base::Seconds(10);
end_time += base::Seconds(10);
// From here on, make sure the animation runs as normal.
did_request_redraw_ = false;
did_request_next_frame_ = false;
begin_frame_args.frame_time = start_time;
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
EXPECT_TRUE(did_request_redraw_);
EXPECT_TRUE(did_request_next_frame_);
host_impl_->DidFinishImplFrame(begin_frame_args);
did_request_redraw_ = false;
did_request_next_frame_ = false;
begin_frame_args.frame_time = third_through_animation;
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
EXPECT_TRUE(did_request_redraw_);
EXPECT_TRUE(did_request_next_frame_);
host_impl_->DidFinishImplFrame(begin_frame_args);
// Another activation shouldn't have any effect on the animation.
host_impl_->ActivateSyncTree();
did_request_redraw_ = false;
did_request_next_frame_ = false;
begin_frame_args.frame_time = halfway_through_animation;
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
EXPECT_TRUE(did_request_redraw_);
EXPECT_TRUE(did_request_next_frame_);
host_impl_->DidFinishImplFrame(begin_frame_args);
did_request_redraw_ = false;
did_request_next_frame_ = false;
did_request_commit_ = false;
begin_frame_args.frame_time = end_time;
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
EXPECT_TRUE(did_request_commit_);
EXPECT_FALSE(did_request_next_frame_);
host_impl_->DidFinishImplFrame(begin_frame_args);
std::unique_ptr<CompositorCommitData> commit_data =
host_impl_->ProcessCompositorDeltas(
/* main_thread_mutator_host */ nullptr);
EXPECT_EQ(commit_data->page_scale_delta, target_scale);
EXPECT_TRUE(ScrollInfoContains(*commit_data, scroll_layer->element_id(),
gfx::Vector2dF(-50, -50)));
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
PageScaleAnimationCompletedNotification) {
SetupViewportLayersInnerScrolls(gfx::Size(50, 50), gfx::Size(100, 100));
DrawFrame();
LayerImpl* scroll_layer = InnerViewportScrollLayer();
DCHECK(scroll_layer);
base::TimeTicks start_time = base::TimeTicks() + base::Seconds(1);
base::TimeDelta duration = base::Milliseconds(100);
base::TimeTicks halfway_through_animation = start_time + duration / 2;
base::TimeTicks end_time = start_time + duration;
viz::BeginFrameArgs begin_frame_args =
viz::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, 0, 1);
host_impl_->active_tree()->PushPageScaleFromMainThread(1, 0.5f, 4);
scroll_layer->layer_tree_impl()
->property_trees()
->scroll_tree_mutable()
.UpdateScrollOffsetBaseForTesting(scroll_layer->element_id(),
gfx::PointF(50, 50));
did_complete_page_scale_animation_ = false;
host_impl_->active_tree()->SetPendingPageScaleAnimation(
std::make_unique<PendingPageScaleAnimation>(gfx::Point(), false, 2,
duration));
host_impl_->ActivateSyncTree();
begin_frame_args.frame_time = start_time;
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
EXPECT_FALSE(did_complete_page_scale_animation_);
host_impl_->DidFinishImplFrame(begin_frame_args);
begin_frame_args.frame_time = halfway_through_animation;
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
EXPECT_FALSE(did_complete_page_scale_animation_);
host_impl_->DidFinishImplFrame(begin_frame_args);
begin_frame_args.frame_time = end_time;
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
EXPECT_TRUE(did_complete_page_scale_animation_);
host_impl_->DidFinishImplFrame(begin_frame_args);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
MaxScrollOffsetAffectedByViewportBoundsDelta) {
SetupViewportLayersInnerScrolls(gfx::Size(50, 50), gfx::Size(100, 100));
host_impl_->active_tree()->PushPageScaleFromMainThread(1, 0.5f, 4);
DrawFrame();
LayerImpl* inner_scroll = InnerViewportScrollLayer();
DCHECK(inner_scroll);
EXPECT_EQ(gfx::SizeF(50, 50),
host_impl_->active_tree()->ScrollableViewportSize());
EXPECT_EQ(gfx::PointF(50, 50), MaxScrollOffset(inner_scroll));
PropertyTrees* property_trees = host_impl_->active_tree()->property_trees();
property_trees->SetInnerViewportContainerBoundsDelta(gfx::Vector2dF(15, 15));
property_trees->SetOuterViewportContainerBoundsDelta(gfx::Vector2dF(7, 7));
// Container grows in response to the inner viewport bounds delta.
EXPECT_EQ(gfx::SizeF(65, 65),
host_impl_->active_tree()->ScrollableViewportSize());
EXPECT_EQ(gfx::PointF(42, 42), MaxScrollOffset(inner_scroll));
property_trees->SetInnerViewportContainerBoundsDelta(gfx::Vector2dF());
property_trees->SetOuterViewportContainerBoundsDelta(gfx::Vector2dF());
inner_scroll->SetBounds(gfx::Size());
GetScrollNode(inner_scroll)->bounds = inner_scroll->bounds();
DrawFrame();
property_trees->SetOuterViewportContainerBoundsDelta(gfx::Vector2dF(60, 60));
EXPECT_EQ(gfx::PointF(10, 10), MaxScrollOffset(inner_scroll));
}
// Ensures scroll gestures coming from scrollbars cause animations in the
// appropriate scenarios.
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
AnimatedGranularityCausesSmoothScroll) {
gfx::Size viewport_size(300, 200);
gfx::Size content_size(1000, 1000);
SetupViewportLayersOuterScrolls(viewport_size, content_size);
gfx::Point position(295, 195);
gfx::Vector2dF offset(0, 50);
std::vector<ui::ScrollInputType> types = {ui::ScrollInputType::kScrollbar,
ui::ScrollInputType::kWheel};
for (auto type : types) {
auto begin_state = BeginState(position, offset, type);
begin_state->data()->set_current_native_scrolling_element(
host_impl_->OuterViewportScrollNode()->element_id);
begin_state->data()->delta_granularity =
ui::ScrollGranularity::kScrollByPixel;
auto update_state = UpdateState(position, offset, type);
update_state->data()->delta_granularity =
ui::ScrollGranularity::kScrollByPixel;
ASSERT_FALSE(GetImplAnimationHost()->ImplOnlyScrollAnimatingElement());
// Perform a scrollbar-like scroll (one injected by the
// ScrollbarController). It should cause an animation to be created.
{
GetInputHandler().ScrollBegin(begin_state.get(), type);
ASSERT_EQ(host_impl_->CurrentlyScrollingNode(),
host_impl_->OuterViewportScrollNode());
GetInputHandler().ScrollUpdate(update_state.get());
EXPECT_TRUE(GetImplAnimationHost()->ImplOnlyScrollAnimatingElement());
GetInputHandler().ScrollEnd();
}
GetImplAnimationHost()->ScrollAnimationAbort();
ASSERT_FALSE(GetImplAnimationHost()->ImplOnlyScrollAnimatingElement());
// Perform a scrollbar-like scroll (one injected by the
// ScrollbarController). This time we change the granularity to precise (as
// if thumb-dragging). This should not cause an animation.
{
begin_state->data()->delta_granularity =
ui::ScrollGranularity::kScrollByPrecisePixel;
update_state->data()->delta_granularity =
ui::ScrollGranularity::kScrollByPrecisePixel;
GetInputHandler().ScrollBegin(begin_state.get(), type);
ASSERT_EQ(host_impl_->CurrentlyScrollingNode(),
host_impl_->OuterViewportScrollNode());
GetInputHandler().ScrollUpdate(update_state.get());
EXPECT_FALSE(GetImplAnimationHost()->ImplOnlyScrollAnimatingElement());
GetInputHandler().ScrollEnd();
}
}
}
// Ensures scroll gestures coming from scrollbars don't cause animations if
// smooth scrolling is disabled.
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
NonAnimatedGranularityCausesInstantScroll) {
// Disable animated scrolling
LayerTreeSettings settings = DefaultSettings();
settings.enable_smooth_scroll = false;
CreateHostImpl(settings, CreateLayerTreeFrameSink());
gfx::Size viewport_size(300, 200);
gfx::Size content_size(1000, 1000);
SetupViewportLayersOuterScrolls(viewport_size, content_size);
gfx::Point position(295, 195);
gfx::Vector2dF offset(0, 50);
std::vector<ui::ScrollInputType> types = {ui::ScrollInputType::kScrollbar,
ui::ScrollInputType::kWheel};
for (auto type : types) {
auto begin_state = BeginState(position, offset, type);
begin_state->data()->set_current_native_scrolling_element(
host_impl_->OuterViewportScrollNode()->element_id);
begin_state->data()->delta_granularity =
ui::ScrollGranularity::kScrollByPixel;
auto update_state = UpdateState(position, offset, type);
update_state->data()->delta_granularity =
ui::ScrollGranularity::kScrollByPixel;
ASSERT_FALSE(GetImplAnimationHost()->ImplOnlyScrollAnimatingElement());
// Perform a scrollbar-like scroll (one injected by the
// ScrollbarController). It should cause an animation to be created.
{
GetInputHandler().ScrollBegin(begin_state.get(), type);
ASSERT_EQ(host_impl_->CurrentlyScrollingNode(),
host_impl_->OuterViewportScrollNode());
GetInputHandler().ScrollUpdate(update_state.get());
EXPECT_FALSE(GetImplAnimationHost()->ImplOnlyScrollAnimatingElement());
GetInputHandler().ScrollEnd();
}
}
}
class LayerTreeHostImplOverridePhysicalTime : public LayerTreeHostImpl {
public:
LayerTreeHostImplOverridePhysicalTime(
const LayerTreeSettings& settings,
LayerTreeHostImplClient* client,
TaskRunnerProvider* task_runner_provider,
TaskGraphRunner* task_graph_runner,
RenderingStatsInstrumentation* rendering_stats_instrumentation)
: LayerTreeHostImpl(settings,
client,
task_runner_provider,
rendering_stats_instrumentation,
task_graph_runner,
AnimationHost::CreateForTesting(ThreadInstance::IMPL),
nullptr,
0,
nullptr,
nullptr) {}
const viz::BeginFrameArgs& CurrentBeginFrameArgs() const override {
return current_begin_frame_args_;
}
void SetCurrentPhysicalTimeTicksForTest(base::TimeTicks fake_now) {
current_begin_frame_args_ = viz::CreateBeginFrameArgsForTesting(
BEGINFRAME_FROM_HERE, 0, 1, fake_now);
}
private:
viz::BeginFrameArgs current_begin_frame_args_;
};
class LayerTreeHostImplTestScrollbarAnimation : public LayerTreeHostImplTest {
protected:
void SetupLayers(LayerTreeSettings settings) {
host_impl_->ReleaseLayerTreeFrameSink();
host_impl_ = nullptr;
gfx::Size viewport_size(50, 50);
gfx::Size content_size(100, 100);
LayerTreeHostImplOverridePhysicalTime* host_impl_override_time =
new LayerTreeHostImplOverridePhysicalTime(
settings, this, &task_runner_provider_, &task_graph_runner_,
&stats_instrumentation_);
InputHandler::Create(
static_cast<CompositorDelegateForInput&>(*host_impl_override_time));
host_impl_ = base::WrapUnique(host_impl_override_time);
layer_tree_frame_sink_ = CreateLayerTreeFrameSink();
host_impl_->SetVisible(true);
host_impl_->InitializeFrameSink(layer_tree_frame_sink_.get());
SetupViewportLayersInnerScrolls(viewport_size, content_size);
host_impl_->active_tree()->PushPageScaleFromMainThread(1, 1, 4);
auto* scrollbar = AddLayer<SolidColorScrollbarLayerImpl>(
host_impl_->active_tree(), ScrollbarOrientation::VERTICAL, 10, 0,
false);
SetupScrollbarLayer(OuterViewportScrollLayer(), scrollbar);
host_impl_->active_tree()->DidBecomeActive();
host_impl_->active_tree()->HandleScrollbarShowRequests();
host_impl_->active_tree()->SetLocalSurfaceIdFromParent(
viz::LocalSurfaceId(1, base::UnguessableToken::Deserialize(2u, 3u)));
DrawFrame();
// SetScrollElementId will initialize the scrollbar which will cause it to
// show and request a redraw.
did_request_redraw_ = false;
}
void RunTest(LayerTreeSettings::ScrollbarAnimator animator) {
LayerTreeSettings settings = DefaultSettings();
settings.scrollbar_animator = animator;
settings.scrollbar_fade_delay = base::Milliseconds(20);
settings.scrollbar_fade_duration = base::Milliseconds(20);
// If no animator is set, scrollbar won't show and no animation is expected.
bool expecting_animations = animator != LayerTreeSettings::NO_ANIMATOR;
SetupLayers(settings);
base::TimeTicks fake_now = base::TimeTicks::Now();
// Android Overlay Scrollbar does not have a initial show and fade out.
if (animator == LayerTreeSettings::AURA_OVERLAY) {
// A task will be posted to fade the initial scrollbar.
EXPECT_FALSE(did_request_next_frame_);
EXPECT_FALSE(did_request_redraw_);
EXPECT_FALSE(animation_task_.is_null());
requested_animation_delay_ = base::TimeDelta();
animation_task_.Reset();
} else {
EXPECT_FALSE(did_request_next_frame_);
EXPECT_FALSE(did_request_redraw_);
EXPECT_TRUE(animation_task_.is_null());
EXPECT_EQ(base::TimeDelta(), requested_animation_delay_);
}
// If no scroll happened during a scroll gesture, it should have no effect.
GetInputHandler().ScrollBegin(
BeginState(gfx::Point(), gfx::Vector2dF(), ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
GetInputHandler().ScrollEnd();
EXPECT_FALSE(did_request_next_frame_);
EXPECT_FALSE(did_request_redraw_);
EXPECT_EQ(base::TimeDelta(), requested_animation_delay_);
EXPECT_TRUE(animation_task_.is_null());
// For Aura Overlay Scrollbar, if no scroll happened during a scroll
// gesture, shows scrollbars and schedules a delay fade out.
GetInputHandler().ScrollBegin(
BeginState(gfx::Point(), gfx::Vector2dF(), ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
GetInputHandler().ScrollUpdate(UpdateState(gfx::Point(),
gfx::Vector2dF(0, 0),
ui::ScrollInputType::kWheel)
.get());
GetInputHandler().ScrollEnd();
EXPECT_FALSE(did_request_next_frame_);
EXPECT_FALSE(did_request_redraw_);
if (animator == LayerTreeSettings::AURA_OVERLAY) {
EXPECT_EQ(base::Milliseconds(20), requested_animation_delay_);
EXPECT_FALSE(animation_task_.is_null());
requested_animation_delay_ = base::TimeDelta();
animation_task_.Reset();
} else {
EXPECT_EQ(base::TimeDelta(), requested_animation_delay_);
EXPECT_TRUE(animation_task_.is_null());
}
// Before the scrollbar animation exists, we should not get redraws.
viz::BeginFrameArgs begin_frame_args = viz::CreateBeginFrameArgsForTesting(
BEGINFRAME_FROM_HERE, 0, 2, fake_now);
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
EXPECT_FALSE(did_request_next_frame_);
did_request_next_frame_ = false;
EXPECT_FALSE(did_request_redraw_);
did_request_redraw_ = false;
EXPECT_EQ(base::TimeDelta(), requested_animation_delay_);
EXPECT_TRUE(animation_task_.is_null());
host_impl_->DidFinishImplFrame(begin_frame_args);
// After a scroll, a scrollbar animation should be scheduled about 20ms from
// now.
GetInputHandler().ScrollBegin(BeginState(gfx::Point(), gfx::Vector2dF(0, 5),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
GetInputHandler().ScrollUpdate(UpdateState(gfx::Point(),
gfx::Vector2dF(0, 5),
ui::ScrollInputType::kWheel)
.get());
EXPECT_FALSE(did_request_next_frame_);
EXPECT_TRUE(did_request_redraw_);
did_request_redraw_ = false;
if (expecting_animations) {
EXPECT_EQ(base::Milliseconds(20), requested_animation_delay_);
EXPECT_FALSE(animation_task_.is_null());
} else {
EXPECT_EQ(base::TimeDelta(), requested_animation_delay_);
EXPECT_TRUE(animation_task_.is_null());
}
GetInputHandler().ScrollEnd();
EXPECT_FALSE(did_request_next_frame_);
EXPECT_FALSE(did_request_redraw_);
if (expecting_animations) {
EXPECT_EQ(base::Milliseconds(20), requested_animation_delay_);
EXPECT_FALSE(animation_task_.is_null());
} else {
EXPECT_EQ(base::TimeDelta(), requested_animation_delay_);
EXPECT_TRUE(animation_task_.is_null());
}
if (expecting_animations) {
// Before the scrollbar animation begins, we should not get redraws.
begin_frame_args = viz::CreateBeginFrameArgsForTesting(
BEGINFRAME_FROM_HERE, 0, 3, fake_now);
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
EXPECT_FALSE(did_request_next_frame_);
did_request_next_frame_ = false;
EXPECT_FALSE(did_request_redraw_);
did_request_redraw_ = false;
host_impl_->DidFinishImplFrame(begin_frame_args);
// Start the scrollbar animation.
fake_now += requested_animation_delay_;
requested_animation_delay_ = base::TimeDelta();
std::move(animation_task_).Run();
EXPECT_TRUE(did_request_next_frame_);
did_request_next_frame_ = false;
EXPECT_FALSE(did_request_redraw_);
// After the scrollbar animation begins, we should start getting redraws.
begin_frame_args = viz::CreateBeginFrameArgsForTesting(
BEGINFRAME_FROM_HERE, 0, 4, fake_now);
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
EXPECT_TRUE(did_request_next_frame_);
did_request_next_frame_ = false;
EXPECT_TRUE(did_request_redraw_);
did_request_redraw_ = false;
EXPECT_EQ(base::TimeDelta(), requested_animation_delay_);
EXPECT_TRUE(animation_task_.is_null());
host_impl_->DidFinishImplFrame(begin_frame_args);
}
// Setting the scroll offset outside a scroll should not cause the
// scrollbar to appear or schedule a scrollbar animation.
if (host_impl_->active_tree()
->property_trees()
->scroll_tree_mutable()
.UpdateScrollOffsetBaseForTesting(
InnerViewportScrollLayer()->element_id(), gfx::PointF(5, 5)))
host_impl_->active_tree()->DidUpdateScrollOffset(
InnerViewportScrollLayer()->element_id());
EXPECT_FALSE(did_request_next_frame_);
EXPECT_FALSE(did_request_redraw_);
EXPECT_EQ(base::TimeDelta(), requested_animation_delay_);
EXPECT_TRUE(animation_task_.is_null());
// Changing page scale triggers scrollbar animation.
host_impl_->active_tree()->PushPageScaleFromMainThread(1, 1, 4);
host_impl_->active_tree()->SetPageScaleOnActiveTree(1.1f);
EXPECT_FALSE(did_request_next_frame_);
EXPECT_FALSE(did_request_redraw_);
if (expecting_animations) {
EXPECT_EQ(base::Milliseconds(20), requested_animation_delay_);
EXPECT_FALSE(animation_task_.is_null());
requested_animation_delay_ = base::TimeDelta();
animation_task_.Reset();
} else {
EXPECT_EQ(base::TimeDelta(), requested_animation_delay_);
EXPECT_TRUE(animation_task_.is_null());
}
}
};
TEST_F(LayerTreeHostImplTestScrollbarAnimation, Android) {
RunTest(LayerTreeSettings::ANDROID_OVERLAY);
}
TEST_F(LayerTreeHostImplTestScrollbarAnimation, AuraOverlay) {
RunTest(LayerTreeSettings::AURA_OVERLAY);
}
TEST_F(LayerTreeHostImplTestScrollbarAnimation, NoAnimator) {
RunTest(LayerTreeSettings::NO_ANIMATOR);
}
class LayerTreeHostImplTestScrollbarOpacity
: public ScrollUnifiedLayerTreeHostImplTest {
protected:
void RunTest(LayerTreeSettings::ScrollbarAnimator animator) {
LayerTreeSettings settings = DefaultSettings();
settings.scrollbar_animator = animator;
settings.scrollbar_fade_delay = base::Milliseconds(20);
settings.scrollbar_fade_duration = base::Milliseconds(20);
gfx::Size viewport_size(50, 50);
gfx::Size content_size(100, 100);
// If no animator is set, scrollbar won't show and no animation is expected.
bool expecting_animations = animator != LayerTreeSettings::NO_ANIMATOR;
CreateHostImpl(settings, CreateLayerTreeFrameSink());
CreatePendingTree();
SetupViewportLayers(host_impl_->pending_tree(), viewport_size, content_size,
content_size);
LayerImpl* scroll =
host_impl_->pending_tree()->OuterViewportScrollLayerForTesting();
auto* scrollbar = AddLayer<SolidColorScrollbarLayerImpl>(
host_impl_->pending_tree(), ScrollbarOrientation::VERTICAL, 10, 0,
false);
SetupScrollbarLayer(scroll, scrollbar);
scrollbar->SetOffsetToTransformParent(gfx::Vector2dF(90, 0));
host_impl_->pending_tree()->PushPageScaleFromMainThread(1, 1, 1);
UpdateDrawProperties(host_impl_->pending_tree());
host_impl_->ActivateSyncTree();
LayerImpl* active_scrollbar_layer =
host_impl_->active_tree()->LayerById(scrollbar->id());
EffectNode* active_tree_node = GetEffectNode(active_scrollbar_layer);
EXPECT_FLOAT_EQ(active_scrollbar_layer->Opacity(),
active_tree_node->opacity);
if (expecting_animations) {
host_impl_->ScrollbarAnimationControllerForElementId(scroll->element_id())
->DidMouseMove(gfx::PointF(0, 90));
} else {
EXPECT_EQ(nullptr, host_impl_->ScrollbarAnimationControllerForElementId(
scroll->element_id()));
}
GetInputHandler().ScrollBegin(BeginState(gfx::Point(), gfx::Vector2dF(0, 5),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
GetInputHandler().ScrollUpdate(UpdateState(gfx::Point(),
gfx::Vector2dF(0, 5),
ui::ScrollInputType::kWheel)
.get());
GetInputHandler().ScrollEnd();
CreatePendingTree();
// To test the case where the effect tree index of scrollbar layer changes,
// we create an effect node with a render surface above the scrollbar's
// effect node.
auto* pending_root = host_impl_->pending_tree()->root_layer();
auto& new_effect_node = CreateEffectNode(
GetPropertyTrees(pending_root), pending_root->effect_tree_index(),
pending_root->transform_tree_index(), pending_root->clip_tree_index());
new_effect_node.render_surface_reason = RenderSurfaceReason::kTest;
LayerImpl* pending_scrollbar_layer =
host_impl_->pending_tree()->LayerById(scrollbar->id());
GetEffectNode(pending_scrollbar_layer)->parent_id = new_effect_node.id;
pending_scrollbar_layer->SetNeedsPushProperties();
UpdateDrawProperties(host_impl_->pending_tree());
EffectNode* pending_tree_node = GetEffectNode(pending_scrollbar_layer);
if (expecting_animations) {
EXPECT_FLOAT_EQ(1, active_tree_node->opacity);
EXPECT_FLOAT_EQ(1, active_scrollbar_layer->Opacity());
} else {
EXPECT_FLOAT_EQ(0, active_tree_node->opacity);
EXPECT_FLOAT_EQ(0, active_scrollbar_layer->Opacity());
}
EXPECT_FLOAT_EQ(0, pending_tree_node->opacity);
host_impl_->ActivateSyncTree();
active_tree_node = GetEffectNode(active_scrollbar_layer);
if (expecting_animations) {
EXPECT_FLOAT_EQ(1, active_tree_node->opacity);
EXPECT_FLOAT_EQ(1, active_scrollbar_layer->Opacity());
} else {
EXPECT_FLOAT_EQ(0, active_tree_node->opacity);
EXPECT_FLOAT_EQ(0, active_scrollbar_layer->Opacity());
}
}
};
INSTANTIATE_TEST_SUITE_P(All,
LayerTreeHostImplTestScrollbarOpacity,
testing::Bool());
TEST_P(LayerTreeHostImplTestScrollbarOpacity, Android) {
RunTest(LayerTreeSettings::ANDROID_OVERLAY);
}
TEST_P(LayerTreeHostImplTestScrollbarOpacity, AuraOverlay) {
RunTest(LayerTreeSettings::AURA_OVERLAY);
}
TEST_P(LayerTreeHostImplTestScrollbarOpacity, NoAnimator) {
RunTest(LayerTreeSettings::NO_ANIMATOR);
}
class LayerTreeHostImplTestMultiScrollable
: public ScrollUnifiedLayerTreeHostImplTest {
public:
void SetUpLayers(LayerTreeSettings settings) {
is_aura_scrollbar_ =
settings.scrollbar_animator == LayerTreeSettings::AURA_OVERLAY;
gfx::Size viewport_size(300, 200);
gfx::Size content_size(1000, 1000);
gfx::Size child_layer_size(250, 150);
gfx::Size scrollbar_size_1(gfx::Size(15, viewport_size.height()));
gfx::Size scrollbar_size_2(gfx::Size(15, child_layer_size.height()));
CreateHostImpl(settings, CreateLayerTreeFrameSink());
host_impl_->active_tree()->SetDeviceScaleFactor(1);
SetupViewportLayers(host_impl_->active_tree(), viewport_size, content_size,
content_size);
LayerImpl* root_scroll = OuterViewportScrollLayer();
// scrollbar_1 on root scroll.
scrollbar_1_ = AddLayer<SolidColorScrollbarLayerImpl>(
host_impl_->active_tree(), ScrollbarOrientation::VERTICAL, 15, 0, true);
SetupScrollbarLayer(root_scroll, scrollbar_1_);
scrollbar_1_->SetBounds(scrollbar_size_1);
TouchActionRegion touch_action_region;
touch_action_region.Union(TouchAction::kNone, gfx::Rect(scrollbar_size_1));
scrollbar_1_->SetTouchActionRegion(touch_action_region);
// scrollbar_2 on child.
auto* child =
AddScrollableLayer(root_scroll, gfx::Size(100, 100), child_layer_size);
GetTransformNode(child)->post_translation = gfx::Vector2dF(50, 50);
scrollbar_2_ = AddLayer<SolidColorScrollbarLayerImpl>(
host_impl_->active_tree(), ScrollbarOrientation::VERTICAL, 15, 0, true);
SetupScrollbarLayer(child, scrollbar_2_);
scrollbar_2_->SetBounds(scrollbar_size_2);
UpdateDrawProperties(host_impl_->active_tree());
host_impl_->active_tree()->UpdateScrollbarGeometries();
host_impl_->active_tree()->DidBecomeActive();
ResetScrollbars();
}
void ResetScrollbars() {
GetEffectNode(scrollbar_1_.get())->opacity = 0;
GetEffectNode(scrollbar_2_.get())->opacity = 0;
UpdateDrawProperties(host_impl_->active_tree());
if (is_aura_scrollbar_)
animation_task_.Reset();
}
bool is_aura_scrollbar_;
raw_ptr<SolidColorScrollbarLayerImpl> scrollbar_1_;
raw_ptr<SolidColorScrollbarLayerImpl> scrollbar_2_;
};
INSTANTIATE_TEST_SUITE_P(All,
LayerTreeHostImplTestMultiScrollable,
testing::Bool());
TEST_P(LayerTreeHostImplTestMultiScrollable,
ScrollbarFlashAfterAnyScrollUpdate) {
LayerTreeSettings settings = DefaultSettings();
settings.scrollbar_fade_delay = base::Milliseconds(500);
settings.scrollbar_fade_duration = base::Milliseconds(300);
settings.scrollbar_animator = LayerTreeSettings::AURA_OVERLAY;
settings.scrollbar_flash_after_any_scroll_update = true;
SetUpLayers(settings);
EXPECT_EQ(scrollbar_1_->Opacity(), 0);
EXPECT_EQ(scrollbar_2_->Opacity(), 0);
// Scroll on root should flash all scrollbars.
GetInputHandler().RootScrollBegin(
BeginState(gfx::Point(20, 20), gfx::Vector2dF(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
GetInputHandler().ScrollUpdate(UpdateState(gfx::Point(20, 20),
gfx::Vector2d(0, 10),
ui::ScrollInputType::kWheel)
.get());
GetInputHandler().ScrollEnd();
EXPECT_TRUE(scrollbar_1_->Opacity());
EXPECT_TRUE(scrollbar_2_->Opacity());
EXPECT_FALSE(animation_task_.is_null());
ResetScrollbars();
// Scroll on child should flash all scrollbars.
GetInputHandler().ScrollBegin(
BeginState(gfx::Point(70, 70), gfx::Vector2dF(0, 100),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
GetInputHandler().ScrollUpdate(
AnimatedUpdateState(gfx::Point(70, 70), gfx::Vector2d(0, 100)).get());
GetInputHandler().ScrollEnd();
EXPECT_TRUE(scrollbar_1_->Opacity());
EXPECT_TRUE(scrollbar_2_->Opacity());
EXPECT_FALSE(animation_task_.is_null());
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollHitTestOnScrollbar) {
LayerTreeSettings settings = DefaultSettings();
settings.scrollbar_fade_delay = base::Milliseconds(500);
settings.scrollbar_fade_duration = base::Milliseconds(300);
settings.scrollbar_animator = LayerTreeSettings::NO_ANIMATOR;
gfx::Size viewport_size(300, 200);
gfx::Size content_size(1000, 1000);
gfx::Size child_layer_size(250, 150);
gfx::Size scrollbar_size_1(gfx::Size(15, viewport_size.height()));
gfx::Size scrollbar_size_2(gfx::Size(15, child_layer_size.height()));
CreateHostImpl(settings, CreateLayerTreeFrameSink());
host_impl_->active_tree()->SetDeviceScaleFactor(1);
SetupViewportLayersInnerScrolls(viewport_size, content_size);
LayerImpl* root_scroll = OuterViewportScrollLayer();
// scrollbar_1 on root scroll.
auto* scrollbar_1 = AddLayer<PaintedScrollbarLayerImpl>(
host_impl_->active_tree(), ScrollbarOrientation::VERTICAL, true, true);
SetupScrollbarLayer(root_scroll, scrollbar_1);
scrollbar_1->SetBounds(scrollbar_size_1);
TouchActionRegion touch_action_region;
touch_action_region.Union(TouchAction::kNone, gfx::Rect(scrollbar_size_1));
scrollbar_1->SetTouchActionRegion(touch_action_region);
LayerImpl* child =
AddScrollableLayer(root_scroll, gfx::Size(100, 100), child_layer_size);
GetTransformNode(child)->post_translation = gfx::Vector2dF(50, 50);
// scrollbar_2 on child.
auto* scrollbar_2 = AddLayer<PaintedScrollbarLayerImpl>(
host_impl_->active_tree(), ScrollbarOrientation::VERTICAL, true, true);
SetupScrollbarLayer(child, scrollbar_2);
scrollbar_2->SetBounds(scrollbar_size_2);
scrollbar_2->SetOffsetToTransformParent(gfx::Vector2dF(50, 50));
UpdateDrawProperties(host_impl_->active_tree());
host_impl_->active_tree()->DidBecomeActive();
// Wheel scroll on root scrollbar should process on impl thread.
{
InputHandler::ScrollStatus status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(1, 1), gfx::Vector2dF(),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
GetInputHandler().ScrollEnd();
}
// Touch scroll on root scrollbar should process on main thread.
{
InputHandler::ScrollStatus status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(1, 1), gfx::Vector2dF(),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
EXPECT_EQ(ScrollThread::SCROLL_ON_MAIN_THREAD, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kScrollbarScrolling,
status.main_thread_scrolling_reasons);
}
// Wheel scroll on scrollbar should process on impl thread.
{
InputHandler::ScrollStatus status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(51, 51), gfx::Vector2dF(),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kNotScrollingOnMain,
status.main_thread_scrolling_reasons);
GetInputHandler().ScrollEnd();
}
// Touch scroll on scrollbar should process on main thread.
{
InputHandler::ScrollStatus status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(51, 51), gfx::Vector2dF(),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
EXPECT_EQ(ScrollThread::SCROLL_ON_MAIN_THREAD, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kScrollbarScrolling,
status.main_thread_scrolling_reasons);
}
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
ScrollbarVisibilityChangeCausesRedrawAndCommit) {
LayerTreeSettings settings = DefaultSettings();
settings.scrollbar_animator = LayerTreeSettings::AURA_OVERLAY;
settings.scrollbar_fade_delay = base::Milliseconds(20);
settings.scrollbar_fade_duration = base::Milliseconds(20);
settings.enable_scroll_update_optimizations = true;
gfx::Size viewport_size(50, 50);
gfx::Size content_size(100, 100);
CreateHostImpl(settings, CreateLayerTreeFrameSink());
CreatePendingTree();
SetupViewportLayers(host_impl_->pending_tree(), viewport_size, content_size,
content_size);
LayerImpl* scroll =
host_impl_->pending_tree()->OuterViewportScrollLayerForTesting();
auto* scrollbar = AddLayer<SolidColorScrollbarLayerImpl>(
host_impl_->pending_tree(), ScrollbarOrientation::VERTICAL, 10, 0, false);
SetupScrollbarLayer(scroll, scrollbar);
scrollbar->SetOffsetToTransformParent(gfx::Vector2dF(90, 0));
host_impl_->pending_tree()->PushPageScaleFromMainThread(1, 1, 1);
host_impl_->ActivateSyncTree();
ScrollbarAnimationController* scrollbar_controller =
host_impl_->ScrollbarAnimationControllerForElementId(
scroll->element_id());
// Scrollbars will flash shown but we should have a fade out animation
// queued. Run it and fade out the scrollbars.
ASSERT_FALSE(scrollbar_controller->ScrollbarsHidden());
EXPECT_TRUE(scrollbar_controller->visibility_changed());
ClearMainThreadDeltasForTesting(host_impl_.get());
auto commit_data = host_impl_->ProcessCompositorDeltas(
/* main_thread_mutator_host */ nullptr);
using ScrollbarsInfo = CompositorCommitData::ScrollbarsUpdateInfo;
EXPECT_THAT(commit_data->scrollbars, testing::ElementsAre(ScrollbarsInfo{
scroll->element_id(), false}));
EXPECT_FALSE(scrollbar_controller->visibility_changed());
{
ASSERT_FALSE(animation_task_.is_null());
ASSERT_FALSE(animation_task_.IsCancelled());
std::move(animation_task_).Run();
base::TimeTicks fake_now = base::TimeTicks::Now();
scrollbar_controller->Animate(fake_now);
fake_now += settings.scrollbar_fade_delay;
scrollbar_controller->Animate(fake_now);
ASSERT_TRUE(scrollbar_controller->ScrollbarsHidden());
ClearMainThreadDeltasForTesting(host_impl_.get());
commit_data = host_impl_->ProcessCompositorDeltas(
/* main_thread_mutator_host */ nullptr);
EXPECT_THAT(commit_data->scrollbars, testing::ElementsAre(ScrollbarsInfo{
scroll->element_id(), true}));
EXPECT_FALSE(scrollbar_controller->visibility_changed());
}
// Move the mouse over the scrollbar region. This should post a delayed fade
// in task. Execute it to fade in the scrollbars.
{
animation_task_.Reset();
scrollbar_controller->DidMouseMove(gfx::PointF(90, 0));
ASSERT_FALSE(animation_task_.is_null());
ASSERT_FALSE(animation_task_.IsCancelled());
}
// The fade in task should cause the scrollbars to show. Ensure that we
// requested a redraw and a commit.
{
did_request_redraw_ = false;
did_request_commit_ = false;
ASSERT_TRUE(scrollbar_controller->ScrollbarsHidden());
EXPECT_FALSE(scrollbar_controller->visibility_changed());
ClearMainThreadDeltasForTesting(host_impl_.get());
commit_data = host_impl_->ProcessCompositorDeltas(
/* main_thread_mutator_host */ nullptr);
EXPECT_TRUE(commit_data->scrollbars.empty());
std::move(animation_task_).Run();
base::TimeTicks fake_now = base::TimeTicks::Now();
scrollbar_controller->Animate(fake_now);
fake_now += settings.scrollbar_fade_duration;
scrollbar_controller->Animate(fake_now);
ASSERT_FALSE(scrollbar_controller->ScrollbarsHidden());
EXPECT_TRUE(scrollbar_controller->visibility_changed());
ClearMainThreadDeltasForTesting(host_impl_.get());
commit_data = host_impl_->ProcessCompositorDeltas(
/* main_thread_mutator_host */ nullptr);
EXPECT_THAT(commit_data->scrollbars, testing::ElementsAre(ScrollbarsInfo{
scroll->element_id(), false}));
EXPECT_FALSE(scrollbar_controller->visibility_changed());
EXPECT_TRUE(did_request_redraw_);
EXPECT_TRUE(did_request_commit_);
}
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollbarInnerLargerThanOuter) {
LayerTreeSettings settings = DefaultSettings();
CreateHostImpl(settings, CreateLayerTreeFrameSink());
gfx::Size inner_viewport_size(315, 200);
gfx::Size outer_viewport_size(300, 200);
gfx::Size content_size(1000, 1000);
SetupViewportLayers(host_impl_->active_tree(), inner_viewport_size,
outer_viewport_size, content_size);
LayerImpl* root_scroll = OuterViewportScrollLayer();
auto* horiz_scrollbar = AddLayer<PaintedScrollbarLayerImpl>(
host_impl_->active_tree(), ScrollbarOrientation::HORIZONTAL, true, true);
SetupScrollbarLayer(root_scroll, horiz_scrollbar);
LayerImpl* child = AddLayer();
child->SetBounds(content_size);
child->SetBounds(inner_viewport_size);
host_impl_->active_tree()->UpdateScrollbarGeometries();
EXPECT_EQ(300, horiz_scrollbar->clip_layer_length());
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollbarRegistration) {
LayerTreeSettings settings = DefaultSettings();
settings.scrollbar_animator = LayerTreeSettings::ANDROID_OVERLAY;
settings.scrollbar_fade_delay = base::Milliseconds(20);
settings.scrollbar_fade_duration = base::Milliseconds(20);
CreateHostImpl(settings, CreateLayerTreeFrameSink());
gfx::Size viewport_size(300, 200);
gfx::Size content_size(1000, 1000);
SetupViewportLayersInnerScrolls(viewport_size, content_size);
auto* container = InnerViewportScrollLayer();
auto* root_scroll = OuterViewportScrollLayer();
auto* vert_1_scrollbar = AddLayer<SolidColorScrollbarLayerImpl>(
host_impl_->active_tree(), ScrollbarOrientation::VERTICAL, 5, 5, true);
CopyProperties(container, vert_1_scrollbar);
auto* horiz_1_scrollbar = AddLayer<SolidColorScrollbarLayerImpl>(
host_impl_->active_tree(), ScrollbarOrientation::HORIZONTAL, 5, 5, true);
CopyProperties(container, horiz_1_scrollbar);
auto* vert_2_scrollbar = AddLayer<SolidColorScrollbarLayerImpl>(
host_impl_->active_tree(), ScrollbarOrientation::VERTICAL, 5, 5, true);
CopyProperties(container, vert_2_scrollbar);
auto* horiz_2_scrollbar = AddLayer<SolidColorScrollbarLayerImpl>(
host_impl_->active_tree(), ScrollbarOrientation::HORIZONTAL, 5, 5, true);
CopyProperties(container, horiz_2_scrollbar);
UpdateDrawProperties(host_impl_->active_tree());
// Check scrollbar registration on the viewport layers.
EXPECT_EQ(0ul, host_impl_->ScrollbarsFor(root_scroll->element_id()).size());
EXPECT_EQ(nullptr, host_impl_->ScrollbarAnimationControllerForElementId(
root_scroll->element_id()));
vert_1_scrollbar->SetScrollElementId(root_scroll->element_id());
EXPECT_EQ(1ul, host_impl_->ScrollbarsFor(root_scroll->element_id()).size());
EXPECT_TRUE(host_impl_->ScrollbarAnimationControllerForElementId(
root_scroll->element_id()));
horiz_1_scrollbar->SetScrollElementId(root_scroll->element_id());
EXPECT_EQ(2ul, host_impl_->ScrollbarsFor(root_scroll->element_id()).size());
EXPECT_TRUE(host_impl_->ScrollbarAnimationControllerForElementId(
root_scroll->element_id()));
// Scrolling the viewport should result in a scrollbar animation update.
animation_task_.Reset();
GetInputHandler().ScrollBegin(BeginState(gfx::Point(), gfx::Vector2dF(10, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
GetInputHandler().ScrollUpdate(UpdateState(gfx::Point(),
gfx::Vector2d(10, 10),
ui::ScrollInputType::kWheel)
.get());
GetInputHandler().ScrollEnd();
EXPECT_FALSE(animation_task_.is_null());
animation_task_.Reset();
// Check scrollbar registration on a sublayer.
LayerImpl* child =
AddScrollableLayer(root_scroll, viewport_size, gfx::Size(200, 200));
ElementId child_scroll_element_id = child->element_id();
EXPECT_EQ(0ul, host_impl_->ScrollbarsFor(child_scroll_element_id).size());
EXPECT_EQ(nullptr, host_impl_->ScrollbarAnimationControllerForElementId(
child_scroll_element_id));
vert_2_scrollbar->SetScrollElementId(child_scroll_element_id);
EXPECT_EQ(1ul, host_impl_->ScrollbarsFor(child_scroll_element_id).size());
EXPECT_TRUE(host_impl_->ScrollbarAnimationControllerForElementId(
child_scroll_element_id));
horiz_2_scrollbar->SetScrollElementId(child_scroll_element_id);
EXPECT_EQ(2ul, host_impl_->ScrollbarsFor(child_scroll_element_id).size());
EXPECT_TRUE(host_impl_->ScrollbarAnimationControllerForElementId(
child_scroll_element_id));
// Changing one of the child layers should result in a scrollbar animation
// update.
animation_task_.Reset();
child->set_needs_show_scrollbars(true);
UpdateDrawProperties(host_impl_->active_tree());
host_impl_->active_tree()->HandleScrollbarShowRequests();
EXPECT_FALSE(animation_task_.is_null());
animation_task_.Reset();
// Check scrollbar unregistration.
ElementId root_scroll_element_id = root_scroll->element_id();
host_impl_->active_tree()->DetachLayers();
EXPECT_EQ(0ul, host_impl_->ScrollbarsFor(root_scroll_element_id).size());
EXPECT_EQ(nullptr, host_impl_->ScrollbarAnimationControllerForElementId(
root_scroll_element_id));
EXPECT_EQ(0ul, host_impl_->ScrollbarsFor(child_scroll_element_id).size());
EXPECT_EQ(nullptr, host_impl_->ScrollbarAnimationControllerForElementId(
root_scroll_element_id));
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollBeforeMouseMove) {
LayerTreeSettings settings = DefaultSettings();
settings.scrollbar_animator = LayerTreeSettings::AURA_OVERLAY;
settings.scrollbar_fade_delay = base::Milliseconds(20);
settings.scrollbar_fade_duration = base::Milliseconds(20);
CreateHostImpl(settings, CreateLayerTreeFrameSink());
gfx::Size viewport_size(300, 200);
gfx::Size content_size(1000, 1000);
SetupViewportLayersInnerScrolls(viewport_size, content_size);
auto* root_scroll = OuterViewportScrollLayer();
const int kScrollbarThickness = 5;
auto* vert_scrollbar = AddLayer<SolidColorScrollbarLayerImpl>(
host_impl_->active_tree(), ScrollbarOrientation::VERTICAL,
kScrollbarThickness, 0, false);
SetupScrollbarLayer(root_scroll, vert_scrollbar);
vert_scrollbar->SetBounds(gfx::Size(10, 200));
vert_scrollbar->SetOffsetToTransformParent(
gfx::Vector2dF(300 - kScrollbarThickness, 0));
host_impl_->active_tree()->UpdateScrollbarGeometries();
EXPECT_EQ(1ul, host_impl_->ScrollbarsFor(root_scroll->element_id()).size());
auto* scrollbar_controller =
host_impl_->ScrollbarAnimationControllerForElementId(
root_scroll->element_id());
const float kDistanceToTriggerThumb =
vert_scrollbar->ComputeThumbQuadRect().height() +
scrollbar_controller
->GetScrollbarAnimationController(ScrollbarOrientation::VERTICAL)
.MouseMoveDistanceToTriggerExpand();
// Move the mouse near the thumb while its at the viewport top.
auto near_thumb_at_top = gfx::Point(295, kDistanceToTriggerThumb - 1);
GetInputHandler().MouseMoveAt(near_thumb_at_top);
EXPECT_TRUE(scrollbar_controller->MouseIsNearScrollbarThumb(
ScrollbarOrientation::VERTICAL));
// Move the mouse away from the thumb.
GetInputHandler().MouseMoveAt(gfx::Point(295, kDistanceToTriggerThumb + 1));
EXPECT_FALSE(scrollbar_controller->MouseIsNearScrollbarThumb(
ScrollbarOrientation::VERTICAL));
// Scroll the page down which moves the thumb down to the viewport bottom.
GetInputHandler().ScrollBegin(BeginState(gfx::Point(), gfx::Vector2dF(0, 800),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
GetInputHandler().ScrollUpdate(UpdateState(gfx::Point(),
gfx::Vector2d(0, 800),
ui::ScrollInputType::kWheel)
.get());
GetInputHandler().ScrollEnd();
// Move the mouse near the thumb in the top position.
GetInputHandler().MouseMoveAt(near_thumb_at_top);
EXPECT_FALSE(scrollbar_controller->MouseIsNearScrollbarThumb(
ScrollbarOrientation::VERTICAL));
// Scroll the page up which moves the thumb back up.
GetInputHandler().ScrollBegin(
BeginState(gfx::Point(), gfx::Vector2dF(0, -800),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
GetInputHandler().ScrollUpdate(UpdateState(gfx::Point(),
gfx::Vector2d(0, -800),
ui::ScrollInputType::kWheel)
.get());
GetInputHandler().ScrollEnd();
// Move the mouse near the thumb in the top position.
GetInputHandler().MouseMoveAt(near_thumb_at_top);
EXPECT_TRUE(scrollbar_controller->MouseIsNearScrollbarThumb(
ScrollbarOrientation::VERTICAL));
}
void LayerTreeHostImplTest::SetupMouseMoveAtWithDeviceScale(
float device_scale_factor) {
LayerTreeSettings settings = DefaultSettings();
settings.scrollbar_fade_delay = base::Milliseconds(500);
settings.scrollbar_fade_duration = base::Milliseconds(300);
settings.scrollbar_animator = LayerTreeSettings::AURA_OVERLAY;
const int thumb_thickness = 15;
gfx::Size viewport_size(300, 200);
gfx::Size content_size(1000, 1000);
gfx::Size scrollbar_size(gfx::Size(thumb_thickness, viewport_size.height()));
CreateHostImpl(settings, CreateLayerTreeFrameSink());
host_impl_->active_tree()->SetDeviceScaleFactor(device_scale_factor);
SetupViewportLayersInnerScrolls(viewport_size, content_size);
LayerImpl* root_scroll = OuterViewportScrollLayer();
// The scrollbar is on the left side.
auto* scrollbar = AddLayer<SolidColorScrollbarLayerImpl>(
host_impl_->active_tree(), ScrollbarOrientation::VERTICAL,
thumb_thickness, 0, true);
SetupScrollbarLayer(root_scroll, scrollbar);
scrollbar->SetBounds(scrollbar_size);
TouchActionRegion touch_action_region;
touch_action_region.Union(TouchAction::kNone, gfx::Rect(scrollbar_size));
scrollbar->SetTouchActionRegion(touch_action_region);
host_impl_->active_tree()->DidBecomeActive();
DrawFrame();
ScrollbarAnimationController* scrollbar_animation_controller =
host_impl_->ScrollbarAnimationControllerForElementId(
root_scroll->element_id());
const float kMouseMoveDistanceToTriggerFadeIn =
scrollbar_animation_controller
->GetScrollbarAnimationController(ScrollbarOrientation::VERTICAL)
.MouseMoveDistanceToTriggerFadeIn();
const float kMouseMoveDistanceToTriggerExpand =
scrollbar_animation_controller
->GetScrollbarAnimationController(ScrollbarOrientation::VERTICAL)
.MouseMoveDistanceToTriggerExpand();
GetInputHandler().MouseMoveAt(
gfx::Point(thumb_thickness + kMouseMoveDistanceToTriggerFadeIn + 1, 1));
EXPECT_FALSE(scrollbar_animation_controller->MouseIsNearScrollbar(
ScrollbarOrientation::VERTICAL));
EXPECT_FALSE(scrollbar_animation_controller->MouseIsNearScrollbarThumb(
ScrollbarOrientation::VERTICAL));
GetInputHandler().MouseMoveAt(
gfx::Point(thumb_thickness + kMouseMoveDistanceToTriggerExpand, 10));
EXPECT_TRUE(scrollbar_animation_controller->MouseIsNearScrollbar(
ScrollbarOrientation::VERTICAL));
EXPECT_TRUE(scrollbar_animation_controller->MouseIsNearScrollbarThumb(
ScrollbarOrientation::VERTICAL));
GetInputHandler().MouseMoveAt(
gfx::Point(thumb_thickness + kMouseMoveDistanceToTriggerFadeIn + 1, 100));
EXPECT_FALSE(scrollbar_animation_controller->MouseIsNearScrollbar(
ScrollbarOrientation::VERTICAL));
EXPECT_FALSE(scrollbar_animation_controller->MouseIsNearScrollbarThumb(
ScrollbarOrientation::VERTICAL));
did_request_redraw_ = false;
EXPECT_FALSE(scrollbar_animation_controller->MouseIsOverScrollbarThumb(
ScrollbarOrientation::VERTICAL));
GetInputHandler().MouseMoveAt(gfx::Point(10, 10));
EXPECT_TRUE(scrollbar_animation_controller->MouseIsOverScrollbarThumb(
ScrollbarOrientation::VERTICAL));
GetInputHandler().MouseMoveAt(gfx::Point(10, 0));
EXPECT_TRUE(scrollbar_animation_controller->MouseIsOverScrollbarThumb(
ScrollbarOrientation::VERTICAL));
GetInputHandler().MouseMoveAt(gfx::Point(150, 120));
EXPECT_FALSE(scrollbar_animation_controller->MouseIsOverScrollbarThumb(
ScrollbarOrientation::VERTICAL));
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, MouseMoveAtWithDeviceScaleOf1) {
SetupMouseMoveAtWithDeviceScale(1);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, MouseMoveAtWithDeviceScaleOf2) {
SetupMouseMoveAtWithDeviceScale(2);
}
// This test verifies that only SurfaceLayers in the viewport and have fallbacks
// that are different are included in viz::CompositorFrameMetadata's
// |activation_dependencies|.
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ActivationDependenciesInMetadata) {
SetupViewportLayersInnerScrolls(gfx::Size(50, 50), gfx::Size(100, 100));
LayerImpl* root = root_layer();
std::vector<viz::SurfaceId> primary_surfaces = {
MakeSurfaceId(viz::FrameSinkId(1, 1), 1),
MakeSurfaceId(viz::FrameSinkId(2, 2), 2),
MakeSurfaceId(viz::FrameSinkId(3, 3), 3)};
std::vector<viz::SurfaceId> fallback_surfaces = {
MakeSurfaceId(viz::FrameSinkId(4, 4), 1),
MakeSurfaceId(viz::FrameSinkId(4, 4), 2),
MakeSurfaceId(viz::FrameSinkId(4, 4), 3)};
for (size_t i = 0; i < primary_surfaces.size(); ++i) {
auto* child = AddLayer<SurfaceLayerImpl>(host_impl_->active_tree());
child->SetBounds(gfx::Size(1, 1));
child->SetDrawsContent(true);
child->SetRange(
viz::SurfaceRange(fallback_surfaces[i], primary_surfaces[i]), 2u);
CopyProperties(root, child);
child->SetOffsetToTransformParent(gfx::Vector2dF(25.0f * i, 0));
}
base::flat_set<viz::SurfaceRange> surfaces_set;
// |fallback_surfaces| and |primary_surfaces| should have same size
for (size_t i = 0; i < fallback_surfaces.size(); ++i) {
surfaces_set.insert(
viz::SurfaceRange(fallback_surfaces[i], primary_surfaces[i]));
}
host_impl_->active_tree()->SetSurfaceRanges(std::move(surfaces_set));
host_impl_->SetFullViewportDamage();
DrawFrame();
{
auto* fake_layer_tree_frame_sink = static_cast<FakeLayerTreeFrameSink*>(
host_impl_->layer_tree_frame_sink());
const viz::CompositorFrameMetadata& metadata =
fake_layer_tree_frame_sink->last_sent_frame()->metadata;
EXPECT_THAT(metadata.activation_dependencies,
testing::UnorderedElementsAre(primary_surfaces[0],
primary_surfaces[1]));
EXPECT_THAT(
metadata.referenced_surfaces,
testing::UnorderedElementsAre(
viz::SurfaceRange(fallback_surfaces[0], primary_surfaces[0]),
viz::SurfaceRange(fallback_surfaces[1], primary_surfaces[1]),
viz::SurfaceRange(fallback_surfaces[2], primary_surfaces[2])));
EXPECT_EQ(2u, metadata.deadline.deadline_in_frames());
EXPECT_FALSE(metadata.deadline.use_default_lower_bound_deadline());
}
// Verify that on the next frame generation that the deadline is reset.
host_impl_->SetFullViewportDamage();
DrawFrame();
{
auto* fake_layer_tree_frame_sink = static_cast<FakeLayerTreeFrameSink*>(
host_impl_->layer_tree_frame_sink());
const viz::CompositorFrameMetadata& metadata =
fake_layer_tree_frame_sink->last_sent_frame()->metadata;
EXPECT_THAT(metadata.activation_dependencies,
testing::UnorderedElementsAre(primary_surfaces[0],
primary_surfaces[1]));
EXPECT_THAT(
metadata.referenced_surfaces,
testing::UnorderedElementsAre(
viz::SurfaceRange(fallback_surfaces[0], primary_surfaces[0]),
viz::SurfaceRange(fallback_surfaces[1], primary_surfaces[1]),
viz::SurfaceRange(fallback_surfaces[2], primary_surfaces[2])));
EXPECT_EQ(0u, metadata.deadline.deadline_in_frames());
EXPECT_FALSE(metadata.deadline.use_default_lower_bound_deadline());
}
}
// Verify that updating the set of referenced surfaces for the active tree
// causes a new CompositorFrame to be submitted, even if there is no other
// damage.
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
SurfaceReferencesChangeCausesDamage) {
SetupViewportLayersInnerScrolls(gfx::Size(50, 50), gfx::Size(100, 100));
auto* fake_layer_tree_frame_sink =
static_cast<FakeLayerTreeFrameSink*>(host_impl_->layer_tree_frame_sink());
// Submit an initial CompositorFrame with an empty set of referenced surfaces.
host_impl_->active_tree()->SetSurfaceRanges({});
host_impl_->SetFullViewportDamage();
DrawFrame();
{
const viz::CompositorFrameMetadata& metadata =
fake_layer_tree_frame_sink->last_sent_frame()->metadata;
EXPECT_THAT(metadata.referenced_surfaces, testing::IsEmpty());
}
const viz::SurfaceId surface_id = MakeSurfaceId(viz::FrameSinkId(1, 1), 1);
// Update the set of referenced surfaces to contain |surface_id| but don't
// make any other changes that would cause damage. This mimics updating the
// SurfaceLayer for an offscreen tab.
host_impl_->active_tree()->SetSurfaceRanges({viz::SurfaceRange(surface_id)});
DrawFrame();
{
const viz::CompositorFrameMetadata& metadata =
fake_layer_tree_frame_sink->last_sent_frame()->metadata;
EXPECT_THAT(metadata.referenced_surfaces,
testing::UnorderedElementsAre(viz::SurfaceRange(surface_id)));
}
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, CompositorFrameMetadata) {
SetupViewportLayersInnerScrolls(gfx::Size(50, 50), gfx::Size(100, 100));
host_impl_->active_tree()->PushPageScaleFromMainThread(1, 0.5f, 4);
DrawFrame();
{
viz::CompositorFrameMetadata metadata =
host_impl_->MakeCompositorFrameMetadata();
EXPECT_EQ(gfx::PointF(), metadata.root_scroll_offset);
EXPECT_EQ(1, metadata.page_scale_factor);
EXPECT_EQ(gfx::SizeF(50, 50), metadata.scrollable_viewport_size);
EXPECT_EQ(0.5f, metadata.min_page_scale_factor);
}
// Scrolling should update metadata immediately.
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), gfx::Vector2dF(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
GetInputHandler().ScrollUpdate(UpdateState(gfx::Point(), gfx::Vector2d(0, 10),
ui::ScrollInputType::kWheel)
.get());
{
viz::CompositorFrameMetadata metadata =
host_impl_->MakeCompositorFrameMetadata();
EXPECT_EQ(gfx::PointF(0, 10), metadata.root_scroll_offset);
}
GetInputHandler().ScrollEnd();
{
viz::CompositorFrameMetadata metadata =
host_impl_->MakeCompositorFrameMetadata();
EXPECT_EQ(gfx::PointF(0, 10), metadata.root_scroll_offset);
}
// Page scale should update metadata correctly (shrinking only the viewport).
GetInputHandler().ScrollBegin(BeginState(gfx::Point(), gfx::Vector2dF(),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
GetInputHandler().PinchGestureBegin(gfx::Point(),
ui::ScrollInputType::kWheel);
GetInputHandler().PinchGestureUpdate(2, gfx::Point());
GetInputHandler().PinchGestureEnd(gfx::Point());
GetInputHandler().ScrollEnd();
{
viz::CompositorFrameMetadata metadata =
host_impl_->MakeCompositorFrameMetadata();
EXPECT_EQ(gfx::PointF(0, 10), metadata.root_scroll_offset);
EXPECT_EQ(2, metadata.page_scale_factor);
EXPECT_EQ(gfx::SizeF(25, 25), metadata.scrollable_viewport_size);
EXPECT_EQ(0.5f, metadata.min_page_scale_factor);
}
// Likewise if set from the main thread.
host_impl_->ProcessCompositorDeltas(/* main_thread_mutator_host */ nullptr);
host_impl_->active_tree()->PushPageScaleFromMainThread(4, 0.5f, 4);
host_impl_->active_tree()->SetPageScaleOnActiveTree(4);
{
viz::CompositorFrameMetadata metadata =
host_impl_->MakeCompositorFrameMetadata();
EXPECT_EQ(gfx::PointF(0, 10), metadata.root_scroll_offset);
EXPECT_EQ(4, metadata.page_scale_factor);
EXPECT_EQ(gfx::SizeF(12.5f, 12.5f), metadata.scrollable_viewport_size);
EXPECT_EQ(0.5f, metadata.min_page_scale_factor);
}
}
class DidDrawCheckLayer : public LayerImpl {
public:
static std::unique_ptr<DidDrawCheckLayer> Create(LayerTreeImpl* tree_impl,
int id) {
return base::WrapUnique(new DidDrawCheckLayer(tree_impl, id));
}
bool WillDraw(DrawMode draw_mode,
viz::ClientResourceProvider* provider) override {
if (!LayerImpl::WillDraw(draw_mode, provider))
return false;
if (will_draw_returns_false_)
return false;
will_draw_returned_true_ = true;
return true;
}
void AppendQuads(viz::CompositorRenderPass* render_pass,
AppendQuadsData* append_quads_data) override {
append_quads_called_ = true;
LayerImpl::AppendQuads(render_pass, append_quads_data);
}
void DidDraw(viz::ClientResourceProvider* provider) override {
did_draw_called_ = true;
LayerImpl::DidDraw(provider);
}
bool will_draw_returned_true() const { return will_draw_returned_true_; }
bool append_quads_called() const { return append_quads_called_; }
bool did_draw_called() const { return did_draw_called_; }
void set_will_draw_returns_false() { will_draw_returns_false_ = true; }
void ClearDidDrawCheck() {
will_draw_returned_true_ = false;
append_quads_called_ = false;
did_draw_called_ = false;
}
protected:
DidDrawCheckLayer(LayerTreeImpl* tree_impl, int id)
: LayerImpl(tree_impl, id),
will_draw_returns_false_(false),
will_draw_returned_true_(false),
append_quads_called_(false),
did_draw_called_(false) {
SetBounds(gfx::Size(10, 10));
SetDrawsContent(true);
draw_properties().visible_layer_rect = gfx::Rect(0, 0, 10, 10);
}
private:
bool will_draw_returns_false_;
bool will_draw_returned_true_;
bool append_quads_called_;
bool did_draw_called_;
};
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
DamageShouldNotCareAboutContributingLayers) {
auto* root = SetupRootLayer<DidDrawCheckLayer>(host_impl_->active_tree(),
gfx::Size(10, 10));
// Make a child layer that draws.
auto* layer = AddLayer<SolidColorLayerImpl>(host_impl_->active_tree());
layer->SetBounds(gfx::Size(10, 10));
layer->SetDrawsContent(true);
layer->SetBackgroundColor(SkColors::kRed);
CopyProperties(root, layer);
UpdateDrawProperties(host_impl_->active_tree());
{
TestFrameData frame;
auto args = viz::CreateBeginFrameArgsForTesting(
BEGINFRAME_FROM_HERE, viz::BeginFrameArgs::kManualSourceId, 1,
base::TimeTicks() + base::Milliseconds(1));
host_impl_->WillBeginImplFrame(args);
EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame));
EXPECT_FALSE(frame.has_no_damage);
EXPECT_NE(frame.render_passes.size(), 0u);
size_t total_quad_count = 0;
for (const auto& pass : frame.render_passes)
total_quad_count += pass->quad_list.size();
EXPECT_NE(total_quad_count, 0u);
host_impl_->DrawLayers(&frame);
host_impl_->DidDrawAllLayers(frame);
host_impl_->DidFinishImplFrame(args);
}
// Stops the child layer from drawing. We should have damage from this but
// should not have any quads. This should clear the damaged area.
layer->SetDrawsContent(false);
GetEffectNode(root)->opacity = 0;
UpdateDrawProperties(host_impl_->active_tree());
// The background is default to transparent. If the background is opaque, we
// would fill the frame with background colour when no layers are contributing
// quads. This means we would end up with 0 quad.
EXPECT_EQ(host_impl_->active_tree()->background_color(),
SkColors::kTransparent);
{
TestFrameData frame;
auto args = viz::CreateBeginFrameArgsForTesting(
BEGINFRAME_FROM_HERE, viz::BeginFrameArgs::kManualSourceId, 1,
base::TimeTicks() + base::Milliseconds(1));
host_impl_->WillBeginImplFrame(args);
EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame));
EXPECT_FALSE(frame.has_no_damage);
EXPECT_NE(frame.render_passes.size(), 0u);
size_t total_quad_count = 0;
for (const auto& pass : frame.render_passes)
total_quad_count += pass->quad_list.size();
EXPECT_EQ(total_quad_count, 0u);
host_impl_->DrawLayers(&frame);
host_impl_->DidDrawAllLayers(frame);
host_impl_->DidFinishImplFrame(args);
}
// Now tries to draw again. Nothing changes, so should have no damage, no
// render pass, and no quad.
{
TestFrameData frame;
auto args = viz::CreateBeginFrameArgsForTesting(
BEGINFRAME_FROM_HERE, viz::BeginFrameArgs::kManualSourceId, 1,
base::TimeTicks() + base::Milliseconds(1));
host_impl_->WillBeginImplFrame(args);
EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame));
EXPECT_TRUE(frame.has_no_damage);
EXPECT_EQ(frame.render_passes.size(), 0u);
size_t total_quad_count = 0;
for (const auto& pass : frame.render_passes)
total_quad_count += pass->quad_list.size();
EXPECT_EQ(total_quad_count, 0u);
host_impl_->DrawLayers(&frame);
host_impl_->DidDrawAllLayers(frame);
host_impl_->DidFinishImplFrame(args);
}
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, WillDrawReturningFalseDoesNotCall) {
// The root layer is always drawn, so run this test on a child layer that
// will be masked out by the root layer's bounds.
auto* root = SetupRootLayer<DidDrawCheckLayer>(host_impl_->active_tree(),
gfx::Size(10, 10));
auto* layer = AddLayer<DidDrawCheckLayer>(host_impl_->active_tree());
CopyProperties(root, layer);
DrawFrame();
EXPECT_TRUE(layer->will_draw_returned_true());
EXPECT_TRUE(layer->append_quads_called());
EXPECT_TRUE(layer->did_draw_called());
host_impl_->SetViewportDamage(gfx::Rect(10, 10));
layer->set_will_draw_returns_false();
layer->ClearDidDrawCheck();
DrawFrame();
EXPECT_FALSE(layer->will_draw_returned_true());
EXPECT_FALSE(layer->append_quads_called());
EXPECT_FALSE(layer->did_draw_called());
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, DidDrawNotCalledOnHiddenLayer) {
// The root layer is always drawn, so run this test on a child layer that
// will be masked out by the root layer's bounds.
auto* root = SetupRootLayer<DidDrawCheckLayer>(host_impl_->active_tree(),
gfx::Size(10, 10));
CreateClipNode(root);
auto* layer = AddLayer<DidDrawCheckLayer>(host_impl_->active_tree());
layer->SetBounds(gfx::Size(10, 10));
CopyProperties(root, layer);
// Ensure visible_layer_rect for layer is not empty
layer->SetOffsetToTransformParent(gfx::Vector2dF(100, 100));
UpdateDrawProperties(host_impl_->active_tree());
EXPECT_FALSE(layer->will_draw_returned_true());
EXPECT_FALSE(layer->did_draw_called());
DrawFrame();
EXPECT_FALSE(layer->will_draw_returned_true());
EXPECT_FALSE(layer->did_draw_called());
EXPECT_TRUE(layer->visible_layer_rect().IsEmpty());
// Ensure visible_layer_rect for layer is not empty
layer->SetOffsetToTransformParent(gfx::Vector2dF());
layer->NoteLayerPropertyChanged();
UpdateDrawProperties(host_impl_->active_tree());
EXPECT_FALSE(layer->will_draw_returned_true());
EXPECT_FALSE(layer->did_draw_called());
DrawFrame();
EXPECT_TRUE(layer->will_draw_returned_true());
EXPECT_TRUE(layer->did_draw_called());
EXPECT_FALSE(layer->visible_layer_rect().IsEmpty());
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, WillDrawNotCalledOnOccludedLayer) {
gfx::Size big_size(1000, 1000);
auto* root =
SetupRootLayer<DidDrawCheckLayer>(host_impl_->active_tree(), big_size);
auto* occluded_layer = AddLayer<DidDrawCheckLayer>(host_impl_->active_tree());
CopyProperties(root, occluded_layer);
auto* top_layer = AddLayer<DidDrawCheckLayer>(host_impl_->active_tree());
// This layer covers the occluded_layer above. Make this layer large so it can
// occlude.
top_layer->SetBounds(big_size);
top_layer->SetContentsOpaque(true);
CopyProperties(occluded_layer, top_layer);
UpdateDrawProperties(host_impl_->active_tree());
EXPECT_FALSE(occluded_layer->will_draw_returned_true());
EXPECT_FALSE(occluded_layer->did_draw_called());
EXPECT_FALSE(top_layer->will_draw_returned_true());
EXPECT_FALSE(top_layer->did_draw_called());
DrawFrame();
EXPECT_FALSE(occluded_layer->will_draw_returned_true());
EXPECT_FALSE(occluded_layer->did_draw_called());
EXPECT_TRUE(top_layer->will_draw_returned_true());
EXPECT_TRUE(top_layer->did_draw_called());
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, DidDrawCalledOnAllLayers) {
auto* root = SetupRootLayer<DidDrawCheckLayer>(host_impl_->active_tree(),
gfx::Size(10, 10));
auto* layer1 = AddLayer<DidDrawCheckLayer>(host_impl_->active_tree());
auto* layer2 = AddLayer<DidDrawCheckLayer>(host_impl_->active_tree());
CopyProperties(root, layer1);
CreateTransformNode(layer1).flattens_inherited_transform = true;
CreateEffectNode(layer1).render_surface_reason = RenderSurfaceReason::kTest;
CopyProperties(layer1, layer2);
UpdateDrawProperties(host_impl_->active_tree());
EXPECT_FALSE(root->did_draw_called());
EXPECT_FALSE(layer1->did_draw_called());
EXPECT_FALSE(layer2->did_draw_called());
DrawFrame();
EXPECT_TRUE(root->did_draw_called());
EXPECT_TRUE(layer1->did_draw_called());
EXPECT_TRUE(layer2->did_draw_called());
EXPECT_NE(GetRenderSurface(root), GetRenderSurface(layer1));
EXPECT_TRUE(GetRenderSurface(layer1));
}
class MissingTextureAnimatingLayer : public DidDrawCheckLayer {
public:
static std::unique_ptr<MissingTextureAnimatingLayer> Create(
LayerTreeImpl* tree_impl,
int id,
bool tile_missing,
bool had_incomplete_tile,
bool animating,
scoped_refptr<AnimationTimeline> timeline) {
return base::WrapUnique(new MissingTextureAnimatingLayer(
tree_impl, id, tile_missing, had_incomplete_tile, animating, timeline));
}
void AppendQuads(viz::CompositorRenderPass* render_pass,
AppendQuadsData* append_quads_data) override {
LayerImpl::AppendQuads(render_pass, append_quads_data);
if (had_incomplete_tile_)
append_quads_data->num_incomplete_tiles++;
if (tile_missing_)
append_quads_data->num_missing_tiles++;
}
private:
MissingTextureAnimatingLayer(LayerTreeImpl* tree_impl,
int id,
bool tile_missing,
bool had_incomplete_tile,
bool animating,
scoped_refptr<AnimationTimeline> timeline)
: DidDrawCheckLayer(tree_impl, id),
tile_missing_(tile_missing),
had_incomplete_tile_(had_incomplete_tile) {
if (animating) {
this->SetElementId(LayerIdToElementIdForTesting(id));
AddAnimatedTransformToElementWithAnimation(this->element_id(), timeline,
10.0, 3, 0);
}
}
bool tile_missing_;
bool had_incomplete_tile_;
};
struct PrepareToDrawSuccessTestCase {
explicit PrepareToDrawSuccessTestCase(DrawResult result)
: expected_result(result) {}
struct State {
bool has_missing_tile = false;
bool has_incomplete_tile = false;
bool is_animating = false;
};
bool high_res_required = false;
State layer_before;
State layer_between;
State layer_after;
DrawResult expected_result;
};
class LayerTreeHostImplPrepareToDrawTest : public LayerTreeHostImplTest {
public:
void CreateLayerFromState(DidDrawCheckLayer* root,
const scoped_refptr<AnimationTimeline>& timeline,
const PrepareToDrawSuccessTestCase::State& state) {
auto* layer = AddLayer<MissingTextureAnimatingLayer>(
root->layer_tree_impl(), state.has_missing_tile,
state.has_incomplete_tile, state.is_animating, timeline);
CopyProperties(root, layer);
if (state.is_animating)
CreateTransformNode(layer).has_potential_animation = true;
}
};
TEST_F(LayerTreeHostImplPrepareToDrawTest, PrepareToDrawSucceedsAndFails) {
LayerTreeSettings settings = DefaultSettings();
settings.commit_to_active_tree = false;
CreateHostImpl(settings, CreateLayerTreeFrameSink());
std::vector<PrepareToDrawSuccessTestCase> cases;
// 0. Default case.
cases.push_back(PrepareToDrawSuccessTestCase(DRAW_SUCCESS));
// 1. Animated layer first.
cases.push_back(PrepareToDrawSuccessTestCase(DRAW_SUCCESS));
cases.back().layer_before.is_animating = true;
// 2. Animated layer between.
cases.push_back(PrepareToDrawSuccessTestCase(DRAW_SUCCESS));
cases.back().layer_between.is_animating = true;
// 3. Animated layer last.
cases.push_back(PrepareToDrawSuccessTestCase(DRAW_SUCCESS));
cases.back().layer_after.is_animating = true;
// 4. Missing tile first.
cases.push_back(PrepareToDrawSuccessTestCase(DRAW_SUCCESS));
cases.back().layer_before.has_missing_tile = true;
// 5. Missing tile between.
cases.push_back(PrepareToDrawSuccessTestCase(DRAW_SUCCESS));
cases.back().layer_between.has_missing_tile = true;
// 6. Missing tile last.
cases.push_back(PrepareToDrawSuccessTestCase(DRAW_SUCCESS));
cases.back().layer_after.has_missing_tile = true;
// 7. Incomplete tile first.
cases.push_back(PrepareToDrawSuccessTestCase(DRAW_SUCCESS));
cases.back().layer_before.has_incomplete_tile = true;
// 8. Incomplete tile between.
cases.push_back(PrepareToDrawSuccessTestCase(DRAW_SUCCESS));
cases.back().layer_between.has_incomplete_tile = true;
// 9. Incomplete tile last.
cases.push_back(PrepareToDrawSuccessTestCase(DRAW_SUCCESS));
cases.back().layer_after.has_incomplete_tile = true;
// 10. Animation with missing tile.
cases.push_back(
PrepareToDrawSuccessTestCase(DRAW_ABORTED_CHECKERBOARD_ANIMATIONS));
cases.back().layer_between.has_missing_tile = true;
cases.back().layer_between.is_animating = true;
// 11. Animation with incomplete tile.
cases.push_back(PrepareToDrawSuccessTestCase(DRAW_SUCCESS));
cases.back().layer_between.has_incomplete_tile = true;
cases.back().layer_between.is_animating = true;
// 12. High res required.
cases.push_back(PrepareToDrawSuccessTestCase(DRAW_SUCCESS));
cases.back().high_res_required = true;
// 13. High res required with incomplete tile.
cases.push_back(
PrepareToDrawSuccessTestCase(DRAW_ABORTED_MISSING_HIGH_RES_CONTENT));
cases.back().high_res_required = true;
cases.back().layer_between.has_incomplete_tile = true;
// 14. High res required with missing tile.
cases.push_back(
PrepareToDrawSuccessTestCase(DRAW_ABORTED_MISSING_HIGH_RES_CONTENT));
cases.back().high_res_required = true;
cases.back().layer_between.has_missing_tile = true;
// 15. High res required is higher priority than animating missing tiles.
cases.push_back(
PrepareToDrawSuccessTestCase(DRAW_ABORTED_MISSING_HIGH_RES_CONTENT));
cases.back().high_res_required = true;
cases.back().layer_between.has_missing_tile = true;
cases.back().layer_after.has_missing_tile = true;
cases.back().layer_after.is_animating = true;
// 16. High res required is higher priority than animating missing tiles.
cases.push_back(
PrepareToDrawSuccessTestCase(DRAW_ABORTED_MISSING_HIGH_RES_CONTENT));
cases.back().high_res_required = true;
cases.back().layer_between.has_missing_tile = true;
cases.back().layer_before.has_missing_tile = true;
cases.back().layer_before.is_animating = true;
auto* root = SetupRootLayer<DidDrawCheckLayer>(host_impl_->active_tree(),
gfx::Size(10, 10));
UpdateDrawProperties(host_impl_->active_tree());
DrawFrame();
for (size_t i = 0; i < cases.size(); ++i) {
// Clean up host_impl_ state.
const auto& testcase = cases[i];
host_impl_->active_tree()->DetachLayersKeepingRootLayerForTesting();
timeline()->ClearAnimations();
std::ostringstream scope;
scope << "Test case: " << i;
SCOPED_TRACE(scope.str());
CreateLayerFromState(root, timeline(), testcase.layer_before);
CreateLayerFromState(root, timeline(), testcase.layer_between);
CreateLayerFromState(root, timeline(), testcase.layer_after);
UpdateDrawProperties(host_impl_->active_tree());
if (testcase.high_res_required)
host_impl_->SetRequiresHighResToDraw();
TestFrameData frame;
auto args = viz::CreateBeginFrameArgsForTesting(
BEGINFRAME_FROM_HERE, viz::BeginFrameArgs::kManualSourceId, 1,
base::TimeTicks() + base::Milliseconds(1));
host_impl_->WillBeginImplFrame(args);
EXPECT_EQ(testcase.expected_result, host_impl_->PrepareToDraw(&frame));
host_impl_->DrawLayers(&frame);
host_impl_->DidDrawAllLayers(frame);
host_impl_->DidFinishImplFrame(args);
}
}
TEST_F(LayerTreeHostImplPrepareToDrawTest,
PrepareToDrawWhenDrawAndSwapFullViewportEveryFrame) {
CreateHostImpl(DefaultSettings(), FakeLayerTreeFrameSink::CreateSoftware());
const gfx::Transform external_transform;
const gfx::Rect external_viewport;
const bool resourceless_software_draw = true;
host_impl_->SetExternalTilePriorityConstraints(external_viewport,
external_transform);
std::vector<PrepareToDrawSuccessTestCase> cases;
// 0. Default case.
cases.push_back(PrepareToDrawSuccessTestCase(DRAW_SUCCESS));
// 1. Animation with missing tile.
cases.push_back(PrepareToDrawSuccessTestCase(DRAW_SUCCESS));
cases.back().layer_between.has_missing_tile = true;
cases.back().layer_between.is_animating = true;
// 2. High res required with incomplete tile.
cases.push_back(PrepareToDrawSuccessTestCase(DRAW_SUCCESS));
cases.back().high_res_required = true;
cases.back().layer_between.has_incomplete_tile = true;
// 3. High res required with missing tile.
cases.push_back(PrepareToDrawSuccessTestCase(DRAW_SUCCESS));
cases.back().high_res_required = true;
cases.back().layer_between.has_missing_tile = true;
auto* root = SetupRootLayer<DidDrawCheckLayer>(host_impl_->active_tree(),
gfx::Size(10, 10));
UpdateDrawProperties(host_impl_->active_tree());
host_impl_->OnDraw(external_transform, external_viewport,
resourceless_software_draw, false);
for (size_t i = 0; i < cases.size(); ++i) {
const auto& testcase = cases[i];
host_impl_->active_tree()->DetachLayersKeepingRootLayerForTesting();
std::ostringstream scope;
scope << "Test case: " << i;
SCOPED_TRACE(scope.str());
CreateLayerFromState(root, timeline(), testcase.layer_before);
CreateLayerFromState(root, timeline(), testcase.layer_between);
CreateLayerFromState(root, timeline(), testcase.layer_after);
if (testcase.high_res_required)
host_impl_->SetRequiresHighResToDraw();
host_impl_->OnDraw(external_transform, external_viewport,
resourceless_software_draw, false);
}
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollRootIgnored) {
SetupDefaultRootLayer(gfx::Size(10, 10));
DrawFrame();
// Scroll event is ignored because layer is not scrollable and there is no
// viewport.
InputHandler::ScrollStatus status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(), gfx::Vector2dF(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
EXPECT_EQ(ScrollThread::SCROLL_IGNORED, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kNoScrollingLayer,
status.main_thread_scrolling_reasons);
EXPECT_FALSE(did_request_redraw_);
EXPECT_FALSE(did_request_commit_);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ClampingAfterActivation) {
CreatePendingTree();
host_impl_->pending_tree()->PushPageScaleFromMainThread(1, 1, 1);
SetupViewportLayers(host_impl_->pending_tree(), gfx::Size(50, 50),
gfx::Size(100, 100), gfx::Size(100, 100));
host_impl_->ActivateSyncTree();
CreatePendingTree();
const gfx::PointF pending_scroll(-100, -100);
LayerImpl* active_outer_layer = OuterViewportScrollLayer();
LayerImpl* pending_outer_layer =
host_impl_->pending_tree()->OuterViewportScrollLayerForTesting();
pending_outer_layer->layer_tree_impl()
->property_trees()
->scroll_tree_mutable()
.UpdateScrollOffsetBaseForTesting(pending_outer_layer->element_id(),
pending_scroll);
host_impl_->ActivateSyncTree();
// Scrolloffsets on the active tree will be clamped after activation.
EXPECT_EQ(CurrentScrollOffset(active_outer_layer), gfx::PointF(0, 0));
}
class LayerTreeHostImplBrowserControlsTest
: public ScrollUnifiedLayerTreeHostImplTest {
public:
LayerTreeHostImplBrowserControlsTest()
// Make the clip size the same as the layer (content) size so the layer is
// non-scrollable.
: layer_size_(10, 10), clip_size_(layer_size_), top_controls_height_(50) {
viewport_size_ = gfx::Size(clip_size_.width(),
clip_size_.height() + top_controls_height_);
}
bool CreateHostImpl(
const LayerTreeSettings& settings,
std::unique_ptr<LayerTreeFrameSink> layer_tree_frame_sink) override {
bool init = LayerTreeHostImplTest::CreateHostImpl(
settings, std::move(layer_tree_frame_sink));
if (init) {
host_impl_->active_tree()->SetBrowserControlsParams(
{top_controls_height_, 0, 0, 0, false, false});
host_impl_->active_tree()->SetCurrentBrowserControlsShownRatio(1.f, 1.f);
host_impl_->active_tree()->PushPageScaleFromMainThread(1.f, 1.f, 1.f);
}
return init;
}
protected:
void SetupBrowserControlsAndScrollLayerWithVirtualViewport(
const gfx::Size& inner_viewport_size,
const gfx::Size& outer_viewport_size,
const gfx::Size& scroll_layer_size) {
SetupBrowserControlsAndScrollLayerWithVirtualViewport(
host_impl_->active_tree(), inner_viewport_size, outer_viewport_size,
scroll_layer_size);
}
void SetupBrowserControlsAndScrollLayerWithVirtualViewport(
LayerTreeImpl* tree_impl,
const gfx::Size& inner_viewport_size,
const gfx::Size& outer_viewport_size,
const gfx::Size& scroll_layer_size) {
tree_impl->SetBrowserControlsParams(
{top_controls_height_, 0, 0, 0, false, true});
tree_impl->SetCurrentBrowserControlsShownRatio(1.f, 1.f);
tree_impl->PushPageScaleFromMainThread(1.f, 1.f, 1.f);
host_impl_->DidChangeBrowserControlsPosition();
SetupViewportLayers(tree_impl, inner_viewport_size, outer_viewport_size,
scroll_layer_size);
}
gfx::Size layer_size_;
gfx::Size clip_size_;
gfx::Size viewport_size_;
float top_controls_height_;
LayerTreeSettings settings_;
}; // class LayerTreeHostImplBrowserControlsTest
INSTANTIATE_TEST_SUITE_P(All,
LayerTreeHostImplBrowserControlsTest,
testing::Bool());
#define EXPECT_VIEWPORT_GEOMETRIES(expected_browser_controls_shown_ratio) \
do { \
auto* tree = host_impl_->active_tree(); \
auto* property_trees = tree->property_trees(); \
EXPECT_EQ(expected_browser_controls_shown_ratio, \
tree->CurrentTopControlsShownRatio()); \
EXPECT_EQ( \
tree->top_controls_height() * expected_browser_controls_shown_ratio, \
host_impl_->browser_controls_manager()->ContentTopOffset()); \
int delta = \
(tree->top_controls_height() + tree->bottom_controls_height()) * \
(1 - expected_browser_controls_shown_ratio); \
int scaled_delta = delta / tree->min_page_scale_factor(); \
gfx::Size inner_scroll_bounds = tree->InnerViewportScrollNode()->bounds; \
inner_scroll_bounds.Enlarge(0, scaled_delta); \
EXPECT_EQ(inner_scroll_bounds, InnerViewportScrollLayer()->bounds()); \
EXPECT_EQ(gfx::RectF(gfx::SizeF(inner_scroll_bounds)), \
tree->OuterViewportClipNode()->clip); \
EXPECT_EQ(gfx::Vector2dF(0, delta), \
property_trees->inner_viewport_container_bounds_delta()); \
EXPECT_EQ(gfx::Vector2dF(0, scaled_delta), \
property_trees->outer_viewport_container_bounds_delta()); \
} while (false)
// Tests that, on a page with content the same size as the viewport, hiding
// the browser controls also increases the ScrollableSize (i.e. the content
// size). Since the viewport got larger, the effective scrollable "content" also
// did. This ensures, for one thing, that the overscroll glow is shown in the
// right place.
TEST_P(LayerTreeHostImplBrowserControlsTest,
HidingBrowserControlsExpandsScrollableSize) {
SetupBrowserControlsAndScrollLayerWithVirtualViewport(
gfx::Size(50, 50), gfx::Size(50, 50), gfx::Size(50, 50));
LayerTreeImpl* active_tree = host_impl_->active_tree();
DrawFrame();
// The browser controls should start off showing so the viewport should be
// shrunk.
EXPECT_VIEWPORT_GEOMETRIES(1);
EXPECT_EQ(gfx::SizeF(50, 50), active_tree->ScrollableSize());
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), gfx::Vector2dF(0, 25),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
host_impl_->browser_controls_manager()->ScrollBegin();
// Hide the browser controls by a bit, the scrollable size should increase but
// the actual content bounds shouldn't.
host_impl_->browser_controls_manager()->ScrollBy(gfx::Vector2dF(0, 25));
EXPECT_VIEWPORT_GEOMETRIES(0.5f);
EXPECT_EQ(gfx::SizeF(50, 75), active_tree->ScrollableSize());
// Fully hide the browser controls.
host_impl_->browser_controls_manager()->ScrollBy(gfx::Vector2dF(0, 25));
EXPECT_VIEWPORT_GEOMETRIES(0);
EXPECT_EQ(gfx::SizeF(50, 100), active_tree->ScrollableSize());
// Scrolling additionally shouldn't have any effect.
host_impl_->browser_controls_manager()->ScrollBy(gfx::Vector2dF(0, 25));
EXPECT_VIEWPORT_GEOMETRIES(0);
EXPECT_EQ(gfx::SizeF(50, 100), active_tree->ScrollableSize());
host_impl_->browser_controls_manager()->ScrollEnd();
GetInputHandler().ScrollEnd();
}
TEST_P(LayerTreeHostImplBrowserControlsTest,
HidingBrowserControlsExpandsClipAncestorsOfReplacedOuterScroller) {
SetupBrowserControlsAndScrollLayerWithVirtualViewport(
gfx::Size(180, 180), gfx::Size(180, 180), gfx::Size(180, 180));
LayerTreeImpl* active_tree = host_impl_->active_tree();
PropertyTrees* property_trees = active_tree->property_trees();
LayerImpl* original_outer_scroll = OuterViewportScrollLayer();
LayerImpl* parent_clip_layer = AddLayer();
CopyProperties(original_outer_scroll, parent_clip_layer);
parent_clip_layer->SetBounds(gfx::Size(160, 160));
CreateClipNode(parent_clip_layer);
LayerImpl* clip_layer = AddLayer();
clip_layer->SetBounds(gfx::Size(150, 150));
CopyProperties(parent_clip_layer, clip_layer);
CreateClipNode(clip_layer);
LayerImpl* scroll_layer =
AddScrollableLayer(clip_layer, gfx::Size(150, 150), gfx::Size(300, 300));
GetScrollNode(scroll_layer)->scrolls_outer_viewport = true;
ClipNode* original_outer_clip = GetClipNode(original_outer_scroll);
ClipNode* parent_clip = GetClipNode(parent_clip_layer);
ClipNode* scroll_clip = GetClipNode(clip_layer);
auto viewport_property_ids = active_tree->ViewportPropertyIdsForTesting();
viewport_property_ids.outer_clip = clip_layer->clip_tree_index();
viewport_property_ids.outer_scroll = scroll_layer->scroll_tree_index();
active_tree->SetViewportPropertyIds(viewport_property_ids);
UpdateDrawProperties(active_tree);
EXPECT_EQ(scroll_layer, OuterViewportScrollLayer());
EXPECT_EQ(GetScrollNode(scroll_layer),
active_tree->OuterViewportScrollNode());
EXPECT_EQ(1, active_tree->CurrentTopControlsShownRatio());
EXPECT_EQ(50, host_impl_->browser_controls_manager()->ContentTopOffset());
EXPECT_EQ(gfx::Vector2dF(),
property_trees->inner_viewport_container_bounds_delta());
EXPECT_EQ(gfx::Vector2dF(),
property_trees->outer_viewport_container_bounds_delta());
EXPECT_EQ(gfx::SizeF(300, 300), active_tree->ScrollableSize());
EXPECT_EQ(gfx::RectF(0, 0, 180, 180), original_outer_clip->clip);
EXPECT_EQ(gfx::RectF(0, 0, 160, 160), parent_clip->clip);
EXPECT_EQ(gfx::RectF(0, 0, 150, 150), scroll_clip->clip);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), gfx::Vector2dF(0, 25),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
// Hide the browser controls by a bit, the scrollable size should increase but
// the actual content bounds shouldn't.
host_impl_->browser_controls_manager()->ScrollBy(gfx::Vector2dF(0, 25));
EXPECT_EQ(0.5f, active_tree->CurrentTopControlsShownRatio());
EXPECT_EQ(25, host_impl_->browser_controls_manager()->ContentTopOffset());
EXPECT_EQ(gfx::Vector2dF(0, 25),
property_trees->inner_viewport_container_bounds_delta());
EXPECT_EQ(gfx::Vector2dF(0, 25),
property_trees->outer_viewport_container_bounds_delta());
EXPECT_EQ(gfx::SizeF(300, 300), active_tree->ScrollableSize());
EXPECT_EQ(gfx::RectF(0, 0, 150, 175), scroll_clip->clip);
EXPECT_EQ(gfx::RectF(0, 0, 160, 175), parent_clip->clip);
EXPECT_EQ(gfx::RectF(0, 0, 180, 180), original_outer_clip->clip);
// Fully hide the browser controls.
host_impl_->browser_controls_manager()->ScrollBy(gfx::Vector2dF(0, 25));
EXPECT_EQ(0, active_tree->CurrentTopControlsShownRatio());
EXPECT_EQ(0, host_impl_->browser_controls_manager()->ContentTopOffset());
EXPECT_EQ(gfx::Vector2dF(0, 50),
property_trees->inner_viewport_container_bounds_delta());
EXPECT_EQ(gfx::Vector2dF(0, 50),
property_trees->outer_viewport_container_bounds_delta());
EXPECT_EQ(gfx::SizeF(300, 300), active_tree->ScrollableSize());
EXPECT_EQ(gfx::RectF(0, 0, 150, 200), scroll_clip->clip);
EXPECT_EQ(gfx::RectF(0, 0, 160, 200), parent_clip->clip);
EXPECT_EQ(gfx::RectF(0, 0, 180, 200), original_outer_clip->clip);
// Scrolling additionally shouldn't have any effect.
host_impl_->browser_controls_manager()->ScrollBy(gfx::Vector2dF(0, 25));
EXPECT_EQ(0, active_tree->CurrentTopControlsShownRatio());
EXPECT_EQ(0, host_impl_->browser_controls_manager()->ContentTopOffset());
EXPECT_EQ(gfx::Vector2dF(0, 50),
property_trees->inner_viewport_container_bounds_delta());
EXPECT_EQ(gfx::Vector2dF(0, 50),
property_trees->outer_viewport_container_bounds_delta());
EXPECT_EQ(gfx::SizeF(300, 300), active_tree->ScrollableSize());
EXPECT_EQ(gfx::RectF(0, 0, 150, 200), scroll_clip->clip);
EXPECT_EQ(gfx::RectF(0, 0, 160, 200), parent_clip->clip);
EXPECT_EQ(gfx::RectF(0, 0, 180, 200), original_outer_clip->clip);
host_impl_->browser_controls_manager()->ScrollEnd();
GetInputHandler().ScrollEnd();
}
// Ensure that moving the browser controls (i.e. omnibox/url-bar on mobile) on
// pages with a non-1 minimum page scale factor (e.g. legacy desktop page)
// correctly scales the clipping adjustment performed to show the newly exposed
// region of the page.
TEST_P(LayerTreeHostImplBrowserControlsTest,
MovingBrowserControlsOuterClipDeltaScaled) {
gfx::Size inner_size = gfx::Size(100, 100);
gfx::Size outer_size = gfx::Size(100, 100);
gfx::Size content_size = gfx::Size(200, 1000);
SetupBrowserControlsAndScrollLayerWithVirtualViewport(inner_size, outer_size,
content_size);
LayerTreeImpl* active_tree = host_impl_->active_tree();
// Create a content layer beneath the outer viewport scroll layer.
LayerImpl* content = AddLayer();
content->SetBounds(gfx::Size(100, 100));
CopyProperties(OuterViewportScrollLayer(), content);
active_tree->PushPageScaleFromMainThread(0.5f, 0.5f, 4);
DrawFrame();
// The browser controls should start off showing so the viewport should be
// shrunk.
EXPECT_VIEWPORT_GEOMETRIES(1.0f);
EXPECT_EQ(gfx::SizeF(200, 1000), active_tree->ScrollableSize());
ASSERT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), gfx::Vector2dF(0, 25),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
// Hide the browser controls by 25px. The outer clip should expand by 50px as
// because the outer viewport is sized based on the minimum scale, in this
// case 0.5. Therefore, changes to the outer viewport need to be divided by
// the minimum scale as well.
GetInputHandler().ScrollUpdate(UpdateState(gfx::Point(0, 0),
gfx::Vector2dF(0, 25),
ui::ScrollInputType::kTouchscreen)
.get());
EXPECT_VIEWPORT_GEOMETRIES(0.5f);
GetInputHandler().ScrollEnd();
}
// Tests that browser controls affect the position of horizontal scrollbars.
TEST_P(LayerTreeHostImplBrowserControlsTest,
HidingBrowserControlsAdjustsScrollbarPosition) {
SetupBrowserControlsAndScrollLayerWithVirtualViewport(
gfx::Size(50, 50), gfx::Size(50, 50), gfx::Size(50, 50));
LayerTreeImpl* active_tree = host_impl_->active_tree();
// Create a horizontal scrollbar.
gfx::Size scrollbar_size(gfx::Size(50, 15));
auto* scrollbar_layer = AddLayer<SolidColorScrollbarLayerImpl>(
host_impl_->active_tree(), ScrollbarOrientation::HORIZONTAL, 3, 20,
false);
SetupScrollbarLayer(OuterViewportScrollLayer(), scrollbar_layer);
scrollbar_layer->SetBounds(scrollbar_size);
TouchActionRegion touch_action_region;
touch_action_region.Union(TouchAction::kNone, gfx::Rect(scrollbar_size));
scrollbar_layer->SetTouchActionRegion(touch_action_region);
scrollbar_layer->SetOffsetToTransformParent(gfx::Vector2dF(0, 35));
UpdateDrawProperties(host_impl_->active_tree());
host_impl_->active_tree()->UpdateScrollbarGeometries();
DrawFrame();
// The browser controls should start off showing so the viewport should be
// shrunk.
EXPECT_VIEWPORT_GEOMETRIES(1.0f);
EXPECT_EQ(gfx::SizeF(50, 50), active_tree->ScrollableSize());
EXPECT_EQ(gfx::Size(50, 15), scrollbar_layer->bounds());
EXPECT_EQ(gfx::Rect(20, 0, 10, 3), scrollbar_layer->ComputeThumbQuadRect());
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), gfx::Vector2dF(0, 25),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
host_impl_->browser_controls_manager()->ScrollBegin();
// Hide the browser controls by a bit, the scrollable size should increase but
// the actual content bounds shouldn't.
{
host_impl_->browser_controls_manager()->ScrollBy(gfx::Vector2dF(0, 25));
host_impl_->active_tree()->UpdateScrollbarGeometries();
EXPECT_VIEWPORT_GEOMETRIES(0.5f);
EXPECT_EQ(gfx::SizeF(50, 75), active_tree->ScrollableSize());
EXPECT_EQ(gfx::Size(50, 15), scrollbar_layer->bounds());
EXPECT_EQ(gfx::Rect(20, 25, 10, 3),
scrollbar_layer->ComputeThumbQuadRect());
}
// Fully hide the browser controls.
{
host_impl_->browser_controls_manager()->ScrollBy(gfx::Vector2dF(0, 25));
host_impl_->active_tree()->UpdateScrollbarGeometries();
EXPECT_VIEWPORT_GEOMETRIES(0);
EXPECT_EQ(gfx::SizeF(50, 100), active_tree->ScrollableSize());
EXPECT_EQ(gfx::Size(50, 15), scrollbar_layer->bounds());
EXPECT_EQ(gfx::Rect(20, 50, 10, 3),
scrollbar_layer->ComputeThumbQuadRect());
}
// Additional scrolling shouldn't have any effect.
{
host_impl_->browser_controls_manager()->ScrollBy(gfx::Vector2dF(0, 25));
EXPECT_VIEWPORT_GEOMETRIES(0);
EXPECT_EQ(gfx::SizeF(50, 100), active_tree->ScrollableSize());
EXPECT_EQ(gfx::Size(50, 15), scrollbar_layer->bounds());
EXPECT_EQ(gfx::Rect(20, 50, 10, 3),
scrollbar_layer->ComputeThumbQuadRect());
}
host_impl_->browser_controls_manager()->ScrollEnd();
GetInputHandler().ScrollEnd();
}
TEST_P(LayerTreeHostImplBrowserControlsTest,
ScrollBrowserControlsByFractionalAmount) {
SetupBrowserControlsAndScrollLayerWithVirtualViewport(
gfx::Size(10, 10), gfx::Size(10, 10), gfx::Size(10, 10));
DrawFrame();
gfx::Vector2dF top_controls_scroll_delta(0, 5.25f);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), top_controls_scroll_delta,
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
// Make the test scroll delta a fractional amount, to verify that the
// fixed container size delta is (1) non-zero, and (2) fractional, and
// (3) matches the movement of the browser controls.
host_impl_->browser_controls_manager()->ScrollBegin();
host_impl_->browser_controls_manager()->ScrollBy(top_controls_scroll_delta);
host_impl_->browser_controls_manager()->ScrollEnd();
GetInputHandler().ScrollEnd();
auto* property_trees = host_impl_->active_tree()->property_trees();
EXPECT_FLOAT_EQ(top_controls_scroll_delta.y(),
property_trees->inner_viewport_container_bounds_delta().y());
}
// In this test, the outer viewport is initially unscrollable. We test that a
// scroll initiated on the inner viewport, causing the browser controls to show
// and thus making the outer viewport scrollable, still scrolls the outer
// viewport.
TEST_P(LayerTreeHostImplBrowserControlsTest,
BrowserControlsOuterViewportBecomesScrollable) {
SetupBrowserControlsAndScrollLayerWithVirtualViewport(
gfx::Size(10, 50), gfx::Size(10, 50), gfx::Size(10, 100));
DrawFrame();
LayerImpl* inner_scroll = InnerViewportScrollLayer();
inner_scroll->SetDrawsContent(true);
LayerImpl* outer_scroll = OuterViewportScrollLayer();
outer_scroll->SetDrawsContent(true);
// Need SetDrawsContent so ScrollBegin's hit test finds an actual layer.
outer_scroll->SetDrawsContent(true);
host_impl_->active_tree()->PushPageScaleFromMainThread(2, 1, 2);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), gfx::Vector2dF(0, 50),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
GetInputHandler().ScrollUpdate(UpdateState(gfx::Point(),
gfx::Vector2dF(0, 50),
ui::ScrollInputType::kTouchscreen)
.get());
// The entire scroll delta should have been used to hide the browser controls.
// The viewport layers should be resized back to their full sizes.
EXPECT_EQ(0, host_impl_->active_tree()->CurrentTopControlsShownRatio());
EXPECT_EQ(0, CurrentScrollOffset(inner_scroll).y());
EXPECT_EQ(100, inner_scroll->bounds().height());
EXPECT_EQ(100, outer_scroll->bounds().height());
// The inner viewport should be scrollable by 50px * page_scale.
GetInputHandler().ScrollUpdate(UpdateState(gfx::Point(),
gfx::Vector2dF(0, 100),
ui::ScrollInputType::kTouchscreen)
.get());
EXPECT_EQ(50, CurrentScrollOffset(inner_scroll).y());
EXPECT_EQ(0, CurrentScrollOffset(outer_scroll).y());
EXPECT_EQ(gfx::PointF(), MaxScrollOffset(outer_scroll));
GetInputHandler().ScrollEnd();
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), gfx::Vector2dF(0, -50),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
EXPECT_EQ(host_impl_->CurrentlyScrollingNode()->id,
outer_scroll->scroll_tree_index());
GetInputHandler().ScrollUpdate(UpdateState(gfx::Point(),
gfx::Vector2dF(0, -50),
ui::ScrollInputType::kTouchscreen)
.get());
// The entire scroll delta should have been used to show the browser controls.
// The outer viewport should be resized to accomodate and scrolled to the
// bottom of the document to keep the viewport in place.
EXPECT_EQ(1, host_impl_->active_tree()->CurrentTopControlsShownRatio());
EXPECT_EQ(50, inner_scroll->bounds().height());
EXPECT_EQ(100, outer_scroll->bounds().height());
EXPECT_EQ(25, CurrentScrollOffset(outer_scroll).y());
EXPECT_EQ(25, CurrentScrollOffset(inner_scroll).y());
// Now when we continue scrolling, make sure the outer viewport gets scrolled
// since it wasn't scrollable when the scroll began.
GetInputHandler().ScrollUpdate(UpdateState(gfx::Point(),
gfx::Vector2dF(0, -20),
ui::ScrollInputType::kTouchscreen)
.get());
EXPECT_EQ(25, CurrentScrollOffset(outer_scroll).y());
EXPECT_EQ(15, CurrentScrollOffset(inner_scroll).y());
GetInputHandler().ScrollUpdate(UpdateState(gfx::Point(),
gfx::Vector2dF(0, -30),
ui::ScrollInputType::kTouchscreen)
.get());
EXPECT_EQ(25, CurrentScrollOffset(outer_scroll).y());
EXPECT_EQ(0, CurrentScrollOffset(inner_scroll).y());
GetInputHandler().ScrollUpdate(UpdateState(gfx::Point(),
gfx::Vector2dF(0.f, -50),
ui::ScrollInputType::kTouchscreen)
.get());
GetInputHandler().ScrollEnd();
EXPECT_EQ(0, CurrentScrollOffset(outer_scroll).y());
EXPECT_EQ(0, CurrentScrollOffset(inner_scroll).y());
}
// Test that the fixed position container delta is appropriately adjusted
// by the browser controls showing/hiding and page scale doesn't affect it.
TEST_P(LayerTreeHostImplBrowserControlsTest, FixedContainerDelta) {
SetupBrowserControlsAndScrollLayerWithVirtualViewport(
gfx::Size(100, 100), gfx::Size(100, 100), gfx::Size(100, 100));
DrawFrame();
host_impl_->active_tree()->PushPageScaleFromMainThread(1, 1, 2);
float page_scale = 1.5f;
// Zoom in, since the fixed container is the outer viewport, the delta should
// not be scaled.
host_impl_->active_tree()->PushPageScaleFromMainThread(page_scale, 1, 2);
gfx::Vector2dF top_controls_scroll_delta(0, 20);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), top_controls_scroll_delta,
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
// Scroll down, the browser controls hiding should expand the viewport size so
// the delta should be equal to the scroll distance.
host_impl_->browser_controls_manager()->ScrollBegin();
host_impl_->browser_controls_manager()->ScrollBy(top_controls_scroll_delta);
EXPECT_FLOAT_EQ(top_controls_height_ - top_controls_scroll_delta.y(),
host_impl_->browser_controls_manager()->ContentTopOffset());
auto* property_trees = host_impl_->active_tree()->property_trees();
EXPECT_FLOAT_EQ(top_controls_scroll_delta.y(),
property_trees->outer_viewport_container_bounds_delta().y());
GetInputHandler().ScrollEnd();
// Scroll past the maximum extent. The delta shouldn't be greater than the
// browser controls height.
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), top_controls_scroll_delta,
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
host_impl_->browser_controls_manager()->ScrollBegin();
host_impl_->browser_controls_manager()->ScrollBy(top_controls_scroll_delta);
host_impl_->browser_controls_manager()->ScrollBy(top_controls_scroll_delta);
host_impl_->browser_controls_manager()->ScrollBy(top_controls_scroll_delta);
EXPECT_EQ(0, host_impl_->browser_controls_manager()->ContentTopOffset());
EXPECT_VECTOR2DF_EQ(gfx::Vector2dF(0, top_controls_height_),
property_trees->outer_viewport_container_bounds_delta());
GetInputHandler().ScrollEnd();
// Scroll in the direction to make the browser controls show.
EXPECT_EQ(
ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), -top_controls_scroll_delta,
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
host_impl_->browser_controls_manager()->ScrollBegin();
host_impl_->browser_controls_manager()->ScrollBy(-top_controls_scroll_delta);
EXPECT_EQ(top_controls_scroll_delta.y(),
host_impl_->browser_controls_manager()->ContentTopOffset());
EXPECT_VECTOR2DF_EQ(
gfx::Vector2dF(0, top_controls_height_ - top_controls_scroll_delta.y()),
property_trees->outer_viewport_container_bounds_delta());
host_impl_->browser_controls_manager()->ScrollEnd();
GetInputHandler().ScrollEnd();
}
// Push a browser controls ratio from the main thread that we didn't send as a
// delta and make sure that the ratio is clamped to the [0, 1] range.
TEST_P(LayerTreeHostImplBrowserControlsTest, BrowserControlsPushUnsentRatio) {
SetupBrowserControlsAndScrollLayerWithVirtualViewport(
gfx::Size(10, 50), gfx::Size(10, 50), gfx::Size(10, 100));
DrawFrame();
// Need SetDrawsContent so ScrollBegin's hit test finds an actual layer.
LayerImpl* inner_scroll = InnerViewportScrollLayer();
inner_scroll->SetDrawsContent(true);
LayerImpl* outer_scroll = OuterViewportScrollLayer();
outer_scroll->SetDrawsContent(true);
host_impl_->active_tree()->PushBrowserControlsFromMainThread(1, 1);
ASSERT_EQ(1.0f, host_impl_->active_tree()->CurrentTopControlsShownRatio());
host_impl_->active_tree()->SetCurrentBrowserControlsShownRatio(0.5f, 0.5f);
ASSERT_EQ(0.5f, host_impl_->active_tree()->CurrentTopControlsShownRatio());
host_impl_->active_tree()->PushBrowserControlsFromMainThread(0, 0);
ASSERT_EQ(0, host_impl_->active_tree()->CurrentTopControlsShownRatio());
}
// Test that if a scrollable sublayer doesn't consume the scroll,
// browser controls should hide when scrolling down.
TEST_P(LayerTreeHostImplBrowserControlsTest,
BrowserControlsScrollableSublayer) {
gfx::Size sub_content_size(100, 400);
gfx::Size sub_content_layer_size(100, 300);
SetupBrowserControlsAndScrollLayerWithVirtualViewport(
gfx::Size(100, 50), gfx::Size(100, 100), gfx::Size(100, 100));
DrawFrame();
// Show browser controls
EXPECT_EQ(1, host_impl_->active_tree()->CurrentTopControlsShownRatio());
LayerImpl* outer_viewport_scroll_layer = OuterViewportScrollLayer();
LayerImpl* child = AddLayer();
child->SetHitTestable(true);
child->SetElementId(LayerIdToElementIdForTesting(child->id()));
child->SetBounds(sub_content_size);
child->SetDrawsContent(true);
CopyProperties(outer_viewport_scroll_layer, child);
CreateTransformNode(child);
CreateScrollNode(child, sub_content_layer_size);
UpdateDrawProperties(host_impl_->active_tree());
// Scroll child to the limit.
SetScrollOffsetDelta(child, gfx::Vector2dF(0, 100));
// Scroll 25px to hide browser controls
gfx::Vector2dF scroll_delta(0, 25);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), scroll_delta,
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), scroll_delta, ui::ScrollInputType::kTouchscreen)
.get());
GetInputHandler().ScrollEnd();
// Browser controls should be hidden
EXPECT_EQ(scroll_delta.y(),
top_controls_height_ -
host_impl_->browser_controls_manager()->ContentTopOffset());
}
// Ensure setting the browser controls position explicitly using the setters on
// the TreeImpl correctly affects the browser controls manager and viewport
// bounds for the active tree.
TEST_P(LayerTreeHostImplBrowserControlsTest,
PositionBrowserControlsToActiveTreeExplicitly) {
SetupBrowserControlsAndScrollLayerWithVirtualViewport(
layer_size_, layer_size_, layer_size_);
DrawFrame();
host_impl_->active_tree()->SetCurrentBrowserControlsShownRatio(0, 0);
host_impl_->active_tree()->top_controls_shown_ratio()->PushMainToPending(
30 / top_controls_height_);
host_impl_->active_tree()->top_controls_shown_ratio()->PushPendingToActive();
EXPECT_FLOAT_EQ(30,
host_impl_->browser_controls_manager()->ContentTopOffset());
EXPECT_FLOAT_EQ(-20,
host_impl_->browser_controls_manager()->ControlsTopOffset());
host_impl_->active_tree()->SetCurrentBrowserControlsShownRatio(0, 0);
EXPECT_FLOAT_EQ(0,
host_impl_->browser_controls_manager()->ContentTopOffset());
EXPECT_FLOAT_EQ(-50,
host_impl_->browser_controls_manager()->ControlsTopOffset());
host_impl_->DidChangeBrowserControlsPosition();
auto* property_trees = host_impl_->active_tree()->property_trees();
EXPECT_EQ(gfx::Vector2dF(0, 50),
property_trees->inner_viewport_container_bounds_delta());
}
// Ensure setting the browser controls position explicitly using the setters on
// the TreeImpl correctly affects the browser controls manager and viewport
// bounds for the pending tree.
TEST_P(LayerTreeHostImplBrowserControlsTest,
PositionBrowserControlsToPendingTreeExplicitly) {
CreatePendingTree();
SetupBrowserControlsAndScrollLayerWithVirtualViewport(
host_impl_->pending_tree(), layer_size_, layer_size_, layer_size_);
// Changing SetCurrentBrowserControlsShownRatio is one way to cause the
// pending tree to update it's viewport.
host_impl_->SetCurrentBrowserControlsShownRatio(0, 0);
EXPECT_FLOAT_EQ(top_controls_height_,
host_impl_->pending_tree()
->property_trees()
->inner_viewport_container_bounds_delta()
.y());
host_impl_->SetCurrentBrowserControlsShownRatio(0.5f, 0.5f);
EXPECT_FLOAT_EQ(0.5f * top_controls_height_,
host_impl_->pending_tree()
->property_trees()
->inner_viewport_container_bounds_delta()
.y());
host_impl_->SetCurrentBrowserControlsShownRatio(1, 1);
EXPECT_FLOAT_EQ(0, host_impl_->pending_tree()
->property_trees()
->inner_viewport_container_bounds_delta()
.y());
// Pushing changes from the main thread is the second way. These values are
// added to the 1 set above.
host_impl_->pending_tree()->PushBrowserControlsFromMainThread(-0.5f, -0.5f);
EXPECT_FLOAT_EQ(0.5f * top_controls_height_,
host_impl_->pending_tree()
->property_trees()
->inner_viewport_container_bounds_delta()
.y());
host_impl_->pending_tree()->PushBrowserControlsFromMainThread(-1, -1);
EXPECT_FLOAT_EQ(top_controls_height_,
host_impl_->pending_tree()
->property_trees()
->inner_viewport_container_bounds_delta()
.y());
}
// Test that the top_controls delta and sent delta are appropriately
// applied on sync tree activation. The total browser controls offset shouldn't
// change after the activation.
TEST_P(LayerTreeHostImplBrowserControlsTest, ApplyDeltaOnTreeActivation) {
SetupBrowserControlsAndScrollLayerWithVirtualViewport(
layer_size_, layer_size_, layer_size_);
DrawFrame();
host_impl_->active_tree()->top_controls_shown_ratio()->PushMainToPending(
20 / top_controls_height_);
host_impl_->active_tree()->top_controls_shown_ratio()->PushPendingToActive();
host_impl_->active_tree()->SetCurrentBrowserControlsShownRatio(
15 / top_controls_height_, 15 / top_controls_height_);
host_impl_->active_tree()->top_controls_shown_ratio()->PullDeltaForMainThread(
/* next_bmf */ false);
host_impl_->active_tree()->SetCurrentBrowserControlsShownRatio(0, 0);
host_impl_->sync_tree()->PushBrowserControlsFromMainThread(
15 / top_controls_height_, 15 / top_controls_height_);
host_impl_->DidChangeBrowserControlsPosition();
auto* property_trees = host_impl_->active_tree()->property_trees();
EXPECT_EQ(gfx::Vector2dF(0, 50),
property_trees->inner_viewport_container_bounds_delta());
EXPECT_EQ(0, host_impl_->browser_controls_manager()->ContentTopOffset());
host_impl_->ActivateSyncTree();
EXPECT_EQ(0, host_impl_->browser_controls_manager()->ContentTopOffset());
EXPECT_EQ(gfx::Vector2dF(0, 50),
property_trees->inner_viewport_container_bounds_delta());
EXPECT_FLOAT_EQ(
-15, host_impl_->active_tree()->top_controls_shown_ratio()->Delta() *
top_controls_height_);
EXPECT_FLOAT_EQ(
15, host_impl_->active_tree()->top_controls_shown_ratio()->ActiveBase() *
top_controls_height_);
}
// Test that changing the browser controls layout height is correctly applied to
// the inner viewport container bounds. That is, the browser controls layout
// height is the amount that the inner viewport container was shrunk outside
// the compositor to accommodate the browser controls.
TEST_P(LayerTreeHostImplBrowserControlsTest,
BrowserControlsLayoutHeightChanged) {
SetupBrowserControlsAndScrollLayerWithVirtualViewport(
layer_size_, layer_size_, layer_size_);
DrawFrame();
host_impl_->sync_tree()->PushBrowserControlsFromMainThread(1, 1);
host_impl_->sync_tree()->SetBrowserControlsParams(
{top_controls_height_, 0, 0, 0, false, true});
host_impl_->active_tree()->top_controls_shown_ratio()->PushMainToPending(1);
host_impl_->active_tree()->top_controls_shown_ratio()->PushPendingToActive();
host_impl_->active_tree()->SetCurrentBrowserControlsShownRatio(0, 0);
host_impl_->DidChangeBrowserControlsPosition();
auto* property_trees = host_impl_->active_tree()->property_trees();
EXPECT_EQ(gfx::Vector2dF(0, 50),
property_trees->inner_viewport_container_bounds_delta());
EXPECT_EQ(0, host_impl_->browser_controls_manager()->ContentTopOffset());
host_impl_->ActivateSyncTree();
EXPECT_EQ(0, host_impl_->browser_controls_manager()->ContentTopOffset());
// The total bounds should remain unchanged since the bounds delta should
// account for the difference between the layout height and the current
// browser controls offset.
EXPECT_EQ(gfx::Vector2dF(0, 50),
property_trees->inner_viewport_container_bounds_delta());
host_impl_->active_tree()->SetCurrentBrowserControlsShownRatio(1, 1);
host_impl_->DidChangeBrowserControlsPosition();
EXPECT_EQ(1, host_impl_->browser_controls_manager()->TopControlsShownRatio());
EXPECT_EQ(50, host_impl_->browser_controls_manager()->TopControlsHeight());
EXPECT_EQ(50, host_impl_->browser_controls_manager()->ContentTopOffset());
EXPECT_EQ(gfx::Vector2dF(),
property_trees->inner_viewport_container_bounds_delta());
}
// Test that showing/hiding the browser controls when the viewport is fully
// scrolled doesn't incorrectly change the viewport offset due to clamping from
// changing viewport bounds.
TEST_P(LayerTreeHostImplBrowserControlsTest,
BrowserControlsViewportOffsetClamping) {
SetupBrowserControlsAndScrollLayerWithVirtualViewport(
gfx::Size(100, 100), gfx::Size(200, 200), gfx::Size(200, 400));
DrawFrame();
EXPECT_EQ(1, host_impl_->active_tree()->CurrentTopControlsShownRatio());
LayerImpl* outer_scroll = OuterViewportScrollLayer();
LayerImpl* inner_scroll = InnerViewportScrollLayer();
// Scroll the viewports to max scroll offset.
SetScrollOffsetDelta(outer_scroll, gfx::Vector2dF(0, 200));
SetScrollOffsetDelta(inner_scroll, gfx::Vector2dF(100, 100));
gfx::PointF viewport_offset = host_impl_->active_tree()->TotalScrollOffset();
EXPECT_EQ(host_impl_->active_tree()->TotalMaxScrollOffset(), viewport_offset);
// Hide the browser controls by 25px.
gfx::Vector2dF scroll_delta(0, 25);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), scroll_delta,
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), scroll_delta, ui::ScrollInputType::kTouchscreen)
.get());
// scrolling down at the max extents no longer hides the browser controls
EXPECT_EQ(1, host_impl_->active_tree()->CurrentTopControlsShownRatio());
// forcefully hide the browser controls by 25px
host_impl_->browser_controls_manager()->ScrollBy(scroll_delta);
GetInputHandler().ScrollEnd();
EXPECT_FLOAT_EQ(
scroll_delta.y(),
top_controls_height_ -
host_impl_->browser_controls_manager()->ContentTopOffset());
// We should still be fully scrolled.
EXPECT_EQ(host_impl_->active_tree()->TotalMaxScrollOffset(),
host_impl_->active_tree()->TotalScrollOffset());
viewport_offset = host_impl_->active_tree()->TotalScrollOffset();
// Bring the browser controls down by 25px.
scroll_delta = gfx::Vector2dF(0, -25);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), scroll_delta,
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), scroll_delta, ui::ScrollInputType::kTouchscreen)
.get());
GetInputHandler().ScrollEnd();
// The viewport offset shouldn't have changed.
EXPECT_EQ(viewport_offset, host_impl_->active_tree()->TotalScrollOffset());
// Scroll the viewports to max scroll offset.
SetScrollOffsetDelta(outer_scroll, gfx::Vector2dF(0, 200));
SetScrollOffsetDelta(inner_scroll, gfx::Vector2dF(100, 100));
EXPECT_EQ(host_impl_->active_tree()->TotalMaxScrollOffset(),
host_impl_->active_tree()->TotalScrollOffset());
}
// Test that the browser controls coming in and out maintains the same aspect
// ratio between the inner and outer viewports.
TEST_P(LayerTreeHostImplBrowserControlsTest, BrowserControlsAspectRatio) {
SetupBrowserControlsAndScrollLayerWithVirtualViewport(
gfx::Size(100, 100), gfx::Size(200, 200), gfx::Size(200, 400));
host_impl_->active_tree()->PushPageScaleFromMainThread(1, 0.5f, 2);
DrawFrame();
EXPECT_FLOAT_EQ(top_controls_height_,
host_impl_->browser_controls_manager()->ContentTopOffset());
gfx::Vector2dF scroll_delta(0, 25);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), scroll_delta,
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), scroll_delta, ui::ScrollInputType::kTouchscreen)
.get());
GetInputHandler().ScrollEnd();
EXPECT_FLOAT_EQ(
scroll_delta.y(),
top_controls_height_ -
host_impl_->browser_controls_manager()->ContentTopOffset());
// Browser controls were hidden by 25px so the inner viewport should have
// expanded by that much.
auto* property_trees = host_impl_->active_tree()->property_trees();
EXPECT_EQ(gfx::Vector2dF(0, 25),
property_trees->inner_viewport_container_bounds_delta());
// Outer viewport should match inner's aspect ratio. The bounds are ceiled.
float aspect_ratio = 100.0f / 125.0f;
auto expected = gfx::ToCeiledSize(gfx::SizeF(200, 200 / aspect_ratio));
EXPECT_EQ(expected, InnerViewportScrollLayer()->bounds());
}
TEST_P(LayerTreeHostImplBrowserControlsTest, NoShrinkNotUserScrollable) {
SetupBrowserControlsAndScrollLayerWithVirtualViewport(
gfx::Size(100, 100), gfx::Size(100, 100), gfx::Size(100, 200));
GetScrollNode(OuterViewportScrollLayer())->user_scrollable_vertical = false;
DrawFrame();
gfx::Vector2dF delta(0, 15);
ui::ScrollInputType type = ui::ScrollInputType::kTouchscreen;
auto& handler = GetInputHandler();
handler.ScrollBegin(BeginState(gfx::Point(), delta, type).get(), type);
handler.ScrollUpdate(UpdateState(gfx::Point(), delta, type).get());
handler.ScrollEnd();
// Outer viewport has overflow, but is not user-scrollable. Make sure the
// browser controls did not shrink when we tried to scroll.
EXPECT_EQ(top_controls_height_,
host_impl_->browser_controls_manager()->ContentTopOffset());
}
// Test that scrolling the outer viewport affects the browser controls.
TEST_P(LayerTreeHostImplBrowserControlsTest,
BrowserControlsScrollOuterViewport) {
SetupBrowserControlsAndScrollLayerWithVirtualViewport(
gfx::Size(100, 100), gfx::Size(200, 200), gfx::Size(200, 400));
DrawFrame();
EXPECT_EQ(top_controls_height_,
host_impl_->browser_controls_manager()->ContentTopOffset());
// Send a gesture scroll that will scroll the outer viewport, make sure the
// browser controls get scrolled.
gfx::Vector2dF scroll_delta(0, 15);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), scroll_delta,
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), scroll_delta, ui::ScrollInputType::kTouchscreen)
.get());
EXPECT_EQ(OuterViewportScrollLayer()->scroll_tree_index(),
host_impl_->CurrentlyScrollingNode()->id);
GetInputHandler().ScrollEnd();
EXPECT_FLOAT_EQ(
scroll_delta.y(),
top_controls_height_ -
host_impl_->browser_controls_manager()->ContentTopOffset());
scroll_delta = gfx::Vector2dF(0, 50);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), scroll_delta,
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), scroll_delta, ui::ScrollInputType::kTouchscreen)
.get());
EXPECT_EQ(0, host_impl_->browser_controls_manager()->ContentTopOffset());
EXPECT_EQ(OuterViewportScrollLayer()->scroll_tree_index(),
host_impl_->CurrentlyScrollingNode()->id);
GetInputHandler().ScrollEnd();
// Position the viewports such that the inner viewport will be scrolled.
gfx::Vector2dF inner_viewport_offset(0, 25);
SetScrollOffsetDelta(OuterViewportScrollLayer(), gfx::Vector2dF());
SetScrollOffsetDelta(InnerViewportScrollLayer(), inner_viewport_offset);
scroll_delta = gfx::Vector2dF(0, -65);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), scroll_delta,
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), scroll_delta, ui::ScrollInputType::kTouchscreen)
.get());
EXPECT_EQ(top_controls_height_,
host_impl_->browser_controls_manager()->ContentTopOffset());
EXPECT_FLOAT_EQ(
inner_viewport_offset.y() + (scroll_delta.y() + top_controls_height_),
ScrollDelta(InnerViewportScrollLayer()).y());
GetInputHandler().ScrollEnd();
}
TEST_P(LayerTreeHostImplBrowserControlsTest,
ScrollNonScrollableRootWithBrowserControls) {
SetupBrowserControlsAndScrollLayerWithVirtualViewport(
layer_size_, layer_size_, layer_size_);
DrawFrame();
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), gfx::Vector2dF(0, 50),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
host_impl_->browser_controls_manager()->ScrollBegin();
host_impl_->browser_controls_manager()->ScrollBy(gfx::Vector2dF(0, 50));
host_impl_->browser_controls_manager()->ScrollEnd();
EXPECT_EQ(0, host_impl_->browser_controls_manager()->ContentTopOffset());
// Now that browser controls have moved, expect the clip to resize.
auto* property_trees = host_impl_->active_tree()->property_trees();
EXPECT_EQ(gfx::Vector2dF(0, 50),
property_trees->inner_viewport_container_bounds_delta());
GetInputHandler().ScrollEnd();
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), gfx::Vector2dF(0, -25),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
float scroll_increment_y = -25;
host_impl_->browser_controls_manager()->ScrollBegin();
host_impl_->browser_controls_manager()->ScrollBy(
gfx::Vector2dF(0, scroll_increment_y));
EXPECT_FLOAT_EQ(-scroll_increment_y,
host_impl_->browser_controls_manager()->ContentTopOffset());
// Now that browser controls have moved, expect the clip to resize.
EXPECT_EQ(gfx::Vector2dF(0, 25),
property_trees->inner_viewport_container_bounds_delta());
host_impl_->browser_controls_manager()->ScrollBy(
gfx::Vector2dF(0, scroll_increment_y));
host_impl_->browser_controls_manager()->ScrollEnd();
EXPECT_FLOAT_EQ(-2 * scroll_increment_y,
host_impl_->browser_controls_manager()->ContentTopOffset());
// Now that browser controls have moved, expect the clip to resize.
EXPECT_EQ(gfx::Vector2dF(),
property_trees->inner_viewport_container_bounds_delta());
GetInputHandler().ScrollEnd();
// Verify the layer is once-again non-scrollable.
EXPECT_EQ(gfx::PointF(), MaxScrollOffset(InnerViewportScrollLayer()));
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), gfx::Vector2dF(0, 10),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
}
// Tests that activating a pending tree while there's a bounds_delta on the
// viewport layers from browser controls doesn't cause a scroll jump. This bug
// was occurring because the UpdateViewportContainerSizes was being called
// before the property trees were updated with the bounds_delta.
// crbug.com/597266.
TEST_P(LayerTreeHostImplBrowserControlsTest,
ViewportBoundsDeltaOnTreeActivation) {
const gfx::Size inner_viewport_size(1000, 1000);
const gfx::Size outer_viewport_size(1000, 1000);
const gfx::Size content_size(2000, 2000);
// Initialization
{
SetupBrowserControlsAndScrollLayerWithVirtualViewport(
inner_viewport_size, outer_viewport_size, content_size);
host_impl_->active_tree()->PushPageScaleFromMainThread(1, 1, 1);
// Start off with the browser controls hidden on both main and impl.
host_impl_->active_tree()->SetBrowserControlsParams(
{top_controls_height_, 0, 0, 0, false, false});
host_impl_->active_tree()->PushBrowserControlsFromMainThread(0, 0);
CreatePendingTree();
SetupBrowserControlsAndScrollLayerWithVirtualViewport(
host_impl_->pending_tree(), inner_viewport_size, outer_viewport_size,
content_size);
host_impl_->pending_tree()->SetBrowserControlsParams(
{top_controls_height_, 0, 0, 0, false, false});
UpdateDrawProperties(host_impl_->pending_tree());
// Fully scroll the viewport.
GetInputHandler().ScrollBegin(
BeginState(gfx::Point(75, 75), gfx::Vector2dF(0, 2000),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), gfx::Vector2d(0, 2000),
ui::ScrollInputType::kTouchscreen)
.get());
GetInputHandler().ScrollEnd();
}
LayerImpl* outer_scroll = OuterViewportScrollLayer();
ASSERT_FLOAT_EQ(0,
host_impl_->browser_controls_manager()->ContentTopOffset());
ASSERT_EQ(1000, MaxScrollOffset(outer_scroll).y());
ASSERT_EQ(1000, CurrentScrollOffset(outer_scroll).y());
// Kick off an animation to show the browser controls.
host_impl_->browser_controls_manager()->UpdateBrowserControlsState(
BrowserControlsState::kBoth, BrowserControlsState::kShown, true);
base::TimeTicks start_time = base::TimeTicks::Now();
viz::BeginFrameArgs begin_frame_args =
viz::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, 0, 1);
// The first animation frame will not produce any delta, it will establish
// the animation.
{
begin_frame_args.frame_time = start_time;
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
host_impl_->UpdateAnimationState(true);
host_impl_->DidFinishImplFrame(begin_frame_args);
float delta =
host_impl_->active_tree()->top_controls_shown_ratio()->Delta();
ASSERT_EQ(delta, 0);
}
// Pump an animation frame to put some delta in the browser controls.
{
begin_frame_args.frame_time = start_time + base::Milliseconds(50);
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
host_impl_->UpdateAnimationState(true);
host_impl_->DidFinishImplFrame(begin_frame_args);
}
// Pull the browser controls delta and get it back to the pending tree so that
// when we go to activate the pending tree we cause a change to browser
// controls.
{
float delta =
host_impl_->active_tree()->top_controls_shown_ratio()->Delta();
ASSERT_GT(delta, 0);
ASSERT_LT(delta, 1);
host_impl_->active_tree()
->top_controls_shown_ratio()
->PullDeltaForMainThread(/* next_bmf */ false);
host_impl_->active_tree()->top_controls_shown_ratio()->PushMainToPending(
delta);
}
// 200 is the kShowHideMaxDurationMs value from browser_controls_manager.cc so
// the browser controls should be fully animated in this frame.
{
begin_frame_args.frame_time = start_time + base::Milliseconds(200);
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
host_impl_->UpdateAnimationState(true);
host_impl_->DidFinishImplFrame(begin_frame_args);
ASSERT_EQ(50, host_impl_->browser_controls_manager()->ContentTopOffset());
ASSERT_EQ(1050, MaxScrollOffset(outer_scroll).y());
// NEAR because clip layer bounds are truncated in MaxScrollOffset so we
// lose some precision in the intermediate animation steps.
ASSERT_NEAR(1050, CurrentScrollOffset(outer_scroll).y(), 1);
}
// Activate the pending tree which should have the same scroll value as the
// active tree.
{
host_impl_->pending_tree()
->property_trees()
->scroll_tree_mutable()
.SetScrollOffsetDeltaForTesting(outer_scroll->element_id(),
gfx::Vector2dF(0, 1050));
host_impl_->ActivateSyncTree();
// Make sure we don't accidentally clamp the outer offset based on a bounds
// delta that hasn't yet been updated.
EXPECT_NEAR(1050, CurrentScrollOffset(outer_scroll).y(), 1);
}
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollNonCompositedRoot) {
// Test the configuration where a non-composited root layer is embedded in a
// scrollable outer layer.
gfx::Size surface_size(10, 10);
gfx::Size contents_size(20, 20);
SetupViewportLayersNoScrolls(surface_size);
LayerImpl* scroll_container_layer = AddContentLayer();
CreateEffectNode(scroll_container_layer).render_surface_reason =
RenderSurfaceReason::kTest;
LayerImpl* scroll_layer =
AddScrollableLayer(scroll_container_layer, surface_size, contents_size);
LayerImpl* content_layer = AddLayer();
content_layer->SetDrawsContent(true);
content_layer->SetBounds(contents_size);
CopyProperties(scroll_layer, content_layer);
DrawFrame();
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(5, 5), gfx::Vector2dF(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
GetInputHandler().ScrollUpdate(UpdateState(gfx::Point(), gfx::Vector2d(0, 10),
ui::ScrollInputType::kWheel)
.get());
GetInputHandler().ScrollEnd();
EXPECT_TRUE(did_request_redraw_);
EXPECT_TRUE(did_request_commit_);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollChildCallsCommitAndRedraw) {
gfx::Size surface_size(10, 10);
gfx::Size contents_size(20, 20);
SetupViewportLayersNoScrolls(surface_size);
LayerImpl* content_root = AddContentLayer();
CreateEffectNode(content_root).render_surface_reason =
RenderSurfaceReason::kTest;
AddScrollableLayer(content_root, surface_size, contents_size);
DrawFrame();
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(5, 5), gfx::Vector2dF(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
GetInputHandler().ScrollUpdate(UpdateState(gfx::Point(), gfx::Vector2d(0, 10),
ui::ScrollInputType::kWheel)
.get());
GetInputHandler().ScrollEnd();
EXPECT_TRUE(did_request_redraw_);
EXPECT_TRUE(did_request_commit_);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollMissesChild) {
gfx::Size viewport_size(5, 5);
gfx::Size surface_size(10, 10);
SetupViewportLayersOuterScrolls(viewport_size, surface_size);
AddScrollableLayer(OuterViewportScrollLayer(), viewport_size, surface_size);
DrawFrame();
// A scroll that doesn't hit any layers should fall back to viewport
// scrolling.
InputHandler::ScrollStatus status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(15, 5), gfx::Vector2dF(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
EXPECT_EQ(host_impl_->CurrentlyScrollingNode(),
host_impl_->OuterViewportScrollNode());
EXPECT_FALSE(did_request_redraw_);
EXPECT_FALSE(did_request_commit_);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollMissesBackfacingChild) {
gfx::Size viewport_size(5, 5);
gfx::Size surface_size(10, 10);
SetupViewportLayersOuterScrolls(viewport_size, surface_size);
LayerImpl* child = AddScrollableLayer(OuterViewportScrollLayer(),
viewport_size, surface_size);
gfx::Transform matrix;
matrix.RotateAboutXAxis(180.0);
GetTransformNode(child)->local = matrix;
CreateEffectNode(child).double_sided = false;
DrawFrame();
// The scroll shouldn't hit the child layer because the it isn't facing the
// viewer. The hit test should go through it and hit the outer viewport.
InputHandler::ScrollStatus status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(5, 5), gfx::Vector2dF(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
EXPECT_EQ(host_impl_->CurrentlyScrollingNode(),
host_impl_->OuterViewportScrollNode());
EXPECT_FALSE(did_request_redraw_);
EXPECT_FALSE(did_request_commit_);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollLayerWithMainThreadReason) {
gfx::Size scroll_container_size(5, 5);
gfx::Size surface_size(10, 10);
LayerImpl* root = SetupDefaultRootLayer(surface_size);
// Note: we can use the same clip layer for both since both calls to
// AddScrollableLayer() use the same surface size.
LayerImpl* scroll_layer =
AddScrollableLayer(root, scroll_container_size, surface_size);
LayerImpl* content_layer =
AddScrollableLayer(scroll_layer, scroll_container_size, surface_size);
GetScrollNode(content_layer)->main_thread_scrolling_reasons =
MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects;
DrawFrame();
InputHandler::ScrollStatus status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(5, 5), gfx::Vector2dF(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
if (base::FeatureList::IsEnabled(features::kScrollUnification)) {
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
EXPECT_FALSE(status.needs_main_thread_hit_test);
EXPECT_EQ(
MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects,
host_impl_->CurrentlyScrollingNode()->main_thread_scrolling_reasons);
} else {
// Scrolling fails because the content layer is asking to be scrolled on the
// main thread.
EXPECT_EQ(ScrollThread::SCROLL_ON_MAIN_THREAD, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects,
status.main_thread_scrolling_reasons);
}
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
ScrollRootAndChangePageScaleOnMainThread) {
gfx::Size inner_viewport_size(20, 20);
gfx::Size outer_viewport_size(40, 40);
gfx::Size content_size(80, 80);
SetupViewportLayers(host_impl_->active_tree(), inner_viewport_size,
outer_viewport_size, content_size);
host_impl_->active_tree()->PushPageScaleFromMainThread(1, 1, 2);
DrawFrame();
gfx::Vector2d scroll_delta(0, 10);
gfx::Vector2dF expected_scroll_delta(scroll_delta);
LayerImpl* outer_scroll = OuterViewportScrollLayer();
gfx::PointF expected_max_scroll = MaxScrollOffset(outer_scroll);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(5, 5), scroll_delta,
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), scroll_delta, ui::ScrollInputType::kWheel)
.get());
GetInputHandler().ScrollEnd();
// Set new page scale from main thread.
float page_scale = 2;
host_impl_->active_tree()->PushPageScaleFromMainThread(page_scale, 1, 2);
std::unique_ptr<CompositorCommitData> commit_data =
host_impl_->ProcessCompositorDeltas(
/* main_thread_mutator_host */ nullptr);
LayerImpl* inner_scroll = InnerViewportScrollLayer();
EXPECT_TRUE(ScrollInfoContains(*commit_data.get(), inner_scroll->element_id(),
expected_scroll_delta));
// The scroll range should also have been updated.
EXPECT_EQ(expected_max_scroll, MaxScrollOffset(outer_scroll));
// The page scale delta remains constant because the impl thread did not
// scale.
EXPECT_EQ(1, host_impl_->active_tree()->page_scale_delta());
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
ScrollRootAndChangePageScaleOnImplThread) {
gfx::Size inner_viewport_size(20, 20);
gfx::Size outer_viewport_size(40, 40);
gfx::Size content_size(80, 80);
SetupViewportLayers(host_impl_->active_tree(), inner_viewport_size,
outer_viewport_size, content_size);
host_impl_->active_tree()->PushPageScaleFromMainThread(1, 1, 2);
DrawFrame();
gfx::Vector2d scroll_delta(0, 10);
gfx::Vector2dF expected_scroll_delta(scroll_delta);
LayerImpl* outer_scroll = OuterViewportScrollLayer();
gfx::PointF expected_max_scroll = MaxScrollOffset(outer_scroll);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(5, 5), scroll_delta,
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), scroll_delta, ui::ScrollInputType::kWheel)
.get());
GetInputHandler().ScrollEnd();
// Set new page scale on impl thread by pinching.
float page_scale = 2;
GetInputHandler().ScrollBegin(BeginState(gfx::Point(), gfx::Vector2dF(),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
GetInputHandler().PinchGestureBegin(gfx::Point(),
ui::ScrollInputType::kWheel);
GetInputHandler().PinchGestureUpdate(page_scale, gfx::Point());
GetInputHandler().PinchGestureEnd(gfx::Point());
GetInputHandler().ScrollEnd();
DrawOneFrame();
// The scroll delta is not scaled because the main thread did not scale.
std::unique_ptr<CompositorCommitData> commit_data =
host_impl_->ProcessCompositorDeltas(
/* main_thread_mutator_host */ nullptr);
LayerImpl* inner_scroll = InnerViewportScrollLayer();
EXPECT_TRUE(ScrollInfoContains(*commit_data.get(), inner_scroll->element_id(),
expected_scroll_delta));
// The scroll range should also have been updated.
EXPECT_EQ(expected_max_scroll, MaxScrollOffset(outer_scroll));
// The page scale delta should match the new scale on the impl side.
EXPECT_EQ(page_scale, host_impl_->active_tree()->current_page_scale_factor());
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
PageScaleDeltaAppliedToRootScrollLayerOnly) {
host_impl_->active_tree()->PushPageScaleFromMainThread(1, 1, 2);
gfx::Size viewport_size(5, 5);
gfx::Size surface_size(10, 10);
float default_page_scale = 1;
gfx::Transform default_page_scale_matrix;
default_page_scale_matrix.Scale(default_page_scale, default_page_scale);
float new_page_scale = 2;
gfx::Transform new_page_scale_matrix;
new_page_scale_matrix.Scale(new_page_scale, new_page_scale);
SetupViewportLayersInnerScrolls(viewport_size, surface_size);
LayerImpl* root = root_layer();
auto* inner_scroll = InnerViewportScrollLayer();
auto* outer_scroll = OuterViewportScrollLayer();
// Create a normal scrollable root layer and another scrollable child layer.
LayerImpl* scrollable_child_clip = AddLayer();
CopyProperties(inner_scroll, scrollable_child_clip);
AddScrollableLayer(scrollable_child_clip, viewport_size, surface_size);
UpdateDrawProperties(host_impl_->active_tree());
// Set new page scale on impl thread by pinching.
GetInputHandler().ScrollBegin(BeginState(gfx::Point(), gfx::Vector2dF(),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
GetInputHandler().PinchGestureBegin(gfx::Point(),
ui::ScrollInputType::kWheel);
GetInputHandler().PinchGestureUpdate(new_page_scale, gfx::Point());
GetInputHandler().PinchGestureEnd(gfx::Point());
GetInputHandler().ScrollEnd();
DrawOneFrame();
// Make sure all the layers are drawn with the page scale delta applied, i.e.,
// the page scale delta on the root layer is applied hierarchically.
DrawFrame();
EXPECT_EQ(1, root->DrawTransform().rc(0, 0));
EXPECT_EQ(1, root->DrawTransform().rc(1, 1));
EXPECT_EQ(new_page_scale, inner_scroll->DrawTransform().rc(0, 0));
EXPECT_EQ(new_page_scale, inner_scroll->DrawTransform().rc(1, 1));
EXPECT_EQ(new_page_scale, outer_scroll->DrawTransform().rc(0, 0));
EXPECT_EQ(new_page_scale, outer_scroll->DrawTransform().rc(1, 1));
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
ScrollChildAndChangePageScaleOnMainThread) {
SetupViewportLayers(host_impl_->active_tree(), gfx::Size(15, 15),
gfx::Size(30, 30), gfx::Size(50, 50));
LayerImpl* outer_scroll = OuterViewportScrollLayer();
LayerImpl* inner_scroll = InnerViewportScrollLayer();
DrawFrame();
gfx::Vector2d scroll_delta(0, 10);
gfx::Vector2dF expected_scroll_delta(scroll_delta);
gfx::PointF expected_max_scroll(MaxScrollOffset(outer_scroll));
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(5, 5), scroll_delta,
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), scroll_delta, ui::ScrollInputType::kWheel)
.get());
GetInputHandler().ScrollEnd();
float page_scale = 2;
host_impl_->active_tree()->PushPageScaleFromMainThread(page_scale, 1,
page_scale);
DrawOneFrame();
std::unique_ptr<CompositorCommitData> commit_data =
host_impl_->ProcessCompositorDeltas(
/* main_thread_mutator_host */ nullptr);
EXPECT_TRUE(ScrollInfoContains(*commit_data.get(), inner_scroll->element_id(),
expected_scroll_delta));
// The scroll range should not have changed.
EXPECT_EQ(MaxScrollOffset(outer_scroll), expected_max_scroll);
// The page scale delta remains constant because the impl thread did not
// scale.
EXPECT_EQ(1, host_impl_->active_tree()->page_scale_delta());
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollChildBeyondLimit) {
// Scroll a child layer beyond its maximum scroll range and make sure the
// parent layer isn't scrolled.
gfx::Size surface_size(10, 10);
gfx::Size content_size(20, 20);
SetupViewportLayersNoScrolls(surface_size);
LayerImpl* top = AddContentLayer();
CreateEffectNode(top).render_surface_reason = RenderSurfaceReason::kTest;
LayerImpl* child_layer = AddScrollableLayer(top, surface_size, content_size);
LayerImpl* grand_child_layer =
AddScrollableLayer(child_layer, surface_size, content_size);
UpdateDrawProperties(host_impl_->active_tree());
host_impl_->active_tree()->DidBecomeActive();
grand_child_layer->layer_tree_impl()
->property_trees()
->scroll_tree_mutable()
.UpdateScrollOffsetBaseForTesting(grand_child_layer->element_id(),
gfx::PointF(0, 5));
child_layer->layer_tree_impl()
->property_trees()
->scroll_tree_mutable()
.UpdateScrollOffsetBaseForTesting(child_layer->element_id(),
gfx::PointF(3, 0));
DrawFrame();
{
gfx::Vector2d scroll_delta(-8, -7);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), scroll_delta,
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), scroll_delta, ui::ScrollInputType::kWheel)
.get());
GetInputHandler().ScrollEnd();
std::unique_ptr<CompositorCommitData> commit_data =
host_impl_->ProcessCompositorDeltas(
/* main_thread_mutator_host */ nullptr);
// The grand child should have scrolled up to its limit.
EXPECT_TRUE(ScrollInfoContains(*commit_data.get(),
grand_child_layer->element_id(),
gfx::Vector2dF(0, -5)));
// The child should not have scrolled.
ExpectNone(*commit_data.get(), child_layer->element_id());
}
}
TEST_F(LayerTreeHostImplTimelinesTest, ScrollAnimatedLatchToChild) {
// Scroll a child layer beyond its maximum scroll range and make sure the
// parent layer isn't scrolled.
gfx::Size surface_size(100, 100);
gfx::Size content_size(150, 150);
SetupViewportLayersNoScrolls(surface_size);
LayerImpl* top = AddContentLayer();
CreateEffectNode(top).render_surface_reason = RenderSurfaceReason::kTest;
LayerImpl* child_layer = AddScrollableLayer(top, surface_size, content_size);
LayerImpl* grand_child_layer =
AddScrollableLayer(child_layer, surface_size, content_size);
UpdateDrawProperties(host_impl_->active_tree());
host_impl_->active_tree()->DidBecomeActive();
grand_child_layer->layer_tree_impl()
->property_trees()
->scroll_tree_mutable()
.UpdateScrollOffsetBaseForTesting(grand_child_layer->element_id(),
gfx::PointF(0, 30));
child_layer->layer_tree_impl()
->property_trees()
->scroll_tree_mutable()
.UpdateScrollOffsetBaseForTesting(child_layer->element_id(),
gfx::PointF(0, 50));
DrawFrame();
base::TimeTicks start_time = base::TimeTicks() + base::Milliseconds(10);
viz::BeginFrameArgs begin_frame_args =
viz::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, 0, 1);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), gfx::Vector2d(0, -100),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
GetInputHandler().ScrollUpdate(
AnimatedUpdateState(gfx::Point(), gfx::Vector2d(0, -100)).get());
begin_frame_args.frame_time = start_time;
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
host_impl_->UpdateAnimationState(true);
// Should have started scrolling.
EXPECT_NE(gfx::PointF(0, 30), CurrentScrollOffset(grand_child_layer));
host_impl_->DidFinishImplFrame(begin_frame_args);
begin_frame_args.frame_time = start_time + base::Milliseconds(200);
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
host_impl_->UpdateAnimationState(true);
EXPECT_EQ(gfx::PointF(0, 0), CurrentScrollOffset(grand_child_layer));
EXPECT_EQ(gfx::PointF(0, 50), CurrentScrollOffset(child_layer));
host_impl_->DidFinishImplFrame(begin_frame_args);
// Second ScrollAnimated should remain latched to the grand_child_layer.
GetInputHandler().ScrollUpdate(
AnimatedUpdateState(gfx::Point(), gfx::Vector2d(0, -100)).get());
begin_frame_args.frame_time = start_time + base::Milliseconds(250);
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
host_impl_->UpdateAnimationState(true);
host_impl_->DidFinishImplFrame(begin_frame_args);
begin_frame_args.frame_time = start_time + base::Milliseconds(450);
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
host_impl_->UpdateAnimationState(true);
EXPECT_EQ(gfx::PointF(0, 0), CurrentScrollOffset(grand_child_layer));
EXPECT_EQ(gfx::PointF(0, 50), CurrentScrollOffset(child_layer));
host_impl_->DidFinishImplFrame(begin_frame_args);
// Tear down the LayerTreeHostImpl before the InputHandlerClient.
host_impl_->ReleaseLayerTreeFrameSink();
host_impl_ = nullptr;
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollWithoutBubbling) {
// Scroll a child layer beyond its maximum scroll range and make sure the
// the scroll doesn't bubble up to the parent layer.
gfx::Size surface_size(20, 20);
gfx::Size viewport_size(10, 10);
SetupViewportLayersNoScrolls(surface_size);
LayerImpl* child_layer = AddScrollableLayer(InnerViewportScrollLayer(),
viewport_size, surface_size);
LayerImpl* grand_child_layer =
AddScrollableLayer(child_layer, viewport_size, surface_size);
UpdateDrawProperties(host_impl_->active_tree());
host_impl_->active_tree()->DidBecomeActive();
gfx::PointF grand_child_base(0, 2);
gfx::Vector2dF grand_child_delta;
grand_child_layer->layer_tree_impl()
->property_trees()
->scroll_tree_mutable()
.UpdateScrollOffsetBaseForTesting(grand_child_layer->element_id(),
grand_child_base);
gfx::PointF child_base(0, 3);
gfx::Vector2dF child_delta;
child_layer->layer_tree_impl()
->property_trees()
->scroll_tree_mutable()
.UpdateScrollOffsetBaseForTesting(child_layer->element_id(), child_base);
DrawFrame();
{
gfx::Vector2d scroll_delta(0, -10);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), scroll_delta,
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), scroll_delta,
ui::ScrollInputType::kTouchscreen)
.get());
GetInputHandler().ScrollEnd();
std::unique_ptr<CompositorCommitData> commit_data =
host_impl_->ProcessCompositorDeltas(
/* main_thread_mutator_host */ nullptr);
// The grand child should have scrolled up to its limit.
grand_child_delta = gfx::Vector2dF(0, -2);
EXPECT_TRUE(ScrollInfoContains(*commit_data.get(),
grand_child_layer->element_id(),
grand_child_delta));
// The child should not have scrolled.
ExpectNone(*commit_data.get(), child_layer->element_id());
grand_child_base += grand_child_delta;
child_base += child_delta;
PushScrollOffsetsToPendingTree(
{{child_layer->element_id(), child_base},
{grand_child_layer->element_id(), grand_child_base}});
// The next time we scroll we should only scroll the parent.
scroll_delta = gfx::Vector2d(0, -3);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(5, 5), scroll_delta,
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
EXPECT_EQ(host_impl_->CurrentlyScrollingNode()->id,
child_layer->scroll_tree_index());
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), scroll_delta,
ui::ScrollInputType::kTouchscreen)
.get());
EXPECT_EQ(host_impl_->CurrentlyScrollingNode()->id,
child_layer->scroll_tree_index());
GetInputHandler().ScrollEnd();
ClearMainThreadDeltasForTesting(host_impl_.get());
commit_data = host_impl_->ProcessCompositorDeltas(
/* main_thread_mutator_host */ nullptr);
// The child should have scrolled up to its limit.
child_delta = gfx::Vector2dF(0, -3);
EXPECT_TRUE(ScrollInfoContains(*commit_data.get(),
child_layer->element_id(), child_delta));
// The grand child should not have scrolled.
grand_child_delta = gfx::Vector2dF();
ExpectNone(*commit_data.get(), grand_child_layer->element_id());
child_base += child_delta;
grand_child_base += grand_child_delta;
PushScrollOffsetsToPendingTree(
{{grand_child_layer->element_id(), grand_child_base},
{child_layer->element_id(), child_base}});
// After scrolling the parent, another scroll on the opposite direction
// should still scroll the child.
scroll_delta = gfx::Vector2d(0, 7);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(5, 5), scroll_delta,
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
EXPECT_EQ(host_impl_->CurrentlyScrollingNode()->id,
grand_child_layer->scroll_tree_index());
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), scroll_delta,
ui::ScrollInputType::kTouchscreen)
.get());
EXPECT_EQ(host_impl_->CurrentlyScrollingNode()->id,
grand_child_layer->scroll_tree_index());
GetInputHandler().ScrollEnd();
ClearMainThreadDeltasForTesting(host_impl_.get());
commit_data = host_impl_->ProcessCompositorDeltas(
/* main_thread_mutator_host */ nullptr);
// The grand child should have scrolled.
grand_child_delta = gfx::Vector2dF(0, 7);
EXPECT_TRUE(ScrollInfoContains(*commit_data.get(),
grand_child_layer->element_id(),
grand_child_delta));
// The child should not have scrolled.
child_delta = gfx::Vector2dF();
ExpectNone(*commit_data.get(), child_layer->element_id());
grand_child_base += grand_child_delta;
child_base += child_delta;
PushScrollOffsetsToPendingTree(
{{grand_child_layer->element_id(), grand_child_base},
{child_layer->element_id(), child_base}});
// Scrolling should be adjusted from viewport space.
host_impl_->active_tree()->PushPageScaleFromMainThread(2, 2, 2);
host_impl_->active_tree()->SetPageScaleOnActiveTree(2);
scroll_delta = gfx::Vector2d(0, -2);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(1, 1), scroll_delta,
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
EXPECT_EQ(grand_child_layer->scroll_tree_index(),
host_impl_->CurrentlyScrollingNode()->id);
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), scroll_delta,
ui::ScrollInputType::kTouchscreen)
.get());
GetInputHandler().ScrollEnd();
ClearMainThreadDeltasForTesting(host_impl_.get());
commit_data = host_impl_->ProcessCompositorDeltas(
/* main_thread_mutator_host */ nullptr);
// Should have scrolled by half the amount in layer space (-2/2)
EXPECT_TRUE(ScrollInfoContains(*commit_data.get(),
grand_child_layer->element_id(),
gfx::Vector2dF(0, -1)));
}
}
// Ensure that layers who's scroll parent is the InnerViewportScrollNode are
// still able to scroll on the compositor.
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
ChildrenOfInnerScrollNodeCanScrollOnThread) {
gfx::Size viewport_size(10, 10);
gfx::Size content_size(20, 20);
SetupViewportLayersOuterScrolls(viewport_size, content_size);
// Simulate adding a "fixed" layer to the tree.
{
LayerImpl* fixed_layer = AddLayer();
fixed_layer->SetBounds(viewport_size);
fixed_layer->SetDrawsContent(true);
CopyProperties(InnerViewportScrollLayer(), fixed_layer);
}
host_impl_->active_tree()->DidBecomeActive();
DrawFrame();
{
gfx::Vector2dF scroll_delta(0, 4);
// Scrolling should be able to happen on the compositor thread here.
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(5, 5), scroll_delta,
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), scroll_delta, ui::ScrollInputType::kWheel)
.get());
GetInputHandler().ScrollEnd();
std::unique_ptr<CompositorCommitData> commit_data =
host_impl_->ProcessCompositorDeltas(
/* main_thread_mutator_host */ nullptr);
// The outer viewport should have scrolled.
ASSERT_EQ(commit_data->scrolls.size(), 1u);
EXPECT_TRUE(ScrollInfoContains(
*commit_data.get(), host_impl_->OuterViewportScrollNode()->element_id,
scroll_delta));
}
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollEventBubbling) {
// When we try to scroll a non-scrollable child layer, the scroll delta
// should be applied to one of its ancestors if possible.
gfx::Size viewport_size(10, 10);
gfx::Size content_size(20, 20);
SetupViewportLayersOuterScrolls(viewport_size, content_size);
// Add a scroller whose scroll bounds and scroll container bounds are equal.
// Since the max_scroll_offset is 0, scrolls will bubble.
LayerImpl* scroll_child_clip = AddContentLayer();
AddScrollableLayer(scroll_child_clip, gfx::Size(10, 10), gfx::Size(10, 10));
UpdateDrawProperties(host_impl_->active_tree());
host_impl_->active_tree()->DidBecomeActive();
DrawFrame();
{
gfx::Vector2dF scroll_delta(0, 4);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(5, 5), scroll_delta,
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), scroll_delta, ui::ScrollInputType::kWheel)
.get());
GetInputHandler().ScrollEnd();
std::unique_ptr<CompositorCommitData> commit_data =
host_impl_->ProcessCompositorDeltas(
/* main_thread_mutator_host */ nullptr);
// Only the root scroll should have scrolled.
ASSERT_EQ(commit_data->scrolls.size(), 1u);
EXPECT_TRUE(ScrollInfoContains(
*commit_data.get(), host_impl_->OuterViewportScrollNode()->element_id,
scroll_delta));
}
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollBeforeRedraw) {
gfx::Size surface_size(10, 10);
SetupViewportLayersNoScrolls(surface_size);
UpdateDrawProperties(host_impl_->active_tree());
host_impl_->active_tree()->DidBecomeActive();
// Draw one frame and then immediately rebuild the layer tree to mimic a tree
// synchronization.
DrawFrame();
ClearLayersAndPropertyTrees(host_impl_->active_tree());
SetupViewportLayersNoScrolls(surface_size);
// Scrolling should still work even though we did not draw yet.
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(5, 5), gfx::Vector2dF(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollAxisAlignedRotatedLayer) {
SetupViewportLayersInnerScrolls(gfx::Size(50, 50), gfx::Size(100, 100));
auto* scroll_layer = InnerViewportScrollLayer();
scroll_layer->SetDrawsContent(true);
// Rotate the root layer 90 degrees counter-clockwise about its center.
gfx::Transform rotate_transform;
rotate_transform.Rotate(-90.0);
// Set external transform.
host_impl_->OnDraw(rotate_transform, gfx::Rect(0, 0, 50, 50), false, false);
DrawFrame();
// Scroll to the right in screen coordinates with a gesture.
gfx::Vector2d gesture_scroll_delta(10, 0);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), gesture_scroll_delta,
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
GetInputHandler().ScrollUpdate(UpdateState(gfx::Point(), gesture_scroll_delta,
ui::ScrollInputType::kTouchscreen)
.get());
GetInputHandler().ScrollEnd();
// The layer should have scrolled down in its local coordinates.
std::unique_ptr<CompositorCommitData> commit_data =
host_impl_->ProcessCompositorDeltas(
/* main_thread_mutator_host */ nullptr);
EXPECT_TRUE(ScrollInfoContains(*commit_data.get(), scroll_layer->element_id(),
gfx::Vector2dF(0, gesture_scroll_delta.x())));
// Push scrolls to pending tree
PushScrollOffsetsToPendingTree(
{{scroll_layer->element_id(), gfx::PointF(10, 0)}});
ClearNonScrollSyncTreeDeltasForTesting();
// Reset and scroll down with the wheel.
SetScrollOffsetDelta(scroll_layer, gfx::Vector2dF());
gfx::Vector2dF wheel_scroll_delta(0, 10);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), wheel_scroll_delta,
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), wheel_scroll_delta, ui::ScrollInputType::kWheel)
.get());
GetInputHandler().ScrollEnd();
// The layer should have scrolled down in its local coordinates.
commit_data = host_impl_->ProcessCompositorDeltas(
/* main_thread_mutator_host */ nullptr);
EXPECT_TRUE(ScrollInfoContains(*commit_data.get(), scroll_layer->element_id(),
wheel_scroll_delta));
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollNonAxisAlignedRotatedLayer) {
SetupViewportLayersInnerScrolls(gfx::Size(50, 50), gfx::Size(100, 100));
auto* scroll_layer = InnerViewportScrollLayer();
float child_layer_angle = -20;
// Create a child layer that is rotated to a non-axis-aligned angle.
// Only allow vertical scrolling.
gfx::Size content_size = scroll_layer->bounds();
gfx::Size scroll_container_bounds(content_size.width(),
content_size.height() / 2);
LayerImpl* clip_layer = AddLayer();
clip_layer->SetBounds(scroll_container_bounds);
CopyProperties(scroll_layer, clip_layer);
gfx::Transform rotate_transform;
rotate_transform.Translate(-50.0, -50.0);
rotate_transform.Rotate(child_layer_angle);
rotate_transform.Translate(50.0, 50.0);
auto& clip_layer_transform_node = CreateTransformNode(clip_layer);
// The rotation depends on the layer's transform origin, and the child layer
// is a different size than the clip, so make sure the clip layer's origin
// lines up over the child.
clip_layer_transform_node.origin = gfx::Point3F(
clip_layer->bounds().width() * 0.5f, clip_layer->bounds().height(), 0);
clip_layer_transform_node.local = rotate_transform;
LayerImpl* child =
AddScrollableLayer(clip_layer, scroll_container_bounds, content_size);
ElementId child_scroll_id = child->element_id();
DrawFrame();
{
// Scroll down in screen coordinates with a gesture.
gfx::Vector2d gesture_scroll_delta(0, 10);
EXPECT_EQ(
ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(1, 1), gesture_scroll_delta,
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), gesture_scroll_delta,
ui::ScrollInputType::kTouchscreen)
.get());
GetInputHandler().ScrollEnd();
// The child layer should have scrolled down in its local coordinates an
// amount proportional to the angle between it and the input scroll delta.
gfx::Vector2dF expected_scroll_delta(
0, std::floor(gesture_scroll_delta.y() *
std::cos(gfx::DegToRad(child_layer_angle))));
std::unique_ptr<CompositorCommitData> commit_data =
host_impl_->ProcessCompositorDeltas(
/* main_thread_mutator_host */ nullptr);
EXPECT_TRUE(ScrollInfoContains(*commit_data.get(), child_scroll_id,
expected_scroll_delta));
// The root scroll layer should not have scrolled, because the input delta
// was close to the layer's axis of movement.
EXPECT_EQ(commit_data->scrolls.size(), 1u);
PushScrollOffsetsToPendingTree(
{{child_scroll_id,
gfx::PointAtOffsetFromOrigin(expected_scroll_delta)}});
ClearNonScrollSyncTreeDeltasForTesting();
}
{
// Now reset and scroll the same amount horizontally.
SetScrollOffsetDelta(child, gfx::Vector2dF());
gfx::Vector2d gesture_scroll_delta(10, 0);
EXPECT_EQ(
ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(1, 1), gesture_scroll_delta,
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), gesture_scroll_delta,
ui::ScrollInputType::kTouchscreen)
.get());
GetInputHandler().ScrollEnd();
// The child layer should have scrolled down in its local coordinates an
// amount proportional to the angle between it and the input scroll delta.
gfx::Vector2dF expected_scroll_delta(
0, std::floor(-gesture_scroll_delta.x() *
std::sin(gfx::DegToRad(child_layer_angle))));
std::unique_ptr<CompositorCommitData> commit_data =
host_impl_->ProcessCompositorDeltas(
/* main_thread_mutator_host */ nullptr);
EXPECT_TRUE(ScrollInfoContains(*commit_data.get(), child_scroll_id,
expected_scroll_delta));
// The root scroll layer shouldn't have scrolled.
ExpectNone(*commit_data.get(), scroll_layer->element_id());
PushScrollOffsetsToPendingTree(
{{child_scroll_id,
gfx::PointAtOffsetFromOrigin(expected_scroll_delta)}});
}
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollPerspectiveTransformedLayer) {
// When scrolling an element with perspective, the distance scrolled
// depends on the point at which the scroll begins.
SetupViewportLayersInnerScrolls(gfx::Size(50, 50), gfx::Size(100, 100));
auto* scroll_layer = InnerViewportScrollLayer();
// Create a child layer that is rotated on its x axis, with perspective.
LayerImpl* clip_layer = AddLayer();
clip_layer->SetBounds(gfx::Size(50, 50));
CopyProperties(scroll_layer, clip_layer);
gfx::Transform perspective_transform;
perspective_transform.Translate(-50.0, -50.0);
perspective_transform.ApplyPerspectiveDepth(20);
perspective_transform.RotateAboutXAxis(45);
perspective_transform.Translate(50.0, 50.0);
auto& clip_layer_transform_node = CreateTransformNode(clip_layer);
// The transform depends on the layer's transform origin, and the child layer
// is a different size than the clip, so make sure the clip layer's origin
// lines up over the child.
clip_layer_transform_node.origin = gfx::Point3F(
clip_layer->bounds().width(), clip_layer->bounds().height(), 0);
clip_layer_transform_node.local = perspective_transform;
LayerImpl* child = AddScrollableLayer(clip_layer, clip_layer->bounds(),
scroll_layer->bounds());
UpdateDrawProperties(host_impl_->active_tree());
std::unique_ptr<CompositorCommitData> commit_data;
gfx::Vector2dF gesture_scroll_deltas[4];
gesture_scroll_deltas[0] = gfx::Vector2dF(4, 10);
gesture_scroll_deltas[1] = gfx::Vector2dF(4, 10);
gesture_scroll_deltas[2] = gfx::Vector2dF(10, 0);
gesture_scroll_deltas[3] = gfx::Vector2dF(10, 0);
gfx::Vector2dF expected_scroll_deltas[4];
// Perspective affects the vertical delta by a different
// amount depending on the vertical position of the |viewport_point|.
expected_scroll_deltas[0] = gfx::Vector2dF(2, 9);
expected_scroll_deltas[1] = gfx::Vector2dF(1, 4);
// Deltas which start with the same vertical position of the
// |viewport_point| are subject to identical perspective effects.
expected_scroll_deltas[2] = gfx::Vector2dF(5, 0);
expected_scroll_deltas[3] = gfx::Vector2dF(5, 0);
gfx::Point viewport_point(1, 1);
// Scroll in screen coordinates with a gesture. Each scroll starts
// where the previous scroll ended, but the scroll position is reset
// for each scroll.
for (int i = 0; i < 4; ++i) {
SetScrollOffsetDelta(child, gfx::Vector2dF());
DrawFrame();
EXPECT_EQ(
ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(viewport_point, gesture_scroll_deltas[i],
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
GetInputHandler().ScrollUpdate(
UpdateState(viewport_point, gesture_scroll_deltas[i],
ui::ScrollInputType::kTouchscreen)
.get());
viewport_point += gfx::ToFlooredVector2d(gesture_scroll_deltas[i]);
GetInputHandler().ScrollEnd();
commit_data = host_impl_->ProcessCompositorDeltas(
/* main_thread_mutator_host */ nullptr);
EXPECT_TRUE(ScrollInfoContains(*commit_data.get(), child->element_id(),
expected_scroll_deltas[i]));
// The root scroll layer should not have scrolled, because the input delta
// was close to the layer's axis of movement.
EXPECT_EQ(commit_data->scrolls.size(), 1u);
PushScrollOffsetsToPendingTree(
{{child->element_id(),
gfx::PointAtOffsetFromOrigin(expected_scroll_deltas[i])}});
ClearMainThreadDeltasForTesting(host_impl_.get());
}
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollScaledLayer) {
SetupViewportLayersInnerScrolls(gfx::Size(50, 50), gfx::Size(100, 100));
auto* scroll_layer = InnerViewportScrollLayer();
// Scale the layer to twice its normal size.
int scale = 2;
gfx::Transform scale_transform;
scale_transform.Scale(scale, scale);
// Set external transform above root.
host_impl_->OnDraw(scale_transform, gfx::Rect(0, 0, 50, 50), false, false);
DrawFrame();
// Scroll down in screen coordinates with a gesture.
gfx::Vector2d scroll_delta(0, 10);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), scroll_delta,
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), scroll_delta, ui::ScrollInputType::kTouchscreen)
.get());
GetInputHandler().ScrollEnd();
// The layer should have scrolled down in its local coordinates, but half the
// amount.
std::unique_ptr<CompositorCommitData> commit_data =
host_impl_->ProcessCompositorDeltas(
/* main_thread_mutator_host */ nullptr);
EXPECT_TRUE(ScrollInfoContains(*commit_data.get(), scroll_layer->element_id(),
gfx::Vector2dF(0, scroll_delta.y() / scale)));
PushScrollOffsetsToPendingTree(
{{scroll_layer->element_id(), gfx::PointAtOffsetFromOrigin(gfx::Vector2dF(
0, scroll_delta.y() / scale))}});
ClearNonScrollSyncTreeDeltasForTesting();
// Reset and scroll down with the wheel.
SetScrollOffsetDelta(scroll_layer, gfx::Vector2dF());
gfx::Vector2dF wheel_scroll_delta(0, 10);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), wheel_scroll_delta,
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), wheel_scroll_delta, ui::ScrollInputType::kWheel)
.get());
GetInputHandler().ScrollEnd();
// It should apply the scale factor to the scroll delta for the wheel event.
commit_data = host_impl_->ProcessCompositorDeltas(
/* main_thread_mutator_host */ nullptr);
EXPECT_TRUE(ScrollInfoContains(*commit_data.get(), scroll_layer->element_id(),
wheel_scroll_delta));
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollViewportRounding) {
int width = 332;
int height = 20;
int scale = 3;
gfx::Size container_bounds = gfx::Size(width * scale - 1, height * scale);
SetupViewportLayersInnerScrolls(container_bounds, gfx::Size(width, height));
UpdateDrawProperties(host_impl_->active_tree());
host_impl_->active_tree()->SetDeviceScaleFactor(scale);
host_impl_->active_tree()->PushPageScaleFromMainThread(1, 0.5f, 4);
LayerImpl* inner_viewport_scroll_layer = InnerViewportScrollLayer();
EXPECT_EQ(gfx::PointF(0, 0), MaxScrollOffset(inner_viewport_scroll_layer));
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, RootLayerScrollOffsetDelegation) {
TestInputHandlerClient scroll_watcher;
SetupViewportLayersInnerScrolls(gfx::Size(10, 20), gfx::Size(100, 100));
auto* scroll_layer = InnerViewportScrollLayer();
UpdateDrawProperties(host_impl_->active_tree());
GetInputHandler().BindToClient(&scroll_watcher);
gfx::Vector2dF initial_scroll_delta(10, 10);
scroll_layer->layer_tree_impl()
->property_trees()
->scroll_tree_mutable()
.UpdateScrollOffsetBaseForTesting(scroll_layer->element_id(),
gfx::PointF());
SetScrollOffsetDelta(scroll_layer, initial_scroll_delta);
EXPECT_EQ(gfx::PointF(), scroll_watcher.last_set_scroll_offset());
// Requesting an update results in the current scroll offset being set.
GetInputHandler().RequestUpdateForSynchronousInputHandler();
EXPECT_EQ(initial_scroll_delta,
scroll_watcher.last_set_scroll_offset().OffsetFromOrigin());
// Setting the delegate results in the scrollable_size, max_scroll_offset,
// page_scale_factor and {min|max}_page_scale_factor being set.
EXPECT_EQ(gfx::SizeF(100, 100), scroll_watcher.scrollable_size());
EXPECT_EQ(gfx::PointF(90, 80), scroll_watcher.max_scroll_offset());
EXPECT_EQ(1, scroll_watcher.page_scale_factor());
EXPECT_EQ(1, scroll_watcher.min_page_scale_factor());
EXPECT_EQ(1, scroll_watcher.max_page_scale_factor());
// Put a page scale on the tree.
host_impl_->active_tree()->PushPageScaleFromMainThread(2, 0.5f, 4);
EXPECT_EQ(1, scroll_watcher.page_scale_factor());
EXPECT_EQ(1, scroll_watcher.min_page_scale_factor());
EXPECT_EQ(1, scroll_watcher.max_page_scale_factor());
// Activation will update the delegate.
host_impl_->ActivateSyncTree();
EXPECT_EQ(2, scroll_watcher.page_scale_factor());
EXPECT_EQ(.5f, scroll_watcher.min_page_scale_factor());
EXPECT_EQ(4, scroll_watcher.max_page_scale_factor());
// Animating page scale can change the root offset, so it should update the
// delegate. Also resets the page scale to 1 for the rest of the test.
host_impl_->LayerTreeHostImpl::StartPageScaleAnimation(
gfx::Point(0, 0), false, 1, base::TimeDelta());
host_impl_->Animate();
EXPECT_EQ(1, scroll_watcher.page_scale_factor());
EXPECT_EQ(.5f, scroll_watcher.min_page_scale_factor());
EXPECT_EQ(4, scroll_watcher.max_page_scale_factor());
// The pinch gesture doesn't put the delegate into a state where the scroll
// offset is outside of the scroll range. (this is verified by DCHECKs in the
// delegate).
GetInputHandler().ScrollBegin(BeginState(gfx::Point(), gfx::Vector2dF(),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
GetInputHandler().PinchGestureBegin(gfx::Point(),
ui::ScrollInputType::kWheel);
GetInputHandler().PinchGestureUpdate(2, gfx::Point());
GetInputHandler().PinchGestureUpdate(.5f, gfx::Point());
GetInputHandler().PinchGestureEnd(gfx::Point());
GetInputHandler().ScrollEnd();
// Scrolling should be relative to the offset as given by the delegate.
gfx::Vector2dF scroll_delta(0, 10);
gfx::PointF current_offset(7, 8);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), scroll_delta,
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
GetInputHandler().SetSynchronousInputHandlerRootScrollOffset(current_offset);
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), scroll_delta, ui::ScrollInputType::kTouchscreen)
.get());
EXPECT_EQ(current_offset + scroll_delta,
scroll_watcher.last_set_scroll_offset());
current_offset = gfx::PointF(42, 41);
GetInputHandler().SetSynchronousInputHandlerRootScrollOffset(current_offset);
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), scroll_delta, ui::ScrollInputType::kTouchscreen)
.get());
EXPECT_EQ(current_offset + scroll_delta,
scroll_watcher.last_set_scroll_offset());
GetInputHandler().ScrollEnd();
GetInputHandler().SetSynchronousInputHandlerRootScrollOffset(gfx::PointF());
// Forces a full tree synchronization and ensures that the scroll delegate
// sees the correct size of the new tree.
gfx::Size new_viewport_size(21, 12);
gfx::Size new_content_size(42, 24);
CreatePendingTree();
host_impl_->pending_tree()->PushPageScaleFromMainThread(1, 1, 1);
SetupViewportLayers(host_impl_->pending_tree(), new_viewport_size,
new_content_size, new_content_size);
host_impl_->ActivateSyncTree();
EXPECT_EQ(gfx::SizeF(new_content_size), scroll_watcher.scrollable_size());
// Tear down the LayerTreeHostImpl before the InputHandlerClient.
host_impl_->ReleaseLayerTreeFrameSink();
host_impl_ = nullptr;
}
void CheckLayerScrollOffset(LayerImpl* layer, gfx::Point scroll_offset) {
const gfx::Transform target_space_transform =
layer->draw_properties().target_space_transform;
EXPECT_TRUE(target_space_transform.IsScaleOrTranslation());
gfx::Point translated_point = target_space_transform.MapPoint(gfx::Point());
EXPECT_EQ(-scroll_offset.x(), translated_point.x());
EXPECT_EQ(-scroll_offset.y(), translated_point.y());
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
ExternalRootLayerScrollOffsetDelegationReflectedInNextDraw) {
SetupViewportLayersInnerScrolls(gfx::Size(10, 20), gfx::Size(100, 100));
auto* scroll_layer = InnerViewportScrollLayer();
scroll_layer->SetDrawsContent(true);
// Draw first frame to clear any pending draws and check scroll.
DrawFrame();
CheckLayerScrollOffset(scroll_layer, gfx::Point(0, 0));
EXPECT_FALSE(host_impl_->active_tree()->needs_update_draw_properties());
// Set external scroll delta on delegate and notify LayerTreeHost.
gfx::PointF scroll_offset(10, 10);
GetInputHandler().SetSynchronousInputHandlerRootScrollOffset(scroll_offset);
CheckLayerScrollOffset(scroll_layer, gfx::Point(0, 0));
EXPECT_TRUE(host_impl_->active_tree()->needs_update_draw_properties());
// Check scroll delta reflected in layer.
TestFrameData frame;
auto args = viz::CreateBeginFrameArgsForTesting(
BEGINFRAME_FROM_HERE, viz::BeginFrameArgs::kManualSourceId, 1,
base::TimeTicks() + base::Milliseconds(1));
host_impl_->WillBeginImplFrame(args);
EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame));
host_impl_->DrawLayers(&frame);
host_impl_->DidDrawAllLayers(frame);
host_impl_->DidFinishImplFrame(args);
EXPECT_FALSE(frame.has_no_damage);
CheckLayerScrollOffset(scroll_layer, gfx::ToRoundedPoint(scroll_offset));
}
// Ensure the viewport correctly handles the user_scrollable bits. That is, if
// the outer viewport disables user scrolling, we should still be able to
// scroll the inner viewport.
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ViewportUserScrollable) {
gfx::Size viewport_size(100, 100);
gfx::Size content_size(200, 200);
SetupViewportLayersOuterScrolls(viewport_size, content_size);
auto* outer_scroll = OuterViewportScrollLayer();
auto* inner_scroll = InnerViewportScrollLayer();
ScrollTree& scroll_tree =
host_impl_->active_tree()->property_trees()->scroll_tree_mutable();
ElementId inner_element_id = inner_scroll->element_id();
ElementId outer_element_id = outer_scroll->element_id();
DrawFrame();
// "Zoom in" so that the inner viewport is scrollable.
float page_scale_factor = 2;
host_impl_->active_tree()->PushPageScaleFromMainThread(
page_scale_factor, page_scale_factor, page_scale_factor);
// Disable scrolling the outer viewport horizontally. The inner viewport
// should still be allowed to scroll.
GetScrollNode(outer_scroll)->user_scrollable_vertical = true;
GetScrollNode(outer_scroll)->user_scrollable_horizontal = false;
gfx::Vector2dF scroll_delta(30 * page_scale_factor, 0);
{
auto begin_state = BeginState(gfx::Point(), scroll_delta,
ui::ScrollInputType::kTouchscreen);
EXPECT_EQ(
ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(begin_state.get(), ui::ScrollInputType::kTouchscreen)
.thread);
// Try scrolling right, the inner viewport should be allowed to scroll.
auto update_state = UpdateState(gfx::Point(), scroll_delta,
ui::ScrollInputType::kTouchscreen);
GetInputHandler().ScrollUpdate(update_state.get());
EXPECT_POINTF_EQ(gfx::PointF(30, 0),
scroll_tree.current_scroll_offset(inner_element_id));
EXPECT_POINTF_EQ(gfx::PointF(0, 0),
scroll_tree.current_scroll_offset(outer_element_id));
// Continue scrolling. The inner viewport should scroll until its extent,
// however, the outer viewport should not accept any scroll.
update_state = UpdateState(gfx::Point(), scroll_delta,
ui::ScrollInputType::kTouchscreen);
GetInputHandler().ScrollUpdate(update_state.get());
update_state = UpdateState(gfx::Point(), scroll_delta,
ui::ScrollInputType::kTouchscreen);
GetInputHandler().ScrollUpdate(update_state.get());
update_state = UpdateState(gfx::Point(), scroll_delta,
ui::ScrollInputType::kTouchscreen);
GetInputHandler().ScrollUpdate(update_state.get());
EXPECT_POINTF_EQ(gfx::PointF(50, 0),
scroll_tree.current_scroll_offset(inner_element_id));
EXPECT_POINTF_EQ(gfx::PointF(0, 0),
scroll_tree.current_scroll_offset(outer_element_id));
GetInputHandler().ScrollEnd();
}
// Reset. Try the same test above but using animated scrolls.
SetScrollOffset(outer_scroll, gfx::PointF(0, 0));
SetScrollOffset(inner_scroll, gfx::PointF(0, 0));
{
auto begin_state =
BeginState(gfx::Point(), scroll_delta, ui::ScrollInputType::kWheel);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(begin_state.get(), ui::ScrollInputType::kWheel)
.thread);
// Try scrolling right, the inner viewport should be allowed to scroll.
auto update_state = AnimatedUpdateState(gfx::Point(), scroll_delta);
GetInputHandler().ScrollUpdate(update_state.get());
base::TimeTicks cur_time = base::TimeTicks() + base::Milliseconds(100);
viz::BeginFrameArgs begin_frame_args =
viz::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, 0, 1);
#define ANIMATE(time_ms) \
cur_time += base::Milliseconds(time_ms); \
begin_frame_args.frame_time = (cur_time); \
begin_frame_args.frame_id.sequence_number++; \
host_impl_->WillBeginImplFrame(begin_frame_args); \
host_impl_->Animate(); \
host_impl_->UpdateAnimationState(true); \
host_impl_->DidFinishImplFrame(begin_frame_args);
// The animation is setup in the first frame so tick twice to actually
// animate it.
ANIMATE(0);
ANIMATE(200);
EXPECT_POINTF_EQ(gfx::PointF(30, 0),
scroll_tree.current_scroll_offset(inner_element_id));
EXPECT_POINTF_EQ(gfx::PointF(0, 0),
scroll_tree.current_scroll_offset(outer_element_id));
// Continue scrolling. The inner viewport should scroll until its extent,
// however, the outer viewport should not accept any scroll.
update_state = AnimatedUpdateState(gfx::Point(), scroll_delta);
GetInputHandler().ScrollUpdate(update_state.get());
ANIMATE(10);
ANIMATE(200);
EXPECT_POINTF_EQ(gfx::PointF(50, 0),
scroll_tree.current_scroll_offset(inner_element_id));
EXPECT_POINTF_EQ(gfx::PointF(0, 0),
scroll_tree.current_scroll_offset(outer_element_id));
// Continue scrolling. the outer viewport should still not scroll.
update_state = AnimatedUpdateState(gfx::Point(), scroll_delta);
GetInputHandler().ScrollUpdate(update_state.get());
ANIMATE(10);
ANIMATE(200);
EXPECT_POINTF_EQ(gfx::PointF(50, 0),
scroll_tree.current_scroll_offset(inner_element_id));
EXPECT_POINTF_EQ(gfx::PointF(0, 0),
scroll_tree.current_scroll_offset(outer_element_id));
// Fully scroll the inner viewport. We'll now try to start an animation on
// the outer viewport in the vertical direction, which is scrollable. We'll
// then try to update the curve to scroll horizontally. Ensure that doesn't
// allow any horizontal scroll.
SetScrollOffset(inner_scroll, gfx::PointF(50, 50));
update_state = AnimatedUpdateState(gfx::Point(), gfx::Vector2dF(0, 100));
GetInputHandler().ScrollUpdate(update_state.get());
ANIMATE(16);
ANIMATE(64);
// We don't care about the exact offset, we just want to make sure the
// scroll is in progress but not finished.
ASSERT_LT(0, scroll_tree.current_scroll_offset(outer_element_id).y());
ASSERT_GT(50, scroll_tree.current_scroll_offset(outer_element_id).y());
ASSERT_EQ(0, scroll_tree.current_scroll_offset(outer_element_id).x());
EXPECT_POINTF_EQ(gfx::PointF(50, 50),
scroll_tree.current_scroll_offset(inner_element_id));
// Now when we scroll we should do so by updating the ongoing animation
// curve. Ensure this doesn't allow any horizontal scrolling.
update_state = AnimatedUpdateState(gfx::Point(), gfx::Vector2dF(100, 100));
GetInputHandler().ScrollUpdate(update_state.get());
ANIMATE(200);
EXPECT_POINTF_EQ(gfx::PointF(0, 100),
scroll_tree.current_scroll_offset(outer_element_id));
EXPECT_POINTF_EQ(gfx::PointF(50, 50),
scroll_tree.current_scroll_offset(inner_element_id));
#undef ANIMATE
GetInputHandler().ScrollEnd();
}
}
// Ensure that the SetSynchronousInputHandlerRootScrollOffset method used by
// the WebView API correctly respects the user_scrollable bits on both of the
// inner and outer viewport scroll nodes.
TEST_P(ScrollUnifiedLayerTreeHostImplTest, SetRootScrollOffsetUserScrollable) {
gfx::Size viewport_size(100, 100);
gfx::Size content_size(200, 200);
SetupViewportLayersOuterScrolls(viewport_size, content_size);
auto* outer_scroll = OuterViewportScrollLayer();
auto* inner_scroll = InnerViewportScrollLayer();
ScrollTree& scroll_tree =
host_impl_->active_tree()->property_trees()->scroll_tree_mutable();
ElementId inner_element_id = inner_scroll->element_id();
ElementId outer_element_id = outer_scroll->element_id();
DrawFrame();
// Ensure that the scroll offset is interpreted as a content offset so it
// should be unaffected by the page scale factor. See
// https://crbug.com/973771.
float page_scale_factor = 2;
host_impl_->active_tree()->PushPageScaleFromMainThread(
page_scale_factor, page_scale_factor, page_scale_factor);
// Disable scrolling the inner viewport. Only the outer should scroll.
{
ASSERT_FALSE(did_request_redraw_);
GetScrollNode(inner_scroll)->user_scrollable_vertical = false;
GetScrollNode(inner_scroll)->user_scrollable_horizontal = false;
gfx::PointF scroll_offset(25, 30);
GetInputHandler().SetSynchronousInputHandlerRootScrollOffset(scroll_offset);
EXPECT_POINTF_EQ(gfx::PointF(0, 0),
scroll_tree.current_scroll_offset(inner_element_id));
EXPECT_POINTF_EQ(scroll_offset,
scroll_tree.current_scroll_offset(outer_element_id));
EXPECT_TRUE(did_request_redraw_);
// Reset
did_request_redraw_ = false;
GetScrollNode(inner_scroll)->user_scrollable_vertical = true;
GetScrollNode(inner_scroll)->user_scrollable_horizontal = true;
SetScrollOffset(outer_scroll, gfx::PointF(0, 0));
}
// Disable scrolling the outer viewport. The inner should scroll to its
// extent but there should be no bubbling over to the outer viewport.
{
ASSERT_FALSE(did_request_redraw_);
GetScrollNode(outer_scroll)->user_scrollable_vertical = false;
GetScrollNode(outer_scroll)->user_scrollable_horizontal = false;
gfx::PointF scroll_offset(120, 140);
GetInputHandler().SetSynchronousInputHandlerRootScrollOffset(scroll_offset);
EXPECT_POINTF_EQ(gfx::PointF(50, 50),
scroll_tree.current_scroll_offset(inner_element_id));
EXPECT_POINTF_EQ(gfx::PointF(0, 0),
scroll_tree.current_scroll_offset(outer_element_id));
EXPECT_TRUE(did_request_redraw_);
// Reset
did_request_redraw_ = false;
GetScrollNode(outer_scroll)->user_scrollable_vertical = true;
GetScrollNode(outer_scroll)->user_scrollable_horizontal = true;
SetScrollOffset(inner_scroll, gfx::PointF(0, 0));
}
// Disable both viewports. No scrolling should take place, no redraw should
// be requested.
{
ASSERT_FALSE(did_request_redraw_);
GetScrollNode(inner_scroll)->user_scrollable_vertical = false;
GetScrollNode(inner_scroll)->user_scrollable_horizontal = false;
GetScrollNode(outer_scroll)->user_scrollable_vertical = false;
GetScrollNode(outer_scroll)->user_scrollable_horizontal = false;
gfx::PointF scroll_offset(60, 70);
GetInputHandler().SetSynchronousInputHandlerRootScrollOffset(scroll_offset);
EXPECT_POINTF_EQ(gfx::PointF(0, 0),
scroll_tree.current_scroll_offset(inner_element_id));
EXPECT_POINTF_EQ(gfx::PointF(0, 0),
scroll_tree.current_scroll_offset(outer_element_id));
EXPECT_FALSE(did_request_redraw_);
// Reset
GetScrollNode(inner_scroll)->user_scrollable_vertical = true;
GetScrollNode(inner_scroll)->user_scrollable_horizontal = true;
GetScrollNode(outer_scroll)->user_scrollable_vertical = true;
GetScrollNode(outer_scroll)->user_scrollable_horizontal = true;
}
// If the inner is at its extent but the outer cannot scroll, we shouldn't
// request a redraw.
{
ASSERT_FALSE(did_request_redraw_);
GetScrollNode(outer_scroll)->user_scrollable_vertical = false;
GetScrollNode(outer_scroll)->user_scrollable_horizontal = false;
SetScrollOffset(inner_scroll, gfx::PointF(50, 50));
gfx::PointF scroll_offset(60, 70);
GetInputHandler().SetSynchronousInputHandlerRootScrollOffset(scroll_offset);
EXPECT_POINTF_EQ(gfx::PointF(50, 50),
scroll_tree.current_scroll_offset(inner_element_id));
EXPECT_POINTF_EQ(gfx::PointF(0, 0),
scroll_tree.current_scroll_offset(outer_element_id));
EXPECT_FALSE(did_request_redraw_);
// Reset
GetScrollNode(outer_scroll)->user_scrollable_vertical = true;
GetScrollNode(outer_scroll)->user_scrollable_horizontal = true;
}
}
// The SetSynchronousInputHandlerRootScrollOffset API can be called while there
// is no inner viewport set. This test passes if we don't crash.
TEST_P(ScrollUnifiedLayerTreeHostImplTest, SetRootScrollOffsetNoViewportCrash) {
auto* inner_scroll = InnerViewportScrollLayer();
ASSERT_FALSE(inner_scroll);
gfx::PointF scroll_offset(25, 30);
GetInputHandler().SetSynchronousInputHandlerRootScrollOffset(scroll_offset);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, OverscrollRoot) {
InputHandlerScrollResult scroll_result;
SetupViewportLayersInnerScrolls(gfx::Size(50, 50), gfx::Size(100, 100));
host_impl_->active_tree()->PushPageScaleFromMainThread(1, 0.5f, 4);
DrawFrame();
EXPECT_EQ(gfx::Vector2dF(),
GetInputHandler().accumulated_root_overscroll_for_testing());
// In-bounds scrolling does not affect overscroll.
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), gfx::Vector2dF(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
scroll_result = GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), gfx::Vector2d(0, 10),
ui::ScrollInputType::kWheel)
.get());
EXPECT_TRUE(scroll_result.did_scroll);
EXPECT_FALSE(scroll_result.did_overscroll_root);
EXPECT_EQ(gfx::Vector2dF(), scroll_result.unused_scroll_delta);
EXPECT_EQ(gfx::Vector2dF(),
GetInputHandler().accumulated_root_overscroll_for_testing());
// Overscroll events are reflected immediately.
scroll_result = GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), gfx::Vector2d(0, 50),
ui::ScrollInputType::kWheel)
.get());
EXPECT_TRUE(scroll_result.did_scroll);
EXPECT_TRUE(scroll_result.did_overscroll_root);
EXPECT_EQ(gfx::Vector2dF(0, 10), scroll_result.unused_scroll_delta);
EXPECT_EQ(gfx::Vector2dF(0, 10),
GetInputHandler().accumulated_root_overscroll_for_testing());
EXPECT_EQ(scroll_result.accumulated_root_overscroll,
GetInputHandler().accumulated_root_overscroll_for_testing());
// In-bounds scrolling resets accumulated overscroll for the scrolled axes.
scroll_result = GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), gfx::Vector2d(0, -50),
ui::ScrollInputType::kWheel)
.get());
EXPECT_TRUE(scroll_result.did_scroll);
EXPECT_FALSE(scroll_result.did_overscroll_root);
EXPECT_EQ(gfx::Vector2dF(), scroll_result.unused_scroll_delta);
EXPECT_EQ(gfx::Vector2dF(0, 0),
GetInputHandler().accumulated_root_overscroll_for_testing());
EXPECT_EQ(scroll_result.accumulated_root_overscroll,
GetInputHandler().accumulated_root_overscroll_for_testing());
scroll_result = GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), gfx::Vector2d(0, -10),
ui::ScrollInputType::kWheel)
.get());
EXPECT_FALSE(scroll_result.did_scroll);
EXPECT_TRUE(scroll_result.did_overscroll_root);
EXPECT_EQ(gfx::Vector2dF(0, -10), scroll_result.unused_scroll_delta);
EXPECT_EQ(gfx::Vector2dF(0, -10),
GetInputHandler().accumulated_root_overscroll_for_testing());
EXPECT_EQ(scroll_result.accumulated_root_overscroll,
GetInputHandler().accumulated_root_overscroll_for_testing());
scroll_result = GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), gfx::Vector2d(10, 0),
ui::ScrollInputType::kWheel)
.get());
EXPECT_TRUE(scroll_result.did_scroll);
EXPECT_FALSE(scroll_result.did_overscroll_root);
EXPECT_EQ(gfx::Vector2dF(0, 0), scroll_result.unused_scroll_delta);
EXPECT_EQ(gfx::Vector2dF(0, -10),
GetInputHandler().accumulated_root_overscroll_for_testing());
EXPECT_EQ(scroll_result.accumulated_root_overscroll,
GetInputHandler().accumulated_root_overscroll_for_testing());
scroll_result = GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), gfx::Vector2d(-15, 0),
ui::ScrollInputType::kWheel)
.get());
EXPECT_TRUE(scroll_result.did_scroll);
EXPECT_TRUE(scroll_result.did_overscroll_root);
EXPECT_EQ(gfx::Vector2dF(-5, 0), scroll_result.unused_scroll_delta);
EXPECT_EQ(gfx::Vector2dF(-5, -10),
GetInputHandler().accumulated_root_overscroll_for_testing());
EXPECT_EQ(scroll_result.accumulated_root_overscroll,
GetInputHandler().accumulated_root_overscroll_for_testing());
scroll_result = GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), gfx::Vector2d(0, 60),
ui::ScrollInputType::kWheel)
.get());
EXPECT_TRUE(scroll_result.did_scroll);
EXPECT_TRUE(scroll_result.did_overscroll_root);
EXPECT_EQ(gfx::Vector2dF(0, 10), scroll_result.unused_scroll_delta);
EXPECT_EQ(gfx::Vector2dF(-5, 10),
GetInputHandler().accumulated_root_overscroll_for_testing());
EXPECT_EQ(scroll_result.accumulated_root_overscroll,
GetInputHandler().accumulated_root_overscroll_for_testing());
scroll_result = GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), gfx::Vector2d(10, -60),
ui::ScrollInputType::kWheel)
.get());
EXPECT_TRUE(scroll_result.did_scroll);
EXPECT_TRUE(scroll_result.did_overscroll_root);
EXPECT_EQ(gfx::Vector2dF(0, -10), scroll_result.unused_scroll_delta);
EXPECT_EQ(gfx::Vector2dF(0, -10),
GetInputHandler().accumulated_root_overscroll_for_testing());
EXPECT_EQ(scroll_result.accumulated_root_overscroll,
GetInputHandler().accumulated_root_overscroll_for_testing());
// Overscroll accumulates within the scope of ScrollBegin/ScrollEnd as long
// as no scroll occurs.
scroll_result = GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), gfx::Vector2d(0, -20),
ui::ScrollInputType::kWheel)
.get());
EXPECT_FALSE(scroll_result.did_scroll);
EXPECT_TRUE(scroll_result.did_overscroll_root);
EXPECT_EQ(gfx::Vector2dF(0, -20), scroll_result.unused_scroll_delta);
EXPECT_EQ(gfx::Vector2dF(0, -30),
GetInputHandler().accumulated_root_overscroll_for_testing());
EXPECT_EQ(scroll_result.accumulated_root_overscroll,
GetInputHandler().accumulated_root_overscroll_for_testing());
scroll_result = GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), gfx::Vector2d(0, -20),
ui::ScrollInputType::kWheel)
.get());
EXPECT_FALSE(scroll_result.did_scroll);
EXPECT_TRUE(scroll_result.did_overscroll_root);
EXPECT_EQ(gfx::Vector2dF(0, -20), scroll_result.unused_scroll_delta);
EXPECT_EQ(gfx::Vector2dF(0, -50),
GetInputHandler().accumulated_root_overscroll_for_testing());
EXPECT_EQ(scroll_result.accumulated_root_overscroll,
GetInputHandler().accumulated_root_overscroll_for_testing());
// Overscroll resets on valid scroll.
scroll_result = GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), gfx::Vector2d(0, 10),
ui::ScrollInputType::kWheel)
.get());
EXPECT_TRUE(scroll_result.did_scroll);
EXPECT_FALSE(scroll_result.did_overscroll_root);
EXPECT_EQ(gfx::Vector2dF(0, 0), scroll_result.unused_scroll_delta);
EXPECT_EQ(gfx::Vector2dF(0, 0),
GetInputHandler().accumulated_root_overscroll_for_testing());
EXPECT_EQ(scroll_result.accumulated_root_overscroll,
GetInputHandler().accumulated_root_overscroll_for_testing());
scroll_result = GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), gfx::Vector2d(0, -20),
ui::ScrollInputType::kWheel)
.get());
EXPECT_TRUE(scroll_result.did_scroll);
EXPECT_TRUE(scroll_result.did_overscroll_root);
EXPECT_EQ(gfx::Vector2dF(0, -10), scroll_result.unused_scroll_delta);
EXPECT_EQ(gfx::Vector2dF(0, -10),
GetInputHandler().accumulated_root_overscroll_for_testing());
EXPECT_EQ(scroll_result.accumulated_root_overscroll,
GetInputHandler().accumulated_root_overscroll_for_testing());
GetInputHandler().ScrollEnd();
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, OverscrollChildWithoutBubbling) {
// Scroll child layers beyond their maximum scroll range and make sure root
// overscroll does not accumulate.
InputHandlerScrollResult scroll_result;
gfx::Size scroll_container_size(5, 5);
gfx::Size surface_size(10, 10);
SetupViewportLayersNoScrolls(surface_size);
LayerImpl* root = AddScrollableLayer(OuterViewportScrollLayer(),
scroll_container_size, surface_size);
LayerImpl* child_layer =
AddScrollableLayer(root, scroll_container_size, surface_size);
LayerImpl* grand_child_layer =
AddScrollableLayer(child_layer, scroll_container_size, surface_size);
UpdateDrawProperties(host_impl_->active_tree());
host_impl_->active_tree()->DidBecomeActive();
child_layer->layer_tree_impl()
->property_trees()
->scroll_tree_mutable()
.UpdateScrollOffsetBaseForTesting(child_layer->element_id(),
gfx::PointF(0, 3));
grand_child_layer->layer_tree_impl()
->property_trees()
->scroll_tree_mutable()
.UpdateScrollOffsetBaseForTesting(grand_child_layer->element_id(),
gfx::PointF(0, 2));
DrawFrame();
{
gfx::Vector2d scroll_delta(0, -10);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), scroll_delta,
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
scroll_result = GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), scroll_delta,
ui::ScrollInputType::kTouchscreen)
.get());
EXPECT_EQ(host_impl_->CurrentlyScrollingNode()->id,
grand_child_layer->scroll_tree_index());
EXPECT_TRUE(scroll_result.did_scroll);
EXPECT_FALSE(scroll_result.did_overscroll_root);
EXPECT_EQ(gfx::Vector2dF(),
GetInputHandler().accumulated_root_overscroll_for_testing());
GetInputHandler().ScrollEnd();
// The next time we scroll we should only scroll the parent, but overscroll
// should still not reach the root layer.
scroll_delta = gfx::Vector2d(0, -30);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(5, 5), scroll_delta,
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
EXPECT_EQ(host_impl_->CurrentlyScrollingNode()->id,
child_layer->scroll_tree_index());
EXPECT_EQ(gfx::Vector2dF(),
GetInputHandler().accumulated_root_overscroll_for_testing());
GetInputHandler().ScrollEnd();
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(5, 5), scroll_delta,
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
scroll_result = GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), scroll_delta,
ui::ScrollInputType::kTouchscreen)
.get());
EXPECT_TRUE(scroll_result.did_scroll);
EXPECT_FALSE(scroll_result.did_overscroll_root);
EXPECT_EQ(host_impl_->CurrentlyScrollingNode()->id,
child_layer->scroll_tree_index());
EXPECT_EQ(gfx::Vector2dF(),
GetInputHandler().accumulated_root_overscroll_for_testing());
GetInputHandler().ScrollEnd();
// After scrolling the parent, another scroll on the opposite direction
// should scroll the child.
scroll_delta = gfx::Vector2d(0, 70);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(5, 5), scroll_delta,
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
EXPECT_EQ(host_impl_->CurrentlyScrollingNode()->id,
grand_child_layer->scroll_tree_index());
scroll_result = GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), scroll_delta,
ui::ScrollInputType::kTouchscreen)
.get());
EXPECT_TRUE(scroll_result.did_scroll);
EXPECT_FALSE(scroll_result.did_overscroll_root);
EXPECT_EQ(host_impl_->CurrentlyScrollingNode()->id,
grand_child_layer->scroll_tree_index());
EXPECT_EQ(gfx::Vector2dF(),
GetInputHandler().accumulated_root_overscroll_for_testing());
GetInputHandler().ScrollEnd();
}
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, OverscrollChildEventBubbling) {
// When we try to scroll a non-scrollable child layer, the scroll delta
// should be applied to one of its ancestors if possible. Overscroll should
// be reflected only when it has bubbled up to the root scrolling layer.
InputHandlerScrollResult scroll_result;
SetupViewportLayersInnerScrolls(gfx::Size(10, 10), gfx::Size(20, 20));
DrawFrame();
{
gfx::Vector2d scroll_delta(0, 8);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(5, 5), scroll_delta,
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
scroll_result = GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), scroll_delta, ui::ScrollInputType::kWheel)
.get());
EXPECT_TRUE(scroll_result.did_scroll);
EXPECT_FALSE(scroll_result.did_overscroll_root);
EXPECT_EQ(gfx::Vector2dF(),
GetInputHandler().accumulated_root_overscroll_for_testing());
scroll_result = GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), scroll_delta, ui::ScrollInputType::kWheel)
.get());
EXPECT_TRUE(scroll_result.did_scroll);
EXPECT_TRUE(scroll_result.did_overscroll_root);
EXPECT_EQ(gfx::Vector2dF(0, 6),
GetInputHandler().accumulated_root_overscroll_for_testing());
scroll_result = GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), scroll_delta, ui::ScrollInputType::kWheel)
.get());
EXPECT_FALSE(scroll_result.did_scroll);
EXPECT_TRUE(scroll_result.did_overscroll_root);
EXPECT_EQ(gfx::Vector2dF(0, 14),
GetInputHandler().accumulated_root_overscroll_for_testing());
GetInputHandler().ScrollEnd();
}
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, OverscrollAlways) {
InputHandlerScrollResult scroll_result;
LayerTreeSettings settings = DefaultSettings();
CreateHostImpl(settings, CreateLayerTreeFrameSink());
SetupViewportLayersNoScrolls(gfx::Size(50, 50));
UpdateDrawProperties(host_impl_->active_tree());
host_impl_->active_tree()->PushPageScaleFromMainThread(1, 0.5f, 4);
DrawFrame();
EXPECT_EQ(gfx::Vector2dF(),
GetInputHandler().accumulated_root_overscroll_for_testing());
// Even though the layer can't scroll the overscroll still happens.
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), gfx::Vector2dF(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
scroll_result = GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), gfx::Vector2d(0, 10),
ui::ScrollInputType::kWheel)
.get());
EXPECT_FALSE(scroll_result.did_scroll);
EXPECT_TRUE(scroll_result.did_overscroll_root);
EXPECT_EQ(gfx::Vector2dF(0, 10),
GetInputHandler().accumulated_root_overscroll_for_testing());
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, NoOverscrollWhenNotAtEdge) {
InputHandlerScrollResult scroll_result;
gfx::Size viewport_size(100, 100);
gfx::Size content_size(200, 200);
SetupViewportLayersOuterScrolls(viewport_size, content_size);
DrawFrame();
{
// Edge glow effect should be applicable only upon reaching Edges
// of the content. unnecessary glow effect calls shouldn't be
// called while scrolling up without reaching the edge of the content.
EXPECT_EQ(
ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(0, 0), gfx::Vector2dF(0, 100),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
scroll_result = GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), gfx::Vector2dF(0, 100),
ui::ScrollInputType::kWheel)
.get());
EXPECT_TRUE(scroll_result.did_scroll);
EXPECT_FALSE(scroll_result.did_overscroll_root);
EXPECT_EQ(gfx::Vector2dF(),
GetInputHandler().accumulated_root_overscroll_for_testing());
scroll_result = GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), gfx::Vector2dF(0, -2.30f),
ui::ScrollInputType::kWheel)
.get());
EXPECT_TRUE(scroll_result.did_scroll);
EXPECT_FALSE(scroll_result.did_overscroll_root);
EXPECT_EQ(gfx::Vector2dF(),
GetInputHandler().accumulated_root_overscroll_for_testing());
GetInputHandler().ScrollEnd();
// unusedrootDelta should be subtracted from applied delta so that
// unwanted glow effect calls are not called.
EXPECT_EQ(
ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(0, 0), gfx::Vector2dF(0, 20),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
scroll_result = GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), gfx::Vector2dF(0, 20),
ui::ScrollInputType::kTouchscreen)
.get());
EXPECT_TRUE(scroll_result.did_scroll);
EXPECT_TRUE(scroll_result.did_overscroll_root);
EXPECT_VECTOR2DF_EQ(
gfx::Vector2dF(0.000000f, 17.699997f),
GetInputHandler().accumulated_root_overscroll_for_testing());
scroll_result = GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), gfx::Vector2dF(0.02f, -0.01f),
ui::ScrollInputType::kTouchscreen)
.get());
EXPECT_FALSE(scroll_result.did_scroll);
EXPECT_FALSE(scroll_result.did_overscroll_root);
EXPECT_VECTOR2DF_EQ(
gfx::Vector2dF(0.000000f, 17.699997f),
GetInputHandler().accumulated_root_overscroll_for_testing());
GetInputHandler().ScrollEnd();
// TestCase to check kEpsilon, which prevents minute values to trigger
// gloweffect without reaching edge.
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(
BeginState(gfx::Point(0, 0), gfx::Vector2dF(-0.12f, 0.1f),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
scroll_result = GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), gfx::Vector2dF(-0.12f, 0.1f),
ui::ScrollInputType::kWheel)
.get());
EXPECT_FALSE(scroll_result.did_scroll);
EXPECT_FALSE(scroll_result.did_overscroll_root);
EXPECT_EQ(gfx::Vector2dF(),
GetInputHandler().accumulated_root_overscroll_for_testing());
GetInputHandler().ScrollEnd();
}
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, NoOverscrollOnNonViewportLayers) {
const gfx::Size content_size(200, 200);
const gfx::Size viewport_size(100, 100);
SetupViewportLayersOuterScrolls(viewport_size, content_size);
LayerImpl* outer_scroll_layer = OuterViewportScrollLayer();
LayerImpl* content_layer = AddContentLayer();
// Initialization: Add a nested scrolling layer, simulating a scrolling div.
LayerImpl* scroll_layer =
AddScrollableLayer(content_layer, content_size, gfx::Size(400, 400));
InputHandlerScrollResult scroll_result;
DrawFrame();
// Start a scroll gesture, ensure it's scrolling the subscroller.
{
GetInputHandler().ScrollBegin(
BeginState(gfx::Point(0, 0), gfx::Vector2dF(100, 100),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(0, 0), gfx::Vector2dF(100, 100),
ui::ScrollInputType::kTouchscreen)
.get());
EXPECT_POINTF_EQ(gfx::PointF(100, 100), CurrentScrollOffset(scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(0, 0),
CurrentScrollOffset(outer_scroll_layer));
}
// Continue the scroll. Ensure that scrolling beyond the child's extent
// doesn't consume the delta but it isn't counted as overscroll.
{
InputHandlerScrollResult result = GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(0, 0), gfx::Vector2dF(120, 140),
ui::ScrollInputType::kTouchscreen)
.get());
EXPECT_POINTF_EQ(gfx::PointF(200, 200), CurrentScrollOffset(scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(0, 0),
CurrentScrollOffset(outer_scroll_layer));
EXPECT_FALSE(result.did_overscroll_root);
}
// Continue the scroll. Ensure that scrolling beyond the child's extent
// doesn't consume the delta but it isn't counted as overscroll.
{
InputHandlerScrollResult result = GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(0, 0), gfx::Vector2dF(20, 40),
ui::ScrollInputType::kTouchscreen)
.get());
EXPECT_POINTF_EQ(gfx::PointF(200, 200), CurrentScrollOffset(scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(0, 0),
CurrentScrollOffset(outer_scroll_layer));
EXPECT_FALSE(result.did_overscroll_root);
}
GetInputHandler().ScrollEnd();
}
// This ensures that the --disable-threaded-scrolling flag is respected even
// when a scroll occurs outside of a layer which normally falls back to the
// inner viewport layer. https://crbug.com/625100.
TEST_P(ScrollUnifiedLayerTreeHostImplTest, OverscrollOnMainThread) {
// TODO(bokan): The meaning of this flag is lost with scroll unification. We
// need to decide what we should do with it. https://crbug.com/1086625.
if (base::FeatureList::IsEnabled(features::kScrollUnification))
return;
InputHandlerScrollResult scroll_result;
LayerTreeSettings settings = DefaultSettings();
CreateHostImpl(settings, CreateLayerTreeFrameSink());
const gfx::Size viewport_size(50, 50);
SetupViewportLayersNoScrolls(viewport_size);
GetScrollNode(InnerViewportScrollLayer())->main_thread_scrolling_reasons =
MainThreadScrollingReason::kThreadedScrollingDisabled;
GetScrollNode(OuterViewportScrollLayer())->main_thread_scrolling_reasons =
MainThreadScrollingReason::kThreadedScrollingDisabled;
DrawFrame();
// Overscroll initiated outside layers will be handled by the main thread.
EXPECT_EQ(nullptr, host_impl_->active_tree()->FindLayerThatIsHitByPoint(
gfx::PointF(0, 60)));
EXPECT_EQ(
ScrollThread::SCROLL_ON_MAIN_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(0, 60), gfx::Vector2dF(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
// Overscroll initiated inside layers will be handled by the main thread.
EXPECT_NE(nullptr, host_impl_->active_tree()->FindLayerThatIsHitByPoint(
gfx::PointF(0, 0)));
EXPECT_EQ(ScrollThread::SCROLL_ON_MAIN_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(0, 0), gfx::Vector2dF(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
}
// Test that scrolling the inner viewport directly works, as can happen when the
// scroll chains up to it from an sibling of the outer viewport.
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollFromOuterViewportSibling) {
const gfx::Size viewport_size(100, 100);
SetupViewportLayersNoScrolls(viewport_size);
host_impl_->active_tree()->SetBrowserControlsParams(
{10, 0, 0, 0, false, false});
host_impl_->active_tree()->SetCurrentBrowserControlsShownRatio(1.f, 1.f);
LayerImpl* outer_scroll_layer = OuterViewportScrollLayer();
LayerImpl* inner_scroll_layer = InnerViewportScrollLayer();
// Create a scrolling layer that's parented directly to the inner viewport.
// This will test that scrolls that chain up to the inner viewport without
// passing through the outer viewport still scroll correctly and affect
// browser controls.
LayerImpl* scroll_layer = AddScrollableLayer(
inner_scroll_layer, viewport_size, gfx::Size(400, 400));
float min_page_scale = 1, max_page_scale = 4;
float page_scale_factor = 2;
host_impl_->active_tree()->PushPageScaleFromMainThread(
page_scale_factor, min_page_scale, max_page_scale);
host_impl_->active_tree()->SetPageScaleOnActiveTree(page_scale_factor);
// Fully scroll the child.
{
GetInputHandler().ScrollBegin(
BeginState(gfx::Point(0, 0), gfx::Vector2dF(1000, 1000),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(0, 0), gfx::Vector2dF(1000, 1000),
ui::ScrollInputType::kTouchscreen)
.get());
GetInputHandler().ScrollEnd();
EXPECT_EQ(1, host_impl_->active_tree()->CurrentTopControlsShownRatio());
EXPECT_POINTF_EQ(gfx::PointF(300, 300), CurrentScrollOffset(scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(0, 0),
CurrentScrollOffset(inner_scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(0, 0),
CurrentScrollOffset(outer_scroll_layer));
}
// Scrolling on the child now should chain up directly to the inner viewport.
// Scrolling it should cause browser controls to hide. The outer viewport
// should not be affected.
{
gfx::Vector2d scroll_delta(0, 10);
GetInputHandler().ScrollBegin(BeginState(gfx::Point(0, 0), scroll_delta,
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), scroll_delta,
ui::ScrollInputType::kTouchscreen)
.get());
EXPECT_EQ(0, host_impl_->active_tree()->CurrentTopControlsShownRatio());
EXPECT_POINTF_EQ(gfx::PointF(0, 0),
CurrentScrollOffset(inner_scroll_layer));
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), scroll_delta,
ui::ScrollInputType::kTouchscreen)
.get());
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), scroll_delta,
ui::ScrollInputType::kTouchscreen)
.get());
EXPECT_POINTF_EQ(gfx::PointF(0, 10),
CurrentScrollOffset(inner_scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(0, 0),
CurrentScrollOffset(outer_scroll_layer));
GetInputHandler().ScrollEnd();
}
}
// Test that scrolls chain correctly when a child scroller on the page (e.g. a
// scrolling div) is set as the outer viewport. This happens in the
// rootScroller proposal.
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
ScrollChainingWithReplacedOuterViewport) {
const gfx::Size content_size(200, 200);
const gfx::Size viewport_size(100, 100);
LayerTreeImpl* layer_tree_impl = host_impl_->active_tree();
SetupViewportLayersOuterScrolls(viewport_size, content_size);
LayerImpl* outer_scroll_layer = OuterViewportScrollLayer();
LayerImpl* inner_scroll_layer = InnerViewportScrollLayer();
LayerImpl* content_layer = AddContentLayer();
// Initialization: Add two nested scrolling layers, simulating a scrolling div
// with another scrolling div inside it. Set the outer "div" to be the outer
// viewport.
LayerImpl* scroll_layer =
AddScrollableLayer(content_layer, content_size, gfx::Size(400, 400));
GetScrollNode(scroll_layer)->scrolls_outer_viewport = true;
LayerImpl* child_scroll_layer = AddScrollableLayer(
scroll_layer, gfx::Size(300, 300), gfx::Size(500, 500));
auto viewport_property_ids = layer_tree_impl->ViewportPropertyIdsForTesting();
viewport_property_ids.outer_scroll = scroll_layer->scroll_tree_index();
layer_tree_impl->SetViewportPropertyIds(viewport_property_ids);
UpdateDrawProperties(layer_tree_impl);
// Scroll should target the nested scrolling layer in the content and then
// chain to the parent scrolling layer which is now set as the outer
// viewport. The original outer viewport layer shouldn't get any scroll here.
{
GetInputHandler().ScrollBegin(
BeginState(gfx::Point(0, 0), gfx::Vector2dF(200, 200),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(0, 0), gfx::Vector2dF(200, 200),
ui::ScrollInputType::kTouchscreen)
.get());
GetInputHandler().ScrollEnd();
EXPECT_POINTF_EQ(gfx::PointF(200, 200),
CurrentScrollOffset(child_scroll_layer));
GetInputHandler().ScrollBegin(
BeginState(gfx::Point(0, 0), gfx::Vector2dF(200, 200),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(0, 0), gfx::Vector2dF(200, 200),
ui::ScrollInputType::kTouchscreen)
.get());
GetInputHandler().ScrollEnd();
EXPECT_POINTF_EQ(gfx::PointF(0, 0),
CurrentScrollOffset(outer_scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(200, 200), CurrentScrollOffset(scroll_layer));
}
// Now that the nested scrolling layers are fully scrolled, further scrolls
// would normally chain up to the "outer viewport" but since we've set the
// scrolling content as the outer viewport, it should stop chaining there.
{
GetInputHandler().ScrollBegin(
BeginState(gfx::Point(0, 0), gfx::Vector2dF(100, 100),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(0, 0), gfx::Vector2dF(100, 100),
ui::ScrollInputType::kTouchscreen)
.get());
GetInputHandler().ScrollEnd();
EXPECT_POINTF_EQ(gfx::PointF(0, 0),
CurrentScrollOffset(outer_scroll_layer));
}
// Zoom into the page by a 2X factor so that the inner viewport becomes
// scrollable.
float min_page_scale = 1, max_page_scale = 4;
float page_scale_factor = 2;
host_impl_->active_tree()->PushPageScaleFromMainThread(
page_scale_factor, min_page_scale, max_page_scale);
host_impl_->active_tree()->SetPageScaleOnActiveTree(page_scale_factor);
// Reset the parent scrolling layer (i.e. the current outer viewport) so that
// we can ensure viewport scrolling works correctly.
scroll_layer->SetCurrentScrollOffset(gfx::PointF(0, 0));
// Scrolling the content layer should now scroll the inner viewport first,
// and then chain up to the current outer viewport (i.e. the parent scroll
// layer).
{
GetInputHandler().ScrollBegin(
BeginState(gfx::Point(0, 0), gfx::Vector2dF(100, 100),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(0, 0), gfx::Vector2dF(100, 100),
ui::ScrollInputType::kTouchscreen)
.get());
GetInputHandler().ScrollEnd();
EXPECT_POINTF_EQ(gfx::PointF(50, 50),
CurrentScrollOffset(inner_scroll_layer));
GetInputHandler().ScrollBegin(
BeginState(gfx::Point(0, 0), gfx::Vector2dF(100, 100),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(0, 0), gfx::Vector2dF(100, 100),
ui::ScrollInputType::kTouchscreen)
.get());
GetInputHandler().ScrollEnd();
EXPECT_POINTF_EQ(gfx::PointF(0, 0),
CurrentScrollOffset(outer_scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(50, 50), CurrentScrollOffset(scroll_layer));
}
}
// Test that scrolls chain correctly when a child scroller on the page (e.g. a
// scrolling div) is set as the outer viewport but scrolls start from a layer
// that's not a descendant of the outer viewport. This happens in the
// rootScroller proposal.
TEST_P(ScrollUnifiedLayerTreeHostImplTest, RootScrollerScrollNonDescendant) {
const gfx::Size content_size(300, 300);
const gfx::Size viewport_size(300, 300);
LayerTreeImpl* layer_tree_impl = host_impl_->active_tree();
SetupViewportLayersInnerScrolls(viewport_size, content_size);
LayerImpl* inner_scroll_layer = InnerViewportScrollLayer();
LayerImpl* content_layer = AddContentLayer();
// Initialization: Add a scrolling layer, simulating an ordinary DIV, to be
// set as the outer viewport. Add a sibling scrolling layer that isn't a child
// of the outer viewport scroll layer.
LayerImpl* outer_scroll_layer =
AddScrollableLayer(content_layer, content_size, gfx::Size(1200, 1200));
LayerImpl* sibling_scroll_layer = AddScrollableLayer(
content_layer, gfx::Size(600, 600), gfx::Size(1200, 1200));
GetScrollNode(InnerViewportScrollLayer())
->prevent_viewport_scrolling_from_inner = true;
GetScrollNode(OuterViewportScrollLayer())->scrolls_outer_viewport = false;
GetScrollNode(outer_scroll_layer)->scrolls_outer_viewport = true;
auto viewport_property_ids = layer_tree_impl->ViewportPropertyIdsForTesting();
viewport_property_ids.outer_scroll = outer_scroll_layer->scroll_tree_index();
layer_tree_impl->SetViewportPropertyIds(viewport_property_ids);
ASSERT_EQ(outer_scroll_layer,
layer_tree_impl->OuterViewportScrollLayerForTesting());
// Scrolls should target the non-descendant scroller. Chaining should not
// propagate to the outer viewport scroll layer.
{
// This should fully scroll the layer.
GetInputHandler().ScrollBegin(
BeginState(gfx::Point(0, 0), gfx::Vector2dF(1000, 1000),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(0, 0), gfx::Vector2dF(1000, 1000),
ui::ScrollInputType::kTouchscreen)
.get());
GetInputHandler().ScrollEnd();
EXPECT_POINTF_EQ(gfx::PointF(600, 600),
CurrentScrollOffset(sibling_scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(0, 0),
CurrentScrollOffset(outer_scroll_layer));
// Scrolling now should chain up but, since the outer viewport is a sibling
// rather than an ancestor, we shouldn't chain to it.
GetInputHandler().ScrollBegin(
BeginState(gfx::Point(0, 0), gfx::Vector2dF(1000, 1000),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(0, 0), gfx::Vector2dF(1000, 1000),
ui::ScrollInputType::kTouchscreen)
.get());
GetInputHandler().ScrollEnd();
EXPECT_POINTF_EQ(gfx::PointF(600, 600),
CurrentScrollOffset(sibling_scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(0, 0),
CurrentScrollOffset(outer_scroll_layer));
}
float min_page_scale = 1, max_page_scale = 4;
float page_scale_factor = 1;
host_impl_->active_tree()->PushPageScaleFromMainThread(
page_scale_factor, min_page_scale, max_page_scale);
gfx::PointF viewport_bottom_right(viewport_size.width(),
viewport_size.height());
// Reset the scroll offset.
sibling_scroll_layer->SetCurrentScrollOffset(gfx::PointF());
// Now pinch-zoom in. Anchoring should cause scrolling only on the inner
// viewport layer.
{
// Pinch in to the middle of the screen. The inner viewport should scroll
// to keep the gesture anchored but not the outer or the sibling scroller.
page_scale_factor = 2;
gfx::Point anchor(viewport_size.width() / 2, viewport_size.height() / 2);
GetInputHandler().ScrollBegin(
BeginState(anchor, gfx::Vector2dF(), ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
GetInputHandler().PinchGestureBegin(anchor, ui::ScrollInputType::kWheel);
GetInputHandler().PinchGestureUpdate(page_scale_factor, anchor);
GetInputHandler().PinchGestureEnd(anchor);
EXPECT_POINTF_EQ(gfx::PointF(anchor.x() / 2, anchor.y() / 2),
CurrentScrollOffset(inner_scroll_layer));
GetInputHandler().ScrollUpdate(
UpdateState(anchor, viewport_bottom_right.OffsetFromOrigin(),
ui::ScrollInputType::kTouchscreen)
.get());
EXPECT_POINTF_EQ(
gfx::ScalePoint(viewport_bottom_right, 1 / page_scale_factor),
CurrentScrollOffset(inner_scroll_layer));
// TODO(bokan): This doesn't yet work but we'll probably want to fix this
// at some point.
// EXPECT_VECTOR2DF_EQ(
// gfx::Vector2dF(),
// CurrentScrollOffset(outer_scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(0, 0),
CurrentScrollOffset(sibling_scroll_layer));
GetInputHandler().ScrollEnd();
}
// Reset the scroll offsets
sibling_scroll_layer->SetCurrentScrollOffset(gfx::PointF());
inner_scroll_layer->SetCurrentScrollOffset(gfx::PointF());
outer_scroll_layer->SetCurrentScrollOffset(gfx::PointF());
// Scrolls over the sibling while pinched in should scroll the sibling first,
// but then chain up to the inner viewport so that the user can still pan
// around. The outer viewport should be unaffected.
{
// This should fully scroll the sibling but, because we latch to the
// scroller, it shouldn't chain up to the inner viewport yet.
GetInputHandler().ScrollBegin(
BeginState(gfx::Point(0, 0), gfx::Vector2dF(2000, 2000),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(0, 0), gfx::Vector2dF(2000, 2000),
ui::ScrollInputType::kTouchscreen)
.get());
GetInputHandler().ScrollEnd();
EXPECT_POINTF_EQ(gfx::PointF(600, 600),
CurrentScrollOffset(sibling_scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(0, 0),
CurrentScrollOffset(inner_scroll_layer));
// Scrolling now should chain up to the inner viewport.
GetInputHandler().ScrollBegin(
BeginState(gfx::Point(0, 0), gfx::Vector2dF(2000, 2000),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(0, 0), gfx::Vector2dF(2000, 2000),
ui::ScrollInputType::kTouchscreen)
.get());
GetInputHandler().ScrollEnd();
EXPECT_POINTF_EQ(ScalePoint(viewport_bottom_right, 1 / page_scale_factor),
CurrentScrollOffset(inner_scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(0, 0),
CurrentScrollOffset(outer_scroll_layer));
// No more scrolling should be possible.
GetInputHandler().ScrollBegin(
BeginState(gfx::Point(0, 0), gfx::Vector2dF(2000, 2000),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(0, 0), gfx::Vector2dF(2000, 2000),
ui::ScrollInputType::kTouchscreen)
.get());
GetInputHandler().ScrollEnd();
EXPECT_POINTF_EQ(gfx::PointF(0, 0),
CurrentScrollOffset(outer_scroll_layer));
}
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, OverscrollOnImplThread) {
InputHandlerScrollResult scroll_result;
LayerTreeSettings settings = DefaultSettings();
CreateHostImpl(settings, CreateLayerTreeFrameSink());
const gfx::Size content_size(50, 50);
SetupViewportLayersNoScrolls(content_size);
// By default, no main thread scrolling reasons should exist.
LayerImpl* scroll_layer = InnerViewportScrollLayer();
ScrollNode* scroll_node = GetScrollNode(scroll_layer);
EXPECT_EQ(MainThreadScrollingReason::kNotScrollingOnMain,
scroll_node->main_thread_scrolling_reasons);
DrawFrame();
// Overscroll initiated outside layers will be handled by the impl thread.
EXPECT_EQ(nullptr, host_impl_->active_tree()->FindLayerThatIsHitByPoint(
gfx::PointF(0, 60)));
EXPECT_EQ(
ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(0, 60), gfx::Vector2dF(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
GetInputHandler().ScrollEnd();
// Overscroll initiated inside layers will be handled by the impl thread.
EXPECT_NE(nullptr, host_impl_->active_tree()->FindLayerThatIsHitByPoint(
gfx::PointF(0, 0)));
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(0, 0), gfx::Vector2dF(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
}
class BlendStateCheckLayer : public LayerImpl {
public:
static std::unique_ptr<BlendStateCheckLayer> Create(
LayerTreeImpl* tree_impl,
int id,
viz::ClientResourceProvider* resource_provider) {
return base::WrapUnique(
new BlendStateCheckLayer(tree_impl, id, resource_provider));
}
BlendStateCheckLayer(LayerTreeImpl* tree_impl,
int id,
viz::ClientResourceProvider* resource_provider)
: LayerImpl(tree_impl, id),
resource_provider_(resource_provider),
blend_(false),
has_render_surface_(false),
comparison_layer_(nullptr),
quads_appended_(false),
quad_rect_(5, 5, 5, 5),
quad_visible_rect_(5, 5, 5, 5) {
resource_id_ = resource_provider_->ImportResource(
viz::TransferableResource::MakeSoftware(
viz::SharedBitmap::GenerateId(), gfx::Size(1, 1), viz::RGBA_8888),
base::DoNothing());
SetBounds(gfx::Size(10, 10));
SetDrawsContent(true);
}
void ReleaseResources() override {
resource_provider_->RemoveImportedResource(resource_id_);
}
void AppendQuads(viz::CompositorRenderPass* render_pass,
AppendQuadsData* append_quads_data) override {
quads_appended_ = true;
gfx::Rect opaque_rect;
if (contents_opaque())
opaque_rect = quad_rect_;
else
opaque_rect = opaque_content_rect_;
gfx::Rect visible_quad_rect = quad_visible_rect_;
bool needs_blending = !opaque_rect.Contains(visible_quad_rect);
viz::SharedQuadState* shared_quad_state =
render_pass->CreateAndAppendSharedQuadState();
PopulateSharedQuadState(shared_quad_state, contents_opaque());
auto* test_blending_draw_quad =
render_pass->CreateAndAppendDrawQuad<viz::TileDrawQuad>();
test_blending_draw_quad->SetNew(shared_quad_state, quad_rect_,
visible_quad_rect, needs_blending,
resource_id_, gfx::RectF(0, 0, 1, 1),
gfx::Size(1, 1), false, false, false);
EXPECT_EQ(blend_, test_blending_draw_quad->ShouldDrawWithBlending());
EXPECT_EQ(has_render_surface_,
GetRenderSurface(this) != GetRenderSurface(comparison_layer_));
}
void SetExpectation(bool blend,
bool has_render_surface,
LayerImpl* comparison_layer) {
blend_ = blend;
has_render_surface_ = has_render_surface;
comparison_layer_ = comparison_layer;
quads_appended_ = false;
}
bool quads_appended() const { return quads_appended_; }
void SetQuadRect(const gfx::Rect& rect) { quad_rect_ = rect; }
void SetQuadVisibleRect(const gfx::Rect& rect) { quad_visible_rect_ = rect; }
void SetOpaqueContentRect(const gfx::Rect& rect) {
opaque_content_rect_ = rect;
}
private:
raw_ptr<viz::ClientResourceProvider> resource_provider_;
bool blend_;
bool has_render_surface_;
raw_ptr<LayerImpl> comparison_layer_;
bool quads_appended_;
gfx::Rect quad_rect_;
gfx::Rect opaque_content_rect_;
gfx::Rect quad_visible_rect_;
viz::ResourceId resource_id_;
};
TEST_P(ScrollUnifiedLayerTreeHostImplTest, BlendingOffWhenDrawingOpaqueLayers) {
LayerImpl* root = SetupDefaultRootLayer(gfx::Size(10, 10));
root->SetDrawsContent(false);
auto* layer1 = AddLayer<BlendStateCheckLayer>(
host_impl_->active_tree(), host_impl_->resource_provider());
CopyProperties(root, layer1);
CreateTransformNode(layer1).post_translation = gfx::Vector2dF(2, 2);
CreateEffectNode(layer1);
// Opaque layer, drawn without blending.
layer1->SetContentsOpaque(true);
layer1->SetExpectation(false, false, root);
layer1->UnionUpdateRect(gfx::Rect(layer1->bounds()));
DrawFrame();
EXPECT_TRUE(layer1->quads_appended());
// Layer with translucent content and painting, so drawn with blending.
layer1->SetContentsOpaque(false);
layer1->SetExpectation(true, false, root);
layer1->UnionUpdateRect(gfx::Rect(layer1->bounds()));
DrawFrame();
EXPECT_TRUE(layer1->quads_appended());
// Layer with translucent opacity, drawn with blending.
layer1->SetContentsOpaque(true);
SetOpacity(layer1, 0.5f);
layer1->SetExpectation(true, false, root);
layer1->UnionUpdateRect(gfx::Rect(layer1->bounds()));
DrawFrame();
EXPECT_TRUE(layer1->quads_appended());
// Layer with translucent opacity and painting, drawn with blending.
layer1->SetContentsOpaque(true);
SetOpacity(layer1, 0.5f);
layer1->SetExpectation(true, false, root);
layer1->UnionUpdateRect(gfx::Rect(layer1->bounds()));
DrawFrame();
EXPECT_TRUE(layer1->quads_appended());
auto* layer2 = AddLayer<BlendStateCheckLayer>(
host_impl_->active_tree(), host_impl_->resource_provider());
CopyProperties(layer1, layer2);
CreateTransformNode(layer2).post_translation = gfx::Vector2dF(4, 4);
CreateEffectNode(layer2);
// 2 opaque layers, drawn without blending.
layer1->SetContentsOpaque(true);
SetOpacity(layer1, 1);
layer1->SetExpectation(false, false, root);
layer1->UnionUpdateRect(gfx::Rect(layer1->bounds()));
layer2->SetContentsOpaque(true);
SetOpacity(layer2, 1);
layer2->SetExpectation(false, false, root);
layer2->UnionUpdateRect(gfx::Rect(layer1->bounds()));
DrawFrame();
EXPECT_TRUE(layer1->quads_appended());
EXPECT_TRUE(layer2->quads_appended());
// Parent layer with translucent content, drawn with blending.
// Child layer with opaque content, drawn without blending.
layer1->SetContentsOpaque(false);
layer1->SetExpectation(true, false, root);
layer1->UnionUpdateRect(gfx::Rect(layer1->bounds()));
layer2->SetExpectation(false, false, root);
layer2->UnionUpdateRect(gfx::Rect(layer1->bounds()));
DrawFrame();
EXPECT_TRUE(layer1->quads_appended());
EXPECT_TRUE(layer2->quads_appended());
// Parent layer with translucent content but opaque painting, drawn without
// blending.
// Child layer with opaque content, drawn without blending.
layer1->SetContentsOpaque(true);
layer1->SetExpectation(false, false, root);
layer1->UnionUpdateRect(gfx::Rect(layer1->bounds()));
layer2->SetExpectation(false, false, root);
layer2->UnionUpdateRect(gfx::Rect(layer1->bounds()));
DrawFrame();
EXPECT_TRUE(layer1->quads_appended());
EXPECT_TRUE(layer2->quads_appended());
// Parent layer with translucent opacity and opaque content. Since it has a
// drawing child, it's drawn to a render surface which carries the opacity,
// so it's itself drawn without blending.
// Child layer with opaque content, drawn without blending (parent surface
// carries the inherited opacity).
layer1->SetContentsOpaque(true);
SetOpacity(layer1, 0.5f);
GetEffectNode(layer1)->render_surface_reason = RenderSurfaceReason::kTest;
layer1->SetExpectation(false, true, root);
layer1->UnionUpdateRect(gfx::Rect(layer1->bounds()));
layer2->SetExpectation(false, false, layer1);
layer2->UnionUpdateRect(gfx::Rect(layer1->bounds()));
DrawFrame();
EXPECT_TRUE(layer1->quads_appended());
EXPECT_TRUE(layer2->quads_appended());
GetEffectNode(layer1)->render_surface_reason = RenderSurfaceReason::kNone;
// Draw again, but with child non-opaque, to make sure
// layer1 not culled.
layer1->SetContentsOpaque(true);
SetOpacity(layer1, 1);
layer1->SetExpectation(false, false, root);
layer1->UnionUpdateRect(gfx::Rect(layer1->bounds()));
layer2->SetContentsOpaque(true);
SetOpacity(layer2, 0.5f);
layer2->SetExpectation(true, false, layer1);
layer2->UnionUpdateRect(gfx::Rect(layer1->bounds()));
DrawFrame();
EXPECT_TRUE(layer1->quads_appended());
EXPECT_TRUE(layer2->quads_appended());
// A second way of making the child non-opaque.
layer1->SetContentsOpaque(true);
SetOpacity(layer1, 1);
layer1->SetExpectation(false, false, root);
layer1->UnionUpdateRect(gfx::Rect(layer1->bounds()));
layer2->SetContentsOpaque(false);
SetOpacity(layer2, 1);
layer2->SetExpectation(true, false, root);
layer2->UnionUpdateRect(gfx::Rect(layer1->bounds()));
DrawFrame();
EXPECT_TRUE(layer1->quads_appended());
EXPECT_TRUE(layer2->quads_appended());
// And when the layer says its not opaque but is painted opaque, it is not
// blended.
layer1->SetContentsOpaque(true);
SetOpacity(layer1, 1);
layer1->SetExpectation(false, false, root);
layer1->UnionUpdateRect(gfx::Rect(layer1->bounds()));
layer2->SetContentsOpaque(true);
SetOpacity(layer2, 1);
layer2->SetExpectation(false, false, root);
layer2->UnionUpdateRect(gfx::Rect(layer1->bounds()));
DrawFrame();
EXPECT_TRUE(layer1->quads_appended());
EXPECT_TRUE(layer2->quads_appended());
// Layer with partially opaque contents, drawn with blending.
layer1->SetContentsOpaque(false);
layer1->SetQuadRect(gfx::Rect(5, 5, 5, 5));
layer1->SetQuadVisibleRect(gfx::Rect(5, 5, 5, 5));
layer1->SetOpaqueContentRect(gfx::Rect(5, 5, 2, 5));
layer1->SetExpectation(true, false, root);
layer1->UnionUpdateRect(gfx::Rect(layer1->bounds()));
DrawFrame();
EXPECT_TRUE(layer1->quads_appended());
// Layer with partially opaque contents partially culled, drawn with blending.
layer1->SetContentsOpaque(false);
layer1->SetQuadRect(gfx::Rect(5, 5, 5, 5));
layer1->SetQuadVisibleRect(gfx::Rect(5, 5, 5, 2));
layer1->SetOpaqueContentRect(gfx::Rect(5, 5, 2, 5));
layer1->SetExpectation(true, false, root);
layer1->UnionUpdateRect(gfx::Rect(layer1->bounds()));
DrawFrame();
EXPECT_TRUE(layer1->quads_appended());
// Layer with partially opaque contents culled, drawn with blending.
layer1->SetContentsOpaque(false);
layer1->SetQuadRect(gfx::Rect(5, 5, 5, 5));
layer1->SetQuadVisibleRect(gfx::Rect(7, 5, 3, 5));
layer1->SetOpaqueContentRect(gfx::Rect(5, 5, 2, 5));
layer1->SetExpectation(true, false, root);
layer1->UnionUpdateRect(gfx::Rect(layer1->bounds()));
DrawFrame();
EXPECT_TRUE(layer1->quads_appended());
// Layer with partially opaque contents and translucent contents culled, drawn
// without blending.
layer1->SetContentsOpaque(false);
layer1->SetQuadRect(gfx::Rect(5, 5, 5, 5));
layer1->SetQuadVisibleRect(gfx::Rect(5, 5, 2, 5));
layer1->SetOpaqueContentRect(gfx::Rect(5, 5, 2, 5));
layer1->SetExpectation(false, false, root);
layer1->UnionUpdateRect(gfx::Rect(layer1->bounds()));
DrawFrame();
EXPECT_TRUE(layer1->quads_appended());
}
static bool MayContainVideoBitSetOnFrameData(LayerTreeHostImpl* host_impl) {
host_impl->active_tree()->set_needs_update_draw_properties();
TestFrameData frame;
auto args = viz::CreateBeginFrameArgsForTesting(
BEGINFRAME_FROM_HERE, viz::BeginFrameArgs::kManualSourceId, 1,
base::TimeTicks() + base::Milliseconds(1));
host_impl->WillBeginImplFrame(args);
EXPECT_EQ(DRAW_SUCCESS, host_impl->PrepareToDraw(&frame));
host_impl->DrawLayers(&frame);
host_impl->DidDrawAllLayers(frame);
host_impl->DidFinishImplFrame(args);
return frame.may_contain_video;
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, MayContainVideo) {
gfx::Size big_size(1000, 1000);
auto* root =
SetupRootLayer<DidDrawCheckLayer>(host_impl_->active_tree(), big_size);
auto* video_layer = AddLayer<DidDrawCheckLayer>(host_impl_->active_tree());
video_layer->set_may_contain_video(true);
CopyProperties(root, video_layer);
UpdateDrawProperties(host_impl_->active_tree());
EXPECT_TRUE(MayContainVideoBitSetOnFrameData(host_impl_.get()));
// Test with the video layer occluded.
auto* large_layer = AddLayer<DidDrawCheckLayer>(host_impl_->active_tree());
large_layer->SetBounds(big_size);
large_layer->SetContentsOpaque(true);
CopyProperties(root, large_layer);
UpdateDrawProperties(host_impl_->active_tree());
EXPECT_FALSE(MayContainVideoBitSetOnFrameData(host_impl_.get()));
{
// Remove the large layer.
OwnedLayerImplList layers =
host_impl_->active_tree()->DetachLayersKeepingRootLayerForTesting();
ASSERT_EQ(video_layer, layers[1].get());
host_impl_->active_tree()->AddLayer(std::move(layers[1]));
}
UpdateDrawProperties(host_impl_->active_tree());
EXPECT_TRUE(MayContainVideoBitSetOnFrameData(host_impl_.get()));
// Move the video layer so it goes beyond the root.
video_layer->SetOffsetToTransformParent(gfx::Vector2dF(100, 100));
UpdateDrawProperties(host_impl_->active_tree());
EXPECT_FALSE(MayContainVideoBitSetOnFrameData(host_impl_.get()));
video_layer->SetOffsetToTransformParent(gfx::Vector2dF(0, 0));
video_layer->NoteLayerPropertyChanged();
UpdateDrawProperties(host_impl_->active_tree());
EXPECT_TRUE(MayContainVideoBitSetOnFrameData(host_impl_.get()));
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, MayThrottleIfUnusedFrames) {
// Make sure that the throttle bit gets set properly.
viz::CompositorFrameMetadata metadata;
// By default, throttling should be allowed.
metadata = host_impl_->MakeCompositorFrameMetadata();
EXPECT_TRUE(metadata.may_throttle_if_undrawn_frames);
// If requested, frames should request no throttling.
host_impl_->SetMayThrottleIfUndrawnFrames(false);
metadata = host_impl_->MakeCompositorFrameMetadata();
EXPECT_FALSE(metadata.may_throttle_if_undrawn_frames);
// Explicitly set it back to the default, for completeness.
host_impl_->SetMayThrottleIfUndrawnFrames(true);
metadata = host_impl_->MakeCompositorFrameMetadata();
EXPECT_TRUE(metadata.may_throttle_if_undrawn_frames);
}
class LayerTreeHostImplViewportCoveredTest : public LayerTreeHostImplTest {
protected:
LayerTreeHostImplViewportCoveredTest()
: gutter_quad_material_(viz::DrawQuad::Material::kSolidColor),
child_(nullptr),
did_activate_pending_tree_(false) {}
std::unique_ptr<LayerTreeFrameSink> CreateFakeLayerTreeFrameSink(
bool software) {
if (software)
return FakeLayerTreeFrameSink::CreateSoftware();
return FakeLayerTreeFrameSink::Create3d();
}
void SetupActiveTreeLayers() {
host_impl_->active_tree()->set_background_color(SkColors::kGray);
LayerImpl* root = SetupDefaultRootLayer(viewport_size_);
child_ = AddLayer<BlendStateCheckLayer>(host_impl_->active_tree(),
host_impl_->resource_provider());
child_->SetExpectation(false, false, root);
child_->SetContentsOpaque(true);
CopyProperties(root, child_);
UpdateDrawProperties(host_impl_->active_tree());
}
void SetLayerGeometry(const gfx::Rect& layer_rect) {
child_->SetBounds(layer_rect.size());
child_->SetQuadRect(gfx::Rect(layer_rect.size()));
child_->SetQuadVisibleRect(gfx::Rect(layer_rect.size()));
child_->SetOffsetToTransformParent(
gfx::Vector2dF(layer_rect.OffsetFromOrigin()));
}
// Expect no gutter rects.
void TestLayerCoversFullViewport() {
SetLayerGeometry(gfx::Rect(viewport_size_));
TestFrameData frame;
EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame));
ASSERT_EQ(1u, frame.render_passes.size());
EXPECT_EQ(0u, CountGutterQuads(frame.render_passes[0]->quad_list));
EXPECT_EQ(1u, frame.render_passes[0]->quad_list.size());
ValidateTextureDrawQuads(frame.render_passes[0]->quad_list);
VerifyQuadsExactlyCoverViewport(frame.render_passes[0]->quad_list);
host_impl_->DidDrawAllLayers(frame);
}
// Expect fullscreen gutter rect.
void SetUpEmptylayer() { SetLayerGeometry(gfx::Rect()); }
void VerifyEmptyLayerRenderPasses(
const viz::CompositorRenderPassList& render_passes) {
ASSERT_EQ(1u, render_passes.size());
EXPECT_EQ(1u, CountGutterQuads(render_passes[0]->quad_list));
EXPECT_EQ(1u, render_passes[0]->quad_list.size());
ValidateTextureDrawQuads(render_passes[0]->quad_list);
VerifyQuadsExactlyCoverViewport(render_passes[0]->quad_list);
}
void TestEmptyLayer() {
SetUpEmptylayer();
DrawFrame();
}
void TestEmptyLayerWithOnDraw() {
SetUpEmptylayer();
gfx::Transform identity;
gfx::Rect viewport(viewport_size_);
bool resourceless_software_draw = true;
host_impl_->OnDraw(identity, viewport, resourceless_software_draw, false);
VerifyEmptyLayerRenderPasses(last_on_draw_render_passes_);
}
// Expect four surrounding gutter rects.
void SetUpLayerInMiddleOfViewport() {
SetLayerGeometry(gfx::Rect(500, 500, 200, 200));
}
void VerifyLayerInMiddleOfViewport(
const viz::CompositorRenderPassList& render_passes) {
ASSERT_EQ(1u, render_passes.size());
EXPECT_EQ(4u, CountGutterQuads(render_passes[0]->quad_list));
EXPECT_EQ(5u, render_passes[0]->quad_list.size());
ValidateTextureDrawQuads(render_passes[0]->quad_list);
VerifyQuadsExactlyCoverViewport(render_passes[0]->quad_list);
}
void TestLayerInMiddleOfViewport() {
SetUpLayerInMiddleOfViewport();
DrawFrame();
}
void TestLayerInMiddleOfViewportWithOnDraw() {
SetUpLayerInMiddleOfViewport();
gfx::Transform identity;
gfx::Rect viewport(viewport_size_);
bool resourceless_software_draw = true;
host_impl_->OnDraw(identity, viewport, resourceless_software_draw, false);
VerifyLayerInMiddleOfViewport(last_on_draw_render_passes_);
}
// Expect no gutter rects.
void SetUpLayerIsLargerThanViewport() {
SetLayerGeometry(
gfx::Rect(viewport_size_.width() + 10, viewport_size_.height() + 10));
}
void VerifyLayerIsLargerThanViewport(
const viz::CompositorRenderPassList& render_passes) {
ASSERT_EQ(1u, render_passes.size());
EXPECT_EQ(0u, CountGutterQuads(render_passes[0]->quad_list));
EXPECT_EQ(1u, render_passes[0]->quad_list.size());
ValidateTextureDrawQuads(render_passes[0]->quad_list);
}
void TestLayerIsLargerThanViewport() {
SetUpLayerIsLargerThanViewport();
DrawFrame();
}
void TestLayerIsLargerThanViewportWithOnDraw() {
SetUpLayerIsLargerThanViewport();
gfx::Transform identity;
gfx::Rect viewport(viewport_size_);
bool resourceless_software_draw = true;
host_impl_->OnDraw(identity, viewport, resourceless_software_draw, false);
VerifyLayerIsLargerThanViewport(last_on_draw_render_passes_);
}
void DidActivateSyncTree() override {
LayerTreeHostImplTest::DidActivateSyncTree();
did_activate_pending_tree_ = true;
}
void set_gutter_quad_material(viz::DrawQuad::Material material) {
gutter_quad_material_ = material;
}
void set_gutter_texture_size(const gfx::Size& gutter_texture_size) {
gutter_texture_size_ = gutter_texture_size;
}
protected:
size_t CountGutterQuads(const viz::QuadList& quad_list) {
size_t num_gutter_quads = 0;
for (auto* quad : quad_list) {
num_gutter_quads += (quad->material == gutter_quad_material_) ? 1 : 0;
}
return num_gutter_quads;
}
void VerifyQuadsExactlyCoverViewport(const viz::QuadList& quad_list) {
VerifyQuadsExactlyCoverRect(quad_list,
gfx::Rect(DipSizeToPixelSize(viewport_size_)));
}
// Make sure that the texture coordinates match their expectations.
void ValidateTextureDrawQuads(const viz::QuadList& quad_list) {
for (auto* quad : quad_list) {
if (quad->material != viz::DrawQuad::Material::kTextureContent)
continue;
const viz::TextureDrawQuad* texture_quad =
viz::TextureDrawQuad::MaterialCast(quad);
gfx::SizeF gutter_texture_size_pixels =
gfx::ScaleSize(gfx::SizeF(gutter_texture_size_),
host_impl_->active_tree()->device_scale_factor());
EXPECT_EQ(texture_quad->uv_top_left.x(),
texture_quad->rect.x() / gutter_texture_size_pixels.width());
EXPECT_EQ(texture_quad->uv_top_left.y(),
texture_quad->rect.y() / gutter_texture_size_pixels.height());
EXPECT_EQ(
texture_quad->uv_bottom_right.x(),
texture_quad->rect.right() / gutter_texture_size_pixels.width());
EXPECT_EQ(
texture_quad->uv_bottom_right.y(),
texture_quad->rect.bottom() / gutter_texture_size_pixels.height());
}
}
viz::DrawQuad::Material gutter_quad_material_;
gfx::Size gutter_texture_size_;
gfx::Size viewport_size_;
raw_ptr<BlendStateCheckLayer> child_;
bool did_activate_pending_tree_;
};
TEST_F(LayerTreeHostImplViewportCoveredTest, ViewportCovered) {
viewport_size_ = gfx::Size(1000, 1000);
bool software = false;
CreateHostImpl(DefaultSettings(), CreateFakeLayerTreeFrameSink(software));
SetupActiveTreeLayers();
EXPECT_SCOPED(TestLayerCoversFullViewport());
EXPECT_SCOPED(TestEmptyLayer());
EXPECT_SCOPED(TestLayerInMiddleOfViewport());
EXPECT_SCOPED(TestLayerIsLargerThanViewport());
}
TEST_F(LayerTreeHostImplViewportCoveredTest, ViewportCoveredScaled) {
viewport_size_ = gfx::Size(1000, 1000);
bool software = false;
CreateHostImpl(DefaultSettings(), CreateFakeLayerTreeFrameSink(software));
host_impl_->active_tree()->SetDeviceScaleFactor(2);
SetupActiveTreeLayers();
EXPECT_SCOPED(TestLayerCoversFullViewport());
EXPECT_SCOPED(TestEmptyLayer());
EXPECT_SCOPED(TestLayerInMiddleOfViewport());
EXPECT_SCOPED(TestLayerIsLargerThanViewport());
}
TEST_F(LayerTreeHostImplViewportCoveredTest, ActiveTreeGrowViewportInvalid) {
viewport_size_ = gfx::Size(1000, 1000);
bool software = true;
CreateHostImpl(DefaultSettings(), CreateFakeLayerTreeFrameSink(software));
// Pending tree to force active_tree size invalid. Not used otherwise.
CreatePendingTree();
SetupActiveTreeLayers();
EXPECT_SCOPED(TestEmptyLayerWithOnDraw());
EXPECT_SCOPED(TestLayerInMiddleOfViewportWithOnDraw());
EXPECT_SCOPED(TestLayerIsLargerThanViewportWithOnDraw());
}
TEST_F(LayerTreeHostImplViewportCoveredTest, ActiveTreeShrinkViewportInvalid) {
viewport_size_ = gfx::Size(1000, 1000);
bool software = true;
CreateHostImpl(DefaultSettings(), CreateFakeLayerTreeFrameSink(software));
// Set larger viewport and activate it to active tree.
CreatePendingTree();
gfx::Size larger_viewport(viewport_size_.width() + 100,
viewport_size_.height() + 100);
host_impl_->active_tree()->SetDeviceViewportRect(
gfx::Rect(DipSizeToPixelSize(larger_viewport)));
host_impl_->ActivateSyncTree();
EXPECT_TRUE(did_activate_pending_tree_);
// Shrink pending tree viewport without activating.
CreatePendingTree();
host_impl_->active_tree()->SetDeviceViewportRect(
gfx::Rect(DipSizeToPixelSize(viewport_size_)));
SetupActiveTreeLayers();
EXPECT_SCOPED(TestEmptyLayerWithOnDraw());
EXPECT_SCOPED(TestLayerInMiddleOfViewportWithOnDraw());
EXPECT_SCOPED(TestLayerIsLargerThanViewportWithOnDraw());
}
class FakeDrawableLayerImpl : public LayerImpl {
public:
static std::unique_ptr<LayerImpl> Create(LayerTreeImpl* tree_impl, int id) {
return base::WrapUnique(new FakeDrawableLayerImpl(tree_impl, id));
}
protected:
FakeDrawableLayerImpl(LayerTreeImpl* tree_impl, int id)
: LayerImpl(tree_impl, id) {}
};
// Make sure damage tracking propagates all the way to the viz::CompositorFrame
// submitted to the LayerTreeFrameSink, where it should request to swap only
// the sub-buffer that is damaged.
TEST_P(ScrollUnifiedLayerTreeHostImplTest, PartialSwapReceivesDamageRect) {
auto gl_owned = std::make_unique<viz::TestGLES2Interface>();
scoped_refptr<viz::TestContextProvider> context_provider(
viz::TestContextProvider::Create(std::move(gl_owned)));
context_provider->BindToCurrentSequence();
std::unique_ptr<FakeLayerTreeFrameSink> layer_tree_frame_sink(
FakeLayerTreeFrameSink::Create3d(context_provider));
FakeLayerTreeFrameSink* fake_layer_tree_frame_sink =
layer_tree_frame_sink.get();
// This test creates its own LayerTreeHostImpl, so
// that we can force partial swap enabled.
LayerTreeSettings settings = DefaultSettings();
std::unique_ptr<LayerTreeHostImpl> layer_tree_host_impl =
LayerTreeHostImpl::Create(
settings, this, &task_runner_provider_, &stats_instrumentation_,
&task_graph_runner_,
AnimationHost::CreateForTesting(ThreadInstance::IMPL), nullptr, 0,
nullptr, nullptr);
layer_tree_host_impl->SetVisible(true);
layer_tree_host_impl->InitializeFrameSink(layer_tree_frame_sink.get());
LayerImpl* root = SetupRootLayer<LayerImpl>(
layer_tree_host_impl->active_tree(), gfx::Size(500, 500));
LayerImpl* child = AddLayer<LayerImpl>(layer_tree_host_impl->active_tree());
child->SetBounds(gfx::Size(14, 15));
child->SetDrawsContent(true);
CopyProperties(root, child);
child->SetOffsetToTransformParent(gfx::Vector2dF(12, 13));
layer_tree_host_impl->active_tree()->SetLocalSurfaceIdFromParent(
viz::LocalSurfaceId(1, base::UnguessableToken::Deserialize(2u, 3u)));
UpdateDrawProperties(layer_tree_host_impl->active_tree());
TestFrameData frame;
// First frame, the entire screen should get swapped.
auto args = viz::CreateBeginFrameArgsForTesting(
BEGINFRAME_FROM_HERE, viz::BeginFrameArgs::kManualSourceId, 1,
base::TimeTicks() + base::Milliseconds(1));
layer_tree_host_impl->WillBeginImplFrame(args);
EXPECT_EQ(DRAW_SUCCESS, layer_tree_host_impl->PrepareToDraw(&frame));
layer_tree_host_impl->DrawLayers(&frame);
layer_tree_host_impl->DidDrawAllLayers(frame);
layer_tree_host_impl->DidFinishImplFrame(args);
gfx::Rect expected_swap_rect(500, 500);
EXPECT_EQ(expected_swap_rect, fake_layer_tree_frame_sink->last_swap_rect());
// Second frame, only the damaged area should get swapped. Damage should be
// the union of old and new child rects: gfx::Rect(26, 28).
child->SetOffsetToTransformParent(gfx::Vector2dF());
child->NoteLayerPropertyChanged();
args = viz::CreateBeginFrameArgsForTesting(
BEGINFRAME_FROM_HERE, viz::BeginFrameArgs::kManualSourceId, 1,
base::TimeTicks() + base::Milliseconds(1));
layer_tree_host_impl->WillBeginImplFrame(args);
EXPECT_EQ(DRAW_SUCCESS, layer_tree_host_impl->PrepareToDraw(&frame));
layer_tree_host_impl->DrawLayers(&frame);
layer_tree_host_impl->DidDrawAllLayers(frame);
layer_tree_host_impl->DidFinishImplFrame(args);
expected_swap_rect = gfx::Rect(26, 28);
EXPECT_EQ(expected_swap_rect, fake_layer_tree_frame_sink->last_swap_rect());
layer_tree_host_impl->active_tree()->SetDeviceViewportRect(gfx::Rect(10, 10));
// This will damage everything.
root->SetBackgroundColor(SkColors::kBlack);
args = viz::CreateBeginFrameArgsForTesting(
BEGINFRAME_FROM_HERE, viz::BeginFrameArgs::kManualSourceId, 1,
base::TimeTicks() + base::Milliseconds(1));
layer_tree_host_impl->WillBeginImplFrame(args);
EXPECT_EQ(DRAW_SUCCESS, layer_tree_host_impl->PrepareToDraw(&frame));
layer_tree_host_impl->DrawLayers(&frame);
layer_tree_host_impl->DidDrawAllLayers(frame);
layer_tree_host_impl->DidFinishImplFrame(args);
expected_swap_rect = gfx::Rect(10, 10);
EXPECT_EQ(expected_swap_rect, fake_layer_tree_frame_sink->last_swap_rect());
layer_tree_host_impl->ReleaseLayerTreeFrameSink();
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, RootLayerDoesntCreateExtraSurface) {
LayerImpl* root = SetupDefaultRootLayer(gfx::Size(10, 10));
LayerImpl* child = AddLayer();
child->SetBounds(gfx::Size(10, 10));
child->SetDrawsContent(true);
root->SetBounds(gfx::Size(10, 10));
root->SetDrawsContent(true);
CopyProperties(root, child);
UpdateDrawProperties(host_impl_->active_tree());
TestFrameData frame;
EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame));
EXPECT_EQ(1u, frame.render_surface_list->size());
EXPECT_EQ(1u, frame.render_passes.size());
host_impl_->DidDrawAllLayers(frame);
}
class FakeLayerWithQuads : public LayerImpl {
public:
static std::unique_ptr<LayerImpl> Create(LayerTreeImpl* tree_impl, int id) {
return base::WrapUnique(new FakeLayerWithQuads(tree_impl, id));
}
void AppendQuads(viz::CompositorRenderPass* render_pass,
AppendQuadsData* append_quads_data) override {
viz::SharedQuadState* shared_quad_state =
render_pass->CreateAndAppendSharedQuadState();
PopulateSharedQuadState(shared_quad_state, contents_opaque());
SkColor4f gray = SkColors::kGray;
gfx::Rect quad_rect(bounds());
gfx::Rect visible_quad_rect(quad_rect);
auto* my_quad =
render_pass->CreateAndAppendDrawQuad<viz::SolidColorDrawQuad>();
my_quad->SetNew(shared_quad_state, quad_rect, visible_quad_rect, gray,
false);
}
private:
FakeLayerWithQuads(LayerTreeImpl* tree_impl, int id)
: LayerImpl(tree_impl, id) {}
};
TEST_P(ScrollUnifiedLayerTreeHostImplTest, LayersFreeTextures) {
scoped_refptr<viz::TestContextProvider> context_provider =
viz::TestContextProvider::Create();
viz::TestSharedImageInterface* sii = context_provider->SharedImageInterface();
std::unique_ptr<LayerTreeFrameSink> layer_tree_frame_sink(
FakeLayerTreeFrameSink::Create3d(context_provider));
CreateHostImpl(DefaultSettings(), std::move(layer_tree_frame_sink));
LayerImpl* root_layer = SetupDefaultRootLayer(gfx::Size(10, 10));
scoped_refptr<VideoFrame> softwareFrame = media::VideoFrame::CreateColorFrame(
gfx::Size(4, 4), 0x80, 0x80, 0x80, base::TimeDelta());
FakeVideoFrameProvider provider;
provider.set_frame(softwareFrame);
auto* video_layer = AddLayer<VideoLayerImpl>(
host_impl_->active_tree(), &provider, media::VIDEO_ROTATION_0);
video_layer->SetBounds(gfx::Size(10, 10));
video_layer->SetDrawsContent(true);
CopyProperties(root_layer, video_layer);
UpdateDrawProperties(host_impl_->active_tree());
EXPECT_EQ(0u, sii->shared_image_count());
DrawFrame();
EXPECT_GT(sii->shared_image_count(), 0u);
// Kill the layer tree.
ClearLayersAndPropertyTrees(host_impl_->active_tree());
// There should be no textures left in use after.
EXPECT_EQ(0u, sii->shared_image_count());
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, HasTransparentBackground) {
SetupDefaultRootLayer(gfx::Size(10, 10));
host_impl_->active_tree()->set_background_color(SkColors::kWhite);
UpdateDrawProperties(host_impl_->active_tree());
// Verify one quad is drawn when transparent background set is not set.
TestFrameData frame;
auto args = viz::CreateBeginFrameArgsForTesting(
BEGINFRAME_FROM_HERE, viz::BeginFrameArgs::kManualSourceId, 1,
base::TimeTicks() + base::Milliseconds(1));
host_impl_->WillBeginImplFrame(args);
EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame));
{
const auto& root_pass = frame.render_passes.back();
ASSERT_EQ(1u, root_pass->quad_list.size());
EXPECT_EQ(viz::DrawQuad::Material::kSolidColor,
root_pass->quad_list.front()->material);
}
host_impl_->DrawLayers(&frame);
host_impl_->DidDrawAllLayers(frame);
host_impl_->DidFinishImplFrame(args);
// Cause damage so we would draw something if possible.
host_impl_->SetFullViewportDamage();
// Verify no quads are drawn when transparent background is set.
host_impl_->active_tree()->set_background_color(SkColors::kTransparent);
host_impl_->SetFullViewportDamage();
args = viz::CreateBeginFrameArgsForTesting(
BEGINFRAME_FROM_HERE, viz::BeginFrameArgs::kManualSourceId, 1,
base::TimeTicks() + base::Milliseconds(1));
host_impl_->WillBeginImplFrame(args);
EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame));
{
const auto& root_pass = frame.render_passes.back();
ASSERT_EQ(0u, root_pass->quad_list.size());
}
host_impl_->DrawLayers(&frame);
host_impl_->DidDrawAllLayers(frame);
host_impl_->DidFinishImplFrame(args);
// Cause damage so we would draw something if possible.
host_impl_->SetFullViewportDamage();
// Verify no quads are drawn when semi-transparent background is set.
host_impl_->active_tree()->set_background_color({1.0f, 0.0f, 0.0f, 0.1f});
host_impl_->SetFullViewportDamage();
host_impl_->WillBeginImplFrame(viz::CreateBeginFrameArgsForTesting(
BEGINFRAME_FROM_HERE, viz::BeginFrameArgs::kManualSourceId, 1,
base::TimeTicks() + base::Milliseconds(1)));
EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame));
{
const auto& root_pass = frame.render_passes.back();
ASSERT_EQ(0u, root_pass->quad_list.size());
}
host_impl_->DrawLayers(&frame);
host_impl_->DidDrawAllLayers(frame);
host_impl_->DidFinishImplFrame(args);
}
class LayerTreeHostImplTestDrawAndTestDamage : public LayerTreeHostImplTest {
protected:
std::unique_ptr<LayerTreeFrameSink> CreateLayerTreeFrameSink() override {
return FakeLayerTreeFrameSink::Create3d();
}
void DrawFrameAndTestDamage(const gfx::Rect& expected_damage,
const LayerImpl* child) {
bool expect_to_draw = !expected_damage.IsEmpty();
TestFrameData frame;
auto args = viz::CreateBeginFrameArgsForTesting(
BEGINFRAME_FROM_HERE, viz::BeginFrameArgs::kManualSourceId, 1,
base::TimeTicks() + base::Milliseconds(1));
host_impl_->WillBeginImplFrame(args);
EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame));
if (!expect_to_draw) {
// With no damage, we don't draw, and no quads are created.
ASSERT_EQ(0u, frame.render_passes.size());
} else {
ASSERT_EQ(1u, frame.render_passes.size());
// Verify the damage rect for the root render pass.
const viz::CompositorRenderPass* root_render_pass =
frame.render_passes.back().get();
EXPECT_EQ(expected_damage, root_render_pass->damage_rect);
// Verify the root and child layers' quads are generated and not being
// culled.
ASSERT_EQ(2u, root_render_pass->quad_list.size());
gfx::Rect expected_child_visible_rect(child->bounds());
EXPECT_EQ(expected_child_visible_rect,
root_render_pass->quad_list.front()->visible_rect);
LayerImpl* root = root_layer();
gfx::Rect expected_root_visible_rect(root->bounds());
EXPECT_EQ(expected_root_visible_rect,
root_render_pass->quad_list.ElementAt(1)->visible_rect);
}
EXPECT_EQ(expect_to_draw, host_impl_->DrawLayers(&frame).has_value());
host_impl_->DidDrawAllLayers(frame);
host_impl_->DidFinishImplFrame(args);
}
};
TEST_F(LayerTreeHostImplTestDrawAndTestDamage, FrameIncludesDamageRect) {
auto* root = SetupRootLayer<SolidColorLayerImpl>(host_impl_->active_tree(),
gfx::Size(10, 10));
root->SetDrawsContent(true);
root->SetBackgroundColor(SkColors::kRed);
// Child layer is in the bottom right corner.
auto* child = AddLayer<SolidColorLayerImpl>(host_impl_->active_tree());
child->SetBounds(gfx::Size(1, 1));
child->SetDrawsContent(true);
child->SetBackgroundColor(SkColors::kRed);
CopyProperties(root, child);
child->SetOffsetToTransformParent(gfx::Vector2dF(9, 9));
UpdateDrawProperties(host_impl_->active_tree());
// Draw a frame. In the first frame, the entire viewport should be damaged.
gfx::Rect full_frame_damage(
host_impl_->active_tree()->GetDeviceViewport().size());
DrawFrameAndTestDamage(full_frame_damage, child);
// The second frame has damage that doesn't touch the child layer. Its quads
// should still be generated.
gfx::Rect small_damage = gfx::Rect(0, 0, 1, 1);
root->UnionUpdateRect(small_damage);
DrawFrameAndTestDamage(small_damage, child);
// The third frame should have no damage, so no quads should be generated.
gfx::Rect no_damage;
DrawFrameAndTestDamage(no_damage, child);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, FarAwayQuadsDontNeedAA) {
// Due to precision issues (especially on Android), sometimes far
// away quads can end up thinking they need AA.
float device_scale_factor = 4 / 3;
gfx::Size root_size(2000, 1000);
CreatePendingTree();
host_impl_->pending_tree()->SetDeviceScaleFactor(device_scale_factor);
host_impl_->pending_tree()->PushPageScaleFromMainThread(1, 1 / 16, 16);
auto* root = SetupRootLayer<LayerImpl>(host_impl_->pending_tree(), root_size);
root->SetNeedsPushProperties();
gfx::Size content_layer_bounds(100001, 100);
auto* scrolling_layer =
AddScrollableLayer(root, content_layer_bounds, gfx::Size());
scrolling_layer->SetNeedsPushProperties();
scoped_refptr<FakeRasterSource> raster_source(
FakeRasterSource::CreateFilled(content_layer_bounds));
auto* content_layer =
AddLayer<FakePictureLayerImpl>(host_impl_->pending_tree(), raster_source);
CopyProperties(scrolling_layer, content_layer);
content_layer->SetBounds(content_layer_bounds);
content_layer->SetDrawsContent(true);
content_layer->SetNeedsPushProperties();
UpdateDrawProperties(host_impl_->pending_tree());
gfx::PointF scroll_offset(100000, 0);
scrolling_layer->layer_tree_impl()
->property_trees()
->scroll_tree_mutable()
.UpdateScrollOffsetBaseForTesting(scrolling_layer->element_id(),
scroll_offset);
host_impl_->ActivateSyncTree();
UpdateDrawProperties(host_impl_->active_tree());
ASSERT_EQ(1u, host_impl_->active_tree()->GetRenderSurfaceList().size());
TestFrameData frame;
auto args = viz::CreateBeginFrameArgsForTesting(
BEGINFRAME_FROM_HERE, viz::BeginFrameArgs::kManualSourceId, 1,
base::TimeTicks() + base::Milliseconds(1));
host_impl_->WillBeginImplFrame(args);
EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame));
ASSERT_EQ(1u, frame.render_passes.size());
ASSERT_LE(1u, frame.render_passes[0]->quad_list.size());
const viz::DrawQuad* quad = frame.render_passes[0]->quad_list.front();
bool clipped = false;
MathUtil::MapQuad(
quad->shared_quad_state->quad_to_target_transform,
gfx::QuadF(gfx::RectF(quad->shared_quad_state->visible_quad_layer_rect)),
&clipped);
EXPECT_FALSE(clipped);
host_impl_->DrawLayers(&frame);
host_impl_->DidDrawAllLayers(frame);
host_impl_->DidFinishImplFrame(args);
}
class CompositorFrameMetadataTest : public LayerTreeHostImplTest {
public:
CompositorFrameMetadataTest() = default;
void DidReceiveCompositorFrameAckOnImplThread() override { acks_received_++; }
int acks_received_ = 0;
};
TEST_F(CompositorFrameMetadataTest, CompositorFrameAckCountsAsSwapComplete) {
SetupRootLayer<FakeLayerWithQuads>(host_impl_->active_tree(),
gfx::Size(10, 10));
UpdateDrawProperties(host_impl_->active_tree());
DrawFrame();
host_impl_->ReclaimResources(std::vector<viz::ReturnedResource>());
host_impl_->DidReceiveCompositorFrameAck();
EXPECT_EQ(acks_received_, 1);
}
class CountingSoftwareDevice : public viz::SoftwareOutputDevice {
public:
CountingSoftwareDevice() : frames_began_(0), frames_ended_(0) {}
SkCanvas* BeginPaint(const gfx::Rect& damage_rect) override {
++frames_began_;
return viz::SoftwareOutputDevice::BeginPaint(damage_rect);
}
void EndPaint() override {
viz::SoftwareOutputDevice::EndPaint();
++frames_ended_;
}
int frames_began_, frames_ended_;
};
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
ForcedDrawToSoftwareDeviceSkipsUnsupportedLayers) {
set_reduce_memory_result(false);
EXPECT_TRUE(CreateHostImpl(DefaultSettings(),
FakeLayerTreeFrameSink::CreateSoftware()));
const gfx::Transform external_transform;
const gfx::Rect external_viewport;
const bool resourceless_software_draw = true;
host_impl_->SetExternalTilePriorityConstraints(external_viewport,
external_transform);
// SolidColorLayerImpl will be drawn.
auto* root = SetupRootLayer<SolidColorLayerImpl>(host_impl_->active_tree(),
gfx::Size(10, 10));
root->SetDrawsContent(true);
// VideoLayerImpl will not be drawn.
FakeVideoFrameProvider provider;
LayerImpl* video_layer = AddLayer<VideoLayerImpl>(
host_impl_->active_tree(), &provider, media::VIDEO_ROTATION_0);
video_layer->SetBounds(gfx::Size(10, 10));
video_layer->SetDrawsContent(true);
CopyProperties(root, video_layer);
UpdateDrawProperties(host_impl_->active_tree());
host_impl_->OnDraw(external_transform, external_viewport,
resourceless_software_draw, false);
EXPECT_EQ(1u, last_on_draw_frame_->will_draw_layers.size());
EXPECT_EQ(host_impl_->active_tree()->root_layer(),
last_on_draw_frame_->will_draw_layers[0]);
}
// Checks that we use the memory limits provided.
TEST_P(ScrollUnifiedLayerTreeHostImplTest, MemoryLimits) {
host_impl_->ReleaseLayerTreeFrameSink();
host_impl_ = nullptr;
const size_t kGpuByteLimit = 1234321;
const size_t kGpuResourceLimit = 2345432;
const gpu::MemoryAllocation::PriorityCutoff kGpuCutoff =
gpu::MemoryAllocation::CUTOFF_ALLOW_EVERYTHING;
const TileMemoryLimitPolicy kGpuTileCutoff =
ManagedMemoryPolicy::PriorityCutoffToTileMemoryLimitPolicy(kGpuCutoff);
const TileMemoryLimitPolicy kNothingTileCutoff =
ManagedMemoryPolicy::PriorityCutoffToTileMemoryLimitPolicy(
gpu::MemoryAllocation::CUTOFF_ALLOW_NOTHING);
EXPECT_NE(kGpuTileCutoff, kNothingTileCutoff);
LayerTreeSettings settings = DefaultSettings();
settings.memory_policy =
ManagedMemoryPolicy(kGpuByteLimit, kGpuCutoff, kGpuResourceLimit);
host_impl_ = LayerTreeHostImpl::Create(
settings, this, &task_runner_provider_, &stats_instrumentation_,
&task_graph_runner_,
AnimationHost::CreateForTesting(ThreadInstance::IMPL), nullptr, 0,
nullptr, nullptr);
InputHandler::Create(static_cast<CompositorDelegateForInput&>(*host_impl_));
// Gpu compositing.
layer_tree_frame_sink_ = FakeLayerTreeFrameSink::Create3d();
host_impl_->SetVisible(true);
host_impl_->InitializeFrameSink(layer_tree_frame_sink_.get());
{
const auto& state = host_impl_->global_tile_state();
EXPECT_EQ(kGpuByteLimit, state.hard_memory_limit_in_bytes);
EXPECT_EQ(kGpuResourceLimit, state.num_resources_limit);
EXPECT_EQ(kGpuTileCutoff, state.memory_limit_policy);
}
// Not visible, drops to 0.
host_impl_->SetVisible(false);
{
const auto& state = host_impl_->global_tile_state();
EXPECT_EQ(0u, state.hard_memory_limit_in_bytes);
EXPECT_EQ(kGpuResourceLimit, state.num_resources_limit);
EXPECT_EQ(kNothingTileCutoff, state.memory_limit_policy);
}
// Visible, is the gpu limit again.
host_impl_->SetVisible(true);
{
const auto& state = host_impl_->global_tile_state();
EXPECT_EQ(kGpuByteLimit, state.hard_memory_limit_in_bytes);
EXPECT_EQ(kGpuResourceLimit, state.num_resources_limit);
}
// Software compositing.
host_impl_->ReleaseLayerTreeFrameSink();
layer_tree_frame_sink_ = FakeLayerTreeFrameSink::CreateSoftware();
host_impl_->InitializeFrameSink(layer_tree_frame_sink_.get());
{
const auto& state = host_impl_->global_tile_state();
EXPECT_EQ(kGpuByteLimit, state.hard_memory_limit_in_bytes);
EXPECT_EQ(kGpuResourceLimit, state.num_resources_limit);
EXPECT_EQ(kGpuTileCutoff, state.memory_limit_policy);
}
// Not visible, drops to 0.
host_impl_->SetVisible(false);
{
const auto& state = host_impl_->global_tile_state();
EXPECT_EQ(0u, state.hard_memory_limit_in_bytes);
EXPECT_EQ(kGpuResourceLimit, state.num_resources_limit);
EXPECT_EQ(kNothingTileCutoff, state.memory_limit_policy);
}
// Visible, is the software limit again.
host_impl_->SetVisible(true);
{
const auto& state = host_impl_->global_tile_state();
EXPECT_EQ(kGpuByteLimit, state.hard_memory_limit_in_bytes);
EXPECT_EQ(kGpuResourceLimit, state.num_resources_limit);
EXPECT_EQ(kGpuTileCutoff, state.memory_limit_policy);
}
}
namespace {
void ExpectFullDamageAndDraw(LayerTreeHostImpl* host_impl) {
gfx::Rect full_frame_damage(
host_impl->active_tree()->GetDeviceViewport().size());
TestFrameData frame;
auto args = viz::CreateBeginFrameArgsForTesting(
BEGINFRAME_FROM_HERE, viz::BeginFrameArgs::kManualSourceId, 1,
base::TimeTicks() + base::Milliseconds(1));
host_impl->WillBeginImplFrame(args);
EXPECT_EQ(DRAW_SUCCESS, host_impl->PrepareToDraw(&frame));
ASSERT_EQ(1u, frame.render_passes.size());
const viz::CompositorRenderPass* root_render_pass =
frame.render_passes.back().get();
EXPECT_EQ(full_frame_damage, root_render_pass->damage_rect);
EXPECT_TRUE(host_impl->DrawLayers(&frame));
host_impl->DidDrawAllLayers(frame);
host_impl->DidFinishImplFrame(args);
}
} // namespace
TEST_F(LayerTreeHostImplTestDrawAndTestDamage,
RequireHighResAndRedrawWhenVisible) {
ASSERT_TRUE(host_impl_->active_tree());
LayerImpl* root = SetupRootLayer<SolidColorLayerImpl>(
host_impl_->active_tree(), gfx::Size(10, 10));
root->SetBackgroundColor(SkColors::kRed);
UpdateDrawProperties(host_impl_->active_tree());
// RequiresHighResToDraw is set when new output surface is used.
EXPECT_TRUE(host_impl_->RequiresHighResToDraw());
// Expect full frame damage for first frame.
EXPECT_SCOPED(ExpectFullDamageAndDraw(host_impl_.get()));
host_impl_->ResetRequiresHighResToDraw();
host_impl_->SetVisible(false);
EXPECT_FALSE(host_impl_->RequiresHighResToDraw());
host_impl_->SetVisible(true);
EXPECT_TRUE(host_impl_->RequiresHighResToDraw());
host_impl_->SetVisible(false);
EXPECT_TRUE(host_impl_->RequiresHighResToDraw());
host_impl_->ResetRequiresHighResToDraw();
EXPECT_FALSE(host_impl_->RequiresHighResToDraw());
did_request_redraw_ = false;
host_impl_->SetVisible(true);
EXPECT_TRUE(host_impl_->RequiresHighResToDraw());
// Expect redraw and full frame damage when becoming visible.
EXPECT_TRUE(did_request_redraw_);
EXPECT_SCOPED(ExpectFullDamageAndDraw(host_impl_.get()));
}
class LayerTreeHostImplTestPrepareTiles : public LayerTreeHostImplTest {
public:
void SetUp() override {
fake_host_impl_ = new FakeLayerTreeHostImpl(
LayerTreeSettings(), &task_runner_provider_, &task_graph_runner_);
host_impl_.reset(fake_host_impl_);
layer_tree_frame_sink_ = CreateLayerTreeFrameSink();
host_impl_->SetVisible(true);
host_impl_->InitializeFrameSink(layer_tree_frame_sink_.get());
host_impl_->active_tree()->SetDeviceViewportRect(gfx::Rect(10, 10));
}
raw_ptr<FakeLayerTreeHostImpl> fake_host_impl_;
};
TEST_F(LayerTreeHostImplTestPrepareTiles, PrepareTilesWhenInvisible) {
EXPECT_TRUE(fake_host_impl_->prepare_tiles_needed());
host_impl_->SetVisible(false);
EXPECT_FALSE(fake_host_impl_->prepare_tiles_needed());
host_impl_->SetVisible(true);
EXPECT_TRUE(fake_host_impl_->prepare_tiles_needed());
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, UIResourceManagement) {
auto test_context_provider = viz::TestContextProvider::Create();
viz::TestSharedImageInterface* sii =
test_context_provider->SharedImageInterface();
CreateHostImpl(DefaultSettings(), FakeLayerTreeFrameSink::Create3d(
std::move(test_context_provider)));
EXPECT_EQ(0u, sii->shared_image_count());
UIResourceId ui_resource_id = 1;
bool is_opaque = false;
UIResourceBitmap bitmap(gfx::Size(1, 1), is_opaque);
host_impl_->CreateUIResource(ui_resource_id, bitmap);
EXPECT_EQ(1u, sii->shared_image_count());
viz::ResourceId id1 = host_impl_->ResourceIdForUIResource(ui_resource_id);
EXPECT_NE(viz::kInvalidResourceId, id1);
// Multiple requests with the same id is allowed. The previous texture is
// deleted.
host_impl_->CreateUIResource(ui_resource_id, bitmap);
EXPECT_EQ(1u, sii->shared_image_count());
viz::ResourceId id2 = host_impl_->ResourceIdForUIResource(ui_resource_id);
EXPECT_NE(viz::kInvalidResourceId, id2);
EXPECT_NE(id1, id2);
// Deleting invalid UIResourceId is allowed and does not change state.
host_impl_->DeleteUIResource(-1);
EXPECT_EQ(1u, sii->shared_image_count());
// Should return zero for invalid UIResourceId. Number of textures should
// not change.
EXPECT_EQ(viz::kInvalidResourceId, host_impl_->ResourceIdForUIResource(-1));
EXPECT_EQ(1u, sii->shared_image_count());
host_impl_->DeleteUIResource(ui_resource_id);
EXPECT_EQ(viz::kInvalidResourceId,
host_impl_->ResourceIdForUIResource(ui_resource_id));
EXPECT_EQ(0u, sii->shared_image_count());
// Should not change state for multiple deletion on one UIResourceId
host_impl_->DeleteUIResource(ui_resource_id);
EXPECT_EQ(0u, sii->shared_image_count());
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, CreateETC1UIResource) {
auto test_context_provider = viz::TestContextProvider::Create();
viz::TestSharedImageInterface* sii =
test_context_provider->SharedImageInterface();
CreateHostImpl(DefaultSettings(), FakeLayerTreeFrameSink::Create3d(
std::move(test_context_provider)));
EXPECT_EQ(0u, sii->shared_image_count());
gfx::Size size(4, 4);
// SkImageInfo has no support for ETC1. The |info| below contains the right
// total pixel size for the bitmap but not the right height and width. The
// correct width/height are passed directly to UIResourceBitmap.
SkImageInfo info =
SkImageInfo::Make(4, 2, kAlpha_8_SkColorType, kPremul_SkAlphaType);
sk_sp<SkPixelRef> pixel_ref(SkMallocPixelRef::MakeAllocate(info, 0));
pixel_ref->setImmutable();
UIResourceBitmap bitmap(std::move(pixel_ref), size);
UIResourceId ui_resource_id = 1;
host_impl_->CreateUIResource(ui_resource_id, bitmap);
EXPECT_EQ(1u, sii->shared_image_count());
viz::ResourceId id1 = host_impl_->ResourceIdForUIResource(ui_resource_id);
EXPECT_NE(viz::kInvalidResourceId, id1);
}
// This tests the case where hit testing only on scrollable layers returns a
// layer that's outside the scroll chain of the first hit test *any* layer. See
// LayerTreeHostImpl::IsInitialScrollHitTestReliable for details.
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollHitTestIsNotReliable) {
// If we ray cast a scroller that is not on the first layer's ancestor chain,
// we should return ScrollThread::SCROLL_ON_MAIN_THREAD.
gfx::Size viewport_size(50, 50);
gfx::Size content_size(100, 100);
SetupViewportLayersOuterScrolls(viewport_size, content_size);
LayerImpl* occluder_layer = AddLayer();
occluder_layer->SetDrawsContent(true);
occluder_layer->SetHitTestable(true);
occluder_layer->SetBounds(content_size);
// The parent of the occluder is *above* the scroller.
CopyProperties(root_layer(), occluder_layer);
occluder_layer->SetTransformTreeIndex(
host_impl_->active_tree()->PageScaleTransformNode()->id);
DrawFrame();
InputHandler::ScrollStatus status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(), gfx::Vector2dF(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
if (base::FeatureList::IsEnabled(features::kScrollUnification)) {
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
EXPECT_TRUE(status.needs_main_thread_hit_test);
} else {
EXPECT_EQ(ScrollThread::SCROLL_ON_MAIN_THREAD, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kFailedHitTest,
status.main_thread_scrolling_reasons);
}
}
// Similar but different case to above. See
// LayerTreeHostImpl::IsInitialScrollHitTestReliable for details.
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollHitTestAncestorMismatch) {
// If we ray cast a scroller this is on the first layer's ancestor chain, but
// is not the first scroller we encounter when walking up from the layer, we
// should also return ScrollThread::SCROLL_ON_MAIN_THREAD.
gfx::Size viewport_size(50, 50);
gfx::Size content_size(100, 100);
SetupViewportLayersOuterScrolls(viewport_size, content_size);
LayerImpl* scroll_layer = OuterViewportScrollLayer();
LayerImpl* child_scroll_clip = AddLayer();
CopyProperties(scroll_layer, child_scroll_clip);
LayerImpl* child_scroll =
AddScrollableLayer(child_scroll_clip, viewport_size, content_size);
child_scroll->SetOffsetToTransformParent(gfx::Vector2dF(10, 10));
LayerImpl* occluder_layer = AddLayer();
occluder_layer->SetDrawsContent(true);
occluder_layer->SetHitTestable(true);
occluder_layer->SetBounds(content_size);
CopyProperties(child_scroll, occluder_layer);
occluder_layer->SetOffsetToTransformParent(gfx::Vector2dF(-10, -10));
DrawFrame();
InputHandler::ScrollStatus status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(), gfx::Vector2dF(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
if (base::FeatureList::IsEnabled(features::kScrollUnification)) {
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
EXPECT_TRUE(status.needs_main_thread_hit_test);
} else {
EXPECT_EQ(ScrollThread::SCROLL_ON_MAIN_THREAD, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kFailedHitTest,
status.main_thread_scrolling_reasons);
}
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollInvisibleScroller) {
gfx::Size viewport_size(50, 50);
gfx::Size content_size(100, 100);
SetupViewportLayersInnerScrolls(viewport_size, content_size);
LayerImpl* scroll_layer = InnerViewportScrollLayer();
LayerImpl* child_scroll =
AddScrollableLayer(scroll_layer, viewport_size, content_size);
child_scroll->SetDrawsContent(false);
DrawFrame();
// We should have scrolled |child_scroll| even though it does not move
// any layer that is a drawn RSLL member.
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), gfx::Vector2dF(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
EXPECT_EQ(child_scroll->scroll_tree_index(),
host_impl_->CurrentlyScrollingNode()->id);
}
// Make sure LatencyInfo carried by LatencyInfoSwapPromise are passed
// in viz::CompositorFrameMetadata.
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
LatencyInfoPassedToCompositorFrameMetadata) {
LayerTreeSettings settings = DefaultSettings();
settings.commit_to_active_tree = false;
CreateHostImpl(settings, CreateLayerTreeFrameSink());
SetupRootLayer<SolidColorLayerImpl>(host_impl_->active_tree(),
gfx::Size(10, 10));
UpdateDrawProperties(host_impl_->active_tree());
auto* fake_layer_tree_frame_sink =
static_cast<FakeLayerTreeFrameSink*>(host_impl_->layer_tree_frame_sink());
ui::LatencyInfo latency_info;
latency_info.set_trace_id(5);
latency_info.AddLatencyNumber(ui::INPUT_EVENT_LATENCY_BEGIN_RWH_COMPONENT);
std::unique_ptr<SwapPromise> swap_promise(
new LatencyInfoSwapPromise(latency_info));
host_impl_->active_tree()->QueuePinnedSwapPromise(std::move(swap_promise));
host_impl_->SetFullViewportDamage();
host_impl_->SetNeedsRedraw();
DrawFrame();
const auto& metadata_latency_after =
fake_layer_tree_frame_sink->last_sent_frame()->metadata.latency_info;
EXPECT_EQ(1u, metadata_latency_after.size());
EXPECT_TRUE(metadata_latency_after[0].FindLatency(
ui::INPUT_EVENT_LATENCY_BEGIN_RWH_COMPONENT, nullptr));
}
#if BUILDFLAG(IS_ANDROID)
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
SelectionBoundsPassedToCompositorFrameMetadata) {
LayerImpl* root = SetupRootLayer<SolidColorLayerImpl>(
host_impl_->active_tree(), gfx::Size(10, 10));
UpdateDrawProperties(host_impl_->active_tree());
// Plumb the layer-local selection bounds.
gfx::Point selection_start(5, 0);
gfx::Point selection_end(5, 5);
LayerSelection selection;
selection.start.type = gfx::SelectionBound::CENTER;
selection.start.layer_id = root->id();
selection.start.edge_end = selection_end;
selection.start.edge_start = selection_start;
selection.end = selection.start;
host_impl_->active_tree()->RegisterSelection(selection);
host_impl_->SetNeedsRedraw();
RenderFrameMetadata metadata = StartDrawAndProduceRenderFrameMetadata();
// Ensure the selection bounds have propagated to the frame metadata.
const viz::Selection<gfx::SelectionBound>& selection_after =
metadata.selection;
EXPECT_EQ(selection.start.type, selection_after.start.type());
EXPECT_EQ(selection.end.type, selection_after.end.type());
EXPECT_EQ(gfx::PointF(selection_end), selection_after.start.edge_end());
EXPECT_EQ(gfx::PointF(selection_start), selection_after.start.edge_start());
EXPECT_TRUE(selection_after.start.visible());
EXPECT_TRUE(selection_after.end.visible());
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, HiddenSelectionBoundsStayHidden) {
LayerImpl* root = SetupDefaultRootLayer(gfx::Size(10, 10));
UpdateDrawProperties(host_impl_->active_tree());
// Plumb the layer-local selection bounds.
gfx::Point selection_start(5, 0);
gfx::Point selection_end(5, 5);
LayerSelection selection;
// Mark the start as hidden.
selection.start.hidden = true;
selection.start.type = gfx::SelectionBound::CENTER;
selection.start.layer_id = root->id();
selection.start.edge_end = selection_end;
selection.start.edge_start = selection_start;
selection.end = selection.start;
host_impl_->active_tree()->RegisterSelection(selection);
host_impl_->SetNeedsRedraw();
RenderFrameMetadata metadata = StartDrawAndProduceRenderFrameMetadata();
// Ensure the selection bounds have propagated to the frame metadata.
const viz::Selection<gfx::SelectionBound>& selection_after =
metadata.selection;
EXPECT_EQ(selection.start.type, selection_after.start.type());
EXPECT_EQ(selection.end.type, selection_after.end.type());
EXPECT_EQ(gfx::PointF(selection_end), selection_after.start.edge_end());
EXPECT_EQ(gfx::PointF(selection_start), selection_after.start.edge_start());
EXPECT_FALSE(selection_after.start.visible());
EXPECT_FALSE(selection_after.end.visible());
}
#endif // BUILDFLAG(IS_ANDROID)
TEST_P(ScrollUnifiedLayerTreeHostImplTest, SimpleSwapPromiseMonitor) {
{
StrictMock<MockLatencyInfoSwapPromiseMonitor> monitor(host_impl_.get());
EXPECT_CALL(monitor, OnSetNeedsCommitOnMain()).Times(0);
EXPECT_CALL(monitor, OnSetNeedsRedrawOnImpl()).Times(1);
host_impl_->SetNeedsRedraw();
}
{
StrictMock<MockLatencyInfoSwapPromiseMonitor> monitor(host_impl_.get());
EXPECT_CALL(monitor, OnSetNeedsCommitOnMain()).Times(0);
EXPECT_CALL(monitor, OnSetNeedsRedrawOnImpl()).Times(1);
// Redraw with damage.
host_impl_->SetFullViewportDamage();
host_impl_->SetNeedsRedraw();
}
{
StrictMock<MockLatencyInfoSwapPromiseMonitor> monitor(host_impl_.get());
EXPECT_CALL(monitor, OnSetNeedsCommitOnMain()).Times(0);
EXPECT_CALL(monitor, OnSetNeedsRedrawOnImpl()).Times(1);
// Redraw without damage.
host_impl_->SetNeedsRedraw();
}
{
StrictMock<MockLatencyInfoSwapPromiseMonitor> monitor(host_impl_.get());
EXPECT_CALL(monitor, OnSetNeedsCommitOnMain()).Times(0);
EXPECT_CALL(monitor, OnSetNeedsRedrawOnImpl()).Times(1);
SetupViewportLayersInnerScrolls(gfx::Size(50, 50), gfx::Size(100, 100));
// Scrolling normally should not trigger any forwarding.
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), gfx::Vector2dF(0, 10),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
EXPECT_TRUE(
GetInputHandler()
.ScrollUpdate(UpdateState(gfx::Point(), gfx::Vector2d(0, 10),
ui::ScrollInputType::kTouchscreen)
.get())
.did_scroll);
GetInputHandler().ScrollEnd();
EXPECT_TRUE(Mock::VerifyAndClearExpectations(&monitor));
EXPECT_CALL(monitor, OnSetNeedsCommitOnMain()).Times(0);
EXPECT_CALL(monitor, OnSetNeedsRedrawOnImpl()).Times(1);
// Scrolling with a scroll handler should defer the swap to the main
// thread.
host_impl_->active_tree()->set_have_scroll_event_handlers(true);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), gfx::Vector2dF(0, 10),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
EXPECT_TRUE(
GetInputHandler()
.ScrollUpdate(UpdateState(gfx::Point(), gfx::Vector2d(0, 10),
ui::ScrollInputType::kTouchscreen)
.get())
.did_scroll);
GetInputHandler().ScrollEnd();
}
}
class LayerTreeHostImplWithBrowserControlsTest : public LayerTreeHostImplTest {
public:
void SetUp() override {
LayerTreeSettings settings = DefaultSettings();
settings.commit_to_active_tree = false;
CreateHostImpl(settings, CreateLayerTreeFrameSink());
host_impl_->active_tree()->SetBrowserControlsParams(
{static_cast<float>(top_controls_height_), 0, 0, 0, false, false});
host_impl_->active_tree()->SetCurrentBrowserControlsShownRatio(1.f, 1.f);
}
protected:
void Scroll(float y) {
ASSERT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), gfx::Vector2dF(0, 50),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
ASSERT_TRUE(
GetInputHandler()
.ScrollUpdate(UpdateState(gfx::Point(), gfx::Vector2dF(0, y),
ui::ScrollInputType::kTouchscreen)
.get())
.did_scroll);
GetInputHandler().ScrollEnd();
}
void RunAnimation() {
viz::BeginFrameArgs begin_frame_args = viz::CreateBeginFrameArgsForTesting(
BEGINFRAME_FROM_HERE, 0, 1, base::TimeTicks::Now());
do {
did_request_next_frame_ = false;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
host_impl_->DidFinishImplFrame(begin_frame_args);
begin_frame_args.frame_time += base::Milliseconds(5);
begin_frame_args.frame_id.sequence_number++;
} while (did_request_next_frame_);
}
static const int top_controls_height_;
};
const int LayerTreeHostImplWithBrowserControlsTest::top_controls_height_ = 50;
TEST_F(LayerTreeHostImplWithBrowserControlsTest, NoIdleAnimations) {
SetupViewportLayersInnerScrolls(gfx::Size(50, 50), gfx::Size(100, 100));
auto* scroll_layer = InnerViewportScrollLayer();
scroll_layer->layer_tree_impl()
->property_trees()
->scroll_tree_mutable()
.UpdateScrollOffsetBaseForTesting(scroll_layer->element_id(),
gfx::PointF(0, 10));
viz::BeginFrameArgs begin_frame_args =
viz::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, 0, 2);
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
EXPECT_FALSE(did_request_redraw_);
host_impl_->DidFinishImplFrame(begin_frame_args);
}
TEST_F(LayerTreeHostImplWithBrowserControlsTest,
BrowserControlsHeightIsCommitted) {
SetupViewportLayersInnerScrolls(gfx::Size(50, 50), gfx::Size(100, 100));
EXPECT_FALSE(did_request_redraw_);
CreatePendingTree();
host_impl_->sync_tree()->SetBrowserControlsParams(
{100, 0, 0, 0, false, false});
host_impl_->ActivateSyncTree();
EXPECT_EQ(100, host_impl_->browser_controls_manager()->TopControlsHeight());
}
TEST_F(LayerTreeHostImplWithBrowserControlsTest,
BrowserControlsStayFullyVisibleOnHeightChange) {
SetupViewportLayersInnerScrolls(gfx::Size(50, 50), gfx::Size(100, 100));
EXPECT_EQ(0, host_impl_->browser_controls_manager()->ControlsTopOffset());
CreatePendingTree();
host_impl_->sync_tree()->SetBrowserControlsParams({0, 0, 0, 0, false, false});
host_impl_->ActivateSyncTree();
EXPECT_EQ(0, host_impl_->browser_controls_manager()->ControlsTopOffset());
CreatePendingTree();
host_impl_->sync_tree()->SetBrowserControlsParams(
{50, 0, 0, 0, false, false});
host_impl_->ActivateSyncTree();
EXPECT_EQ(0, host_impl_->browser_controls_manager()->ControlsTopOffset());
}
TEST_F(LayerTreeHostImplWithBrowserControlsTest,
BrowserControlsAnimationScheduling) {
SetupViewportLayersInnerScrolls(gfx::Size(50, 50), gfx::Size(100, 100));
auto* scroll_layer = InnerViewportScrollLayer();
scroll_layer->layer_tree_impl()
->property_trees()
->scroll_tree_mutable()
.UpdateScrollOffsetBaseForTesting(scroll_layer->element_id(),
gfx::PointF(0, 10));
host_impl_->DidChangeBrowserControlsPosition();
EXPECT_TRUE(did_request_next_frame_);
EXPECT_TRUE(did_request_redraw_);
}
TEST_F(LayerTreeHostImplWithBrowserControlsTest,
ScrollHandledByBrowserControls) {
InputHandlerScrollResult result;
SetupViewportLayersInnerScrolls(gfx::Size(50, 100), gfx::Size(100, 200));
auto* scroll_layer = InnerViewportScrollLayer();
UpdateDrawProperties(host_impl_->active_tree());
host_impl_->browser_controls_manager()->UpdateBrowserControlsState(
BrowserControlsState::kBoth, BrowserControlsState::kShown, false);
DrawFrame();
// First, scroll just the browser controls and verify that the scroll
// succeeds.
const float residue = 10;
float offset = top_controls_height_ - residue;
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), gfx::Vector2dF(0, offset),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
EXPECT_EQ(0, host_impl_->browser_controls_manager()->ControlsTopOffset());
EXPECT_EQ(gfx::PointF(), CurrentScrollOffset(scroll_layer));
result = GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), gfx::Vector2d(0, offset),
ui::ScrollInputType::kTouchscreen)
.get());
EXPECT_EQ(result.unused_scroll_delta, gfx::Vector2d(0, 0));
EXPECT_TRUE(result.did_scroll);
EXPECT_FLOAT_EQ(-offset,
host_impl_->browser_controls_manager()->ControlsTopOffset());
EXPECT_EQ(gfx::PointF(), CurrentScrollOffset(scroll_layer));
// Scroll across the boundary
const float content_scroll = 20;
offset = residue + content_scroll;
result = GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), gfx::Vector2d(0, offset),
ui::ScrollInputType::kTouchscreen)
.get());
EXPECT_TRUE(result.did_scroll);
EXPECT_EQ(result.unused_scroll_delta, gfx::Vector2d(0, 0));
EXPECT_EQ(-top_controls_height_,
host_impl_->browser_controls_manager()->ControlsTopOffset());
EXPECT_EQ(gfx::PointF(0, content_scroll), CurrentScrollOffset(scroll_layer));
// Now scroll back to the top of the content
offset = -content_scroll;
result = GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), gfx::Vector2d(0, offset),
ui::ScrollInputType::kTouchscreen)
.get());
EXPECT_TRUE(result.did_scroll);
EXPECT_EQ(result.unused_scroll_delta, gfx::Vector2d(0, 0));
EXPECT_EQ(-top_controls_height_,
host_impl_->browser_controls_manager()->ControlsTopOffset());
EXPECT_EQ(gfx::PointF(), CurrentScrollOffset(scroll_layer));
// And scroll the browser controls completely into view
offset = -top_controls_height_;
result = GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), gfx::Vector2d(0, offset),
ui::ScrollInputType::kTouchscreen)
.get());
EXPECT_TRUE(result.did_scroll);
EXPECT_EQ(result.unused_scroll_delta, gfx::Vector2d(0, 0));
EXPECT_EQ(0, host_impl_->browser_controls_manager()->ControlsTopOffset());
EXPECT_EQ(gfx::PointF(), CurrentScrollOffset(scroll_layer));
// And attempt to scroll past the end
result = GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), gfx::Vector2d(0, offset),
ui::ScrollInputType::kTouchscreen)
.get());
EXPECT_FALSE(result.did_scroll);
EXPECT_EQ(result.unused_scroll_delta, gfx::Vector2d(0, -50));
EXPECT_EQ(0, host_impl_->browser_controls_manager()->ControlsTopOffset());
EXPECT_EQ(gfx::PointF(), CurrentScrollOffset(scroll_layer));
GetInputHandler().ScrollEnd();
}
TEST_F(LayerTreeHostImplWithBrowserControlsTest,
WheelUnhandledByBrowserControls) {
SetupViewportLayersInnerScrolls(gfx::Size(50, 100), gfx::Size(100, 200));
host_impl_->active_tree()->SetBrowserControlsParams(
{top_controls_height_, 0, 0, 0, false, true});
host_impl_->browser_controls_manager()->UpdateBrowserControlsState(
BrowserControlsState::kBoth, BrowserControlsState::kShown, false);
DrawFrame();
LayerImpl* viewport_layer = InnerViewportScrollLayer();
const float delta = top_controls_height_;
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), gfx::Vector2dF(0, delta),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
EXPECT_EQ(0, host_impl_->browser_controls_manager()->ControlsTopOffset());
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(viewport_layer));
// Wheel scrolls should not affect the browser controls, and should pass
// directly through to the viewport.
EXPECT_TRUE(
GetInputHandler()
.ScrollUpdate(UpdateState(gfx::Point(), gfx::Vector2d(0, delta),
ui::ScrollInputType::kWheel)
.get())
.did_scroll);
EXPECT_FLOAT_EQ(0,
host_impl_->browser_controls_manager()->ControlsTopOffset());
EXPECT_POINTF_EQ(gfx::PointF(0, delta), CurrentScrollOffset(viewport_layer));
EXPECT_TRUE(
GetInputHandler()
.ScrollUpdate(UpdateState(gfx::Point(), gfx::Vector2d(0, delta),
ui::ScrollInputType::kWheel)
.get())
.did_scroll);
EXPECT_FLOAT_EQ(0,
host_impl_->browser_controls_manager()->ControlsTopOffset());
EXPECT_POINTF_EQ(gfx::PointF(0, delta * 2),
CurrentScrollOffset(viewport_layer));
}
TEST_F(LayerTreeHostImplWithBrowserControlsTest,
BrowserControlsAnimationAtOrigin) {
SetupViewportLayersInnerScrolls(gfx::Size(50, 100), gfx::Size(100, 200));
auto* scroll_layer = InnerViewportScrollLayer();
UpdateDrawProperties(host_impl_->active_tree());
host_impl_->browser_controls_manager()->UpdateBrowserControlsState(
BrowserControlsState::kBoth, BrowserControlsState::kShown, false);
DrawFrame();
const float residue = 35;
float offset = top_controls_height_ - residue;
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), gfx::Vector2dF(0, offset),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
EXPECT_EQ(0, host_impl_->browser_controls_manager()->ControlsTopOffset());
EXPECT_EQ(gfx::PointF(), CurrentScrollOffset(scroll_layer));
// Scroll the browser controls partially.
EXPECT_TRUE(
GetInputHandler()
.ScrollUpdate(UpdateState(gfx::Point(), gfx::Vector2d(0, offset),
ui::ScrollInputType::kTouchscreen)
.get())
.did_scroll);
EXPECT_FLOAT_EQ(-offset,
host_impl_->browser_controls_manager()->ControlsTopOffset());
EXPECT_EQ(gfx::PointF(), CurrentScrollOffset(scroll_layer));
did_request_redraw_ = false;
did_request_next_frame_ = false;
did_request_commit_ = false;
// End the scroll while the controls are still offset from their limit.
GetInputHandler().ScrollEnd();
ASSERT_TRUE(host_impl_->browser_controls_manager()->HasAnimation());
EXPECT_TRUE(did_request_next_frame_);
EXPECT_TRUE(did_request_redraw_);
EXPECT_TRUE(did_request_commit_);
// The browser controls should properly animate until finished, despite the
// scroll offset being at the origin.
viz::BeginFrameArgs begin_frame_args = viz::CreateBeginFrameArgsForTesting(
BEGINFRAME_FROM_HERE, 0, 1, base::TimeTicks::Now());
while (did_request_next_frame_) {
did_request_redraw_ = false;
did_request_next_frame_ = false;
did_request_commit_ = false;
float old_offset =
host_impl_->browser_controls_manager()->ControlsTopOffset();
begin_frame_args.frame_time += base::Milliseconds(5);
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
EXPECT_EQ(gfx::PointF(), CurrentScrollOffset(scroll_layer));
float new_offset =
host_impl_->browser_controls_manager()->ControlsTopOffset();
// No commit is needed as the controls are animating the content offset,
// not the scroll offset.
EXPECT_FALSE(did_request_commit_);
if (new_offset != old_offset)
EXPECT_TRUE(did_request_redraw_);
if (new_offset != 0) {
EXPECT_TRUE(host_impl_->browser_controls_manager()->HasAnimation());
EXPECT_TRUE(did_request_next_frame_);
}
host_impl_->DidFinishImplFrame(begin_frame_args);
}
EXPECT_FALSE(host_impl_->browser_controls_manager()->HasAnimation());
}
TEST_F(LayerTreeHostImplWithBrowserControlsTest,
BrowserControlsAnimationAfterScroll) {
SetupViewportLayersInnerScrolls(gfx::Size(50, 100), gfx::Size(100, 200));
auto* scroll_layer = InnerViewportScrollLayer();
UpdateDrawProperties(host_impl_->active_tree());
host_impl_->browser_controls_manager()->UpdateBrowserControlsState(
BrowserControlsState::kBoth, BrowserControlsState::kShown, false);
float initial_scroll_offset = 50;
scroll_layer->layer_tree_impl()
->property_trees()
->scroll_tree_mutable()
.UpdateScrollOffsetBaseForTesting(scroll_layer->element_id(),
gfx::PointF(0, initial_scroll_offset));
DrawFrame();
const float residue = 15;
float offset = top_controls_height_ - residue;
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), gfx::Vector2dF(0, offset),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
EXPECT_EQ(0, host_impl_->browser_controls_manager()->ControlsTopOffset());
EXPECT_EQ(gfx::PointF(0, initial_scroll_offset),
CurrentScrollOffset(scroll_layer));
// Scroll the browser controls partially.
EXPECT_TRUE(
GetInputHandler()
.ScrollUpdate(UpdateState(gfx::Point(), gfx::Vector2d(0, offset),
ui::ScrollInputType::kTouchscreen)
.get())
.did_scroll);
EXPECT_FLOAT_EQ(-offset,
host_impl_->browser_controls_manager()->ControlsTopOffset());
EXPECT_EQ(gfx::PointF(0, initial_scroll_offset),
CurrentScrollOffset(scroll_layer));
did_request_redraw_ = false;
did_request_next_frame_ = false;
did_request_commit_ = false;
// End the scroll while the controls are still offset from the limit.
GetInputHandler().ScrollEnd();
ASSERT_TRUE(host_impl_->browser_controls_manager()->HasAnimation());
EXPECT_TRUE(did_request_next_frame_);
EXPECT_TRUE(did_request_redraw_);
EXPECT_TRUE(did_request_commit_);
// Animate the browser controls to the limit.
viz::BeginFrameArgs begin_frame_args = viz::CreateBeginFrameArgsForTesting(
BEGINFRAME_FROM_HERE, 0, 1, base::TimeTicks::Now());
while (did_request_next_frame_) {
did_request_redraw_ = false;
did_request_next_frame_ = false;
did_request_commit_ = false;
float old_offset =
host_impl_->browser_controls_manager()->ControlsTopOffset();
begin_frame_args.frame_time += base::Milliseconds(5);
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
float new_offset =
host_impl_->browser_controls_manager()->ControlsTopOffset();
if (new_offset != old_offset) {
EXPECT_TRUE(did_request_redraw_);
EXPECT_TRUE(did_request_commit_);
}
host_impl_->DidFinishImplFrame(begin_frame_args);
}
EXPECT_FALSE(host_impl_->browser_controls_manager()->HasAnimation());
EXPECT_EQ(-top_controls_height_,
host_impl_->browser_controls_manager()->ControlsTopOffset());
}
TEST_F(LayerTreeHostImplWithBrowserControlsTest,
BrowserControlsScrollDeltaInOverScroll) {
// Verifies that the overscroll delta should not have accumulated in
// the browser controls if we do a hide and show without releasing finger.
SetupViewportLayersInnerScrolls(gfx::Size(50, 100), gfx::Size(100, 200));
auto* scroll_layer = InnerViewportScrollLayer();
UpdateDrawProperties(host_impl_->active_tree());
host_impl_->browser_controls_manager()->UpdateBrowserControlsState(
BrowserControlsState::kBoth, BrowserControlsState::kShown, false);
DrawFrame();
float offset = 50;
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), gfx::Vector2dF(0, offset),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
EXPECT_EQ(0, host_impl_->browser_controls_manager()->ControlsTopOffset());
EXPECT_TRUE(
GetInputHandler()
.ScrollUpdate(UpdateState(gfx::Point(), gfx::Vector2d(0, offset),
ui::ScrollInputType::kTouchscreen)
.get())
.did_scroll);
EXPECT_EQ(-offset,
host_impl_->browser_controls_manager()->ControlsTopOffset());
EXPECT_EQ(gfx::PointF(), CurrentScrollOffset(scroll_layer));
EXPECT_TRUE(
GetInputHandler()
.ScrollUpdate(UpdateState(gfx::Point(), gfx::Vector2d(0, offset),
ui::ScrollInputType::kTouchscreen)
.get())
.did_scroll);
EXPECT_EQ(gfx::PointF(0, offset), CurrentScrollOffset(scroll_layer));
EXPECT_TRUE(
GetInputHandler()
.ScrollUpdate(UpdateState(gfx::Point(), gfx::Vector2d(0, offset),
ui::ScrollInputType::kTouchscreen)
.get())
.did_scroll);
// Should have fully scrolled
EXPECT_EQ(gfx::PointF(0, MaxScrollOffset(scroll_layer).y()),
CurrentScrollOffset(scroll_layer));
float overscrollamount = 10;
// Overscroll the content
EXPECT_FALSE(GetInputHandler()
.ScrollUpdate(UpdateState(gfx::Point(),
gfx::Vector2d(0, overscrollamount),
ui::ScrollInputType::kTouchscreen)
.get())
.did_scroll);
EXPECT_EQ(gfx::PointF(0, 2 * offset), CurrentScrollOffset(scroll_layer));
EXPECT_EQ(gfx::Vector2dF(0, overscrollamount),
GetInputHandler().accumulated_root_overscroll_for_testing());
EXPECT_TRUE(
GetInputHandler()
.ScrollUpdate(UpdateState(gfx::Point(), gfx::Vector2d(0, -2 * offset),
ui::ScrollInputType::kTouchscreen)
.get())
.did_scroll);
EXPECT_EQ(gfx::PointF(0, 0), CurrentScrollOffset(scroll_layer));
EXPECT_EQ(-offset,
host_impl_->browser_controls_manager()->ControlsTopOffset());
EXPECT_TRUE(
GetInputHandler()
.ScrollUpdate(UpdateState(gfx::Point(), gfx::Vector2d(0, -offset),
ui::ScrollInputType::kTouchscreen)
.get())
.did_scroll);
EXPECT_EQ(gfx::PointF(0, 0), CurrentScrollOffset(scroll_layer));
// Browser controls should be fully visible
EXPECT_EQ(0, host_impl_->browser_controls_manager()->ControlsTopOffset());
GetInputHandler().ScrollEnd();
}
// Tests that when animating the top controls down, the viewport doesn't counter
// scroll if it's not already scrolled.
TEST_F(LayerTreeHostImplWithBrowserControlsTest,
AnimationDoesntScrollUnscrolledViewport) {
// Initialize with 50px browser controls, 200px contents, and 100px viewport.
SetupViewportLayersInnerScrolls(gfx::Size(100, 100), gfx::Size(100, 200));
LayerTreeImpl* layer_tree_impl = host_impl_->active_tree();
ASSERT_EQ(1, layer_tree_impl->CurrentTopControlsShownRatio());
// Scroll down 10px, which should partially hide the browser controls, but
// not scroll the viewport.
Scroll(10.f);
EXPECT_EQ(0.8f, host_impl_->active_tree()->CurrentTopControlsShownRatio());
EXPECT_EQ(0.f, host_impl_->viewport().TotalScrollOffset().y());
// Let the top controls animate back down.
RunAnimation();
EXPECT_EQ(1, layer_tree_impl->CurrentTopControlsShownRatio());
EXPECT_EQ(0.f, host_impl_->viewport().TotalScrollOffset().y());
}
// Tests that when animating the top controls down, the viewport counter scrolls
// if it's partially scrolled down.
TEST_F(LayerTreeHostImplWithBrowserControlsTest,
AnimationScrollsScrolledViewport) {
// Initialize with 50px browser controls, 200px contents, and 100px viewport.
SetupViewportLayersInnerScrolls(gfx::Size(100, 100), gfx::Size(100, 200));
LayerTreeImpl* layer_tree_impl = host_impl_->active_tree();
ASSERT_EQ(1, layer_tree_impl->CurrentTopControlsShownRatio());
// Scroll down 60px, then up 40px, which should hide the browser controls and
// scroll the viewport 10px, then bring the browser controls down 40px.
Scroll(60.f);
EXPECT_EQ(0.f, host_impl_->active_tree()->CurrentTopControlsShownRatio());
EXPECT_EQ(10.f, host_impl_->viewport().TotalScrollOffset().y());
Scroll(-40.f);
EXPECT_EQ(0.8f, host_impl_->active_tree()->CurrentTopControlsShownRatio());
EXPECT_EQ(10.f, host_impl_->viewport().TotalScrollOffset().y());
// Let the top controls animate back down.
RunAnimation();
EXPECT_EQ(1, layer_tree_impl->CurrentTopControlsShownRatio());
EXPECT_EQ(20.f, host_impl_->viewport().TotalScrollOffset().y());
}
// Tests that the page animates down with the top controls when
// BrowserControlParams.only_expand_top_controls_at_page_top is true.
TEST_F(LayerTreeHostImplWithBrowserControlsTest,
AnimationScrollsViewportWhenOnlyExpandTopControlsAtPageTopIsSet) {
// Initialize with 50px browser controls, 200px page contents, a 100px
// viewport, and only_expand_top_controls_at_page_top enabled.
SetupViewportLayersInnerScrolls(gfx::Size(100, 100), gfx::Size(100, 200));
LayerTreeImpl* layer_tree_impl = host_impl_->active_tree();
layer_tree_impl->SetBrowserControlsParams(
{/*top_controls_height=*/50.f, 0.f, 0.f, 0.f, false, false,
/*only_expand_top_controls_at_page_top=*/true});
ASSERT_EQ(1, layer_tree_impl->CurrentTopControlsShownRatio());
// Scroll down 60px, then up 50px, which should hide the browser controls and
// scroll the viewport 10px, then unscroll the viewport and bring the browser
// controls down 40px.
Scroll(60.f);
EXPECT_EQ(0.f, host_impl_->active_tree()->CurrentTopControlsShownRatio());
EXPECT_EQ(10.f, host_impl_->viewport().TotalScrollOffset().y());
Scroll(-50.f);
EXPECT_EQ(0.8f, host_impl_->active_tree()->CurrentTopControlsShownRatio());
EXPECT_EQ(0.f, host_impl_->viewport().TotalScrollOffset().y());
// Let the top controls animate back down.
RunAnimation();
// With only_expand_top_controls_at_page_top set, the page shouldn't scroll.
EXPECT_EQ(1, layer_tree_impl->CurrentTopControlsShownRatio());
EXPECT_EQ(0.f, host_impl_->viewport().TotalScrollOffset().y());
}
// Tests that when we set a child scroller (e.g. a scrolling div) as the outer
// viewport, scrolling it controls the browser controls.
TEST_P(LayerTreeHostImplBrowserControlsTest,
ReplacedOuterViewportScrollsBrowserControls) {
const gfx::Size scroll_content_size(400, 400);
const gfx::Size root_layer_size(200, 200);
const gfx::Size viewport_size(100, 100);
SetupBrowserControlsAndScrollLayerWithVirtualViewport(
viewport_size, viewport_size, root_layer_size);
LayerTreeImpl* layer_tree_impl = host_impl_->active_tree();
LayerImpl* outer_scroll = OuterViewportScrollLayer();
// Initialization: Add a child scrolling layer to the outer scroll layer and
// set its scroll layer as the outer viewport. This simulates setting a
// scrolling element as the root scroller on the page.
LayerImpl* clip_layer = AddLayer();
clip_layer->SetBounds(root_layer_size);
CopyProperties(outer_scroll, clip_layer);
CreateClipNode(clip_layer);
LayerImpl* scroll_layer =
AddScrollableLayer(clip_layer, root_layer_size, scroll_content_size);
GetScrollNode(scroll_layer)->scrolls_outer_viewport = true;
auto viewport_property_ids = layer_tree_impl->ViewportPropertyIdsForTesting();
viewport_property_ids.outer_clip = clip_layer->clip_tree_index();
viewport_property_ids.outer_scroll = scroll_layer->scroll_tree_index();
layer_tree_impl->SetViewportPropertyIds(viewport_property_ids);
DrawFrame();
ASSERT_EQ(1, layer_tree_impl->CurrentTopControlsShownRatio());
// Scrolling should scroll the child content and the browser controls. The
// original outer viewport should get no scroll.
{
GetInputHandler().ScrollBegin(
BeginState(gfx::Point(0, 0), gfx::Vector2dF(100, 100),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(0, 0), gfx::Vector2dF(100, 100),
ui::ScrollInputType::kTouchscreen)
.get());
GetInputHandler().ScrollEnd();
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(outer_scroll));
EXPECT_POINTF_EQ(gfx::PointF(100, 50), CurrentScrollOffset(scroll_layer));
EXPECT_EQ(0, layer_tree_impl->CurrentTopControlsShownRatio());
}
}
using LayerTreeHostImplVirtualViewportTest = LayerTreeHostImplTest;
TEST_F(LayerTreeHostImplVirtualViewportTest, RootScrollBothInnerAndOuterLayer) {
gfx::Size content_size = gfx::Size(100, 160);
gfx::Size outer_viewport = gfx::Size(50, 80);
gfx::Size inner_viewport = gfx::Size(25, 40);
SetupViewportLayers(host_impl_->active_tree(), inner_viewport, outer_viewport,
content_size);
LayerImpl* outer_scroll = OuterViewportScrollLayer();
LayerImpl* inner_scroll = InnerViewportScrollLayer();
DrawFrame();
{
gfx::PointF inner_expected;
gfx::PointF outer_expected;
EXPECT_EQ(inner_expected, CurrentScrollOffset(inner_scroll));
EXPECT_EQ(outer_expected, CurrentScrollOffset(outer_scroll));
gfx::PointF current_offset(70, 100);
GetInputHandler().SetSynchronousInputHandlerRootScrollOffset(
current_offset);
EXPECT_EQ(gfx::PointF(25, 40), MaxScrollOffset(inner_scroll));
EXPECT_EQ(gfx::PointF(50, 80), MaxScrollOffset(outer_scroll));
// Inner viewport scrolls first. Then the rest is applied to the outer
// viewport.
EXPECT_EQ(gfx::PointF(25, 40), CurrentScrollOffset(inner_scroll));
EXPECT_EQ(gfx::PointF(45, 60), CurrentScrollOffset(outer_scroll));
}
}
TEST_F(LayerTreeHostImplVirtualViewportTest,
DiagonalScrollBubblesPerfectlyToInner) {
gfx::Size content_size = gfx::Size(200, 320);
gfx::Size outer_viewport = gfx::Size(100, 160);
gfx::Size inner_viewport = gfx::Size(50, 80);
SetupViewportLayers(host_impl_->active_tree(), inner_viewport, outer_viewport,
content_size);
LayerImpl* outer_scroll = OuterViewportScrollLayer();
LayerImpl* inner_scroll = InnerViewportScrollLayer();
DrawFrame();
{
gfx::PointF inner_expected;
gfx::PointF outer_expected;
EXPECT_POINTF_EQ(inner_expected, CurrentScrollOffset(inner_scroll));
EXPECT_POINTF_EQ(outer_expected, CurrentScrollOffset(outer_scroll));
gfx::Vector2dF scroll_delta(inner_viewport.width() / 2,
inner_viewport.height() / 2);
// Make sure the scroll goes to the inner viewport first.
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), scroll_delta,
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
// Scroll near the edge of the outer viewport.
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), scroll_delta,
ui::ScrollInputType::kTouchscreen)
.get());
inner_expected += scroll_delta;
EXPECT_POINTF_EQ(inner_expected, CurrentScrollOffset(inner_scroll));
EXPECT_POINTF_EQ(outer_expected, CurrentScrollOffset(outer_scroll));
// Now diagonal scroll across the outer viewport boundary in a single event.
// The entirety of the scroll should be consumed, as bubbling between inner
// and outer viewport layers is perfect.
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), gfx::ScaleVector2d(scroll_delta, 2),
ui::ScrollInputType::kTouchscreen)
.get());
outer_expected += scroll_delta;
inner_expected += scroll_delta;
GetInputHandler().ScrollEnd();
EXPECT_POINTF_EQ(inner_expected, CurrentScrollOffset(inner_scroll));
EXPECT_POINTF_EQ(outer_expected, CurrentScrollOffset(outer_scroll));
}
}
TEST_F(LayerTreeHostImplVirtualViewportTest,
ScrollBeginEventThatTargetsViewportLayerSkipsHitTest) {
gfx::Size content_size = gfx::Size(100, 160);
gfx::Size outer_viewport = gfx::Size(50, 80);
gfx::Size inner_viewport = gfx::Size(25, 40);
SetupViewportLayers(host_impl_->active_tree(), inner_viewport, outer_viewport,
content_size);
LayerImpl* outer_scroll = OuterViewportScrollLayer();
LayerImpl* child_scroll =
AddScrollableLayer(outer_scroll, inner_viewport, outer_viewport);
UpdateDrawProperties(host_impl_->active_tree());
DrawFrame();
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.RootScrollBegin(BeginState(gfx::Point(), gfx::Vector2dF(0, 10),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
EXPECT_EQ(host_impl_->CurrentlyScrollingNode(),
host_impl_->OuterViewportScrollNode());
GetInputHandler().ScrollEnd();
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), gfx::Vector2dF(0, 10),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
EXPECT_EQ(host_impl_->CurrentlyScrollingNode()->id,
child_scroll->scroll_tree_index());
GetInputHandler().ScrollEnd();
}
TEST_F(LayerTreeHostImplVirtualViewportTest,
NoOverscrollWhenInnerViewportCantScroll) {
InputHandlerScrollResult scroll_result;
gfx::Size content_size = gfx::Size(100, 160);
gfx::Size outer_viewport = gfx::Size(50, 80);
gfx::Size inner_viewport = gfx::Size(25, 40);
SetupViewportLayers(host_impl_->active_tree(), inner_viewport, outer_viewport,
content_size);
// Make inner viewport unscrollable.
LayerImpl* inner_scroll = InnerViewportScrollLayer();
GetScrollNode(inner_scroll)->user_scrollable_horizontal = false;
GetScrollNode(inner_scroll)->user_scrollable_vertical = false;
DrawFrame();
// Ensure inner viewport doesn't react to scrolls (test it's unscrollable).
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(inner_scroll));
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), gfx::Vector2dF(0, 100),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
scroll_result = GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), gfx::Vector2dF(0, 100),
ui::ScrollInputType::kTouchscreen)
.get());
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(inner_scroll));
// When inner viewport is unscrollable, a fling gives zero overscroll.
EXPECT_FALSE(scroll_result.did_overscroll_root);
EXPECT_EQ(gfx::Vector2dF(),
GetInputHandler().accumulated_root_overscroll_for_testing());
}
class LayerTreeHostImplWithImplicitLimitsTest : public LayerTreeHostImplTest {
public:
void SetUp() override {
LayerTreeSettings settings = DefaultSettings();
settings.max_memory_for_prepaint_percentage = 50;
CreateHostImpl(settings, CreateLayerTreeFrameSink());
}
};
TEST_F(LayerTreeHostImplWithImplicitLimitsTest, ImplicitMemoryLimits) {
// Set up a memory policy and percentages which could cause
// 32-bit integer overflows.
ManagedMemoryPolicy mem_policy(300 * 1024 * 1024); // 300MB
// Verify implicit limits are calculated correctly with no overflows
host_impl_->SetMemoryPolicy(mem_policy);
EXPECT_EQ(host_impl_->global_tile_state().hard_memory_limit_in_bytes,
300u * 1024u * 1024u);
EXPECT_EQ(host_impl_->global_tile_state().soft_memory_limit_in_bytes,
150u * 1024u * 1024u);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
ExternalTransformReflectedInNextDraw) {
const gfx::Size viewport_size(50, 50);
const gfx::Size layer_size(100, 100);
gfx::Transform external_transform;
const gfx::Rect external_viewport(layer_size);
const bool resourceless_software_draw = false;
SetupViewportLayersInnerScrolls(viewport_size, layer_size);
auto* layer = InnerViewportScrollLayer();
layer->SetDrawsContent(true);
host_impl_->SetExternalTilePriorityConstraints(external_viewport,
external_transform);
host_impl_->OnDraw(external_transform, external_viewport,
resourceless_software_draw, false);
EXPECT_TRANSFORM_EQ(external_transform,
layer->draw_properties().target_space_transform);
external_transform.Translate(20, 20);
host_impl_->SetExternalTilePriorityConstraints(external_viewport,
external_transform);
host_impl_->OnDraw(external_transform, external_viewport,
resourceless_software_draw, false);
EXPECT_TRANSFORM_EQ(external_transform,
layer->draw_properties().target_space_transform);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ExternalTransformSetNeedsRedraw) {
const gfx::Size viewport_size(100, 100);
SetupDefaultRootLayer(viewport_size);
UpdateDrawProperties(host_impl_->active_tree());
const gfx::Transform transform_for_tile_priority;
const gfx::Transform draw_transform;
const gfx::Rect viewport_for_tile_priority1(viewport_size);
const gfx::Rect viewport_for_tile_priority2(50, 50);
const gfx::Rect draw_viewport(viewport_size);
bool resourceless_software_draw = false;
// Clear any damage.
host_impl_->SetExternalTilePriorityConstraints(viewport_for_tile_priority1,
transform_for_tile_priority);
host_impl_->OnDraw(draw_transform, draw_viewport, resourceless_software_draw,
false);
last_on_draw_frame_.reset();
// Setting new constraints needs redraw.
did_request_redraw_ = false;
host_impl_->SetExternalTilePriorityConstraints(viewport_for_tile_priority2,
transform_for_tile_priority);
EXPECT_TRUE(did_request_redraw_);
host_impl_->OnDraw(draw_transform, draw_viewport, resourceless_software_draw,
false);
EXPECT_FALSE(last_on_draw_frame_->has_no_damage);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, OnMemoryPressure) {
gfx::Size size(200, 200);
viz::ResourceFormat format = viz::RGBA_8888;
gfx::ColorSpace color_space = gfx::ColorSpace::CreateSRGB();
ResourcePool::InUsePoolResource resource =
host_impl_->resource_pool()->AcquireResource(size, format, color_space);
size_t current_memory_usage =
host_impl_->resource_pool()->GetTotalMemoryUsageForTesting();
EXPECT_EQ(current_memory_usage, 0u);
resource.set_gpu_backing(std::make_unique<StubGpuBacking>());
host_impl_->resource_pool()->ReleaseResource(std::move(resource));
current_memory_usage =
host_impl_->resource_pool()->GetTotalMemoryUsageForTesting();
base::MemoryPressureListener::SimulatePressureNotification(
base::MemoryPressureListener::MEMORY_PRESSURE_LEVEL_CRITICAL);
base::RunLoop().RunUntilIdle();
size_t memory_usage_after_memory_pressure =
host_impl_->resource_pool()->GetTotalMemoryUsageForTesting();
// Memory usage after the memory pressure should be less than previous one.
EXPECT_LT(memory_usage_after_memory_pressure, current_memory_usage);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, OnDrawConstraintSetNeedsRedraw) {
const gfx::Size viewport_size(100, 100);
SetupDefaultRootLayer(viewport_size);
UpdateDrawProperties(host_impl_->active_tree());
const gfx::Transform draw_transform;
const gfx::Rect draw_viewport1(viewport_size);
const gfx::Rect draw_viewport2(50, 50);
bool resourceless_software_draw = false;
// Clear any damage.
host_impl_->OnDraw(draw_transform, draw_viewport1, resourceless_software_draw,
false);
last_on_draw_frame_.reset();
// Same draw params does not swap.
did_request_redraw_ = false;
host_impl_->OnDraw(draw_transform, draw_viewport1, resourceless_software_draw,
false);
EXPECT_FALSE(did_request_redraw_);
EXPECT_TRUE(last_on_draw_frame_->has_no_damage);
last_on_draw_frame_.reset();
// Different draw params does swap.
did_request_redraw_ = false;
host_impl_->OnDraw(draw_transform, draw_viewport2, resourceless_software_draw,
false);
EXPECT_TRUE(did_request_redraw_);
EXPECT_FALSE(last_on_draw_frame_->has_no_damage);
}
// This test verifies that the viewport damage rect is the full viewport and not
// just part of the viewport in the presence of an external viewport.
TEST_P(ScrollUnifiedLayerTreeHostImplTest, FullViewportDamageAfterOnDraw) {
const gfx::Size viewport_size(100, 100);
SetupDefaultRootLayer(viewport_size);
UpdateDrawProperties(host_impl_->active_tree());
const gfx::Transform draw_transform;
const gfx::Rect draw_viewport(gfx::Point(5, 5), viewport_size);
bool resourceless_software_draw = false;
host_impl_->OnDraw(draw_transform, draw_viewport, resourceless_software_draw,
false);
EXPECT_EQ(draw_viewport, host_impl_->active_tree()->GetDeviceViewport());
host_impl_->SetFullViewportDamage();
EXPECT_EQ(host_impl_->active_tree()->internal_device_viewport(),
host_impl_->viewport_damage_rect_for_testing());
}
class ResourcelessSoftwareLayerTreeHostImplTest : public LayerTreeHostImplTest {
protected:
std::unique_ptr<LayerTreeFrameSink> CreateLayerTreeFrameSink() override {
return FakeLayerTreeFrameSink::Create3d();
}
};
TEST_F(ResourcelessSoftwareLayerTreeHostImplTest,
ResourcelessSoftwareSetNeedsRedraw) {
const gfx::Size viewport_size(100, 100);
SetupDefaultRootLayer(viewport_size);
UpdateDrawProperties(host_impl_->active_tree());
const gfx::Transform draw_transform;
const gfx::Rect draw_viewport(viewport_size);
bool resourceless_software_draw = false;
// Clear any damage.
host_impl_->OnDraw(draw_transform, draw_viewport, resourceless_software_draw,
false);
last_on_draw_frame_.reset();
// Always swap even if same draw params.
resourceless_software_draw = true;
host_impl_->OnDraw(draw_transform, draw_viewport, resourceless_software_draw,
false);
EXPECT_FALSE(last_on_draw_frame_->has_no_damage);
last_on_draw_frame_.reset();
// Next hardware draw has damage.
resourceless_software_draw = false;
host_impl_->OnDraw(draw_transform, draw_viewport, resourceless_software_draw,
false);
EXPECT_FALSE(last_on_draw_frame_->has_no_damage);
}
TEST_F(ResourcelessSoftwareLayerTreeHostImplTest,
ResourcelessSoftwareDrawSkipsUpdateTiles) {
const gfx::Size viewport_size(100, 100);
CreatePendingTree();
scoped_refptr<FakeRasterSource> raster_source(
FakeRasterSource::CreateFilled(viewport_size));
auto* root = SetupRootLayer<FakePictureLayerImpl>(
host_impl_->pending_tree(), viewport_size, raster_source);
root->SetBounds(viewport_size);
root->SetDrawsContent(true);
UpdateDrawProperties(host_impl_->pending_tree());
host_impl_->ActivateSyncTree();
const gfx::Transform draw_transform;
const gfx::Rect draw_viewport(viewport_size);
bool resourceless_software_draw = false;
// Regular draw causes UpdateTiles.
did_request_prepare_tiles_ = false;
host_impl_->OnDraw(draw_transform, draw_viewport, resourceless_software_draw,
false);
EXPECT_TRUE(did_request_prepare_tiles_);
host_impl_->PrepareTiles();
// Resourceless draw skips UpdateTiles.
const gfx::Rect new_draw_viewport(50, 50);
resourceless_software_draw = true;
did_request_prepare_tiles_ = false;
host_impl_->OnDraw(draw_transform, new_draw_viewport,
resourceless_software_draw, false);
EXPECT_FALSE(did_request_prepare_tiles_);
}
TEST_F(CommitToPendingTreeLayerTreeHostImplTest,
ExternalTileConstraintReflectedInPendingTree) {
EXPECT_FALSE(host_impl_->CommitToActiveTree());
const gfx::Size layer_size(100, 100);
// Set up active and pending tree.
CreatePendingTree();
SetupRootLayer<LayerImpl>(host_impl_->pending_tree(), layer_size);
UpdateDrawProperties(host_impl_->pending_tree());
host_impl_->pending_tree()->root_layer()->SetNeedsPushProperties();
host_impl_->ActivateSyncTree();
UpdateDrawProperties(host_impl_->active_tree());
CreatePendingTree();
UpdateDrawProperties(host_impl_->pending_tree());
UpdateDrawProperties(host_impl_->active_tree());
EXPECT_FALSE(host_impl_->pending_tree()->needs_update_draw_properties());
EXPECT_FALSE(host_impl_->active_tree()->needs_update_draw_properties());
// Update external constraints should set_needs_update_draw_properties on
// both trees.
gfx::Transform external_transform;
gfx::Rect external_viewport(10, 20);
host_impl_->SetExternalTilePriorityConstraints(external_viewport,
external_transform);
EXPECT_TRUE(host_impl_->pending_tree()->needs_update_draw_properties());
EXPECT_TRUE(host_impl_->active_tree()->needs_update_draw_properties());
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
ExternalViewportAffectsVisibleRects) {
const gfx::Size viewport_size(50, 50);
const gfx::Size layer_size(100, 100);
SetupViewportLayersInnerScrolls(viewport_size, layer_size);
LayerImpl* content_layer = AddContentLayer();
host_impl_->active_tree()->SetDeviceViewportRect(gfx::Rect(90, 90));
UpdateDrawProperties(host_impl_->active_tree());
EXPECT_EQ(gfx::Rect(90, 90), content_layer->visible_layer_rect());
gfx::Transform external_transform;
gfx::Rect external_viewport(10, 20);
bool resourceless_software_draw = false;
host_impl_->SetExternalTilePriorityConstraints(external_viewport,
external_transform);
host_impl_->OnDraw(external_transform, external_viewport,
resourceless_software_draw, false);
EXPECT_EQ(gfx::Rect(10, 20), content_layer->visible_layer_rect());
// Clear the external viewport.
external_viewport = gfx::Rect();
host_impl_->SetExternalTilePriorityConstraints(external_viewport,
external_transform);
host_impl_->OnDraw(external_transform, external_viewport,
resourceless_software_draw, false);
EXPECT_EQ(gfx::Rect(90, 90), content_layer->visible_layer_rect());
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
ExternalTransformAffectsVisibleRects) {
const gfx::Size viewport_size(50, 50);
const gfx::Size layer_size(100, 100);
SetupViewportLayersInnerScrolls(viewport_size, layer_size);
LayerImpl* content_layer = AddContentLayer();
host_impl_->active_tree()->SetDeviceViewportRect(gfx::Rect(50, 50));
UpdateDrawProperties(host_impl_->active_tree());
EXPECT_EQ(gfx::Rect(50, 50), content_layer->visible_layer_rect());
gfx::Transform external_transform;
external_transform.Translate(10, 10);
external_transform.Scale(2, 2);
gfx::Rect external_viewport;
bool resourceless_software_draw = false;
host_impl_->SetExternalTilePriorityConstraints(external_viewport,
external_transform);
// Visible rects should now be shifted and scaled because of the external
// transform.
host_impl_->OnDraw(external_transform, external_viewport,
resourceless_software_draw, false);
EXPECT_EQ(gfx::Rect(20, 20), content_layer->visible_layer_rect());
// Clear the external transform.
external_transform = gfx::Transform();
host_impl_->SetExternalTilePriorityConstraints(external_viewport,
external_transform);
host_impl_->OnDraw(external_transform, external_viewport,
resourceless_software_draw, false);
EXPECT_EQ(gfx::Rect(50, 50), content_layer->visible_layer_rect());
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
ExternalTransformAffectsSublayerScaleFactor) {
const gfx::Size viewport_size(50, 50);
const gfx::Size layer_size(100, 100);
SetupViewportLayersInnerScrolls(viewport_size, layer_size);
LayerImpl* test_layer = AddContentLayer();
gfx::Transform perspective_transform;
perspective_transform.ApplyPerspectiveDepth(2);
CreateTransformNode(test_layer).local = perspective_transform;
CreateEffectNode(test_layer).render_surface_reason =
RenderSurfaceReason::kTest;
host_impl_->active_tree()->SetDeviceViewportRect(gfx::Rect(50, 50));
UpdateDrawProperties(host_impl_->active_tree());
EffectNode* node = GetEffectNode(test_layer);
EXPECT_EQ(node->surface_contents_scale, gfx::Vector2dF(1, 1));
gfx::Transform external_transform;
external_transform.Translate(10, 10);
external_transform.Scale(2, 2);
gfx::Rect external_viewport;
bool resourceless_software_draw = false;
host_impl_->SetExternalTilePriorityConstraints(external_viewport,
external_transform);
// Transform node's sublayer scale should include the device transform scale.
host_impl_->OnDraw(external_transform, external_viewport,
resourceless_software_draw, false);
node = GetEffectNode(test_layer);
EXPECT_EQ(node->surface_contents_scale, gfx::Vector2dF(2, 2));
// Clear the external transform.
external_transform = gfx::Transform();
host_impl_->SetExternalTilePriorityConstraints(external_viewport,
external_transform);
host_impl_->OnDraw(external_transform, external_viewport,
resourceless_software_draw, false);
node = GetEffectNode(test_layer);
EXPECT_EQ(node->surface_contents_scale, gfx::Vector2dF(1, 1));
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, OneScrollForFirstScrollDelay) {
LayerTreeSettings settings = DefaultSettings();
settings.commit_to_active_tree = false;
CreateHostImpl(settings, CreateLayerTreeFrameSink());
SetupRootLayer<SolidColorLayerImpl>(host_impl_->active_tree(),
gfx::Size(10, 10));
UpdateDrawProperties(host_impl_->active_tree());
EXPECT_EQ(first_scroll_observed, 0);
// LatencyInfo for the first scroll.
ui::LatencyInfo latency_info;
latency_info.set_trace_id(5);
latency_info.AddLatencyNumber(
ui::INPUT_EVENT_LATENCY_SCROLL_UPDATE_ORIGINAL_COMPONENT);
std::unique_ptr<SwapPromise> swap_promise(
new LatencyInfoSwapPromise(latency_info));
host_impl_->active_tree()->QueuePinnedSwapPromise(std::move(swap_promise));
host_impl_->SetFullViewportDamage();
host_impl_->SetNeedsRedraw();
DrawFrame();
constexpr uint32_t frame_token_1 = 1;
viz::FrameTimingDetails mock_details;
mock_details.presentation_feedback = ExampleFeedback();
// When the LayerTreeHostImpl receives presentation feedback, the callback
// will be fired.
host_impl_->DidPresentCompositorFrame(frame_token_1, mock_details);
EXPECT_EQ(first_scroll_observed, 1);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, OtherInputsForFirstScrollDelay) {
LayerTreeSettings settings = DefaultSettings();
settings.commit_to_active_tree = false;
CreateHostImpl(settings, CreateLayerTreeFrameSink());
SetupRootLayer<SolidColorLayerImpl>(host_impl_->active_tree(),
gfx::Size(10, 10));
UpdateDrawProperties(host_impl_->active_tree());
EXPECT_EQ(first_scroll_observed, 0);
// LatencyInfo for the first input, which is not scroll.
ui::LatencyInfo latency_info;
latency_info.set_trace_id(5);
latency_info.AddLatencyNumber(ui::INPUT_EVENT_LATENCY_BEGIN_RWH_COMPONENT);
std::unique_ptr<SwapPromise> swap_promise(
new LatencyInfoSwapPromise(latency_info));
host_impl_->active_tree()->QueuePinnedSwapPromise(std::move(swap_promise));
host_impl_->SetFullViewportDamage();
host_impl_->SetNeedsRedraw();
DrawFrame();
constexpr uint32_t frame_token_1 = 1;
viz::FrameTimingDetails mock_details;
mock_details.presentation_feedback = ExampleFeedback();
// When the LayerTreeHostImpl receives presentation feedback, the callback
// will be fired.
host_impl_->DidPresentCompositorFrame(frame_token_1, mock_details);
EXPECT_EQ(first_scroll_observed, 0);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, MultipleScrollsForFirstScrollDelay) {
LayerTreeSettings settings = DefaultSettings();
settings.commit_to_active_tree = false;
CreateHostImpl(settings, CreateLayerTreeFrameSink());
SetupRootLayer<SolidColorLayerImpl>(host_impl_->active_tree(),
gfx::Size(10, 10));
UpdateDrawProperties(host_impl_->active_tree());
EXPECT_EQ(first_scroll_observed, 0);
// LatencyInfo for the first scroll.
ui::LatencyInfo latency_info;
latency_info.set_trace_id(5);
latency_info.AddLatencyNumber(
ui::INPUT_EVENT_LATENCY_SCROLL_UPDATE_ORIGINAL_COMPONENT);
std::unique_ptr<SwapPromise> swap_promise(
new LatencyInfoSwapPromise(latency_info));
host_impl_->active_tree()->QueuePinnedSwapPromise(std::move(swap_promise));
DrawFrame();
constexpr uint32_t frame_token_1 = 1;
viz::FrameTimingDetails mock_details;
mock_details.presentation_feedback = ExampleFeedback();
// When the LayerTreeHostImpl receives presentation feedback, the callback
// will be fired.
host_impl_->DidPresentCompositorFrame(frame_token_1, mock_details);
EXPECT_EQ(first_scroll_observed, 1);
// LatencyInfo for the second scroll.
ui::LatencyInfo latency_info2;
latency_info2.set_trace_id(6);
latency_info2.AddLatencyNumber(
ui::INPUT_EVENT_LATENCY_SCROLL_UPDATE_ORIGINAL_COMPONENT);
std::unique_ptr<SwapPromise> swap_promise2(
new LatencyInfoSwapPromise(latency_info2));
host_impl_->active_tree()->QueuePinnedSwapPromise(std::move(swap_promise2));
host_impl_->SetFullViewportDamage();
host_impl_->SetNeedsRedraw();
DrawFrame();
constexpr uint32_t frame_token_2 = 2;
viz::FrameTimingDetails mock_details2;
mock_details2.presentation_feedback = ExampleFeedback();
// When the LayerTreeHostImpl receives presentation feedback, the callback
// will be fired.
host_impl_->DidPresentCompositorFrame(frame_token_2, mock_details2);
EXPECT_EQ(first_scroll_observed, 1);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollAnimated) {
const gfx::Size content_size(1000, 1000);
const gfx::Size viewport_size(50, 100);
SetupViewportLayersOuterScrolls(viewport_size, content_size);
DrawFrame();
base::TimeTicks start_time = base::TimeTicks() + base::Milliseconds(100);
viz::BeginFrameArgs begin_frame_args =
viz::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, 0, 1);
{
// Creating the animation should set 'needs redraw'. This is required
// for LatencyInfo's to be propagated along with the CompositorFrame
StrictMock<MockLatencyInfoSwapPromiseMonitor> monitor(host_impl_.get());
EXPECT_CALL(monitor, OnSetNeedsCommitOnMain()).Times(0);
EXPECT_CALL(monitor, OnSetNeedsRedrawOnImpl()).Times(AtLeast(1));
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), gfx::Vector2d(0, 50),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
GetInputHandler().ScrollUpdate(
AnimatedUpdateState(gfx::Point(), gfx::Vector2d(0, 50)).get());
}
LayerImpl* scrolling_layer = OuterViewportScrollLayer();
EXPECT_EQ(scrolling_layer->scroll_tree_index(),
host_impl_->CurrentlyScrollingNode()->id);
begin_frame_args.frame_time = start_time;
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
host_impl_->UpdateAnimationState(true);
EXPECT_NE(gfx::PointF(), CurrentScrollOffset(scrolling_layer));
host_impl_->DidFinishImplFrame(begin_frame_args);
begin_frame_args.frame_time = start_time + base::Milliseconds(50);
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
host_impl_->UpdateAnimationState(true);
float y = CurrentScrollOffset(scrolling_layer).y();
EXPECT_TRUE(y > 1 && y < 49);
{
// Updating the animation should set 'needs redraw'. This is required
// for LatencyInfo's to be propagated along with the CompositorFrame
StrictMock<MockLatencyInfoSwapPromiseMonitor> monitor(host_impl_.get());
EXPECT_CALL(monitor, OnSetNeedsCommitOnMain()).Times(0);
EXPECT_CALL(monitor, OnSetNeedsRedrawOnImpl()).Times(1);
// Update target.
GetInputHandler().ScrollUpdate(
AnimatedUpdateState(gfx::Point(), gfx::Vector2d(0, 50)).get());
GetInputHandler().ScrollEnd();
}
host_impl_->DidFinishImplFrame(begin_frame_args);
begin_frame_args.frame_time = start_time + base::Milliseconds(200);
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
host_impl_->UpdateAnimationState(true);
y = CurrentScrollOffset(scrolling_layer).y();
EXPECT_TRUE(y > 50 && y < 100);
EXPECT_EQ(scrolling_layer->scroll_tree_index(),
host_impl_->CurrentlyScrollingNode()->id);
host_impl_->DidFinishImplFrame(begin_frame_args);
begin_frame_args.frame_time = start_time + base::Milliseconds(250);
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
host_impl_->UpdateAnimationState(true);
EXPECT_POINTF_EQ(gfx::PointF(0, 100), CurrentScrollOffset(scrolling_layer));
EXPECT_EQ(nullptr, host_impl_->CurrentlyScrollingNode());
host_impl_->DidFinishImplFrame(begin_frame_args);
}
// Tests latching behavior, in particular when a ScrollEnd is received but a
// new ScrollBegin is received before the animation from the previous gesture
// stream is finished.
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollAnimatedLatching) {
const gfx::Size content_size(1000, 1000);
const gfx::Size viewport_size(50, 100);
SetupViewportLayersOuterScrolls(viewport_size, content_size);
AddScrollableLayer(OuterViewportScrollLayer(), gfx::Size(10, 10),
gfx::Size(20, 20));
LayerImpl* outer_scroll = OuterViewportScrollLayer();
DrawFrame();
viz::BeginFrameArgs begin_frame_args =
viz::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, 0, 1);
// Start an animated scroll over the outer viewport.
{
gfx::Point position(40, 40);
auto begin_state =
BeginState(position, gfx::Vector2d(0, 50), ui::ScrollInputType::kWheel);
GetInputHandler().ScrollBegin(begin_state.get(),
ui::ScrollInputType::kWheel);
auto update_state = AnimatedUpdateState(position, gfx::Vector2d(0, 50));
GetInputHandler().ScrollUpdate(update_state.get());
EXPECT_EQ(outer_scroll->scroll_tree_index(),
host_impl_->CurrentlyScrollingNode()->id);
base::TimeTicks start_time = base::TimeTicks() + base::Milliseconds(100);
begin_frame_args.frame_time = start_time;
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
host_impl_->UpdateAnimationState(true);
host_impl_->DidFinishImplFrame(begin_frame_args);
EXPECT_NE(gfx::PointF(), CurrentScrollOffset(outer_scroll));
EXPECT_TRUE(GetImplAnimationHost()->ImplOnlyScrollAnimatingElement());
}
// End the scroll gesture. We should still be latched to the scroll layer
// since the animation is still in progress.
{
GetInputHandler().ScrollEnd();
EXPECT_TRUE(GetImplAnimationHost()->ImplOnlyScrollAnimatingElement());
EXPECT_EQ(outer_scroll->scroll_tree_index(),
host_impl_->CurrentlyScrollingNode()->id);
begin_frame_args.frame_time += base::Milliseconds(5);
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
host_impl_->UpdateAnimationState(true);
host_impl_->DidFinishImplFrame(begin_frame_args);
EXPECT_TRUE(GetImplAnimationHost()->ImplOnlyScrollAnimatingElement());
EXPECT_EQ(outer_scroll->scroll_tree_index(),
host_impl_->CurrentlyScrollingNode()->id);
}
// Start a new animated scroll. We should remain latched to the outer
// viewport, despite the fact this scroll began over the child scroller,
// because we don't clear the latch until the animation is finished.
{
gfx::Point position(10, 10);
auto begin_state =
BeginState(position, gfx::Vector2d(0, 50), ui::ScrollInputType::kWheel);
GetInputHandler().ScrollBegin(begin_state.get(),
ui::ScrollInputType::kWheel);
EXPECT_EQ(outer_scroll->scroll_tree_index(),
host_impl_->CurrentlyScrollingNode()->id);
}
// Run the animation to the end. Because we received a ScrollBegin, the
// deferred ScrollEnd from the first gesture should have been cleared. That
// is, we shouldn't clear the latch when the animation ends because we're
// currently in an active scroll gesture.
{
begin_frame_args.frame_time += base::Milliseconds(200);
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
host_impl_->UpdateAnimationState(true);
host_impl_->DidFinishImplFrame(begin_frame_args);
EXPECT_FALSE(GetImplAnimationHost()->ImplOnlyScrollAnimatingElement());
EXPECT_EQ(outer_scroll->scroll_tree_index(),
host_impl_->CurrentlyScrollingNode()->id);
}
// A ScrollEnd should now clear the latch.
{
GetInputHandler().ScrollEnd();
EXPECT_FALSE(host_impl_->CurrentlyScrollingNode());
}
}
// Test to ensure that animated scrolls correctly account for the page scale
// factor. That is, if you zoom into the page, a wheel scroll should scroll the
// content *less* than before so that it appears to move the same distance when
// zoomed in.
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollAnimatedWhileZoomed) {
const gfx::Size content_size(1000, 1000);
const gfx::Size viewport_size(50, 100);
SetupViewportLayersOuterScrolls(viewport_size, content_size);
LayerImpl* scrolling_layer = InnerViewportScrollLayer();
DrawFrame();
// Zoom in to 2X
{
float min_page_scale = 1, max_page_scale = 4;
float page_scale_factor = 2;
host_impl_->active_tree()->PushPageScaleFromMainThread(
page_scale_factor, min_page_scale, max_page_scale);
host_impl_->active_tree()->SetPageScaleOnActiveTree(page_scale_factor);
}
// Start an animated scroll then do another animated scroll immediately
// afterwards. This will ensure we test both the starting animation and
// animation update code.
{
EXPECT_EQ(
ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(10, 10), gfx::Vector2d(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
GetInputHandler().ScrollUpdate(
AnimatedUpdateState(gfx::Point(10, 10), gfx::Vector2d(0, 10)).get());
GetInputHandler().ScrollUpdate(
AnimatedUpdateState(gfx::Point(10, 10), gfx::Vector2d(0, 20)).get());
// Scrolling the inner viewport happens through the Viewport class which
// uses the outer viewport to represent "latched to the viewport".
EXPECT_EQ(OuterViewportScrollLayer()->scroll_tree_index(),
host_impl_->CurrentlyScrollingNode()->id);
}
base::TimeTicks start_time = base::TimeTicks() + base::Milliseconds(100);
viz::BeginFrameArgs begin_frame_args =
viz::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, 0, 1);
// Tick a frame to get the animation started.
{
begin_frame_args.frame_time = start_time;
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
host_impl_->UpdateAnimationState(true);
EXPECT_NE(0, CurrentScrollOffset(scrolling_layer).y());
host_impl_->DidFinishImplFrame(begin_frame_args);
}
// Tick ahead to the end of the animation. We scrolled 30 viewport pixels but
// since we're zoomed in to 2x we should have scrolled 15 content pixels.
{
begin_frame_args.frame_time = start_time + base::Milliseconds(1000);
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
host_impl_->UpdateAnimationState(true);
EXPECT_EQ(15, CurrentScrollOffset(scrolling_layer).y());
host_impl_->DidFinishImplFrame(begin_frame_args);
}
}
// Ensures a scroll updating an in progress animation works correctly when the
// inner viewport is animating. Specifically this test makes sure the animation
// update doesn't get confused between the currently scrolling node and the
// currently animating node which are different. See https://crbug.com/1070561.
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollAnimatedUpdateInnerViewport) {
const gfx::Size content_size(210, 1000);
const gfx::Size viewport_size(200, 200);
SetupViewportLayersOuterScrolls(viewport_size, content_size);
DrawFrame();
// Zoom in to 2X and ensure both viewports have scroll extent in every
// direction.
{
float min_page_scale = 1, max_page_scale = 4;
float page_scale_factor = 2;
host_impl_->active_tree()->PushPageScaleFromMainThread(
page_scale_factor, min_page_scale, max_page_scale);
host_impl_->active_tree()->SetPageScaleOnActiveTree(page_scale_factor);
SetScrollOffsetDelta(InnerViewportScrollLayer(), gfx::Vector2d(50, 50));
SetScrollOffsetDelta(OuterViewportScrollLayer(), gfx::Vector2d(5, 400));
}
// Start an animated scroll on the inner viewport.
{
auto begin_state = BeginState(gfx::Point(10, 10), gfx::Vector2d(0, 60),
ui::ScrollInputType::kWheel);
GetInputHandler().ScrollBegin(begin_state.get(),
ui::ScrollInputType::kWheel);
GetInputHandler().ScrollUpdate(
AnimatedUpdateState(gfx::Point(10, 10), gfx::Vector2d(0, 60)).get());
// Scrolling the inner viewport happens through the Viewport class which
// uses the outer viewport to represent "latched to the viewport".
EXPECT_EQ(OuterViewportScrollLayer()->scroll_tree_index(),
host_impl_->CurrentlyScrollingNode()->id);
// However, the animating scroll node should be the inner viewport.
ASSERT_TRUE(InnerViewportScrollLayer()->element_id());
EXPECT_EQ(InnerViewportScrollLayer()->element_id(),
GetImplAnimationHost()->ImplOnlyScrollAnimatingElement());
}
base::TimeTicks start_time = base::TimeTicks() + base::Milliseconds(100);
viz::BeginFrameArgs begin_frame_args =
viz::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, 0, 1);
// Tick a frame to get the animation started.
{
begin_frame_args.frame_time = start_time;
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
host_impl_->UpdateAnimationState(true);
// The inner viewport should have scrolled a bit from its initial position;
// the outer viewport should be still. Neither should move horizontally.
EXPECT_LT(50, CurrentScrollOffset(InnerViewportScrollLayer()).y());
EXPECT_EQ(400, CurrentScrollOffset(OuterViewportScrollLayer()).y());
EXPECT_EQ(50, CurrentScrollOffset(InnerViewportScrollLayer()).x());
EXPECT_EQ(5, CurrentScrollOffset(OuterViewportScrollLayer()).x());
host_impl_->DidFinishImplFrame(begin_frame_args);
}
// Do another scroll update which should update the existing animation curve.
{
// This scroll will cause the target to be at the max scroll offset. Inner
// viewport max offset is 100px. Initial offset is 50px. We scrolled 60px +
// 60px divided by scale factor 2 so 60px total.
GetInputHandler().ScrollUpdate(
AnimatedUpdateState(gfx::Point(10, 10), gfx::Vector2d(0, 60)).get());
// While we're animating the curve, we don't distribute to the outer
// viewport so this scroll update should be a no-op.
GetInputHandler().ScrollUpdate(
AnimatedUpdateState(gfx::Point(10, 10), gfx::Vector2d(0, 60)).get());
}
// Tick ahead to the end of the animation. The inner viewport should be
// scrolled to the maximum offset. The outer viewport should not have
// scrolled.
{
begin_frame_args.frame_time = start_time + base::Milliseconds(1000);
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
host_impl_->UpdateAnimationState(true);
EXPECT_EQ(100, CurrentScrollOffset(InnerViewportScrollLayer()).y());
EXPECT_EQ(400, CurrentScrollOffset(OuterViewportScrollLayer()).y());
// Ensure no horizontal delta is produced.
EXPECT_EQ(50, CurrentScrollOffset(InnerViewportScrollLayer()).x());
EXPECT_EQ(5, CurrentScrollOffset(OuterViewportScrollLayer()).x());
host_impl_->DidFinishImplFrame(begin_frame_args);
}
}
// This tests that faded-out Aura scrollbars can't be interacted with.
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
FadedOutPaintedOverlayScrollbarHitTest) {
LayerTreeSettings settings = DefaultSettings();
settings.compositor_threaded_scrollbar_scrolling = true;
CreateHostImpl(settings, CreateLayerTreeFrameSink());
// Setup the viewport.
const gfx::Size viewport_size = gfx::Size(360, 600);
const gfx::Size content_size = gfx::Size(345, 3800);
SetupViewportLayersOuterScrolls(viewport_size, content_size);
LayerImpl* scroll_layer = OuterViewportScrollLayer();
// Set up the scrollbar and its dimensions.
LayerTreeImpl* layer_tree_impl = host_impl_->active_tree();
auto* scrollbar = AddLayer<PaintedOverlayScrollbarLayerImpl>(
layer_tree_impl, ScrollbarOrientation::VERTICAL, false);
SetupScrollbarLayerCommon(scroll_layer, scrollbar);
scrollbar->SetHitTestable(true);
const gfx::Size scrollbar_size = gfx::Size(15, 600);
scrollbar->SetBounds(scrollbar_size);
// Set up the thumb dimensions.
scrollbar->SetThumbThickness(15);
scrollbar->SetThumbLength(50);
scrollbar->SetTrackStart(0);
scrollbar->SetTrackLength(575);
scrollbar->SetOffsetToTransformParent(gfx::Vector2dF(345, 0));
// Set up the scroll node and other state required for scrolling.
GetInputHandler().ScrollBegin(
BeginState(gfx::Point(350, 18), gfx::Vector2dF(),
ui::ScrollInputType::kScrollbar)
.get(),
ui::ScrollInputType::kScrollbar);
TestInputHandlerClient input_handler_client;
GetInputHandler().BindToClient(&input_handler_client);
// PaintedOverlayScrollbarLayerImpl(s) don't have a track, so we test thumb
// drags instead. Start with 0.8 opacity. Scrolling is expected to occur in
// this case.
auto& scrollbar_effect_node = CreateEffectNode(scrollbar);
scrollbar_effect_node.opacity = 0.8;
GetInputHandler().MouseDown(gfx::PointF(350, 18),
/*jump_key_modifier*/ false);
InputHandlerPointerResult result =
GetInputHandler().MouseMoveAt(gfx::Point(350, 28));
EXPECT_GT(result.scroll_delta.y(), 0u);
GetInputHandler().MouseUp(gfx::PointF(350, 28));
// Scrolling shouldn't occur at opacity = 0.
scrollbar_effect_node.opacity = 0;
GetInputHandler().MouseDown(gfx::PointF(350, 18),
/*jump_key_modifier*/ false);
result = GetInputHandler().MouseMoveAt(gfx::Point(350, 28));
EXPECT_EQ(result.scroll_delta.y(), 0u);
GetInputHandler().MouseUp(gfx::PointF(350, 28));
// Tear down the LayerTreeHostImpl before the InputHandlerClient.
host_impl_->ReleaseLayerTreeFrameSink();
host_impl_ = nullptr;
}
// Tests that no scrolls occur when thumb_len equals track_len.
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollOnLargeThumb) {
LayerTreeSettings settings = DefaultSettings();
settings.compositor_threaded_scrollbar_scrolling = true;
CreateHostImpl(settings, CreateLayerTreeFrameSink());
// Setup the viewport.
const gfx::Size viewport_size = gfx::Size(360, 600);
const gfx::Size content_size = gfx::Size(345, 3800);
SetupViewportLayersOuterScrolls(viewport_size, content_size);
LayerImpl* scroll_layer = OuterViewportScrollLayer();
// Set up the scrollbar and its dimensions.
LayerTreeImpl* layer_tree_impl = host_impl_->active_tree();
layer_tree_impl->set_painted_device_scale_factor(2.5f);
auto* scrollbar = AddLayer<PaintedScrollbarLayerImpl>(
layer_tree_impl, ScrollbarOrientation::VERTICAL, false, true);
SetupScrollbarLayerCommon(scroll_layer, scrollbar);
scrollbar->SetHitTestable(true);
const gfx::Size scrollbar_size = gfx::Size(15, 600);
scrollbar->SetBounds(scrollbar_size);
// Set up the thumb dimensions.
scrollbar->SetThumbThickness(15);
scrollbar->SetThumbLength(575);
scrollbar->SetTrackRect(gfx::Rect(0, 15, 15, 575));
scrollbar->SetOffsetToTransformParent(gfx::Vector2dF(345, 0));
TestInputHandlerClient input_handler_client;
GetInputHandler().BindToClient(&input_handler_client);
// PointerDown on the scrollbar should populate drag_state.
GetInputHandler().MouseDown(gfx::PointF(350, 300),
/*jump_key_modifier*/ false);
EXPECT_TRUE(GetInputHandler()
.scrollbar_controller_for_testing()
->drag_state_.has_value());
// Moving the mouse downwards should result in no scroll.
InputHandlerPointerResult res =
GetInputHandler().MouseMoveAt(gfx::Point(350, 600));
EXPECT_EQ(res.scroll_delta.y(), 0);
// Moving the mouse upwards should result in no scroll.
res = GetInputHandler().MouseMoveAt(gfx::Point(350, 0));
EXPECT_EQ(res.scroll_delta.y(), 0);
// End the scroll.
GetInputHandler().MouseUp(gfx::PointF(350, 0));
EXPECT_TRUE(!GetInputHandler()
.scrollbar_controller_for_testing()
->drag_state_.has_value());
// Tear down the LayerTreeHostImpl before the InputHandlerClient.
host_impl_->ReleaseLayerTreeFrameSink();
host_impl_ = nullptr;
}
// Tests that deleting a horizontal scrollbar doesn't affect the autoscroll task
// for the vertical scrollbar.
TEST_P(ScrollUnifiedLayerTreeHostImplTest, AutoscrollOnDeletedScrollbar) {
LayerTreeSettings settings = DefaultSettings();
settings.compositor_threaded_scrollbar_scrolling = true;
CreateHostImpl(settings, CreateLayerTreeFrameSink());
// Setup the viewport.
const gfx::Size viewport_size = gfx::Size(360, 600);
const gfx::Size content_size = gfx::Size(345, 3800);
SetupViewportLayersOuterScrolls(viewport_size, content_size);
LayerImpl* scroll_layer = OuterViewportScrollLayer();
// Set up the scrollbar and its dimensions.
LayerTreeImpl* layer_tree_impl = host_impl_->active_tree();
auto* scrollbar = AddLayer<PaintedScrollbarLayerImpl>(
layer_tree_impl, ScrollbarOrientation::VERTICAL, false, true);
SetupScrollbarLayerCommon(scroll_layer, scrollbar);
scrollbar->SetHitTestable(true);
const gfx::Size scrollbar_size = gfx::Size(15, 600);
scrollbar->SetBounds(scrollbar_size);
// Set up the thumb dimensions.
scrollbar->SetThumbThickness(15);
scrollbar->SetThumbLength(50);
scrollbar->SetTrackRect(gfx::Rect(0, 15, 15, 575));
scrollbar->SetOffsetToTransformParent(gfx::Vector2dF(345, 0));
TestInputHandlerClient input_handler_client;
GetInputHandler().BindToClient(&input_handler_client);
// PointerDown on the scrollbar schedules an autoscroll task.
GetInputHandler().MouseDown(gfx::PointF(350, 580),
/*jump_key_modifier*/ false);
EXPECT_TRUE(!host_impl_->CurrentlyScrollingNode());
// Now, unregister the horizontal scrollbar and test that the autoscroll task
// that was scheduled for the vertical scrollbar still exists. (Note that
// adding a horizontal scrollbar layer is not needed. This test merely checks
// the logic inside ScrollbarController::DidUnregisterScrollbar)
host_impl_->DidUnregisterScrollbarLayer(scroll_layer->element_id(),
ScrollbarOrientation::HORIZONTAL);
EXPECT_TRUE(GetInputHandler()
.scrollbar_controller_for_testing()
->AutoscrollTaskIsScheduled());
// If a call comes in to delete the scrollbar layer for which the autoscroll
// was scheduled, the autoscroll task should set a waiting state instead of
// initiating an autoscroll, in case the scrollbar comes back.
layer_tree_impl->UnregisterScrollbar(scrollbar);
EXPECT_TRUE(GetInputHandler()
.scrollbar_controller_for_testing()
->AutoscrollTaskIsScheduled());
GetInputHandler()
.scrollbar_controller_for_testing()
->cancelable_autoscroll_task_->callback()
.Run();
GetInputHandler()
.scrollbar_controller_for_testing()
->cancelable_autoscroll_task_.reset();
EXPECT_EQ(GetInputHandler()
.scrollbar_controller_for_testing()
->autoscroll_state_->status,
ScrollbarController::AutoScrollStatus::AUTOSCROLL_READY);
// Re-register the scrollbar. An autoscroll task should be posted that
// actually starts a scroll animation
layer_tree_impl->RegisterScrollbar(scrollbar);
EXPECT_TRUE(GetInputHandler()
.scrollbar_controller_for_testing()
->AutoscrollTaskIsScheduled());
GetInputHandler()
.scrollbar_controller_for_testing()
->cancelable_autoscroll_task_->callback()
.Run();
GetInputHandler()
.scrollbar_controller_for_testing()
->cancelable_autoscroll_task_.reset();
EXPECT_EQ(GetInputHandler()
.scrollbar_controller_for_testing()
->autoscroll_state_->status,
ScrollbarController::AutoScrollStatus::AUTOSCROLL_SCROLLING);
// End the scroll.
GetInputHandler().MouseUp(gfx::PointF(350, 580));
GetInputHandler().ScrollEnd();
EXPECT_TRUE(!host_impl_->CurrentlyScrollingNode());
// Tear down the LayerTreeHostImpl before the InputHandlerClient.
host_impl_->ReleaseLayerTreeFrameSink();
host_impl_ = nullptr;
}
// Tests that a pointerdown followed by pointermove(s) produces
// InputHandlerPointerResult with scroll_offset > 0 even though the GSB might
// have been dispatched *after* the first pointermove was handled by the
// ScrollbarController.
TEST_P(ScrollUnifiedLayerTreeHostImplTest, PointerMoveOutOfSequence) {
LayerTreeSettings settings = DefaultSettings();
settings.compositor_threaded_scrollbar_scrolling = true;
CreateHostImpl(settings, CreateLayerTreeFrameSink());
// Setup the viewport.
const gfx::Size viewport_size = gfx::Size(360, 600);
const gfx::Size content_size = gfx::Size(345, 3800);
SetupViewportLayersOuterScrolls(viewport_size, content_size);
LayerImpl* scroll_layer = OuterViewportScrollLayer();
// Set up the scrollbar and its dimensions.
LayerTreeImpl* layer_tree_impl = host_impl_->active_tree();
auto* scrollbar = AddLayer<PaintedScrollbarLayerImpl>(
layer_tree_impl, ScrollbarOrientation::VERTICAL, false, true);
SetupScrollbarLayerCommon(scroll_layer, scrollbar);
scrollbar->SetHitTestable(true);
const gfx::Size scrollbar_size = gfx::Size(15, 600);
scrollbar->SetBounds(scrollbar_size);
// Set up the thumb dimensions.
scrollbar->SetThumbThickness(15);
scrollbar->SetThumbLength(50);
scrollbar->SetTrackRect(gfx::Rect(0, 15, 15, 575));
scrollbar->SetOffsetToTransformParent(gfx::Vector2dF(345, 0));
TestInputHandlerClient input_handler_client;
GetInputHandler().BindToClient(&input_handler_client);
// PointerDown sets up the state needed to initiate a drag. Although, the
// resulting GSB won't be dispatched until the next VSync. Hence, the
// CurrentlyScrollingNode is expected to be null.
GetInputHandler().MouseDown(gfx::PointF(350, 18),
/*jump_key_modifier*/ false);
EXPECT_TRUE(!host_impl_->CurrentlyScrollingNode());
// PointerMove arrives before the next VSync. This still needs to be handled
// by the ScrollbarController even though the GSB has not yet been dispatched.
// Note that this doesn't result in a scroll yet. It only prepares a GSU based
// on the result that is returned by ScrollbarController::HandlePointerMove.
InputHandlerPointerResult result =
GetInputHandler().MouseMoveAt(gfx::Point(350, 19));
EXPECT_GT(result.scroll_delta.y(), 0u);
// GSB gets dispatched at VSync.
viz::BeginFrameArgs begin_frame_args =
viz::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, 0, 1);
begin_frame_args.frame_time = base::TimeTicks::Now();
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
GetInputHandler().ScrollBegin(
BeginState(gfx::Point(350, 18), gfx::Vector2dF(),
ui::ScrollInputType::kScrollbar)
.get(),
ui::ScrollInputType::kScrollbar);
EXPECT_TRUE(host_impl_->CurrentlyScrollingNode());
// The PointerMove(s) that follow should be handled and are expected to have a
// scroll_offset > 0.
result = GetInputHandler().MouseMoveAt(gfx::Point(350, 20));
EXPECT_GT(result.scroll_delta.y(), 0u);
// End the scroll.
GetInputHandler().MouseUp(gfx::PointF(350, 20));
GetInputHandler().ScrollEnd();
EXPECT_TRUE(!host_impl_->CurrentlyScrollingNode());
// Tear down the LayerTreeHostImpl before the InputHandlerClient.
host_impl_->ReleaseLayerTreeFrameSink();
host_impl_ = nullptr;
}
// This tests that faded-out Mac scrollbars can't be interacted with.
TEST_P(ScrollUnifiedLayerTreeHostImplTest, FadedOutPaintedScrollbarHitTest) {
LayerTreeSettings settings = DefaultSettings();
settings.compositor_threaded_scrollbar_scrolling = true;
CreateHostImpl(settings, CreateLayerTreeFrameSink());
// Setup the viewport.
const gfx::Size viewport_size = gfx::Size(360, 600);
const gfx::Size content_size = gfx::Size(345, 3800);
SetupViewportLayersOuterScrolls(viewport_size, content_size);
LayerImpl* scroll_layer = OuterViewportScrollLayer();
// Set up the scrollbar and its dimensions.
LayerTreeImpl* layer_tree_impl = host_impl_->active_tree();
auto* scrollbar = AddLayer<PaintedScrollbarLayerImpl>(
layer_tree_impl, ScrollbarOrientation::VERTICAL, false, true);
SetupScrollbarLayerCommon(scroll_layer, scrollbar);
scrollbar->SetHitTestable(true);
const gfx::Size scrollbar_size = gfx::Size(15, 600);
scrollbar->SetBounds(scrollbar_size);
// Set up the thumb dimensions.
scrollbar->SetThumbThickness(15);
scrollbar->SetThumbLength(50);
scrollbar->SetTrackRect(gfx::Rect(0, 15, 15, 575));
scrollbar->SetOffsetToTransformParent(gfx::Vector2dF(345, 0));
TestInputHandlerClient input_handler_client;
GetInputHandler().BindToClient(&input_handler_client);
// MouseDown on the track of a scrollbar with opacity 0 should not produce a
// scroll.
scrollbar->SetScrollbarPaintedOpacity(0);
InputHandlerPointerResult result = GetInputHandler().MouseDown(
gfx::PointF(350, 100), /*jump_key_modifier*/ false);
EXPECT_EQ(result.scroll_delta.y(), 0u);
// MouseDown on the track of a scrollbar with opacity > 0 should produce a
// scroll.
scrollbar->SetScrollbarPaintedOpacity(1);
result = GetInputHandler().MouseDown(gfx::PointF(350, 100),
/*jump_key_modifier*/ false);
EXPECT_GT(result.scroll_delta.y(), 0u);
// Tear down the LayerTreeHostImpl before the InputHandlerClient.
host_impl_->ReleaseLayerTreeFrameSink();
host_impl_ = nullptr;
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
SingleGSUForScrollbarThumbDragPerFrame) {
LayerTreeSettings settings = DefaultSettings();
settings.compositor_threaded_scrollbar_scrolling = true;
CreateHostImpl(settings, CreateLayerTreeFrameSink());
// Setup the viewport.
const gfx::Size viewport_size = gfx::Size(360, 600);
const gfx::Size content_size = gfx::Size(345, 3800);
SetupViewportLayersOuterScrolls(viewport_size, content_size);
LayerImpl* scroll_layer = OuterViewportScrollLayer();
// Set up the scrollbar and its dimensions.
LayerTreeImpl* layer_tree_impl = host_impl_->active_tree();
auto* scrollbar = AddLayer<PaintedScrollbarLayerImpl>(
layer_tree_impl, ScrollbarOrientation::VERTICAL, false, true);
SetupScrollbarLayer(scroll_layer, scrollbar);
const gfx::Size scrollbar_size = gfx::Size(15, 600);
scrollbar->SetBounds(scrollbar_size);
// Set up the thumb dimensions.
scrollbar->SetThumbThickness(15);
scrollbar->SetThumbLength(50);
scrollbar->SetTrackRect(gfx::Rect(0, 15, 15, 575));
// Set up scrollbar arrows.
scrollbar->SetBackButtonRect(
gfx::Rect(gfx::Point(345, 0), gfx::Size(15, 15)));
scrollbar->SetForwardButtonRect(
gfx::Rect(gfx::Point(345, 570), gfx::Size(15, 15)));
scrollbar->SetOffsetToTransformParent(gfx::Vector2dF(345, 0));
GetInputHandler().ScrollBegin(
BeginState(gfx::Point(350, 18), gfx::Vector2dF(),
ui::ScrollInputType::kScrollbar)
.get(),
ui::ScrollInputType::kScrollbar);
TestInputHandlerClient input_handler_client;
GetInputHandler().BindToClient(&input_handler_client);
// ------------------------- Start frame 0 -------------------------
base::TimeTicks start_time = base::TimeTicks() + base::Milliseconds(200);
viz::BeginFrameArgs begin_frame_args =
viz::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, 0, 1);
begin_frame_args.frame_time = start_time;
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
// MouseDown on the thumb should not produce a scroll.
InputHandlerPointerResult result = GetInputHandler().MouseDown(
gfx::PointF(350, 18), /*jump_key_modifier*/ false);
EXPECT_EQ(result.scroll_delta.y(), 0u);
// The first request for a GSU should be processed as expected.
result = GetInputHandler().MouseMoveAt(gfx::Point(350, 19));
EXPECT_GT(result.scroll_delta.y(), 0u);
// A second request for a GSU within the same frame should be ignored as it
// will cause the thumb drag to become jittery. The reason this happens is
// because when the first GSU is processed, it gets queued in the compositor
// thread event queue. So a second request within the same frame will end up
// calculating an incorrect delta (as ComputeThumbQuadRect would not have
// accounted for the delta in the first GSU that was not yet dispatched).
result = GetInputHandler().MouseMoveAt(gfx::Point(350, 20));
EXPECT_EQ(result.scroll_delta.y(), 0u);
host_impl_->DidFinishImplFrame(begin_frame_args);
// ------------------------- Start frame 1 -------------------------
begin_frame_args.frame_time = start_time + base::Milliseconds(250);
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
// MouseMove for a new frame gets processed as usual.
result = GetInputHandler().MouseMoveAt(gfx::Point(350, 21));
EXPECT_GT(result.scroll_delta.y(), 0u);
// MouseUp is not expected to have a delta.
result = GetInputHandler().MouseUp(gfx::PointF(350, 21));
EXPECT_EQ(result.scroll_delta.y(), 0u);
// Tear down the LayerTreeHostImpl before the InputHandlerClient.
host_impl_->ReleaseLayerTreeFrameSink();
host_impl_ = nullptr;
}
// Test if the AverageLagTrackingManager's pending frames list is cleared when
// the LayerTreeFrameSink loses context. It is necessary since the frames won't
// receive a presentation feedback if the context is lost, and the pending
// frames will never be removed from the list otherwise.
TEST_F(LayerTreeHostImplTest,
ClearTrackingManagerOnLayerTreeFrameSinkLoseContext) {
const gfx::Size content_size(1000, 10000);
const gfx::Size viewport_size(500, 500);
SetupViewportLayersOuterScrolls(viewport_size, content_size);
DrawFrame();
GetInputHandler().ScrollBegin(
BeginState(gfx::Point(250, 250), gfx::Vector2dF(),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
// Draw 30 frames, each with 1 LatencyInfo object that will be added to the
// AverageLagTrackingManager.
for (int i = 0; i < 30; i++) {
// Makes a scroll update so the next frame is set to be processed
// (to force frame->has_no_damage = false).
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), gfx::Vector2d(0, 10),
ui::ScrollInputType::kTouchscreen)
.get());
// Add an `EventMetrics` object that will be accepted by
// `AverageLagTrackingManager::CollectScrollEventsFromFrame()`.
EventMetrics::List events_metrics;
events_metrics.push_back(ScrollUpdateEventMetrics::Create(
ui::EventType::ET_GESTURE_SCROLL_UPDATE,
ui::ScrollInputType::kTouchscreen,
/*is_inertial=*/false,
i == 0 ? ScrollUpdateEventMetrics::ScrollUpdateType::kStarted
: ScrollUpdateEventMetrics::ScrollUpdateType::kContinued,
/*delta=*/10.0f, base::TimeTicks::Now(),
base::TimeTicks::Now() + base::Milliseconds(1)));
host_impl_->active_tree()->AppendEventsMetricsFromMainThread(
std::move(events_metrics));
DrawFrame();
}
// Make LayerTreeFrameSink lose context. It should clear
// |lag_tracking_manager_|.
host_impl_->DidLoseLayerTreeFrameSink();
// Finish the test. |lag_tracking_manager_| will check in its destructor if
// there is less than 20 frames in its pending frames list.
}
// Test that DroppedFrameCounter and TotalFrameCounter reset themselves under
// certain conditions
TEST_F(LayerTreeHostImplTest, FrameCounterReset) {
TotalFrameCounter* total_frame_counter =
host_impl_->total_frame_counter_for_testing();
DroppedFrameCounter* dropped_frame_counter =
host_impl_->dropped_frame_counter_for_testing();
EXPECT_EQ(total_frame_counter->total_frames(), 0u);
EXPECT_EQ(dropped_frame_counter->total_frames(), 0u);
total_frame_counter->set_total_frames_for_testing(1u);
EXPECT_EQ(total_frame_counter->total_frames(), 1u);
dropped_frame_counter->AddGoodFrame();
EXPECT_EQ(dropped_frame_counter->total_frames(), 1u);
auto interval = base::Milliseconds(16);
base::TimeTicks now = base::TimeTicks::Now();
auto deadline = now + interval;
viz::BeginFrameArgs args = viz::BeginFrameArgs::Create(
BEGINFRAME_FROM_HERE, 1u /*source_id*/, 2u /*sequence_number*/, now,
deadline, interval, viz::BeginFrameArgs::NORMAL);
dropped_frame_counter->OnEndFrame(
args, CreateFakeFrameInfo(FrameInfo::FrameFinalState::kDropped));
// FCP not received, so the total_smoothness_dropped_ won't increase.
EXPECT_EQ(dropped_frame_counter->total_smoothness_dropped(), 0u);
BeginMainFrameMetrics begin_frame_metrics;
begin_frame_metrics.should_measure_smoothness = true;
host_impl_->ReadyToCommit(args, true, &begin_frame_metrics);
dropped_frame_counter->SetTimeFcpReceivedForTesting(args.frame_time);
dropped_frame_counter->OnEndFrame(
args, CreateFakeFrameInfo(FrameInfo::FrameFinalState::kDropped));
EXPECT_EQ(dropped_frame_counter->total_smoothness_dropped(), 1u);
total_frame_counter->set_total_frames_for_testing(1u);
dropped_frame_counter->AddGoodFrame();
host_impl_->SetActiveURL(GURL(), 1u);
EXPECT_EQ(total_frame_counter->total_frames(), 0u);
EXPECT_EQ(dropped_frame_counter->total_frames(), 0u);
EXPECT_EQ(dropped_frame_counter->total_smoothness_dropped(), 0u);
}
// Test that DroppedFrameCounter and TotalFrameCounter do not reset themselves
// under certain conditions
TEST_F(LayerTreeHostImplTest, FrameCounterNotReset) {
TotalFrameCounter* total_frame_counter =
host_impl_->total_frame_counter_for_testing();
DroppedFrameCounter* dropped_frame_counter =
host_impl_->dropped_frame_counter_for_testing();
EXPECT_EQ(total_frame_counter->total_frames(), 0u);
EXPECT_EQ(dropped_frame_counter->total_frames(), 0u);
auto interval = base::Milliseconds(16);
base::TimeTicks now = base::TimeTicks::Now();
auto deadline = now + interval;
viz::BeginFrameArgs arg1 = viz::BeginFrameArgs::Create(
BEGINFRAME_FROM_HERE, 1u /*source_id*/, 1u /*sequence_number*/, now,
deadline, interval, viz::BeginFrameArgs::NORMAL);
BeginMainFrameMetrics begin_frame_metrics;
begin_frame_metrics.should_measure_smoothness = true;
host_impl_->ReadyToCommit(arg1, true, &begin_frame_metrics);
EXPECT_EQ(total_frame_counter->total_frames(), 0u);
EXPECT_EQ(dropped_frame_counter->total_frames(), 0u);
total_frame_counter->set_total_frames_for_testing(1u);
EXPECT_EQ(total_frame_counter->total_frames(), 1u);
dropped_frame_counter->AddGoodFrame();
EXPECT_EQ(dropped_frame_counter->total_frames(), 1u);
now = deadline;
deadline = now + interval;
viz::BeginFrameArgs arg2 = viz::BeginFrameArgs::Create(
BEGINFRAME_FROM_HERE, 1u /*source_id*/, 2u /*sequence_number*/, now,
deadline, interval, viz::BeginFrameArgs::NORMAL);
// Consecutive BeginFrameMetrics with the same |should_measure_smoothness|
// flag should not reset the counter.
host_impl_->ReadyToCommit(arg2, true, &begin_frame_metrics);
EXPECT_EQ(total_frame_counter->total_frames(), 1u);
EXPECT_EQ(dropped_frame_counter->total_frames(), 1u);
}
// Tests that the scheduled autoscroll task aborts if a 2nd mousedown occurs in
// the same frame.
TEST_F(LayerTreeHostImplTest, AutoscrollTaskAbort) {
LayerTreeSettings settings = DefaultSettings();
settings.compositor_threaded_scrollbar_scrolling = true;
CreateHostImpl(settings, CreateLayerTreeFrameSink());
// Setup the viewport.
const gfx::Size viewport_size = gfx::Size(360, 600);
const gfx::Size content_size = gfx::Size(345, 3800);
SetupViewportLayersOuterScrolls(viewport_size, content_size);
LayerImpl* scroll_layer = OuterViewportScrollLayer();
// Set up the scrollbar and its dimensions.
LayerTreeImpl* layer_tree_impl = host_impl_->active_tree();
auto* scrollbar = AddLayer<PaintedScrollbarLayerImpl>(
layer_tree_impl, ScrollbarOrientation::VERTICAL,
/*is_left_side_vertical_scrollbar*/ false,
/*is_overlay*/ false);
SetupScrollbarLayer(scroll_layer, scrollbar);
const gfx::Size scrollbar_size = gfx::Size(15, 600);
scrollbar->SetBounds(scrollbar_size);
host_impl_->set_force_smooth_wheel_scrolling_for_testing(true);
// Set up the thumb dimensions.
scrollbar->SetThumbThickness(15);
scrollbar->SetThumbLength(50);
scrollbar->SetTrackRect(gfx::Rect(0, 15, 15, 575));
// Set up scrollbar arrows.
scrollbar->SetBackButtonRect(
gfx::Rect(gfx::Point(345, 0), gfx::Size(15, 15)));
scrollbar->SetForwardButtonRect(
gfx::Rect(gfx::Point(345, 570), gfx::Size(15, 15)));
scrollbar->SetOffsetToTransformParent(gfx::Vector2dF(345, 0));
TestInputHandlerClient input_handler_client;
GetInputHandler().BindToClient(&input_handler_client);
{
// An autoscroll task gets scheduled on mousedown.
InputHandlerPointerResult result = GetInputHandler().MouseDown(
gfx::PointF(350, 575), /*jump_key_modifier*/ false);
EXPECT_EQ(result.type, PointerResultType::kScrollbarScroll);
auto begin_state = BeginState(gfx::Point(350, 575), gfx::Vector2d(0, 40),
ui::ScrollInputType::kScrollbar);
EXPECT_EQ(
ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(begin_state.get(), ui::ScrollInputType::kScrollbar)
.thread);
EXPECT_TRUE(GetInputHandler()
.scrollbar_controller_for_testing()
->AutoscrollTaskIsScheduled());
}
{
// Another mousedown occurs in the same frame. InputHandlerProxy calls
// LayerTreeHostImpl::ScrollEnd and the autoscroll task should be cancelled.
InputHandlerPointerResult result = GetInputHandler().MouseDown(
gfx::PointF(350, 575), /*jump_key_modifier*/ false);
EXPECT_EQ(result.type, PointerResultType::kScrollbarScroll);
GetInputHandler().ScrollEnd();
EXPECT_FALSE(GetInputHandler()
.scrollbar_controller_for_testing()
->AutoscrollTaskIsScheduled());
}
// Tear down the LayerTreeHostImpl before the InputHandlerClient.
host_impl_->ReleaseLayerTreeFrameSink();
host_impl_ = nullptr;
}
// Tests that the ScrollbarController handles jump clicks.
TEST_F(LayerTreeHostImplTest, JumpOnScrollbarClick) {
LayerTreeSettings settings = DefaultSettings();
settings.compositor_threaded_scrollbar_scrolling = true;
CreateHostImpl(settings, CreateLayerTreeFrameSink());
// Setup the viewport.
const gfx::Size viewport_size = gfx::Size(360, 600);
const gfx::Size content_size = gfx::Size(345, 3800);
SetupViewportLayersOuterScrolls(viewport_size, content_size);
LayerImpl* scroll_layer = OuterViewportScrollLayer();
// Set up the scrollbar and its dimensions.
LayerTreeImpl* layer_tree_impl = host_impl_->active_tree();
auto* scrollbar = AddLayer<PaintedScrollbarLayerImpl>(
layer_tree_impl, ScrollbarOrientation::VERTICAL,
/*is_left_side_vertical_scrollbar*/ false,
/*is_overlay*/ false);
SetupScrollbarLayer(scroll_layer, scrollbar);
const gfx::Size scrollbar_size = gfx::Size(15, 600);
scrollbar->SetBounds(scrollbar_size);
host_impl_->set_force_smooth_wheel_scrolling_for_testing(true);
// Set up the thumb dimensions.
scrollbar->SetThumbThickness(15);
scrollbar->SetThumbLength(50);
scrollbar->SetTrackRect(gfx::Rect(0, 15, 15, 575));
// Set up scrollbar arrows.
scrollbar->SetBackButtonRect(
gfx::Rect(gfx::Point(345, 0), gfx::Size(15, 15)));
scrollbar->SetForwardButtonRect(
gfx::Rect(gfx::Point(345, 570), gfx::Size(15, 15)));
scrollbar->SetOffsetToTransformParent(gfx::Vector2dF(345, 0));
TestInputHandlerClient input_handler_client;
GetInputHandler().BindToClient(&input_handler_client);
// Verify all 4 combinations of JumpOnTrackClick and jump_key_modifier.
{
// Click on track when JumpOnTrackClick is false and jump_key_modifier is
// false. Expected to perform a regular track scroll.
scrollbar->SetJumpOnTrackClick(false);
InputHandlerPointerResult result = GetInputHandler().MouseDown(
gfx::PointF(350, 400), /*jump_key_modifier*/ false);
EXPECT_EQ(result.type, PointerResultType::kScrollbarScroll);
EXPECT_EQ(result.scroll_delta.y(), 525);
result = GetInputHandler().MouseUp(gfx::PointF(350, 400));
EXPECT_EQ(result.type, PointerResultType::kScrollbarScroll);
EXPECT_EQ(result.scroll_delta.y(), 0);
}
{
// Click on track when JumpOnTrackClick is false and jump_key_modifier is
// true. Expected to perform scroller jump to the clicked location.
scrollbar->SetJumpOnTrackClick(false);
InputHandlerPointerResult result = GetInputHandler().MouseDown(
gfx::PointF(350, 400), /*jump_key_modifier*/ true);
EXPECT_EQ(result.type, PointerResultType::kScrollbarScroll);
EXPECT_FLOAT_EQ(result.scroll_delta.y(), 2194.2856f);
result = GetInputHandler().MouseUp(gfx::PointF(350, 400));
EXPECT_EQ(result.type, PointerResultType::kScrollbarScroll);
EXPECT_EQ(result.scroll_delta.y(), 0);
}
{
// Click on track when JumpOnTrackClick is true and jump_key_modifier is
// false. Expected to perform scroller jump to the clicked location.
scrollbar->SetJumpOnTrackClick(true);
InputHandlerPointerResult result = GetInputHandler().MouseDown(
gfx::PointF(350, 400), /*jump_key_modifier*/ false);
EXPECT_EQ(result.type, PointerResultType::kScrollbarScroll);
EXPECT_FLOAT_EQ(result.scroll_delta.y(), 2194.2856f);
result = GetInputHandler().MouseUp(gfx::PointF(350, 400));
EXPECT_EQ(result.type, PointerResultType::kScrollbarScroll);
EXPECT_EQ(result.scroll_delta.y(), 0);
}
{
// Click on track when JumpOnTrackClick is true and jump_key_modifier is
// true. Expected to perform a regular track scroll.
scrollbar->SetJumpOnTrackClick(true);
InputHandlerPointerResult result = GetInputHandler().MouseDown(
gfx::PointF(350, 400), /*jump_key_modifier*/ true);
EXPECT_EQ(result.type, PointerResultType::kScrollbarScroll);
EXPECT_EQ(result.scroll_delta.y(), 525);
result = GetInputHandler().MouseUp(gfx::PointF(350, 400));
EXPECT_EQ(result.type, PointerResultType::kScrollbarScroll);
EXPECT_EQ(result.scroll_delta.y(), 0);
}
// Tear down the LayerTreeHostImpl before the InputHandlerClient.
host_impl_->ReleaseLayerTreeFrameSink();
host_impl_ = nullptr;
}
// Tests that a thumb drag continues to function as expected after a jump click.
// The functionality of thumb drag itself is pretty well tested. So all that
// this test needs to verify is that the thumb drag_state_ is correctly
// populated.
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ThumbDragAfterJumpClick) {
LayerTreeSettings settings = DefaultSettings();
settings.compositor_threaded_scrollbar_scrolling = true;
CreateHostImpl(settings, CreateLayerTreeFrameSink());
// Setup the viewport.
const gfx::Size viewport_size = gfx::Size(360, 600);
const gfx::Size content_size = gfx::Size(345, 3800);
SetupViewportLayersOuterScrolls(viewport_size, content_size);
LayerImpl* scroll_layer = OuterViewportScrollLayer();
// Set up the scrollbar and its dimensions.
LayerTreeImpl* layer_tree_impl = host_impl_->active_tree();
auto* scrollbar = AddLayer<PaintedScrollbarLayerImpl>(
layer_tree_impl, ScrollbarOrientation::VERTICAL,
/*is_left_side_vertical_scrollbar*/ false,
/*is_overlay*/ false);
SetupScrollbarLayer(scroll_layer, scrollbar);
const gfx::Size scrollbar_size = gfx::Size(15, 600);
scrollbar->SetBounds(scrollbar_size);
host_impl_->set_force_smooth_wheel_scrolling_for_testing(true);
const int thumb_len = 50;
// Set up the thumb dimensions.
scrollbar->SetThumbThickness(15);
scrollbar->SetThumbLength(thumb_len);
scrollbar->SetTrackRect(gfx::Rect(0, 15, 15, 575));
// Set up scrollbar arrows.
scrollbar->SetBackButtonRect(
gfx::Rect(gfx::Point(345, 0), gfx::Size(15, 15)));
scrollbar->SetForwardButtonRect(
gfx::Rect(gfx::Point(345, 570), gfx::Size(15, 15)));
scrollbar->SetOffsetToTransformParent(gfx::Vector2dF(345, 0));
TestInputHandlerClient input_handler_client;
GetInputHandler().BindToClient(&input_handler_client);
{
EXPECT_FALSE(GetInputHandler()
.scrollbar_controller_for_testing()
->drag_state_.has_value());
// Perform a pointerdown on the track part to induce a jump click.
const InputHandlerPointerResult result =
GetInputHandler().scrollbar_controller_for_testing()->HandlePointerDown(
gfx::PointF(350, 560), /*jump_key_modifier*/ true);
// This verifies that the jump click took place as expected.
EXPECT_EQ(0, result.scroll_delta.x());
EXPECT_FLOAT_EQ(result.scroll_delta.y(), 243.80952f);
// This verifies that the drag_state_ was initialized when a jump click
// occurred.
EXPECT_TRUE(GetInputHandler()
.scrollbar_controller_for_testing()
->drag_state_.has_value());
// This verifies that the start/snap-back position is the scroll position
// before any jump-click
EXPECT_FLOAT_EQ(GetInputHandler()
.scrollbar_controller_for_testing()
->drag_state_->scroll_position_at_start_,
0.0f);
EXPECT_FLOAT_EQ(GetInputHandler()
.scrollbar_controller_for_testing()
->drag_state_->drag_origin.y(),
15.0f + thumb_len / 2.0f);
}
// Tear down the LayerTreeHostImpl before the InputHandlerClient.
host_impl_->ReleaseLayerTreeFrameSink();
host_impl_ = nullptr;
}
// Tests that an existing scroll offset animation (for a scrollbar) is aborted
// before a new one is created.
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
AbortAnimatedScrollBeforeStartingAutoscroll) {
LayerTreeSettings settings = DefaultSettings();
settings.compositor_threaded_scrollbar_scrolling = true;
CreateHostImpl(settings, CreateLayerTreeFrameSink());
// Setup the viewport.
const gfx::Size viewport_size = gfx::Size(360, 600);
const gfx::Size content_size = gfx::Size(345, 3800);
SetupViewportLayersOuterScrolls(viewport_size, content_size);
LayerImpl* scroll_layer = OuterViewportScrollLayer();
// Set up the scrollbar and its dimensions.
LayerTreeImpl* layer_tree_impl = host_impl_->active_tree();
auto* scrollbar = AddLayer<PaintedScrollbarLayerImpl>(
layer_tree_impl, ScrollbarOrientation::VERTICAL,
/*is_left_side_vertical_scrollbar*/ false,
/*is_overlay*/ false);
SetupScrollbarLayer(scroll_layer, scrollbar);
const gfx::Size scrollbar_size = gfx::Size(15, 600);
scrollbar->SetBounds(scrollbar_size);
host_impl_->set_force_smooth_wheel_scrolling_for_testing(true);
// Set up the thumb dimensions.
scrollbar->SetThumbThickness(15);
scrollbar->SetThumbLength(50);
scrollbar->SetTrackRect(gfx::Rect(0, 15, 15, 575));
// Set up scrollbar arrows.
scrollbar->SetBackButtonRect(
gfx::Rect(gfx::Point(345, 0), gfx::Size(15, 15)));
scrollbar->SetForwardButtonRect(
gfx::Rect(gfx::Point(345, 570), gfx::Size(15, 15)));
scrollbar->SetOffsetToTransformParent(gfx::Vector2dF(345, 0));
TestInputHandlerClient input_handler_client;
GetInputHandler().BindToClient(&input_handler_client);
{
// Set up an animated scrollbar autoscroll.
GetInputHandler().scrollbar_controller_for_testing()->HandlePointerDown(
gfx::PointF(350, 560), /*jump_key_modifier*/ false);
auto begin_state = BeginState(gfx::Point(350, 560), gfx::Vector2d(0, 40),
ui::ScrollInputType::kScrollbar);
EXPECT_EQ(
ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(begin_state.get(), ui::ScrollInputType::kScrollbar)
.thread);
auto update_state = UpdateState(gfx::Point(350, 560), gfx::Vector2dF(0, 40),
ui::ScrollInputType::kScrollbar);
update_state->data()->delta_granularity =
ui::ScrollGranularity::kScrollByPixel;
GetInputHandler().ScrollUpdate(update_state.get());
// Autoscroll animations should be active.
EXPECT_TRUE(GetInputHandler()
.scrollbar_controller_for_testing()
->ScrollbarScrollIsActive());
EXPECT_TRUE(GetImplAnimationHost()->ImplOnlyScrollAnimatingElement());
}
{
// When it's time to kick off the scrollbar autoscroll animation (i.e ~250ms
// after pointerdown), the ScrollbarController should ensure that any
// existing scroll offset animations are aborted and a new autoscroll
// animation is created. Test passes if unit test doesn't hit any DCHECK
// failures.
GetInputHandler().scrollbar_controller_for_testing()->autoscroll_state_ =
ScrollbarController::AutoScrollState();
GetInputHandler()
.scrollbar_controller_for_testing()
->autoscroll_state_->velocity = 800;
GetInputHandler()
.scrollbar_controller_for_testing()
->autoscroll_state_->pressed_scrollbar_part =
ScrollbarPart::FORWARD_TRACK;
GetInputHandler().scrollbar_controller_for_testing()->StartAutoScroll();
EXPECT_TRUE(GetImplAnimationHost()->ImplOnlyScrollAnimatingElement());
}
// Tear down the LayerTreeHostImpl before the InputHandlerClient.
host_impl_->ReleaseLayerTreeFrameSink();
host_impl_ = nullptr;
}
// Tests that an animated scrollbar scroll aborts when a different device (like
// a mousewheel) wants to animate the scroll offset.
TEST_P(ScrollUnifiedLayerTreeHostImplTest, AnimatedScrollYielding) {
LayerTreeSettings settings = DefaultSettings();
settings.compositor_threaded_scrollbar_scrolling = true;
CreateHostImpl(settings, CreateLayerTreeFrameSink());
// Setup the viewport.
const gfx::Size viewport_size = gfx::Size(360, 600);
const gfx::Size content_size = gfx::Size(345, 3800);
SetupViewportLayersOuterScrolls(viewport_size, content_size);
LayerImpl* scroll_layer = OuterViewportScrollLayer();
// Set up the scrollbar and its dimensions.
LayerTreeImpl* layer_tree_impl = host_impl_->active_tree();
auto* scrollbar = AddLayer<PaintedScrollbarLayerImpl>(
layer_tree_impl, ScrollbarOrientation::VERTICAL,
/*is_left_side_vertical_scrollbar*/ false,
/*is_overlay*/ false);
// TODO(arakeri): crbug.com/1070063 Setting the dimensions for scrollbar parts
// (like thumb, track etc) should be moved to SetupScrollbarLayer.
SetupScrollbarLayer(scroll_layer, scrollbar);
const gfx::Size scrollbar_size = gfx::Size(15, 600);
scrollbar->SetBounds(scrollbar_size);
host_impl_->set_force_smooth_wheel_scrolling_for_testing(true);
// Set up the thumb dimensions.
scrollbar->SetThumbThickness(15);
scrollbar->SetThumbLength(50);
scrollbar->SetTrackRect(gfx::Rect(0, 15, 15, 575));
// Set up scrollbar arrows.
scrollbar->SetBackButtonRect(
gfx::Rect(gfx::Point(345, 0), gfx::Size(15, 15)));
scrollbar->SetForwardButtonRect(
gfx::Rect(gfx::Point(345, 570), gfx::Size(15, 15)));
scrollbar->SetOffsetToTransformParent(gfx::Vector2dF(345, 0));
TestInputHandlerClient input_handler_client;
GetInputHandler().BindToClient(&input_handler_client);
{
// Set up an animated scrollbar autoscroll.
GetInputHandler().scrollbar_controller_for_testing()->HandlePointerDown(
gfx::PointF(350, 560), /*jump_key_modifier*/ false);
auto begin_state = BeginState(gfx::Point(350, 560), gfx::Vector2d(0, 40),
ui::ScrollInputType::kScrollbar);
EXPECT_EQ(
ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(begin_state.get(), ui::ScrollInputType::kScrollbar)
.thread);
auto update_state = UpdateState(gfx::Point(350, 560), gfx::Vector2dF(0, 40),
ui::ScrollInputType::kScrollbar);
update_state->data()->delta_granularity =
ui::ScrollGranularity::kScrollByPixel;
GetInputHandler().ScrollUpdate(update_state.get());
// Autoscroll animations should be active.
EXPECT_TRUE(GetInputHandler()
.scrollbar_controller_for_testing()
->ScrollbarScrollIsActive());
EXPECT_TRUE(GetImplAnimationHost()->ImplOnlyScrollAnimatingElement());
}
{
// While the cc autoscroll is in progress, a mousewheel tick takes place.
auto begin_state = BeginState(gfx::Point(), gfx::Vector2d(350, 560),
ui::ScrollInputType::kWheel);
begin_state->data()->delta_granularity =
ui::ScrollGranularity::kScrollByPixel;
// InputHandlerProxy calls LayerTreeHostImpl::ScrollEnd to end the
// autoscroll as it has detected a device change.
GetInputHandler().ScrollEnd();
// This then leads to ScrollbarController::ResetState getting called which
// clears ScrollbarController::autoscroll_state_,
// captured_scrollbar_metadata_ etc. That means
// ScrollbarController::ScrollbarLayer should return null.
EXPECT_FALSE(
GetInputHandler().scrollbar_controller_for_testing()->ScrollbarLayer());
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(begin_state.get(), ui::ScrollInputType::kWheel)
.thread);
// Autoscroll animation should be aborted at this point.
EXPECT_FALSE(GetImplAnimationHost()->ImplOnlyScrollAnimatingElement());
GetInputHandler().ScrollUpdate(
AnimatedUpdateState(gfx::Point(350, 560), gfx::Vector2d(0, 40)).get());
// Mousewheel animation should be active.
EXPECT_TRUE(GetImplAnimationHost()->ImplOnlyScrollAnimatingElement());
// This should not trigger any DCHECKs and will be a no-op.
GetInputHandler().scrollbar_controller_for_testing()->WillBeginImplFrame();
}
// Tear down the LayerTreeHostImpl before the InputHandlerClient.
host_impl_->ReleaseLayerTreeFrameSink();
host_impl_ = nullptr;
}
// Tests that changing the scroller length in the middle of a thumb drag doesn't
// cause the scroller to jump.
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ThumbDragScrollerLengthIncrease) {
LayerTreeSettings settings = DefaultSettings();
settings.compositor_threaded_scrollbar_scrolling = true;
CreateHostImpl(settings, CreateLayerTreeFrameSink());
// Setup the viewport.
const gfx::Size viewport_size = gfx::Size(360, 600);
const gfx::Size content_size = gfx::Size(345, 3800);
SetupViewportLayersOuterScrolls(viewport_size, content_size);
LayerImpl* scroll_layer = OuterViewportScrollLayer();
// Set up the scrollbar and its dimensions.
LayerTreeImpl* layer_tree_impl = host_impl_->active_tree();
auto* scrollbar = AddLayer<PaintedScrollbarLayerImpl>(
layer_tree_impl, ScrollbarOrientation::VERTICAL,
/*is_left_side_vertical_scrollbar*/ false,
/*is_overlay*/ false);
// TODO(arakeri): crbug.com/1070063 Setting the dimensions for scrollbar parts
// (like thumb, track etc) should be moved to SetupScrollbarLayer.
SetupScrollbarLayer(scroll_layer, scrollbar);
const gfx::Size scrollbar_size = gfx::Size(15, 600);
scrollbar->SetBounds(scrollbar_size);
// Set up the thumb dimensions.
scrollbar->SetThumbThickness(15);
scrollbar->SetThumbLength(50);
scrollbar->SetTrackRect(gfx::Rect(0, 15, 15, 575));
// Set up scrollbar arrows.
scrollbar->SetBackButtonRect(
gfx::Rect(gfx::Point(345, 0), gfx::Size(15, 15)));
scrollbar->SetForwardButtonRect(
gfx::Rect(gfx::Point(345, 570), gfx::Size(15, 15)));
scrollbar->SetOffsetToTransformParent(gfx::Vector2dF(345, 0));
TestInputHandlerClient input_handler_client;
GetInputHandler().BindToClient(&input_handler_client);
// ----------------------------- Start frame 0 -----------------------------
viz::BeginFrameArgs begin_frame_args =
viz::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, 0, 1);
base::TimeTicks start_time = base::TimeTicks() + base::Milliseconds(200);
begin_frame_args.frame_time = start_time;
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
InputHandlerPointerResult result = GetInputHandler().MouseDown(
gfx::PointF(350, 18), /*jump_key_modifier*/ false);
EXPECT_EQ(result.scroll_delta.y(), 0);
EXPECT_EQ(result.type, PointerResultType::kScrollbarScroll);
host_impl_->DidFinishImplFrame(begin_frame_args);
// ----------------------------- Start frame 1 -----------------------------
begin_frame_args.frame_time = start_time + base::Milliseconds(250);
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
result = GetInputHandler().MouseMoveAt(gfx::Point(350, 20));
EXPECT_FLOAT_EQ(result.scroll_delta.y(), 12.190476f);
// This is intentional. The thumb drags that follow will test the behavior
// *after* the scroller length expansion.
scrollbar->SetScrollLayerLength(7000);
host_impl_->DidFinishImplFrame(begin_frame_args);
// ----------------------------- Start frame 2 -----------------------------
// The very first mousemove after the scroller length change will result in a
// zero offset. This is done to ensure that the scroller doesn't jump ahead
// when the length changes mid thumb drag. So, every time the scroller length
// changes mid thumb drag, a GSU is lost (in the worst case).
begin_frame_args.frame_time = start_time + base::Milliseconds(300);
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
result = GetInputHandler().MouseMoveAt(gfx::Point(350, 22));
EXPECT_EQ(result.scroll_delta.y(), 0);
host_impl_->DidFinishImplFrame(begin_frame_args);
// ----------------------------- Start frame 3 -----------------------------
// All subsequent mousemoves then produce deltas which are "displaced" by a
// certain amount. The previous mousemove (to y = 22) would have calculated
// the drag_state_->scroller_displacement value as 48 (based on the pointer
// movement). The current pointermove (to y = 26) calculates the delta as 97.
// Since delta -= drag_state_->scroller_displacement, the actual delta becomes
// 97 - 48 which is 49. The math that calculates the deltas (i.e 97 and 48)
// can be found in ScrollbarController::GetScrollDeltaForDragPosition.
begin_frame_args.frame_time = start_time + base::Milliseconds(350);
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
result = GetInputHandler().MouseMoveAt(gfx::Point(350, 26));
EXPECT_FLOAT_EQ(result.scroll_delta.y(), 48.761906f);
GetInputHandler().MouseUp(gfx::PointF(350, 26));
host_impl_->DidFinishImplFrame(begin_frame_args);
// Tear down the LayerTreeHostImpl before the InputHandlerClient.
host_impl_->ReleaseLayerTreeFrameSink();
host_impl_ = nullptr;
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, MainThreadFallback) {
LayerTreeSettings settings = DefaultSettings();
settings.compositor_threaded_scrollbar_scrolling = true;
CreateHostImpl(settings, CreateLayerTreeFrameSink());
// Setup the viewport.
const gfx::Size viewport_size = gfx::Size(360, 600);
const gfx::Size content_size = gfx::Size(345, 3800);
SetupViewportLayersOuterScrolls(viewport_size, content_size);
LayerImpl* scroll_layer = OuterViewportScrollLayer();
// Set up the scrollbar and its dimensions.
LayerTreeImpl* layer_tree_impl = host_impl_->active_tree();
auto* scrollbar = AddLayer<PaintedScrollbarLayerImpl>(
layer_tree_impl, ScrollbarOrientation::VERTICAL, false, true);
SetupScrollbarLayer(scroll_layer, scrollbar);
const gfx::Size scrollbar_size = gfx::Size(15, 600);
scrollbar->SetBounds(scrollbar_size);
// Set up the thumb dimensions.
scrollbar->SetThumbThickness(15);
scrollbar->SetThumbLength(50);
scrollbar->SetTrackRect(gfx::Rect(0, 15, 15, 575));
// Set up scrollbar arrows.
scrollbar->SetBackButtonRect(
gfx::Rect(gfx::Point(345, 0), gfx::Size(15, 15)));
scrollbar->SetForwardButtonRect(
gfx::Rect(gfx::Point(345, 570), gfx::Size(15, 15)));
scrollbar->SetOffsetToTransformParent(gfx::Vector2dF(345, 0));
TestInputHandlerClient input_handler_client;
GetInputHandler().BindToClient(&input_handler_client);
// Clicking on the track should produce a scroll on the compositor thread.
InputHandlerPointerResult compositor_threaded_scrolling_result =
GetInputHandler().MouseDown(gfx::PointF(350, 500),
/*jump_key_modifier*/ false);
GetInputHandler().MouseUp(gfx::PointF(350, 500));
EXPECT_EQ(compositor_threaded_scrolling_result.scroll_delta.y(), 525u);
EXPECT_FALSE(GetScrollNode(scroll_layer)->main_thread_scrolling_reasons);
// If the scroll_node has a main_thread_scrolling_reason, the
// InputHandlerPointerResult should return a zero offset. This will cause the
// main thread to handle the scroll.
GetScrollNode(scroll_layer)->main_thread_scrolling_reasons =
MainThreadScrollingReason::kThreadedScrollingDisabled;
compositor_threaded_scrolling_result = GetInputHandler().MouseDown(
gfx::PointF(350, 500), /*jump_key_modifier*/ false);
GetInputHandler().MouseUp(gfx::PointF(350, 500));
EXPECT_EQ(compositor_threaded_scrolling_result.scroll_delta.y(), 0u);
// Tear down the LayerTreeHostImpl before the InputHandlerClient.
host_impl_->ReleaseLayerTreeFrameSink();
host_impl_ = nullptr;
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
SecondScrollAnimatedBeginNotIgnored) {
const gfx::Size content_size(1000, 1000);
const gfx::Size viewport_size(50, 100);
SetupViewportLayersOuterScrolls(viewport_size, content_size);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), gfx::Vector2dF(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
GetInputHandler().ScrollEnd();
// The second ScrollBegin should not get ignored.
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), gfx::Vector2dF(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
}
// Verfify that a smooth scroll animation doesn't jump when UpdateTarget gets
// called before the animation is started.
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
AnimatedScrollUpdateTargetBeforeStarting) {
const gfx::Size content_size(1000, 1000);
const gfx::Size viewport_size(50, 100);
SetupViewportLayersOuterScrolls(viewport_size, content_size);
DrawFrame();
base::TimeTicks start_time = base::TimeTicks() + base::Milliseconds(200);
viz::BeginFrameArgs begin_frame_args =
viz::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, 0, 1);
begin_frame_args.frame_time = start_time;
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->UpdateAnimationState(true);
host_impl_->DidFinishImplFrame(begin_frame_args);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), gfx::Vector2d(0, 50),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
GetInputHandler().ScrollUpdate(
AnimatedUpdateState(gfx::Point(), gfx::Vector2d(0, 50)).get());
// This will call ScrollOffsetAnimationCurve::UpdateTarget while the animation
// created above is in state ANIMATION::WAITING_FOR_TARGET_AVAILABILITY and
// doesn't have a start time.
GetInputHandler().ScrollUpdate(
AnimatedUpdateState(gfx::Point(), gfx::Vector2d(0, 100)).get());
begin_frame_args.frame_time = start_time + base::Milliseconds(250);
begin_frame_args.frame_id.sequence_number++;
// This is when the animation above gets promoted to STARTING.
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->UpdateAnimationState(true);
host_impl_->DidFinishImplFrame(begin_frame_args);
begin_frame_args.frame_time = start_time + base::Milliseconds(300);
begin_frame_args.frame_id.sequence_number++;
// This is when the animation above gets ticked.
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->UpdateAnimationState(true);
host_impl_->DidFinishImplFrame(begin_frame_args);
LayerImpl* scrolling_layer = OuterViewportScrollLayer();
EXPECT_EQ(scrolling_layer->scroll_tree_index(),
host_impl_->CurrentlyScrollingNode()->id);
// Verify no jump.
float y = CurrentScrollOffset(scrolling_layer).y();
if (features::IsImpulseScrollAnimationEnabled()) {
// Impulse scroll animation is faster than non-impulse, which results in a
// traveled distance larger than the original 50px.
EXPECT_TRUE(y > 50 && y < 100);
} else {
EXPECT_TRUE(y > 1 && y < 49);
}
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, ScrollAnimatedWithDelay) {
const gfx::Size content_size(1000, 1000);
const gfx::Size viewport_size(50, 100);
SetupViewportLayersOuterScrolls(viewport_size, content_size);
DrawFrame();
base::TimeTicks start_time = base::TimeTicks() + base::Milliseconds(100);
viz::BeginFrameArgs begin_frame_args =
viz::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, 0, 1);
// Create animation with a 100ms delay.
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), gfx::Vector2d(0, 100),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
GetInputHandler().ScrollUpdate(
AnimatedUpdateState(gfx::Point(), gfx::Vector2d(0, 100)).get(),
base::Milliseconds(100));
LayerImpl* scrolling_layer = OuterViewportScrollLayer();
EXPECT_EQ(scrolling_layer->scroll_tree_index(),
host_impl_->CurrentlyScrollingNode()->id);
// First tick, animation is started.
begin_frame_args.frame_time = start_time;
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->UpdateAnimationState(true);
EXPECT_NE(gfx::PointF(), CurrentScrollOffset(scrolling_layer));
host_impl_->DidFinishImplFrame(begin_frame_args);
// Second tick after 50ms, animation should be half way done since the
// duration due to delay is 100ms. Subtract off the frame interval since we
// progress a full frame on the first tick.
base::TimeTicks half_way_time =
start_time - begin_frame_args.interval + base::Milliseconds(50);
begin_frame_args.frame_time = half_way_time;
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->UpdateAnimationState(true);
EXPECT_NEAR((features::IsImpulseScrollAnimationEnabled() ? 87 : 50),
CurrentScrollOffset(scrolling_layer).y(), 1);
host_impl_->DidFinishImplFrame(begin_frame_args);
// Update target.
GetInputHandler().ScrollUpdate(
AnimatedUpdateState(gfx::Point(), gfx::Vector2d(0, 100)).get(),
base::Milliseconds(150));
// Third tick after 100ms, should be at the target position since update
// target was called with a large value of jank.
begin_frame_args.frame_time = start_time + base::Milliseconds(100);
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->UpdateAnimationState(true);
EXPECT_LT(100, CurrentScrollOffset(scrolling_layer).y());
}
// Test that a smooth scroll offset animation is aborted when followed by a
// non-smooth scroll offset animation.
TEST_F(LayerTreeHostImplTimelinesTest, ScrollAnimatedAborted) {
const gfx::Size content_size(1000, 1000);
const gfx::Size viewport_size(500, 500);
SetupViewportLayersOuterScrolls(viewport_size, content_size);
DrawFrame();
base::TimeTicks start_time = base::TimeTicks() + base::Milliseconds(100);
viz::BeginFrameArgs begin_frame_args =
viz::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, 0, 1);
// Perform animated scroll.
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), gfx::Vector2d(0, 50),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
GetInputHandler().ScrollUpdate(
AnimatedUpdateState(gfx::Point(), gfx::Vector2d(0, 50)).get());
LayerImpl* scrolling_layer = OuterViewportScrollLayer();
EXPECT_EQ(scrolling_layer->scroll_tree_index(),
host_impl_->CurrentlyScrollingNode()->id);
begin_frame_args.frame_time = start_time;
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
host_impl_->UpdateAnimationState(true);
EXPECT_TRUE(GetImplAnimationHost()->HasAnyAnimationTargetingProperty(
scrolling_layer->element_id(), TargetProperty::SCROLL_OFFSET));
EXPECT_NE(gfx::PointF(), CurrentScrollOffset(scrolling_layer));
host_impl_->DidFinishImplFrame(begin_frame_args);
begin_frame_args.frame_time = start_time + base::Milliseconds(50);
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
host_impl_->UpdateAnimationState(true);
float y = CurrentScrollOffset(scrolling_layer).y();
EXPECT_TRUE(y > 1 && y < 49);
GetInputHandler().ScrollEnd();
// Perform instant scroll.
// Use "precise pixel" granularity to avoid animating.
auto begin_state = BeginState(gfx::Point(0, y), gfx::Vector2dF(0, 50),
ui::ScrollInputType::kWheel);
begin_state->data()->delta_granularity =
ui::ScrollGranularity::kScrollByPrecisePixel;
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(begin_state.get(), ui::ScrollInputType::kWheel)
.thread);
auto update_state = UpdateState(gfx::Point(0, y), gfx::Vector2d(0, 50),
ui::ScrollInputType::kWheel);
// Use "precise pixel" granularity to avoid animating.
update_state->data()->delta_granularity =
ui::ScrollGranularity::kScrollByPrecisePixel;
GetInputHandler().ScrollUpdate(update_state.get());
GetInputHandler().ScrollEnd();
// The instant scroll should have marked the smooth scroll animation as
// aborted.
EXPECT_FALSE(GetImplAnimationHost()->HasTickingKeyframeModelForTesting(
scrolling_layer->element_id()));
EXPECT_POINTF_EQ(gfx::PointF(0, y + 50),
CurrentScrollOffset(scrolling_layer));
EXPECT_EQ(nullptr, host_impl_->CurrentlyScrollingNode());
host_impl_->DidFinishImplFrame(begin_frame_args);
}
// Evolved from LayerTreeHostImplTest.ScrollAnimated.
TEST_F(LayerTreeHostImplTimelinesTest, ScrollAnimated) {
const gfx::Size content_size(1000, 1000);
const gfx::Size viewport_size(500, 500);
SetupViewportLayersOuterScrolls(viewport_size, content_size);
DrawFrame();
base::TimeTicks start_time = base::TimeTicks() + base::Milliseconds(100);
viz::BeginFrameArgs begin_frame_args =
viz::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, 0, 1);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), gfx::Vector2d(0, 50),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
GetInputHandler().ScrollUpdate(
AnimatedUpdateState(gfx::Point(), gfx::Vector2d(0, 50)).get());
LayerImpl* scrolling_layer = OuterViewportScrollLayer();
EXPECT_EQ(scrolling_layer->scroll_tree_index(),
host_impl_->CurrentlyScrollingNode()->id);
begin_frame_args.frame_time = start_time;
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
host_impl_->UpdateAnimationState(true);
EXPECT_NE(gfx::PointF(), CurrentScrollOffset(scrolling_layer));
host_impl_->DidFinishImplFrame(begin_frame_args);
begin_frame_args.frame_time = start_time + base::Milliseconds(50);
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
host_impl_->UpdateAnimationState(true);
float y = CurrentScrollOffset(scrolling_layer).y();
EXPECT_TRUE(y > 1 && y < 49);
// Update target.
GetInputHandler().ScrollUpdate(
AnimatedUpdateState(gfx::Point(), gfx::Vector2d(0, 50)).get());
GetInputHandler().ScrollEnd();
host_impl_->DidFinishImplFrame(begin_frame_args);
begin_frame_args.frame_time = start_time + base::Milliseconds(200);
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
host_impl_->UpdateAnimationState(true);
y = CurrentScrollOffset(scrolling_layer).y();
EXPECT_TRUE(y > 50 && y < 100);
EXPECT_EQ(scrolling_layer->scroll_tree_index(),
host_impl_->CurrentlyScrollingNode()->id);
host_impl_->DidFinishImplFrame(begin_frame_args);
begin_frame_args.frame_time = start_time + base::Milliseconds(250);
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
host_impl_->UpdateAnimationState(true);
EXPECT_POINTF_EQ(gfx::PointF(0, 100), CurrentScrollOffset(scrolling_layer));
EXPECT_EQ(nullptr, host_impl_->CurrentlyScrollingNode());
host_impl_->DidFinishImplFrame(begin_frame_args);
}
// Test that the scroll delta for an animated scroll is distributed correctly
// between the inner and outer viewport.
TEST_F(LayerTreeHostImplTimelinesTest, ImplPinchZoomScrollAnimated) {
const gfx::Size content_size(200, 200);
const gfx::Size viewport_size(100, 100);
SetupViewportLayersOuterScrolls(viewport_size, content_size);
UpdateDrawProperties(host_impl_->active_tree());
LayerImpl* outer_scroll_layer = OuterViewportScrollLayer();
LayerImpl* inner_scroll_layer = InnerViewportScrollLayer();
// Zoom into the page by a 2X factor
float min_page_scale = 1, max_page_scale = 4;
float page_scale_factor = 2;
host_impl_->active_tree()->PushPageScaleFromMainThread(
page_scale_factor, min_page_scale, max_page_scale);
host_impl_->active_tree()->SetPageScaleOnActiveTree(page_scale_factor);
// Scroll by a small amount, there should be no bubbling to the outer
// viewport (but scrolling the viewport always sets the outer as the
// currently scrolling node).
base::TimeTicks start_time = base::TimeTicks() + base::Milliseconds(250);
viz::BeginFrameArgs begin_frame_args =
viz::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, 0, 1);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), gfx::Vector2d(10, 20),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
GetInputHandler().ScrollUpdate(
AnimatedUpdateState(gfx::Point(), gfx::Vector2d(10, 20)).get());
host_impl_->Animate();
host_impl_->UpdateAnimationState(true);
EXPECT_EQ(outer_scroll_layer->scroll_tree_index(),
host_impl_->CurrentlyScrollingNode()->id);
begin_frame_args.frame_id.sequence_number++;
BeginImplFrameAndAnimate(begin_frame_args, start_time);
EXPECT_POINTF_EQ(gfx::PointF(5, 10), CurrentScrollOffset(inner_scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(outer_scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(outer_scroll_layer));
// Scroll by the inner viewport's max scroll extent, the remainder
// should bubble up to the outer viewport.
GetInputHandler().ScrollUpdate(
AnimatedUpdateState(gfx::Point(), gfx::Vector2d(100, 100)).get());
host_impl_->Animate();
host_impl_->UpdateAnimationState(true);
EXPECT_EQ(outer_scroll_layer->scroll_tree_index(),
host_impl_->CurrentlyScrollingNode()->id);
begin_frame_args.frame_id.sequence_number++;
BeginImplFrameAndAnimate(begin_frame_args,
start_time + base::Milliseconds(350));
EXPECT_POINTF_EQ(gfx::PointF(50, 50),
CurrentScrollOffset(inner_scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(5, 10), CurrentScrollOffset(outer_scroll_layer));
// Scroll by the outer viewport's max scroll extent, it should all go to the
// outer viewport.
GetInputHandler().ScrollUpdate(
AnimatedUpdateState(gfx::Point(), gfx::Vector2d(190, 180)).get());
host_impl_->Animate();
host_impl_->UpdateAnimationState(true);
EXPECT_EQ(outer_scroll_layer->scroll_tree_index(),
host_impl_->CurrentlyScrollingNode()->id);
begin_frame_args.frame_id.sequence_number++;
BeginImplFrameAndAnimate(begin_frame_args,
start_time + base::Milliseconds(850));
EXPECT_POINTF_EQ(gfx::PointF(50, 50),
CurrentScrollOffset(inner_scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(100, 100),
CurrentScrollOffset(outer_scroll_layer));
// Scroll upwards by the max scroll extent. The inner viewport should animate
// and the remainder should bubble to the outer viewport.
GetInputHandler().ScrollUpdate(
AnimatedUpdateState(gfx::Point(), gfx::Vector2d(-110, -120)).get());
host_impl_->Animate();
host_impl_->UpdateAnimationState(true);
EXPECT_EQ(outer_scroll_layer->scroll_tree_index(),
host_impl_->CurrentlyScrollingNode()->id);
begin_frame_args.frame_id.sequence_number++;
BeginImplFrameAndAnimate(begin_frame_args,
start_time + base::Milliseconds(1200));
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(inner_scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(95, 90),
CurrentScrollOffset(outer_scroll_layer));
}
// Test that the correct viewport scroll layer is updated when the target offset
// is updated.
TEST_F(LayerTreeHostImplTimelinesTest, ImplPinchZoomScrollAnimatedUpdate) {
const gfx::Size content_size(200, 200);
const gfx::Size viewport_size(100, 100);
SetupViewportLayersOuterScrolls(viewport_size, content_size);
LayerImpl* outer_scroll_layer = OuterViewportScrollLayer();
LayerImpl* inner_scroll_layer = InnerViewportScrollLayer();
// Zoom into the page by a 2X factor
float min_page_scale = 1, max_page_scale = 4;
float page_scale_factor = 2;
host_impl_->active_tree()->PushPageScaleFromMainThread(
page_scale_factor, min_page_scale, max_page_scale);
host_impl_->active_tree()->SetPageScaleOnActiveTree(page_scale_factor);
// Scroll the inner viewport.
base::TimeTicks start_time = base::TimeTicks() + base::Milliseconds(50);
viz::BeginFrameArgs begin_frame_args =
viz::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, 0, 1);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), gfx::Vector2d(90, 90),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
GetInputHandler().ScrollUpdate(
AnimatedUpdateState(gfx::Point(), gfx::Vector2d(90, 90)).get());
host_impl_->Animate();
host_impl_->UpdateAnimationState(true);
// When either the inner or outer node is being scrolled, the outer node is
// the one that's "latched".
EXPECT_EQ(outer_scroll_layer->scroll_tree_index(),
host_impl_->CurrentlyScrollingNode()->id);
begin_frame_args.frame_id.sequence_number++;
BeginImplFrameAndAnimate(begin_frame_args, start_time);
float inner_x = CurrentScrollOffset(inner_scroll_layer).x();
float inner_y = CurrentScrollOffset(inner_scroll_layer).y();
EXPECT_TRUE(inner_x > 0 && inner_x < 45);
EXPECT_TRUE(inner_y > 0 && inner_y < 45);
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(outer_scroll_layer));
// Update target.
GetInputHandler().ScrollUpdate(
AnimatedUpdateState(gfx::Point(), gfx::Vector2d(50, 50)).get());
host_impl_->Animate();
host_impl_->UpdateAnimationState(true);
EXPECT_EQ(outer_scroll_layer->scroll_tree_index(),
host_impl_->CurrentlyScrollingNode()->id);
// Verify that all the delta is applied to the inner viewport and nothing is
// carried forward.
begin_frame_args.frame_id.sequence_number++;
BeginImplFrameAndAnimate(begin_frame_args,
start_time + base::Milliseconds(350));
EXPECT_POINTF_EQ(gfx::PointF(50, 50),
CurrentScrollOffset(inner_scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(outer_scroll_layer));
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(outer_scroll_layer));
}
// Test that smooth scroll offset animation doesn't happen for non user
// scrollable layers.
TEST_F(LayerTreeHostImplTimelinesTest, ScrollAnimatedNotUserScrollable) {
const gfx::Size content_size(1000, 1000);
const gfx::Size viewport_size(500, 500);
SetupViewportLayersOuterScrolls(viewport_size, content_size);
LayerImpl* scrolling_layer = OuterViewportScrollLayer();
GetScrollNode(scrolling_layer)->user_scrollable_vertical = true;
GetScrollNode(scrolling_layer)->user_scrollable_horizontal = false;
DrawFrame();
base::TimeTicks start_time = base::TimeTicks() + base::Milliseconds(100);
viz::BeginFrameArgs begin_frame_args =
viz::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, 0, 1);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), gfx::Vector2d(50, 50),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
GetInputHandler().ScrollUpdate(
AnimatedUpdateState(gfx::Point(), gfx::Vector2d(50, 50)).get());
EXPECT_EQ(scrolling_layer->scroll_tree_index(),
host_impl_->CurrentlyScrollingNode()->id);
begin_frame_args.frame_time = start_time;
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
host_impl_->UpdateAnimationState(true);
EXPECT_NE(gfx::PointF(), CurrentScrollOffset(scrolling_layer));
host_impl_->DidFinishImplFrame(begin_frame_args);
begin_frame_args.frame_time = start_time + base::Milliseconds(50);
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
host_impl_->UpdateAnimationState(true);
// Should not have scrolled horizontally.
EXPECT_EQ(0, CurrentScrollOffset(scrolling_layer).x());
float y = CurrentScrollOffset(scrolling_layer).y();
EXPECT_TRUE(y > 1 && y < 49);
// Update target.
GetInputHandler().ScrollUpdate(
AnimatedUpdateState(gfx::Point(), gfx::Vector2d(50, 50)).get());
host_impl_->DidFinishImplFrame(begin_frame_args);
begin_frame_args.frame_time = start_time + base::Milliseconds(200);
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
host_impl_->UpdateAnimationState(true);
y = CurrentScrollOffset(scrolling_layer).y();
EXPECT_TRUE(y > 50 && y < 100);
EXPECT_EQ(scrolling_layer->scroll_tree_index(),
host_impl_->CurrentlyScrollingNode()->id);
host_impl_->DidFinishImplFrame(begin_frame_args);
begin_frame_args.frame_time = start_time + base::Milliseconds(250);
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
host_impl_->UpdateAnimationState(true);
EXPECT_POINTF_EQ(gfx::PointF(0, 100), CurrentScrollOffset(scrolling_layer));
// The CurrentlyScrollingNode shouldn't be cleared until a GestureScrollEnd.
EXPECT_EQ(scrolling_layer->scroll_tree_index(),
host_impl_->CurrentlyScrollingNode()->id);
host_impl_->DidFinishImplFrame(begin_frame_args);
GetInputHandler().ScrollEnd();
EXPECT_EQ(nullptr, host_impl_->CurrentlyScrollingNode());
}
// Test that smooth scrolls clamp correctly when bounds change mid-animation.
TEST_F(LayerTreeHostImplTimelinesTest, ScrollAnimatedChangingBounds) {
const gfx::Size old_content_size(1000, 1000);
const gfx::Size new_content_size(750, 750);
const gfx::Size viewport_size(500, 500);
SetupViewportLayersOuterScrolls(viewport_size, old_content_size);
LayerImpl* scrolling_layer = OuterViewportScrollLayer();
LayerImpl* content_layer = AddContentLayer();
DrawFrame();
base::TimeTicks start_time = base::TimeTicks() + base::Milliseconds(100);
viz::BeginFrameArgs begin_frame_args =
viz::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, 0, 1);
GetInputHandler().ScrollBegin(
BeginState(gfx::Point(), gfx::Vector2d(500, 500),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
GetInputHandler().ScrollUpdate(
AnimatedUpdateState(gfx::Point(), gfx::Vector2d(500, 500)).get());
EXPECT_EQ(scrolling_layer->scroll_tree_index(),
host_impl_->CurrentlyScrollingNode()->id);
begin_frame_args.frame_time = start_time;
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
host_impl_->UpdateAnimationState(true);
host_impl_->DidFinishImplFrame(begin_frame_args);
content_layer->SetBounds(new_content_size);
scrolling_layer->SetBounds(new_content_size);
GetScrollNode(scrolling_layer)->bounds = new_content_size;
begin_frame_args.frame_time = start_time + base::Milliseconds(200);
begin_frame_args.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->Animate();
host_impl_->UpdateAnimationState(true);
host_impl_->DidFinishImplFrame(begin_frame_args);
EXPECT_EQ(gfx::PointF(250, 250), CurrentScrollOffset(scrolling_layer));
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, InvalidLayerNotAddedToRasterQueue) {
CreatePendingTree();
Region empty_invalidation;
scoped_refptr<RasterSource> raster_source_with_tiles(
FakeRasterSource::CreateFilled(gfx::Size(10, 10)));
auto* layer = SetupRootLayer<FakePictureLayerImpl>(host_impl_->pending_tree(),
gfx::Size(10, 10));
layer->set_gpu_raster_max_texture_size(
host_impl_->active_tree()->GetDeviceViewport().size());
layer->SetDrawsContent(true);
layer->tilings()->AddTiling(gfx::AxisTransform2d(), raster_source_with_tiles);
layer->UpdateRasterSource(raster_source_with_tiles, &empty_invalidation,
nullptr, nullptr);
layer->tilings()->tiling_at(0)->set_resolution(
TileResolution::HIGH_RESOLUTION);
layer->tilings()->tiling_at(0)->CreateAllTilesForTesting();
layer->tilings()->UpdateTilePriorities(gfx::Rect(gfx::Size(10, 10)), 1, 1.0,
Occlusion(), true);
layer->set_has_valid_tile_priorities(true);
std::unique_ptr<RasterTilePriorityQueue> non_empty_raster_priority_queue_all =
host_impl_->BuildRasterQueue(TreePriority::SAME_PRIORITY_FOR_BOTH_TREES,
RasterTilePriorityQueue::Type::ALL);
EXPECT_FALSE(non_empty_raster_priority_queue_all->IsEmpty());
layer->set_has_valid_tile_priorities(false);
std::unique_ptr<RasterTilePriorityQueue> empty_raster_priority_queue_all =
host_impl_->BuildRasterQueue(TreePriority::SAME_PRIORITY_FOR_BOTH_TREES,
RasterTilePriorityQueue::Type::ALL);
EXPECT_TRUE(empty_raster_priority_queue_all->IsEmpty());
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, DidBecomeActive) {
CreatePendingTree();
host_impl_->ActivateSyncTree();
CreatePendingTree();
LayerTreeImpl* pending_tree = host_impl_->pending_tree();
auto* pending_layer =
SetupRootLayer<FakePictureLayerImpl>(pending_tree, gfx::Size(10, 10));
EXPECT_EQ(0u, pending_layer->did_become_active_call_count());
pending_tree->DidBecomeActive();
EXPECT_EQ(1u, pending_layer->did_become_active_call_count());
std::unique_ptr<FakePictureLayerImpl> mask_layer =
FakePictureLayerImpl::Create(pending_tree, next_layer_id_++);
FakePictureLayerImpl* raw_mask_layer = mask_layer.get();
SetupMaskProperties(pending_layer, raw_mask_layer);
pending_tree->AddLayer(std::move(mask_layer));
EXPECT_EQ(1u, pending_layer->did_become_active_call_count());
EXPECT_EQ(0u, raw_mask_layer->did_become_active_call_count());
pending_tree->DidBecomeActive();
EXPECT_EQ(2u, pending_layer->did_become_active_call_count());
EXPECT_EQ(1u, raw_mask_layer->did_become_active_call_count());
EXPECT_EQ(2u, pending_layer->did_become_active_call_count());
EXPECT_EQ(1u, raw_mask_layer->did_become_active_call_count());
pending_tree->DidBecomeActive();
EXPECT_EQ(3u, pending_layer->did_become_active_call_count());
EXPECT_EQ(2u, raw_mask_layer->did_become_active_call_count());
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
WheelScrollWithPageScaleFactorOnInnerLayer) {
SetupViewportLayersInnerScrolls(gfx::Size(50, 50), gfx::Size(100, 100));
auto* scroll_layer = InnerViewportScrollLayer();
host_impl_->active_tree()->SetDeviceViewportRect(gfx::Rect(50, 50));
DrawFrame();
EXPECT_EQ(scroll_layer, InnerViewportScrollLayer());
float min_page_scale = 1, max_page_scale = 4;
float page_scale_factor = 1;
// The scroll deltas should have the page scale factor applied.
{
host_impl_->active_tree()->PushPageScaleFromMainThread(
page_scale_factor, min_page_scale, max_page_scale);
host_impl_->active_tree()->SetPageScaleOnActiveTree(page_scale_factor);
SetScrollOffsetDelta(scroll_layer, gfx::Vector2d());
float page_scale_delta = 2;
GetInputHandler().ScrollBegin(BeginState(gfx::Point(), gfx::Vector2dF(),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
GetInputHandler().PinchGestureBegin(gfx::Point(),
ui::ScrollInputType::kWheel);
GetInputHandler().PinchGestureUpdate(page_scale_delta, gfx::Point());
GetInputHandler().PinchGestureEnd(gfx::Point());
GetInputHandler().ScrollEnd();
gfx::Vector2dF scroll_delta(0, 5);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), scroll_delta,
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
EXPECT_POINTF_EQ(gfx::PointF(0, 0), CurrentScrollOffset(scroll_layer));
GetInputHandler().ScrollUpdate(
UpdateState(gfx::Point(), scroll_delta, ui::ScrollInputType::kWheel)
.get());
GetInputHandler().ScrollEnd();
EXPECT_POINTF_EQ(gfx::PointF(0, 2.5), CurrentScrollOffset(scroll_layer));
}
}
class LayerTreeHostImplCountingLostSurfaces : public LayerTreeHostImplTest {
public:
void DidLoseLayerTreeFrameSinkOnImplThread() override {
num_lost_surfaces_++;
}
protected:
int num_lost_surfaces_ = 0;
};
// We do not want to reset context recovery state when we get repeated context
// loss notifications via different paths.
TEST_F(LayerTreeHostImplCountingLostSurfaces, TwiceLostSurface) {
EXPECT_EQ(0, num_lost_surfaces_);
host_impl_->DidLoseLayerTreeFrameSink();
EXPECT_EQ(1, num_lost_surfaces_);
host_impl_->DidLoseLayerTreeFrameSink();
EXPECT_EQ(1, num_lost_surfaces_);
}
size_t CountRenderPassesWithId(const viz::CompositorRenderPassList& list,
viz::CompositorRenderPassId id) {
return base::ranges::count(list, id, &viz::CompositorRenderPass::id);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, RemoveUnreferencedRenderPass) {
TestFrameData frame;
frame.render_passes.push_back(viz::CompositorRenderPass::Create());
viz::CompositorRenderPass* pass3 = frame.render_passes.back().get();
frame.render_passes.push_back(viz::CompositorRenderPass::Create());
viz::CompositorRenderPass* pass2 = frame.render_passes.back().get();
frame.render_passes.push_back(viz::CompositorRenderPass::Create());
viz::CompositorRenderPass* pass1 = frame.render_passes.back().get();
pass1->SetNew(viz::CompositorRenderPassId{1}, gfx::Rect(), gfx::Rect(),
gfx::Transform());
pass2->SetNew(viz::CompositorRenderPassId{2}, gfx::Rect(), gfx::Rect(),
gfx::Transform());
pass3->SetNew(viz::CompositorRenderPassId{3}, gfx::Rect(), gfx::Rect(),
gfx::Transform());
// Add a quad to each pass so they aren't empty.
auto* color_quad = pass1->CreateAndAppendDrawQuad<viz::SolidColorDrawQuad>();
color_quad->material = viz::DrawQuad::Material::kSolidColor;
color_quad = pass2->CreateAndAppendDrawQuad<viz::SolidColorDrawQuad>();
color_quad->material = viz::DrawQuad::Material::kSolidColor;
color_quad = pass3->CreateAndAppendDrawQuad<viz::SolidColorDrawQuad>();
color_quad->material = viz::DrawQuad::Material::kSolidColor;
// pass3 is referenced by pass2.
auto* rpdq =
pass2->CreateAndAppendDrawQuad<viz::CompositorRenderPassDrawQuad>();
rpdq->material = viz::DrawQuad::Material::kCompositorRenderPass;
rpdq->render_pass_id = pass3->id;
// But pass2 is not referenced by pass1. So pass2 and pass3 should be culled.
FakeLayerTreeHostImpl::RemoveRenderPasses(&frame);
EXPECT_EQ(1u, frame.render_passes.size());
EXPECT_EQ(1u, CountRenderPassesWithId(frame.render_passes,
viz::CompositorRenderPassId{1u}));
EXPECT_EQ(0u, CountRenderPassesWithId(frame.render_passes,
viz::CompositorRenderPassId{2u}));
EXPECT_EQ(0u, CountRenderPassesWithId(frame.render_passes,
viz::CompositorRenderPassId{3u}));
EXPECT_EQ(viz::CompositorRenderPassId{1u}, frame.render_passes[0]->id);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, RemoveEmptyRenderPass) {
TestFrameData frame;
frame.render_passes.push_back(viz::CompositorRenderPass::Create());
viz::CompositorRenderPass* pass3 = frame.render_passes.back().get();
frame.render_passes.push_back(viz::CompositorRenderPass::Create());
viz::CompositorRenderPass* pass2 = frame.render_passes.back().get();
frame.render_passes.push_back(viz::CompositorRenderPass::Create());
viz::CompositorRenderPass* pass1 = frame.render_passes.back().get();
pass1->SetNew(viz::CompositorRenderPassId{1}, gfx::Rect(), gfx::Rect(),
gfx::Transform());
pass2->SetNew(viz::CompositorRenderPassId{2}, gfx::Rect(), gfx::Rect(),
gfx::Transform());
pass3->SetNew(viz::CompositorRenderPassId{3}, gfx::Rect(), gfx::Rect(),
gfx::Transform());
// pass1 is not empty, but pass2 and pass3 are.
auto* color_quad = pass1->CreateAndAppendDrawQuad<viz::SolidColorDrawQuad>();
color_quad->material = viz::DrawQuad::Material::kSolidColor;
// pass3 is referenced by pass2.
auto* rpdq =
pass2->CreateAndAppendDrawQuad<viz::CompositorRenderPassDrawQuad>();
rpdq->material = viz::DrawQuad::Material::kCompositorRenderPass;
rpdq->render_pass_id = pass3->id;
// pass2 is referenced by pass1.
rpdq = pass1->CreateAndAppendDrawQuad<viz::CompositorRenderPassDrawQuad>();
rpdq->material = viz::DrawQuad::Material::kCompositorRenderPass;
rpdq->render_pass_id = pass2->id;
// Since pass3 is empty it should be removed. Then pass2 is empty too, and
// should be removed.
FakeLayerTreeHostImpl::RemoveRenderPasses(&frame);
EXPECT_EQ(1u, frame.render_passes.size());
EXPECT_EQ(1u, CountRenderPassesWithId(frame.render_passes,
viz::CompositorRenderPassId{1u}));
EXPECT_EQ(0u, CountRenderPassesWithId(frame.render_passes,
viz::CompositorRenderPassId{2u}));
EXPECT_EQ(0u, CountRenderPassesWithId(frame.render_passes,
viz::CompositorRenderPassId{3u}));
EXPECT_EQ(viz::CompositorRenderPassId{1u}, frame.render_passes[0]->id);
// The viz::CompositorRenderPassDrawQuad should be removed from pass1.
EXPECT_EQ(1u, pass1->quad_list.size());
EXPECT_EQ(viz::DrawQuad::Material::kSolidColor,
pass1->quad_list.ElementAt(0)->material);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, DoNotRemoveEmptyRootRenderPass) {
TestFrameData frame;
frame.render_passes.push_back(viz::CompositorRenderPass::Create());
viz::CompositorRenderPass* pass3 = frame.render_passes.back().get();
frame.render_passes.push_back(viz::CompositorRenderPass::Create());
viz::CompositorRenderPass* pass2 = frame.render_passes.back().get();
frame.render_passes.push_back(viz::CompositorRenderPass::Create());
viz::CompositorRenderPass* pass1 = frame.render_passes.back().get();
pass1->SetNew(viz::CompositorRenderPassId{1}, gfx::Rect(), gfx::Rect(),
gfx::Transform());
pass2->SetNew(viz::CompositorRenderPassId{2}, gfx::Rect(), gfx::Rect(),
gfx::Transform());
pass3->SetNew(viz::CompositorRenderPassId{3}, gfx::Rect(), gfx::Rect(),
gfx::Transform());
// pass3 is referenced by pass2.
auto* rpdq =
pass2->CreateAndAppendDrawQuad<viz::CompositorRenderPassDrawQuad>();
rpdq->material = viz::DrawQuad::Material::kCompositorRenderPass;
rpdq->render_pass_id = pass3->id;
// pass2 is referenced by pass1.
rpdq = pass1->CreateAndAppendDrawQuad<viz::CompositorRenderPassDrawQuad>();
rpdq->material = viz::DrawQuad::Material::kCompositorRenderPass;
rpdq->render_pass_id = pass2->id;
// Since pass3 is empty it should be removed. Then pass2 is empty too, and
// should be removed. Then pass1 is empty too, but it's the root so it should
// not be removed.
FakeLayerTreeHostImpl::RemoveRenderPasses(&frame);
EXPECT_EQ(1u, frame.render_passes.size());
EXPECT_EQ(1u, CountRenderPassesWithId(frame.render_passes,
viz::CompositorRenderPassId{1u}));
EXPECT_EQ(0u, CountRenderPassesWithId(frame.render_passes,
viz::CompositorRenderPassId{2u}));
EXPECT_EQ(0u, CountRenderPassesWithId(frame.render_passes,
viz::CompositorRenderPassId{3u}));
EXPECT_EQ(viz::CompositorRenderPassId{1u}, frame.render_passes[0]->id);
// The viz::CompositorRenderPassDrawQuad should be removed from pass1.
EXPECT_EQ(0u, pass1->quad_list.size());
}
class FakeVideoFrameController : public VideoFrameController {
public:
void OnBeginFrame(const viz::BeginFrameArgs& args) override {
begin_frame_args_ = args;
did_draw_frame_ = false;
}
void DidDrawFrame() override { did_draw_frame_ = true; }
const viz::BeginFrameArgs& begin_frame_args() const {
return begin_frame_args_;
}
bool did_draw_frame() const { return did_draw_frame_; }
private:
viz::BeginFrameArgs begin_frame_args_;
bool did_draw_frame_ = false;
};
TEST_P(ScrollUnifiedLayerTreeHostImplTest, AddVideoFrameControllerInsideFrame) {
viz::BeginFrameArgs begin_frame_args =
viz::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, 0, 2);
FakeVideoFrameController controller;
host_impl_->WillBeginImplFrame(begin_frame_args);
EXPECT_FALSE(controller.begin_frame_args().IsValid());
host_impl_->AddVideoFrameController(&controller);
EXPECT_TRUE(controller.begin_frame_args().IsValid());
host_impl_->DidFinishImplFrame(begin_frame_args);
EXPECT_FALSE(controller.did_draw_frame());
TestFrameData frame;
host_impl_->DidDrawAllLayers(frame);
EXPECT_TRUE(controller.did_draw_frame());
controller.OnBeginFrame(begin_frame_args);
EXPECT_FALSE(controller.did_draw_frame());
host_impl_->RemoveVideoFrameController(&controller);
host_impl_->DidDrawAllLayers(frame);
EXPECT_FALSE(controller.did_draw_frame());
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
AddVideoFrameControllerOutsideFrame) {
viz::BeginFrameArgs begin_frame_args =
viz::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, 0, 2);
FakeVideoFrameController controller;
host_impl_->WillBeginImplFrame(begin_frame_args);
host_impl_->DidFinishImplFrame(begin_frame_args);
EXPECT_FALSE(controller.begin_frame_args().IsValid());
host_impl_->AddVideoFrameController(&controller);
EXPECT_FALSE(controller.begin_frame_args().IsValid());
begin_frame_args =
viz::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, 0, 3);
EXPECT_FALSE(controller.begin_frame_args().IsValid());
host_impl_->WillBeginImplFrame(begin_frame_args);
EXPECT_TRUE(controller.begin_frame_args().IsValid());
EXPECT_FALSE(controller.did_draw_frame());
TestFrameData frame;
host_impl_->DidDrawAllLayers(frame);
EXPECT_TRUE(controller.did_draw_frame());
controller.OnBeginFrame(begin_frame_args);
EXPECT_FALSE(controller.did_draw_frame());
host_impl_->RemoveVideoFrameController(&controller);
host_impl_->DidDrawAllLayers(frame);
EXPECT_FALSE(controller.did_draw_frame());
}
class GpuRasterizationDisabledLayerTreeHostImplTest
: public LayerTreeHostImplTest {
public:
std::unique_ptr<LayerTreeFrameSink> CreateLayerTreeFrameSink() override {
return FakeLayerTreeFrameSink::Create3d();
}
};
class MsaaIsSlowLayerTreeHostImplTest : public LayerTreeHostImplTest {
public:
void CreateHostImplWithCaps(bool msaa_is_slow, bool avoid_stencil_buffers) {
LayerTreeSettings settings = DefaultSettings();
settings.gpu_rasterization_msaa_sample_count = 4;
auto frame_sink =
FakeLayerTreeFrameSink::Builder()
.AllContexts(&viz::TestGLES2Interface::set_msaa_is_slow,
&viz::TestRasterInterface::set_msaa_is_slow,
msaa_is_slow)
.AllContexts(&viz::TestGLES2Interface::set_gpu_rasterization,
&viz::TestRasterInterface::set_gpu_rasterization, true)
.AllContexts(&viz::TestGLES2Interface::set_avoid_stencil_buffers,
&viz::TestRasterInterface::set_avoid_stencil_buffers,
avoid_stencil_buffers)
.Build();
EXPECT_TRUE(CreateHostImpl(settings, std::move(frame_sink)));
}
};
TEST_F(MsaaIsSlowLayerTreeHostImplTest, GpuRasterizationStatusMsaaIsSlow) {
// Ensure that without the msaa_is_slow or avoid_stencil_buffers caps
// we raster slow paths with msaa.
CreateHostImplWithCaps(false, false);
host_impl_->CommitComplete();
EXPECT_TRUE(host_impl_->use_gpu_rasterization());
EXPECT_TRUE(host_impl_->can_use_msaa());
// Ensure that with either msaa_is_slow or avoid_stencil_buffers caps
// we don't raster slow paths with msaa (we'll still use GPU raster, though).
// msaa_is_slow = true, avoid_stencil_buffers = false
CreateHostImplWithCaps(true, false);
host_impl_->CommitComplete();
EXPECT_TRUE(host_impl_->use_gpu_rasterization());
EXPECT_FALSE(host_impl_->can_use_msaa());
// msaa_is_slow = false, avoid_stencil_buffers = true
CreateHostImplWithCaps(false, true);
host_impl_->CommitComplete();
EXPECT_TRUE(host_impl_->use_gpu_rasterization());
EXPECT_FALSE(host_impl_->can_use_msaa());
// msaa_is_slow = true, avoid_stencil_buffers = true
CreateHostImplWithCaps(true, true);
host_impl_->CommitComplete();
EXPECT_TRUE(host_impl_->use_gpu_rasterization());
EXPECT_FALSE(host_impl_->can_use_msaa());
}
class MsaaCompatibilityLayerTreeHostImplTest : public LayerTreeHostImplTest {
public:
void CreateHostImplWithMultisampleCompatibility(
bool support_multisample_compatibility) {
LayerTreeSettings settings = DefaultSettings();
settings.gpu_rasterization_msaa_sample_count = 4;
auto frame_sink =
FakeLayerTreeFrameSink::Builder()
.AllContexts(
&viz::TestGLES2Interface::set_support_multisample_compatibility,
&viz::TestRasterInterface::set_multisample_compatibility,
support_multisample_compatibility)
.AllContexts(&viz::TestGLES2Interface::set_gpu_rasterization,
&viz::TestRasterInterface::set_gpu_rasterization, true)
.Build();
EXPECT_TRUE(CreateHostImpl(settings, std::move(frame_sink)));
}
};
TEST_F(MsaaCompatibilityLayerTreeHostImplTest,
GpuRasterizationStatusNonAAPaint) {
// Always use a recording with slow paths so the toggle is dependent on non aa
// paint.
auto recording_source = FakeRecordingSource::CreateRecordingSource(
gfx::Rect(100, 100), gfx::Size(100, 100));
recording_source->set_has_slow_paths(true);
// Ensure that without non-aa paint and without multisample compatibility, we
// raster slow paths with msaa.
CreateHostImplWithMultisampleCompatibility(false);
recording_source->set_has_non_aa_paint(false);
recording_source->Rerecord();
EXPECT_TRUE(host_impl_->can_use_msaa());
EXPECT_GT(host_impl_->GetMSAASampleCountForRaster(
recording_source->GetDisplayItemList()),
0);
// Ensure that without non-aa paint and with multisample compatibility, we
// raster slow paths with msaa.
CreateHostImplWithMultisampleCompatibility(true);
recording_source->set_has_non_aa_paint(false);
recording_source->Rerecord();
EXPECT_TRUE(host_impl_->can_use_msaa());
EXPECT_GT(host_impl_->GetMSAASampleCountForRaster(
recording_source->GetDisplayItemList()),
0);
// Ensure that with non-aa paint and without multisample compatibility, we do
// not raster slow paths with msaa.
CreateHostImplWithMultisampleCompatibility(false);
recording_source->set_has_non_aa_paint(true);
recording_source->Rerecord();
EXPECT_TRUE(host_impl_->can_use_msaa());
EXPECT_EQ(host_impl_->GetMSAASampleCountForRaster(
recording_source->GetDisplayItemList()),
0);
// Ensure that with non-aa paint and with multisample compatibility, we raster
// slow paths with msaa.
CreateHostImplWithMultisampleCompatibility(true);
recording_source->set_has_non_aa_paint(true);
recording_source->Rerecord();
EXPECT_TRUE(host_impl_->can_use_msaa());
EXPECT_GT(host_impl_->GetMSAASampleCountForRaster(
recording_source->GetDisplayItemList()),
0);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, UpdatePageScaleFactorOnActiveTree) {
// Check page scale factor updates the property trees when an update is made
// on the active tree.
CreatePendingTree();
host_impl_->pending_tree()->PushPageScaleFromMainThread(1, 1, 3);
SetupViewportLayers(host_impl_->pending_tree(), gfx::Size(50, 50),
gfx::Size(100, 100), gfx::Size(100, 100));
host_impl_->ActivateSyncTree();
DrawFrame();
CreatePendingTree();
host_impl_->active_tree()->SetPageScaleOnActiveTree(2);
TransformNode* active_tree_node =
host_impl_->active_tree()->PageScaleTransformNode();
// SetPageScaleOnActiveTree also updates the factors in property trees.
EXPECT_TRUE(active_tree_node->local.IsScale2d());
EXPECT_EQ(gfx::Vector2dF(2, 2), active_tree_node->local.To2dScale());
EXPECT_EQ(gfx::Point3F(), active_tree_node->origin);
EXPECT_EQ(2, host_impl_->active_tree()->current_page_scale_factor());
EXPECT_EQ(2, host_impl_->active_tree()
->property_trees()
->transform_tree()
.page_scale_factor());
TransformNode* pending_tree_node =
host_impl_->pending_tree()->PageScaleTransformNode();
// Since the pending tree shares the scale factor with the active tree, its
// value and property trees should also have been updated.
EXPECT_TRUE(pending_tree_node->local.IsScale2d());
EXPECT_EQ(gfx::Vector2dF(2, 2), pending_tree_node->local.To2dScale());
EXPECT_EQ(gfx::Point3F(), pending_tree_node->origin);
EXPECT_EQ(2, host_impl_->pending_tree()->current_page_scale_factor());
EXPECT_EQ(2, host_impl_->pending_tree()
->property_trees()
->transform_tree()
.page_scale_factor());
// Update draw properties doesn't change the correct values
host_impl_->pending_tree()->set_needs_update_draw_properties();
UpdateDrawProperties(host_impl_->pending_tree());
pending_tree_node = host_impl_->pending_tree()->PageScaleTransformNode();
EXPECT_TRUE(pending_tree_node->local.IsScale2d());
EXPECT_EQ(gfx::Vector2dF(2, 2), pending_tree_node->local.To2dScale());
EXPECT_EQ(gfx::Point3F(), pending_tree_node->origin);
host_impl_->ActivateSyncTree();
UpdateDrawProperties(host_impl_->active_tree());
active_tree_node = host_impl_->active_tree()->PageScaleTransformNode();
EXPECT_TRUE(active_tree_node->local.IsScale2d());
EXPECT_EQ(gfx::Vector2dF(2, 2), active_tree_node->local.To2dScale());
EXPECT_EQ(gfx::Point3F(), active_tree_node->origin);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
SubLayerScaleForNodeInSubtreeOfPageScaleLayer) {
// Checks that the sublayer scale of a transform node in the subtree of the
// page scale layer is updated without a property tree rebuild.
host_impl_->active_tree()->PushPageScaleFromMainThread(1, 1, 3);
SetupViewportLayersInnerScrolls(gfx::Size(50, 50), gfx::Size(100, 100));
LayerImpl* in_subtree_of_page_scale_layer = AddLayer();
CopyProperties(root_layer(), in_subtree_of_page_scale_layer);
in_subtree_of_page_scale_layer->SetTransformTreeIndex(
host_impl_->active_tree()->PageScaleTransformNode()->id);
CreateEffectNode(in_subtree_of_page_scale_layer).render_surface_reason =
RenderSurfaceReason::kTest;
DrawFrame();
EffectNode* node = GetEffectNode(in_subtree_of_page_scale_layer);
EXPECT_EQ(node->surface_contents_scale, gfx::Vector2dF(1, 1));
host_impl_->active_tree()->SetPageScaleOnActiveTree(2);
DrawFrame();
node = GetEffectNode(in_subtree_of_page_scale_layer);
EXPECT_EQ(node->surface_contents_scale, gfx::Vector2dF(2, 2));
}
// Checks that if we lose a GPU raster enabled LayerTreeFrameSink and replace
// it with a software LayerTreeFrameSink, LayerTreeHostImpl correctly
// re-computes GPU rasterization status.
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
RecomputeGpuRasterOnLayerTreeFrameSinkChange) {
host_impl_->ReleaseLayerTreeFrameSink();
host_impl_ = nullptr;
host_impl_ = LayerTreeHostImpl::Create(
DefaultSettings(), this, &task_runner_provider_, &stats_instrumentation_,
&task_graph_runner_,
AnimationHost::CreateForTesting(ThreadInstance::IMPL), nullptr, 0,
nullptr, nullptr);
InputHandler::Create(static_cast<CompositorDelegateForInput&>(*host_impl_));
host_impl_->SetVisible(true);
// InitializeFrameSink with a gpu-raster enabled output surface.
auto gpu_raster_layer_tree_frame_sink =
FakeLayerTreeFrameSink::Create3dForGpuRasterization();
host_impl_->InitializeFrameSink(gpu_raster_layer_tree_frame_sink.get());
EXPECT_TRUE(host_impl_->use_gpu_rasterization());
// Re-initialize with a software output surface.
layer_tree_frame_sink_ = FakeLayerTreeFrameSink::CreateSoftware();
host_impl_->InitializeFrameSink(layer_tree_frame_sink_.get());
EXPECT_FALSE(host_impl_->use_gpu_rasterization());
}
void LayerTreeHostImplTest::SetupMouseMoveAtTestScrollbarStates(
bool main_thread_scrolling) {
LayerTreeSettings settings = DefaultSettings();
settings.scrollbar_fade_delay = base::Milliseconds(500);
settings.scrollbar_fade_duration = base::Milliseconds(300);
settings.scrollbar_animator = LayerTreeSettings::AURA_OVERLAY;
const int thumb_thickness = 15;
gfx::Size viewport_size(300, 200);
gfx::Size content_size(1000, 1000);
gfx::Size child_layer_size(250, 150);
gfx::Size scrollbar_size_1(
gfx::Size(thumb_thickness, viewport_size.height()));
gfx::Size scrollbar_size_2(
gfx::Size(thumb_thickness, child_layer_size.height()));
CreateHostImpl(settings, CreateLayerTreeFrameSink());
host_impl_->active_tree()->SetDeviceScaleFactor(1);
SetupViewportLayersInnerScrolls(viewport_size, content_size);
LayerImpl* root_scroll = OuterViewportScrollLayer();
if (main_thread_scrolling) {
GetScrollNode(root_scroll)->main_thread_scrolling_reasons =
MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects;
}
// scrollbar_1 on root scroll.
auto* scrollbar_1 = AddLayer<SolidColorScrollbarLayerImpl>(
host_impl_->active_tree(), ScrollbarOrientation::VERTICAL,
thumb_thickness, 0, true);
SetupScrollbarLayer(root_scroll, scrollbar_1);
scrollbar_1->SetBounds(scrollbar_size_1);
TouchActionRegion touch_action_region;
touch_action_region.Union(TouchAction::kNone, gfx::Rect(scrollbar_size_1));
scrollbar_1->SetTouchActionRegion(touch_action_region);
host_impl_->active_tree()->UpdateScrollbarGeometries();
host_impl_->active_tree()->DidBecomeActive();
DrawFrame();
ScrollbarAnimationController* scrollbar_1_animation_controller =
host_impl_->ScrollbarAnimationControllerForElementId(
root_scroll->element_id());
EXPECT_TRUE(scrollbar_1_animation_controller);
const float kMouseMoveDistanceToTriggerFadeIn =
scrollbar_1_animation_controller
->GetScrollbarAnimationController(ScrollbarOrientation::VERTICAL)
.MouseMoveDistanceToTriggerFadeIn();
const float kMouseMoveDistanceToTriggerExpand =
scrollbar_1_animation_controller
->GetScrollbarAnimationController(ScrollbarOrientation::VERTICAL)
.MouseMoveDistanceToTriggerExpand();
// Mouse moves close to the scrollbar, goes over the scrollbar, and
// moves back to where it was.
GetInputHandler().MouseMoveAt(
gfx::Point(thumb_thickness + kMouseMoveDistanceToTriggerFadeIn + 1, 0));
EXPECT_FALSE(scrollbar_1_animation_controller->MouseIsNearScrollbar(
ScrollbarOrientation::VERTICAL));
EXPECT_FALSE(scrollbar_1_animation_controller->MouseIsNearScrollbarThumb(
ScrollbarOrientation::VERTICAL));
EXPECT_FALSE(scrollbar_1_animation_controller->MouseIsOverScrollbarThumb(
ScrollbarOrientation::VERTICAL));
GetInputHandler().MouseMoveAt(
gfx::Point(thumb_thickness + kMouseMoveDistanceToTriggerExpand + 1, 0));
EXPECT_TRUE(scrollbar_1_animation_controller->MouseIsNearScrollbar(
ScrollbarOrientation::VERTICAL));
EXPECT_FALSE(scrollbar_1_animation_controller->MouseIsNearScrollbarThumb(
ScrollbarOrientation::VERTICAL));
EXPECT_FALSE(scrollbar_1_animation_controller->MouseIsOverScrollbarThumb(
ScrollbarOrientation::VERTICAL));
GetInputHandler().MouseMoveAt(
gfx::Point(thumb_thickness + kMouseMoveDistanceToTriggerExpand, 0));
EXPECT_TRUE(scrollbar_1_animation_controller->MouseIsNearScrollbar(
ScrollbarOrientation::VERTICAL));
EXPECT_TRUE(scrollbar_1_animation_controller->MouseIsNearScrollbarThumb(
ScrollbarOrientation::VERTICAL));
EXPECT_FALSE(scrollbar_1_animation_controller->MouseIsOverScrollbarThumb(
ScrollbarOrientation::VERTICAL));
GetInputHandler().MouseMoveAt(gfx::Point(10, 0));
EXPECT_TRUE(scrollbar_1_animation_controller->MouseIsNearScrollbar(
ScrollbarOrientation::VERTICAL));
EXPECT_TRUE(scrollbar_1_animation_controller->MouseIsNearScrollbarThumb(
ScrollbarOrientation::VERTICAL));
EXPECT_TRUE(scrollbar_1_animation_controller->MouseIsOverScrollbarThumb(
ScrollbarOrientation::VERTICAL));
GetInputHandler().MouseMoveAt(
gfx::Point(thumb_thickness + kMouseMoveDistanceToTriggerExpand, 0));
EXPECT_TRUE(scrollbar_1_animation_controller->MouseIsNearScrollbar(
ScrollbarOrientation::VERTICAL));
EXPECT_TRUE(scrollbar_1_animation_controller->MouseIsNearScrollbarThumb(
ScrollbarOrientation::VERTICAL));
EXPECT_FALSE(scrollbar_1_animation_controller->MouseIsOverScrollbarThumb(
ScrollbarOrientation::VERTICAL));
GetInputHandler().MouseMoveAt(
gfx::Point(thumb_thickness + kMouseMoveDistanceToTriggerExpand + 1, 0));
EXPECT_TRUE(scrollbar_1_animation_controller->MouseIsNearScrollbar(
ScrollbarOrientation::VERTICAL));
EXPECT_FALSE(scrollbar_1_animation_controller->MouseIsNearScrollbarThumb(
ScrollbarOrientation::VERTICAL));
EXPECT_FALSE(scrollbar_1_animation_controller->MouseIsOverScrollbarThumb(
ScrollbarOrientation::VERTICAL));
GetInputHandler().MouseMoveAt(
gfx::Point(thumb_thickness + kMouseMoveDistanceToTriggerFadeIn + 1, 0));
EXPECT_FALSE(scrollbar_1_animation_controller->MouseIsNearScrollbar(
ScrollbarOrientation::VERTICAL));
EXPECT_FALSE(scrollbar_1_animation_controller->MouseIsNearScrollbarThumb(
ScrollbarOrientation::VERTICAL));
EXPECT_FALSE(scrollbar_1_animation_controller->MouseIsOverScrollbarThumb(
ScrollbarOrientation::VERTICAL));
// scrollbar_2 on child.
auto* scrollbar_2 = AddLayer<SolidColorScrollbarLayerImpl>(
host_impl_->active_tree(), ScrollbarOrientation::VERTICAL,
thumb_thickness, 0, true);
LayerImpl* child =
AddScrollableLayer(root_scroll, gfx::Size(100, 100), child_layer_size);
child->SetOffsetToTransformParent(gfx::Vector2dF(50, 50));
if (main_thread_scrolling) {
GetScrollNode(child)->main_thread_scrolling_reasons =
MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects;
}
SetupScrollbarLayer(child, scrollbar_2);
scrollbar_2->SetBounds(scrollbar_size_2);
scrollbar_2->SetOffsetToTransformParent(child->offset_to_transform_parent());
UpdateDrawProperties(host_impl_->active_tree());
host_impl_->active_tree()->UpdateScrollbarGeometries();
host_impl_->active_tree()->DidBecomeActive();
ScrollbarAnimationController* scrollbar_2_animation_controller =
host_impl_->ScrollbarAnimationControllerForElementId(child->element_id());
EXPECT_TRUE(scrollbar_2_animation_controller);
// Mouse goes over scrollbar_2, moves close to scrollbar_2, moves close to
// scrollbar_1, goes over scrollbar_1.
GetInputHandler().MouseMoveAt(gfx::Point(60, 60));
EXPECT_FALSE(scrollbar_1_animation_controller->MouseIsNearScrollbar(
ScrollbarOrientation::VERTICAL));
EXPECT_FALSE(scrollbar_1_animation_controller->MouseIsNearScrollbarThumb(
ScrollbarOrientation::VERTICAL));
EXPECT_FALSE(scrollbar_1_animation_controller->MouseIsOverScrollbarThumb(
ScrollbarOrientation::VERTICAL));
EXPECT_TRUE(scrollbar_2_animation_controller->MouseIsNearScrollbar(
ScrollbarOrientation::VERTICAL));
EXPECT_TRUE(scrollbar_2_animation_controller->MouseIsNearScrollbarThumb(
ScrollbarOrientation::VERTICAL));
EXPECT_TRUE(scrollbar_2_animation_controller->MouseIsOverScrollbarThumb(
ScrollbarOrientation::VERTICAL));
GetInputHandler().MouseMoveAt(
gfx::Point(50 + thumb_thickness + kMouseMoveDistanceToTriggerExpand, 50));
EXPECT_FALSE(scrollbar_1_animation_controller->MouseIsNearScrollbar(
ScrollbarOrientation::VERTICAL));
EXPECT_FALSE(scrollbar_1_animation_controller->MouseIsNearScrollbarThumb(
ScrollbarOrientation::VERTICAL));
EXPECT_FALSE(scrollbar_1_animation_controller->MouseIsOverScrollbarThumb(
ScrollbarOrientation::VERTICAL));
EXPECT_TRUE(scrollbar_2_animation_controller->MouseIsNearScrollbar(
ScrollbarOrientation::VERTICAL));
EXPECT_TRUE(scrollbar_2_animation_controller->MouseIsNearScrollbarThumb(
ScrollbarOrientation::VERTICAL));
EXPECT_FALSE(scrollbar_2_animation_controller->MouseIsOverScrollbarThumb(
ScrollbarOrientation::VERTICAL));
GetInputHandler().MouseMoveAt(
gfx::Point(thumb_thickness + kMouseMoveDistanceToTriggerExpand, 0));
EXPECT_TRUE(scrollbar_1_animation_controller->MouseIsNearScrollbar(
ScrollbarOrientation::VERTICAL));
EXPECT_TRUE(scrollbar_1_animation_controller->MouseIsNearScrollbarThumb(
ScrollbarOrientation::VERTICAL));
EXPECT_FALSE(scrollbar_1_animation_controller->MouseIsOverScrollbarThumb(
ScrollbarOrientation::VERTICAL));
EXPECT_FALSE(scrollbar_2_animation_controller->MouseIsNearScrollbar(
ScrollbarOrientation::VERTICAL));
EXPECT_FALSE(scrollbar_2_animation_controller->MouseIsNearScrollbarThumb(
ScrollbarOrientation::VERTICAL));
EXPECT_FALSE(scrollbar_2_animation_controller->MouseIsOverScrollbarThumb(
ScrollbarOrientation::VERTICAL));
GetInputHandler().MouseMoveAt(gfx::Point(10, 0));
EXPECT_TRUE(scrollbar_1_animation_controller->MouseIsNearScrollbar(
ScrollbarOrientation::VERTICAL));
EXPECT_TRUE(scrollbar_1_animation_controller->MouseIsNearScrollbarThumb(
ScrollbarOrientation::VERTICAL));
EXPECT_TRUE(scrollbar_1_animation_controller->MouseIsOverScrollbarThumb(
ScrollbarOrientation::VERTICAL));
EXPECT_FALSE(scrollbar_2_animation_controller->MouseIsNearScrollbar(
ScrollbarOrientation::VERTICAL));
EXPECT_FALSE(scrollbar_2_animation_controller->MouseIsNearScrollbarThumb(
ScrollbarOrientation::VERTICAL));
EXPECT_FALSE(scrollbar_2_animation_controller->MouseIsOverScrollbarThumb(
ScrollbarOrientation::VERTICAL));
// Capture scrollbar_1, then move mouse to scrollbar_2's layer);
animation_task_.Reset();
// Only the MouseMove's location will affect the overlay scrollbar.
GetInputHandler().MouseDown(gfx::PointF(60, 50), /*jump_key_modifier*/ false);
GetInputHandler().MouseMoveAt(gfx::Point(60, 50));
GetInputHandler().MouseUp(gfx::PointF(60, 50));
EXPECT_FALSE(animation_task_.is_null());
// Near scrollbar_1, then mouse down and up, should not post an event to fade
// out scrollbar_1.
GetInputHandler().MouseMoveAt(gfx::Point(40, 150));
animation_task_.Reset();
GetInputHandler().MouseDown(gfx::PointF(40, 150),
/*jump_key_modifier*/ false);
GetInputHandler().MouseUp(gfx::PointF(40, 150));
EXPECT_TRUE(animation_task_.is_null());
// Near scrollbar_1, then mouse down and unregister
// scrollbar_2_animation_controller, then mouse up should not cause crash.
GetInputHandler().MouseMoveAt(gfx::Point(40, 150));
GetInputHandler().MouseDown(gfx::PointF(40, 150),
/*jump_key_modifier*/ false);
host_impl_->DidUnregisterScrollbarLayer(root_scroll->element_id(),
ScrollbarOrientation::VERTICAL);
GetInputHandler().MouseUp(gfx::PointF(40, 150));
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
LayerTreeHostImplTestScrollbarStatesInMainThreadScrolling) {
SetupMouseMoveAtTestScrollbarStates(true);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
LayerTreeHostImplTestScrollbarStatesInNotMainThreadScrolling) {
SetupMouseMoveAtTestScrollbarStates(false);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, CheckerImagingTileInvalidation) {
LayerTreeSettings settings = LegacySWSettings();
settings.commit_to_active_tree = false;
settings.enable_checker_imaging = true;
settings.min_image_bytes_to_checker = 512 * 1024;
settings.default_tile_size = gfx::Size(256, 256);
settings.max_untiled_layer_size = gfx::Size(256, 256);
CreateHostImpl(settings, CreateLayerTreeFrameSink());
gfx::Size layer_size = gfx::Size(750, 750);
std::unique_ptr<FakeRecordingSource> recording_source =
FakeRecordingSource::CreateFilledRecordingSource(layer_size);
PaintImage checkerable_image =
PaintImageBuilder::WithCopy(
CreateDiscardablePaintImage(gfx::Size(500, 500)))
.set_decoding_mode(PaintImage::DecodingMode::kAsync)
.TakePaintImage();
recording_source->add_draw_image(checkerable_image, gfx::Point(0, 0));
SkColor non_solid_color = SkColorSetARGB(128, 45, 56, 67);
PaintFlags non_solid_flags;
non_solid_flags.setColor(non_solid_color);
recording_source->add_draw_rect_with_flags(gfx::Rect(510, 0, 200, 600),
non_solid_flags);
recording_source->add_draw_rect_with_flags(gfx::Rect(0, 510, 200, 400),
non_solid_flags);
recording_source->Rerecord();
scoped_refptr<RasterSource> raster_source =
recording_source->CreateRasterSource();
viz::BeginFrameArgs begin_frame_args =
viz::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, 0, 1);
host_impl_->WillBeginImplFrame(begin_frame_args);
// Create the pending tree.
host_impl_->BeginCommit(0, /*trace_id=*/1);
LayerTreeImpl* pending_tree = host_impl_->pending_tree();
auto* root = SetupRootLayer<FakePictureLayerImpl>(pending_tree, layer_size,
raster_source);
root->SetDrawsContent(true);
UpdateDrawProperties(pending_tree);
// Update the decoding state map for the tracker so it knows the correct
// decoding preferences for the image.
host_impl_->tile_manager()->checker_image_tracker().UpdateImageDecodingHints(
raster_source->TakeDecodingModeMap());
// CompleteCommit which should perform a PrepareTiles, adding tilings for the
// root layer, each one having a raster task.
host_impl_->CommitComplete();
EXPECT_EQ(root->num_tilings(), 1U);
const PictureLayerTiling* tiling = root->tilings()->tiling_at(0);
EXPECT_EQ(tiling->AllTilesForTesting().size(), 9U);
for (auto* tile : tiling->AllTilesForTesting())
EXPECT_TRUE(tile->HasRasterTask());
// Activate the pending tree and ensure that all tiles are rasterized.
while (!did_notify_ready_to_activate_)
base::RunLoop().RunUntilIdle();
for (auto* tile : tiling->AllTilesForTesting())
EXPECT_FALSE(tile->HasRasterTask());
// PrepareTiles should have scheduled a decode with the ImageDecodeService,
// ensure that it requests an impl-side invalidation.
while (!did_request_impl_side_invalidation_)
base::RunLoop().RunUntilIdle();
// Invalidate content on impl-side and ensure that the correct tiles are
// invalidated on the pending tree.
host_impl_->InvalidateContentOnImplSide();
pending_tree = host_impl_->pending_tree();
root = static_cast<FakePictureLayerImpl*>(pending_tree->root_layer());
for (auto* tile : root->tilings()->tiling_at(0)->AllTilesForTesting()) {
if (tile->tiling_i_index() < 2 && tile->tiling_j_index() < 2)
EXPECT_TRUE(tile->HasRasterTask());
else
EXPECT_FALSE(tile->HasRasterTask());
}
const auto expected_invalidation =
ImageRectsToRegion(raster_source->GetDisplayItemList()
->discardable_image_map()
.GetRectsForImage(checkerable_image.stable_id()));
EXPECT_EQ(expected_invalidation, *(root->GetPendingInvalidation()));
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, RasterColorSpace) {
LayerTreeSettings settings = DefaultSettings();
CreateHostImpl(settings, CreateLayerTreeFrameSink());
// The default raster color space should be sRGB.
auto wcg_params =
host_impl_->GetTargetColorParams(gfx::ContentColorUsage::kWideColorGamut);
EXPECT_EQ(wcg_params.color_space, gfx::ColorSpace::CreateSRGB());
// The raster color space should update with tree activation.
host_impl_->active_tree()->SetDisplayColorSpaces(
gfx::DisplayColorSpaces(gfx::ColorSpace::CreateDisplayP3D65()));
wcg_params =
host_impl_->GetTargetColorParams(gfx::ContentColorUsage::kWideColorGamut);
EXPECT_EQ(wcg_params.color_space, gfx::ColorSpace::CreateDisplayP3D65());
EXPECT_EQ(wcg_params.sdr_max_luminance_nits,
gfx::ColorSpace::kDefaultSDRWhiteLevel);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, RasterColorSpaceSoftware) {
LayerTreeSettings settings = DefaultSettings();
CreateHostImpl(settings, FakeLayerTreeFrameSink::CreateSoftware());
// Software composited resources should always use sRGB as their color space.
auto wcg_params =
host_impl_->GetTargetColorParams(gfx::ContentColorUsage::kWideColorGamut);
EXPECT_EQ(wcg_params.color_space, gfx::ColorSpace::CreateSRGB());
host_impl_->active_tree()->SetDisplayColorSpaces(
gfx::DisplayColorSpaces(gfx::ColorSpace::CreateDisplayP3D65()));
wcg_params =
host_impl_->GetTargetColorParams(gfx::ContentColorUsage::kWideColorGamut);
EXPECT_EQ(wcg_params.color_space, gfx::ColorSpace::CreateSRGB());
EXPECT_EQ(wcg_params.sdr_max_luminance_nits,
gfx::ColorSpace::kDefaultSDRWhiteLevel);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, RasterColorPrefersSRGB) {
auto p3 = gfx::ColorSpace::CreateDisplayP3D65();
LayerTreeSettings settings = DefaultSettings();
settings.prefer_raster_in_srgb = true;
CreateHostImpl(settings, CreateLayerTreeFrameSink());
host_impl_->active_tree()->SetDisplayColorSpaces(gfx::DisplayColorSpaces(p3));
auto srgb_params =
host_impl_->GetTargetColorParams(gfx::ContentColorUsage::kSRGB);
EXPECT_EQ(srgb_params.color_space, gfx::ColorSpace::CreateSRGB());
settings.prefer_raster_in_srgb = false;
CreateHostImpl(settings, CreateLayerTreeFrameSink());
host_impl_->active_tree()->SetDisplayColorSpaces(gfx::DisplayColorSpaces(p3));
srgb_params = host_impl_->GetTargetColorParams(gfx::ContentColorUsage::kSRGB);
EXPECT_EQ(srgb_params.color_space, p3);
EXPECT_EQ(srgb_params.sdr_max_luminance_nits,
gfx::ColorSpace::kDefaultSDRWhiteLevel);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, RasterColorSpaceHDR) {
constexpr float kCustomWhiteLevel = 200.f;
constexpr float kHDRMaxLuminanceRelative = 2.f;
auto hdr = gfx::ColorSpace::CreateHDR10();
gfx::DisplayColorSpaces display_cs(hdr);
display_cs.SetSDRMaxLuminanceNits(kCustomWhiteLevel);
display_cs.SetHDRMaxLuminanceRelative(kHDRMaxLuminanceRelative);
LayerTreeSettings settings = DefaultSettings();
CreateHostImpl(settings, CreateLayerTreeFrameSink());
host_impl_->active_tree()->SetDisplayColorSpaces(display_cs);
const auto srgb_params =
host_impl_->GetTargetColorParams(gfx::ContentColorUsage::kSRGB);
const auto wcg_params =
host_impl_->GetTargetColorParams(gfx::ContentColorUsage::kWideColorGamut);
const auto hdr_params =
host_impl_->GetTargetColorParams(gfx::ContentColorUsage::kHDR);
// Non-HDR content should be rasterized in P3.
EXPECT_EQ(srgb_params.color_space, gfx::ColorSpace::CreateDisplayP3D65());
EXPECT_EQ(srgb_params.sdr_max_luminance_nits, kCustomWhiteLevel);
EXPECT_EQ(srgb_params.hdr_max_luminance_relative, 1.f);
EXPECT_EQ(wcg_params.color_space, gfx::ColorSpace::CreateDisplayP3D65());
EXPECT_EQ(wcg_params.sdr_max_luminance_nits, kCustomWhiteLevel);
EXPECT_EQ(wcg_params.hdr_max_luminance_relative, 1.f);
EXPECT_EQ(hdr_params.color_space, gfx::ColorSpace::CreateExtendedSRGB());
EXPECT_EQ(hdr_params.sdr_max_luminance_nits, kCustomWhiteLevel);
EXPECT_EQ(hdr_params.hdr_max_luminance_relative, kHDRMaxLuminanceRelative);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, UpdatedTilingsForNonDrawingLayers) {
gfx::Size layer_bounds(500, 500);
CreatePendingTree();
auto* root =
SetupRootLayer<LayerImpl>(host_impl_->pending_tree(), layer_bounds);
scoped_refptr<FakeRasterSource> raster_source(
FakeRasterSource::CreateFilled(layer_bounds));
auto* animated_transform_layer =
AddLayer<FakePictureLayerImpl>(host_impl_->pending_tree(), raster_source);
animated_transform_layer->SetBounds(layer_bounds);
animated_transform_layer->SetDrawsContent(true);
host_impl_->pending_tree()->SetElementIdsForTesting();
gfx::Transform singular;
singular.Scale3d(6, 6, 0);
CopyProperties(root, animated_transform_layer);
CreateTransformNode(animated_transform_layer).local = singular;
// A layer with a non-invertible transform is not drawn or rasterized. Since
// this layer is not rasterized, we shouldn't be creating any tilings for it.
UpdateDrawProperties(host_impl_->pending_tree());
EXPECT_FALSE(animated_transform_layer->HasValidTilePriorities());
EXPECT_EQ(animated_transform_layer->tilings()->num_tilings(), 0u);
UpdateDrawProperties(host_impl_->pending_tree());
EXPECT_FALSE(animated_transform_layer->raster_even_if_not_drawn());
EXPECT_FALSE(animated_transform_layer->contributes_to_drawn_render_surface());
EXPECT_EQ(animated_transform_layer->tilings()->num_tilings(), 0u);
// Now add a transform animation to this layer. While we don't drawn layers
// with non-invertible transforms, we still raster them if there is a
// transform animation.
gfx::TransformOperations start_transform_operations;
start_transform_operations.AppendMatrix(singular);
gfx::TransformOperations end_transform_operations;
AddAnimatedTransformToElementWithAnimation(
animated_transform_layer->element_id(), timeline(), 10.0,
start_transform_operations, end_transform_operations);
// The layer is still not drawn, but it will be rasterized. Since the layer is
// rasterized, we should be creating tilings for it in UpdateDrawProperties.
// However, none of these tiles should be required for activation.
UpdateDrawProperties(host_impl_->pending_tree());
EXPECT_TRUE(animated_transform_layer->raster_even_if_not_drawn());
EXPECT_FALSE(animated_transform_layer->contributes_to_drawn_render_surface());
ASSERT_EQ(animated_transform_layer->tilings()->num_tilings(), 1u);
EXPECT_FALSE(animated_transform_layer->tilings()
->tiling_at(0)
->can_require_tiles_for_activation());
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
RasterTilePrioritizationForNonDrawingLayers) {
gfx::Size layer_bounds(500, 500);
CreatePendingTree();
auto* root =
SetupRootLayer<LayerImpl>(host_impl_->pending_tree(), layer_bounds);
root->SetBounds(layer_bounds);
scoped_refptr<FakeRasterSource> raster_source(
FakeRasterSource::CreateFilled(layer_bounds));
auto* hidden_layer =
AddLayer<FakePictureLayerImpl>(host_impl_->pending_tree(), raster_source);
hidden_layer->SetBounds(layer_bounds);
hidden_layer->SetDrawsContent(true);
hidden_layer->set_contributes_to_drawn_render_surface(true);
CopyProperties(root, hidden_layer);
auto* drawing_layer =
AddLayer<FakePictureLayerImpl>(host_impl_->pending_tree(), raster_source);
drawing_layer->SetBounds(layer_bounds);
drawing_layer->SetDrawsContent(true);
drawing_layer->set_contributes_to_drawn_render_surface(true);
CopyProperties(root, drawing_layer);
gfx::Rect layer_rect(0, 0, 500, 500);
hidden_layer->tilings()->AddTiling(gfx::AxisTransform2d(), raster_source);
PictureLayerTiling* hidden_tiling = hidden_layer->tilings()->tiling_at(0);
hidden_tiling->set_resolution(TileResolution::LOW_RESOLUTION);
hidden_tiling->CreateAllTilesForTesting();
hidden_tiling->SetTilePriorityRectsForTesting(
layer_rect, // Visible rect.
layer_rect, // Skewport rect.
layer_rect, // Soon rect.
layer_rect); // Eventually rect.
drawing_layer->tilings()->AddTiling(gfx::AxisTransform2d(), raster_source);
PictureLayerTiling* drawing_tiling = drawing_layer->tilings()->tiling_at(0);
drawing_tiling->set_resolution(TileResolution::HIGH_RESOLUTION);
drawing_tiling->CreateAllTilesForTesting();
drawing_tiling->SetTilePriorityRectsForTesting(
layer_rect, // Visible rect.
layer_rect, // Skewport rect.
layer_rect, // Soon rect.
layer_rect); // Eventually rect.
// Both layers are drawn. Since the hidden layer has a low resolution tiling,
// in smoothness priority mode its tile is higher priority.
std::unique_ptr<RasterTilePriorityQueue> queue =
host_impl_->BuildRasterQueue(TreePriority::SMOOTHNESS_TAKES_PRIORITY,
RasterTilePriorityQueue::Type::ALL);
EXPECT_EQ(queue->Top().tile()->layer_id(), 2);
// Hide the hidden layer and set it to so it still rasters. Now the drawing
// layer should be prioritized over the hidden layer.
hidden_layer->set_contributes_to_drawn_render_surface(false);
hidden_layer->set_raster_even_if_not_drawn(true);
queue = host_impl_->BuildRasterQueue(TreePriority::SMOOTHNESS_TAKES_PRIORITY,
RasterTilePriorityQueue::Type::ALL);
EXPECT_EQ(queue->Top().tile()->layer_id(), 3);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, DrawAfterDroppingTileResources) {
LayerTreeSettings settings = DefaultSettings();
settings.using_synchronous_renderer_compositor = true;
CreateHostImpl(settings, CreateLayerTreeFrameSink());
CreatePendingTree();
gfx::Size bounds(100, 100);
scoped_refptr<FakeRasterSource> raster_source(
FakeRasterSource::CreateFilled(bounds));
auto* root = SetupRootLayer<FakePictureLayerImpl>(host_impl_->pending_tree(),
bounds, raster_source);
root->SetDrawsContent(true);
host_impl_->ActivateSyncTree();
FakePictureLayerImpl* layer = static_cast<FakePictureLayerImpl*>(
host_impl_->active_tree()->FindActiveTreeLayerById(root->id()));
DrawFrame();
EXPECT_FALSE(host_impl_->active_tree()->needs_update_draw_properties());
EXPECT_LT(0, layer->raster_page_scale());
EXPECT_GT(layer->tilings()->num_tilings(), 0u);
const ManagedMemoryPolicy policy = host_impl_->ActualManagedMemoryPolicy();
const ManagedMemoryPolicy zero_policy(0u);
host_impl_->SetMemoryPolicy(zero_policy);
EXPECT_EQ(0, layer->raster_page_scale());
EXPECT_EQ(layer->tilings()->num_tilings(), 0u);
host_impl_->SetMemoryPolicy(policy);
DrawFrame();
EXPECT_LT(0, layer->raster_page_scale());
EXPECT_GT(layer->tilings()->num_tilings(), 0u);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, AllowedTouchActionTest1) {
AllowedTouchActionTestHelper(1.0f, 1.0f);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, AllowedTouchActionTest2) {
AllowedTouchActionTestHelper(1.0f, 0.789f);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, AllowedTouchActionTest3) {
AllowedTouchActionTestHelper(2.345f, 1.0f);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, AllowedTouchActionTest4) {
AllowedTouchActionTestHelper(2.654f, 0.678f);
}
// Test implementation of RenderFrameMetadataObserver which can optionally
// request the frame-token to be sent to the embedder during frame submission.
class TestRenderFrameMetadataObserver : public RenderFrameMetadataObserver {
public:
explicit TestRenderFrameMetadataObserver(bool increment_counter)
: increment_counter_(increment_counter) {}
TestRenderFrameMetadataObserver(const TestRenderFrameMetadataObserver&) =
delete;
~TestRenderFrameMetadataObserver() override {}
TestRenderFrameMetadataObserver& operator=(
const TestRenderFrameMetadataObserver&) = delete;
void BindToCurrentSequence() override {}
void OnRenderFrameSubmission(
const RenderFrameMetadata& render_frame_metadata,
viz::CompositorFrameMetadata* compositor_frame_metadata,
bool force_send) override {
if (increment_counter_)
compositor_frame_metadata->send_frame_token_to_embedder = true;
last_metadata_ = render_frame_metadata;
}
const absl::optional<RenderFrameMetadata>& last_metadata() const {
return last_metadata_;
}
private:
bool increment_counter_;
absl::optional<RenderFrameMetadata> last_metadata_;
};
TEST_P(ScrollUnifiedLayerTreeHostImplTest, RenderFrameMetadata) {
SetupViewportLayersInnerScrolls(gfx::Size(50, 50), gfx::Size(100, 100));
host_impl_->active_tree()->SetDeviceViewportRect(gfx::Rect(50, 50));
host_impl_->active_tree()->PushPageScaleFromMainThread(1, 0.5f, 4);
{
// Check initial metadata is correct.
RenderFrameMetadata metadata = StartDrawAndProduceRenderFrameMetadata();
EXPECT_EQ(gfx::PointF(), metadata.root_scroll_offset);
EXPECT_EQ(1, metadata.page_scale_factor);
#if BUILDFLAG(IS_ANDROID)
EXPECT_EQ(gfx::SizeF(50, 50), metadata.scrollable_viewport_size);
EXPECT_EQ(0.5f, metadata.min_page_scale_factor);
EXPECT_EQ(4, metadata.max_page_scale_factor);
EXPECT_EQ(gfx::SizeF(100, 100), metadata.root_layer_size);
EXPECT_FALSE(metadata.root_overflow_y_hidden);
#endif
}
// Scrolling should update metadata immediately.
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), gfx::Vector2dF(0, 10),
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel)
.thread);
GetInputHandler().ScrollUpdate(UpdateState(gfx::Point(), gfx::Vector2d(0, 10),
ui::ScrollInputType::kWheel)
.get());
{
RenderFrameMetadata metadata = StartDrawAndProduceRenderFrameMetadata();
EXPECT_EQ(gfx::PointF(0, 10), metadata.root_scroll_offset);
}
GetInputHandler().ScrollEnd();
{
RenderFrameMetadata metadata = StartDrawAndProduceRenderFrameMetadata();
EXPECT_EQ(gfx::PointF(0, 10), metadata.root_scroll_offset);
}
#if BUILDFLAG(IS_ANDROID)
// Root "overflow: hidden" properties should be reflected on the outer
// viewport scroll layer.
{
UpdateDrawProperties(host_impl_->active_tree());
host_impl_->OuterViewportScrollNode()->user_scrollable_horizontal = false;
RenderFrameMetadata metadata = StartDrawAndProduceRenderFrameMetadata();
EXPECT_FALSE(metadata.root_overflow_y_hidden);
}
{
UpdateDrawProperties(host_impl_->active_tree());
host_impl_->OuterViewportScrollNode()->user_scrollable_vertical = false;
RenderFrameMetadata metadata = StartDrawAndProduceRenderFrameMetadata();
EXPECT_TRUE(metadata.root_overflow_y_hidden);
}
// Re-enable scrollability and verify that overflows are no longer
// hidden.
{
UpdateDrawProperties(host_impl_->active_tree());
host_impl_->OuterViewportScrollNode()->user_scrollable_horizontal = true;
host_impl_->OuterViewportScrollNode()->user_scrollable_vertical = true;
RenderFrameMetadata metadata = StartDrawAndProduceRenderFrameMetadata();
EXPECT_FALSE(metadata.root_overflow_y_hidden);
}
// Root "overflow: hidden" properties should also be reflected on the
// inner viewport scroll layer.
{
UpdateDrawProperties(host_impl_->active_tree());
host_impl_->OuterViewportScrollNode()->user_scrollable_horizontal = false;
RenderFrameMetadata metadata = StartDrawAndProduceRenderFrameMetadata();
EXPECT_FALSE(metadata.root_overflow_y_hidden);
}
{
UpdateDrawProperties(host_impl_->active_tree());
host_impl_->OuterViewportScrollNode()->user_scrollable_vertical = false;
RenderFrameMetadata metadata = StartDrawAndProduceRenderFrameMetadata();
EXPECT_TRUE(metadata.root_overflow_y_hidden);
}
#endif
// Page scale should update metadata correctly (shrinking only the viewport).
GetInputHandler().ScrollBegin(BeginState(gfx::Point(), gfx::Vector2dF(),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
GetInputHandler().PinchGestureBegin(gfx::Point(),
ui::ScrollInputType::kWheel);
GetInputHandler().PinchGestureUpdate(2, gfx::Point());
GetInputHandler().PinchGestureEnd(gfx::Point());
GetInputHandler().ScrollEnd();
{
RenderFrameMetadata metadata = StartDrawAndProduceRenderFrameMetadata();
EXPECT_EQ(gfx::PointF(0, 10), metadata.root_scroll_offset);
EXPECT_EQ(2, metadata.page_scale_factor);
#if BUILDFLAG(IS_ANDROID)
EXPECT_EQ(gfx::SizeF(25, 25), metadata.scrollable_viewport_size);
EXPECT_EQ(0.5f, metadata.min_page_scale_factor);
EXPECT_EQ(4, metadata.max_page_scale_factor);
EXPECT_EQ(gfx::SizeF(100, 100), metadata.root_layer_size);
#endif
}
// Likewise if set from the main thread.
host_impl_->ProcessCompositorDeltas(/* main_thread_mutator_host */ nullptr);
host_impl_->active_tree()->PushPageScaleFromMainThread(4, 0.5f, 4);
host_impl_->active_tree()->SetPageScaleOnActiveTree(4);
{
RenderFrameMetadata metadata = StartDrawAndProduceRenderFrameMetadata();
EXPECT_EQ(gfx::PointF(0, 10), metadata.root_scroll_offset);
EXPECT_EQ(4, metadata.page_scale_factor);
#if BUILDFLAG(IS_ANDROID)
EXPECT_EQ(gfx::SizeF(12.5f, 12.5f), metadata.scrollable_viewport_size);
EXPECT_EQ(0.5f, metadata.min_page_scale_factor);
EXPECT_EQ(4, metadata.max_page_scale_factor);
EXPECT_EQ(gfx::SizeF(100, 100), metadata.root_layer_size);
#endif
}
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
SelectionBoundsPassedToRenderFrameMetadata) {
LayerImpl* root = SetupDefaultRootLayer(gfx::Size(10, 10));
UpdateDrawProperties(host_impl_->active_tree());
auto observer = std::make_unique<TestRenderFrameMetadataObserver>(false);
auto* observer_ptr = observer.get();
host_impl_->SetRenderFrameObserver(std::move(observer));
EXPECT_FALSE(observer_ptr->last_metadata());
// Trigger a draw-swap sequence.
host_impl_->SetNeedsRedraw();
DrawFrame();
// Ensure the selection bounds propagated to the render frame metadata
// represent an empty selection.
ASSERT_TRUE(observer_ptr->last_metadata());
const viz::Selection<gfx::SelectionBound>& selection_1 =
observer_ptr->last_metadata()->selection;
EXPECT_EQ(gfx::SelectionBound::EMPTY, selection_1.start.type());
EXPECT_EQ(gfx::SelectionBound::EMPTY, selection_1.end.type());
EXPECT_EQ(gfx::PointF(), selection_1.start.edge_end());
EXPECT_EQ(gfx::PointF(), selection_1.start.edge_start());
EXPECT_FALSE(selection_1.start.visible());
EXPECT_FALSE(selection_1.end.visible());
// Plumb the layer-local selection bounds.
gfx::Point selection_start(5, 0);
gfx::Point selection_end(5, 5);
LayerSelection selection;
selection.start.type = gfx::SelectionBound::CENTER;
selection.start.layer_id = root->id();
selection.start.edge_end = selection_end;
selection.start.edge_start = selection_start;
selection.end = selection.start;
host_impl_->active_tree()->RegisterSelection(selection);
// Trigger a draw-swap sequence.
host_impl_->SetNeedsRedraw();
DrawFrame();
// Ensure the selection bounds have propagated to the render frame metadata.
ASSERT_TRUE(observer_ptr->last_metadata());
const viz::Selection<gfx::SelectionBound>& selection_2 =
observer_ptr->last_metadata()->selection;
EXPECT_EQ(selection.start.type, selection_2.start.type());
EXPECT_EQ(selection.end.type, selection_2.end.type());
EXPECT_EQ(gfx::PointF(selection_end), selection_2.start.edge_end());
EXPECT_EQ(gfx::PointF(selection_start), selection_2.start.edge_start());
EXPECT_TRUE(selection_2.start.visible());
EXPECT_TRUE(selection_2.end.visible());
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
VerticalScrollDirectionChangesPassedToRenderFrameMetadata) {
// Set up the viewport.
SetupViewportLayersInnerScrolls(gfx::Size(50, 50), gfx::Size(100, 100));
host_impl_->active_tree()->SetDeviceViewportRect(gfx::Rect(50, 50));
// Set up the render frame metadata observer.
auto observer = std::make_unique<TestRenderFrameMetadataObserver>(false);
auto* observer_ptr = observer.get();
host_impl_->SetRenderFrameObserver(std::move(observer));
EXPECT_FALSE(observer_ptr->last_metadata());
// Our test will be comprised of multiple legs, each leg consisting of a
// distinct scroll event and an expectation regarding the vertical scroll
// direction passed to the render frame metadata.
typedef struct {
gfx::Vector2d scroll_delta;
viz::VerticalScrollDirection expected_vertical_scroll_direction;
} TestLeg;
std::vector<TestLeg> test_legs;
// Initially, vertical scroll direction should be |kNull| indicating absence.
test_legs.push_back({/*scroll_delta=*/gfx::Vector2d(),
/*expected_vertical_scroll_direction=*/viz::
VerticalScrollDirection::kNull});
// Scrolling to the right should not affect vertical scroll direction.
test_legs.push_back({/*scroll_delta=*/gfx::Vector2d(10, 0),
/*expected_vertical_scroll_direction=*/viz::
VerticalScrollDirection::kNull});
// After scrolling down, the vertical scroll direction should be |kDown|.
test_legs.push_back({/*scroll_delta=*/gfx::Vector2d(0, 10),
/*expected_vertical_scroll_direction=*/viz::
VerticalScrollDirection::kDown});
// If we scroll down again, the vertical scroll direction should be |kNull| as
// there was no change in vertical scroll direction.
test_legs.push_back({/*scroll_delta=*/gfx::Vector2d(0, 10),
/*expected_vertical_scroll_direction=*/viz::
VerticalScrollDirection::kNull});
// Scrolling to the left should not affect last vertical scroll direction.
test_legs.push_back({/*scroll_delta=*/gfx::Vector2d(-10, 0),
/*expected_vertical_scroll_direction=*/viz::
VerticalScrollDirection::kNull});
// After scrolling up, the vertical scroll direction should be |kUp|.
test_legs.push_back({/*scroll_delta=*/gfx::Vector2d(0, -10),
/*expected_vertical_scroll_direction=*/viz::
VerticalScrollDirection::kUp});
// If we scroll up again, the vertical scroll direction should be |kNull| as
// there was no change in vertical scroll direction.
test_legs.push_back({/*scroll_delta=*/gfx::Vector2d(0, -10),
/*expected_vertical_scroll_direction=*/viz::
VerticalScrollDirection::kNull});
// Iterate over all legs of our test.
for (auto& test_leg : test_legs) {
// If the test leg contains a scroll, perform it.
if (!test_leg.scroll_delta.IsZero()) {
GetInputHandler().ScrollBegin(
BeginState(gfx::Point(), test_leg.scroll_delta,
ui::ScrollInputType::kWheel)
.get(),
ui::ScrollInputType::kWheel);
GetInputHandler().ScrollUpdate(UpdateState(gfx::Point(),
test_leg.scroll_delta,
ui::ScrollInputType::kWheel)
.get());
}
// Trigger draw.
host_impl_->SetNeedsRedraw();
DrawFrame();
// Assert our expectation regarding the vertical scroll direction.
EXPECT_EQ(test_leg.expected_vertical_scroll_direction,
observer_ptr->last_metadata()->new_vertical_scroll_direction);
// If the test leg contains a scroll, end it.
if (!test_leg.scroll_delta.IsZero())
GetInputHandler().ScrollEnd();
}
}
// Tests ScrollUpdate() to see if the method sets the scroll tree's currently
// scrolling node.
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
ScrollUpdateDoesNotSetScrollingNode) {
SetupViewportLayersInnerScrolls(gfx::Size(50, 50), gfx::Size(100, 100));
UpdateDrawProperties(host_impl_->active_tree());
ScrollStateData scroll_state_data;
std::unique_ptr<ScrollState> scroll_state(new ScrollState(scroll_state_data));
ScrollTree& scroll_tree =
host_impl_->active_tree()->property_trees()->scroll_tree_mutable();
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), gfx::Vector2dF(),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
ScrollNode* scroll_node = scroll_tree.CurrentlyScrollingNode();
EXPECT_TRUE(scroll_node);
GetInputHandler().ScrollUpdate(scroll_state.get());
// Check to see the scroll tree's currently scrolling node is
// still the same.
EXPECT_EQ(scroll_node, scroll_tree.CurrentlyScrollingNode());
// Set the scroll tree's currently scrolling node to null.
host_impl_->active_tree()->SetCurrentlyScrollingNode(nullptr);
EXPECT_FALSE(scroll_tree.CurrentlyScrollingNode());
GetInputHandler().ScrollUpdate(scroll_state.get());
EXPECT_EQ(nullptr, scroll_tree.CurrentlyScrollingNode());
}
class HitTestRegionListGeneratingLayerTreeHostImplTest
: public LayerTreeHostImplTest {
public:
bool CreateHostImpl(
const LayerTreeSettings& settings,
std::unique_ptr<LayerTreeFrameSink> layer_tree_frame_sink) override {
// Enable hit test data generation with the CompositorFrame.
LayerTreeSettings new_settings = settings;
return LayerTreeHostImplTest::CreateHostImpl(
new_settings, std::move(layer_tree_frame_sink));
}
};
// Test to ensure that hit test data is created correctly from the active layer
// tree.
TEST_F(HitTestRegionListGeneratingLayerTreeHostImplTest, BuildHitTestData) {
// Setup surface layers in LayerTreeHostImpl.
host_impl_->CreatePendingTree();
host_impl_->ActivateSyncTree();
// The structure of the layer tree:
// +-Root (1024x768)
// +---intermediate_layer (200, 300), 200x200
// +-----surface_child1 (50, 50), 100x100, Rotate(45)
// +---surface_child2 (450, 300), 100x100
// +---overlapping_layer (500, 350), 200x200
auto* root = SetupDefaultRootLayer(gfx::Size(1024, 768));
auto* intermediate_layer = AddLayer();
auto* surface_child1 = AddLayer<SurfaceLayerImpl>(host_impl_->active_tree());
auto* surface_child2 = AddLayer<SurfaceLayerImpl>(host_impl_->active_tree());
auto* overlapping_layer = AddLayer();
intermediate_layer->SetBounds(gfx::Size(200, 200));
surface_child1->SetBounds(gfx::Size(100, 100));
gfx::Transform rotate;
rotate.Rotate(45);
surface_child1->SetDrawsContent(true);
surface_child1->SetHitTestable(true);
surface_child1->SetSurfaceHitTestable(true);
surface_child2->SetBounds(gfx::Size(100, 100));
surface_child2->SetDrawsContent(true);
surface_child2->SetHitTestable(true);
surface_child2->SetSurfaceHitTestable(true);
overlapping_layer->SetBounds(gfx::Size(200, 200));
overlapping_layer->SetDrawsContent(true);
overlapping_layer->SetHitTestable(true);
viz::LocalSurfaceId child_local_surface_id(2,
base::UnguessableToken::Create());
viz::FrameSinkId frame_sink_id(2, 0);
viz::SurfaceId child_surface_id(frame_sink_id, child_local_surface_id);
surface_child1->SetRange(viz::SurfaceRange(absl::nullopt, child_surface_id),
absl::nullopt);
surface_child2->SetRange(viz::SurfaceRange(absl::nullopt, child_surface_id),
absl::nullopt);
CopyProperties(root, intermediate_layer);
intermediate_layer->SetOffsetToTransformParent(gfx::Vector2dF(200, 300));
CopyProperties(root, surface_child2);
surface_child2->SetOffsetToTransformParent(gfx::Vector2dF(450, 300));
CopyProperties(root, overlapping_layer);
overlapping_layer->SetOffsetToTransformParent(gfx::Vector2dF(500, 350));
CopyProperties(intermediate_layer, surface_child1);
auto& surface_child1_transform_node = CreateTransformNode(surface_child1);
// The post_translation includes offset of intermediate_layer.
surface_child1_transform_node.post_translation = gfx::Vector2dF(250, 350);
surface_child1_transform_node.local = rotate;
UpdateDrawProperties(host_impl_->active_tree());
draw_property_utils::ComputeEffects(
&host_impl_->active_tree()->property_trees()->effect_tree_mutable());
constexpr gfx::Rect kFrameRect(0, 0, 1024, 768);
absl::optional<viz::HitTestRegionList> hit_test_region_list =
host_impl_->BuildHitTestData();
// Generating HitTestRegionList should have been enabled for this test.
ASSERT_TRUE(hit_test_region_list);
// Since surface_child2 draws in front of surface_child1, it should also be in
// the front of the hit test region list.
uint32_t expected_flags = viz::HitTestRegionFlags::kHitTestMouse |
viz::HitTestRegionFlags::kHitTestTouch |
viz::HitTestRegionFlags::kHitTestMine;
EXPECT_EQ(expected_flags, hit_test_region_list->flags);
EXPECT_EQ(kFrameRect, hit_test_region_list->bounds);
EXPECT_EQ(2u, hit_test_region_list->regions.size());
EXPECT_EQ(child_surface_id.frame_sink_id(),
hit_test_region_list->regions[1].frame_sink_id);
expected_flags = viz::HitTestRegionFlags::kHitTestMouse |
viz::HitTestRegionFlags::kHitTestTouch |
viz::HitTestRegionFlags::kHitTestChildSurface;
EXPECT_EQ(expected_flags, hit_test_region_list->regions[1].flags);
gfx::Transform child1_transform;
child1_transform.Rotate(-45);
child1_transform.Translate(-250, -350);
EXPECT_TRUE(child1_transform.ApproximatelyEqual(
hit_test_region_list->regions[1].transform));
EXPECT_EQ(gfx::Rect(0, 0, 100, 100), hit_test_region_list->regions[1].rect);
EXPECT_EQ(child_surface_id.frame_sink_id(),
hit_test_region_list->regions[0].frame_sink_id);
expected_flags = viz::HitTestRegionFlags::kHitTestMouse |
viz::HitTestRegionFlags::kHitTestTouch |
viz::HitTestRegionFlags::kHitTestChildSurface |
viz::HitTestRegionFlags::kHitTestAsk;
EXPECT_EQ(expected_flags, hit_test_region_list->regions[0].flags);
gfx::Transform child2_transform;
child2_transform.Translate(-450, -300);
EXPECT_TRUE(child2_transform.ApproximatelyEqual(
hit_test_region_list->regions[0].transform));
EXPECT_EQ(gfx::Rect(0, 0, 100, 100), hit_test_region_list->regions[0].rect);
}
TEST_F(HitTestRegionListGeneratingLayerTreeHostImplTest, PointerEvents) {
// Setup surface layers in LayerTreeHostImpl.
host_impl_->CreatePendingTree();
host_impl_->ActivateSyncTree();
// The structure of the layer tree:
// +-Root (1024x768)
// +---surface_child1 (0, 0), 100x100
// +---overlapping_surface_child2 (50, 50), 100x100, pointer-events: none,
// does not generate hit test region
auto* root = SetupDefaultRootLayer(gfx::Size(1024, 768));
auto* surface_child1 = AddLayer<SurfaceLayerImpl>(host_impl_->active_tree());
auto* surface_child2 = AddLayer<SurfaceLayerImpl>(host_impl_->active_tree());
surface_child1->SetBounds(gfx::Size(100, 100));
surface_child1->SetDrawsContent(true);
surface_child1->SetHitTestable(true);
surface_child1->SetSurfaceHitTestable(true);
surface_child1->SetHasPointerEventsNone(false);
CopyProperties(root, surface_child1);
surface_child2->SetBounds(gfx::Size(100, 100));
surface_child2->SetDrawsContent(true);
surface_child2->SetHitTestable(true);
surface_child2->SetSurfaceHitTestable(false);
surface_child2->SetHasPointerEventsNone(true);
CopyProperties(root, surface_child2);
surface_child2->SetOffsetToTransformParent(gfx::Vector2dF(50, 50));
viz::LocalSurfaceId child_local_surface_id(2,
base::UnguessableToken::Create());
viz::FrameSinkId frame_sink_id(2, 0);
viz::SurfaceId child_surface_id(frame_sink_id, child_local_surface_id);
surface_child1->SetRange(viz::SurfaceRange(absl::nullopt, child_surface_id),
absl::nullopt);
constexpr gfx::Rect kFrameRect(0, 0, 1024, 768);
UpdateDrawProperties(host_impl_->active_tree());
absl::optional<viz::HitTestRegionList> hit_test_region_list =
host_impl_->BuildHitTestData();
// Generating HitTestRegionList should have been enabled for this test.
ASSERT_TRUE(hit_test_region_list);
uint32_t expected_flags = viz::HitTestRegionFlags::kHitTestMouse |
viz::HitTestRegionFlags::kHitTestTouch |
viz::HitTestRegionFlags::kHitTestMine;
EXPECT_EQ(expected_flags, hit_test_region_list->flags);
EXPECT_EQ(kFrameRect, hit_test_region_list->bounds);
// Since |surface_child2| is not |surface_hit_testable|, it does not
// contribute to a hit test region. Although it overlaps |surface_child1|, it
// does not make |surface_child1| kHitTestAsk because it has pointer-events
// none property.
EXPECT_EQ(1u, hit_test_region_list->regions.size());
EXPECT_EQ(child_surface_id.frame_sink_id(),
hit_test_region_list->regions[0].frame_sink_id);
expected_flags = viz::HitTestRegionFlags::kHitTestMouse |
viz::HitTestRegionFlags::kHitTestTouch |
viz::HitTestRegionFlags::kHitTestChildSurface;
EXPECT_EQ(expected_flags, hit_test_region_list->regions[0].flags);
gfx::Transform child1_transform;
EXPECT_TRUE(child1_transform.ApproximatelyEqual(
hit_test_region_list->regions[0].transform));
EXPECT_EQ(gfx::Rect(0, 0, 100, 100), hit_test_region_list->regions[0].rect);
}
TEST_F(HitTestRegionListGeneratingLayerTreeHostImplTest, ComplexPage) {
// Setup surface layers in LayerTreeHostImpl.
host_impl_->CreatePendingTree();
host_impl_->ActivateSyncTree();
// The structure of the layer tree:
// +-Root (1024x768)
// +---surface_child (0, 0), 100x100
// +---100x non overlapping layers (110, 110), 1x1
LayerImpl* root = SetupDefaultRootLayer(gfx::Size(1024, 768));
auto* surface_child = AddLayer<SurfaceLayerImpl>(host_impl_->active_tree());
surface_child->SetBounds(gfx::Size(100, 100));
surface_child->SetDrawsContent(true);
surface_child->SetHitTestable(true);
surface_child->SetSurfaceHitTestable(true);
surface_child->SetHasPointerEventsNone(false);
viz::LocalSurfaceId child_local_surface_id(2,
base::UnguessableToken::Create());
viz::FrameSinkId frame_sink_id(2, 0);
viz::SurfaceId child_surface_id(frame_sink_id, child_local_surface_id);
surface_child->SetRange(viz::SurfaceRange(absl::nullopt, child_surface_id),
absl::nullopt);
CopyProperties(root, surface_child);
// Create 101 non overlapping layers.
for (size_t i = 0; i <= 100; ++i) {
LayerImpl* layer = AddLayer();
layer->SetBounds(gfx::Size(1, 1));
layer->SetDrawsContent(true);
layer->SetHitTestable(true);
CopyProperties(root, layer);
}
constexpr gfx::Rect kFrameRect(0, 0, 1024, 768);
UpdateDrawProperties(host_impl_->active_tree());
absl::optional<viz::HitTestRegionList> hit_test_region_list =
host_impl_->BuildHitTestData();
// Generating HitTestRegionList should have been enabled for this test.
ASSERT_TRUE(hit_test_region_list);
uint32_t expected_flags = viz::HitTestRegionFlags::kHitTestMouse |
viz::HitTestRegionFlags::kHitTestTouch |
viz::HitTestRegionFlags::kHitTestMine;
EXPECT_EQ(expected_flags, hit_test_region_list->flags);
EXPECT_EQ(kFrameRect, hit_test_region_list->bounds);
EXPECT_EQ(1u, hit_test_region_list->regions.size());
EXPECT_EQ(child_surface_id.frame_sink_id(),
hit_test_region_list->regions[0].frame_sink_id);
// Since the layer count is greater than 100, in order to save time, we do not
// check whether each layer overlaps the surface layer, instead, we are being
// conservative and make the surface layer slow hit testing.
expected_flags = viz::HitTestRegionFlags::kHitTestMouse |
viz::HitTestRegionFlags::kHitTestTouch |
viz::HitTestRegionFlags::kHitTestChildSurface |
viz::HitTestRegionFlags::kHitTestAsk;
EXPECT_EQ(expected_flags, hit_test_region_list->regions[0].flags);
gfx::Transform child1_transform;
EXPECT_TRUE(child1_transform.ApproximatelyEqual(
hit_test_region_list->regions[0].transform));
EXPECT_EQ(gfx::Rect(0, 0, 100, 100), hit_test_region_list->regions[0].rect);
}
TEST_F(HitTestRegionListGeneratingLayerTreeHostImplTest, InvalidFrameSinkId) {
// Setup surface layers in LayerTreeHostImpl.
host_impl_->CreatePendingTree();
host_impl_->ActivateSyncTree();
// The structure of the layer tree:
// +-Root (1024x768)
// +---surface_child1 (0, 0), 100x100
// +---surface_child2 (0, 0), 50x50, frame_sink_id = (0, 0)
LayerImpl* root = SetupDefaultRootLayer(gfx::Size(1024, 768));
auto* surface_child1 = AddLayer<SurfaceLayerImpl>(host_impl_->active_tree());
host_impl_->active_tree()->SetDeviceViewportRect(gfx::Rect(1024, 768));
surface_child1->SetBounds(gfx::Size(100, 100));
surface_child1->SetDrawsContent(true);
surface_child1->SetHitTestable(true);
surface_child1->SetSurfaceHitTestable(true);
surface_child1->SetHasPointerEventsNone(false);
CopyProperties(root, surface_child1);
viz::LocalSurfaceId child_local_surface_id(2,
base::UnguessableToken::Create());
viz::FrameSinkId frame_sink_id(2, 0);
viz::SurfaceId child_surface_id(frame_sink_id, child_local_surface_id);
surface_child1->SetRange(viz::SurfaceRange(absl::nullopt, child_surface_id),
absl::nullopt);
auto* surface_child2 = AddLayer<SurfaceLayerImpl>(host_impl_->active_tree());
surface_child2->SetBounds(gfx::Size(50, 50));
surface_child2->SetDrawsContent(true);
surface_child2->SetHitTestable(true);
surface_child2->SetSurfaceHitTestable(true);
surface_child2->SetHasPointerEventsNone(false);
CopyProperties(root, surface_child2);
surface_child2->SetRange(viz::SurfaceRange(absl::nullopt, viz::SurfaceId()),
absl::nullopt);
constexpr gfx::Rect kFrameRect(0, 0, 1024, 768);
UpdateDrawProperties(host_impl_->active_tree());
absl::optional<viz::HitTestRegionList> hit_test_region_list =
host_impl_->BuildHitTestData();
// Generating HitTestRegionList should have been enabled for this test.
ASSERT_TRUE(hit_test_region_list);
uint32_t expected_flags = viz::HitTestRegionFlags::kHitTestMouse |
viz::HitTestRegionFlags::kHitTestTouch |
viz::HitTestRegionFlags::kHitTestMine;
EXPECT_EQ(expected_flags, hit_test_region_list->flags);
EXPECT_EQ(kFrameRect, hit_test_region_list->bounds);
EXPECT_EQ(1u, hit_test_region_list->regions.size());
EXPECT_EQ(child_surface_id.frame_sink_id(),
hit_test_region_list->regions[0].frame_sink_id);
// We do not populate hit test region for a surface layer with invalid frame
// sink id to avoid deserialization failure. Instead we make the overlapping
// hit test region kHitTestAsk.
expected_flags = viz::HitTestRegionFlags::kHitTestMouse |
viz::HitTestRegionFlags::kHitTestTouch |
viz::HitTestRegionFlags::kHitTestChildSurface |
viz::HitTestRegionFlags::kHitTestAsk;
EXPECT_EQ(expected_flags, hit_test_region_list->regions[0].flags);
gfx::Transform child1_transform;
EXPECT_TRUE(child1_transform.ApproximatelyEqual(
hit_test_region_list->regions[0].transform));
EXPECT_EQ(gfx::Rect(0, 0, 100, 100), hit_test_region_list->regions[0].rect);
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest,
ImplThreadPhaseUponImplSideInvalidation) {
LayerTreeSettings settings = DefaultSettings();
CreateHostImpl(settings, CreateLayerTreeFrameSink());
// In general invalidation should never be ran outside the impl frame.
auto args = viz::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, 0, 1);
host_impl_->WillBeginImplFrame(args);
// Expect no crash because the operation is within an impl frame.
host_impl_->InvalidateContentOnImplSide();
// Once the impl frame is finished the impl thread phase is set to IDLE.
host_impl_->DidFinishImplFrame(args);
settings.using_synchronous_renderer_compositor = true;
CreateHostImpl(settings, CreateLayerTreeFrameSink());
// Expect no crash when using synchronous renderer compositor regardless the
// impl thread phase.
host_impl_->InvalidateContentOnImplSide();
// Test passes when there is no crash.
}
TEST_P(ScrollUnifiedLayerTreeHostImplTest, SkipOnDrawDoesNotUpdateDrawParams) {
EXPECT_TRUE(CreateHostImpl(DefaultSettings(),
FakeLayerTreeFrameSink::CreateSoftware()));
SetupViewportLayersInnerScrolls(gfx::Size(50, 50), gfx::Size(100, 100));
auto* layer = InnerViewportScrollLayer();
layer->SetDrawsContent(true);
gfx::Transform transform;
transform.Translate(20, 20);
gfx::Rect viewport(0, 0, 50, 50);
const bool resourceless_software_draw = false;
bool skip_draw = false;
host_impl_->OnDraw(transform, viewport, resourceless_software_draw,
skip_draw);
EXPECT_EQ(transform, host_impl_->DrawTransform());
EXPECT_EQ(viewport, host_impl_->active_tree()->GetDeviceViewport());
skip_draw = true;
gfx::Transform new_transform;
gfx::Rect new_viewport;
host_impl_->OnDraw(new_transform, new_viewport, resourceless_software_draw,
skip_draw);
EXPECT_EQ(transform, host_impl_->DrawTransform());
EXPECT_EQ(viewport, host_impl_->active_tree()->GetDeviceViewport());
}
// Test that a touch scroll over a SolidColorScrollbarLayer, the scrollbar used
// on Android, does not register as a scrollbar scroll and result in main
// threaded scrolling.
TEST_P(ScrollUnifiedLayerTreeHostImplTest, TouchScrollOnAndroidScrollbar) {
LayerTreeImpl* layer_tree_impl = host_impl_->active_tree();
gfx::Size viewport_size = gfx::Size(360, 600);
gfx::Size scroll_content_size = gfx::Size(360, 3800);
gfx::Size scrollbar_size = gfx::Size(15, 600);
SetupViewportLayersNoScrolls(viewport_size);
LayerImpl* content = AddScrollableLayer(OuterViewportScrollLayer(),
viewport_size, scroll_content_size);
auto* scrollbar = AddLayer<SolidColorScrollbarLayerImpl>(
layer_tree_impl, ScrollbarOrientation::VERTICAL, 10, 0, false);
SetupScrollbarLayer(content, scrollbar);
scrollbar->SetBounds(scrollbar_size);
scrollbar->SetOffsetToTransformParent(gfx::Vector2dF(345, 0));
UpdateDrawProperties(layer_tree_impl);
layer_tree_impl->DidBecomeActive();
// Do a scroll over the scrollbar layer as well as the content layer, which
// should result in scrolling the scroll layer on the impl thread as the
// scrollbar should not be hit.
InputHandler::ScrollStatus status = GetInputHandler().ScrollBegin(
BeginState(gfx::Point(350, 50), gfx::Vector2dF(0, 10),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen);
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
}
TEST_F(CommitToPendingTreeLayerTreeHostImplTest,
CommitWithNoPaintWorkletLayerPainter) {
ASSERT_FALSE(host_impl_->GetPaintWorkletLayerPainterForTesting());
host_impl_->CreatePendingTree();
// When there is no PaintWorkletLayerPainter registered, commits should finish
// immediately and move onto preparing tiles.
ASSERT_FALSE(did_prepare_tiles_);
host_impl_->CommitComplete();
EXPECT_TRUE(did_prepare_tiles_);
}
TEST_F(CommitToPendingTreeLayerTreeHostImplTest, CommitWithNoPaintWorklets) {
host_impl_->SetPaintWorkletLayerPainter(
std::make_unique<TestPaintWorkletLayerPainter>());
host_impl_->CreatePendingTree();
// When there are no PaintWorklets in the committed display lists, commits
// should finish immediately and move onto preparing tiles.
ASSERT_FALSE(did_prepare_tiles_);
host_impl_->CommitComplete();
EXPECT_TRUE(did_prepare_tiles_);
}
TEST_F(CommitToPendingTreeLayerTreeHostImplTest, CommitWithDirtyPaintWorklets) {
auto painter_owned = std::make_unique<TestPaintWorkletLayerPainter>();
TestPaintWorkletLayerPainter* painter = painter_owned.get();
host_impl_->SetPaintWorkletLayerPainter(std::move(painter_owned));
// Setup the pending tree with a PictureLayerImpl that will contain
// PaintWorklets.
host_impl_->CreatePendingTree();
auto* root = SetupRootLayer<PictureLayerImpl>(host_impl_->pending_tree(),
gfx::Size(100, 100));
root->SetNeedsPushProperties();
// Add a PaintWorkletInput to the PictureLayerImpl.
scoped_refptr<RasterSource> raster_source_with_pws(
FakeRasterSource::CreateFilledWithPaintWorklet(root->bounds()));
Region empty_invalidation;
root->UpdateRasterSource(raster_source_with_pws, &empty_invalidation, nullptr,
nullptr);
UpdateDrawProperties(host_impl_->pending_tree());
// Since we have dirty PaintWorklets, committing will not cause tile
// preparation to happen. Instead, it will be delayed until the callback
// passed to the PaintWorkletLayerPainter is called.
did_prepare_tiles_ = false;
host_impl_->CommitComplete();
EXPECT_FALSE(did_prepare_tiles_);
// Set up a result to have been 'painted'.
ASSERT_EQ(root->GetPaintWorkletRecordMap().size(), 1u);
scoped_refptr<const PaintWorkletInput> input =
root->GetPaintWorkletRecordMap().begin()->first;
int worklet_id = input->WorkletId();
PaintWorkletJob painted_job(worklet_id, input, {});
sk_sp<PaintRecord> record = sk_make_sp<PaintRecord>();
painted_job.SetOutput(record);
auto painted_job_vector = base::MakeRefCounted<PaintWorkletJobVector>();
painted_job_vector->data.push_back(std::move(painted_job));
PaintWorkletJobMap painted_job_map;
painted_job_map[worklet_id] = std::move(painted_job_vector);
// Finally, 'paint' the content. This should unlock tile preparation and
// update the PictureLayerImpl's map.
std::move(painter->TakeDoneCallback()).Run(std::move(painted_job_map));
EXPECT_EQ(root->GetPaintWorkletRecordMap().find(input)->second.second,
record);
EXPECT_TRUE(did_prepare_tiles_);
}
TEST_F(CommitToPendingTreeLayerTreeHostImplTest,
CommitWithNoDirtyPaintWorklets) {
host_impl_->SetPaintWorkletLayerPainter(
std::make_unique<TestPaintWorkletLayerPainter>());
host_impl_->CreatePendingTree();
auto* root = SetupRootLayer<PictureLayerImpl>(host_impl_->pending_tree(),
gfx::Size(100, 100));
root->SetNeedsPushProperties();
// Add some PaintWorklets.
scoped_refptr<RasterSource> raster_source_with_pws(
FakeRasterSource::CreateFilledWithPaintWorklet(root->bounds()));
Region empty_invalidation;
root->UpdateRasterSource(raster_source_with_pws, &empty_invalidation, nullptr,
nullptr);
UpdateDrawProperties(host_impl_->pending_tree());
// Pretend that our worklets were already painted.
ASSERT_EQ(root->GetPaintWorkletRecordMap().size(), 1u);
root->SetPaintWorkletRecord(root->GetPaintWorkletRecordMap().begin()->first,
sk_make_sp<PaintRecord>());
// Since there are no dirty PaintWorklets, the commit should immediately
// prepare tiles.
ASSERT_FALSE(did_prepare_tiles_);
host_impl_->CommitComplete();
EXPECT_TRUE(did_prepare_tiles_);
}
class ForceActivateAfterPaintWorkletPaintLayerTreeHostImplTest
: public CommitToPendingTreeLayerTreeHostImplTest {
public:
void NotifyPaintWorkletStateChange(
Scheduler::PaintWorkletState state) override {
if (state == Scheduler::PaintWorkletState::IDLE) {
// Pretend a force activation happened.
host_impl_->ActivateSyncTree();
ASSERT_FALSE(host_impl_->pending_tree());
}
}
};
TEST_F(ForceActivateAfterPaintWorkletPaintLayerTreeHostImplTest,
ForceActivationAfterPaintWorkletsFinishPainting) {
auto painter_owned = std::make_unique<TestPaintWorkletLayerPainter>();
TestPaintWorkletLayerPainter* painter = painter_owned.get();
host_impl_->SetPaintWorkletLayerPainter(std::move(painter_owned));
// Setup the pending tree with a PictureLayerImpl that will contain
// PaintWorklets.
host_impl_->CreatePendingTree();
auto* root = SetupRootLayer<PictureLayerImpl>(host_impl_->pending_tree(),
gfx::Size(100, 100));
root->SetNeedsPushProperties();
// Add a PaintWorkletInput to the PictureLayerImpl.
scoped_refptr<RasterSource> raster_source_with_pws(
FakeRasterSource::CreateFilledWithPaintWorklet(root->bounds()));
Region empty_invalidation;
root->UpdateRasterSource(raster_source_with_pws, &empty_invalidation, nullptr,
nullptr);
UpdateDrawProperties(host_impl_->pending_tree());
// Since we have dirty PaintWorklets, committing will not cause tile
// preparation to happen. Instead, it will be delayed until the callback
// passed to the PaintWorkletLayerPainter is called.
did_prepare_tiles_ = false;
host_impl_->CommitComplete();
EXPECT_FALSE(did_prepare_tiles_);
// Set up a result to have been 'painted'.
ASSERT_EQ(root->GetPaintWorkletRecordMap().size(), 1u);
scoped_refptr<const PaintWorkletInput> input =
root->GetPaintWorkletRecordMap().begin()->first;
int worklet_id = input->WorkletId();
PaintWorkletJob painted_job(worklet_id, input, {});
sk_sp<PaintRecord> record = sk_make_sp<PaintRecord>();
painted_job.SetOutput(record);
auto painted_job_vector = base::MakeRefCounted<PaintWorkletJobVector>();
painted_job_vector->data.push_back(std::move(painted_job));
PaintWorkletJobMap painted_job_map;
painted_job_map[worklet_id] = std::move(painted_job_vector);
// Finally, 'paint' the content. The test class causes a forced activation
// during NotifyPaintWorkletStateChange. The PictureLayerImpl should still be
// updated, but since the tree was force activated there should be no tile
// preparation.
std::move(painter->TakeDoneCallback()).Run(std::move(painted_job_map));
EXPECT_EQ(root->GetPaintWorkletRecordMap().find(input)->second.second,
record);
EXPECT_FALSE(did_prepare_tiles_);
}
// Verify that the device scale factor is not used to rescale scrollbar deltas
// in percent-based scrolling.
TEST_P(ScrollUnifiedLayerTreeHostImplTest, PercentBasedScrollbarDeltasDSF3) {
LayerTreeSettings settings = DefaultSettings();
settings.percent_based_scrolling = true;
settings.use_painted_device_scale_factor = true;
CreateHostImpl(settings, CreateLayerTreeFrameSink());
const gfx::Size viewport_size = gfx::Size(800, 800);
SetupViewportLayersOuterScrolls(viewport_size, viewport_size);
LayerImpl* content_layer = AddContentLayer();
LayerImpl* scroll_layer = AddScrollableLayer(
content_layer, gfx::Size(185, 500), gfx::Size(185, 3800));
auto* scrollbar = AddLayer<PaintedScrollbarLayerImpl>(
host_impl_->active_tree(), ScrollbarOrientation::VERTICAL, false, true);
SetupScrollbarLayer(scroll_layer, scrollbar);
scrollbar->SetBounds(gfx::Size(15, 500));
scrollbar->SetThumbThickness(15);
scrollbar->SetThumbLength(50);
scrollbar->SetTrackRect(gfx::Rect(0, 15, 15, 485));
scrollbar->SetBackButtonRect(gfx::Rect(gfx::Point(0, 0), gfx::Size(15, 15)));
scrollbar->SetForwardButtonRect(
gfx::Rect(gfx::Point(0, 485), gfx::Size(15, 15)));
scrollbar->SetOffsetToTransformParent(gfx::Vector2dF(185, 0));
DrawFrame();
TestInputHandlerClient input_handler_client;
GetInputHandler().BindToClient(&input_handler_client);
// Test scrolling with device scale factor = 3.
const float expected_delta = kPercentDeltaForDirectionalScroll * 500;
host_impl_->active_tree()->set_painted_device_scale_factor(3);
InputHandlerPointerResult scroll_result =
GetInputHandler().MouseDown(gfx::PointF(190, 490), false);
GetInputHandler().MouseUp(gfx::PointF(190, 490));
EXPECT_EQ(scroll_result.scroll_delta.y(), expected_delta);
EXPECT_FALSE(GetScrollNode(scroll_layer)->main_thread_scrolling_reasons);
// Test with DSF = 1. As the scrollable layers aren't rescaled by the DSF,
// neither the scroll offset, the same result for DSF = 3 is expected.
host_impl_->active_tree()->set_painted_device_scale_factor(1);
InputHandlerPointerResult scroll_with_dsf_1 =
GetInputHandler().MouseDown(gfx::PointF(190, 490), false);
GetInputHandler().MouseUp(gfx::PointF(190, 490));
EXPECT_EQ(scroll_with_dsf_1.scroll_delta.y(), expected_delta);
EXPECT_FALSE(GetScrollNode(scroll_layer)->main_thread_scrolling_reasons);
// Tear down the LayerTreeHostImpl before the InputHandlerClient.
host_impl_->ReleaseLayerTreeFrameSink();
host_impl_ = nullptr;
}
// Verify that page based scrolling resolves to the correct amount of scroll
// delta.
TEST_P(ScrollUnifiedLayerTreeHostImplTest, PageBasedScroll) {
const gfx::Size kViewportSize(100, 100);
const gfx::Size kContentSize(300, 300);
SetupViewportLayersOuterScrolls(kViewportSize, kContentSize);
DrawFrame();
const gfx::Vector2dF kPageDelta(2, 1);
auto begin_state =
BeginState(gfx::Point(), kPageDelta, ui::ScrollInputType::kWheel);
begin_state->data()->delta_granularity = ui::ScrollGranularity::kScrollByPage;
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(begin_state.get(), ui::ScrollInputType::kWheel)
.thread);
auto update_state =
UpdateState(gfx::Point(), kPageDelta, ui::ScrollInputType::kWheel);
update_state->data()->delta_granularity =
ui::ScrollGranularity::kScrollByPage;
// We should still be scrolling, because the scrolled layer also exists in the
// new tree.
GetInputHandler().ScrollUpdate(update_state.get());
viz::BeginFrameArgs begin_frame_args =
viz::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, 0, 1);
base::TimeTicks start_time = base::TimeTicks() + base::Milliseconds(100);
BeginImplFrameAndAnimate(begin_frame_args, start_time);
BeginImplFrameAndAnimate(begin_frame_args,
start_time + base::Milliseconds(50));
BeginImplFrameAndAnimate(begin_frame_args,
start_time + base::Milliseconds(2000));
const gfx::PointF kExpectedOffset(
kPageDelta.x() * kViewportSize.width() * kMinFractionToStepWhenPaging,
kPageDelta.y() * kViewportSize.height() * kMinFractionToStepWhenPaging);
const gfx::PointF kCurrentOffset =
host_impl_->active_tree()
->property_trees()
->scroll_tree()
.current_scroll_offset(
host_impl_->OuterViewportScrollNode()->element_id);
EXPECT_EQ(kExpectedOffset, kCurrentOffset);
GetInputHandler().ScrollEnd();
}
class UnifiedScrollingTest : public LayerTreeHostImplTest {
public:
using ScrollStatus = InputHandler::ScrollStatus;
void SetUp() override {
scoped_feature_list.InitAndEnableFeature(features::kScrollUnification);
LayerTreeHostImplTest::SetUp();
cur_time_ = base::TimeTicks() + base::Milliseconds(100);
begin_frame_args_ =
viz::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, 0, 1);
SetupViewportLayersOuterScrolls(gfx::Size(100, 100), gfx::Size(200, 200));
}
void CreateUncompositedScrollerAndNonFastScrollableRegion() {
// Create an uncompositd scroll node that corresponds to a non fast
// scrollable region on the outer viewport scroll layer.
gfx::Size scrollable_content_bounds(100, 100);
gfx::Size container_bounds(50, 50);
CreateScrollNodeForUncompositedScroller(
GetPropertyTrees(), host_impl_->OuterViewportScrollNode()->id,
ScrollerElementId(), scrollable_content_bounds, container_bounds);
OuterViewportScrollLayer()->SetNonFastScrollableRegion(gfx::Rect(50, 50));
host_impl_->active_tree()->set_needs_update_draw_properties();
UpdateDrawProperties(host_impl_->active_tree());
host_impl_->active_tree()->DidBecomeActive();
DrawFrame();
}
void CreateScroller(uint32_t main_thread_scrolling_reasons) {
// Creates a regular compositeds scroller that comes with a ScrollNode and
// Layer.
gfx::Size scrollable_content_bounds(100, 100);
gfx::Size container_bounds(50, 50);
LayerImpl* layer =
AddScrollableLayer(OuterViewportScrollLayer(), container_bounds,
scrollable_content_bounds);
scroller_layer_ = layer;
GetScrollNode(layer)->main_thread_scrolling_reasons =
main_thread_scrolling_reasons;
GetScrollNode(layer)->is_composited = true;
UpdateDrawProperties(host_impl_->active_tree());
host_impl_->active_tree()->DidBecomeActive();
DrawFrame();
}
void CreateSuashingLayerCoveringWholeViewport() {
// Add a (simulated) "squashing layer". It's scroll parent is the outer
// viewport but it covers the entire viewport and any scrollers underneath
// it.
LayerImpl* squashing_layer = AddLayer();
squashing_layer->SetBounds(gfx::Size(100, 100));
squashing_layer->SetDrawsContent(true);
squashing_layer->SetHitTestable(true);
CopyProperties(OuterViewportScrollLayer(), squashing_layer);
UpdateDrawProperties(host_impl_->active_tree());
}
ScrollStatus ScrollBegin(const gfx::Vector2d& delta) {
auto scroll_state =
BeginState(gfx::Point(25, 25), delta, ui::ScrollInputType::kWheel);
ScrollStatus status = GetInputHandler().ScrollBegin(
scroll_state.get(), ui::ScrollInputType::kWheel);
if (status.needs_main_thread_hit_test)
to_be_continued_scroll_begin_ = std::move(scroll_state);
return status;
}
ScrollStatus ContinuedScrollBegin(ElementId element_id) {
DCHECK(to_be_continued_scroll_begin_)
<< "ContinuedScrollBegin needs to come after a ScrollBegin that "
"requested a main frame";
std::unique_ptr<ScrollState> scroll_state =
std::move(to_be_continued_scroll_begin_);
scroll_state->data()->set_current_native_scrolling_element(element_id);
scroll_state->data()->is_main_thread_hit_tested = true;
return GetInputHandler().ScrollBegin(scroll_state.get(),
ui::ScrollInputType::kWheel);
}
InputHandlerScrollResult ScrollUpdate(const gfx::Vector2d& delta) {
auto scroll_state =
UpdateState(gfx::Point(25, 25), delta, ui::ScrollInputType::kWheel);
return GetInputHandler().ScrollUpdate(scroll_state.get());
}
InputHandlerScrollResult AnimatedScrollUpdate(const gfx::Vector2d& delta) {
auto scroll_state = AnimatedUpdateState(gfx::Point(25, 25), delta);
return GetInputHandler().ScrollUpdate(scroll_state.get());
}
void ScrollEnd() { return GetInputHandler().ScrollEnd(); }
// An animation is setup in the first BeginFrame so it won't actually update
// in the first one. Use a named method for that so it's clear rather than
// mysteriously calling BeginFrame twice.
void StartAnimation() { BeginFrame(base::TimeDelta()); }
void BeginFrame(base::TimeDelta forward) {
cur_time_ += forward;
begin_frame_args_.frame_time = cur_time_;
begin_frame_args_.frame_id.sequence_number++;
host_impl_->WillBeginImplFrame(begin_frame_args_);
host_impl_->Animate();
host_impl_->UpdateAnimationState(true);
host_impl_->DidFinishImplFrame(begin_frame_args_);
}
gfx::PointF GetScrollOffset(ScrollNode* node) {
return GetPropertyTrees()->scroll_tree().current_scroll_offset(
node->element_id);
}
gfx::PointF ScrollerOffset() {
return GetPropertyTrees()->scroll_tree().current_scroll_offset(
ScrollerElementId());
}
PropertyTrees* GetPropertyTrees() {
return host_impl_->active_tree()->property_trees();
}
ScrollNode* CurrentlyScrollingNode() {
return host_impl_->CurrentlyScrollingNode();
}
ScrollNode* ScrollerNode() {
ScrollNode* node =
GetPropertyTrees()->scroll_tree_mutable().FindNodeFromElementId(
ScrollerElementId());
DCHECK(node);
return node;
}
ElementId ScrollerElementId() const {
if (scroller_layer_)
return scroller_layer_->element_id();
return ElementId(1234);
}
base::TimeDelta kFrameInterval = base::Milliseconds(16);
// Parameterized test body. Defined inline with tests.
void TestUncompositedScrollingState(bool mutates_transform_tree);
private:
raw_ptr<LayerImpl> scroller_layer_ = nullptr;
base::TimeTicks cur_time_;
viz::BeginFrameArgs begin_frame_args_;
std::unique_ptr<ScrollState> to_be_continued_scroll_begin_;
base::test::ScopedFeatureList scoped_feature_list;
};
// A ScrollBegin that hits a non fast scrollable region must return a request
// for a main thread hit test.
TEST_F(UnifiedScrollingTest, UnifiedScrollNonFastScrollableRegion) {
CreateUncompositedScrollerAndNonFastScrollableRegion();
// When ScrollUnification is turned on, scrolling inside a non-fast
// scrollable region should request a main thread hit test. It's the client's
// responsibility to request a hit test from Blink. It can then call
// ScrollBegin again, providing the element_id to scroll.
{
ScrollStatus status = ScrollBegin(gfx::Vector2d(0, 10));
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
EXPECT_TRUE(status.needs_main_thread_hit_test);
// The scroll hasn't started yet though.
EXPECT_FALSE(CurrentlyScrollingNode());
}
// Simulate the scroll hit test coming back from the main thread. This time
// ScrollBegin will be called with an element id provided so that a hit test
// is unnecessary.
{
ScrollStatus status = ContinuedScrollBegin(ScrollerElementId());
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
EXPECT_FALSE(status.needs_main_thread_hit_test);
EXPECT_TRUE(CurrentlyScrollingNode());
EXPECT_EQ(ScrollerNode(), CurrentlyScrollingNode());
}
// Ensure ScrollUpdates can successfully scroll this node. They shouldn't
// mutate the associated transform node.
{
EXPECT_TRUE(ScrollUpdate(gfx::Vector2d(0, 10)).did_scroll);
EXPECT_EQ(gfx::PointF(0, 10), ScrollerOffset());
}
// Try to scroll past the end. Ensure the max scrolling bounds are respected.
{
EXPECT_TRUE(ScrollUpdate(gfx::Vector2d(0, 1000)).did_scroll);
EXPECT_EQ(gfx::PointF(0, 50), ScrollerOffset());
}
// Overscrolling should cause the scroll update to be dropped.
{
EXPECT_FALSE(ScrollUpdate(gfx::Vector2d(0, 10)).did_scroll);
EXPECT_EQ(gfx::PointF(0, 50), ScrollerOffset());
}
GetInputHandler().ScrollEnd();
}
// A main thread hit test should still go through latch bubbling. That is, if
// the hit tested scroller is fully scrolled and cannot consume the scroll, we
// should chain up to its ancestor.
TEST_F(UnifiedScrollingTest, MainThreadHitTestLatchBubbling) {
CreateUncompositedScrollerAndNonFastScrollableRegion();
// Start with the scroller fully scrolled.
{
ScrollBegin(gfx::Vector2d(0, 1000));
ContinuedScrollBegin(ScrollerElementId());
ScrollUpdate(gfx::Vector2d(0, 1000));
ScrollEnd();
ASSERT_EQ(gfx::PointF(0, 50), ScrollerOffset());
}
{
ScrollStatus status = ScrollBegin(gfx::Vector2d(0, 10));
ASSERT_TRUE(status.needs_main_thread_hit_test);
status = ContinuedScrollBegin(ScrollerElementId());
// Since the hit tested scroller in ContinuedScrollBegin was fully
// scrolled, we should latch to the viewport instead.
EXPECT_TRUE(CurrentlyScrollingNode());
EXPECT_EQ(host_impl_->OuterViewportScrollNode(), CurrentlyScrollingNode());
}
}
using UnifiedScrollingDeathTest = UnifiedScrollingTest;
// A main thread hit test that with an empty target id should be dropped.
TEST_F(UnifiedScrollingDeathTest, EmptyMainThreadHitTest) {
::testing::FLAGS_gtest_death_test_style = "threadsafe";
CreateUncompositedScrollerAndNonFastScrollableRegion();
{
ElementId kInvalidId;
DCHECK(!kInvalidId);
ScrollStatus status = ScrollBegin(gfx::Vector2d(0, 10));
// Note, we have a NOTREACHED here to make sure this cannot happen. If
// DCHECKs are enabled we can just make sure we get killed when we end up
// in this situation.
#if DCHECK_IS_ON()
EXPECT_DEATH_IF_SUPPORTED({ status = ContinuedScrollBegin(kInvalidId); },
"");
#else
status = ContinuedScrollBegin(kInvalidId);
EXPECT_EQ(ScrollThread::SCROLL_IGNORED, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kNoScrollingLayer,
status.main_thread_scrolling_reasons);
#endif
}
}
// A main thread hit test that returns a scroll node we can't find should be
// dropped.
TEST_F(UnifiedScrollingTest, MainThreadHitTestScrollNodeNotFound) {
CreateUncompositedScrollerAndNonFastScrollableRegion();
{
ElementId kUnknown(42);
DCHECK(!GetPropertyTrees()->scroll_tree().FindNodeFromElementId(kUnknown));
ScrollStatus status = ScrollBegin(gfx::Vector2d(0, 10));
status = ContinuedScrollBegin(kUnknown);
EXPECT_EQ(ScrollThread::SCROLL_IGNORED, status.thread);
EXPECT_EQ(MainThreadScrollingReason::kNoScrollingLayer,
status.main_thread_scrolling_reasons);
}
}
// The presence of a squashing layer is one reason we might "fail to hit test"
// on the compositor. A heuristic is used that if the first hit scrollable
// layer isn't a scrolling ancestor of the first hit layer, we probably hit a
// squashing layer which might have empty regions we don't know how to hit
// test. This requires falling back to the main thread. However, with scroll
// unification, we may still be able to scroll the final scroller entirely on
// the compositor. See LayerTreeHostImpl::IsInitialScrollHitTestReliable.
TEST_F(UnifiedScrollingTest, SquashingLayerCausesMainThreadHitTest) {
// Create a scroller that should scroll on the compositor thread and the add
// "squashing" layer over top of it. This simulates the case where a
// squashing layer obscuring a scroller makes the hit test unreliable.
CreateScroller(MainThreadScrollingReason::kNotScrollingOnMain);
CreateSuashingLayerCoveringWholeViewport();
// When ScrollUnification is turned on, scrolling over a squashing-like layer
// that cannot be reliably hit tested on the compositor should request a main
// thread hit test.
{
ScrollStatus status = ScrollBegin(gfx::Vector2d(0, 10));
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
EXPECT_TRUE(status.needs_main_thread_hit_test);
}
// Resolving the hit test should allow the scroller underneath to scroll as
// normal on the impl thread.
{
ScrollStatus status = ContinuedScrollBegin(ScrollerElementId());
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
EXPECT_FALSE(status.needs_main_thread_hit_test);
EXPECT_TRUE(CurrentlyScrollingNode());
EXPECT_EQ(ScrollerNode(), CurrentlyScrollingNode());
}
}
// Under unified scroling, a composited scroller with a main thread scrolling
// reason should be scrolled on the compositor. Ensure ScrollBegin returns
// success without needing a main thread hit test.
TEST_F(UnifiedScrollingTest, MainThreadScrollingReasonsScrollOnCompositor) {
CreateScroller(
MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects);
{
ScrollStatus status = ScrollBegin(gfx::Vector2d(0, 10));
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD, status.thread);
EXPECT_FALSE(status.needs_main_thread_hit_test);
}
}
// This tests whether or not various kinds of scrolling mutates the transform
// tree or not. It is parameterized and used by tests below.
void UnifiedScrollingTest::TestUncompositedScrollingState(
bool mutates_transform_tree) {
TransformTree& tree = GetPropertyTrees()->transform_tree_mutable();
TransformNode* transform_node = tree.Node(ScrollerNode()->transform_id);
// Ensure we're in a clean state to start.
{
ASSERT_EQ(transform_node->element_id, ScrollerElementId());
ASSERT_TRUE(transform_node->scrolls);
ASSERT_EQ(gfx::PointF(0, 0), transform_node->scroll_offset);
ASSERT_FALSE(transform_node->transform_changed);
ASSERT_FALSE(transform_node->needs_local_transform_update);
ASSERT_FALSE(tree.needs_update());
}
// Start a scroll, ensure the scroll tree was updated and a commit was
// requested. Check that the transform tree mutation was as expected for the
// test parameter.
{
ScrollStatus status = ScrollBegin(gfx::Vector2d(0, 10));
if (status.needs_main_thread_hit_test)
ContinuedScrollBegin(ScrollerElementId());
ASSERT_EQ(ScrollerNode(), CurrentlyScrollingNode());
did_request_commit_ = false;
ScrollUpdate(gfx::Vector2d(0, 10));
ASSERT_EQ(gfx::PointF(0, 10), ScrollerOffset());
EXPECT_TRUE(did_request_commit_);
// Ensure the transform tree was updated only if expected.
if (mutates_transform_tree)
EXPECT_EQ(gfx::PointF(0, 10), transform_node->scroll_offset);
else
EXPECT_EQ(gfx::PointF(0, 0), transform_node->scroll_offset);
EXPECT_EQ(mutates_transform_tree, transform_node->transform_changed);
EXPECT_EQ(mutates_transform_tree,
transform_node->needs_local_transform_update);
EXPECT_EQ(mutates_transform_tree, tree.needs_update());
}
// Perform animated scroll update. Ensure the same things.
{
did_request_commit_ = false;
AnimatedScrollUpdate(gfx::Vector2d(0, 10));
ASSERT_TRUE(host_impl_->mutator_host()->ImplOnlyScrollAnimatingElement());
ASSERT_EQ(gfx::PointF(0, 10), ScrollerOffset());
StartAnimation();
BeginFrame(kFrameInterval);
BeginFrame(base::Milliseconds(500));
BeginFrame(kFrameInterval);
ASSERT_EQ(gfx::PointF(0, 20), ScrollerOffset());
EXPECT_TRUE(did_request_commit_);
if (mutates_transform_tree)
EXPECT_EQ(gfx::PointF(0, 20), transform_node->scroll_offset);
else
EXPECT_EQ(gfx::PointF(0, 0), transform_node->scroll_offset);
EXPECT_EQ(mutates_transform_tree, transform_node->transform_changed);
EXPECT_EQ(mutates_transform_tree,
transform_node->needs_local_transform_update);
EXPECT_EQ(mutates_transform_tree, tree.needs_update());
}
}
// When scrolling a main-thread hit tested scroller with main thread reasons,
// we should update the scroll node but the transform tree shouldn't be
// mutated. Also ensure NeedsCommit is set. A nice additional benefit of scroll
// unification should be seamless upgrade to a full compositor scroll if a main
// thread reason is removed.
TEST_F(UnifiedScrollingTest, MainThreadReasonsScrollDoesntAffectTransform) {
CreateScroller(
MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects);
TestUncompositedScrollingState(/*mutates_transform_tree=*/false);
ASSERT_EQ(ScrollerNode()->main_thread_scrolling_reasons,
MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects);
TransformTree& tree = GetPropertyTrees()->transform_tree_mutable();
TransformNode* transform_node = tree.Node(ScrollerNode()->transform_id);
// Removing the main thread reason bit should start mutating the transform
// tree.
{
ScrollerNode()->main_thread_scrolling_reasons =
MainThreadScrollingReason::kNotScrollingOnMain;
UpdateDrawProperties(host_impl_->active_tree());
host_impl_->active_tree()->DidBecomeActive();
ScrollUpdate(gfx::Vector2d(0, 10));
ASSERT_EQ(gfx::PointF(0, 30), ScrollerOffset());
// The transform node should now be updated by the scroll.
EXPECT_EQ(gfx::PointF(0, 30), transform_node->scroll_offset);
EXPECT_TRUE(transform_node->transform_changed);
EXPECT_TRUE(transform_node->needs_local_transform_update);
EXPECT_TRUE(tree.needs_update());
}
ScrollEnd();
}
// When scrolling an uncomposited scroller, we shouldn't modify the transform
// tree. If a scroller is promoted mid-scroll it should start mutating the
// transform tree.
TEST_F(UnifiedScrollingTest, UncompositedScrollerDoesntAffectTransform) {
CreateUncompositedScrollerAndNonFastScrollableRegion();
TestUncompositedScrollingState(/*mutates_transform_tree=*/false);
ASSERT_FALSE(ScrollerNode()->is_composited);
TransformTree& tree = GetPropertyTrees()->transform_tree_mutable();
TransformNode* transform_node = tree.Node(ScrollerNode()->transform_id);
// Marking the node as composited should start updating the transform tree.
{
ScrollerNode()->is_composited = true;
UpdateDrawProperties(host_impl_->active_tree());
host_impl_->active_tree()->DidBecomeActive();
ScrollUpdate(gfx::Vector2d(0, 10));
ASSERT_EQ(gfx::PointF(0, 30), ScrollerOffset());
// The transform node should now be updated by the scroll.
EXPECT_EQ(gfx::PointF(0, 30), transform_node->scroll_offset);
EXPECT_TRUE(transform_node->transform_changed);
EXPECT_TRUE(transform_node->needs_local_transform_update);
EXPECT_TRUE(tree.needs_update());
}
ScrollEnd();
}
// When scrolling a composited scroller that just happens to have needed a main
// thread hit test first, we should modify the transform tree as usual.
TEST_F(UnifiedScrollingTest, CompositedWithSquashedLayerMutatesTransform) {
CreateScroller(MainThreadScrollingReason::kNotScrollingOnMain);
CreateSuashingLayerCoveringWholeViewport();
TestUncompositedScrollingState(/*mutates_transform_tree=*/true);
ScrollEnd();
}
// Verifies that when a surface layer is occluded, its frame sink id will be
// marked as qualified for throttling.
TEST_F(OccludedSurfaceThrottlingLayerTreeHostImplTest,
ThrottleOccludedSurface) {
LayerTreeImpl* tree = host_impl_->active_tree();
gfx::Rect viewport_rect(0, 0, 800, 600);
auto* root = SetupRootLayer<LayerImpl>(tree, viewport_rect.size());
auto* occluded = AddLayer<SurfaceLayerImpl>(tree);
occluded->SetBounds(gfx::Size(400, 300));
occluded->SetDrawsContent(true);
viz::SurfaceId start = MakeSurfaceId(viz::FrameSinkId(1, 2), 1);
viz::SurfaceId end = MakeSurfaceId(viz::FrameSinkId(3, 4), 1);
occluded->SetRange(viz::SurfaceRange(start, end), 2u);
CopyProperties(root, occluded);
auto* occluder = AddLayer<SolidColorLayerImpl>(tree);
occluder->SetBounds(gfx::Size(400, 400));
occluder->SetDrawsContent(true);
occluder->SetContentsOpaque(true);
CopyProperties(root, occluder);
DrawFrame();
EXPECT_EQ(host_impl_->GetFrameSinksToThrottleForTesting(),
base::flat_set<viz::FrameSinkId>{end.frame_sink_id()});
}
TEST_F(LayerTreeHostImplTest, FrameElementIdHitTestSimple) {
SetupDefaultRootLayer();
LayerImpl* frame_layer = AddLayer();
frame_layer->SetBounds(gfx::Size(50, 50));
frame_layer->SetDrawsContent(true);
frame_layer->SetHitTestable(true);
CopyProperties(root_layer(), frame_layer);
CreateTransformNode(frame_layer).visible_frame_element_id = ElementId(0x10);
UpdateDrawProperties(host_impl_->active_tree());
EXPECT_EQ(GetInputHandler().FindFrameElementIdAtPoint(gfx::PointF(10, 10)),
ElementId(0x10));
}
TEST_F(LayerTreeHostImplTest, FrameElementIdHitTestInheritance) {
SetupDefaultRootLayer();
LayerImpl* frame_layer = AddLayer();
frame_layer->SetBounds(gfx::Size(50, 50));
frame_layer->SetHitTestable(true);
CopyProperties(root_layer(), frame_layer);
CreateTransformNode(frame_layer, root_layer()->transform_tree_index())
.visible_frame_element_id = ElementId(0x20);
// Create a child layer with no associated frame, but with the above frame
// layer as a parent.
LayerImpl* child_layer = AddLayer();
child_layer->SetBounds(gfx::Size(50, 50));
child_layer->SetHitTestable(true);
CopyProperties(root_layer(), child_layer);
auto& child_node =
CreateTransformNode(child_layer, frame_layer->transform_tree_index());
child_node.parent_frame_id = frame_layer->transform_tree_index();
child_layer->SetOffsetToTransformParent(gfx::Vector2dF(25, 25));
UpdateDrawProperties(host_impl_->active_tree());
// Hit tests on the parent should return the parent's frame element ID.
EXPECT_EQ(GetInputHandler().FindFrameElementIdAtPoint(gfx::PointF(15, 15)),
ElementId(0x20));
// Ensure that hit tests on the child (non-frame) layer returns the frame
// element id of its parent.
EXPECT_EQ(GetInputHandler().FindFrameElementIdAtPoint(gfx::PointF(60, 60)),
ElementId(0x20));
}
TEST_F(LayerTreeHostImplTest, FrameElementIdHitTestOverlap) {
SetupDefaultRootLayer();
LayerImpl* frame_layer = AddLayer();
frame_layer->SetBounds(gfx::Size(50, 50));
frame_layer->SetHitTestable(true);
CopyProperties(root_layer(), frame_layer);
CreateTransformNode(frame_layer).visible_frame_element_id = ElementId(0x10);
LayerImpl* occluding_frame_layer = AddLayer();
occluding_frame_layer->SetBounds(gfx::Size(50, 50));
occluding_frame_layer->SetHitTestable(true);
CopyProperties(root_layer(), occluding_frame_layer);
auto& occluding_frame_node = CreateTransformNode(
occluding_frame_layer, frame_layer->transform_tree_index());
occluding_frame_node.visible_frame_element_id = ElementId(0x20);
occluding_frame_node.parent_frame_id = frame_layer->transform_tree_index();
occluding_frame_layer->SetOffsetToTransformParent(gfx::Vector2dF(25, 25));
UpdateDrawProperties(host_impl_->active_tree());
// Both frame layers should return their own frame element IDs, despite
// overlapping.
EXPECT_EQ(GetInputHandler().FindFrameElementIdAtPoint(gfx::PointF(15, 15)),
ElementId(0x10));
EXPECT_EQ(GetInputHandler().FindFrameElementIdAtPoint(gfx::PointF(30, 30)),
ElementId(0x20));
}
TEST_F(LayerTreeHostImplTest, FrameElementIdHitTestOverlapSimpleClip) {
SetupDefaultRootLayer();
LayerImpl* frame_layer = AddLayer();
frame_layer->SetBounds(gfx::Size(50, 50));
frame_layer->SetHitTestable(true);
CopyProperties(root_layer(), frame_layer);
CreateTransformNode(frame_layer).visible_frame_element_id = ElementId(0x10);
LayerImpl* clipped_frame_layer = AddLayer();
clipped_frame_layer->SetBounds(gfx::Size(50, 50));
clipped_frame_layer->SetHitTestable(true);
CopyProperties(root_layer(), clipped_frame_layer);
CreateTransformNode(clipped_frame_layer).visible_frame_element_id =
ElementId(0x20);
clipped_frame_layer->SetOffsetToTransformParent(gfx::Vector2dF(25, 25));
// Create a clip excluding the overlapped region.
auto& clip_node = CreateClipNode(clipped_frame_layer);
clip_node.clip = gfx::RectF(40, 40, 10, 10);
UpdateDrawProperties(host_impl_->active_tree());
// Ensure that the overlapping (clipped) layer isn't targeted.
EXPECT_EQ(GetInputHandler().FindFrameElementIdAtPoint(gfx::PointF(30, 30)),
ElementId(0x10));
}
TEST_F(LayerTreeHostImplTest, FrameElementIdHitTestOverlapRoundedCorners) {
SetupDefaultRootLayer();
LayerImpl* frame_layer = AddLayer();
frame_layer->SetBounds(gfx::Size(50, 50));
frame_layer->SetHitTestable(true);
CopyProperties(root_layer(), frame_layer);
CreateTransformNode(frame_layer).visible_frame_element_id = ElementId(0x10);
LayerImpl* rounded_frame_layer = AddLayer();
rounded_frame_layer->SetBounds(gfx::Size(50, 50));
rounded_frame_layer->SetHitTestable(true);
CopyProperties(root_layer(), rounded_frame_layer);
CreateTransformNode(rounded_frame_layer, frame_layer->transform_tree_index())
.visible_frame_element_id = ElementId(0x20);
rounded_frame_layer->SetOffsetToTransformParent(gfx::Vector2dF(25, 25));
// Add rounded corners to the layer, which are unable to be hit tested by the
// simple quad-based logic.
CreateEffectNode(rounded_frame_layer).mask_filter_info =
gfx::MaskFilterInfo(gfx::RRectF(25, 25, 50, 50, 5));
UpdateDrawProperties(host_impl_->active_tree());
// The lookup should bail out in the presence of a complex clip/mask on the
// target chain.
EXPECT_FALSE(
GetInputHandler().FindFrameElementIdAtPoint(gfx::PointF(30, 30)));
}
TEST_F(LayerTreeHostImplTest, FrameElementIdHitTestOverlapSibling) {
SetupDefaultRootLayer();
LayerImpl* frame_layer = AddLayer();
frame_layer->SetBounds(gfx::Size(50, 50));
frame_layer->SetHitTestable(true);
CopyProperties(root_layer(), frame_layer);
CreateTransformNode(frame_layer, root_layer()->transform_tree_index())
.visible_frame_element_id = ElementId(0x20);
LayerImpl* sibling_frame_layer = AddLayer();
sibling_frame_layer->SetBounds(gfx::Size(50, 50));
sibling_frame_layer->SetHitTestable(true);
CopyProperties(root_layer(), sibling_frame_layer);
CreateTransformNode(sibling_frame_layer, root_layer()->transform_tree_index())
.visible_frame_element_id = ElementId(0x30);
sibling_frame_layer->SetOffsetToTransformParent(gfx::Vector2dF(25, 25));
UpdateDrawProperties(host_impl_->active_tree());
EXPECT_EQ(GetInputHandler().FindFrameElementIdAtPoint(gfx::PointF(15, 15)),
ElementId(0x20));
EXPECT_EQ(GetInputHandler().FindFrameElementIdAtPoint(gfx::PointF(60, 60)),
ElementId(0x30));
// If we have a layer occluded by a layer from another document, attributions
// should be discarded outside of the simple frame -> subframe case.
EXPECT_FALSE(
GetInputHandler().FindFrameElementIdAtPoint(gfx::PointF(30, 30)));
}
TEST_F(LayerTreeHostImplTest, ViewTransitionRequestCausesDamage) {
const gfx::Size viewport_size(100, 100);
SetupDefaultRootLayer(viewport_size);
UpdateDrawProperties(host_impl_->active_tree());
const gfx::Transform draw_transform;
const gfx::Rect draw_viewport(viewport_size);
bool resourceless_software_draw = false;
// Clear any damage.
host_impl_->OnDraw(draw_transform, draw_viewport, resourceless_software_draw,
false);
last_on_draw_frame_.reset();
did_request_redraw_ = false;
// Ensure there is no damage.
host_impl_->OnDraw(draw_transform, draw_viewport, resourceless_software_draw,
false);
EXPECT_FALSE(did_request_redraw_);
EXPECT_TRUE(last_on_draw_frame_->has_no_damage);
last_on_draw_frame_.reset();
did_request_redraw_ = false;
// Adding a transition effect should cause us to redraw.
host_impl_->active_tree()->AddViewTransitionRequest(
ViewTransitionRequest::CreateAnimateRenderer(
/*document_tag=*/0, viz::NavigationID::Null()));
// Ensure there is damage and we requested a redraw.
host_impl_->OnDraw(draw_transform, draw_viewport, resourceless_software_draw,
false);
EXPECT_TRUE(did_request_redraw_);
EXPECT_FALSE(last_on_draw_frame_->has_no_damage);
}
TEST_F(LayerTreeHostImplTest, CollectRegionCaptureBounds) {
const auto kFirstId = viz::RegionCaptureCropId::CreateRandom();
const auto kSecondId = viz::RegionCaptureCropId::CreateRandom();
const auto kThirdId = viz::RegionCaptureCropId::CreateRandom();
const auto kFourthId = viz::RegionCaptureCropId::CreateRandom();
const viz::RegionCaptureBounds kRootBounds{
{{kFirstId, gfx::Rect{0, 0, 250, 250}}, {kSecondId, gfx::Rect{}}}};
const viz::RegionCaptureBounds kChildBounds{
{{kThirdId, gfx::Rect{5, 6, 300, 400}}}};
const viz::RegionCaptureBounds kSecondChildBounds{
{{kFourthId, gfx::Rect{20, 10, 400, 500}}}};
// Set up the root layer.
LayerImpl* root_layer = SetupDefaultRootLayer(gfx::Size(350, 360));
root_layer->SetCaptureBounds(kRootBounds);
// Set up a child layer, with a scaling transform.
LayerImpl* child_layer = AddLayer();
CopyProperties(root_layer, child_layer);
child_layer->SetCaptureBounds(kChildBounds);
gfx::Transform child_layer_transform;
child_layer_transform.Scale(2.0, 3.0);
child_layer->draw_properties().screen_space_transform =
std::move(child_layer_transform);
// Set up another child layer, with a rotation transform.
LayerImpl* second_child_layer = AddLayer();
CopyProperties(root_layer, second_child_layer);
second_child_layer->SetCaptureBounds(kSecondChildBounds);
gfx::Transform second_layer_transform;
second_layer_transform.Rotate(45);
second_child_layer->draw_properties().screen_space_transform =
std::move(second_layer_transform);
// Set up the drawable content rect and transforms for the root surface.
// Drawing the frame sets up the RenderSurfaceImpl in the backend.
UpdateDrawProperties(host_impl_->active_tree());
DrawFrame();
// NOTE: setting contribution has to be done after updating and drawing, and
// causes the layers to use draw_properties().screen_screen_transform instead
// of using values from the transform tree.
child_layer->set_contributes_to_drawn_render_surface(true);
second_child_layer->set_contributes_to_drawn_render_surface(true);
// Actually collect the region capture bounds.
const viz::RegionCaptureBounds collected_bounds =
host_impl_->CollectRegionCaptureBounds();
EXPECT_EQ(4u, collected_bounds.bounds().size());
// Validate expectations.
EXPECT_EQ((gfx::Rect{0, 0, 250, 250}),
collected_bounds.bounds().find(kFirstId)->second);
EXPECT_EQ((gfx::Rect{}), collected_bounds.bounds().find(kSecondId)->second);
// The third case is more interesting: the bounds are scaled 2x and 3x,
// which changes the origin but also causes both bounds to clip at the
// content rect.
EXPECT_EQ((gfx::Rect{10, 18, 340, 342}),
collected_bounds.bounds().find(kThirdId)->second);
// Finally, test a rotation instead of a simple scaling.
EXPECT_EQ((gfx::Rect{0, 21, 290, 339}),
collected_bounds.bounds().find(kFourthId)->second);
}
// Check if picturelayer's ScrollInteractionInProgress() return true even when
// BrowserControl is consuming ScrollUpdate.
TEST_P(LayerTreeHostImplBrowserControlsTest,
BrowserControlsScrollInteractionInProgress) {
gfx::Size inner_size = gfx::Size(100, 100);
gfx::Size outer_size = gfx::Size(100, 100);
gfx::Size content_size = gfx::Size(100, 200);
SetupBrowserControlsAndScrollLayerWithVirtualViewport(inner_size, outer_size,
content_size);
LayerTreeImpl* active_tree = host_impl_->active_tree();
// Create a content layer beneath the outer viewport scroll layer.
scoped_refptr<FakeRasterSource> raster_source(
FakeRasterSource::CreateFilled(content_size));
auto* picture_layer =
AddLayer<FakePictureLayerImpl>(host_impl_->active_tree(), raster_source);
CopyProperties(OuterViewportScrollLayer(), picture_layer);
picture_layer->SetBounds(content_size);
picture_layer->SetDrawsContent(true);
picture_layer->SetNeedsPushProperties();
active_tree->PushPageScaleFromMainThread(1.0f, 1.0f, 2.0f);
DrawFrame();
EXPECT_EQ(ScrollThread::SCROLL_ON_IMPL_THREAD,
GetInputHandler()
.ScrollBegin(BeginState(gfx::Point(), gfx::Vector2dF(0, 50),
ui::ScrollInputType::kTouchscreen)
.get(),
ui::ScrollInputType::kTouchscreen)
.thread);
// shownratio == 1
EXPECT_EQ(1, host_impl_->active_tree()->CurrentTopControlsShownRatio());
EXPECT_EQ(picture_layer->ScrollInteractionInProgress(), false);
// 0 < shownratio <1
GetInputHandler().ScrollUpdate(UpdateState(gfx::Point(),
gfx::Vector2dF(0, 25),
ui::ScrollInputType::kTouchscreen)
.get());
EXPECT_GT(host_impl_->active_tree()->CurrentTopControlsShownRatio(), 0);
EXPECT_LT(host_impl_->active_tree()->CurrentTopControlsShownRatio(), 1);
EXPECT_EQ(picture_layer->ScrollInteractionInProgress(), true);
GetInputHandler().ScrollUpdate(UpdateState(gfx::Point(),
gfx::Vector2dF(0, 30),
ui::ScrollInputType::kTouchscreen)
.get());
// now shownratio == 0
EXPECT_EQ(0, host_impl_->active_tree()->CurrentTopControlsShownRatio());
EXPECT_EQ(picture_layer->ScrollInteractionInProgress(), true);
GetInputHandler().ScrollEnd();
// scroll end, shownratio == 0
EXPECT_EQ(0, host_impl_->active_tree()->CurrentTopControlsShownRatio());
EXPECT_EQ(picture_layer->ScrollInteractionInProgress(), false);
}
} // namespace cc