Print Preview Refresh: Fix some destinations sizing issues
- Expand line heights & add margin so that the header is the right
height and the focus highlight for "Manage" doesn't get cut off.
- Set min-height 0 on the list container flex child so that it can
shrink. Otherwise, odd bugs occur since it stays the height of the
content.
Bug: 888411, 888412
Change-Id: I4d61b7c5c2e41bacc29695f3588c20070182c16a
Reviewed-on: https://chromium-review.googlesource.com/1241973
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594030}diff --git a/chrome/browser/resources/print_preview/new/destination_dialog.html b/chrome/browser/resources/print_preview/new/destination_dialog.html
index fe21ce5..efedf4d1b 100644
--- a/chrome/browser/resources/print_preview/new/destination_dialog.html
+++ b/chrome/browser/resources/print_preview/new/destination_dialog.html
@@ -54,7 +54,7 @@
}
.user-info {
- font-size: calc(13/15 * 1em);
+ font-size: calc(13 / 15 * 1em);
line-height: normal;
margin-bottom: 14px;
margin-top: 8px;
@@ -77,7 +77,7 @@
/* Height = 3 * destination item (28px) + 10px padding + 1 line text */
#recentList {
flex: 0;
- min-height: calc(94px + 1rem);
+ min-height: calc(94px + 20 / 13 * 1rem);
padding-bottom: 18px;
}
@@ -85,12 +85,12 @@
/* header (82px + 1 line) - button (64px) - 2px spinner - 2px extra */
#printList {
flex: 1;
- min-height: calc(94px + 1rem);
+ min-height: calc(94px + 20 / 13 * 1rem);
padding-bottom: 0;
}
paper-button {
- font-size: calc(12/13 * 1em);
+ font-size: calc(12 / 13 * 1em);
}
#dialog #promos {
@@ -140,7 +140,7 @@
#invitationPromo invitation-details {
color: var(--google-grey-refresh-700);
- font-size: calc(10/13 * 1em);
+ font-size: calc(10 / 13 * 1em);
font-weight: 500;
}
</style>
diff --git a/chrome/browser/resources/print_preview/new/destination_list.html b/chrome/browser/resources/print_preview/new/destination_list.html
index 28a0125..0a74336 100644
--- a/chrome/browser/resources/print_preview/new/destination_list.html
+++ b/chrome/browser/resources/print_preview/new/destination_list.html
@@ -26,6 +26,7 @@
#listContainer {
flex: 1;
+ min-height: 0;
}
.title,
@@ -39,7 +40,8 @@
border-bottom: 2px solid var(--google-grey-300);
display: flex;
flex: 0;
- min-height: 1em;
+ margin-top: 2px;
+ min-height: calc(20/13 * 1em);
padding-bottom: 8px;
}
