commit | 196a48bb90a8dd70b666178087d2d105ffd61cff | [log] [tgz] |
---|---|---|
author | Fergus Dall <sidereal@google.com> | Tue Jan 25 07:15:29 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Jan 25 07:15:29 2022 |
tree | 86f623ad680042c476616869f01f5ffceb6be2f4 | |
parent | cd64ab02706bf380190336c08e6f6021122815d2 [diff] |
crostini_upgrader: Update to match UI feedback Changes: - Change the string that tells the user about our new log file into two strings for failure/success - Stop showing the error icon when we display error logs - Double the default height of the log box, since we now have more space - Re-add the bottom margin to the error icon that was reduced in CL:2340352 and removed in CL:3312456. This was done to make more space for the logs, but no longer makes sense since they're now mutally exclusive. - Make the close/cancel button align right when it's the only button. This was failing due to improper use of the "close-button" class, which includes an unconditional 8 pixel margin on the right. Instead we should specify the gap in the container, where it will only be inserted *between* elements. - In the UPGRADE_ERROR and ERROR states put the "close" label on the cancel button, rather then "cancel", as we do in the RESTORE_SUCCEEDED and SUCCEEDED states. - Only show the "close" button in the RESTORE_SUCCEEDED rather then also showing the "done" button. - Show the default illustration in the BACKUP and UPGRADING states instead of leaving the space blank. - Remove the close and minimise buttons at the top of the dialogue Bug: 1217902 Change-Id: Iec8c5b8ee7bd14719ffe655dbbc4f2573e20ae81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3372525 Reviewed-by: David Munro <davidmunro@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/main@{#962882}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.