| // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| // Use of this source code is governed by a BSD-style license that can be |
| // found in the LICENSE file. |
| |
| #include "components/policy/core/common/policy_service_impl.h" |
| |
| #include <memory> |
| #include <utility> |
| |
| #include "base/bind.h" |
| #include "base/bind_helpers.h" |
| #include "base/callback.h" |
| #include "base/macros.h" |
| #include "base/run_loop.h" |
| #include "base/test/task_environment.h" |
| #include "base/values.h" |
| #include "components/policy/core/common/extension_policy_migrator.h" |
| #include "components/policy/core/common/external_data_fetcher.h" |
| #include "components/policy/core/common/mock_configuration_policy_provider.h" |
| #include "components/policy/core/common/mock_policy_service.h" |
| #include "components/policy/core/common/policy_types.h" |
| #include "components/policy/policy_constants.h" |
| #include "components/strings/grit/components_strings.h" |
| #include "testing/gmock/include/gmock/gmock.h" |
| #include "testing/gtest/include/gtest/gtest.h" |
| |
| using ::testing::_; |
| using ::testing::AnyNumber; |
| using ::testing::Invoke; |
| using ::testing::Mock; |
| using ::testing::Return; |
| |
| namespace policy { |
| |
| namespace { |
| |
| const char kExtension[] = "extension-id"; |
| const char kSameLevelPolicy[] = "policy-same-level-and-scope"; |
| const char kDiffLevelPolicy[] = "chrome-diff-level-and-scope"; |
| |
| // Helper to compare the arguments to an EXPECT_CALL of OnPolicyUpdated() with |
| // their expected values. |
| MATCHER_P(PolicyEquals, expected, "") { |
| return arg.Equals(*expected); |
| } |
| |
| // Helper to compare the arguments to an EXPECT_CALL of OnPolicyValueUpdated() |
| // with their expected values. |
| MATCHER_P(ValueEquals, expected, "") { |
| return *expected == *arg; |
| } |
| |
| // Helper that fills |bundle| with test policies. |
| void AddTestPolicies(PolicyBundle* bundle, |
| const char* value, |
| PolicyLevel level, |
| PolicyScope scope) { |
| PolicyMap* policy_map = |
| &bundle->Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string())); |
| policy_map->Set(kSameLevelPolicy, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_ENTERPRISE_DEFAULT, base::Value(value), |
| nullptr); |
| policy_map->Set(kDiffLevelPolicy, level, scope, POLICY_SOURCE_PLATFORM, |
| base::Value(value), nullptr); |
| policy_map = |
| &bundle->Get(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, kExtension)); |
| policy_map->Set(kSameLevelPolicy, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_ENTERPRISE_DEFAULT, base::Value(value), |
| nullptr); |
| policy_map->Set(kDiffLevelPolicy, level, scope, POLICY_SOURCE_PLATFORM, |
| base::Value(value), nullptr); |
| } |
| |
| // Observer class that changes the policy in the passed provider when the |
| // callback is invoked. |
| class ChangePolicyObserver : public PolicyService::Observer { |
| public: |
| explicit ChangePolicyObserver(MockConfigurationPolicyProvider* provider) |
| : provider_(provider), |
| observer_invoked_(false) {} |
| |
| void OnPolicyUpdated(const PolicyNamespace&, |
| const PolicyMap& previous, |
| const PolicyMap& current) override { |
| PolicyMap new_policy; |
| new_policy.Set("foo", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_CLOUD, base::Value(14), nullptr); |
| provider_->UpdateChromePolicy(new_policy); |
| observer_invoked_ = true; |
| } |
| |
| bool observer_invoked() const { return observer_invoked_; } |
| |
| private: |
| MockConfigurationPolicyProvider* provider_; |
| bool observer_invoked_; |
| }; |
| |
| class MockPolicyMigrator : public ExtensionPolicyMigrator { |
| public: |
| MOCK_METHOD1(Migrate, void(PolicyBundle* bundle)); |
| }; |
| |
| } // namespace |
| |
| class PolicyServiceTest : public testing::Test { |
| public: |
| PolicyServiceTest() = default; |
| void SetUp() override { |
| EXPECT_CALL(provider0_, IsInitializationComplete(_)) |
| .WillRepeatedly(Return(true)); |
| EXPECT_CALL(provider1_, IsInitializationComplete(_)) |
| .WillRepeatedly(Return(true)); |
| EXPECT_CALL(provider2_, IsInitializationComplete(_)) |
| .WillRepeatedly(Return(true)); |
| |
| provider0_.Init(); |
| provider1_.Init(); |
| provider2_.Init(); |
| |
| policy0_.Set("pre", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_ENTERPRISE_DEFAULT, base::Value(13), nullptr); |
| provider0_.UpdateChromePolicy(policy0_); |
| |
| PolicyServiceImpl::Providers providers; |
| providers.push_back(&provider0_); |
| providers.push_back(&provider1_); |
| providers.push_back(&provider2_); |
| auto migrator = std::make_unique<MockPolicyMigrator>(); |
| EXPECT_CALL(*migrator, Migrate(_)) |
| .WillRepeatedly(Invoke([](PolicyBundle* bundle) { |
| bundle->Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string())) |
| .Set("migrated", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_PLATFORM, base::Value(15), nullptr); |
| })); |
| PolicyServiceImpl::Migrators migrators; |
| migrators.push_back(std::move(migrator)); |
| policy_service_ = std::make_unique<PolicyServiceImpl>(std::move(providers), |
| std::move(migrators)); |
| } |
| |
| void TearDown() override { |
| provider0_.Shutdown(); |
| provider1_.Shutdown(); |
| provider2_.Shutdown(); |
| } |
| |
| MOCK_METHOD2(OnPolicyValueUpdated, void(const base::Value*, |
| const base::Value*)); |
| |
| MOCK_METHOD0(OnPolicyRefresh, void()); |
| |
| // Returns true if the policies for namespace |ns| match |expected|. |
| bool VerifyPolicies(const PolicyNamespace& ns, |
| const PolicyMap& expected) { |
| return policy_service_->GetPolicies(ns).Equals(expected); |
| } |
| |
| void RunUntilIdle() { |
| base::RunLoop loop; |
| loop.RunUntilIdle(); |
| } |
| |
| protected: |
| base::test::SingleThreadTaskEnvironment task_environment_; |
| MockConfigurationPolicyProvider provider0_; |
| MockConfigurationPolicyProvider provider1_; |
| MockConfigurationPolicyProvider provider2_; |
| PolicyMap policy0_; |
| PolicyMap policy1_; |
| PolicyMap policy2_; |
| std::unique_ptr<PolicyServiceImpl> policy_service_; |
| |
| private: |
| DISALLOW_COPY_AND_ASSIGN(PolicyServiceTest); |
| }; |
| |
| TEST_F(PolicyServiceTest, LoadsPoliciesBeforeProvidersRefresh) { |
| PolicyMap expected; |
| expected.Set("pre", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_ENTERPRISE_DEFAULT, base::Value(13), nullptr); |
| expected.Set("migrated", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_PLATFORM, base::Value(15), nullptr); |
| EXPECT_TRUE(VerifyPolicies( |
| PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()), expected)); |
| } |
| |
| TEST_F(PolicyServiceTest, NotifyObservers) { |
| MockPolicyServiceObserver observer; |
| policy_service_->AddObserver(POLICY_DOMAIN_CHROME, &observer); |
| |
| PolicyMap expectedPrevious; |
| expectedPrevious.Set("pre", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_ENTERPRISE_DEFAULT, base::Value(13), |
| nullptr); |
| expectedPrevious.Set("migrated", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_PLATFORM, base::Value(15), nullptr); |
| |
| PolicyMap expectedCurrent; |
| expectedCurrent.CopyFrom(expectedPrevious); |
| expectedCurrent.Set("aaa", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_CLOUD, base::Value(123), nullptr); |
| policy0_.Set("aaa", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_CLOUD, base::Value(123), nullptr); |
| EXPECT_CALL(observer, OnPolicyUpdated(PolicyNamespace(POLICY_DOMAIN_CHROME, |
| std::string()), |
| PolicyEquals(&expectedPrevious), |
| PolicyEquals(&expectedCurrent))); |
| provider0_.UpdateChromePolicy(policy0_); |
| Mock::VerifyAndClearExpectations(&observer); |
| |
| // No changes. |
| EXPECT_CALL(observer, OnPolicyUpdated(_, _, _)).Times(0); |
| provider0_.UpdateChromePolicy(policy0_); |
| Mock::VerifyAndClearExpectations(&observer); |
| EXPECT_TRUE(VerifyPolicies( |
| PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()), expectedCurrent)); |
| |
| // New policy. |
| expectedPrevious.CopyFrom(expectedCurrent); |
| expectedCurrent.Set("bbb", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_CLOUD, base::Value(456), nullptr); |
| policy0_.Set("bbb", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_CLOUD, base::Value(456), nullptr); |
| EXPECT_CALL(observer, OnPolicyUpdated(PolicyNamespace(POLICY_DOMAIN_CHROME, |
| std::string()), |
| PolicyEquals(&expectedPrevious), |
| PolicyEquals(&expectedCurrent))); |
| provider0_.UpdateChromePolicy(policy0_); |
| Mock::VerifyAndClearExpectations(&observer); |
| |
| // Removed policy. |
| expectedPrevious.CopyFrom(expectedCurrent); |
| expectedCurrent.Erase("bbb"); |
| policy0_.Erase("bbb"); |
| EXPECT_CALL(observer, OnPolicyUpdated(PolicyNamespace(POLICY_DOMAIN_CHROME, |
| std::string()), |
| PolicyEquals(&expectedPrevious), |
| PolicyEquals(&expectedCurrent))); |
| provider0_.UpdateChromePolicy(policy0_); |
| Mock::VerifyAndClearExpectations(&observer); |
| |
| // Changed policy. |
| expectedPrevious.CopyFrom(expectedCurrent); |
| expectedCurrent.Set("aaa", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_CLOUD, base::Value(789), nullptr); |
| policy0_.Set("aaa", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_CLOUD, base::Value(789), nullptr); |
| |
| EXPECT_CALL(observer, OnPolicyUpdated(PolicyNamespace(POLICY_DOMAIN_CHROME, |
| std::string()), |
| PolicyEquals(&expectedPrevious), |
| PolicyEquals(&expectedCurrent))); |
| provider0_.UpdateChromePolicy(policy0_); |
| Mock::VerifyAndClearExpectations(&observer); |
| |
| // No changes again. |
| EXPECT_CALL(observer, OnPolicyUpdated(_, _, _)).Times(0); |
| provider0_.UpdateChromePolicy(policy0_); |
| Mock::VerifyAndClearExpectations(&observer); |
| EXPECT_TRUE(VerifyPolicies( |
| PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()), expectedCurrent)); |
| |
| policy_service_->RemoveObserver(POLICY_DOMAIN_CHROME, &observer); |
| } |
| |
| TEST_F(PolicyServiceTest, NotifyObserversInMultipleNamespaces) { |
| const std::string kExtension0("extension-0"); |
| const std::string kExtension1("extension-1"); |
| const std::string kExtension2("extension-2"); |
| MockPolicyServiceObserver chrome_observer; |
| MockPolicyServiceObserver extension_observer; |
| policy_service_->AddObserver(POLICY_DOMAIN_CHROME, &chrome_observer); |
| policy_service_->AddObserver(POLICY_DOMAIN_EXTENSIONS, &extension_observer); |
| |
| PolicyMap previous_policy_map; |
| previous_policy_map.Set("pre", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_ENTERPRISE_DEFAULT, base::Value(13), |
| nullptr); |
| previous_policy_map.Set("migrated", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_PLATFORM, base::Value(15), nullptr); |
| PolicyMap policy_map; |
| policy_map.CopyFrom(previous_policy_map); |
| policy_map.Set("policy", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_CLOUD, base::Value("value"), nullptr); |
| |
| auto bundle = std::make_unique<PolicyBundle>(); |
| // The initial setup includes a policy for chrome that is now changing. |
| bundle->Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string())) |
| .CopyFrom(policy_map); |
| bundle->Get(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, kExtension0)) |
| .CopyFrom(policy_map); |
| bundle->Get(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, kExtension1)) |
| .CopyFrom(policy_map); |
| |
| const PolicyMap kEmptyPolicyMap; |
| EXPECT_CALL( |
| chrome_observer, |
| OnPolicyUpdated(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()), |
| PolicyEquals(&previous_policy_map), |
| PolicyEquals(&policy_map))); |
| EXPECT_CALL( |
| extension_observer, |
| OnPolicyUpdated(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, kExtension0), |
| PolicyEquals(&kEmptyPolicyMap), |
| PolicyEquals(&policy_map))); |
| EXPECT_CALL( |
| extension_observer, |
| OnPolicyUpdated(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, kExtension1), |
| PolicyEquals(&kEmptyPolicyMap), |
| PolicyEquals(&policy_map))); |
| provider0_.UpdatePolicy(std::move(bundle)); |
| RunUntilIdle(); |
| Mock::VerifyAndClearExpectations(&chrome_observer); |
| Mock::VerifyAndClearExpectations(&extension_observer); |
| |
| // Chrome policy stays the same, kExtension0 is gone, kExtension1 changes, |
| // and kExtension2 is new. |
| previous_policy_map.CopyFrom(policy_map); |
| bundle.reset(new PolicyBundle()); |
| bundle->Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string())) |
| .CopyFrom(policy_map); |
| policy_map.Set("policy", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_CLOUD, base::Value("another value"), nullptr); |
| bundle->Get(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, kExtension1)) |
| .CopyFrom(policy_map); |
| bundle->Get(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, kExtension2)) |
| .CopyFrom(policy_map); |
| |
| EXPECT_CALL(chrome_observer, OnPolicyUpdated(_, _, _)).Times(0); |
| EXPECT_CALL( |
| extension_observer, |
| OnPolicyUpdated(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, kExtension0), |
| PolicyEquals(&previous_policy_map), |
| PolicyEquals(&kEmptyPolicyMap))); |
| EXPECT_CALL( |
| extension_observer, |
| OnPolicyUpdated(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, kExtension1), |
| PolicyEquals(&previous_policy_map), |
| PolicyEquals(&policy_map))); |
| EXPECT_CALL( |
| extension_observer, |
| OnPolicyUpdated(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, kExtension2), |
| PolicyEquals(&kEmptyPolicyMap), |
| PolicyEquals(&policy_map))); |
| provider0_.UpdatePolicy(std::move(bundle)); |
| RunUntilIdle(); |
| Mock::VerifyAndClearExpectations(&chrome_observer); |
| Mock::VerifyAndClearExpectations(&extension_observer); |
| |
| policy_service_->RemoveObserver(POLICY_DOMAIN_CHROME, &chrome_observer); |
| policy_service_->RemoveObserver(POLICY_DOMAIN_EXTENSIONS, |
| &extension_observer); |
| } |
| |
| TEST_F(PolicyServiceTest, ObserverChangesPolicy) { |
| ChangePolicyObserver observer(&provider0_); |
| policy_service_->AddObserver(POLICY_DOMAIN_CHROME, &observer); |
| policy0_.Set("aaa", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_CLOUD, base::Value(123), nullptr); |
| policy0_.Set("bbb", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_CLOUD, base::Value(1234), nullptr); |
| // Should not crash. |
| provider0_.UpdateChromePolicy(policy0_); |
| policy_service_->RemoveObserver(POLICY_DOMAIN_CHROME, &observer); |
| EXPECT_TRUE(observer.observer_invoked()); |
| } |
| |
| TEST_F(PolicyServiceTest, HasProvider) { |
| MockConfigurationPolicyProvider other_provider; |
| EXPECT_TRUE(policy_service_->HasProvider(&provider0_)); |
| EXPECT_TRUE(policy_service_->HasProvider(&provider1_)); |
| EXPECT_TRUE(policy_service_->HasProvider(&provider2_)); |
| EXPECT_FALSE(policy_service_->HasProvider(&other_provider)); |
| } |
| |
| TEST_F(PolicyServiceTest, NotifyProviderUpdateObserver) { |
| MockPolicyServiceProviderUpdateObserver provider_update_observer; |
| policy_service_->AddProviderUpdateObserver(&provider_update_observer); |
| |
| policy0_.Set("aaa", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_CLOUD, base::Value(123), nullptr); |
| EXPECT_CALL(provider_update_observer, |
| OnProviderUpdatePropagated(&provider0_)); |
| provider0_.UpdateChromePolicy(policy0_); |
| Mock::VerifyAndClearExpectations(&provider_update_observer); |
| |
| // No changes, ProviderUpdateObserver still notified. |
| EXPECT_CALL(provider_update_observer, |
| OnProviderUpdatePropagated(&provider0_)); |
| provider0_.UpdateChromePolicy(policy0_); |
| Mock::VerifyAndClearExpectations(&provider_update_observer); |
| |
| policy_service_->RemoveProviderUpdateObserver(&provider_update_observer); |
| } |
| |
| TEST_F(PolicyServiceTest, Priorities) { |
| PolicyMap expected; |
| expected.Set("pre", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_ENTERPRISE_DEFAULT, base::Value(13), nullptr); |
| expected.Set("migrated", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_PLATFORM, base::Value(15), nullptr); |
| expected.Set("aaa", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_CLOUD, base::Value(0), nullptr); |
| expected.GetMutable("aaa")->AddWarning(IDS_POLICY_CONFLICT_DIFF_VALUE); |
| expected.GetMutable("aaa")->AddWarning(IDS_POLICY_CONFLICT_DIFF_VALUE); |
| policy0_.Set("aaa", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_CLOUD, base::Value(0), nullptr); |
| policy1_.Set("aaa", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_CLOUD, base::Value(1), nullptr); |
| policy2_.Set("aaa", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_CLOUD, base::Value(2), nullptr); |
| provider0_.UpdateChromePolicy(policy0_); |
| provider1_.UpdateChromePolicy(policy1_); |
| provider2_.UpdateChromePolicy(policy2_); |
| expected.GetMutable("aaa")->AddConflictingPolicy( |
| policy1_.Get("aaa")->DeepCopy()); |
| expected.GetMutable("aaa")->AddConflictingPolicy( |
| policy2_.Get("aaa")->DeepCopy()); |
| |
| EXPECT_TRUE(VerifyPolicies( |
| PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()), expected)); |
| |
| expected.Set("aaa", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_CLOUD, base::Value(1), nullptr); |
| expected.GetMutable("aaa")->AddWarning(IDS_POLICY_CONFLICT_DIFF_VALUE); |
| policy0_.Erase("aaa"); |
| provider0_.UpdateChromePolicy(policy0_); |
| expected.GetMutable("aaa")->AddConflictingPolicy( |
| policy2_.Get("aaa")->DeepCopy()); |
| EXPECT_TRUE(VerifyPolicies( |
| PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()), expected)); |
| |
| expected.Set("aaa", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_CLOUD, base::Value(2), nullptr); |
| expected.GetMutable("aaa")->AddWarning(IDS_POLICY_CONFLICT_SAME_VALUE); |
| policy1_.Set("aaa", POLICY_LEVEL_RECOMMENDED, POLICY_SCOPE_USER, |
| POLICY_SOURCE_CLOUD, base::Value(1), nullptr); |
| expected.GetMutable("aaa")->AddConflictingPolicy( |
| policy2_.Get("aaa")->DeepCopy()); |
| provider1_.UpdateChromePolicy(policy2_); |
| EXPECT_TRUE(VerifyPolicies( |
| PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()), expected)); |
| } |
| |
| TEST_F(PolicyServiceTest, PolicyChangeRegistrar) { |
| std::unique_ptr<PolicyChangeRegistrar> registrar(new PolicyChangeRegistrar( |
| policy_service_.get(), |
| PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()))); |
| |
| // Starting to observe existing policies doesn't trigger a notification. |
| EXPECT_CALL(*this, OnPolicyValueUpdated(_, _)).Times(0); |
| registrar->Observe( |
| "pre", base::BindRepeating(&PolicyServiceTest::OnPolicyValueUpdated, |
| base::Unretained(this))); |
| registrar->Observe( |
| "aaa", base::BindRepeating(&PolicyServiceTest::OnPolicyValueUpdated, |
| base::Unretained(this))); |
| RunUntilIdle(); |
| Mock::VerifyAndClearExpectations(this); |
| |
| // Changing it now triggers a notification. |
| base::Value kValue0(0); |
| EXPECT_CALL(*this, OnPolicyValueUpdated(NULL, ValueEquals(&kValue0))); |
| policy0_.Set("aaa", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_CLOUD, kValue0.Clone(), nullptr); |
| provider0_.UpdateChromePolicy(policy0_); |
| Mock::VerifyAndClearExpectations(this); |
| |
| // Changing other values doesn't trigger a notification. |
| EXPECT_CALL(*this, OnPolicyValueUpdated(_, _)).Times(0); |
| policy0_.Set("bbb", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_CLOUD, kValue0.Clone(), nullptr); |
| provider0_.UpdateChromePolicy(policy0_); |
| Mock::VerifyAndClearExpectations(this); |
| |
| // Modifying the value triggers a notification. |
| base::Value kValue1(1); |
| EXPECT_CALL(*this, OnPolicyValueUpdated(ValueEquals(&kValue0), |
| ValueEquals(&kValue1))); |
| policy0_.Set("aaa", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_CLOUD, kValue1.Clone(), nullptr); |
| provider0_.UpdateChromePolicy(policy0_); |
| Mock::VerifyAndClearExpectations(this); |
| |
| // Removing the value triggers a notification. |
| EXPECT_CALL(*this, OnPolicyValueUpdated(ValueEquals(&kValue1), NULL)); |
| policy0_.Erase("aaa"); |
| provider0_.UpdateChromePolicy(policy0_); |
| Mock::VerifyAndClearExpectations(this); |
| |
| // No more notifications after destroying the registrar. |
| EXPECT_CALL(*this, OnPolicyValueUpdated(_, _)).Times(0); |
| registrar.reset(); |
| policy0_.Set("aaa", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_CLOUD, kValue1.Clone(), nullptr); |
| policy0_.Set("pre", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_ENTERPRISE_DEFAULT, kValue1.Clone(), nullptr); |
| provider0_.UpdateChromePolicy(policy0_); |
| Mock::VerifyAndClearExpectations(this); |
| } |
| |
| TEST_F(PolicyServiceTest, RefreshPolicies) { |
| EXPECT_CALL(provider0_, RefreshPolicies()).Times(AnyNumber()); |
| EXPECT_CALL(provider1_, RefreshPolicies()).Times(AnyNumber()); |
| EXPECT_CALL(provider2_, RefreshPolicies()).Times(AnyNumber()); |
| |
| EXPECT_CALL(*this, OnPolicyRefresh()).Times(0); |
| policy_service_->RefreshPolicies(base::BindOnce( |
| &PolicyServiceTest::OnPolicyRefresh, base::Unretained(this))); |
| // Let any queued observer tasks run. |
| RunUntilIdle(); |
| Mock::VerifyAndClearExpectations(this); |
| |
| EXPECT_CALL(*this, OnPolicyRefresh()).Times(0); |
| base::Value kValue0(0); |
| policy0_.Set("aaa", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_CLOUD, kValue0.Clone(), nullptr); |
| provider0_.UpdateChromePolicy(policy0_); |
| Mock::VerifyAndClearExpectations(this); |
| |
| EXPECT_CALL(*this, OnPolicyRefresh()).Times(0); |
| base::Value kValue1(1); |
| policy1_.Set("aaa", POLICY_LEVEL_RECOMMENDED, POLICY_SCOPE_USER, |
| POLICY_SOURCE_CLOUD, kValue1.Clone(), nullptr); |
| provider1_.UpdateChromePolicy(policy1_); |
| Mock::VerifyAndClearExpectations(this); |
| |
| // A provider can refresh more than once after a RefreshPolicies call, but |
| // OnPolicyRefresh should be triggered only after all providers are |
| // refreshed. |
| EXPECT_CALL(*this, OnPolicyRefresh()).Times(0); |
| policy1_.Set("bbb", POLICY_LEVEL_RECOMMENDED, POLICY_SCOPE_USER, |
| POLICY_SOURCE_CLOUD, kValue1.Clone(), nullptr); |
| provider1_.UpdateChromePolicy(policy1_); |
| Mock::VerifyAndClearExpectations(this); |
| |
| // If another RefreshPolicies() call happens while waiting for a previous |
| // one to complete, then all providers must refresh again. |
| EXPECT_CALL(*this, OnPolicyRefresh()).Times(0); |
| policy_service_->RefreshPolicies(base::BindOnce( |
| &PolicyServiceTest::OnPolicyRefresh, base::Unretained(this))); |
| RunUntilIdle(); |
| Mock::VerifyAndClearExpectations(this); |
| |
| EXPECT_CALL(*this, OnPolicyRefresh()).Times(0); |
| policy2_.Set("bbb", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_CLOUD, kValue0.Clone(), nullptr); |
| provider2_.UpdateChromePolicy(policy2_); |
| Mock::VerifyAndClearExpectations(this); |
| |
| // Providers 0 and 1 must reload again. |
| EXPECT_CALL(*this, OnPolicyRefresh()).Times(2); |
| base::Value kValue2(2); |
| policy0_.Set("aaa", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_CLOUD, kValue2.Clone(), nullptr); |
| provider0_.UpdateChromePolicy(policy0_); |
| provider1_.UpdateChromePolicy(policy1_); |
| Mock::VerifyAndClearExpectations(this); |
| |
| const PolicyMap& policies = policy_service_->GetPolicies( |
| PolicyNamespace(POLICY_DOMAIN_CHROME, std::string())); |
| EXPECT_EQ(kValue2, *policies.GetValue("aaa")); |
| EXPECT_EQ(kValue0, *policies.GetValue("bbb")); |
| } |
| |
| TEST_F(PolicyServiceTest, NamespaceMerge) { |
| auto bundle0 = std::make_unique<PolicyBundle>(); |
| auto bundle1 = std::make_unique<PolicyBundle>(); |
| auto bundle2 = std::make_unique<PolicyBundle>(); |
| |
| AddTestPolicies(bundle0.get(), "bundle0", |
| POLICY_LEVEL_RECOMMENDED, POLICY_SCOPE_USER); |
| AddTestPolicies(bundle1.get(), "bundle1", |
| POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER); |
| AddTestPolicies(bundle2.get(), "bundle2", |
| POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE); |
| |
| PolicyMap expected; |
| // For policies of the same level and scope, the first provider takes |
| // precedence, on every namespace. |
| expected.Set(kSameLevelPolicy, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_ENTERPRISE_DEFAULT, base::Value("bundle0"), |
| nullptr); |
| expected.Set("migrated", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_PLATFORM, base::Value(15), nullptr); |
| expected.GetMutable(kSameLevelPolicy) |
| ->AddWarning(IDS_POLICY_CONFLICT_DIFF_VALUE); |
| expected.GetMutable(kSameLevelPolicy) |
| ->AddWarning(IDS_POLICY_CONFLICT_DIFF_VALUE); |
| expected.GetMutable(kSameLevelPolicy) |
| ->AddConflictingPolicy( |
| bundle1->Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string())) |
| .Get(kSameLevelPolicy) |
| ->DeepCopy()); |
| expected.GetMutable(kSameLevelPolicy) |
| ->AddConflictingPolicy( |
| bundle2->Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string())) |
| .Get(kSameLevelPolicy) |
| ->DeepCopy()); |
| // For policies with different levels and scopes, the highest priority |
| // level/scope combination takes precedence, on every namespace. |
| expected.Set(kDiffLevelPolicy, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE, |
| POLICY_SOURCE_PLATFORM, base::Value("bundle2"), nullptr); |
| expected.GetMutable(kDiffLevelPolicy) |
| ->AddWarning(IDS_POLICY_CONFLICT_DIFF_VALUE); |
| expected.GetMutable(kDiffLevelPolicy) |
| ->AddConflictingPolicy( |
| bundle0->Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string())) |
| .Get(kDiffLevelPolicy) |
| ->DeepCopy()); |
| expected.GetMutable(kDiffLevelPolicy) |
| ->AddConflictingPolicy( |
| bundle1->Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string())) |
| .Get(kDiffLevelPolicy) |
| ->DeepCopy()); |
| |
| provider0_.UpdatePolicy(std::move(bundle0)); |
| provider1_.UpdatePolicy(std::move(bundle1)); |
| provider2_.UpdatePolicy(std::move(bundle2)); |
| RunUntilIdle(); |
| |
| EXPECT_TRUE(policy_service_->GetPolicies( |
| PolicyNamespace(POLICY_DOMAIN_CHROME, std::string())).Equals(expected)); |
| expected.Erase("migrated"); |
| EXPECT_TRUE(policy_service_->GetPolicies( |
| PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, kExtension)).Equals(expected)); |
| } |
| |
| TEST_F(PolicyServiceTest, IsInitializationComplete) { |
| // |provider0_| has all domains initialized. |
| Mock::VerifyAndClearExpectations(&provider1_); |
| Mock::VerifyAndClearExpectations(&provider2_); |
| EXPECT_CALL(provider1_, IsInitializationComplete(_)) |
| .WillRepeatedly(Return(false)); |
| EXPECT_CALL(provider2_, IsInitializationComplete(_)) |
| .WillRepeatedly(Return(false)); |
| PolicyServiceImpl::Providers providers; |
| providers.push_back(&provider0_); |
| providers.push_back(&provider1_); |
| providers.push_back(&provider2_); |
| policy_service_ = std::make_unique<PolicyServiceImpl>(std::move(providers)); |
| EXPECT_FALSE(policy_service_->IsInitializationComplete(POLICY_DOMAIN_CHROME)); |
| EXPECT_FALSE( |
| policy_service_->IsInitializationComplete(POLICY_DOMAIN_EXTENSIONS)); |
| EXPECT_FALSE(policy_service_->IsInitializationComplete( |
| POLICY_DOMAIN_SIGNIN_EXTENSIONS)); |
| |
| // |provider2_| still doesn't have POLICY_DOMAIN_CHROME initialized, so |
| // the initialization status of that domain won't change. |
| MockPolicyServiceObserver observer; |
| policy_service_->AddObserver(POLICY_DOMAIN_CHROME, &observer); |
| policy_service_->AddObserver(POLICY_DOMAIN_EXTENSIONS, &observer); |
| policy_service_->AddObserver(POLICY_DOMAIN_SIGNIN_EXTENSIONS, &observer); |
| EXPECT_CALL(observer, OnPolicyServiceInitialized(_)).Times(0); |
| Mock::VerifyAndClearExpectations(&provider1_); |
| EXPECT_CALL(provider1_, IsInitializationComplete(POLICY_DOMAIN_CHROME)) |
| .WillRepeatedly(Return(true)); |
| EXPECT_CALL(provider1_, IsInitializationComplete(POLICY_DOMAIN_EXTENSIONS)) |
| .WillRepeatedly(Return(false)); |
| EXPECT_CALL(provider1_, |
| IsInitializationComplete(POLICY_DOMAIN_SIGNIN_EXTENSIONS)) |
| .WillRepeatedly(Return(false)); |
| const PolicyMap kPolicyMap; |
| provider1_.UpdateChromePolicy(kPolicyMap); |
| Mock::VerifyAndClearExpectations(&observer); |
| EXPECT_FALSE(policy_service_->IsInitializationComplete(POLICY_DOMAIN_CHROME)); |
| EXPECT_FALSE( |
| policy_service_->IsInitializationComplete(POLICY_DOMAIN_EXTENSIONS)); |
| EXPECT_FALSE(policy_service_->IsInitializationComplete( |
| POLICY_DOMAIN_SIGNIN_EXTENSIONS)); |
| |
| // Same if |provider1_| doesn't have POLICY_DOMAIN_EXTENSIONS initialized. |
| EXPECT_CALL(observer, OnPolicyServiceInitialized(_)).Times(0); |
| Mock::VerifyAndClearExpectations(&provider2_); |
| EXPECT_CALL(provider2_, IsInitializationComplete(POLICY_DOMAIN_CHROME)) |
| .WillRepeatedly(Return(false)); |
| EXPECT_CALL(provider2_, IsInitializationComplete(POLICY_DOMAIN_EXTENSIONS)) |
| .WillRepeatedly(Return(true)); |
| EXPECT_CALL(provider2_, |
| IsInitializationComplete(POLICY_DOMAIN_SIGNIN_EXTENSIONS)) |
| .WillRepeatedly(Return(true)); |
| provider2_.UpdateChromePolicy(kPolicyMap); |
| Mock::VerifyAndClearExpectations(&observer); |
| EXPECT_FALSE(policy_service_->IsInitializationComplete(POLICY_DOMAIN_CHROME)); |
| EXPECT_FALSE( |
| policy_service_->IsInitializationComplete(POLICY_DOMAIN_EXTENSIONS)); |
| EXPECT_FALSE(policy_service_->IsInitializationComplete( |
| POLICY_DOMAIN_SIGNIN_EXTENSIONS)); |
| |
| // Now initialize POLICY_DOMAIN_CHROME on all the providers. |
| EXPECT_CALL(observer, OnPolicyServiceInitialized(POLICY_DOMAIN_CHROME)); |
| Mock::VerifyAndClearExpectations(&provider2_); |
| EXPECT_CALL(provider2_, IsInitializationComplete(POLICY_DOMAIN_CHROME)) |
| .WillRepeatedly(Return(true)); |
| EXPECT_CALL(provider2_, IsInitializationComplete(POLICY_DOMAIN_EXTENSIONS)) |
| .WillRepeatedly(Return(true)); |
| EXPECT_CALL(provider2_, |
| IsInitializationComplete(POLICY_DOMAIN_SIGNIN_EXTENSIONS)) |
| .WillRepeatedly(Return(true)); |
| provider2_.UpdateChromePolicy(kPolicyMap); |
| Mock::VerifyAndClearExpectations(&observer); |
| EXPECT_TRUE(policy_service_->IsInitializationComplete(POLICY_DOMAIN_CHROME)); |
| // Other domains are still not initialized. |
| EXPECT_FALSE( |
| policy_service_->IsInitializationComplete(POLICY_DOMAIN_EXTENSIONS)); |
| EXPECT_FALSE(policy_service_->IsInitializationComplete( |
| POLICY_DOMAIN_SIGNIN_EXTENSIONS)); |
| |
| // Initialize the remaining domains. |
| EXPECT_CALL(observer, OnPolicyServiceInitialized(POLICY_DOMAIN_EXTENSIONS)); |
| EXPECT_CALL(observer, |
| OnPolicyServiceInitialized(POLICY_DOMAIN_SIGNIN_EXTENSIONS)); |
| Mock::VerifyAndClearExpectations(&provider1_); |
| EXPECT_CALL(provider1_, IsInitializationComplete(POLICY_DOMAIN_CHROME)) |
| .WillRepeatedly(Return(true)); |
| EXPECT_CALL(provider1_, IsInitializationComplete(POLICY_DOMAIN_EXTENSIONS)) |
| .WillRepeatedly(Return(true)); |
| EXPECT_CALL(provider1_, |
| IsInitializationComplete(POLICY_DOMAIN_SIGNIN_EXTENSIONS)) |
| .WillRepeatedly(Return(true)); |
| provider1_.UpdateChromePolicy(kPolicyMap); |
| Mock::VerifyAndClearExpectations(&observer); |
| EXPECT_TRUE(policy_service_->IsInitializationComplete(POLICY_DOMAIN_CHROME)); |
| EXPECT_TRUE( |
| policy_service_->IsInitializationComplete(POLICY_DOMAIN_EXTENSIONS)); |
| EXPECT_TRUE(policy_service_->IsInitializationComplete( |
| POLICY_DOMAIN_SIGNIN_EXTENSIONS)); |
| |
| // Cleanup. |
| policy_service_->RemoveObserver(POLICY_DOMAIN_CHROME, &observer); |
| policy_service_->RemoveObserver(POLICY_DOMAIN_EXTENSIONS, &observer); |
| policy_service_->RemoveObserver(POLICY_DOMAIN_SIGNIN_EXTENSIONS, &observer); |
| } |
| |
| // Tests initialization throttling of PolicyServiceImpl. |
| // This actually tests two cases: |
| // (1) A domain was initialized before UnthrottleInitialization is called. |
| // Observers only get notified after calling UntrhottleInitialization. |
| // This is tested on POLICY_DOMAIN_CHROME. |
| // (2) A domain becomes initialized after UnthrottleInitialization has already |
| // been called. Because initialization is not throttled anymore, observers |
| // get notified immediately when the domain becomes initialized. |
| // This is tested on POLICY_DOMAIN_EXTENSIONS and |
| // POLICY_DOMAIN_SIGNIN_EXTENSIONS. |
| TEST_F(PolicyServiceTest, InitializationThrottled) { |
| // |provider0_| and |provider1_| has all domains initialized, |provider2_| has |
| // no domain initialized. |
| Mock::VerifyAndClearExpectations(&provider2_); |
| EXPECT_CALL(provider2_, IsInitializationComplete(_)) |
| .WillRepeatedly(Return(false)); |
| PolicyServiceImpl::Providers providers; |
| providers.push_back(&provider0_); |
| providers.push_back(&provider1_); |
| providers.push_back(&provider2_); |
| policy_service_ = PolicyServiceImpl::CreateWithThrottledInitialization( |
| std::move(providers)); |
| EXPECT_FALSE(policy_service_->IsInitializationComplete(POLICY_DOMAIN_CHROME)); |
| EXPECT_FALSE( |
| policy_service_->IsInitializationComplete(POLICY_DOMAIN_EXTENSIONS)); |
| EXPECT_FALSE(policy_service_->IsInitializationComplete( |
| POLICY_DOMAIN_SIGNIN_EXTENSIONS)); |
| |
| MockPolicyServiceObserver observer; |
| policy_service_->AddObserver(POLICY_DOMAIN_CHROME, &observer); |
| policy_service_->AddObserver(POLICY_DOMAIN_EXTENSIONS, &observer); |
| policy_service_->AddObserver(POLICY_DOMAIN_SIGNIN_EXTENSIONS, &observer); |
| |
| // Now additionally initialize POLICY_DOMAIN_CHROME on |provider2_|. |
| // Note: VerifyAndClearExpectations is called to reset the previously set |
| // action for IsInitializtionComplete on |provider_2|. |
| Mock::VerifyAndClearExpectations(&provider2_); |
| EXPECT_CALL(provider2_, IsInitializationComplete(POLICY_DOMAIN_CHROME)) |
| .WillRepeatedly(Return(true)); |
| EXPECT_CALL(provider2_, IsInitializationComplete(POLICY_DOMAIN_EXTENSIONS)) |
| .WillRepeatedly(Return(false)); |
| EXPECT_CALL(provider2_, |
| IsInitializationComplete(POLICY_DOMAIN_SIGNIN_EXTENSIONS)) |
| .WillRepeatedly(Return(false)); |
| |
| // Nothing will happen because initialization is still throttled. |
| EXPECT_CALL(observer, OnPolicyServiceInitialized(_)).Times(0); |
| const PolicyMap kPolicyMap; |
| provider2_.UpdateChromePolicy(kPolicyMap); |
| Mock::VerifyAndClearExpectations(&observer); |
| EXPECT_FALSE(policy_service_->IsInitializationComplete(POLICY_DOMAIN_CHROME)); |
| EXPECT_FALSE( |
| policy_service_->IsInitializationComplete(POLICY_DOMAIN_EXTENSIONS)); |
| EXPECT_FALSE(policy_service_->IsInitializationComplete( |
| POLICY_DOMAIN_SIGNIN_EXTENSIONS)); |
| |
| // Unthrottle initialization. This will signal that POLICY_DOMAIN_CHROME is |
| // initialized, the other domains should still not be initialized because |
| // |provider2_| is returning false in IsInitializationComplete for them. |
| EXPECT_CALL(observer, OnPolicyServiceInitialized(POLICY_DOMAIN_CHROME)); |
| policy_service_->UnthrottleInitialization(); |
| Mock::VerifyAndClearExpectations(&observer); |
| EXPECT_TRUE(policy_service_->IsInitializationComplete(POLICY_DOMAIN_CHROME)); |
| EXPECT_FALSE( |
| policy_service_->IsInitializationComplete(POLICY_DOMAIN_EXTENSIONS)); |
| EXPECT_FALSE(policy_service_->IsInitializationComplete( |
| POLICY_DOMAIN_SIGNIN_EXTENSIONS)); |
| |
| // Initialize the remaining domains. |
| // Note: VerifyAndClearExpectations is called to reset the previously set |
| // action for IsInitializtionComplete on |provider_2|. |
| Mock::VerifyAndClearExpectations(&provider2_); |
| EXPECT_CALL(provider2_, IsInitializationComplete(_)) |
| .WillRepeatedly(Return(true)); |
| |
| EXPECT_CALL(observer, OnPolicyServiceInitialized(POLICY_DOMAIN_EXTENSIONS)); |
| EXPECT_CALL(observer, |
| OnPolicyServiceInitialized(POLICY_DOMAIN_SIGNIN_EXTENSIONS)); |
| provider2_.UpdateChromePolicy(kPolicyMap); |
| Mock::VerifyAndClearExpectations(&observer); |
| EXPECT_TRUE(policy_service_->IsInitializationComplete(POLICY_DOMAIN_CHROME)); |
| EXPECT_TRUE( |
| policy_service_->IsInitializationComplete(POLICY_DOMAIN_EXTENSIONS)); |
| EXPECT_TRUE(policy_service_->IsInitializationComplete( |
| POLICY_DOMAIN_SIGNIN_EXTENSIONS)); |
| |
| // Cleanup. |
| policy_service_->RemoveObserver(POLICY_DOMAIN_CHROME, &observer); |
| policy_service_->RemoveObserver(POLICY_DOMAIN_EXTENSIONS, &observer); |
| policy_service_->RemoveObserver(POLICY_DOMAIN_SIGNIN_EXTENSIONS, &observer); |
| } |
| |
| TEST_F(PolicyServiceTest, InitializationThrottledProvidersAlreadyInitialized) { |
| // All providers have all domains initialized. |
| PolicyServiceImpl::Providers providers; |
| providers.push_back(&provider0_); |
| providers.push_back(&provider1_); |
| providers.push_back(&provider2_); |
| policy_service_ = PolicyServiceImpl::CreateWithThrottledInitialization( |
| std::move(providers)); |
| EXPECT_FALSE(policy_service_->IsInitializationComplete(POLICY_DOMAIN_CHROME)); |
| EXPECT_FALSE( |
| policy_service_->IsInitializationComplete(POLICY_DOMAIN_EXTENSIONS)); |
| EXPECT_FALSE(policy_service_->IsInitializationComplete( |
| POLICY_DOMAIN_SIGNIN_EXTENSIONS)); |
| |
| MockPolicyServiceObserver observer; |
| policy_service_->AddObserver(POLICY_DOMAIN_CHROME, &observer); |
| policy_service_->AddObserver(POLICY_DOMAIN_EXTENSIONS, &observer); |
| policy_service_->AddObserver(POLICY_DOMAIN_SIGNIN_EXTENSIONS, &observer); |
| |
| // Unthrottle initialization. This will signal that all domains are |
| // initialized. |
| EXPECT_CALL(observer, OnPolicyServiceInitialized(POLICY_DOMAIN_CHROME)); |
| EXPECT_CALL(observer, OnPolicyServiceInitialized(POLICY_DOMAIN_EXTENSIONS)); |
| EXPECT_CALL(observer, |
| OnPolicyServiceInitialized(POLICY_DOMAIN_SIGNIN_EXTENSIONS)); |
| policy_service_->UnthrottleInitialization(); |
| Mock::VerifyAndClearExpectations(&observer); |
| EXPECT_TRUE(policy_service_->IsInitializationComplete(POLICY_DOMAIN_CHROME)); |
| EXPECT_TRUE( |
| policy_service_->IsInitializationComplete(POLICY_DOMAIN_EXTENSIONS)); |
| EXPECT_TRUE(policy_service_->IsInitializationComplete( |
| POLICY_DOMAIN_SIGNIN_EXTENSIONS)); |
| |
| // Cleanup. |
| policy_service_->RemoveObserver(POLICY_DOMAIN_CHROME, &observer); |
| policy_service_->RemoveObserver(POLICY_DOMAIN_EXTENSIONS, &observer); |
| policy_service_->RemoveObserver(POLICY_DOMAIN_SIGNIN_EXTENSIONS, &observer); |
| } |
| |
| TEST_F(PolicyServiceTest, SeparateProxyPoliciesMerging) { |
| const PolicyNamespace chrome_namespace(POLICY_DOMAIN_CHROME, std::string()); |
| const PolicyNamespace extension_namespace(POLICY_DOMAIN_EXTENSIONS, "xyz"); |
| |
| std::unique_ptr<PolicyBundle> policy_bundle(new PolicyBundle()); |
| PolicyMap& policy_map = policy_bundle->Get(chrome_namespace); |
| // Individual proxy policy values in the Chrome namespace should be collected |
| // into a dictionary. |
| policy_map.Set(key::kProxyServerMode, POLICY_LEVEL_MANDATORY, |
| POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD, base::Value(3), |
| nullptr); |
| |
| // Both these policies should be ignored, since there's a higher priority |
| // policy available. |
| policy_map.Set(key::kProxyMode, POLICY_LEVEL_RECOMMENDED, POLICY_SCOPE_USER, |
| POLICY_SOURCE_CLOUD, base::Value("pac_script"), nullptr); |
| policy_map.Set(key::kProxyPacUrl, POLICY_LEVEL_RECOMMENDED, POLICY_SCOPE_USER, |
| POLICY_SOURCE_CLOUD, |
| base::Value("http://example.com/wpad.dat"), nullptr); |
| |
| // Add a value to a non-Chrome namespace. |
| policy_bundle->Get(extension_namespace) |
| .Set(key::kProxyServerMode, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_CLOUD, base::Value(3), nullptr); |
| |
| // The resulting Chrome namespace map should have the collected policy. |
| PolicyMap expected_chrome; |
| base::Value expected_value(base::Value::Type::DICTIONARY); |
| expected_value.SetIntKey(key::kProxyServerMode, 3); |
| expected_chrome.Set(key::kProxySettings, POLICY_LEVEL_MANDATORY, |
| POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD, |
| std::move(expected_value), nullptr); |
| expected_chrome.Set("migrated", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_PLATFORM, base::Value(15), nullptr); |
| |
| // The resulting Extensions namespace map shouldn't have been modified. |
| PolicyMap expected_extension; |
| expected_extension.Set(key::kProxyServerMode, POLICY_LEVEL_MANDATORY, |
| POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD, base::Value(3), |
| nullptr); |
| |
| provider0_.UpdatePolicy(std::move(policy_bundle)); |
| RunUntilIdle(); |
| |
| EXPECT_TRUE(VerifyPolicies(chrome_namespace, expected_chrome)); |
| EXPECT_TRUE(VerifyPolicies(extension_namespace, expected_extension)); |
| } |
| TEST_F(PolicyServiceTest, DictionaryPoliciesMerging) { |
| const PolicyNamespace chrome_namespace(POLICY_DOMAIN_CHROME, std::string()); |
| |
| base::Value dict1(base::Value::Type::DICTIONARY); |
| dict1.SetBoolKey("google.com", false); |
| dict1.SetBoolKey("gmail.com", true); |
| base::Value dict2 = base::Value(base::Value::Type::DICTIONARY); |
| dict2.SetBoolKey("example.com", true); |
| dict2.SetBoolKey("gmail.com", false); |
| base::Value result = base::Value(base::Value::Type::DICTIONARY); |
| result.SetBoolKey("google.com", false); |
| result.SetBoolKey("gmail.com", false); |
| result.SetBoolKey("example.com", true); |
| |
| std::unique_ptr<base::Value> policy = |
| std::make_unique<base::Value>(base::Value::Type::LIST); |
| policy->Append(base::Value(policy::key::kContentPackManualBehaviorURLs)); |
| |
| auto policy_bundle1 = std::make_unique<PolicyBundle>(); |
| PolicyMap& policy_map1 = policy_bundle1->Get(chrome_namespace); |
| policy_map1.Set(key::kPolicyDictionaryMultipleSourceMergeList, |
| POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE, |
| POLICY_SOURCE_PLATFORM, policy->Clone(), nullptr); |
| PolicyMap::Entry entry_dict_1(POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE, |
| POLICY_SOURCE_PLATFORM, std::move(dict1), |
| nullptr); |
| policy_map1.Set(key::kContentPackManualBehaviorURLs, entry_dict_1.DeepCopy()); |
| |
| auto policy_bundle2 = std::make_unique<PolicyBundle>(); |
| PolicyMap& policy_map2 = policy_bundle2->Get(chrome_namespace); |
| PolicyMap::Entry entry_dict_2(POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE, |
| POLICY_SOURCE_PRIORITY_CLOUD, std::move(dict2), |
| nullptr); |
| policy_map2.Set(key::kContentPackManualBehaviorURLs, entry_dict_2.DeepCopy()); |
| |
| PolicyMap expected_chrome; |
| expected_chrome.Set(key::kPolicyDictionaryMultipleSourceMergeList, |
| POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE, |
| POLICY_SOURCE_PLATFORM, policy->Clone(), nullptr); |
| expected_chrome.Set("migrated", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_PLATFORM, base::Value(15), nullptr); |
| |
| PolicyMap::Entry merged(POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE, |
| POLICY_SOURCE_MERGED, std::move(result), nullptr); |
| merged.AddConflictingPolicy(entry_dict_1.DeepCopy()); |
| merged.AddConflictingPolicy(entry_dict_2.DeepCopy()); |
| merged.AddWarning(IDS_POLICY_CONFLICT_DIFF_VALUE); |
| expected_chrome.Set(key::kContentPackManualBehaviorURLs, std::move(merged)); |
| |
| provider0_.UpdatePolicy(std::move(policy_bundle1)); |
| provider1_.UpdatePolicy(std::move(policy_bundle2)); |
| RunUntilIdle(); |
| |
| EXPECT_TRUE(VerifyPolicies(chrome_namespace, expected_chrome)); |
| } |
| |
| TEST_F(PolicyServiceTest, ListsPoliciesMerging) { |
| const PolicyNamespace chrome_namespace(POLICY_DOMAIN_CHROME, std::string()); |
| |
| base::Value list1(base::Value::Type::LIST); |
| list1.Append(base::Value("google.com")); |
| list1.Append(base::Value("gmail.com")); |
| base::Value list2 = base::Value(base::Value::Type::LIST); |
| list2.Append(base::Value("example.com")); |
| list2.Append(base::Value("gmail.com")); |
| base::Value result = base::Value(base::Value::Type::LIST); |
| result.Append(base::Value("google.com")); |
| result.Append(base::Value("gmail.com")); |
| result.Append(base::Value("example.com")); |
| |
| std::unique_ptr<base::ListValue> policy = std::make_unique<base::ListValue>(); |
| policy->Append(base::Value(policy::key::kExtensionInstallForcelist)); |
| |
| auto policy_bundle1 = std::make_unique<PolicyBundle>(); |
| PolicyMap& policy_map1 = policy_bundle1->Get(chrome_namespace); |
| policy_map1.Set(key::kPolicyListMultipleSourceMergeList, |
| POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE, |
| POLICY_SOURCE_PLATFORM, policy->Clone(), nullptr); |
| PolicyMap::Entry entry_list_1(POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE, |
| POLICY_SOURCE_PLATFORM, std::move(list1), |
| nullptr); |
| policy_map1.Set(key::kExtensionInstallForcelist, entry_list_1.DeepCopy()); |
| |
| auto policy_bundle2 = std::make_unique<PolicyBundle>(); |
| PolicyMap& policy_map2 = policy_bundle2->Get(chrome_namespace); |
| PolicyMap::Entry entry_list_2(POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE, |
| POLICY_SOURCE_CLOUD, std::move(list2), nullptr); |
| policy_map2.Set(key::kExtensionInstallForcelist, entry_list_2.DeepCopy()); |
| |
| PolicyMap expected_chrome; |
| expected_chrome.Set(key::kPolicyListMultipleSourceMergeList, |
| POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE, |
| POLICY_SOURCE_PLATFORM, policy->Clone(), nullptr); |
| expected_chrome.Set("migrated", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_PLATFORM, base::Value(15), nullptr); |
| |
| PolicyMap::Entry merged(POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE, |
| POLICY_SOURCE_MERGED, std::move(result), nullptr); |
| merged.AddConflictingPolicy(entry_list_2.DeepCopy()); |
| merged.AddConflictingPolicy(entry_list_1.DeepCopy()); |
| merged.AddWarning(IDS_POLICY_CONFLICT_DIFF_VALUE); |
| expected_chrome.Set(key::kExtensionInstallForcelist, std::move(merged)); |
| |
| provider0_.UpdatePolicy(std::move(policy_bundle1)); |
| provider1_.UpdatePolicy(std::move(policy_bundle2)); |
| RunUntilIdle(); |
| |
| EXPECT_TRUE(VerifyPolicies(chrome_namespace, expected_chrome)); |
| } |
| |
| TEST_F(PolicyServiceTest, GroupPoliciesMergingDisabledForCloudUsers) { |
| const PolicyNamespace chrome_namespace(POLICY_DOMAIN_CHROME, std::string()); |
| |
| base::Value list1(base::Value::Type::LIST); |
| list1.Append(base::Value("google.com")); |
| base::Value list2(base::Value::Type::LIST); |
| list2.Append(base::Value("example.com")); |
| base::Value list3(base::Value::Type::LIST); |
| list3.Append(base::Value("example_xyz.com")); |
| base::Value result(base::Value::Type::LIST); |
| result.Append(base::Value("google.com")); |
| result.Append(base::Value("example.com")); |
| |
| std::unique_ptr<base::ListValue> policy = std::make_unique<base::ListValue>(); |
| policy->Append(base::Value(policy::key::kExtensionInstallForcelist)); |
| policy->Append(base::Value(policy::key::kExtensionInstallBlocklist)); |
| |
| auto policy_bundle1 = std::make_unique<PolicyBundle>(); |
| PolicyMap& policy_map1 = policy_bundle1->Get(chrome_namespace); |
| policy_map1.Set(key::kPolicyListMultipleSourceMergeList, |
| POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE, |
| POLICY_SOURCE_PLATFORM, policy->Clone(), nullptr); |
| PolicyMap::Entry entry_list_1(POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE, |
| POLICY_SOURCE_PLATFORM, std::move(list1), |
| nullptr); |
| policy_map1.Set(key::kExtensionInstallForcelist, entry_list_1.DeepCopy()); |
| policy_map1.Set(key::kExtensionInstallBlocklist, entry_list_1.DeepCopy()); |
| PolicyMap::Entry atomic_policy_enabled(POLICY_LEVEL_MANDATORY, |
| POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD, |
| base::Value(true), nullptr); |
| policy_map1.Set(key::kPolicyAtomicGroupsEnabled, |
| atomic_policy_enabled.DeepCopy()); |
| |
| auto policy_bundle2 = std::make_unique<PolicyBundle>(); |
| PolicyMap& policy_map2 = policy_bundle2->Get(chrome_namespace); |
| PolicyMap::Entry entry_list_2(POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE, |
| POLICY_SOURCE_CLOUD, std::move(list2), nullptr); |
| PolicyMap::Entry entry_list_3(POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE, |
| POLICY_SOURCE_CLOUD, std::move(list3), nullptr); |
| policy_map2.Set(key::kExtensionInstallForcelist, entry_list_2.DeepCopy()); |
| policy_map2.Set(key::kExtensionInstallBlocklist, entry_list_2.DeepCopy()); |
| policy_map2.Set(key::kExtensionInstallAllowlist, entry_list_3.DeepCopy()); |
| |
| PolicyMap expected_chrome; |
| expected_chrome.Set(key::kPolicyListMultipleSourceMergeList, |
| POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE, |
| POLICY_SOURCE_PLATFORM, policy->Clone(), nullptr); |
| expected_chrome.Set("migrated", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_PLATFORM, base::Value(15), nullptr); |
| |
| PolicyMap::Entry merged(POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE, |
| POLICY_SOURCE_MERGED, std::move(result), nullptr); |
| merged.AddConflictingPolicy(entry_list_2.DeepCopy()); |
| merged.AddConflictingPolicy(entry_list_1.DeepCopy()); |
| merged.AddWarning(IDS_POLICY_CONFLICT_DIFF_VALUE); |
| expected_chrome.Set(key::kExtensionInstallForcelist, merged.DeepCopy()); |
| expected_chrome.Set(key::kExtensionInstallBlocklist, std::move(merged)); |
| expected_chrome.Set(key::kExtensionInstallAllowlist, std::move(entry_list_3)); |
| expected_chrome.Set(key::kPolicyAtomicGroupsEnabled, |
| atomic_policy_enabled.DeepCopy()); |
| |
| provider0_.UpdatePolicy(std::move(policy_bundle1)); |
| provider1_.UpdatePolicy(std::move(policy_bundle2)); |
| RunUntilIdle(); |
| |
| EXPECT_TRUE(VerifyPolicies(chrome_namespace, expected_chrome)); |
| } |
| |
| TEST_F(PolicyServiceTest, GroupPoliciesMergingEnabled) { |
| const PolicyNamespace chrome_namespace(POLICY_DOMAIN_CHROME, std::string()); |
| |
| base::Value list1(base::Value::Type::LIST); |
| list1.Append(base::Value("google.com")); |
| base::Value list2(base::Value::Type::LIST); |
| list2.Append(base::Value("example.com")); |
| base::Value list3(base::Value::Type::LIST); |
| list3.Append(base::Value("example_xyz.com")); |
| base::Value result(base::Value::Type::LIST); |
| result.Append(base::Value("google.com")); |
| result.Append(base::Value("example.com")); |
| |
| std::unique_ptr<base::ListValue> policy = std::make_unique<base::ListValue>(); |
| policy->Append(base::Value(policy::key::kExtensionInstallForcelist)); |
| policy->Append(base::Value(policy::key::kExtensionInstallBlocklist)); |
| |
| auto policy_bundle1 = std::make_unique<PolicyBundle>(); |
| PolicyMap& policy_map1 = policy_bundle1->Get(chrome_namespace); |
| policy_map1.Set(key::kPolicyListMultipleSourceMergeList, |
| POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE, |
| POLICY_SOURCE_PLATFORM, policy->Clone(), nullptr); |
| PolicyMap::Entry entry_list_1(POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE, |
| POLICY_SOURCE_PLATFORM, std::move(list1), |
| nullptr); |
| policy_map1.Set(key::kExtensionInstallForcelist, entry_list_1.DeepCopy()); |
| policy_map1.Set(key::kExtensionInstallBlocklist, entry_list_1.DeepCopy()); |
| PolicyMap::Entry atomic_policy_enabled( |
| POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, POLICY_SOURCE_PLATFORM, |
| base::Value(true), nullptr); |
| policy_map1.Set(key::kPolicyAtomicGroupsEnabled, |
| atomic_policy_enabled.DeepCopy()); |
| |
| auto policy_bundle2 = std::make_unique<PolicyBundle>(); |
| PolicyMap& policy_map2 = policy_bundle2->Get(chrome_namespace); |
| PolicyMap::Entry entry_list_2(POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE, |
| POLICY_SOURCE_CLOUD, std::move(list2), nullptr); |
| PolicyMap::Entry entry_list_3(POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE, |
| POLICY_SOURCE_CLOUD, std::move(list3), nullptr); |
| policy_map2.Set(key::kExtensionInstallForcelist, entry_list_2.DeepCopy()); |
| policy_map2.Set(key::kExtensionInstallBlocklist, entry_list_2.DeepCopy()); |
| policy_map2.Set(key::kExtensionInstallAllowlist, entry_list_3.DeepCopy()); |
| |
| PolicyMap expected_chrome; |
| expected_chrome.Set(key::kPolicyListMultipleSourceMergeList, |
| POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE, |
| POLICY_SOURCE_PLATFORM, policy->Clone(), nullptr); |
| expected_chrome.Set("migrated", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, |
| POLICY_SOURCE_PLATFORM, base::Value(15), nullptr); |
| |
| PolicyMap::Entry merged(POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE, |
| POLICY_SOURCE_MERGED, std::move(result), nullptr); |
| merged.AddConflictingPolicy(entry_list_2.DeepCopy()); |
| merged.AddConflictingPolicy(entry_list_1.DeepCopy()); |
| merged.AddWarning(IDS_POLICY_CONFLICT_DIFF_VALUE); |
| entry_list_3.SetIgnoredByPolicyAtomicGroup(); |
| expected_chrome.Set(key::kExtensionInstallForcelist, merged.DeepCopy()); |
| expected_chrome.Set(key::kExtensionInstallBlocklist, std::move(merged)); |
| expected_chrome.Set(key::kExtensionInstallAllowlist, std::move(entry_list_3)); |
| expected_chrome.Set(key::kPolicyAtomicGroupsEnabled, |
| atomic_policy_enabled.DeepCopy()); |
| |
| provider0_.UpdatePolicy(std::move(policy_bundle1)); |
| provider1_.UpdatePolicy(std::move(policy_bundle2)); |
| RunUntilIdle(); |
| |
| EXPECT_TRUE(VerifyPolicies(chrome_namespace, expected_chrome)); |
| } |
| |
| } // namespace policy |
