Make a ColorSpace dep public to avoid include errors
Since mojom will put headers from ui/gfx/ipc/color into
code in other targets, the dependency need to be public so
that other code get the right dependency.
Without the fix gn check --check-generated reports this:
ERROR at //out/Default/gen/services/viz/public/interfaces/compositing/compositor_frame.mojom-test-utils.cc:51:11: Can't include this header from here.
#include "ui/gfx/ipc/color/gfx_param_traits.h"
^----------------------------------
The target:
//services/viz/public/interfaces:interfaces
is including a file from the target:
//ui/gfx/ipc/color:color
It's usually best to depend directly on the destination target.
In some cases, the destination target is considered a subcomponent
of an intermediate target. In this case, the intermediate target
should depend publicly on the destination to forward the ability
to include headers.
Dependency chain (there may also be others):
//services/viz/public/interfaces:interfaces -->
//ui/gfx/mojo:mojo --[private]-->
//ui/gfx/ipc/color:color
Bug: 938893
Change-Id: I5ab887bc137223c74e7b84ffc75a9fee0b3c01cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538412
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Daniel Bratell <bratell@opera.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644370}diff --git a/ui/gfx/mojo/color_space.typemap b/ui/gfx/mojo/color_space.typemap
index 36ebf09..408ac7c 100644
--- a/ui/gfx/mojo/color_space.typemap
+++ b/ui/gfx/mojo/color_space.typemap
@@ -8,8 +8,6 @@
public_deps = [
"//ipc",
"//ui/gfx",
-]
-deps = [
"//ui/gfx/ipc/color",
]
type_mappings = [ "gfx.mojom.ColorSpace=gfx::ColorSpace" ]
