commit 46b5efc94a308e7edfb0501c5a263e34c1e34526
author Martin Robinson <mrobinson@igalia.com> Thu Aug 08 17:52:05 2019
committer Commit Bot <commit-bot@chromium.org> Thu Aug 08 17:52:05 2019
tree 941c17f733530177b76447b53f1eb794f43ef70e
parent dbc6fcdd4579870328b63bcfcefca5e7c6e5a38b

Use panel or unknown AtkRole for nodes with unknown roles

Typically, Views nodes that have an unknown role are one of a variety
of views. The ATK_ROLE_PANEL is a more accurate classification for
these. For other nodes with an unknown role we can use ATK_ROLE_UNKNOWN.

Bug: 866344
Change-Id: Ifae26ec0f04487abfec86d57df7914ab459967cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741921
Reviewed-by: Joanmarie Diggs <jdiggs@igalia.com>
Commit-Queue: Martin Robinson <mrobinson@igalia.com>
Cr-Commit-Position: refs/heads/master@{#685261}

ui/accessibility/platform/ax_platform_node_auralinux.cc

diff --git a/ui/accessibility/platform/ax_platform_node_auralinux.cc b/ui/accessibility/platform/ax_platform_node_auralinux.cc
index e7f39053..43b7a99 100644
--- a/ui/accessibility/platform/ax_platform_node_auralinux.cc
+++ b/ui/accessibility/platform/ax_platform_node_auralinux.cc
@@ -2584,10 +2584,13 @@
       return ATK_ROLE_PANEL;
     case ax::mojom::Role::kFigcaption:
       return ATK_ROLE_CAPTION;
+    case ax::mojom::Role::kUnknown:
+      // When we are not in web content, assume that a node with an unknown
+      // role is a view (which often have the unknown role).
+      return !GetDelegate()->IsWebContent() ? ATK_ROLE_PANEL : ATK_ROLE_UNKNOWN;
     case ax::mojom::Role::kKeyboard:
     case ax::mojom::Role::kNone:
     case ax::mojom::Role::kPresentational:
-    case ax::mojom::Role::kUnknown:
       return ATK_ROLE_REDUNDANT_OBJECT;
   }
 }