Google Git
Sign in
chromium / chromium / src / 48d01b3894332b1d9897abe8736a376a57e8c9db
commit48d01b3894332b1d9897abe8736a376a57e8c9db[log] [tgz]
authorNick Diego Yamane <nickdiego@igalia.com>Thu Aug 26 17:07:44 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Aug 26 17:07:44 2021
tree79a5e4b2d98d8081256e4081b2593b917ba658a9
parent6ff500e4687d65d7cdcecd54193ac611258c360d [diff]
ozone/wayland: Introduce SerialTracker class

Serial tracking has been done in a simple way, which has been sufficient
so far. Though recently we started observing subtle issues that point
out that it must be improved and made more robust [1][2][3]. Simpler
(but less scalable) solutions started to be employed [4], though a
better and more generic approach is needed.

This CL introduces wl::SerialTracker as well as related structs/enums,
which encapsulates logic for keeping track and retrieving serial values
and metadata. It is basically a generalization of serial related code in
WaylandConnection, with an enhanced way of storing/retrieving them in a
categorized way, based on events for which each serial is associated to,
thus allowing to avoid issues such as the ones linked below.

R=msisov@igalia.com, tonikitoo@igalia.com

[1] https://bugs.chromium.org/p/chromium/issues/detail?id=1209269
[2] https://bugs.chromium.org/p/chromium/issues/detail?id=1175083
[3] https://bugs.chromium.org/p/chromium/issues/detail?id=1202986
[4] https://chromium-review.googlesource.com/c/chromium/src/+/2854638

Bug: 1211874
Test: ozone_unittests --gtest_filter='WaylandSerialTrackerTest.*'
Change-Id: I5ee9cfa5104f7bad3ec1f9c5943e4027eabeb812
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3122285
Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Maksim Sisov <msisov@igalia.com>
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Cr-Commit-Position: refs/heads/main@{#915622}
5 files changed
tree: 79a5e4b2d98d8081256e4081b2593b917ba658a9
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.