Google Git
Sign in
chromium / chromium / src / 5ac2340a2395145c1754c5264225e83e72491f85 / . / components / omnibox / browser / history_quick_provider_unittest.cc
blob: d5b59d46697b9042f56da857031ab4ed0db4237c [file] [log] [blame]
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/omnibox/browser/history_quick_provider.h"
#include <stddef.h>
#include <algorithm>
#include <functional>
#include <memory>
#include <set>
#include <string>
#include <vector>
#include "base/format_macros.h"
#include "base/run_loop.h"
#include "base/stl_util.h"
#include "base/strings/utf_string_conversions.h"
#include "base/test/task_environment.h"
#include "components/bookmarks/browser/bookmark_model.h"
#include "components/bookmarks/test/bookmark_test_helpers.h"
#include "components/bookmarks/test/test_bookmark_client.h"
#include "components/history/core/browser/history_backend.h"
#include "components/history/core/browser/history_database.h"
#include "components/history/core/browser/history_service.h"
#include "components/history/core/browser/history_service_observer.h"
#include "components/history/core/browser/url_database.h"
#include "components/history/core/test/history_service_test_util.h"
#include "components/omnibox/browser/autocomplete_match.h"
#include "components/omnibox/browser/autocomplete_result.h"
#include "components/omnibox/browser/fake_autocomplete_provider_client.h"
#include "components/omnibox/browser/history_test_util.h"
#include "components/omnibox/browser/history_url_provider.h"
#include "components/omnibox/browser/in_memory_url_index_test_util.h"
#include "components/prefs/pref_service.h"
#include "components/search_engines/search_terms_data.h"
#include "testing/gtest/include/gtest/gtest.h"
using base::ASCIIToUTF16;
namespace {
// Waits for OnURLsDeletedNotification and when run quits the supplied run loop.
class WaitForURLsDeletedObserver : public history::HistoryServiceObserver {
public:
explicit WaitForURLsDeletedObserver(base::RunLoop* runner);
~WaitForURLsDeletedObserver() override;
private:
// history::HistoryServiceObserver:
void OnURLsDeleted(history::HistoryService* service,
const history::DeletionInfo& deletion_info) override;
// Weak. Owned by our owner.
base::RunLoop* runner_;
DISALLOW_COPY_AND_ASSIGN(WaitForURLsDeletedObserver);
};
WaitForURLsDeletedObserver::WaitForURLsDeletedObserver(base::RunLoop* runner)
: runner_(runner) {
}
WaitForURLsDeletedObserver::~WaitForURLsDeletedObserver() {
}
void WaitForURLsDeletedObserver::OnURLsDeleted(
history::HistoryService* service,
const history::DeletionInfo& deletion_info) {
runner_->Quit();
}
void WaitForURLsDeletedNotification(history::HistoryService* history_service) {
base::RunLoop runner;
WaitForURLsDeletedObserver observer(&runner);
ScopedObserver<history::HistoryService, history::HistoryServiceObserver>
scoped_observer(&observer);
scoped_observer.Add(history_service);
runner.Run();
}
// Post history_backend->GetURL() to the history thread and stop the originating
// thread's message loop when done.
class GetURLTask : public history::HistoryDBTask {
public:
GetURLTask(const GURL& url, bool* result_storage)
: result_storage_(result_storage),
url_(url) {
}
bool RunOnDBThread(history::HistoryBackend* backend,
history::HistoryDatabase* db) override {
*result_storage_ = backend->GetURL(url_, nullptr);
return true;
}
void DoneRunOnMainThread() override {
base::RunLoop::QuitCurrentWhenIdleDeprecated();
}
private:
~GetURLTask() override {}
bool* result_storage_;
const GURL url_;
DISALLOW_COPY_AND_ASSIGN(GetURLTask);
};
} // namespace
// Flaky leaks on ASAN LSAN (crbug.com/1010691).
#if defined(ADDRESS_SANITIZER)
#define MAYBE_HistoryQuickProviderTest DISABLED_HistoryQuickProviderTest
#else
#define MAYBE_HistoryQuickProviderTest HistoryQuickProviderTest
#endif
class MAYBE_HistoryQuickProviderTest : public testing::Test {
public:
MAYBE_HistoryQuickProviderTest() = default;
protected:
struct TestURLInfo {
std::string url;
std::string title;
int visit_count;
int typed_count;
int days_from_now;
};
class SetShouldContain {
public:
explicit SetShouldContain(const ACMatches& matched_urls);
void operator()(const std::string& expected);
std::set<std::string> LeftOvers() const { return matches_; }
private:
std::set<std::string> matches_;
};
void SetUp() override;
void TearDown() override;
virtual std::vector<TestURLInfo> GetTestData();
// Fills test data into the history system.
void FillData();
// Runs an autocomplete query on |text| and checks to see that the returned
// results' destination URLs match those provided. |expected_urls| does not
// need to be in sorted order.
void RunTest(const base::string16 text,
bool prevent_inline_autocomplete,
std::vector<std::string> expected_urls,
bool can_inline_top_result,
base::string16 expected_fill_into_edit,
base::string16 autocompletion);
// As above, simply with a cursor position specified.
void RunTestWithCursor(const base::string16 text,
const size_t cursor_position,
bool prevent_inline_autocomplete,
std::vector<std::string> expected_urls,
bool can_inline_top_result,
base::string16 expected_fill_into_edit,
base::string16 autocompletion);
// TODO(shess): From history_service.h in reference to history_backend:
// > This class has most of the implementation and runs on the 'thread_'.
// > You MUST communicate with this class ONLY through the thread_'s
// > message_loop().
// Direct use of this object in tests is almost certainly not thread-safe.
history::HistoryBackend* history_backend() {
return client_->GetHistoryService()->history_backend_.get();
}
// Call history_backend()->GetURL(url, NULL) on the history thread, returning
// the result.
bool GetURLProxy(const GURL& url);
FakeAutocompleteProviderClient& client() { return *client_; }
ACMatches& ac_matches() { return ac_matches_; }
HistoryQuickProvider& provider() { return *provider_; }
private:
base::test::TaskEnvironment task_environment_;
std::unique_ptr<FakeAutocompleteProviderClient> client_;
ACMatches ac_matches_; // The resulting matches after running RunTest.
scoped_refptr<HistoryQuickProvider> provider_;
DISALLOW_COPY_AND_ASSIGN(MAYBE_HistoryQuickProviderTest);
};
void MAYBE_HistoryQuickProviderTest::SetUp() {
client_ = std::make_unique<FakeAutocompleteProviderClient>();
ASSERT_TRUE(client_->GetHistoryService());
ASSERT_NO_FATAL_FAILURE(FillData());
// FillData() must be called before RebuildFromHistory(). This will
// ensure that the index is properly populated with data from the database.
InMemoryURLIndex* url_index = client_->GetInMemoryURLIndex();
url_index->RebuildFromHistory(
client_->GetHistoryService()->history_backend_->db());
BlockUntilInMemoryURLIndexIsRefreshed(url_index);
// History index refresh creates rebuilt tasks to run on history thread.
// Block here to make sure that all of them are complete.
history::BlockUntilHistoryProcessesPendingRequests(
client_->GetHistoryService());
provider_ = new HistoryQuickProvider(client_.get());
}
void MAYBE_HistoryQuickProviderTest::TearDown() {
provider_ = nullptr;
client_.reset();
task_environment_.RunUntilIdle();
}
std::vector<MAYBE_HistoryQuickProviderTest::TestURLInfo>
MAYBE_HistoryQuickProviderTest::GetTestData() {
return {
{"http://www.google.com/", "Google", 3, 3, 0},
{"http://slashdot.org/favorite_page.html", "Favorite page", 200, 100, 0},
{"http://kerneltrap.org/not_very_popular.html", "Less popular", 4, 0, 0},
{"http://freshmeat.net/unpopular.html", "Unpopular", 1, 1, 0},
{"http://news.google.com/?ned=us&topic=n", "Google News - U.S.", 2, 2, 0},
{"http://news.google.com/", "Google News", 1, 1, 0},
{"http://foo.com/", "Dir", 200, 100, 0},
{"http://foo.com/dir/", "Dir", 2, 1, 10},
{"http://foo.com/dir/another/", "Dir", 10, 5, 0},
{"http://foo.com/dir/another/again/", "Dir", 5, 1, 0},
{"http://foo.com/dir/another/again/myfile.html", "File", 3, 1, 0},
{"http://visitedest.com/y/a", "VA", 10, 1, 20},
{"http://visitedest.com/y/b", "VB", 9, 1, 20},
{"http://visitedest.com/x/c", "VC", 8, 1, 20},
{"http://visitedest.com/x/d", "VD", 7, 1, 20},
{"http://visitedest.com/y/e", "VE", 6, 1, 20},
{"http://typeredest.com/y/a", "TA", 5, 5, 0},
{"http://typeredest.com/y/b", "TB", 5, 4, 0},
{"http://typeredest.com/x/c", "TC", 5, 3, 0},
{"http://typeredest.com/x/d", "TD", 5, 2, 0},
{"http://typeredest.com/y/e", "TE", 5, 1, 0},
{"http://daysagoest.com/y/a", "DA", 1, 1, 0},
{"http://daysagoest.com/y/b", "DB", 1, 1, 1},
{"http://daysagoest.com/x/c", "DC", 1, 1, 2},
{"http://daysagoest.com/x/d", "DD", 1, 1, 3},
{"http://daysagoest.com/y/e", "DE", 1, 1, 4},
{"http://abcdefghixyzjklmnopqrstuvw.com/a", "", 3, 1, 0},
{"http://spaces.com/path%20with%20spaces/foo.html", "Spaces", 2, 2, 0},
{"http://abcdefghijklxyzmnopqrstuvw.com/a", "", 3, 1, 0},
{"http://abcdefxyzghijklmnopqrstuvw.com/a", "", 3, 1, 0},
{"http://abcxyzdefghijklmnopqrstuvw.com/a", "", 3, 1, 0},
{"http://xyzabcdefghijklmnopqrstuvw.com/a", "", 3, 1, 0},
{"http://cda.com/Dogs%20Cats%20Gorillas%20Sea%20Slugs%20and%20Mice",
"Dogs & Cats & Mice & Other Animals", 1, 1, 0},
{"https://monkeytrap.org/", "", 3, 1, 0},
{"http://popularsitewithpathonly.com/moo",
"popularsitewithpathonly.com/moo", 50, 50, 0},
{"http://popularsitewithroot.com/", "popularsitewithroot.com", 50, 50, 0},
{"http://testsearch.com/?q=thequery", "Test Search Engine", 10, 10, 0},
{"http://testsearch.com/", "Test Search Engine", 9, 9, 0},
{"http://anotherengine.com/?q=thequery", "Another Search Engine", 8, 8,
0},
// The encoded stuff between /wiki/ and the # is 第二次世界大戦
{"http://ja.wikipedia.org/wiki/%E7%AC%AC%E4%BA%8C%E6%AC%A1%E4%B8%96%E7%95"
"%8C%E5%A4%A7%E6%88%A6#.E3.83.B4.E3.82.A7.E3.83.AB.E3.82.B5.E3.82.A4.E3."
"83.A6.E4.BD.93.E5.88.B6",
"Title Unimportant", 2, 2, 0},
{"https://twitter.com/fungoodtimes", "relatable!", 1, 1, 0},
};
}
void MAYBE_HistoryQuickProviderTest::FillData() {
for (const auto& info : GetTestData()) {
history::URLRow row{GURL(info.url)};
ASSERT_TRUE(row.url().is_valid());
row.set_title(base::UTF8ToUTF16(info.title));
row.set_visit_count(info.visit_count);
row.set_typed_count(info.typed_count);
row.set_last_visit(base::Time::Now() -
base::TimeDelta::FromDays(info.days_from_now));
AddFakeURLToHistoryDB(history_backend()->db(), row);
}
}
MAYBE_HistoryQuickProviderTest::SetShouldContain::SetShouldContain(
const ACMatches& matched_urls) {
for (auto iter = matched_urls.begin(); iter != matched_urls.end(); ++iter)
matches_.insert(iter->destination_url.spec());
}
void MAYBE_HistoryQuickProviderTest::SetShouldContain::operator()(
const std::string& expected) {
EXPECT_EQ(1U, matches_.erase(expected))
<< "Results did not contain '" << expected << "' but should have.";
}
void MAYBE_HistoryQuickProviderTest::RunTest(
const base::string16 text,
bool prevent_inline_autocomplete,
std::vector<std::string> expected_urls,
bool can_inline_top_result,
base::string16 expected_fill_into_edit,
base::string16 expected_autocompletion) {
RunTestWithCursor(text, base::string16::npos, prevent_inline_autocomplete,
expected_urls, can_inline_top_result,
expected_fill_into_edit, expected_autocompletion);
}
void MAYBE_HistoryQuickProviderTest::RunTestWithCursor(
const base::string16 text,
const size_t cursor_position,
bool prevent_inline_autocomplete,
std::vector<std::string> expected_urls,
bool can_inline_top_result,
base::string16 expected_fill_into_edit,
base::string16 expected_autocompletion) {
SCOPED_TRACE(text); // Minimal hint to query being run.
base::RunLoop().RunUntilIdle();
AutocompleteInput input(text, cursor_position,
metrics::OmniboxEventProto::OTHER,
TestSchemeClassifier());
input.set_prevent_inline_autocomplete(prevent_inline_autocomplete);
provider_->Start(input, false);
EXPECT_TRUE(provider_->done());
ac_matches_ = provider_->matches();
// We should have gotten back at most
// AutocompleteProvider::provider_max_matches().
EXPECT_LE(ac_matches_.size(), provider_->provider_max_matches());
// If the number of expected and actual matches aren't equal then we need
// test no further, but let's do anyway so that we know which URLs failed.
EXPECT_EQ(expected_urls.size(), ac_matches_.size());
// Verify that all expected URLs were found and that all found URLs
// were expected.
std::set<std::string> leftovers =
for_each(expected_urls.begin(), expected_urls.end(),
SetShouldContain(ac_matches_)).LeftOvers();
EXPECT_EQ(0U, leftovers.size()) << "There were " << leftovers.size()
<< " unexpected results, one of which was: '"
<< *(leftovers.begin()) << "'.";
if (expected_urls.empty())
return;
ASSERT_FALSE(ac_matches_.empty());
// Verify that we got the results in the order expected.
int best_score = ac_matches_.begin()->relevance + 1;
int i = 0;
std::vector<std::string>::const_iterator expected = expected_urls.begin();
for (ACMatches::const_iterator actual = ac_matches_.begin();
actual != ac_matches_.end() && expected != expected_urls.end();
++actual, ++expected, ++i) {
EXPECT_EQ(*expected, actual->destination_url.spec())
<< "For result #" << i << " we got '" << actual->destination_url.spec()
<< "' but expected '" << *expected << "'.";
EXPECT_LT(actual->relevance, best_score)
<< "At result #" << i << " (url=" << actual->destination_url.spec()
<< "), we noticed scores are not monotonically decreasing.";
best_score = actual->relevance;
}
EXPECT_EQ(can_inline_top_result, ac_matches_[0].allowed_to_be_default_match);
if (can_inline_top_result)
EXPECT_EQ(expected_autocompletion, ac_matches_[0].inline_autocompletion);
EXPECT_EQ(expected_fill_into_edit, ac_matches_[0].fill_into_edit);
}
bool MAYBE_HistoryQuickProviderTest::GetURLProxy(const GURL& url) {
base::CancelableTaskTracker task_tracker;
bool result = false;
client_->GetHistoryService()->ScheduleDBTask(
FROM_HERE,
std::unique_ptr<history::HistoryDBTask>(new GetURLTask(url, &result)),
&task_tracker);
// Run the message loop until GetURLTask::DoneRunOnMainThread stops it. If
// the test hangs, DoneRunOnMainThread isn't being invoked correctly.
base::RunLoop().Run();
return result;
}
TEST_F(MAYBE_HistoryQuickProviderTest, SimpleSingleMatch) {
std::vector<std::string> expected_urls;
expected_urls.push_back("http://slashdot.org/favorite_page.html");
RunTest(ASCIIToUTF16("slashdot"), false, expected_urls, true,
ASCIIToUTF16("slashdot.org/favorite_page.html"),
ASCIIToUTF16(".org/favorite_page.html"));
}
TEST_F(MAYBE_HistoryQuickProviderTest, SingleMatchWithCursor) {
std::vector<std::string> expected_urls;
expected_urls.push_back("http://slashdot.org/favorite_page.html");
// With cursor after "slash", we should retrieve the desired result but it
// should not be allowed to be the default match.
RunTestWithCursor(ASCIIToUTF16("slashfavorite_page.html"), 5, false,
expected_urls, false,
ASCIIToUTF16("slashdot.org/favorite_page.html"),
base::string16());
}
TEST_F(MAYBE_HistoryQuickProviderTest, MatchWithAndWithoutCursorWordBreak) {
std::vector<std::string> expected_urls;
expected_urls.push_back("https://twitter.com/fungoodtimes");
// With cursor after "good", we should retrieve the desired result but it
// should not be allowed to be the default match.
RunTestWithCursor(ASCIIToUTF16("fungoodtimes"), 7, false, expected_urls,
false, ASCIIToUTF16("https://twitter.com/fungoodtimes"),
base::string16());
}
TEST_F(MAYBE_HistoryQuickProviderTest, WordBoundariesWithPunctuationMatch) {
std::vector<std::string> expected_urls;
expected_urls.push_back("http://popularsitewithpathonly.com/moo");
RunTest(ASCIIToUTF16("/moo"), false, expected_urls, false,
ASCIIToUTF16("popularsitewithpathonly.com/moo"), base::string16());
}
TEST_F(MAYBE_HistoryQuickProviderTest, MultiTermTitleMatch) {
std::vector<std::string> expected_urls;
expected_urls.push_back(
"http://cda.com/Dogs%20Cats%20Gorillas%20Sea%20Slugs%20and%20Mice");
RunTest(ASCIIToUTF16("mice other animals"), false, expected_urls, false,
ASCIIToUTF16("cda.com/Dogs Cats Gorillas Sea Slugs and Mice"),
base::string16());
}
TEST_F(MAYBE_HistoryQuickProviderTest, NonWordLastCharacterMatch) {
std::string expected_url("http://slashdot.org/favorite_page.html");
std::vector<std::string> expected_urls;
expected_urls.push_back(expected_url);
RunTest(ASCIIToUTF16("slashdot.org/"), false, expected_urls, true,
ASCIIToUTF16("slashdot.org/favorite_page.html"),
ASCIIToUTF16("favorite_page.html"));
}
TEST_F(MAYBE_HistoryQuickProviderTest, MultiMatch) {
std::vector<std::string> expected_urls;
// Scores high because of typed_count.
expected_urls.push_back("http://foo.com/");
// Scores high because of visit count.
expected_urls.push_back("http://foo.com/dir/another/");
// Scores high because of high visit count.
expected_urls.push_back("http://foo.com/dir/another/again/");
RunTest(ASCIIToUTF16("foo"), false, expected_urls, true,
ASCIIToUTF16("foo.com"), ASCIIToUTF16(".com"));
}
TEST_F(MAYBE_HistoryQuickProviderTest, StartRelativeMatch) {
std::vector<std::string> expected_urls;
expected_urls.push_back("http://xyzabcdefghijklmnopqrstuvw.com/a");
RunTest(ASCIIToUTF16("xyza"), false, expected_urls, true,
ASCIIToUTF16("xyzabcdefghijklmnopqrstuvw.com/a"),
ASCIIToUTF16("bcdefghijklmnopqrstuvw.com/a"));
}
TEST_F(MAYBE_HistoryQuickProviderTest, EncodingMatch) {
std::vector<std::string> expected_urls;
expected_urls.push_back("http://spaces.com/path%20with%20spaces/foo.html");
RunTest(ASCIIToUTF16("path with spaces"), false, expected_urls, false,
ASCIIToUTF16("spaces.com/path with spaces/foo.html"),
base::string16());
}
TEST_F(MAYBE_HistoryQuickProviderTest, ContentsClass) {
std::vector<std::string> expected_urls;
expected_urls.push_back(
"http://ja.wikipedia.org/wiki/%E7%AC%AC%E4%BA%8C%E6%AC%A1%E4%B8%96%E7"
"%95%8C%E5%A4%A7%E6%88%A6#.E3.83.B4.E3.82.A7.E3.83.AB.E3.82.B5.E3.82."
"A4.E3.83.A6.E4.BD.93.E5.88.B6");
RunTest(base::UTF8ToUTF16("第二 e3"), false, expected_urls, false,
base::UTF8ToUTF16("ja.wikipedia.org/wiki/第二次世界大戦#.E3.83.B4.E3."
"82.A7.E3.83.AB.E3.82.B5.E3.82.A4.E3.83.A6.E4.BD."
"93.E5.88.B6"),
base::string16());
#if DCHECK_IS_ON()
ac_matches()[0].Validate();
#endif // DCHECK_IS_ON();
// Verify that contents_class divides the string in the right places.
// [22, 24) is the "第二". All the other pairs are the "e3".
ACMatchClassifications contents_class(ac_matches()[0].contents_class);
size_t expected_offsets[] = { 0, 22, 24, 31, 33, 40, 42, 49, 51, 58, 60, 67,
69, 76, 78 };
// ScoredHistoryMatch may not highlight all the occurrences of these terms
// because it only highlights terms at word breaks, and it only stores word
// breaks up to some specified number of characters (50 at the time of this
// comment). This test is written flexibly so it still will pass if we
// increase that number in the future. Regardless, we require the first
// five offsets to be correct--in this example these cover at least one
// occurrence of each term.
EXPECT_LE(contents_class.size(), base::size(expected_offsets));
EXPECT_GE(contents_class.size(), 5u);
for (size_t i = 0; i < contents_class.size(); ++i)
EXPECT_EQ(expected_offsets[i], contents_class[i].offset);
}
TEST_F(MAYBE_HistoryQuickProviderTest, VisitCountMatches) {
std::vector<std::string> expected_urls;
expected_urls.push_back("http://visitedest.com/y/a");
expected_urls.push_back("http://visitedest.com/y/b");
expected_urls.push_back("http://visitedest.com/x/c");
RunTest(ASCIIToUTF16("visitedest"), false, expected_urls, true,
ASCIIToUTF16("visitedest.com/y/a"),
ASCIIToUTF16(".com/y/a"));
}
TEST_F(MAYBE_HistoryQuickProviderTest, TypedCountMatches) {
std::vector<std::string> expected_urls;
expected_urls.push_back("http://typeredest.com/y/a");
expected_urls.push_back("http://typeredest.com/y/b");
expected_urls.push_back("http://typeredest.com/x/c");
RunTest(ASCIIToUTF16("typeredest"), false, expected_urls, true,
ASCIIToUTF16("typeredest.com/y/a"),
ASCIIToUTF16(".com/y/a"));
}
TEST_F(MAYBE_HistoryQuickProviderTest, DaysAgoMatches) {
std::vector<std::string> expected_urls;
expected_urls.push_back("http://daysagoest.com/y/a");
expected_urls.push_back("http://daysagoest.com/y/b");
expected_urls.push_back("http://daysagoest.com/x/c");
RunTest(ASCIIToUTF16("daysagoest"), false, expected_urls, true,
ASCIIToUTF16("daysagoest.com/y/a"),
ASCIIToUTF16(".com/y/a"));
}
TEST_F(MAYBE_HistoryQuickProviderTest, EncodingLimitMatch) {
std::vector<std::string> expected_urls;
std::string url(
"http://cda.com/Dogs%20Cats%20Gorillas%20Sea%20Slugs%20and%20Mice");
// First check that a mid-word match yield no results.
RunTest(ASCIIToUTF16("ice"), false, expected_urls, false,
ASCIIToUTF16("cda.com/Dogs Cats Gorillas Sea Slugs and Mice"),
base::string16());
// Then check that we get results when the match is at a word start
// that is present because of an encoded separate (%20 = space).
expected_urls.push_back(url);
RunTest(ASCIIToUTF16("Mice"), false, expected_urls, false,
ASCIIToUTF16("cda.com/Dogs Cats Gorillas Sea Slugs and Mice"),
base::string16());
// Verify that the matches' ACMatchClassifications offsets are in range.
ACMatchClassifications content(ac_matches()[0].contents_class);
// The max offset accounts for 6 occurrences of '%20' plus the 'http://'.
const size_t max_offset = url.length() - ((6 * 2) + 7);
for (ACMatchClassifications::const_iterator citer = content.begin();
citer != content.end(); ++citer)
EXPECT_LT(citer->offset, max_offset);
ACMatchClassifications description(ac_matches()[0].description_class);
std::string page_title("Dogs & Cats & Mice & Other Animals");
for (ACMatchClassifications::const_iterator diter = description.begin();
diter != description.end(); ++diter)
EXPECT_LT(diter->offset, page_title.length());
}
TEST_F(MAYBE_HistoryQuickProviderTest, Spans) {
// Test SpansFromTermMatch
TermMatches matches_a;
// Simulates matches: '.xx.xxx..xx...xxxxx..' which will test no match at
// either beginning or end as well as adjacent matches.
matches_a.push_back(TermMatch(1, 1, 2));
matches_a.push_back(TermMatch(2, 4, 3));
matches_a.push_back(TermMatch(3, 9, 1));
matches_a.push_back(TermMatch(3, 10, 1));
matches_a.push_back(TermMatch(4, 14, 5));
ACMatchClassifications spans_a =
HistoryQuickProvider::SpansFromTermMatch(matches_a, 20, false);
// ACMatch spans should be: 'NM-NM---N-M-N--M----N-'
ASSERT_EQ(9U, spans_a.size());
EXPECT_EQ(0U, spans_a[0].offset);
EXPECT_EQ(ACMatchClassification::NONE, spans_a[0].style);
EXPECT_EQ(1U, spans_a[1].offset);
EXPECT_EQ(ACMatchClassification::MATCH, spans_a[1].style);
EXPECT_EQ(3U, spans_a[2].offset);
EXPECT_EQ(ACMatchClassification::NONE, spans_a[2].style);
EXPECT_EQ(4U, spans_a[3].offset);
EXPECT_EQ(ACMatchClassification::MATCH, spans_a[3].style);
EXPECT_EQ(7U, spans_a[4].offset);
EXPECT_EQ(ACMatchClassification::NONE, spans_a[4].style);
EXPECT_EQ(9U, spans_a[5].offset);
EXPECT_EQ(ACMatchClassification::MATCH, spans_a[5].style);
EXPECT_EQ(11U, spans_a[6].offset);
EXPECT_EQ(ACMatchClassification::NONE, spans_a[6].style);
EXPECT_EQ(14U, spans_a[7].offset);
EXPECT_EQ(ACMatchClassification::MATCH, spans_a[7].style);
EXPECT_EQ(19U, spans_a[8].offset);
EXPECT_EQ(ACMatchClassification::NONE, spans_a[8].style);
// Simulates matches: 'xx.xx' which will test matches at both beginning and
// end.
TermMatches matches_b;
matches_b.push_back(TermMatch(1, 0, 2));
matches_b.push_back(TermMatch(2, 3, 2));
ACMatchClassifications spans_b =
HistoryQuickProvider::SpansFromTermMatch(matches_b, 5, true);
// ACMatch spans should be: 'M-NM-'
ASSERT_EQ(3U, spans_b.size());
EXPECT_EQ(0U, spans_b[0].offset);
EXPECT_EQ(ACMatchClassification::MATCH | ACMatchClassification::URL,
spans_b[0].style);
EXPECT_EQ(2U, spans_b[1].offset);
EXPECT_EQ(ACMatchClassification::URL, spans_b[1].style);
EXPECT_EQ(3U, spans_b[2].offset);
EXPECT_EQ(ACMatchClassification::MATCH | ACMatchClassification::URL,
spans_b[2].style);
}
TEST_F(MAYBE_HistoryQuickProviderTest, DeleteMatch) {
GURL test_url("http://slashdot.org/favorite_page.html");
std::vector<std::string> expected_urls;
expected_urls.push_back(test_url.spec());
// Fill up ac_matches_; we don't really care about the test yet.
RunTest(ASCIIToUTF16("slashdot"), false, expected_urls, true,
ASCIIToUTF16("slashdot.org/favorite_page.html"),
ASCIIToUTF16(".org/favorite_page.html"));
EXPECT_EQ(1U, ac_matches().size());
EXPECT_TRUE(GetURLProxy(test_url));
provider().DeleteMatch(ac_matches()[0]);
// Check that the underlying URL is deleted from the history DB (this implies
// that all visits are gone as well). Also verify that a deletion notification
// is sent, in response to which the secondary data stores (InMemoryDatabase,
// InMemoryURLIndex) will drop any data they might have pertaining to the URL.
// To ensure that the deletion has been propagated everywhere before we start
// verifying post-deletion states, first wait until we see the notification.
WaitForURLsDeletedNotification(client().GetHistoryService());
EXPECT_FALSE(GetURLProxy(test_url));
// Just to be on the safe side, explicitly verify that we have deleted enough
// data so that we will not be serving the same result again.
expected_urls.clear();
RunTest(ASCIIToUTF16("slashdot"), false, expected_urls, true,
ASCIIToUTF16("NONE EXPECTED"), base::string16());
}
TEST_F(MAYBE_HistoryQuickProviderTest, PreventBeatingURLWhatYouTypedMatch) {
std::vector<std::string> expected_urls;
expected_urls.clear();
expected_urls.push_back("http://popularsitewithroot.com/");
// If the user enters a hostname (no path) that they have visited
// before, we should make sure that all HistoryQuickProvider results
// have scores less than what HistoryURLProvider will assign the
// URL-what-you-typed match.
RunTest(ASCIIToUTF16("popularsitewithroot.com"), false, expected_urls, true,
ASCIIToUTF16("popularsitewithroot.com"), base::string16());
EXPECT_LT(ac_matches()[0].relevance,
HistoryURLProvider::kScoreForBestInlineableResult);
// Check that if the user didn't quite enter the full hostname, this
// hostname would've normally scored above the URL-what-you-typed match.
RunTest(ASCIIToUTF16("popularsitewithroot.c"), false, expected_urls, true,
ASCIIToUTF16("popularsitewithroot.com"),
ASCIIToUTF16("om"));
EXPECT_GE(ac_matches()[0].relevance,
HistoryURLProvider::kScoreForWhatYouTypedResult);
expected_urls.clear();
expected_urls.push_back("http://popularsitewithpathonly.com/moo");
// If the user enters a hostname of a host that they have visited
// but never visited the root page of, we should make sure that all
// HistoryQuickProvider results have scores less than what the
// HistoryURLProvider will assign the URL-what-you-typed match.
RunTest(ASCIIToUTF16("popularsitewithpathonly.com"), false, expected_urls,
true,
ASCIIToUTF16("popularsitewithpathonly.com/moo"),
ASCIIToUTF16("/moo"));
EXPECT_LT(ac_matches()[0].relevance,
HistoryURLProvider::kScoreForUnvisitedIntranetResult);
// Verify the same thing happens if the user adds a / to end of the
// hostname.
RunTest(ASCIIToUTF16("popularsitewithpathonly.com/"), false, expected_urls,
true, ASCIIToUTF16("popularsitewithpathonly.com/moo"),
ASCIIToUTF16("moo"));
EXPECT_LT(ac_matches()[0].relevance,
HistoryURLProvider::kScoreForUnvisitedIntranetResult);
// Check that if the user didn't quite enter the full hostname, this
// page would've normally scored above the URL-what-you-typed match.
RunTest(ASCIIToUTF16("popularsitewithpathonly.co"), false, expected_urls,
true, ASCIIToUTF16("popularsitewithpathonly.com/moo"),
ASCIIToUTF16("m/moo"));
EXPECT_GE(ac_matches()[0].relevance,
HistoryURLProvider::kScoreForWhatYouTypedResult);
// If the user enters a hostname + path that they have not visited
// before (but visited other things on the host), we can allow
// inline autocompletions.
RunTest(ASCIIToUTF16("popularsitewithpathonly.com/mo"), false, expected_urls,
true,
ASCIIToUTF16("popularsitewithpathonly.com/moo"),
ASCIIToUTF16("o"));
EXPECT_GE(ac_matches()[0].relevance,
HistoryURLProvider::kScoreForWhatYouTypedResult);
// If the user enters a hostname + path that they have visited
// before, we should make sure that all HistoryQuickProvider results
// have scores less than what the HistoryURLProvider will assign
// the URL-what-you-typed match.
RunTest(ASCIIToUTF16("popularsitewithpathonly.com/moo"), false,
expected_urls, true,
ASCIIToUTF16("popularsitewithpathonly.com/moo"), base::string16());
EXPECT_LT(ac_matches()[0].relevance,
HistoryURLProvider::kScoreForBestInlineableResult);
}
TEST_F(MAYBE_HistoryQuickProviderTest, PreventInlineAutocomplete) {
std::vector<std::string> expected_urls;
expected_urls.push_back("http://popularsitewithroot.com/");
// Check that the desired URL is normally allowed to be the default match
// against input that is a prefex of the URL.
RunTest(ASCIIToUTF16("popularsitewithr"), false, expected_urls, true,
ASCIIToUTF16("popularsitewithroot.com"),
ASCIIToUTF16("oot.com"));
// Check that it's not allowed to be the default match if
// prevent_inline_autocomplete is true.
RunTest(ASCIIToUTF16("popularsitewithr"), true, expected_urls, false,
ASCIIToUTF16("popularsitewithroot.com"),
ASCIIToUTF16("oot.com"));
// But the exact hostname can still match even if prevent inline autocomplete
// is true. i.e., there's no autocompletion necessary; this is effectively
// URL-what-you-typed.
RunTest(ASCIIToUTF16("popularsitewithroot.com"), true, expected_urls, true,
ASCIIToUTF16("popularsitewithroot.com"), base::string16());
// The above still holds even with an extra trailing slash.
RunTest(ASCIIToUTF16("popularsitewithroot.com/"), true, expected_urls, true,
ASCIIToUTF16("popularsitewithroot.com"), base::string16());
}
TEST_F(MAYBE_HistoryQuickProviderTest, DoesNotProvideMatchesOnFocus) {
AutocompleteInput input(ASCIIToUTF16("popularsite"),
metrics::OmniboxEventProto::OTHER,
TestSchemeClassifier());
input.set_from_omnibox_focus(true);
provider().Start(input, false);
EXPECT_TRUE(provider().matches().empty());
}
ScoredHistoryMatch BuildScoredHistoryMatch(const std::string& url_text) {
return ScoredHistoryMatch(
history::URLRow(GURL(url_text)), VisitInfoVector(), ASCIIToUTF16("h"),
String16Vector(1, ASCIIToUTF16("h")), WordStarts(1, 0), RowWordStarts(),
false, 0, base::Time());
}
// Trim the http:// scheme from the contents in the general case.
TEST_F(MAYBE_HistoryQuickProviderTest, DoTrimHttpScheme) {
AutocompleteInput input(ASCIIToUTF16("face"),
metrics::OmniboxEventProto::OTHER,
TestSchemeClassifier());
provider().Start(input, false);
ScoredHistoryMatch history_match =
BuildScoredHistoryMatch("http://www.facebook.com");
AutocompleteMatch match = provider().QuickMatchToACMatch(history_match, 100);
EXPECT_EQ(ASCIIToUTF16("facebook.com"), match.contents);
}
// Don't trim the http:// scheme from the match contents if
// the user input included a scheme.
TEST_F(MAYBE_HistoryQuickProviderTest, DontTrimHttpSchemeIfInputHasScheme) {
AutocompleteInput input(ASCIIToUTF16("http://face"),
metrics::OmniboxEventProto::OTHER,
TestSchemeClassifier());
provider().Start(input, false);
ScoredHistoryMatch history_match =
BuildScoredHistoryMatch("http://www.facebook.com");
AutocompleteMatch match = provider().QuickMatchToACMatch(history_match, 100);
EXPECT_EQ(ASCIIToUTF16("http://facebook.com"), match.contents);
}
// Don't trim the http:// scheme from the match contents if
// the user input matched it.
TEST_F(MAYBE_HistoryQuickProviderTest, DontTrimHttpSchemeIfInputMatches) {
AutocompleteInput input(ASCIIToUTF16("ht"), metrics::OmniboxEventProto::OTHER,
TestSchemeClassifier());
provider().Start(input, false);
ScoredHistoryMatch history_match =
BuildScoredHistoryMatch("http://www.facebook.com");
history_match.match_in_scheme = true;
AutocompleteMatch match = provider().QuickMatchToACMatch(history_match, 100);
EXPECT_EQ(ASCIIToUTF16("http://facebook.com"), match.contents);
}
// Don't trim the https:// scheme from the match contents if the user input
// included a scheme.
TEST_F(MAYBE_HistoryQuickProviderTest, DontTrimHttpsSchemeIfInputHasScheme) {
AutocompleteInput input(ASCIIToUTF16("https://face"),
metrics::OmniboxEventProto::OTHER,
TestSchemeClassifier());
provider().Start(input, false);
ScoredHistoryMatch history_match =
BuildScoredHistoryMatch("https://www.facebook.com");
AutocompleteMatch match = provider().QuickMatchToACMatch(history_match, 100);
EXPECT_EQ(ASCIIToUTF16("https://facebook.com"), match.contents);
}
// Trim the https:// scheme from the match contents if nothing prevents it.
TEST_F(MAYBE_HistoryQuickProviderTest, DoTrimHttpsScheme) {
AutocompleteInput input(ASCIIToUTF16("face"),
metrics::OmniboxEventProto::OTHER,
TestSchemeClassifier());
provider().Start(input, false);
ScoredHistoryMatch history_match =
BuildScoredHistoryMatch("https://www.facebook.com");
AutocompleteMatch match = provider().QuickMatchToACMatch(history_match, 100);
EXPECT_EQ(ASCIIToUTF16("facebook.com"), match.contents);
}
TEST_F(MAYBE_HistoryQuickProviderTest, CorrectAutocompleteWithTrailingSlash) {
provider().autocomplete_input_ = AutocompleteInput(
base::ASCIIToUTF16("cr/"), metrics::OmniboxEventProto::OTHER,
TestSchemeClassifier());
RowWordStarts word_starts;
word_starts.url_word_starts_ = {0};
ScoredHistoryMatch sh_match(history::URLRow(GURL("http://cr/")),
VisitInfoVector(), ASCIIToUTF16("cr/"),
{ASCIIToUTF16("cr")}, {0}, word_starts, false, 0,
base::Time());
AutocompleteMatch ac_match(provider().QuickMatchToACMatch(sh_match, 0));
EXPECT_EQ(base::ASCIIToUTF16("cr/"), ac_match.fill_into_edit);
EXPECT_EQ(base::ASCIIToUTF16(""), ac_match.inline_autocompletion);
EXPECT_TRUE(ac_match.allowed_to_be_default_match);
}
// HQPOrderingTest -------------------------------------------------------------
class HQPOrderingTest : public MAYBE_HistoryQuickProviderTest {
public:
HQPOrderingTest() = default;
protected:
std::vector<TestURLInfo> GetTestData() override;
private:
DISALLOW_COPY_AND_ASSIGN(HQPOrderingTest);
};
std::vector<MAYBE_HistoryQuickProviderTest::TestURLInfo>
HQPOrderingTest::GetTestData() {
return {
{"http://www.teamliquid.net/tlpd/korean/games/21648_bisu_vs_iris", "", 6,
3, 256},
{"http://www.amazon.com/",
"amazon.com: online shopping for electronics, apparel, computers, "
"books, dvds & more",
20, 20, 10},
{"http://www.teamliquid.net/forum/viewmessage.php?topic_id=52045&"
"currentpage=83",
"google images", 6, 6, 0},
{"http://www.tempurpedic.com/", "tempur-pedic", 7, 7, 0},
{"http://www.teamfortress.com/", "", 5, 5, 6},
{"http://www.rottentomatoes.com/", "", 3, 3, 7},
{"http://music.google.com/music/listen?u=0#start_pl", "", 3, 3, 9},
{"https://www.emigrantdirect.com/",
"high interest savings account, high yield savings - emigrantdirect", 5,
5, 3},
{"http://store.steampowered.com/", "", 6, 6, 1},
{"http://techmeme.com/", "techmeme", 111, 110, 4},
{"http://www.teamliquid.net/tlpd", "team liquid progaming database", 15,
15, 4},
{"http://store.steampowered.com/", "the steam summer camp sale", 6, 6, 1},
{"http://www.teamliquid.net/tlpd/korean/players",
"tlpd - bw korean - player index", 25, 7, 219},
{"http://slashdot.org/", "slashdot: news for nerds, stuff that matters",
3, 3, 6},
{"http://translate.google.com/", "google translate", 3, 3, 0},
{"http://arstechnica.com/", "ars technica", 3, 3, 3},
{"http://www.rottentomatoes.com/",
"movies | movie trailers | reviews - rotten tomatoes", 3, 3, 7},
{"http://www.teamliquid.net/",
"team liquid - starcraft 2 and brood war pro gaming news", 26, 25, 3},
{"http://metaleater.com/", "metaleater", 4, 3, 8},
{"http://half.com/",
"half.com: textbooks , books , music , movies , games , video games", 4,
4, 6},
{"http://teamliquid.net/",
"team liquid - starcraft 2 and brood war pro gaming news", 8, 5, 9},
};
}
TEST_F(HQPOrderingTest, TEMatch) {
std::vector<std::string> expected_urls;
expected_urls.push_back("http://techmeme.com/");
expected_urls.push_back("http://www.teamliquid.net/");
expected_urls.push_back("http://www.teamliquid.net/tlpd");
RunTest(ASCIIToUTF16("te"), false, expected_urls, true,
ASCIIToUTF16("techmeme.com"),
ASCIIToUTF16("chmeme.com"));
}
TEST_F(HQPOrderingTest, TEAMatch) {
std::vector<std::string> expected_urls;
expected_urls.push_back("http://www.teamliquid.net/");
expected_urls.push_back("http://www.teamliquid.net/tlpd");
expected_urls.push_back("http://teamliquid.net/");
RunTest(ASCIIToUTF16("tea"), false, expected_urls, true,
ASCIIToUTF16("www.teamliquid.net"),
ASCIIToUTF16("mliquid.net"));
}