Google Git
Sign in
chromium / chromium / src / 6353cbe0ea8cd363b5bad185028407d05000954c
commit6353cbe0ea8cd363b5bad185028407d05000954c[log] [tgz]
authorrbpotter <rbpotter@chromium.org>Thu Apr 22 15:48:28 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Apr 22 15:48:28 2021
treee447a84ba46fa9cb06c257ad374c9d4f9742d619
parent4e08f84946416194b3a8e542c3a93da4150d6476 [diff]
WebUI: Make web_ui() non-const

This method is marked as const, but it returns a non-const pointer to
an object that owns the WebUIMessageHandler and therefore can modify or
even delete the handler, if non-const methods are called on it. In
accordance with the guidance at [1], change this method to non-const.

Note: Not adding an additional:
const WebUI* web_ui() const;
method, as a const WebUI* does not seem to be useful; since WebUI is an
interface, all of its methods are non-const, and handlers generally
call this method in order to do something like GetWebContents().

[1] https://chromium.googlesource.com/chromium/src/+/main/styleguide/c++/const.md

Bug: None
Change-Id: Ia0a48e84eb36919fe2d027b450cccc25417238ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2827427
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#875177}
35 files changed
tree: e447a84ba46fa9cb06c257ad374c9d4f9742d619
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.