commit 6d0d36a8d9dc2268c1db10f8f44342b80c81a5d4
author Lei Zhang <thestig@chromium.org> Fri Feb 08 04:21:31 2019
committer Commit Bot <commit-bot@chromium.org> Fri Feb 08 04:21:31 2019
tree 9adab722a35faabdfb8f4003e4c6cfd30b35094d
parent 5d44fc3741a05eb683a884f0ecf62b9868196085

Remove a check that always evaluates to true in AppMenuModel.

Change-Id: I9ca2e8106ae2f9e35d841709137b3906d007f589
Reviewed-on: https://chromium-review.googlesource.com/c/1457433
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630166}

chrome/browser/ui/toolbar/app_menu_model.cc

diff --git a/chrome/browser/ui/toolbar/app_menu_model.cc b/chrome/browser/ui/toolbar/app_menu_model.cc
index 6c96886..ef5ab4c3 100644
--- a/chrome/browser/ui/toolbar/app_menu_model.cc
+++ b/chrome/browser/ui/toolbar/app_menu_model.cc
@@ -244,11 +244,12 @@
       uma_action_recorded_(false),
       provider_(provider),
       browser_(browser),
-      app_menu_icon_controller_(app_menu_icon_controller) {}
+      app_menu_icon_controller_(app_menu_icon_controller) {
+  DCHECK(browser_);
+}
 
 AppMenuModel::~AppMenuModel() {
-  if (browser_)  // Null in Cocoa tests.
-    browser_->tab_strip_model()->RemoveObserver(this);
+  browser_->tab_strip_model()->RemoveObserver(this);
 }
 
 void AppMenuModel::Init() {