| // Copyright 2017 The Chromium Authors. All rights reserved. |
| // Use of this source code is governed by a BSD-style license that can be |
| // found in the LICENSE file. |
| |
| #include "components/autofill/core/browser/credit_card_save_manager.h" |
| |
| #include <stddef.h> |
| |
| #include <algorithm> |
| #include <list> |
| #include <map> |
| #include <memory> |
| #include <string> |
| #include <utility> |
| #include <vector> |
| |
| #include "base/guid.h" |
| #include "base/metrics/metrics_hashes.h" |
| #include "base/test/metrics/histogram_tester.h" |
| #include "base/test/scoped_feature_list.h" |
| #include "base/test/scoped_task_environment.h" |
| #include "base/threading/thread_task_runner_handle.h" |
| #include "base/time/time.h" |
| #include "build/build_config.h" |
| #include "components/autofill/core/browser/autofill_experiments.h" |
| #include "components/autofill/core/browser/autofill_metrics.h" |
| #include "components/autofill/core/browser/autofill_profile.h" |
| #include "components/autofill/core/browser/autofill_test_utils.h" |
| #include "components/autofill/core/browser/credit_card.h" |
| #include "components/autofill/core/browser/payments/test_payments_client.h" |
| #include "components/autofill/core/browser/personal_data_manager.h" |
| #include "components/autofill/core/browser/test_autofill_client.h" |
| #include "components/autofill/core/browser/test_autofill_clock.h" |
| #include "components/autofill/core/browser/test_autofill_driver.h" |
| #include "components/autofill/core/browser/test_autofill_manager.h" |
| #include "components/autofill/core/browser/test_credit_card_save_manager.h" |
| #include "components/autofill/core/browser/test_personal_data_manager.h" |
| #include "components/autofill/core/browser/test_sync_service.h" |
| #include "components/autofill/core/browser/validation.h" |
| #include "components/autofill/core/browser/webdata/autofill_webdata_service.h" |
| #include "components/autofill/core/common/autofill_clock.h" |
| #include "components/autofill/core/common/autofill_features.h" |
| #include "components/autofill/core/common/form_data.h" |
| #include "components/autofill/core/common/form_field_data.h" |
| #include "components/prefs/pref_service.h" |
| #include "components/ukm/test_ukm_recorder.h" |
| #include "components/ukm/ukm_source.h" |
| #include "net/url_request/url_request_context_getter.h" |
| #include "net/url_request/url_request_test_util.h" |
| #include "services/metrics/public/cpp/ukm_builders.h" |
| #include "services/network/public/cpp/shared_url_loader_factory.h" |
| #include "testing/gmock/include/gmock/gmock.h" |
| #include "testing/gtest/include/gtest/gtest.h" |
| #include "url/gurl.h" |
| |
| using base::ASCIIToUTF16; |
| using testing::_; |
| using testing::AtLeast; |
| using testing::Return; |
| using testing::SaveArg; |
| using testing::UnorderedElementsAre; |
| |
| namespace autofill { |
| namespace { |
| |
| using UkmCardUploadDecisionType = ukm::builders::Autofill_CardUploadDecision; |
| using UkmDeveloperEngagementType = ukm::builders::Autofill_DeveloperEngagement; |
| |
| const base::Time kArbitraryTime = base::Time::FromDoubleT(25); |
| const base::Time kMuchLaterTime = base::Time::FromDoubleT(5000); |
| |
| std::string NextYear() { |
| base::Time::Exploded now; |
| base::Time::Now().LocalExplode(&now); |
| return std::to_string(now.year + 1); |
| } |
| |
| std::string NextMonth() { |
| base::Time::Exploded now; |
| base::Time::Now().LocalExplode(&now); |
| return std::to_string(now.month % 12 + 1); |
| } |
| |
| class MockAutofillClient : public TestAutofillClient { |
| public: |
| MockAutofillClient() {} |
| |
| ~MockAutofillClient() override {} |
| |
| MOCK_METHOD2(ConfirmSaveCreditCardLocally, |
| void(const CreditCard& card, const base::Closure& callback)); |
| |
| private: |
| DISALLOW_COPY_AND_ASSIGN(MockAutofillClient); |
| }; |
| |
| } // anonymous namespace |
| |
| class CreditCardSaveManagerTest : public testing::Test { |
| public: |
| void SetUp() override { |
| autofill_client_.SetPrefs(test::PrefServiceForTesting()); |
| personal_data_.set_database(autofill_client_.GetDatabase()); |
| personal_data_.SetPrefService(autofill_client_.GetPrefs()); |
| personal_data_.SetSyncServiceForTest(&sync_service_); |
| autofill_driver_.reset(new TestAutofillDriver()); |
| request_context_ = new net::TestURLRequestContextGetter( |
| base::ThreadTaskRunnerHandle::Get()); |
| autofill_driver_->SetURLRequestContext(request_context_.get()); |
| payments_client_ = new payments::TestPaymentsClient( |
| autofill_driver_->GetURLLoaderFactory(), autofill_client_.GetPrefs(), |
| autofill_client_.GetIdentityManager(), |
| /*unmask_delegate=*/nullptr, |
| // Will be set by CreditCardSaveManager's ctor |
| /*save_delegate=*/nullptr); |
| credit_card_save_manager_ = |
| new TestCreditCardSaveManager(autofill_driver_.get(), &autofill_client_, |
| payments_client_, &personal_data_); |
| autofill_manager_.reset(new TestAutofillManager( |
| autofill_driver_.get(), &autofill_client_, &personal_data_, |
| std::unique_ptr<CreditCardSaveManager>(credit_card_save_manager_), |
| payments_client_)); |
| autofill_manager_->SetExpectedObservedSubmission(true); |
| payments_client_->SetSaveDelegate(credit_card_save_manager_); |
| } |
| |
| void TearDown() override { |
| // Order of destruction is important as AutofillManager relies on |
| // PersonalDataManager to be around when it gets destroyed. |
| autofill_manager_.reset(); |
| autofill_driver_.reset(); |
| |
| // Remove the AutofillWebDataService so TestPersonalDataManager does not |
| // need to care about removing self as an observer in destruction. |
| personal_data_.set_database(scoped_refptr<AutofillWebDataService>(nullptr)); |
| personal_data_.SetPrefService(nullptr); |
| personal_data_.ClearCreditCards(); |
| |
| request_context_ = nullptr; |
| } |
| |
| void EnableAutofillUpstreamSendPanFirstSixExperiment() { |
| scoped_feature_list_.InitAndEnableFeature(kAutofillUpstreamSendPanFirstSix); |
| } |
| |
| void EnableAutofillUpstreamUpdatePromptExplanationExperiment() { |
| scoped_feature_list_.InitAndEnableFeature( |
| kAutofillUpstreamUpdatePromptExplanation); |
| } |
| |
| void DisableAutofillUpstreamUpdatePromptExplanationExperiment() { |
| scoped_feature_list_.InitAndDisableFeature( |
| kAutofillUpstreamUpdatePromptExplanation); |
| } |
| |
| void FormsSeen(const std::vector<FormData>& forms) { |
| autofill_manager_->OnFormsSeen(forms, base::TimeTicks()); |
| } |
| |
| void FormSubmitted(const FormData& form) { |
| autofill_manager_->OnFormSubmitted( |
| form, false, SubmissionSource::FORM_SUBMISSION, base::TimeTicks::Now()); |
| } |
| |
| // Populates |form| with data corresponding to a simple credit card form. |
| // Note that this actually appends fields to the form data, which can be |
| // useful for building up more complex test forms. |
| void CreateTestCreditCardFormData(FormData* form, |
| bool is_https, |
| bool use_month_type, |
| bool split_names = false) { |
| form->name = ASCIIToUTF16("MyForm"); |
| if (is_https) { |
| form->origin = GURL("https://myform.com/form.html"); |
| form->action = GURL("https://myform.com/submit.html"); |
| form->main_frame_origin = |
| url::Origin::Create(GURL("https://myform_root.com/form.html")); |
| } else { |
| form->origin = GURL("http://myform.com/form.html"); |
| form->action = GURL("http://myform.com/submit.html"); |
| form->main_frame_origin = |
| url::Origin::Create(GURL("http://myform_root.com/form.html")); |
| } |
| |
| FormFieldData field; |
| if (split_names) { |
| test::CreateTestFormField("First Name on Card", "firstnameoncard", "", |
| "text", &field); |
| field.autocomplete_attribute = "cc-given-name"; |
| form->fields.push_back(field); |
| test::CreateTestFormField("Last Name on Card", "lastnameoncard", "", |
| "text", &field); |
| field.autocomplete_attribute = "cc-family-name"; |
| form->fields.push_back(field); |
| field.autocomplete_attribute = ""; |
| } else { |
| test::CreateTestFormField("Name on Card", "nameoncard", "", "text", |
| &field); |
| form->fields.push_back(field); |
| } |
| test::CreateTestFormField("Card Number", "cardnumber", "", "text", &field); |
| form->fields.push_back(field); |
| if (use_month_type) { |
| test::CreateTestFormField("Expiration Date", "ccmonth", "", "month", |
| &field); |
| form->fields.push_back(field); |
| } else { |
| test::CreateTestFormField("Expiration Date", "ccmonth", "", "text", |
| &field); |
| form->fields.push_back(field); |
| test::CreateTestFormField("", "ccyear", "", "text", &field); |
| form->fields.push_back(field); |
| } |
| test::CreateTestFormField("CVC", "cvc", "", "text", &field); |
| form->fields.push_back(field); |
| } |
| |
| // Fills the fields in |form| with test data. |
| void ManuallyFillAddressForm(const char* first_name, |
| const char* last_name, |
| const char* zip_code, |
| const char* country, |
| FormData* form) { |
| for (FormFieldData& field : form->fields) { |
| if (base::EqualsASCII(field.name, "firstname")) |
| field.value = ASCIIToUTF16(first_name); |
| else if (base::EqualsASCII(field.name, "lastname")) |
| field.value = ASCIIToUTF16(last_name); |
| else if (base::EqualsASCII(field.name, "addr1")) |
| field.value = ASCIIToUTF16("123 Maple"); |
| else if (base::EqualsASCII(field.name, "city")) |
| field.value = ASCIIToUTF16("Dallas"); |
| else if (base::EqualsASCII(field.name, "state")) |
| field.value = ASCIIToUTF16("Texas"); |
| else if (base::EqualsASCII(field.name, "zipcode")) |
| field.value = ASCIIToUTF16(zip_code); |
| else if (base::EqualsASCII(field.name, "country")) |
| field.value = ASCIIToUTF16(country); |
| } |
| } |
| |
| // Tests if credit card data gets saved. |
| void TestSaveCreditCards(bool is_https) { |
| // Set up our form data. |
| FormData form; |
| CreateTestCreditCardFormData(&form, is_https, false); |
| std::vector<FormData> forms(1, form); |
| FormsSeen(forms); |
| |
| // Edit the data, and submit. |
| form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| form.fields[3].value = ASCIIToUTF16(NextYear()); |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)); |
| FormSubmitted(form); |
| } |
| |
| void ExpectUniqueFillableFormParsedUkm() { |
| auto entries = test_ukm_recorder_.GetEntriesByName( |
| UkmDeveloperEngagementType::kEntryName); |
| EXPECT_EQ(1u, entries.size()); |
| for (const auto* const entry : entries) { |
| test_ukm_recorder_.ExpectEntryMetric( |
| entry, UkmDeveloperEngagementType::kDeveloperEngagementName, |
| 1 << AutofillMetrics::FILLABLE_FORM_PARSED_WITHOUT_TYPE_HINTS); |
| } |
| } |
| |
| void ExpectUniqueCardUploadDecision( |
| const base::HistogramTester& histogram_tester, |
| AutofillMetrics::CardUploadDecisionMetric metric) { |
| histogram_tester.ExpectUniqueSample("Autofill.CardUploadDecisionMetric", |
| ToHistogramSample(metric), 1); |
| } |
| |
| void ExpectCardUploadDecision( |
| const base::HistogramTester& histogram_tester, |
| AutofillMetrics::CardUploadDecisionMetric metric) { |
| histogram_tester.ExpectBucketCount("Autofill.CardUploadDecisionMetric", |
| ToHistogramSample(metric), 1); |
| } |
| |
| void ExpectNoCardUploadDecision( |
| const base::HistogramTester& histogram_tester, |
| AutofillMetrics::CardUploadDecisionMetric metric) { |
| histogram_tester.ExpectBucketCount("Autofill.CardUploadDecisionMetric", |
| ToHistogramSample(metric), 0); |
| } |
| |
| void ExpectCardUploadDecisionUkm(int expected_metric_value) { |
| ExpectMetric(UkmCardUploadDecisionType::kUploadDecisionName, |
| UkmCardUploadDecisionType::kEntryName, expected_metric_value, |
| 1 /* expected_num_matching_entries */); |
| } |
| |
| void ExpectFillableFormParsedUkm(int num_fillable_forms_parsed) { |
| ExpectMetric(UkmDeveloperEngagementType::kDeveloperEngagementName, |
| UkmDeveloperEngagementType::kEntryName, |
| 1 << AutofillMetrics::FILLABLE_FORM_PARSED_WITHOUT_TYPE_HINTS, |
| num_fillable_forms_parsed); |
| } |
| |
| void ExpectMetric(const char* metric_name, |
| const char* entry_name, |
| int expected_metric_value, |
| size_t expected_num_matching_entries) { |
| auto entries = test_ukm_recorder_.GetEntriesByName(entry_name); |
| EXPECT_EQ(expected_num_matching_entries, entries.size()); |
| for (const auto* const entry : entries) { |
| test_ukm_recorder_.ExpectEntryMetric(entry, metric_name, |
| expected_metric_value); |
| } |
| } |
| |
| protected: |
| base::test::ScopedTaskEnvironment scoped_task_environment_; |
| ukm::TestAutoSetUkmRecorder test_ukm_recorder_; |
| MockAutofillClient autofill_client_; |
| std::unique_ptr<TestAutofillDriver> autofill_driver_; |
| std::unique_ptr<TestAutofillManager> autofill_manager_; |
| scoped_refptr<net::TestURLRequestContextGetter> request_context_; |
| TestPersonalDataManager personal_data_; |
| TestSyncService sync_service_; |
| base::test::ScopedFeatureList scoped_feature_list_; |
| // Ends up getting owned (and destroyed) by TestFormDataImporter: |
| TestCreditCardSaveManager* credit_card_save_manager_; |
| // Ends up getting owned (and destroyed) by TestAutofillManager: |
| payments::TestPaymentsClient* payments_client_; |
| |
| private: |
| int ToHistogramSample(AutofillMetrics::CardUploadDecisionMetric metric) { |
| for (int sample = 0; sample < metric + 1; ++sample) |
| if (metric & (1 << sample)) |
| return sample; |
| |
| NOTREACHED(); |
| return 0; |
| } |
| }; |
| |
| // Tests that credit card data are saved for forms on https |
| // TODO(crbug.com/666704): Flaky on android_n5x_swarming_rel bot. |
| #if defined(OS_ANDROID) |
| #define MAYBE_ImportFormDataCreditCardHTTPS \ |
| DISABLED_ImportFormDataCreditCardHTTPS |
| #else |
| #define MAYBE_ImportFormDataCreditCardHTTPS ImportFormDataCreditCardHTTPS |
| #endif |
| TEST_F(CreditCardSaveManagerTest, MAYBE_ImportFormDataCreditCardHTTPS) { |
| TestSaveCreditCards(true); |
| } |
| |
| // Tests that credit card data are saved for forms on http |
| // TODO(crbug.com/666704): Flaky on android_n5x_swarming_rel bot. |
| #if defined(OS_ANDROID) |
| #define MAYBE_ImportFormDataCreditCardHTTP DISABLED_ImportFormDataCreditCardHTTP |
| #else |
| #define MAYBE_ImportFormDataCreditCardHTTP ImportFormDataCreditCardHTTP |
| #endif |
| TEST_F(CreditCardSaveManagerTest, MAYBE_ImportFormDataCreditCardHTTP) { |
| TestSaveCreditCards(false); |
| } |
| |
| // Tests that credit card data are saved when autocomplete=off for CC field. |
| // TODO(crbug.com/666704): Flaky on android_n5x_swarming_rel bot. |
| #if defined(OS_ANDROID) |
| #define MAYBE_CreditCardSavedWhenAutocompleteOff \ |
| DISABLED_CreditCardSavedWhenAutocompleteOff |
| #else |
| #define MAYBE_CreditCardSavedWhenAutocompleteOff \ |
| CreditCardSavedWhenAutocompleteOff |
| #endif |
| TEST_F(CreditCardSaveManagerTest, MAYBE_CreditCardSavedWhenAutocompleteOff) { |
| // Set up our form data. |
| FormData form; |
| CreateTestCreditCardFormData(&form, false, false); |
| |
| // Set "autocomplete=off" for cardnumber field. |
| form.fields[1].should_autocomplete = false; |
| |
| std::vector<FormData> forms(1, form); |
| FormsSeen(forms); |
| |
| // Edit the data, and submit. |
| form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| form.fields[3].value = ASCIIToUTF16(NextYear()); |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)); |
| FormSubmitted(form); |
| } |
| |
| // Tests that credit card data are not saved when CC number does not pass the |
| // Luhn test. |
| TEST_F(CreditCardSaveManagerTest, InvalidCreditCardNumberIsNotSaved) { |
| // Set up our form data. |
| FormData form; |
| CreateTestCreditCardFormData(&form, true, false); |
| std::vector<FormData> forms(1, form); |
| FormsSeen(forms); |
| |
| // Edit the data, and submit. |
| std::string card("4408041234567890"); |
| ASSERT_FALSE(autofill::IsValidCreditCardNumber(ASCIIToUTF16(card))); |
| form.fields[1].value = ASCIIToUTF16(card); |
| form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| form.fields[3].value = ASCIIToUTF16(NextYear()); |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(form); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, CreditCardDisabledDoesNotSave) { |
| personal_data_.ClearProfiles(); |
| autofill_manager_->SetCreditCardEnabled(false); |
| |
| // Create, fill and submit an address form in order to establish a recent |
| // profile which can be selected for the upload request. |
| FormData address_form; |
| test::CreateTestAddressFormData(&address_form); |
| FormsSeen(std::vector<FormData>(1, address_form)); |
| ManuallyFillAddressForm("Flo", "Master", "77401", "US", &address_form); |
| FormSubmitted(address_form); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| base::HistogramTester histogram_tester; |
| |
| // The credit card should neither be saved locally or uploaded. |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_FALSE(credit_card_save_manager_->CreditCardWasUploaded()); |
| |
| // Verify that no histogram entry was logged. |
| histogram_tester.ExpectTotalCount("Autofill.CardUploadDecisionMetric", 0); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, UploadCreditCard_FullAddresses) { |
| scoped_feature_list_.InitAndDisableFeature( |
| features::kAutofillSendOnlyCountryInGetUploadDetails); |
| personal_data_.ClearCreditCards(); |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Create, fill and submit an address form in order to establish a recent |
| // profile which can be selected for the upload request. |
| FormData address_form; |
| test::CreateTestAddressFormData(&address_form); |
| FormsSeen(std::vector<FormData>(1, address_form)); |
| ExpectUniqueFillableFormParsedUkm(); |
| |
| ManuallyFillAddressForm("Flo", "Master", "77401", "US", &address_form); |
| FormSubmitted(address_form); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| ExpectFillableFormParsedUkm(2 /* num_fillable_forms_parsed */); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| base::HistogramTester histogram_tester; |
| |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| EXPECT_THAT( |
| payments_client_->active_experiments_in_request(), |
| UnorderedElementsAre(kAutofillUpstreamUpdatePromptExplanation.name)); |
| |
| // Verify that one profile was saved, and it was included in the upload |
| // details request to payments. |
| EXPECT_EQ(1U, personal_data_.GetProfiles().size()); |
| EXPECT_THAT( |
| payments_client_->addresses_in_upload_details(), |
| testing::UnorderedElementsAreArray({*personal_data_.GetProfiles()[0]})); |
| |
| // Server did not send a server_id, expect copy of card is not stored. |
| EXPECT_TRUE(personal_data_.GetCreditCards().empty()); |
| |
| // Verify that the correct histogram entry (and only that) was logged. |
| ExpectUniqueCardUploadDecision(histogram_tester, |
| AutofillMetrics::UPLOAD_OFFERED); |
| // Verify that the correct UKM was logged. |
| ExpectCardUploadDecisionUkm(AutofillMetrics::UPLOAD_OFFERED); |
| // Verify the histogram entry for recent profile modification. |
| histogram_tester.ExpectUniqueSample( |
| "Autofill.HasModifiedProfile.CreditCardFormSubmission", true, 1); |
| // Verify that UMA for "DaysSincePreviousUse" was not logged because we |
| // modified the profile. |
| histogram_tester.ExpectTotalCount( |
| "Autofill.DaysSincePreviousUseAtSubmission.Profile", 0); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, UploadCreditCard_OnlyCountryInAddresses) { |
| // When this feature is enabled, the addresses being sent in the upload |
| // details request will only contain the country. |
| scoped_feature_list_.InitAndEnableFeature( |
| features::kAutofillSendOnlyCountryInGetUploadDetails); |
| personal_data_.ClearCreditCards(); |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Create, fill and submit an address form in order to establish a recent |
| // profile which can be selected for the upload request. |
| FormData address_form; |
| test::CreateTestAddressFormData(&address_form); |
| FormsSeen(std::vector<FormData>(1, address_form)); |
| ExpectUniqueFillableFormParsedUkm(); |
| |
| ManuallyFillAddressForm("Flo", "Master", "77401", "US", &address_form); |
| FormSubmitted(address_form); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| ExpectFillableFormParsedUkm(2 /* num_fillable_forms_parsed */); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| base::HistogramTester histogram_tester; |
| |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| EXPECT_THAT( |
| payments_client_->active_experiments_in_request(), |
| UnorderedElementsAre(kAutofillUpstreamUpdatePromptExplanation.name)); |
| |
| // Verify that even though the full address profile was saved, only the |
| // country was included in the upload details request to payments. |
| EXPECT_EQ(1U, personal_data_.GetProfiles().size()); |
| AutofillProfile only_country; |
| only_country.SetInfo(ADDRESS_HOME_COUNTRY, ASCIIToUTF16("US"), "en-US"); |
| EXPECT_EQ(1U, payments_client_->addresses_in_upload_details().size()); |
| // AutofillProfile::Compare will ignore the difference in guid between our |
| // actual profile being sent and the expected one constructed here. |
| EXPECT_EQ(0, payments_client_->addresses_in_upload_details()[0].Compare( |
| only_country)); |
| |
| // Server did not send a server_id, expect copy of card is not stored. |
| EXPECT_TRUE(personal_data_.GetCreditCards().empty()); |
| |
| // Verify that the correct histogram entry (and only that) was logged. |
| ExpectUniqueCardUploadDecision(histogram_tester, |
| AutofillMetrics::UPLOAD_OFFERED); |
| // Verify that the correct UKM was logged. |
| ExpectCardUploadDecisionUkm(AutofillMetrics::UPLOAD_OFFERED); |
| // Verify the histogram entry for recent profile modification. |
| histogram_tester.ExpectUniqueSample( |
| "Autofill.HasModifiedProfile.CreditCardFormSubmission", true, 1); |
| // Verify that UMA for "DaysSincePreviousUse" was not logged because we |
| // modified the profile. |
| histogram_tester.ExpectTotalCount( |
| "Autofill.DaysSincePreviousUseAtSubmission.Profile", 0); |
| } |
| |
| // Tests that a credit card inferred from a form with a credit card first and |
| // last name can be uploaded. |
| TEST_F(CreditCardSaveManagerTest, UploadCreditCard_FirstAndLastName) { |
| personal_data_.ClearCreditCards(); |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Create, fill and submit an address form in order to establish a recent |
| // profile which can be selected for the upload request. |
| FormData address_form; |
| test::CreateTestAddressFormData(&address_form); |
| FormsSeen(std::vector<FormData>(1, address_form)); |
| ExpectUniqueFillableFormParsedUkm(); |
| |
| ManuallyFillAddressForm("Flo", "Master", "77401", "US", &address_form); |
| FormSubmitted(address_form); |
| |
| // Set up our credit card form data with credit card first and last name |
| // fields. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, /*is_https=*/true, |
| /*use_month_type=*/false, /*split_names=*/true); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("Flo"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("Master"); |
| credit_card_form.fields[2].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[4].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[5].value = ASCIIToUTF16("123"); |
| |
| base::HistogramTester histogram_tester; |
| |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| EXPECT_THAT( |
| payments_client_->active_experiments_in_request(), |
| UnorderedElementsAre(kAutofillUpstreamUpdatePromptExplanation.name)); |
| |
| // Server did not send a server_id, expect copy of card is not stored. |
| EXPECT_TRUE(personal_data_.GetCreditCards().empty()); |
| // Verify that the correct histogram entry (and only that) was logged. |
| ExpectUniqueCardUploadDecision(histogram_tester, |
| AutofillMetrics::UPLOAD_OFFERED); |
| // Verify that the correct UKM was logged. |
| ExpectCardUploadDecisionUkm(AutofillMetrics::UPLOAD_OFFERED); |
| // Verify the histogram entry for recent profile modification. |
| histogram_tester.ExpectUniqueSample( |
| "Autofill.HasModifiedProfile.CreditCardFormSubmission", true, 1); |
| // Verify that UMA for "DaysSincePreviousUse" was not logged because we |
| // modified the profile. |
| histogram_tester.ExpectTotalCount( |
| "Autofill.DaysSincePreviousUseAtSubmission.Profile", 0); |
| histogram_tester.ExpectTotalCount( |
| "Autofill.SaveCardWithFirstAndLastNameOffered.Local", 0); |
| histogram_tester.ExpectTotalCount( |
| "Autofill.SaveCardWithFirstAndLastNameOffered.Server", 1); |
| histogram_tester.ExpectTotalCount( |
| "Autofill.SaveCardWithFirstAndLastNameComplete.Server", 1); |
| } |
| |
| // Tests that a credit card inferred from a form with a credit card first and |
| // last name can be uploaded when the last name comes before first name on the |
| // form. |
| TEST_F(CreditCardSaveManagerTest, UploadCreditCard_LastAndFirstName) { |
| personal_data_.ClearCreditCards(); |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Create, fill and submit an address form in order to establish a recent |
| // profile which can be selected for the upload request. |
| FormData address_form; |
| test::CreateTestAddressFormData(&address_form); |
| FormsSeen(std::vector<FormData>(1, address_form)); |
| ExpectUniqueFillableFormParsedUkm(); |
| |
| ManuallyFillAddressForm("Flo", "Master", "77401", "US", &address_form); |
| FormSubmitted(address_form); |
| |
| // Set up our credit card form data with credit card first and last name |
| // fields. |
| FormData credit_card_form; |
| credit_card_form.name = ASCIIToUTF16("MyForm"); |
| credit_card_form.origin = GURL("https://myform.com/form.html"); |
| credit_card_form.action = GURL("https://myform.com/submit.html"); |
| credit_card_form.main_frame_origin = |
| url::Origin::Create(GURL("https://myform_root.com/form.html")); |
| |
| FormFieldData field; |
| test::CreateTestFormField("Last Name on Card", "lastnameoncard", "", "text", |
| &field); |
| field.autocomplete_attribute = "cc-family-name"; |
| credit_card_form.fields.push_back(field); |
| test::CreateTestFormField("First Name on Card", "firstnameoncard", "", "text", |
| &field); |
| field.autocomplete_attribute = "cc-given-name"; |
| credit_card_form.fields.push_back(field); |
| field.autocomplete_attribute = ""; |
| test::CreateTestFormField("Card Number", "cardnumber", "", "text", &field); |
| credit_card_form.fields.push_back(field); |
| test::CreateTestFormField("Expiration Date", "ccmonth", "", "text", &field); |
| credit_card_form.fields.push_back(field); |
| test::CreateTestFormField("", "ccyear", "", "text", &field); |
| credit_card_form.fields.push_back(field); |
| test::CreateTestFormField("CVC", "cvc", "", "text", &field); |
| credit_card_form.fields.push_back(field); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("Master"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("Flo"); |
| credit_card_form.fields[2].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[4].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[5].value = ASCIIToUTF16("123"); |
| |
| base::HistogramTester histogram_tester; |
| |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| EXPECT_THAT( |
| payments_client_->active_experiments_in_request(), |
| UnorderedElementsAre(kAutofillUpstreamUpdatePromptExplanation.name)); |
| |
| // Server did not send a server_id, expect copy of card is not stored. |
| EXPECT_TRUE(personal_data_.GetCreditCards().empty()); |
| // Verify that the correct histogram entry (and only that) was logged. |
| ExpectUniqueCardUploadDecision(histogram_tester, |
| AutofillMetrics::UPLOAD_OFFERED); |
| // Verify that the correct UKM was logged. |
| ExpectCardUploadDecisionUkm(AutofillMetrics::UPLOAD_OFFERED); |
| // Verify the histogram entry for recent profile modification. |
| histogram_tester.ExpectUniqueSample( |
| "Autofill.HasModifiedProfile.CreditCardFormSubmission", true, 1); |
| // Verify that UMA for "DaysSincePreviousUse" was not logged because we |
| // modified the profile. |
| histogram_tester.ExpectTotalCount( |
| "Autofill.DaysSincePreviousUseAtSubmission.Profile", 0); |
| histogram_tester.ExpectTotalCount( |
| "Autofill.SaveCardWithFirstAndLastNameOffered.Local", 0); |
| histogram_tester.ExpectTotalCount( |
| "Autofill.SaveCardWithFirstAndLastNameOffered.Server", 1); |
| histogram_tester.ExpectTotalCount( |
| "Autofill.SaveCardWithFirstAndLastNameComplete.Server", 1); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, UploadCreditCardAndSaveCopy) { |
| personal_data_.ClearCreditCards(); |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| const char* const server_id = "InstrumentData:1234"; |
| payments_client_->SetServerIdForCardUpload(server_id); |
| |
| // Create, fill and submit an address form in order to establish a recent |
| // profile which can be selected for the upload request. |
| FormData address_form; |
| test::CreateTestAddressFormData(&address_form); |
| FormsSeen(std::vector<FormData>(1, address_form)); |
| |
| ManuallyFillAddressForm("Flo", "Master", "77401", "US", &address_form); |
| FormSubmitted(address_form); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| const char* const card_number = "4111111111111111"; |
| credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); |
| credit_card_form.fields[1].value = ASCIIToUTF16(card_number); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| FormSubmitted(credit_card_form); |
| |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| EXPECT_TRUE(personal_data_.GetLocalCreditCards().empty()); |
| #if defined(OS_LINUX) && !defined(OS_CHROMEOS) |
| // See |OfferStoreUnmaskedCards| |
| EXPECT_TRUE(personal_data_.GetCreditCards().empty()); |
| #else |
| ASSERT_EQ(1U, personal_data_.GetCreditCards().size()); |
| const CreditCard* const saved_card = personal_data_.GetCreditCards()[0]; |
| EXPECT_EQ(CreditCard::OK, saved_card->GetServerStatus()); |
| EXPECT_EQ(base::ASCIIToUTF16("1111"), saved_card->LastFourDigits()); |
| EXPECT_EQ(kVisaCard, saved_card->network()); |
| EXPECT_EQ(std::stoi(NextMonth()), saved_card->expiration_month()); |
| EXPECT_EQ(std::stoi(NextYear()), saved_card->expiration_year()); |
| EXPECT_EQ(server_id, saved_card->server_id()); |
| EXPECT_EQ(CreditCard::FULL_SERVER_CARD, saved_card->record_type()); |
| EXPECT_EQ(base::ASCIIToUTF16(card_number), saved_card->number()); |
| #endif |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, UploadCreditCard_FeatureNotEnabled) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(false); |
| |
| // Create, fill and submit an address form in order to establish a recent |
| // profile which can be selected for the upload request. |
| FormData address_form; |
| test::CreateTestAddressFormData(&address_form); |
| FormsSeen(std::vector<FormData>(1, address_form)); |
| ManuallyFillAddressForm("Flo", "Master", "77401", "US", &address_form); |
| FormSubmitted(address_form); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| base::HistogramTester histogram_tester; |
| |
| // The save prompt should be shown instead of doing an upload. |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)); |
| FormSubmitted(credit_card_form); |
| EXPECT_FALSE(credit_card_save_manager_->CreditCardWasUploaded()); |
| |
| // Verify that no histogram entry was logged. |
| histogram_tester.ExpectTotalCount("Autofill.CardUploadDecisionMetric", 0); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, UploadCreditCard_CvcUnavailable) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Create, fill and submit an address form in order to establish a recent |
| // profile which can be selected for the upload request. |
| FormData address_form; |
| test::CreateTestAddressFormData(&address_form); |
| FormsSeen(std::vector<FormData>(1, address_form)); |
| ExpectUniqueFillableFormParsedUkm(); |
| |
| ManuallyFillAddressForm("Flo", "Master", "77401", "US", &address_form); |
| FormSubmitted(address_form); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| ExpectFillableFormParsedUkm(2 /* num_fillable_forms_parsed */); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16(""); // CVC MISSING |
| |
| base::HistogramTester histogram_tester; |
| |
| // With the offer-to-save decision deferred to Google Payments, Payments can |
| // still decide to allow saving despite the missing CVC value. |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| |
| // Verify that the correct histogram entries were logged. |
| ExpectCardUploadDecision(histogram_tester, AutofillMetrics::UPLOAD_OFFERED); |
| ExpectCardUploadDecision(histogram_tester, |
| AutofillMetrics::CVC_VALUE_NOT_FOUND); |
| // Verify that the correct UKM was logged. |
| ExpectCardUploadDecisionUkm(AutofillMetrics::UPLOAD_OFFERED | |
| AutofillMetrics::CVC_VALUE_NOT_FOUND); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, UploadCreditCard_CvcInvalidLength) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Create, fill and submit an address form in order to establish a recent |
| // profile which can be selected for the upload request. |
| FormData address_form; |
| test::CreateTestAddressFormData(&address_form); |
| FormsSeen(std::vector<FormData>(1, address_form)); |
| ManuallyFillAddressForm("Flo", "Master", "77401", "US", &address_form); |
| FormSubmitted(address_form); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("1234"); |
| |
| base::HistogramTester histogram_tester; |
| |
| // With the offer-to-save decision deferred to Google Payments, Payments can |
| // still decide to allow saving despite the invalid CVC value. |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| |
| // Verify that the correct histogram entries were logged. |
| ExpectCardUploadDecision(histogram_tester, AutofillMetrics::UPLOAD_OFFERED); |
| ExpectCardUploadDecision(histogram_tester, |
| AutofillMetrics::INVALID_CVC_VALUE); |
| // Verify that the correct UKM was logged. |
| ExpectCardUploadDecisionUkm(AutofillMetrics::UPLOAD_OFFERED | |
| AutofillMetrics::INVALID_CVC_VALUE); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, UploadCreditCard_MultipleCvcFields) { |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Remove the profiles that were created in the TestPersonalDataManager |
| // constructor because they would result in conflicting names that would |
| // prevent the upload. |
| personal_data_.ClearProfiles(); |
| |
| // Create, fill and submit an address form in order to establish a recent |
| // profile which can be selected for the upload request. |
| FormData address_form; |
| test::CreateTestAddressFormData(&address_form); |
| FormsSeen(std::vector<FormData>(1, address_form)); |
| ManuallyFillAddressForm("Flo", "Master", "77401", "US", &address_form); |
| FormSubmitted(address_form); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| credit_card_form.name = ASCIIToUTF16("MyForm"); |
| credit_card_form.origin = GURL("https://myform.com/form.html"); |
| credit_card_form.action = GURL("https://myform.com/submit.html"); |
| credit_card_form.main_frame_origin = |
| url::Origin::Create(GURL("http://myform_root.com/form.html")); |
| |
| FormFieldData field; |
| test::CreateTestFormField("Card Name", "cardname", "", "text", &field); |
| credit_card_form.fields.push_back(field); |
| test::CreateTestFormField("Card Number", "cardnumber", "", "text", &field); |
| credit_card_form.fields.push_back(field); |
| test::CreateTestFormField("Expiration Month", "ccmonth", "", "text", &field); |
| credit_card_form.fields.push_back(field); |
| test::CreateTestFormField("Expiration Year", "ccyear", "", "text", &field); |
| credit_card_form.fields.push_back(field); |
| test::CreateTestFormField("CVC (hidden)", "cvc1", "", "text", &field); |
| credit_card_form.fields.push_back(field); |
| test::CreateTestFormField("CVC", "cvc2", "", "text", &field); |
| credit_card_form.fields.push_back(field); |
| |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16(""); // CVC MISSING |
| credit_card_form.fields[5].value = ASCIIToUTF16("123"); |
| |
| base::HistogramTester histogram_tester; |
| |
| // A CVC value appeared in one of the two CVC fields, upload should happen. |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| |
| // Verify that the correct histogram entry (and only that) was logged. |
| ExpectUniqueCardUploadDecision(histogram_tester, |
| AutofillMetrics::UPLOAD_OFFERED); |
| // Verify that the correct UKM was logged. |
| ExpectCardUploadDecisionUkm(AutofillMetrics::UPLOAD_OFFERED); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, UploadCreditCard_NoCvcFieldOnForm) { |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Remove the profiles that were created in the TestPersonalDataManager |
| // constructor because they would result in conflicting names that would |
| // prevent the upload. |
| personal_data_.ClearProfiles(); |
| |
| // Create, fill and submit an address form in order to establish a recent |
| // profile which can be selected for the upload request. |
| FormData address_form; |
| test::CreateTestAddressFormData(&address_form); |
| FormsSeen(std::vector<FormData>(1, address_form)); |
| ManuallyFillAddressForm("Flo", "Master", "77401", "US", &address_form); |
| FormSubmitted(address_form); |
| |
| // Set up our credit card form data. Note that CVC field is missing. |
| FormData credit_card_form; |
| credit_card_form.name = ASCIIToUTF16("MyForm"); |
| credit_card_form.origin = GURL("https://myform.com/form.html"); |
| credit_card_form.action = GURL("https://myform.com/submit.html"); |
| credit_card_form.main_frame_origin = |
| url::Origin::Create(GURL("http://myform_root.com/form.html")); |
| |
| FormFieldData field; |
| test::CreateTestFormField("Card Name", "cardname", "", "text", &field); |
| credit_card_form.fields.push_back(field); |
| test::CreateTestFormField("Card Number", "cardnumber", "", "text", &field); |
| credit_card_form.fields.push_back(field); |
| test::CreateTestFormField("Expiration Month", "ccmonth", "", "text", &field); |
| credit_card_form.fields.push_back(field); |
| test::CreateTestFormField("Expiration Year", "ccyear", "", "text", &field); |
| credit_card_form.fields.push_back(field); |
| |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| |
| base::HistogramTester histogram_tester; |
| |
| // With the offer-to-save decision deferred to Google Payments, Payments can |
| // still decide to allow saving despite the missing CVC value. |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| |
| // Verify that the correct histogram entries were logged. |
| ExpectCardUploadDecision(histogram_tester, AutofillMetrics::UPLOAD_OFFERED); |
| ExpectCardUploadDecision(histogram_tester, |
| AutofillMetrics::CVC_FIELD_NOT_FOUND); |
| // Verify that the correct UKM was logged. |
| ExpectCardUploadDecisionUkm(AutofillMetrics::UPLOAD_OFFERED | |
| AutofillMetrics::CVC_FIELD_NOT_FOUND); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, |
| UploadCreditCard_NoCvcFieldOnForm_InvalidCvcInNonCvcField) { |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Remove the profiles that were created in the TestPersonalDataManager |
| // constructor because they would result in conflicting names that would |
| // prevent the upload. |
| personal_data_.ClearProfiles(); |
| |
| // Create, fill and submit an address form in order to establish a recent |
| // profile which can be selected for the upload request. |
| FormData address_form; |
| test::CreateTestAddressFormData(&address_form); |
| FormsSeen({address_form}); |
| ManuallyFillAddressForm("Flo", "Master", "77401", "US", &address_form); |
| FormSubmitted(address_form); |
| |
| // Set up our credit card form data. Note that CVC field is missing. |
| FormData credit_card_form; |
| credit_card_form.name = ASCIIToUTF16("MyForm"); |
| credit_card_form.origin = GURL("https://myform.com/form.html"); |
| credit_card_form.action = GURL("https://myform.com/submit.html"); |
| credit_card_form.main_frame_origin = |
| url::Origin::Create(GURL("http://myform_root.com/form.html")); |
| |
| FormFieldData field; |
| test::CreateTestFormField("Card Name", "cardname", "", "text", &field); |
| credit_card_form.fields.push_back(field); |
| test::CreateTestFormField("Card Number", "cardnumber", "", "text", &field); |
| credit_card_form.fields.push_back(field); |
| test::CreateTestFormField("Expiration Month", "ccmonth", "", "text", &field); |
| credit_card_form.fields.push_back(field); |
| test::CreateTestFormField("Expiration Year", "ccyear", "", "text", &field); |
| credit_card_form.fields.push_back(field); |
| test::CreateTestFormField("Random Field", "random", "", "text", &field); |
| credit_card_form.fields.push_back(field); |
| |
| FormsSeen({credit_card_form}); |
| |
| // Enter an invalid cvc in "Random Field" and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("1234"); |
| |
| base::HistogramTester histogram_tester; |
| |
| // With the offer-to-save decision deferred to Google Payments, Payments can |
| // still decide to allow saving despite the invalid CVC value. |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| |
| // Verify that the correct histogram entries were logged. |
| ExpectCardUploadDecision(histogram_tester, AutofillMetrics::UPLOAD_OFFERED); |
| ExpectCardUploadDecision(histogram_tester, |
| AutofillMetrics::CVC_FIELD_NOT_FOUND); |
| // Verify that the correct UKM was logged. |
| ExpectCardUploadDecisionUkm(AutofillMetrics::UPLOAD_OFFERED | |
| AutofillMetrics::CVC_FIELD_NOT_FOUND); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, |
| UploadCreditCard_NoCvcFieldOnForm_CvcInNonCvcField) { |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Remove the profiles that were created in the TestPersonalDataManager |
| // constructor because they would result in conflicting names that would |
| // prevent the upload. |
| personal_data_.ClearProfiles(); |
| |
| // Create, fill and submit an address form in order to establish a recent |
| // profile which can be selected for the upload request. |
| FormData address_form; |
| test::CreateTestAddressFormData(&address_form); |
| FormsSeen({address_form}); |
| ManuallyFillAddressForm("Flo", "Master", "77401", "US", &address_form); |
| FormSubmitted(address_form); |
| |
| // Set up our credit card form data. Note that CVC field is missing. |
| FormData credit_card_form; |
| credit_card_form.name = ASCIIToUTF16("MyForm"); |
| credit_card_form.origin = GURL("https://myform.com/form.html"); |
| credit_card_form.action = GURL("https://myform.com/submit.html"); |
| credit_card_form.main_frame_origin = |
| url::Origin::Create(GURL("http://myform_root.com/form.html")); |
| |
| FormFieldData field; |
| test::CreateTestFormField("Card Name", "cardname", "", "text", &field); |
| credit_card_form.fields.push_back(field); |
| test::CreateTestFormField("Card Number", "cardnumber", "", "text", &field); |
| credit_card_form.fields.push_back(field); |
| test::CreateTestFormField("Expiration Month", "ccmonth", "", "text", &field); |
| credit_card_form.fields.push_back(field); |
| test::CreateTestFormField("Expiration Year", "ccyear", "", "text", &field); |
| credit_card_form.fields.push_back(field); |
| test::CreateTestFormField("Random Field", "random", "", "text", &field); |
| credit_card_form.fields.push_back(field); |
| |
| FormsSeen({credit_card_form}); |
| |
| // Enter a valid cvc in "Random Field" and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| base::HistogramTester histogram_tester; |
| |
| // With the offer-to-save decision deferred to Google Payments, Payments can |
| // still decide to allow saving despite the missing CVC value. |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| |
| // Verify that the correct histogram entries were logged. |
| ExpectCardUploadDecision(histogram_tester, AutofillMetrics::UPLOAD_OFFERED); |
| ExpectCardUploadDecision( |
| histogram_tester, |
| AutofillMetrics::FOUND_POSSIBLE_CVC_VALUE_IN_NON_CVC_FIELD); |
| // Verify that the correct UKM was logged. |
| ExpectCardUploadDecisionUkm( |
| AutofillMetrics::UPLOAD_OFFERED | |
| AutofillMetrics::FOUND_POSSIBLE_CVC_VALUE_IN_NON_CVC_FIELD); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, |
| UploadCreditCard_NoCvcFieldOnForm_CvcInAddressField) { |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Remove the profiles that were created in the TestPersonalDataManager |
| // constructor because they would result in conflicting names that would |
| // prevent the upload. |
| personal_data_.ClearProfiles(); |
| |
| // Create, fill and submit an address form in order to establish a recent |
| // profile which can be selected for the upload request. |
| FormData address_form; |
| test::CreateTestAddressFormData(&address_form); |
| FormsSeen({address_form}); |
| ManuallyFillAddressForm("Flo", "Master", "77401", "US", &address_form); |
| FormSubmitted(address_form); |
| |
| // Set up our credit card form data. Note that CVC field is missing. |
| FormData credit_card_form; |
| credit_card_form.name = ASCIIToUTF16("MyForm"); |
| credit_card_form.origin = GURL("https://myform.com/form.html"); |
| credit_card_form.action = GURL("https://myform.com/submit.html"); |
| credit_card_form.main_frame_origin = |
| url::Origin::Create(GURL("http://myform_root.com/form.html")); |
| |
| FormFieldData field; |
| test::CreateTestFormField("Card Name", "cardname", "", "text", &field); |
| credit_card_form.fields.push_back(field); |
| test::CreateTestFormField("Card Number", "cardnumber", "", "text", &field); |
| credit_card_form.fields.push_back(field); |
| test::CreateTestFormField("Expiration Month", "ccmonth", "", "text", &field); |
| credit_card_form.fields.push_back(field); |
| test::CreateTestFormField("Expiration Year", "ccyear", "", "text", &field); |
| credit_card_form.fields.push_back(field); |
| test::CreateTestFormField("Address Line 1", "addr1", "", "text", &field); |
| credit_card_form.fields.push_back(field); |
| |
| FormsSeen({credit_card_form}); |
| |
| // Enter a valid cvc in "Random Field" and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| base::HistogramTester histogram_tester; |
| |
| // With the offer-to-save decision deferred to Google Payments, Payments can |
| // still decide to allow saving despite the missing CVC value. |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| |
| // Verify that the correct histogram entries were logged. |
| ExpectCardUploadDecision(histogram_tester, AutofillMetrics::UPLOAD_OFFERED); |
| ExpectCardUploadDecision(histogram_tester, |
| AutofillMetrics::CVC_FIELD_NOT_FOUND); |
| // Verify that the correct UKM was logged. |
| ExpectCardUploadDecisionUkm(AutofillMetrics::UPLOAD_OFFERED | |
| AutofillMetrics::CVC_FIELD_NOT_FOUND); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, UploadCreditCard_NoProfileAvailable) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Don't fill or submit an address form. |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("Bob Master"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| base::HistogramTester histogram_tester; |
| |
| // With the offer-to-save decision deferred to Google Payments, Payments can |
| // still decide to allow saving despite the missing name/address. |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| |
| // Verify that the correct histogram entries were logged. |
| ExpectCardUploadDecision(histogram_tester, AutofillMetrics::UPLOAD_OFFERED); |
| ExpectCardUploadDecision( |
| histogram_tester, AutofillMetrics::UPLOAD_NOT_OFFERED_NO_ADDRESS_PROFILE); |
| // Verify that the correct UKM was logged. |
| ExpectCardUploadDecisionUkm( |
| AutofillMetrics::UPLOAD_OFFERED | |
| AutofillMetrics::UPLOAD_NOT_OFFERED_NO_ADDRESS_PROFILE); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, UploadCreditCard_NoRecentlyUsedProfile) { |
| // Create the test clock and set the time to a specific value. |
| TestAutofillClock test_clock; |
| test_clock.SetNow(kArbitraryTime); |
| |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Create, fill and submit an address form in order to establish a profile. |
| FormData address_form; |
| test::CreateTestAddressFormData(&address_form); |
| FormsSeen({address_form}); |
| |
| ManuallyFillAddressForm("Flo", "Master", "77401", "US", &address_form); |
| FormSubmitted(address_form); |
| |
| // Set the current time to another value. |
| test_clock.SetNow(kMuchLaterTime); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| base::HistogramTester histogram_tester; |
| |
| // With the offer-to-save decision deferred to Google Payments, Payments can |
| // still decide to allow saving despite the missing name/address. |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| |
| // Verify that the correct histogram entries were logged. |
| ExpectCardUploadDecision(histogram_tester, AutofillMetrics::UPLOAD_OFFERED); |
| ExpectCardUploadDecision( |
| histogram_tester, |
| AutofillMetrics::UPLOAD_NOT_OFFERED_NO_RECENTLY_USED_ADDRESS); |
| // Verify that the correct UKM was logged. |
| ExpectCardUploadDecisionUkm( |
| AutofillMetrics::UPLOAD_OFFERED | |
| AutofillMetrics::UPLOAD_NOT_OFFERED_NO_RECENTLY_USED_ADDRESS); |
| // Verify the histogram entry for recent profile modification. |
| histogram_tester.ExpectUniqueSample( |
| "Autofill.HasModifiedProfile.CreditCardFormSubmission", false, 1); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, |
| UploadCreditCard_CvcUnavailableAndNoProfileAvailable) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Don't fill or submit an address form. |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16(""); // CVC MISSING |
| |
| base::HistogramTester histogram_tester; |
| |
| // With the offer-to-save decision deferred to Google Payments, Payments can |
| // still decide to allow saving despite the missing CVC, name, and address. |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| |
| // Verify that the correct histogram entries were logged. |
| ExpectCardUploadDecision(histogram_tester, AutofillMetrics::UPLOAD_OFFERED); |
| ExpectCardUploadDecision(histogram_tester, |
| AutofillMetrics::CVC_VALUE_NOT_FOUND); |
| ExpectCardUploadDecision( |
| histogram_tester, AutofillMetrics::UPLOAD_NOT_OFFERED_NO_ADDRESS_PROFILE); |
| // Verify that the correct UKM was logged. |
| ExpectCardUploadDecisionUkm( |
| AutofillMetrics::UPLOAD_OFFERED | AutofillMetrics::CVC_VALUE_NOT_FOUND | |
| AutofillMetrics::UPLOAD_NOT_OFFERED_NO_ADDRESS_PROFILE); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, UploadCreditCard_NoNameAvailable) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Create, fill and submit an address form in order to establish a recent |
| // profile which can be selected for the upload request. |
| FormData address_form; |
| test::CreateTestAddressFormData(&address_form); |
| FormsSeen(std::vector<FormData>(1, address_form)); |
| // But omit the name: |
| ManuallyFillAddressForm("", "", "77401", "US", &address_form); |
| FormSubmitted(address_form); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, but don't include a name, and submit. |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| base::HistogramTester histogram_tester; |
| |
| // With the offer-to-save decision deferred to Google Payments, Payments can |
| // still decide to allow saving despite the missing name. |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| |
| // Verify that the correct histogram entries were logged. |
| ExpectCardUploadDecision(histogram_tester, AutofillMetrics::UPLOAD_OFFERED); |
| ExpectCardUploadDecision(histogram_tester, |
| AutofillMetrics::UPLOAD_NOT_OFFERED_NO_NAME); |
| // Verify that the correct UKM was logged. |
| ExpectCardUploadDecisionUkm(AutofillMetrics::UPLOAD_OFFERED | |
| AutofillMetrics::UPLOAD_NOT_OFFERED_NO_NAME); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, |
| UploadCreditCard_NoNameAvailableAndNoProfileAvailable) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Don't fill or submit an address form. |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, but don't include a name, and submit. |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| base::HistogramTester histogram_tester; |
| |
| // With the offer-to-save decision deferred to Google Payments, Payments can |
| // still decide to allow saving despite the missing names/address. |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| |
| // Verify that the correct histogram entries were logged. |
| ExpectCardUploadDecision(histogram_tester, AutofillMetrics::UPLOAD_OFFERED); |
| ExpectCardUploadDecision( |
| histogram_tester, AutofillMetrics::UPLOAD_NOT_OFFERED_NO_ADDRESS_PROFILE); |
| ExpectCardUploadDecision(histogram_tester, |
| AutofillMetrics::UPLOAD_NOT_OFFERED_NO_NAME); |
| // Verify that the correct UKM was logged. |
| ExpectCardUploadDecisionUkm( |
| AutofillMetrics::UPLOAD_OFFERED | |
| AutofillMetrics::UPLOAD_NOT_OFFERED_NO_ADDRESS_PROFILE | |
| AutofillMetrics::UPLOAD_NOT_OFFERED_NO_NAME); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, UploadCreditCard_ZipCodesConflict) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Create, fill and submit two address forms with different zip codes. |
| FormData address_form1, address_form2; |
| test::CreateTestAddressFormData(&address_form1); |
| test::CreateTestAddressFormData(&address_form2); |
| |
| std::vector<FormData> address_forms; |
| address_forms.push_back(address_form1); |
| address_forms.push_back(address_form2); |
| FormsSeen(address_forms); |
| ExpectFillableFormParsedUkm(2 /* num_fillable_forms_parsed */); |
| |
| ManuallyFillAddressForm("Flo", "Master", "77401-8294", "US", &address_form1); |
| FormSubmitted(address_form1); |
| |
| ManuallyFillAddressForm("Flo", "Master", "77401-1234", "US", &address_form2); |
| FormSubmitted(address_form2); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| ExpectFillableFormParsedUkm(3 /* num_fillable_forms_parsed */); |
| |
| // Edit the data and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| base::HistogramTester histogram_tester; |
| |
| // With the offer-to-save decision deferred to Google Payments, Payments can |
| // still decide to allow saving despite the conflicting zip codes. |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| |
| // Verify that the correct histogram entries were logged. |
| ExpectCardUploadDecision(histogram_tester, AutofillMetrics::UPLOAD_OFFERED); |
| ExpectCardUploadDecision( |
| histogram_tester, AutofillMetrics::UPLOAD_NOT_OFFERED_CONFLICTING_ZIPS); |
| // Verify that the correct UKM was logged. |
| ExpectCardUploadDecisionUkm( |
| AutofillMetrics::UPLOAD_OFFERED | |
| AutofillMetrics::UPLOAD_NOT_OFFERED_CONFLICTING_ZIPS); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, |
| UploadCreditCard_ZipCodesDoNotDiscardWhitespace) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Create two separate profiles with different zip codes. Must directly add |
| // instead of submitting a form, because they're deduped on form submit. |
| AutofillProfile profile1; |
| profile1.set_guid("00000000-0000-0000-0000-000000000001"); |
| profile1.SetInfo(NAME_FULL, ASCIIToUTF16("Flo Master"), "en-US"); |
| profile1.SetInfo(ADDRESS_HOME_ZIP, ASCIIToUTF16("H3B2Y5"), "en-US"); |
| profile1.SetInfo(ADDRESS_HOME_COUNTRY, ASCIIToUTF16("CA"), "en-US"); |
| personal_data_.AddProfile(profile1); |
| |
| AutofillProfile profile2; |
| profile2.set_guid("00000000-0000-0000-0000-000000000002"); |
| profile2.SetInfo(NAME_FULL, ASCIIToUTF16("Flo Master"), "en-US"); |
| profile2.SetInfo(ADDRESS_HOME_ZIP, ASCIIToUTF16("h3b 2y5"), "en-US"); |
| profile2.SetInfo(ADDRESS_HOME_COUNTRY, ASCIIToUTF16("CA"), "en-US"); |
| personal_data_.AddProfile(profile2); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen({credit_card_form}); |
| |
| // Edit the data and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| base::HistogramTester histogram_tester; |
| |
| // With the offer-to-save decision deferred to Google Payments, Payments can |
| // still decide to allow saving despite the conflicting zip codes. |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| |
| // Verify that the correct histogram entries were logged. |
| ExpectCardUploadDecision(histogram_tester, AutofillMetrics::UPLOAD_OFFERED); |
| ExpectCardUploadDecision( |
| histogram_tester, AutofillMetrics::UPLOAD_NOT_OFFERED_CONFLICTING_ZIPS); |
| // Verify that the correct UKM was logged. |
| ExpectCardUploadDecisionUkm( |
| AutofillMetrics::UPLOAD_OFFERED | |
| AutofillMetrics::UPLOAD_NOT_OFFERED_CONFLICTING_ZIPS); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, UploadCreditCard_ZipCodesHavePrefixMatch) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Create, fill and submit two address forms with different zip codes. |
| FormData address_form1, address_form2; |
| test::CreateTestAddressFormData(&address_form1); |
| test::CreateTestAddressFormData(&address_form2); |
| |
| std::vector<FormData> address_forms; |
| address_forms.push_back(address_form1); |
| address_forms.push_back(address_form2); |
| FormsSeen(address_forms); |
| |
| ManuallyFillAddressForm("Flo", "Master", "77401", "US", &address_form1); |
| FormSubmitted(address_form1); |
| |
| ManuallyFillAddressForm("Flo", "Master", "77401-8294", "US", &address_form2); |
| FormSubmitted(address_form2); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| base::HistogramTester histogram_tester; |
| |
| // One zip is a prefix of the other, upload should happen. |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| |
| // Verify that the correct histogram entry (and only that) was logged. |
| ExpectUniqueCardUploadDecision(histogram_tester, |
| AutofillMetrics::UPLOAD_OFFERED); |
| // Verify that the correct UKM was logged. |
| ExpectCardUploadDecisionUkm(AutofillMetrics::UPLOAD_OFFERED); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, UploadCreditCard_NoZipCodeAvailable) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Create, fill and submit an address form in order to establish a recent |
| // profile which can be selected for the upload request. |
| FormData address_form; |
| test::CreateTestAddressFormData(&address_form); |
| FormsSeen(std::vector<FormData>(1, address_form)); |
| // Autofill's validation requirements for Venezuala ("VE", see |
| // src/components/autofill/core/browser/country_data.cc) do not require zip |
| // codes. We use Venezuala here because to use the US (or one of many other |
| // countries which autofill requires a zip code for) would result in no |
| // address being imported at all, and then we never reach the check for |
| // missing zip code in the upload code. |
| ManuallyFillAddressForm("Flo", "Master", "" /* zip_code */, "Venezuela", |
| &address_form); |
| FormSubmitted(address_form); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| base::HistogramTester histogram_tester; |
| |
| // With the offer-to-save decision deferred to Google Payments, Payments can |
| // still decide to allow saving despite the missing zip code. |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| |
| // Verify that the correct histogram entries were logged. |
| ExpectCardUploadDecision(histogram_tester, AutofillMetrics::UPLOAD_OFFERED); |
| ExpectCardUploadDecision(histogram_tester, |
| AutofillMetrics::UPLOAD_NOT_OFFERED_NO_ZIP_CODE); |
| // Verify that the correct UKM was logged. |
| ExpectCardUploadDecisionUkm(AutofillMetrics::UPLOAD_OFFERED | |
| AutofillMetrics::UPLOAD_NOT_OFFERED_NO_ZIP_CODE); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, UploadCreditCard_CCFormHasMiddleInitial) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Create, fill and submit two address forms with different names. |
| FormData address_form1, address_form2; |
| test::CreateTestAddressFormData(&address_form1); |
| test::CreateTestAddressFormData(&address_form2); |
| FormsSeen({address_form1, address_form2}); |
| |
| // Names can be different case. |
| ManuallyFillAddressForm("flo", "master", "77401", "US", &address_form1); |
| FormSubmitted(address_form1); |
| |
| // And they can have a middle initial even if the other names don't. |
| ManuallyFillAddressForm("Flo W", "Master", "77401", "US", &address_form2); |
| FormSubmitted(address_form2); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen({credit_card_form}); |
| |
| // Edit the data, but use the name with a middle initial *and* period, and |
| // submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("Flo W. Master"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| base::HistogramTester histogram_tester; |
| |
| // Names match loosely, upload should happen. |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| |
| // Verify that the correct histogram entry (and only that) was logged. |
| ExpectUniqueCardUploadDecision(histogram_tester, |
| AutofillMetrics::UPLOAD_OFFERED); |
| // Verify that the correct UKM was logged. |
| ExpectCardUploadDecisionUkm(AutofillMetrics::UPLOAD_OFFERED); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, UploadCreditCard_NoMiddleInitialInCCForm) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Create, fill and submit two address forms with different names. |
| FormData address_form1, address_form2; |
| test::CreateTestAddressFormData(&address_form1); |
| test::CreateTestAddressFormData(&address_form2); |
| FormsSeen({address_form1, address_form2}); |
| |
| // Names can have different variations of middle initials. |
| ManuallyFillAddressForm("flo w.", "master", "77401", "US", &address_form1); |
| FormSubmitted(address_form1); |
| ManuallyFillAddressForm("Flo W", "Master", "77401", "US", &address_form2); |
| FormSubmitted(address_form2); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen({credit_card_form}); |
| |
| // Edit the data, but do not use middle initial. |
| credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| base::HistogramTester histogram_tester; |
| |
| // Names match loosely, upload should happen. |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| |
| // Verify that the correct histogram entry (and only that) was logged. |
| ExpectUniqueCardUploadDecision(histogram_tester, |
| AutofillMetrics::UPLOAD_OFFERED); |
| // Verify that the correct UKM was logged. |
| ExpectCardUploadDecisionUkm(AutofillMetrics::UPLOAD_OFFERED); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, |
| UploadCreditCard_CCFormHasCardholderMiddleName) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Create, fill and submit address form without middle name. |
| FormData address_form; |
| test::CreateTestAddressFormData(&address_form); |
| FormsSeen({address_form}); |
| ManuallyFillAddressForm("John", "Adams", "77401", "US", &address_form); |
| FormSubmitted(address_form); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen({credit_card_form}); |
| |
| // Edit the name by adding a middle name. |
| credit_card_form.fields[0].value = ASCIIToUTF16("John Quincy Adams"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| base::HistogramTester histogram_tester; |
| |
| // With the offer-to-save decision deferred to Google Payments, Payments can |
| // still decide to allow saving despite the mismatching names. |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| |
| // Verify that the correct histogram entries were logged. |
| ExpectCardUploadDecision(histogram_tester, AutofillMetrics::UPLOAD_OFFERED); |
| ExpectCardUploadDecision( |
| histogram_tester, AutofillMetrics::UPLOAD_NOT_OFFERED_CONFLICTING_NAMES); |
| // Verify that the correct UKM was logged. |
| ExpectCardUploadDecisionUkm( |
| AutofillMetrics::UPLOAD_OFFERED | |
| AutofillMetrics::UPLOAD_NOT_OFFERED_CONFLICTING_NAMES); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, UploadCreditCard_CCFormHasAddressMiddleName) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Create, fill and submit address form with middle name. |
| FormData address_form; |
| test::CreateTestAddressFormData(&address_form); |
| FormsSeen({address_form}); |
| ManuallyFillAddressForm("John Quincy", "Adams", "77401", "US", &address_form); |
| FormSubmitted(address_form); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen({credit_card_form}); |
| |
| // Edit the name by removing middle name. |
| credit_card_form.fields[0].value = ASCIIToUTF16("John Adams"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| base::HistogramTester histogram_tester; |
| |
| // With the offer-to-save decision deferred to Google Payments, Payments can |
| // still decide to allow saving despite the mismatching names. |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| |
| // Verify that the correct histogram entries were logged. |
| ExpectCardUploadDecision(histogram_tester, AutofillMetrics::UPLOAD_OFFERED); |
| ExpectCardUploadDecision( |
| histogram_tester, AutofillMetrics::UPLOAD_NOT_OFFERED_CONFLICTING_NAMES); |
| // Verify that the correct UKM was logged. |
| ExpectCardUploadDecisionUkm( |
| AutofillMetrics::UPLOAD_OFFERED | |
| AutofillMetrics::UPLOAD_NOT_OFFERED_CONFLICTING_NAMES); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, UploadCreditCard_NamesCanMismatch) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Create, fill and submit two address forms with different names. |
| FormData address_form1, address_form2; |
| test::CreateTestAddressFormData(&address_form1); |
| test::CreateTestAddressFormData(&address_form2); |
| |
| std::vector<FormData> address_forms; |
| address_forms.push_back(address_form1); |
| address_forms.push_back(address_form2); |
| FormsSeen(address_forms); |
| |
| ManuallyFillAddressForm("Flo", "Master", "77401", "US", &address_form1); |
| FormSubmitted(address_form1); |
| |
| ManuallyFillAddressForm("Master", "Blaster", "77401", "US", &address_form2); |
| FormSubmitted(address_form2); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, but use yet another name, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("Bob Master"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| base::HistogramTester histogram_tester; |
| |
| // With the offer-to-save decision deferred to Google Payments, Payments can |
| // still decide to allow saving despite the mismatching names. |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| |
| // Verify that the correct histogram entries were logged. |
| ExpectCardUploadDecision(histogram_tester, AutofillMetrics::UPLOAD_OFFERED); |
| ExpectCardUploadDecision( |
| histogram_tester, AutofillMetrics::UPLOAD_NOT_OFFERED_CONFLICTING_NAMES); |
| // Verify that the correct UKM was logged. |
| ExpectCardUploadDecisionUkm( |
| AutofillMetrics::UPLOAD_OFFERED | |
| AutofillMetrics::UPLOAD_NOT_OFFERED_CONFLICTING_NAMES); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, UploadCreditCard_IgnoreOldProfiles) { |
| // Create the test clock and set the time to a specific value. |
| TestAutofillClock test_clock; |
| test_clock.SetNow(kArbitraryTime); |
| |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Create, fill and submit two address forms with different names. |
| FormData address_form1, address_form2; |
| test::CreateTestAddressFormData(&address_form1); |
| test::CreateTestAddressFormData(&address_form2); |
| FormsSeen({address_form1, address_form2}); |
| |
| ManuallyFillAddressForm("Flo", "Master", "77401", "US", &address_form1); |
| FormSubmitted(address_form1); |
| |
| // Advance the current time. Since |address_form1| will not be a recently |
| // used address profile, we will not include it in the candidate profiles. |
| test_clock.SetNow(kMuchLaterTime); |
| |
| ManuallyFillAddressForm("Master", "Blaster", "77401", "US", &address_form2); |
| FormSubmitted(address_form2); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, but use yet another name, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("Master Blaster"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| base::HistogramTester histogram_tester; |
| |
| // Name matches recently used profile, should offer upload. |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| |
| // Verify that the correct histogram entry (and only that) was logged. |
| ExpectUniqueCardUploadDecision(histogram_tester, |
| AutofillMetrics::UPLOAD_OFFERED); |
| } |
| |
| // Requesting cardholder name currently not available on Android. |
| #if !defined(OS_ANDROID) |
| TEST_F( |
| CreditCardSaveManagerTest, |
| UploadCreditCard_RequestCardholderNameIfNameMissingAndNoPaymentsCustomer) { |
| scoped_feature_list_.InitAndEnableFeature( |
| kAutofillUpstreamEditableCardholderName); |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Create, fill and submit an address form in order to establish a recent |
| // profile which can be selected for the upload request. |
| FormData address_form; |
| test::CreateTestAddressFormData(&address_form); |
| FormsSeen(std::vector<FormData>(1, address_form)); |
| // But omit the name: |
| ManuallyFillAddressForm("", "", "77401", "US", &address_form); |
| FormSubmitted(address_form); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, but don't include a name, and submit. |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| base::HistogramTester histogram_tester; |
| |
| // With the offer-to-save decision deferred to Google Payments, Payments can |
| // still decide to allow saving despite the missing name. |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| |
| // Verify that the correct histogram entry and DetectedValue for "Cardholder |
| // name explicitly requested" was logged. |
| ExpectCardUploadDecision( |
| histogram_tester, |
| AutofillMetrics::USER_REQUESTED_TO_PROVIDE_CARDHOLDER_NAME); |
| EXPECT_TRUE(payments_client_->detected_values_in_upload_details() & |
| CreditCardSaveManager::DetectedValue::USER_PROVIDED_NAME); |
| } |
| |
| TEST_F( |
| CreditCardSaveManagerTest, |
| UploadCreditCard_RequestCardholderNameIfNameConflictingAndNoPaymentsCustomer) { |
| scoped_feature_list_.InitAndEnableFeature( |
| kAutofillUpstreamEditableCardholderName); |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Create, fill and submit an address form in order to establish a recent |
| // profile which can be selected for the upload request. |
| FormData address_form; |
| test::CreateTestAddressFormData(&address_form); |
| FormsSeen(std::vector<FormData>(1, address_form)); |
| ManuallyFillAddressForm("John", "Smith", "77401", "US", &address_form); |
| FormSubmitted(address_form); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, but include a conflicting name, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("Jane Doe"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| base::HistogramTester histogram_tester; |
| |
| // With the offer-to-save decision deferred to Google Payments, Payments can |
| // still decide to allow saving despite the missing name. |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| |
| // Verify that the correct histogram entry and DetectedValue for "Cardholder |
| // name explicitly requested" was logged. |
| ExpectCardUploadDecision( |
| histogram_tester, |
| AutofillMetrics::USER_REQUESTED_TO_PROVIDE_CARDHOLDER_NAME); |
| EXPECT_TRUE(payments_client_->detected_values_in_upload_details() & |
| CreditCardSaveManager::DetectedValue::USER_PROVIDED_NAME); |
| } |
| |
| TEST_F( |
| CreditCardSaveManagerTest, |
| UploadCreditCard_DoNotRequestCardholderNameIfNameExistsAndNoPaymentsCustomer) { |
| scoped_feature_list_.InitAndEnableFeature( |
| kAutofillUpstreamEditableCardholderName); |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Create, fill and submit an address form in order to establish a recent |
| // profile which can be selected for the upload request. |
| FormData address_form; |
| test::CreateTestAddressFormData(&address_form); |
| FormsSeen(std::vector<FormData>(1, address_form)); |
| ManuallyFillAddressForm("Flo", "Master", "77401", "US", &address_form); |
| FormSubmitted(address_form); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| base::HistogramTester histogram_tester; |
| |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| |
| // Because everything went smoothly, verify that there was no histogram entry |
| // or DetectedValue for "Cardholder name explicitly requested" logged. |
| ExpectNoCardUploadDecision( |
| histogram_tester, |
| AutofillMetrics::USER_REQUESTED_TO_PROVIDE_CARDHOLDER_NAME); |
| EXPECT_FALSE(payments_client_->detected_values_in_upload_details() & |
| CreditCardSaveManager::DetectedValue::USER_PROVIDED_NAME); |
| } |
| |
| TEST_F( |
| CreditCardSaveManagerTest, |
| UploadCreditCard_DoNotRequestCardholderNameIfNameMissingAndPaymentsCustomer) { |
| scoped_feature_list_.InitAndEnableFeature( |
| kAutofillUpstreamEditableCardholderName); |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Set the billing_customer_number Priority Preference to designate existence |
| // of a Payments account. |
| autofill_client_.GetPrefs()->SetDouble(prefs::kAutofillBillingCustomerNumber, |
| 12345); |
| |
| // Create, fill and submit an address form in order to establish a recent |
| // profile which can be selected for the upload request. |
| FormData address_form; |
| test::CreateTestAddressFormData(&address_form); |
| FormsSeen(std::vector<FormData>(1, address_form)); |
| // But omit the name: |
| ManuallyFillAddressForm("", "", "77401", "US", &address_form); |
| FormSubmitted(address_form); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, but don't include a name, and submit. |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| base::HistogramTester histogram_tester; |
| |
| // With the offer-to-save decision deferred to Google Payments, Payments can |
| // still decide to allow saving despite the missing name. |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| |
| // Verify that there was no histogram entry or DetectedValue for "Cardholder |
| // name explicitly requested" logged. |
| ExpectNoCardUploadDecision( |
| histogram_tester, |
| AutofillMetrics::USER_REQUESTED_TO_PROVIDE_CARDHOLDER_NAME); |
| EXPECT_FALSE(payments_client_->detected_values_in_upload_details() & |
| CreditCardSaveManager::DetectedValue::USER_PROVIDED_NAME); |
| } |
| |
| TEST_F( |
| CreditCardSaveManagerTest, |
| UploadCreditCard_DoNotRequestCardholderNameIfNameConflictingAndPaymentsCustomer) { |
| scoped_feature_list_.InitAndEnableFeature( |
| kAutofillUpstreamEditableCardholderName); |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Set the billing_customer_number Priority Preference to designate existence |
| // of a Payments account. |
| autofill_client_.GetPrefs()->SetDouble(prefs::kAutofillBillingCustomerNumber, |
| 12345); |
| |
| // Create, fill and submit an address form in order to establish a recent |
| // profile which can be selected for the upload request. |
| FormData address_form; |
| test::CreateTestAddressFormData(&address_form); |
| FormsSeen(std::vector<FormData>(1, address_form)); |
| ManuallyFillAddressForm("John", "Smith", "77401", "US", &address_form); |
| FormSubmitted(address_form); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, but include a conflicting name, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("Jane Doe"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| base::HistogramTester histogram_tester; |
| |
| // With the offer-to-save decision deferred to Google Payments, Payments can |
| // still decide to allow saving despite the missing name. |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| |
| // Verify that there was no histogram entry or DetectedValue for "Cardholder |
| // name explicitly requested" logged. |
| ExpectNoCardUploadDecision( |
| histogram_tester, |
| AutofillMetrics::USER_REQUESTED_TO_PROVIDE_CARDHOLDER_NAME); |
| EXPECT_FALSE(payments_client_->detected_values_in_upload_details() & |
| CreditCardSaveManager::DetectedValue::USER_PROVIDED_NAME); |
| } |
| |
| TEST_F( |
| CreditCardSaveManagerTest, |
| UploadCreditCard_DoNotRequestCardholderNameIfNameMissingAndNoPaymentsCustomerExpOff) { |
| scoped_feature_list_.InitAndDisableFeature( |
| kAutofillUpstreamEditableCardholderName); |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Create, fill and submit an address form in order to establish a recent |
| // profile which can be selected for the upload request. |
| FormData address_form; |
| test::CreateTestAddressFormData(&address_form); |
| FormsSeen(std::vector<FormData>(1, address_form)); |
| // But omit the name: |
| ManuallyFillAddressForm("", "", "77401", "US", &address_form); |
| FormSubmitted(address_form); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, but don't include a name, and submit. |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| base::HistogramTester histogram_tester; |
| |
| // With the offer-to-save decision deferred to Google Payments, Payments can |
| // still decide to allow saving despite the missing name. |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| |
| // Verify that there was no histogram entry or DetectedValue for "Cardholder |
| // name explicitly requested" logged. |
| ExpectNoCardUploadDecision( |
| histogram_tester, |
| AutofillMetrics::USER_REQUESTED_TO_PROVIDE_CARDHOLDER_NAME); |
| EXPECT_FALSE(payments_client_->detected_values_in_upload_details() & |
| CreditCardSaveManager::DetectedValue::USER_PROVIDED_NAME); |
| } |
| |
| TEST_F( |
| CreditCardSaveManagerTest, |
| UploadCreditCard_DoNotRequestCardholderNameIfNameConflictingAndNoPaymentsCustomerExpOff) { |
| scoped_feature_list_.InitAndDisableFeature( |
| kAutofillUpstreamEditableCardholderName); |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Create, fill and submit an address form in order to establish a recent |
| // profile which can be selected for the upload request. |
| FormData address_form; |
| test::CreateTestAddressFormData(&address_form); |
| FormsSeen(std::vector<FormData>(1, address_form)); |
| ManuallyFillAddressForm("John", "Smith", "77401", "US", &address_form); |
| FormSubmitted(address_form); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, but include a conflicting name, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("Jane Doe"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| base::HistogramTester histogram_tester; |
| |
| // With the offer-to-save decision deferred to Google Payments, Payments can |
| // still decide to allow saving despite the missing name. |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| |
| // Verify that there was no histogram entry or DetectedValue for "Cardholder |
| // name explicitly requested" logged. |
| ExpectNoCardUploadDecision( |
| histogram_tester, |
| AutofillMetrics::USER_REQUESTED_TO_PROVIDE_CARDHOLDER_NAME); |
| EXPECT_FALSE(payments_client_->detected_values_in_upload_details() & |
| CreditCardSaveManager::DetectedValue::USER_PROVIDED_NAME); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, |
| UploadCreditCard_RequestCardholderNameIfTestingExperimentOn) { |
| scoped_feature_list_.InitAndEnableFeature( |
| kAutofillUpstreamAlwaysRequestCardholderName); |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Create, fill and submit an address form in order to establish a recent |
| // profile which can be selected for the upload request. |
| FormData address_form; |
| test::CreateTestAddressFormData(&address_form); |
| FormsSeen(std::vector<FormData>(1, address_form)); |
| ManuallyFillAddressForm("Flo", "Master", "77401", "US", &address_form); |
| FormSubmitted(address_form); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| base::HistogramTester histogram_tester; |
| |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| |
| // Even though everything went smoothly, because the "always request |
| // cardholder name" experiment was enabled, verify that the correct histogram |
| // entry and DetectedValue for "Cardholder name explicitly requested" was |
| // logged. |
| ExpectCardUploadDecision( |
| histogram_tester, |
| AutofillMetrics::USER_REQUESTED_TO_PROVIDE_CARDHOLDER_NAME); |
| EXPECT_TRUE(payments_client_->detected_values_in_upload_details() & |
| CreditCardSaveManager::DetectedValue::USER_PROVIDED_NAME); |
| } |
| #endif |
| |
| TEST_F(CreditCardSaveManagerTest, UploadCreditCard_LogPreviousUseDate) { |
| // Create the test clock and set the time to a specific value. |
| TestAutofillClock test_clock; |
| test_clock.SetNow(kArbitraryTime); |
| |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Create, fill and submit an address form in order to establish a recent |
| // profile which can be selected for the upload request. |
| FormData address_form; |
| test::CreateTestAddressFormData(&address_form); |
| FormsSeen({address_form}); |
| ManuallyFillAddressForm("Flo", "Master", "77401", "US", &address_form); |
| FormSubmitted(address_form); |
| const std::vector<AutofillProfile*>& profiles = |
| personal_data_.GetProfilesToSuggest(); |
| ASSERT_EQ(1U, profiles.size()); |
| |
| // Advance the current time and simulate use of the address profile. |
| test_clock.SetNow(kMuchLaterTime); |
| profiles[0]->RecordAndLogUse(); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen({credit_card_form}); |
| |
| // Edit the credit card form and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| base::HistogramTester histogram_tester; |
| |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| |
| // Verify that UMA for "DaysSincePreviousUse" is logged. |
| histogram_tester.ExpectUniqueSample( |
| "Autofill.DaysSincePreviousUseAtSubmission.Profile", |
| (kMuchLaterTime - kArbitraryTime).InDays(), |
| /*expected_count=*/1); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, UploadCreditCard_UploadDetailsFails) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Anything other than "en-US" will cause GetUploadDetails to return a failure |
| // response. |
| credit_card_save_manager_->SetAppLocale("pt-BR"); |
| |
| // Create, fill and submit an address form in order to establish a recent |
| // profile which can be selected for the upload request. |
| FormData address_form; |
| test::CreateTestAddressFormData(&address_form); |
| FormsSeen(std::vector<FormData>(1, address_form)); |
| ManuallyFillAddressForm("Flo", "Master", "77401", "US", &address_form); |
| FormSubmitted(address_form); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| base::HistogramTester histogram_tester; |
| |
| // The save prompt should be shown instead of doing an upload. |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)); |
| FormSubmitted(credit_card_form); |
| EXPECT_FALSE(credit_card_save_manager_->CreditCardWasUploaded()); |
| |
| // Verify that the correct histogram entry (and only that) was logged. |
| ExpectUniqueCardUploadDecision( |
| histogram_tester, |
| AutofillMetrics::UPLOAD_NOT_OFFERED_GET_UPLOAD_DETAILS_FAILED); |
| // Verify that the correct UKM was logged. |
| ExpectCardUploadDecisionUkm( |
| AutofillMetrics::UPLOAD_NOT_OFFERED_GET_UPLOAD_DETAILS_FAILED); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, DuplicateMaskedCreditCard_NoUpload) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| credit_card_save_manager_->SetAppLocale("en-US"); |
| |
| // Create, fill and submit an address form in order to establish a recent |
| // profile which can be selected for the upload request. |
| FormData address_form; |
| test::CreateTestAddressFormData(&address_form); |
| FormsSeen(std::vector<FormData>(1, address_form)); |
| ManuallyFillAddressForm("Flo", "Master", "77401", "US", &address_form); |
| FormSubmitted(address_form); |
| |
| // Add a masked credit card whose |TypeAndLastFourDigits| matches what we will |
| // enter below. |
| CreditCard credit_card(CreditCard::MASKED_SERVER_CARD, "a123"); |
| test::SetCreditCardInfo(&credit_card, "Flo Master", "1111", |
| NextMonth().c_str(), NextYear().c_str(), "1"); |
| credit_card.SetNetworkForMaskedCard(kVisaCard); |
| personal_data_.AddServerCreditCard(credit_card); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| // Local save prompt should not be shown as there is alredy masked |
| // card with same |TypeAndLastFourDigits|. |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_FALSE(credit_card_save_manager_->CreditCardWasUploaded()); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, GetDetectedValues_NothingIfNothingFound) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16(""); // No name set |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16(""); // No CVC set |
| |
| // Submit the form and check what detected_values for an upload save would be. |
| FormSubmitted(credit_card_form); |
| EXPECT_EQ(payments_client_->detected_values_in_upload_details(), 0); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, GetDetectedValues_DetectCvc) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16(""); // No name set |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| // Submit the form and check what detected_values for an upload save would be. |
| FormSubmitted(credit_card_form); |
| EXPECT_EQ(payments_client_->detected_values_in_upload_details(), |
| CreditCardSaveManager::DetectedValue::CVC); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, GetDetectedValues_DetectCardholderName) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("John Smith"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16(""); // No CVC set |
| |
| // Submit the form and check what detected_values for an upload save would be. |
| FormSubmitted(credit_card_form); |
| EXPECT_EQ(payments_client_->detected_values_in_upload_details(), |
| CreditCardSaveManager::DetectedValue::CARDHOLDER_NAME); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, GetDetectedValues_DetectAddressName) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Set up a new address profile. |
| AutofillProfile profile; |
| profile.set_guid("00000000-0000-0000-0000-000000000200"); |
| profile.SetInfo(NAME_FULL, ASCIIToUTF16("John Smith"), "en-US"); |
| personal_data_.AddProfile(profile); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16(""); // No name set |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16(""); // No CVC set |
| |
| // Submit the form and check what detected_values for an upload save would be. |
| FormSubmitted(credit_card_form); |
| EXPECT_EQ(payments_client_->detected_values_in_upload_details(), |
| CreditCardSaveManager::DetectedValue::ADDRESS_NAME); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, |
| GetDetectedValues_DetectCardholderAndAddressNameIfMatching) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Set up a new address profile. |
| AutofillProfile profile; |
| profile.set_guid("00000000-0000-0000-0000-000000000200"); |
| profile.SetInfo(NAME_FULL, ASCIIToUTF16("John Smith"), "en-US"); |
| personal_data_.AddProfile(profile); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("John Smith"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16(""); // No CVC set |
| |
| // Submit the form and check what detected_values for an upload save would be. |
| FormSubmitted(credit_card_form); |
| EXPECT_EQ(payments_client_->detected_values_in_upload_details(), |
| CreditCardSaveManager::DetectedValue::CARDHOLDER_NAME | |
| CreditCardSaveManager::DetectedValue::ADDRESS_NAME); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, |
| GetDetectedValues_DetectNoUniqueNameIfNamesConflict) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Set up a new address profile. |
| AutofillProfile profile; |
| profile.set_guid("00000000-0000-0000-0000-000000000200"); |
| profile.SetInfo(NAME_FULL, ASCIIToUTF16("John Smith"), "en-US"); |
| personal_data_.AddProfile(profile); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("Miles Prower"); // Conflict! |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16(""); // No CVC set |
| |
| // Submit the form and check what detected_values for an upload save would be. |
| FormSubmitted(credit_card_form); |
| EXPECT_EQ(payments_client_->detected_values_in_upload_details(), 0); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, GetDetectedValues_DetectPostalCode) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Set up a new address profile. |
| AutofillProfile profile; |
| profile.set_guid("00000000-0000-0000-0000-000000000200"); |
| profile.SetInfo(ADDRESS_HOME_ZIP, ASCIIToUTF16("94043"), "en-US"); |
| personal_data_.AddProfile(profile); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16(""); // No name set |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16(""); // No CVC set |
| |
| // Submit the form and check what detected_values for an upload save would be. |
| FormSubmitted(credit_card_form); |
| EXPECT_EQ(payments_client_->detected_values_in_upload_details(), |
| CreditCardSaveManager::DetectedValue::POSTAL_CODE); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, |
| GetDetectedValues_DetectNoUniquePostalCodeIfZipsConflict) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Set up two new address profiles with conflicting postal codes. |
| AutofillProfile profile1; |
| profile1.set_guid("00000000-0000-0000-0000-000000000200"); |
| profile1.SetInfo(ADDRESS_HOME_ZIP, ASCIIToUTF16("94043"), "en-US"); |
| personal_data_.AddProfile(profile1); |
| AutofillProfile profile2; |
| profile2.set_guid("00000000-0000-0000-0000-000000000201"); |
| profile2.SetInfo(ADDRESS_HOME_ZIP, ASCIIToUTF16("95051"), "en-US"); |
| personal_data_.AddProfile(profile2); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16(""); // No name set |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16(""); // No CVC set |
| |
| // Submit the form and check what detected_values for an upload save would be. |
| FormSubmitted(credit_card_form); |
| EXPECT_EQ(payments_client_->detected_values_in_upload_details(), 0); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, GetDetectedValues_DetectAddressLine) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Set up a new address profile. |
| AutofillProfile profile; |
| profile.set_guid("00000000-0000-0000-0000-000000000200"); |
| profile.SetInfo(ADDRESS_HOME_LINE1, ASCIIToUTF16("123 Testing St."), "en-US"); |
| personal_data_.AddProfile(profile); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16(""); // No name set |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16(""); // No CVC set |
| |
| // Submit the form and check what detected_values for an upload save would be. |
| FormSubmitted(credit_card_form); |
| EXPECT_EQ(payments_client_->detected_values_in_upload_details(), |
| CreditCardSaveManager::DetectedValue::ADDRESS_LINE); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, GetDetectedValues_DetectLocality) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Set up a new address profile. |
| AutofillProfile profile; |
| profile.set_guid("00000000-0000-0000-0000-000000000200"); |
| profile.SetInfo(ADDRESS_HOME_CITY, ASCIIToUTF16("Mountain View"), "en-US"); |
| personal_data_.AddProfile(profile); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16(""); // No name set |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16(""); // No CVC set |
| |
| // Submit the form and check what detected_values for an upload save would be. |
| FormSubmitted(credit_card_form); |
| EXPECT_EQ(payments_client_->detected_values_in_upload_details(), |
| CreditCardSaveManager::DetectedValue::LOCALITY); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, GetDetectedValues_DetectAdministrativeArea) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Set up a new address profile. |
| AutofillProfile profile; |
| profile.set_guid("00000000-0000-0000-0000-000000000200"); |
| profile.SetInfo(ADDRESS_HOME_STATE, ASCIIToUTF16("California"), "en-US"); |
| personal_data_.AddProfile(profile); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16(""); // No name set |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16(""); // No CVC set |
| |
| // Submit the form and check what detected_values for an upload save would be. |
| FormSubmitted(credit_card_form); |
| EXPECT_EQ(payments_client_->detected_values_in_upload_details(), |
| CreditCardSaveManager::DetectedValue::ADMINISTRATIVE_AREA); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, GetDetectedValues_DetectCountryCode) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Set up a new address profile. |
| AutofillProfile profile; |
| profile.set_guid("00000000-0000-0000-0000-000000000200"); |
| profile.SetInfo(ADDRESS_HOME_COUNTRY, ASCIIToUTF16("US"), "en-US"); |
| personal_data_.AddProfile(profile); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16(""); // No name set |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16(""); // No CVC set |
| |
| // Submit the form and check what detected_values for an upload save would be. |
| FormSubmitted(credit_card_form); |
| EXPECT_EQ(payments_client_->detected_values_in_upload_details(), |
| CreditCardSaveManager::DetectedValue::COUNTRY_CODE); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, |
| GetDetectedValues_DetectHasGooglePaymentAccount) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Set the billing_customer_number Priority Preference to designate existence |
| // of a Payments account. |
| autofill_client_.GetPrefs()->SetDouble(prefs::kAutofillBillingCustomerNumber, |
| 12345); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16(""); // No name set |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16(""); // No CVC set |
| |
| // Submit the form and check what detected_values for an upload save would be. |
| FormSubmitted(credit_card_form); |
| EXPECT_EQ(payments_client_->detected_values_in_upload_details(), |
| CreditCardSaveManager::DetectedValue::HAS_GOOGLE_PAYMENTS_ACCOUNT); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, GetDetectedValues_DetectEverythingAtOnce) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Set up a new address profile. |
| AutofillProfile profile; |
| profile.set_guid("00000000-0000-0000-0000-000000000200"); |
| profile.SetInfo(NAME_FULL, ASCIIToUTF16("John Smith"), "en-US"); |
| profile.SetInfo(ADDRESS_HOME_LINE1, ASCIIToUTF16("123 Testing St."), "en-US"); |
| profile.SetInfo(ADDRESS_HOME_CITY, ASCIIToUTF16("Mountain View"), "en-US"); |
| profile.SetInfo(ADDRESS_HOME_STATE, ASCIIToUTF16("California"), "en-US"); |
| profile.SetInfo(ADDRESS_HOME_ZIP, ASCIIToUTF16("94043"), "en-US"); |
| profile.SetInfo(ADDRESS_HOME_COUNTRY, ASCIIToUTF16("US"), "en-US"); |
| personal_data_.AddProfile(profile); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("John Smith"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| // Submit the form and check what detected_values for an upload save would be. |
| FormSubmitted(credit_card_form); |
| EXPECT_EQ(payments_client_->detected_values_in_upload_details(), |
| CreditCardSaveManager::DetectedValue::CVC | |
| CreditCardSaveManager::DetectedValue::CARDHOLDER_NAME | |
| CreditCardSaveManager::DetectedValue::ADDRESS_NAME | |
| CreditCardSaveManager::DetectedValue::ADDRESS_LINE | |
| CreditCardSaveManager::DetectedValue::LOCALITY | |
| CreditCardSaveManager::DetectedValue::ADMINISTRATIVE_AREA | |
| CreditCardSaveManager::DetectedValue::POSTAL_CODE | |
| CreditCardSaveManager::DetectedValue::COUNTRY_CODE); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, |
| GetDetectedValues_DetectSubsetOfPossibleFields) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Set up a new address profile, taking out address line and state. |
| AutofillProfile profile; |
| profile.set_guid("00000000-0000-0000-0000-000000000200"); |
| profile.SetInfo(NAME_FULL, ASCIIToUTF16("John Smith"), "en-US"); |
| profile.SetInfo(ADDRESS_HOME_CITY, ASCIIToUTF16("Mountain View"), "en-US"); |
| profile.SetInfo(ADDRESS_HOME_ZIP, ASCIIToUTF16("94043"), "en-US"); |
| profile.SetInfo(ADDRESS_HOME_COUNTRY, ASCIIToUTF16("US"), "en-US"); |
| personal_data_.AddProfile(profile); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("Miles Prower"); // Conflict! |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| // Submit the form and check what detected_values for an upload save would be. |
| FormSubmitted(credit_card_form); |
| EXPECT_EQ(payments_client_->detected_values_in_upload_details(), |
| CreditCardSaveManager::DetectedValue::CVC | |
| CreditCardSaveManager::DetectedValue::LOCALITY | |
| CreditCardSaveManager::DetectedValue::POSTAL_CODE | |
| CreditCardSaveManager::DetectedValue::COUNTRY_CODE); |
| } |
| |
| // This test checks that ADDRESS_LINE, LOCALITY, ADMINISTRATIVE_AREA, and |
| // COUNTRY_CODE don't care about possible conflicts or consistency and are |
| // populated if even one address profile contains it. |
| TEST_F(CreditCardSaveManagerTest, |
| GetDetectedValues_DetectAddressComponentsAcrossProfiles) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Set up four new address profiles, each with a different address component. |
| AutofillProfile profile1; |
| profile1.set_guid("00000000-0000-0000-0000-000000000200"); |
| profile1.SetInfo(ADDRESS_HOME_LINE1, ASCIIToUTF16("123 Testing St."), |
| "en-US"); |
| personal_data_.AddProfile(profile1); |
| AutofillProfile profile2; |
| profile2.set_guid("00000000-0000-0000-0000-000000000201"); |
| profile2.SetInfo(ADDRESS_HOME_CITY, ASCIIToUTF16("Mountain View"), "en-US"); |
| personal_data_.AddProfile(profile2); |
| AutofillProfile profile3; |
| profile3.set_guid("00000000-0000-0000-0000-000000000202"); |
| profile3.SetInfo(ADDRESS_HOME_STATE, ASCIIToUTF16("California"), "en-US"); |
| personal_data_.AddProfile(profile3); |
| AutofillProfile profile4; |
| profile4.set_guid("00000000-0000-0000-0000-000000000203"); |
| profile4.SetInfo(ADDRESS_HOME_COUNTRY, ASCIIToUTF16("US"), "en-US"); |
| personal_data_.AddProfile(profile4); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16(""); // No name set |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16(""); // No CVC set |
| |
| // Submit the form and check what detected_values for an upload save would be. |
| FormSubmitted(credit_card_form); |
| EXPECT_EQ(payments_client_->detected_values_in_upload_details(), |
| CreditCardSaveManager::DetectedValue::ADDRESS_LINE | |
| CreditCardSaveManager::DetectedValue::LOCALITY | |
| CreditCardSaveManager::DetectedValue::ADMINISTRATIVE_AREA | |
| CreditCardSaveManager::DetectedValue::COUNTRY_CODE); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, |
| UploadCreditCard_LogAdditionalErrorsWithUploadDetailsFailure) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Anything other than "en-US" will cause GetUploadDetails to return a failure |
| // response. |
| credit_card_save_manager_->SetAppLocale("pt-BR"); |
| |
| // Set up a new address profile without a name or postal code. |
| AutofillProfile profile; |
| profile.set_guid("00000000-0000-0000-0000-000000000200"); |
| profile.SetInfo(ADDRESS_HOME_LINE1, ASCIIToUTF16("123 Testing St."), "en-US"); |
| profile.SetInfo(ADDRESS_HOME_CITY, ASCIIToUTF16("Mountain View"), "en-US"); |
| profile.SetInfo(ADDRESS_HOME_STATE, ASCIIToUTF16("California"), "en-US"); |
| profile.SetInfo(ADDRESS_HOME_COUNTRY, ASCIIToUTF16("US"), "en-US"); |
| personal_data_.AddProfile(profile); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16(""); // No name! |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16(""); // No CVC! |
| |
| base::HistogramTester histogram_tester; |
| FormSubmitted(credit_card_form); |
| |
| // Verify that the correct histogram entries were logged. |
| ExpectCardUploadDecision( |
| histogram_tester, |
| AutofillMetrics::UPLOAD_NOT_OFFERED_GET_UPLOAD_DETAILS_FAILED); |
| ExpectCardUploadDecision(histogram_tester, |
| AutofillMetrics::UPLOAD_NOT_OFFERED_NO_NAME); |
| ExpectCardUploadDecision(histogram_tester, |
| AutofillMetrics::UPLOAD_NOT_OFFERED_NO_ZIP_CODE); |
| ExpectCardUploadDecision(histogram_tester, |
| AutofillMetrics::CVC_VALUE_NOT_FOUND); |
| // Verify that the correct UKM was logged. |
| ExpectMetric(UkmCardUploadDecisionType::kUploadDecisionName, |
| UkmCardUploadDecisionType::kEntryName, |
| AutofillMetrics::UPLOAD_NOT_OFFERED_GET_UPLOAD_DETAILS_FAILED | |
| AutofillMetrics::UPLOAD_NOT_OFFERED_NO_NAME | |
| AutofillMetrics::UPLOAD_NOT_OFFERED_NO_ZIP_CODE | |
| AutofillMetrics::CVC_VALUE_NOT_FOUND, |
| 1 /* expected_num_matching_entries */); |
| } |
| |
| TEST_F( |
| CreditCardSaveManagerTest, |
| UploadCreditCard_ShouldOfferLocalSaveIfEverythingDetectedAndPaymentsDeclines) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Anything other than "en-US" will cause GetUploadDetails to return a failure |
| // response. |
| credit_card_save_manager_->SetAppLocale("pt-BR"); |
| |
| // Set up a new address profile. |
| AutofillProfile profile; |
| profile.set_guid("00000000-0000-0000-0000-000000000200"); |
| profile.SetInfo(NAME_FULL, ASCIIToUTF16("John Smith"), "en-US"); |
| profile.SetInfo(ADDRESS_HOME_LINE1, ASCIIToUTF16("123 Testing St."), "en-US"); |
| profile.SetInfo(ADDRESS_HOME_CITY, ASCIIToUTF16("Mountain View"), "en-US"); |
| profile.SetInfo(ADDRESS_HOME_STATE, ASCIIToUTF16("California"), "en-US"); |
| profile.SetInfo(ADDRESS_HOME_ZIP, ASCIIToUTF16("94043"), "en-US"); |
| profile.SetInfo(ADDRESS_HOME_COUNTRY, ASCIIToUTF16("US"), "en-US"); |
| personal_data_.AddProfile(profile); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("John Smith"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| base::HistogramTester histogram_tester; |
| |
| // Because Payments rejects the offer to upload save but CVC + name + address |
| // were all found, the local save prompt should be shown instead of the upload |
| // prompt. |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)); |
| FormSubmitted(credit_card_form); |
| EXPECT_FALSE(credit_card_save_manager_->CreditCardWasUploaded()); |
| } |
| |
| TEST_F( |
| CreditCardSaveManagerTest, |
| UploadCreditCard_ShouldOfferLocalSaveIfEverythingDetectedAndPaymentsDeclines_WithFirstAndLastName) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Anything other than "en-US" will cause GetUploadDetails to return a failure |
| // response. |
| credit_card_save_manager_->SetAppLocale("pt-BR"); |
| |
| // Set up a new address profile. |
| AutofillProfile profile; |
| profile.set_guid("00000000-0000-0000-0000-000000000200"); |
| profile.SetInfo(NAME_FULL, ASCIIToUTF16("John Smith"), "en-US"); |
| profile.SetInfo(ADDRESS_HOME_LINE1, ASCIIToUTF16("123 Testing St."), "en-US"); |
| profile.SetInfo(ADDRESS_HOME_CITY, ASCIIToUTF16("Mountain View"), "en-US"); |
| profile.SetInfo(ADDRESS_HOME_STATE, ASCIIToUTF16("California"), "en-US"); |
| profile.SetInfo(ADDRESS_HOME_ZIP, ASCIIToUTF16("94043"), "en-US"); |
| profile.SetInfo(ADDRESS_HOME_COUNTRY, ASCIIToUTF16("US"), "en-US"); |
| personal_data_.AddProfile(profile); |
| |
| // Set up our credit card form data with credit card first and last name |
| // fields. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, /*is_https=*/true, |
| /*use_month_type=*/false, /*split_names=*/true); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("John"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("Smith"); |
| credit_card_form.fields[2].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[4].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[5].value = ASCIIToUTF16("123"); |
| |
| base::HistogramTester histogram_tester; |
| |
| // Because Payments rejects the offer to upload save but CVC + name + address |
| // were all found, the local save prompt should be shown instead of the upload |
| // prompt. |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)); |
| FormSubmitted(credit_card_form); |
| EXPECT_FALSE(credit_card_save_manager_->CreditCardWasUploaded()); |
| |
| histogram_tester.ExpectTotalCount( |
| "Autofill.SaveCardWithFirstAndLastNameOffered.Local", 1); |
| histogram_tester.ExpectTotalCount( |
| "Autofill.SaveCardWithFirstAndLastNameOffered.Server", 0); |
| histogram_tester.ExpectTotalCount( |
| "Autofill.SaveCardWithFirstAndLastNameComplete.Server", 0); |
| } |
| |
| TEST_F( |
| CreditCardSaveManagerTest, |
| UploadCreditCard_ShouldNotOfferLocalSaveIfSomethingNotDetectedAndPaymentsDeclines) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Anything other than "en-US" will cause GetUploadDetails to return a failure |
| // response. |
| credit_card_save_manager_->SetAppLocale("pt-BR"); |
| |
| // Set up a new address profile without a name or postal code. |
| AutofillProfile profile; |
| profile.set_guid("00000000-0000-0000-0000-000000000200"); |
| profile.SetInfo(ADDRESS_HOME_LINE1, ASCIIToUTF16("123 Testing St."), "en-US"); |
| profile.SetInfo(ADDRESS_HOME_CITY, ASCIIToUTF16("Mountain View"), "en-US"); |
| profile.SetInfo(ADDRESS_HOME_STATE, ASCIIToUTF16("California"), "en-US"); |
| profile.SetInfo(ADDRESS_HOME_COUNTRY, ASCIIToUTF16("US"), "en-US"); |
| personal_data_.AddProfile(profile); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16(""); // No name! |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16(""); // No CVC! |
| |
| base::HistogramTester histogram_tester; |
| |
| // Because Payments rejects the offer to upload save but not all of CVC + name |
| // + address were detected, the local save prompt should not be shown either. |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_FALSE(credit_card_save_manager_->CreditCardWasUploaded()); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, |
| UploadCreditCard_PaymentsDecidesOfferToSaveIfNoCvc) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Create, fill and submit an address form in order to establish a recent |
| // profile which can be selected for the upload request. |
| FormData address_form; |
| test::CreateTestAddressFormData(&address_form); |
| FormsSeen(std::vector<FormData>(1, address_form)); |
| ManuallyFillAddressForm("Flo", "Master", "77401", "US", &address_form); |
| FormSubmitted(address_form); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16(""); // No CVC! |
| |
| base::HistogramTester histogram_tester; |
| |
| // Payments should be asked whether upload save can be offered. |
| // (Unit tests assume they reply yes and save is successful.) |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| |
| // Verify that the correct histogram entries were logged. |
| ExpectCardUploadDecision(histogram_tester, AutofillMetrics::UPLOAD_OFFERED); |
| ExpectCardUploadDecision(histogram_tester, |
| AutofillMetrics::CVC_VALUE_NOT_FOUND); |
| // Verify that the correct UKM was logged. |
| ExpectMetric( |
| UkmCardUploadDecisionType::kUploadDecisionName, |
| UkmCardUploadDecisionType::kEntryName, |
| AutofillMetrics::UPLOAD_OFFERED | AutofillMetrics::CVC_VALUE_NOT_FOUND, |
| 1 /* expected_num_matching_entries */); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, |
| UploadCreditCard_PaymentsDecidesOfferToSaveIfNoName) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Create, fill and submit an address form in order to establish a recent |
| // profile which can be selected for the upload request. |
| FormData address_form; |
| test::CreateTestAddressFormData(&address_form); |
| FormsSeen(std::vector<FormData>(1, address_form)); |
| // But omit the name: |
| ManuallyFillAddressForm("", "", "77401", "US", &address_form); |
| FormSubmitted(address_form); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16(""); // No name! |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| base::HistogramTester histogram_tester; |
| |
| // Payments should be asked whether upload save can be offered. |
| // (Unit tests assume they reply yes and save is successful.) |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| |
| // Verify that the correct histogram entries were logged. |
| ExpectCardUploadDecision(histogram_tester, AutofillMetrics::UPLOAD_OFFERED); |
| ExpectCardUploadDecision(histogram_tester, |
| AutofillMetrics::UPLOAD_NOT_OFFERED_NO_NAME); |
| // Verify that the correct UKM was logged. |
| ExpectMetric(UkmCardUploadDecisionType::kUploadDecisionName, |
| UkmCardUploadDecisionType::kEntryName, |
| AutofillMetrics::UPLOAD_OFFERED | |
| AutofillMetrics::UPLOAD_NOT_OFFERED_NO_NAME, |
| 1 /* expected_num_matching_entries */); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, |
| UploadCreditCard_PaymentsDecidesOfferToSaveIfConflictingNames) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Create, fill and submit an address form in order to establish a recent |
| // profile which can be selected for the upload request. |
| FormData address_form; |
| test::CreateTestAddressFormData(&address_form); |
| FormsSeen(std::vector<FormData>(1, address_form)); |
| ManuallyFillAddressForm("Flo", "Master", "77401", "US", &address_form); |
| FormSubmitted(address_form); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("Miles Prower"); // Conflict! |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| base::HistogramTester histogram_tester; |
| |
| // Payments should be asked whether upload save can be offered. |
| // (Unit tests assume they reply yes and save is successful.) |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| |
| // Verify that the correct histogram entries were logged. |
| ExpectCardUploadDecision(histogram_tester, AutofillMetrics::UPLOAD_OFFERED); |
| ExpectCardUploadDecision( |
| histogram_tester, AutofillMetrics::UPLOAD_NOT_OFFERED_CONFLICTING_NAMES); |
| // Verify that the correct UKM was logged. |
| ExpectMetric(UkmCardUploadDecisionType::kUploadDecisionName, |
| UkmCardUploadDecisionType::kEntryName, |
| AutofillMetrics::UPLOAD_OFFERED | |
| AutofillMetrics::UPLOAD_NOT_OFFERED_CONFLICTING_NAMES, |
| 1 /* expected_num_matching_entries */); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, |
| UploadCreditCard_PaymentsDecidesOfferToSaveIfNoZip) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Set up a new address profile without a postal code. |
| AutofillProfile profile; |
| profile.set_guid("00000000-0000-0000-0000-000000000200"); |
| profile.SetInfo(NAME_FULL, ASCIIToUTF16("Flo Master"), "en-US"); |
| profile.SetInfo(ADDRESS_HOME_LINE1, ASCIIToUTF16("123 Testing St."), "en-US"); |
| profile.SetInfo(ADDRESS_HOME_CITY, ASCIIToUTF16("Mountain View"), "en-US"); |
| profile.SetInfo(ADDRESS_HOME_STATE, ASCIIToUTF16("California"), "en-US"); |
| profile.SetInfo(ADDRESS_HOME_COUNTRY, ASCIIToUTF16("US"), "en-US"); |
| personal_data_.AddProfile(profile); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| base::HistogramTester histogram_tester; |
| |
| // Payments should be asked whether upload save can be offered. |
| // (Unit tests assume they reply yes and save is successful.) |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| |
| // Verify that the correct histogram entries were logged. |
| ExpectCardUploadDecision(histogram_tester, AutofillMetrics::UPLOAD_OFFERED); |
| ExpectCardUploadDecision(histogram_tester, |
| AutofillMetrics::UPLOAD_NOT_OFFERED_NO_ZIP_CODE); |
| // Verify that the correct UKM was logged. |
| ExpectMetric(UkmCardUploadDecisionType::kUploadDecisionName, |
| UkmCardUploadDecisionType::kEntryName, |
| AutofillMetrics::UPLOAD_OFFERED | |
| AutofillMetrics::UPLOAD_NOT_OFFERED_NO_ZIP_CODE, |
| 1 /* expected_num_matching_entries */); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, |
| UploadCreditCard_PaymentsDecidesOfferToSaveIfConflictingZips) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Set up two new address profiles with conflicting postal codes. |
| AutofillProfile profile1; |
| profile1.set_guid("00000000-0000-0000-0000-000000000200"); |
| profile1.SetInfo(NAME_FULL, ASCIIToUTF16("Flo Master"), "en-US"); |
| profile1.SetInfo(ADDRESS_HOME_LINE1, ASCIIToUTF16("123 Testing St."), |
| "en-US"); |
| profile1.SetInfo(ADDRESS_HOME_CITY, ASCIIToUTF16("Mountain View"), "en-US"); |
| profile1.SetInfo(ADDRESS_HOME_STATE, ASCIIToUTF16("California"), "en-US"); |
| profile1.SetInfo(ADDRESS_HOME_ZIP, ASCIIToUTF16("94043"), "en-US"); |
| profile1.SetInfo(ADDRESS_HOME_COUNTRY, ASCIIToUTF16("US"), "en-US"); |
| personal_data_.AddProfile(profile1); |
| AutofillProfile profile2; |
| profile2.set_guid("00000000-0000-0000-0000-000000000201"); |
| profile2.SetInfo(NAME_FULL, ASCIIToUTF16("Flo Master"), "en-US"); |
| profile2.SetInfo(ADDRESS_HOME_LINE1, ASCIIToUTF16("234 Other Place"), |
| "en-US"); |
| profile2.SetInfo(ADDRESS_HOME_CITY, ASCIIToUTF16("Fake City"), "en-US"); |
| profile2.SetInfo(ADDRESS_HOME_STATE, ASCIIToUTF16("Stateland"), "en-US"); |
| profile2.SetInfo(ADDRESS_HOME_ZIP, ASCIIToUTF16("12345"), "en-US"); |
| profile2.SetInfo(ADDRESS_HOME_COUNTRY, ASCIIToUTF16("US"), "en-US"); |
| personal_data_.AddProfile(profile2); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| base::HistogramTester histogram_tester; |
| |
| // Payments should be asked whether upload save can be offered. |
| // (Unit tests assume they reply yes and save is successful.) |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| |
| // Verify that the correct histogram entries were logged. |
| ExpectCardUploadDecision(histogram_tester, AutofillMetrics::UPLOAD_OFFERED); |
| ExpectCardUploadDecision( |
| histogram_tester, AutofillMetrics::UPLOAD_NOT_OFFERED_CONFLICTING_ZIPS); |
| // Verify that the correct UKM was logged. |
| ExpectMetric(UkmCardUploadDecisionType::kUploadDecisionName, |
| UkmCardUploadDecisionType::kEntryName, |
| AutofillMetrics::UPLOAD_OFFERED | |
| AutofillMetrics::UPLOAD_NOT_OFFERED_CONFLICTING_ZIPS, |
| 1 /* expected_num_matching_entries */); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, |
| UploadCreditCard_PaymentsDecidesOfferToSaveIfNothingFound) { |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Set up a new address profile without a name or postal code. |
| AutofillProfile profile; |
| profile.set_guid("00000000-0000-0000-0000-000000000200"); |
| profile.SetInfo(ADDRESS_HOME_LINE1, ASCIIToUTF16("123 Testing St."), "en-US"); |
| profile.SetInfo(ADDRESS_HOME_CITY, ASCIIToUTF16("Mountain View"), "en-US"); |
| profile.SetInfo(ADDRESS_HOME_STATE, ASCIIToUTF16("California"), "en-US"); |
| profile.SetInfo(ADDRESS_HOME_COUNTRY, ASCIIToUTF16("US"), "en-US"); |
| personal_data_.AddProfile(profile); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16(""); // No name! |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16(""); // No CVC! |
| |
| base::HistogramTester histogram_tester; |
| |
| // Payments should be asked whether upload save can be offered. |
| // (Unit tests assume they reply yes and save is successful.) |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| |
| // Verify that the correct histogram entries were logged. |
| ExpectCardUploadDecision(histogram_tester, AutofillMetrics::UPLOAD_OFFERED); |
| ExpectCardUploadDecision(histogram_tester, |
| AutofillMetrics::CVC_VALUE_NOT_FOUND); |
| ExpectCardUploadDecision(histogram_tester, |
| AutofillMetrics::UPLOAD_NOT_OFFERED_NO_NAME); |
| ExpectCardUploadDecision(histogram_tester, |
| AutofillMetrics::UPLOAD_NOT_OFFERED_NO_ZIP_CODE); |
| // Verify that the correct UKM was logged. |
| ExpectMetric(UkmCardUploadDecisionType::kUploadDecisionName, |
| UkmCardUploadDecisionType::kEntryName, |
| AutofillMetrics::UPLOAD_OFFERED | |
| AutofillMetrics::CVC_VALUE_NOT_FOUND | |
| AutofillMetrics::UPLOAD_NOT_OFFERED_NO_NAME | |
| AutofillMetrics::UPLOAD_NOT_OFFERED_NO_ZIP_CODE, |
| 1 /* expected_num_matching_entries */); |
| } |
| |
| TEST_F( |
| CreditCardSaveManagerTest, |
| UploadCreditCard_AddUpdatePromptExplanationFlagStateToRequestIfExperimentOn) { |
| EnableAutofillUpstreamUpdatePromptExplanationExperiment(); |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Create, fill and submit an address form in order to establish a recent |
| // profile which can be selected for the upload request. |
| FormData address_form; |
| test::CreateTestAddressFormData(&address_form); |
| FormsSeen(std::vector<FormData>(1, address_form)); |
| ManuallyFillAddressForm("Flo", "Master", "77401", "US", &address_form); |
| FormSubmitted(address_form); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4444333322221111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| // Confirm upload happened and that the enabled UpdatePromptExplanation |
| // experiment flag state was sent in the request. |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| EXPECT_THAT( |
| payments_client_->active_experiments_in_request(), |
| UnorderedElementsAre(kAutofillUpstreamUpdatePromptExplanation.name)); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, |
| UploadCreditCard_DoNotAddAnyFlagStatesToRequestIfExperimentsOff) { |
| DisableAutofillUpstreamUpdatePromptExplanationExperiment(); |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Create, fill and submit an address form in order to establish a recent |
| // profile which can be selected for the upload request. |
| FormData address_form; |
| test::CreateTestAddressFormData(&address_form); |
| FormsSeen(std::vector<FormData>(1, address_form)); |
| ManuallyFillAddressForm("Flo", "Master", "77401", "US", &address_form); |
| FormSubmitted(address_form); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| // Confirm that upload happened and that no experiment flag state was sent in |
| // the request. |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| EXPECT_TRUE(payments_client_->active_experiments_in_request().empty()); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, UploadCreditCard_AddPanFirstSixToRequest) { |
| EnableAutofillUpstreamSendPanFirstSixExperiment(); |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Create, fill and submit an address form in order to establish a recent |
| // profile which can be selected for the upload request. |
| FormData address_form; |
| test::CreateTestAddressFormData(&address_form); |
| FormsSeen(std::vector<FormData>(1, address_form)); |
| ManuallyFillAddressForm("Flo", "Master", "77401", "US", &address_form); |
| FormSubmitted(address_form); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4444333322221111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| // Confirm that the first six digits of the credit card number were included |
| // in the request. |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| EXPECT_EQ(payments_client_->pan_first_six_in_upload_details(), "444433"); |
| // Confirm that the "send pan first six" experiment flag and enabled |
| // UpdatePromptExplanation experiment flag state was sent in the request. |
| EXPECT_THAT( |
| payments_client_->active_experiments_in_request(), |
| UnorderedElementsAre(kAutofillUpstreamSendPanFirstSix.name, |
| kAutofillUpstreamUpdatePromptExplanation.name)); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, UploadCreditCard_UploadOfLocalCard) { |
| personal_data_.ClearCreditCards(); |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Add a local credit card whose |TypeAndLastFourDigits| matches what we will |
| // enter below. |
| CreditCard local_card; |
| test::SetCreditCardInfo(&local_card, "Flo Master", "4111111111111111", |
| NextMonth().c_str(), NextYear().c_str(), "1"); |
| local_card.set_record_type(CreditCard::LOCAL_CARD); |
| personal_data_.AddCreditCard(local_card); |
| |
| // Create, fill and submit an address form in order to establish a recent |
| // profile which can be selected for the upload request. |
| FormData address_form; |
| test::CreateTestAddressFormData(&address_form); |
| FormsSeen(std::vector<FormData>(1, address_form)); |
| ExpectUniqueFillableFormParsedUkm(); |
| |
| ManuallyFillAddressForm("Flo", "Master", "77401", "US", &address_form); |
| FormSubmitted(address_form); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| ExpectFillableFormParsedUkm(2 /* num_fillable_forms_parsed */); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| base::HistogramTester histogram_tester; |
| |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| |
| // Verify that metrics noted it was an existing local card for which credit |
| // card upload was offered and accepted. |
| histogram_tester.ExpectUniqueSample( |
| "Autofill.UploadOfferedCardOrigin", |
| AutofillMetrics::OFFERING_UPLOAD_OF_LOCAL_CARD, 1); |
| histogram_tester.ExpectUniqueSample( |
| "Autofill.UploadAcceptedCardOrigin", |
| AutofillMetrics::USER_ACCEPTED_UPLOAD_OF_LOCAL_CARD, 1); |
| } |
| |
| TEST_F(CreditCardSaveManagerTest, UploadCreditCard_UploadOfNewCard) { |
| // No cards already on the device. |
| personal_data_.ClearCreditCards(); |
| personal_data_.ClearProfiles(); |
| credit_card_save_manager_->SetCreditCardUploadEnabled(true); |
| |
| // Create, fill and submit an address form in order to establish a recent |
| // profile which can be selected for the upload request. |
| FormData address_form; |
| test::CreateTestAddressFormData(&address_form); |
| FormsSeen(std::vector<FormData>(1, address_form)); |
| ExpectUniqueFillableFormParsedUkm(); |
| |
| ManuallyFillAddressForm("Flo", "Master", "77401", "US", &address_form); |
| FormSubmitted(address_form); |
| |
| // Set up our credit card form data. |
| FormData credit_card_form; |
| CreateTestCreditCardFormData(&credit_card_form, true, false); |
| FormsSeen(std::vector<FormData>(1, credit_card_form)); |
| ExpectFillableFormParsedUkm(2 /* num_fillable_forms_parsed */); |
| |
| // Edit the data, and submit. |
| credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); |
| credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); |
| credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); |
| credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); |
| credit_card_form.fields[4].value = ASCIIToUTF16("123"); |
| |
| base::HistogramTester histogram_tester; |
| |
| EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); |
| FormSubmitted(credit_card_form); |
| EXPECT_TRUE(credit_card_save_manager_->CreditCardWasUploaded()); |
| |
| // Verify that metrics noted it was a brand new card for which credit card |
| // upload was offered and accepted. |
| histogram_tester.ExpectUniqueSample( |
| "Autofill.UploadOfferedCardOrigin", |
| AutofillMetrics::OFFERING_UPLOAD_OF_NEW_CARD, 1); |
| histogram_tester.ExpectUniqueSample( |
| "Autofill.UploadAcceptedCardOrigin", |
| AutofillMetrics::USER_ACCEPTED_UPLOAD_OF_NEW_CARD, 1); |
| } |
| |
| } // namespace autofill |
