commit 7ba57f898a5173c4499096c529ac692bd6c7d727
author Ahmed Fakhry <afakhry@chromium.org> Thu Jan 17 00:04:53 2019
committer Commit Bot <commit-bot@chromium.org> Thu Jan 17 00:04:53 2019
tree bd677359349581c63c32d0ee4d655c2f67184b4c
parent 58de8b4820c917c979991ade306c4d09165349a6

Revert "[omnibox chrome:omnibox] Add checkbox to toggle cell eliding"

This reverts commit 3200e3e7f3e60874cb93faf451cef850f9b80054.

Reason for revert: Breaks compile on linux-chromeos-rel

BUG=922820

Original change's description:
> [omnibox chrome:omnibox] Add checkbox to toggle cell eliding
> 
> Bug: 891303
> Change-Id: I25ac8d8897d388e8f9fd92e0f175d878683ca83e
> Reviewed-on: https://chromium-review.googlesource.com/c/1407772
> Commit-Queue: manuk hovanesian <manukh@chromium.org>
> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#623452}

TBR=jdonnelly@chromium.org,manukh@chromium.org

Change-Id: Ib9f7544c7d79efbfe5ea07964267ae3d01b52f22
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 891303
Reviewed-on: https://chromium-review.googlesource.com/c/1416816
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623459}

chrome/browser/resources/omnibox/omnibox.html

diff --git a/chrome/browser/resources/omnibox/omnibox.html b/chrome/browser/resources/omnibox/omnibox.html
index 60b35f52..c604afd 100644
--- a/chrome/browser/resources/omnibox/omnibox.html
+++ b/chrome/browser/resources/omnibox/omnibox.html
@@ -149,14 +149,6 @@
             </span>
           </label>
         </div>
-        <div class="row">
-          <label class="checkbox-container">
-            <input id="elide-cells" type="checkbox" accesskey="s">
-            <span>
-              Elide Cell<span class="accesskey">s</span>
-            </span>
-          </label>
-        </div>
       </div>
 
       <div class="top-column">

chrome/browser/resources/omnibox/omnibox_input.js

diff --git a/chrome/browser/resources/omnibox/omnibox_input.js b/chrome/browser/resources/omnibox/omnibox_input.js
index ae47acd..39b6b56 100644
--- a/chrome/browser/resources/omnibox/omnibox_input.js
+++ b/chrome/browser/resources/omnibox/omnibox_input.js
@@ -22,7 +22,6 @@
  *   showIncompleteResults: boolean,
  *   showDetails: boolean,
  *   showAllProviders: boolean,
- *   elideCells: boolean,
  * }}
  */
 let DisplayInputs;
@@ -71,7 +70,6 @@
       showIncompleteResults: this.$$('#show-incomplete-results').checked,
       showDetails: this.$$('#show-details').checked,
       showAllProviders: this.$$('#show-all-providers').checked,
-      elideCells: this.$$('#elide-cells').checked,
     };
   }
 
@@ -81,7 +79,6 @@
         displayInputs.showIncompleteResults;
     this.$$('#show-details').checked = displayInputs.showDetails;
     this.$$('#show-all-providers').checked = displayInputs.showAllProviders;
-    this.$$('#elide-cells').checked = displayInputs.elideCells;
   }
 
   /** @override */
@@ -107,7 +104,6 @@
     ['#show-incomplete-results',
      '#show-details',
      '#show-all-providers',
-     '#elide-cells',
     ]
         .forEach(
             query => this.$$(query).addEventListener(
@@ -283,7 +279,6 @@
       showIncompleteResults: false,
       showDetails: false,
       showAllProviders: true,
-      elideCells: true,
     };
   }
 }

chrome/browser/resources/omnibox/omnibox_output.js

diff --git a/chrome/browser/resources/omnibox/omnibox_output.js b/chrome/browser/resources/omnibox/omnibox_output.js
index f31d9339..ed4dbef 100644
--- a/chrome/browser/resources/omnibox/omnibox_output.js
+++ b/chrome/browser/resources/omnibox/omnibox_output.js
@@ -48,7 +48,6 @@
     updateDisplayInputs(displayInputs) {
       this.displayInputs_ = displayInputs;
       this.updateVisibility_();
-      this.updateEliding_();
     }
 
     /** @param {string} filterText */
@@ -147,13 +146,6 @@
     }
 
     /** @private */
-    updateEliding_() {
-      this.resultsGroups_.forEach(
-          resultsGroup =>
-              resultsGroup.updateEliding(this.displayInputs_.elideCells));
-    }
-
-    /** @private */
     updateFilterHighlights_() {
       this.autocompleteMatches.forEach(match => match.filter(this.filterText_));
     }
@@ -307,11 +299,6 @@
           match => match.updateVisibility(showDetails));
     }
 
-    /** @param {boolean} elideCells */
-    updateEliding(elideCells) {
-      this.matches.forEach(match => match.updateEliding(elideCells));
-    }
-
     /**
      * @private
      * @return {boolean}
@@ -470,12 +457,6 @@
       });
     }
 
-    /** @param {boolean} elideCells */
-    updateEliding(elideCells) {
-      Object.values(this.properties)
-          .forEach(property => property.classList.toggle('elided', elideCells));
-    }
-
     /** @param {string} filterText */
     filter(filterText) {
       this.classList.remove('filtered-highlighted');

chrome/browser/resources/omnibox/output_results_group.css

diff --git a/chrome/browser/resources/omnibox/output_results_group.css b/chrome/browser/resources/omnibox/output_results_group.css
index ebc1f06..275aab3c 100644
--- a/chrome/browser/resources/omnibox/output_results_group.css
+++ b/chrome/browser/resources/omnibox/output_results_group.css
@@ -52,7 +52,7 @@
   overflow: hidden;
 }
 
-.body td.elided:not(:hover) {
+.body td:not(:hover) {
   white-space: nowrap;
 }