| commit | 85f990665b1c6a88644beef439020cd82566382e | [log] [tgz] |
|---|---|---|
| author | Robbie McElrath <rmcelrath@chromium.org> | Wed Feb 20 18:54:15 2019 |
| committer | Commit Bot <commit-bot@chromium.org> | Wed Feb 20 18:54:15 2019 |
| tree | 3acf184c1e722a3e5588d538f014bf63da3d457e | |
| parent | 669a04e0a810b31461349ad6b333679b57cc5d60 [diff] |
Fix MultiProfileDownloadNotificationTest.DownloadMultipleFiles flakiness This test occasionally crashes with the network service enabled because a request hits the Interceptor after its been deleted. Change-Id: Ib09e8c6cdf1208ced3297af37e2261c880bae0f1 Reviewed-on: https://chromium-review.googlesource.com/c/1478307 Reviewed-by: Min Qin <qinmin@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#633809}
diff --git a/chrome/browser/download/notification/download_notification_browsertest.cc b/chrome/browser/download/notification/download_notification_browsertest.cc index faf2dc8..1cb4575 100644 --- a/chrome/browser/download/notification/download_notification_browsertest.cc +++ b/chrome/browser/download/notification/download_notification_browsertest.cc
@@ -286,7 +286,11 @@ } } - void TearDownOnMainThread() override { interceptor_.reset(); } + void TearDownOnMainThread() override { + // Make sure any pending requests have finished. + base::RunLoop().RunUntilIdle(); + interceptor_.reset(); + } protected: content::DownloadManager* GetDownloadManager(Browser* browser) {