components/dom_distiller/core/dom_distiller_request_view_base_unittest.cc

// Copyright 2015 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include <vector>

#include "components/dom_distiller/core/article_distillation_update.h"
#include "components/dom_distiller/core/test_request_view_handle.h"
#include "components/grit/components_resources.h"
#include "components/strings/grit/components_strings.h"
#include "components/sync_preferences/testing_pref_service_syncable.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/base/l10n/l10n_util.h"

using testing::HasSubstr;
using testing::Not;

namespace dom_distiller {

class DomDistillerRequestViewTest : public testing::Test {
 protected:
  void SetUp() override {
    pref_service_.reset(new sync_preferences::TestingPrefServiceSyncable());
    DistilledPagePrefs::RegisterProfilePrefs(pref_service_->registry());
    distilled_page_prefs_.reset(new DistilledPagePrefs(pref_service_.get()));
  }

  std::unique_ptr<sync_preferences::TestingPrefServiceSyncable> pref_service_;
  std::unique_ptr<DistilledPagePrefs> distilled_page_prefs_;
};

TEST_F(DomDistillerRequestViewTest, TestTitleEscaped) {
  const std::string valid_title = "valid title";
  const std::string has_quotes = "\"" + valid_title + "\"";
  const std::string escaped_quotes = "\\\"" + valid_title + "\\\"";
  const std::string has_special_chars = "<" + valid_title + "\\";
  const std::string escaped_special_chars = "\\u003C" + valid_title + "\\\\";

  TestRequestViewHandle handle(distilled_page_prefs_.get());

  // Make sure title is properly escaped from quotes.
  {
    std::unique_ptr<DistilledArticleProto> article_proto(
        new DistilledArticleProto());
    article_proto->set_title(has_quotes);

    handle.OnArticleReady(article_proto.get());

    EXPECT_THAT(handle.GetJavaScriptBuffer(), HasSubstr(escaped_quotes));
    EXPECT_THAT(handle.GetJavaScriptBuffer(), Not(HasSubstr(has_quotes)));
    handle.ClearJavaScriptBuffer();
  }

  // Make sure title is properly escaped from special characters.
  {
    std::unique_ptr<DistilledArticleProto> article_proto(
        new DistilledArticleProto());
    article_proto->set_title(has_special_chars);

    handle.OnArticleReady(article_proto.get());

    EXPECT_THAT(handle.GetJavaScriptBuffer(), HasSubstr(escaped_special_chars));
    EXPECT_THAT(handle.GetJavaScriptBuffer(),
                Not(HasSubstr(has_special_chars)));
    handle.ClearJavaScriptBuffer();
  }

}

TEST_F(DomDistillerRequestViewTest, TestTitleNeverEmpty) {
  const std::string valid_title = "valid title";

  TestRequestViewHandle handle(distilled_page_prefs_.get());

  // Test that the title actually gets shown.
  {
    std::unique_ptr<DistilledArticleProto> article_proto(
        new DistilledArticleProto());
    article_proto->set_title(valid_title);

    handle.OnArticleReady(article_proto.get());

    EXPECT_THAT(handle.GetJavaScriptBuffer(), HasSubstr(valid_title));
    handle.ClearJavaScriptBuffer();
  }

  // Test empty string title
  {
    std::unique_ptr<DistilledArticleProto> article_proto(
        new DistilledArticleProto());
    article_proto->set_title("");

    handle.OnArticleReady(article_proto.get());

    EXPECT_THAT(handle.GetJavaScriptBuffer(), Not(HasSubstr(valid_title)));
    handle.ClearJavaScriptBuffer();
  }

  // Test no title.
  {
    std::unique_ptr<DistilledArticleProto> article_proto(
        new DistilledArticleProto());

    handle.OnArticleReady(article_proto.get());

    EXPECT_THAT(handle.GetJavaScriptBuffer(), Not(HasSubstr(valid_title)));
    handle.ClearJavaScriptBuffer();
  }
}

TEST_F(DomDistillerRequestViewTest, TestContentNeverEmpty) {
  const std::string no_content =
      l10n_util::GetStringUTF8(IDS_DOM_DISTILLER_VIEWER_NO_DATA_CONTENT);
  const std::string valid_content = "valid content";

  TestRequestViewHandle handle(distilled_page_prefs_.get());

  // Test single page content
  {
    std::unique_ptr<DistilledArticleProto> article_proto(
        new DistilledArticleProto());
    (*(article_proto->add_pages())).set_html(valid_content);

    handle.OnArticleReady(article_proto.get());

    EXPECT_THAT(handle.GetJavaScriptBuffer(), HasSubstr(valid_content));
    EXPECT_THAT(handle.GetJavaScriptBuffer(), Not(HasSubstr(no_content)));
    handle.ClearJavaScriptBuffer();
  }

  // Test multiple page content
  {
    std::unique_ptr<DistilledArticleProto> article_proto(
        new DistilledArticleProto());
    (*(article_proto->add_pages())).set_html(valid_content);
    (*(article_proto->add_pages())).set_html(valid_content);

    handle.OnArticleReady(article_proto.get());

    EXPECT_THAT(handle.GetJavaScriptBuffer(),
                HasSubstr(valid_content + valid_content));
    EXPECT_THAT(handle.GetJavaScriptBuffer(), Not(HasSubstr(no_content)));
    handle.ClearJavaScriptBuffer();
  }

  // Test empty string content
  {
    std::unique_ptr<DistilledArticleProto> article_proto(
        new DistilledArticleProto());
    (*(article_proto->add_pages())).set_html("");

    handle.OnArticleReady(article_proto.get());

    EXPECT_THAT(handle.GetJavaScriptBuffer(), HasSubstr(no_content));
    EXPECT_THAT(handle.GetJavaScriptBuffer(), Not(HasSubstr(valid_content)));
    handle.ClearJavaScriptBuffer();
  }

  // Test page no content
  {
    std::unique_ptr<DistilledArticleProto> article_proto(
        new DistilledArticleProto());
    article_proto->add_pages();

    handle.OnArticleReady(article_proto.get());

    EXPECT_THAT(handle.GetJavaScriptBuffer(), HasSubstr(no_content));
    EXPECT_THAT(handle.GetJavaScriptBuffer(), Not(HasSubstr(valid_content)));
    handle.ClearJavaScriptBuffer();
  }

  // Test no page.
  {
    std::unique_ptr<DistilledArticleProto> article_proto(
        new DistilledArticleProto());

    handle.OnArticleReady(article_proto.get());

    EXPECT_THAT(handle.GetJavaScriptBuffer(), HasSubstr(no_content));
    EXPECT_THAT(handle.GetJavaScriptBuffer(), Not(HasSubstr(valid_content)));
    handle.ClearJavaScriptBuffer();
  }

  // Test empty string page update
  {
    std::vector<scoped_refptr<ArticleDistillationUpdate::RefCountedPageProto>>
        pages;
    scoped_refptr<base::RefCountedData<DistilledPageProto>> page_proto =
        new base::RefCountedData<DistilledPageProto>();
    page_proto->data.set_html("");
    pages.push_back(page_proto);

    std::unique_ptr<ArticleDistillationUpdate> article_update(
        new ArticleDistillationUpdate(pages, false, false));

    handle.OnArticleUpdated(*article_update);

    EXPECT_THAT(handle.GetJavaScriptBuffer(), HasSubstr(no_content));
    EXPECT_THAT(handle.GetJavaScriptBuffer(), Not(HasSubstr(valid_content)));
    handle.ClearJavaScriptBuffer();
  }
}

TEST_F(DomDistillerRequestViewTest, TestLoadingIndicator) {
  const std::string no_content =
      l10n_util::GetStringUTF8(IDS_DOM_DISTILLER_VIEWER_NO_DATA_CONTENT);
  // Showing the indicator does mean passing 'false' as the parameter.
  const std::string show_loader = "showLoadingIndicator(false);";

  TestRequestViewHandle handle(distilled_page_prefs_.get());
  handle.TakeViewerHandle(nullptr);

  std::vector<scoped_refptr<ArticleDistillationUpdate::RefCountedPageProto>>
      pages;
  scoped_refptr<base::RefCountedData<DistilledPageProto>> page_proto =
      new base::RefCountedData<DistilledPageProto>();
  pages.push_back(page_proto);

  std::unique_ptr<ArticleDistillationUpdate> article_update(
      new ArticleDistillationUpdate(pages, true, false));

  handle.OnArticleUpdated(*article_update);

  EXPECT_THAT(handle.GetJavaScriptBuffer(), HasSubstr(show_loader));
}

}  // namespace dom_distiller