Google Git
Sign in
chromium / chromium / src / 8c3c7f80a11cde75fb92bddd9375bcf04943f53f
commit8c3c7f80a11cde75fb92bddd9375bcf04943f53f[log] [tgz]
authorFergal Daly <fergal@chromium.org>Wed Jan 19 02:19:01 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jan 19 02:19:01 2022
tree47d557a47edb85094d87951dc3ecab5cb86ec256
parenta8ab152bea548cbc0cc423b3449b4987317a3c78 [diff]
Check the return value of AddTabAtIndex(ToBrowser) in tests.

Final goal is to mark WaitForLoadStop as WARN_IF_UNUSED.

This adds ASSERT_TRUE/FALSE to all calls such that tests continue to
pass (except in non-void functions which must use EXPECT instead).

This CL is a split of https://crrev.com/c/2852829.
It covers /chrome/browser/ui/views

I'm splitting into many to avoid one rollback undoing the whole thing
as some of these may turn out to be flaky.

There are 37 CLs covering 161 call-sites in total, I cannot
investigate why individual cases are unexpectedly TRUE/FALSE. Unless
you think it indicates a bug in the test infrastructure, please
approve and investigate the unexpected cases of your directory in
follow-on bugs/CLs.

This CL was uploaded by git cl split.

R=collinbaker@chromium.org

Bug: 1014186,425335
Change-Id: I476be86c8b06f8e2b1043d938eb9650864b64401
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3394395
Auto-Submit: Fergal Daly <fergal@chromium.org>
Reviewed-by: Collin Baker <collinbaker@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/main@{#960758}
1 file changed
tree: 47d557a47edb85094d87951dc3ecab5cb86ec256
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython
  63. .vpython3
  64. .yapfignore
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. ENG_REVIEW_OWNERS
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.