| // Copyright 2024 The Chromium Authors |
| // Use of this source code is governed by a BSD-style license that can be |
| // found in the LICENSE file. |
| |
| #include "chrome/browser/bookmarks/permanent_folder_ordering_tracker.h" |
| |
| #include <cstddef> |
| |
| #include "base/strings/utf_ostream_operators.h" |
| #include "base/test/scoped_feature_list.h" |
| #include "chrome/browser/bookmarks/bookmark_test_helpers.h" |
| #include "components/bookmarks/browser/bookmark_model.h" |
| #include "components/bookmarks/browser/bookmark_node.h" |
| #include "components/bookmarks/test/bookmark_test_helpers.h" |
| #include "components/bookmarks/test/test_bookmark_client.h" |
| #include "components/bookmarks/test/test_matchers.h" |
| #include "components/signin/public/base/signin_switches.h" |
| #include "testing/gmock/include/gmock/gmock.h" |
| #include "testing/gtest/include/gtest/gtest.h" |
| |
| namespace { |
| |
| using bookmarks::BookmarkModel; |
| using bookmarks::BookmarkNode; |
| using bookmarks::BookmarkNodeData; |
| using bookmarks::test::AddNodesFromModelString; |
| using bookmarks::test::IsFolder; |
| using bookmarks::test::IsUrlBookmark; |
| using bookmarks::test::ModelStringFromNode; |
| using testing::AtLeast; |
| using testing::ElementsAre; |
| using testing::Mock; |
| using testing::Optional; |
| using testing::UnorderedElementsAre; |
| |
| MATCHER_P(HasChildren, children_matcher, "") { |
| std::vector<const BookmarkNode*> children; |
| for (size_t i = 0; i < arg.GetChildrenCount(); i++) { |
| children.push_back(arg.GetNodeAtIndex(i)); |
| } |
| return testing::ExplainMatchResult(children_matcher, children, |
| result_listener); |
| } |
| |
| class PermanentFolderOrderingTrackerTest : public testing::Test { |
| public: |
| PermanentFolderOrderingTrackerTest() { ResetModel(); } |
| |
| BookmarkModel& model() { return *model_; } |
| |
| MockPermanentFolderOrderingTrackerDelegate* delegate() { return &delegate_; } |
| |
| void ResetModel() { |
| model_ = std::make_unique<BookmarkModel>( |
| std::make_unique<bookmarks::TestBookmarkClient>()); |
| } |
| |
| private: |
| base::test::ScopedFeatureList features_{ |
| switches::kSyncEnableBookmarksInTransportMode}; |
| std::unique_ptr<BookmarkModel> model_; |
| testing::NiceMock<MockPermanentFolderOrderingTrackerDelegate> delegate_; |
| }; |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, |
| GetUnderlyingPermanentNodesModelLoadedNoAccountNodes) { |
| model().LoadEmptyForTest(); |
| ASSERT_FALSE(model().account_bookmark_bar_node()); |
| { |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged); |
| tracker.Init(/*in_order_node_ids=*/{}); |
| EXPECT_THAT(tracker.GetUnderlyingPermanentNodes(), |
| UnorderedElementsAre(model().bookmark_bar_node())); |
| EXPECT_FALSE(tracker.IsNonDefaultOrderingTracked()); |
| Mock::VerifyAndClearExpectations(delegate()); |
| } |
| |
| { |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::OTHER_NODE, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged); |
| tracker.Init(/*in_order_node_ids=*/{}); |
| EXPECT_THAT(tracker.GetUnderlyingPermanentNodes(), |
| UnorderedElementsAre(model().other_node())); |
| EXPECT_FALSE(tracker.IsNonDefaultOrderingTracked()); |
| Mock::VerifyAndClearExpectations(delegate()); |
| } |
| |
| { |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::MOBILE, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged); |
| tracker.Init(/*in_order_node_ids=*/{}); |
| EXPECT_THAT(tracker.GetUnderlyingPermanentNodes(), |
| UnorderedElementsAre(model().mobile_node())); |
| EXPECT_FALSE(tracker.IsNonDefaultOrderingTracked()); |
| Mock::VerifyAndClearExpectations(delegate()); |
| } |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, |
| GetUnderlyingPermanentNodesModelNotLoadedNoAccountNodes) { |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged); |
| tracker.Init(/*in_order_node_ids=*/{}); |
| model().LoadEmptyForTest(); |
| ASSERT_FALSE(model().account_bookmark_bar_node()); |
| EXPECT_THAT(tracker.GetUnderlyingPermanentNodes(), |
| UnorderedElementsAre(model().bookmark_bar_node())); |
| EXPECT_FALSE(tracker.IsNonDefaultOrderingTracked()); |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, |
| GetUnderlyingPermanentNodesModelLoadedAccountNodes) { |
| model().LoadEmptyForTest(); |
| model().CreateAccountPermanentFolders(); |
| ASSERT_TRUE(model().account_bookmark_bar_node()); |
| |
| { |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged); |
| tracker.Init(/*in_order_node_ids=*/{}); |
| |
| EXPECT_THAT(tracker.GetUnderlyingPermanentNodes(), |
| UnorderedElementsAre(model().account_bookmark_bar_node(), |
| model().bookmark_bar_node())); |
| EXPECT_FALSE(tracker.IsNonDefaultOrderingTracked()); |
| Mock::VerifyAndClearExpectations(delegate()); |
| } |
| |
| { |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::OTHER_NODE, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged); |
| tracker.Init(/*in_order_node_ids=*/{}); |
| EXPECT_THAT(tracker.GetUnderlyingPermanentNodes(), |
| UnorderedElementsAre(model().account_other_node(), |
| model().other_node())); |
| EXPECT_FALSE(tracker.IsNonDefaultOrderingTracked()); |
| Mock::VerifyAndClearExpectations(delegate()); |
| } |
| |
| { |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::MOBILE, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged); |
| tracker.Init(/*in_order_node_ids=*/{}); |
| EXPECT_THAT(tracker.GetUnderlyingPermanentNodes(), |
| UnorderedElementsAre(model().account_mobile_node(), |
| model().mobile_node())); |
| EXPECT_FALSE(tracker.IsNonDefaultOrderingTracked()); |
| Mock::VerifyAndClearExpectations(delegate()); |
| } |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, |
| GetUnderlyingPermanentNodesAccountNodesCreatedLater) { |
| { |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(2); |
| tracker.Init(/*in_order_node_ids=*/{}); |
| model().LoadEmptyForTest(); |
| ASSERT_FALSE(model().account_bookmark_bar_node()); |
| ASSERT_THAT(tracker.GetUnderlyingPermanentNodes(), |
| UnorderedElementsAre(model().bookmark_bar_node())); |
| model().CreateAccountPermanentFolders(); |
| ASSERT_TRUE(model().account_bookmark_bar_node()); |
| EXPECT_THAT(tracker.GetUnderlyingPermanentNodes(), |
| UnorderedElementsAre(model().account_bookmark_bar_node(), |
| model().bookmark_bar_node())); |
| Mock::VerifyAndClearExpectations(delegate()); |
| } |
| |
| ResetModel(); |
| { |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::OTHER_NODE, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(2); |
| tracker.Init(/*in_order_node_ids=*/{}); |
| model().LoadEmptyForTest(); |
| ASSERT_FALSE(model().account_other_node()); |
| ASSERT_THAT(tracker.GetUnderlyingPermanentNodes(), |
| UnorderedElementsAre(model().other_node())); |
| model().CreateAccountPermanentFolders(); |
| ASSERT_TRUE(model().account_other_node()); |
| EXPECT_THAT(tracker.GetUnderlyingPermanentNodes(), |
| UnorderedElementsAre(model().account_other_node(), |
| model().other_node())); |
| Mock::VerifyAndClearExpectations(delegate()); |
| } |
| |
| ResetModel(); |
| { |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::MOBILE, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(2); |
| tracker.Init(/*in_order_node_ids=*/{}); |
| model().LoadEmptyForTest(); |
| ASSERT_FALSE(model().account_mobile_node()); |
| ASSERT_THAT(tracker.GetUnderlyingPermanentNodes(), |
| UnorderedElementsAre(model().mobile_node())); |
| model().CreateAccountPermanentFolders(); |
| ASSERT_TRUE(model().account_mobile_node()); |
| EXPECT_THAT(tracker.GetUnderlyingPermanentNodes(), |
| UnorderedElementsAre(model().account_mobile_node(), |
| model().mobile_node())); |
| Mock::VerifyAndClearExpectations(delegate()); |
| } |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, |
| GetUnderlyingPermanentNodesAccountPermanentFoldersRemoved) { |
| model().LoadEmptyForTest(); |
| model().CreateAccountPermanentFolders(); |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(2); |
| tracker.Init(/*in_order_node_ids=*/{}); |
| ASSERT_THAT(tracker.GetUnderlyingPermanentNodes(), |
| UnorderedElementsAre(model().account_bookmark_bar_node(), |
| model().bookmark_bar_node())); |
| |
| // Remove account permanent folders. |
| model().RemoveAccountPermanentFolders(); |
| EXPECT_THAT(tracker.GetUnderlyingPermanentNodes(), |
| UnorderedElementsAre(model().bookmark_bar_node())); |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, GetDefaultParentForNewNodes) { |
| model().LoadEmptyForTest(); |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(3); |
| tracker.Init(/*in_order_node_ids=*/{}); |
| EXPECT_EQ(tracker.GetDefaultParentForNewNodes(), model().bookmark_bar_node()); |
| |
| model().CreateAccountPermanentFolders(); |
| EXPECT_EQ(tracker.GetDefaultParentForNewNodes(), |
| model().account_bookmark_bar_node()); |
| |
| // Remove account permanent folders. |
| model().RemoveAccountPermanentFolders(); |
| EXPECT_EQ(tracker.GetDefaultParentForNewNodes(), model().bookmark_bar_node()); |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, GetIndexOfNoAccountFolder) { |
| model().LoadEmptyForTest(); |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged); |
| tracker.Init(/*in_order_node_ids=*/{}); |
| ASSERT_THAT(tracker.GetUnderlyingPermanentNodes(), |
| UnorderedElementsAre(model().bookmark_bar_node())); |
| AddNodesFromModelString(&model(), model().bookmark_bar_node(), |
| "1 2 3 f1:[ 4 5 ]"); |
| EXPECT_EQ(tracker.GetChildrenCount(), |
| model().bookmark_bar_node()->children().size()); |
| for (size_t i = 0; i < model().bookmark_bar_node()->children().size(); i++) { |
| const BookmarkNode* node = model().bookmark_bar_node()->children()[i].get(); |
| EXPECT_EQ(tracker.GetIndexOf(node), i); |
| } |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, OrderingDefault) { |
| model().LoadEmptyForTest(); |
| model().CreateAccountPermanentFolders(); |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::OTHER_NODE, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(AtLeast(1)); |
| tracker.Init(/*in_order_node_ids=*/{}); |
| ASSERT_THAT( |
| tracker.GetUnderlyingPermanentNodes(), |
| UnorderedElementsAre(model().account_other_node(), model().other_node())); |
| AddNodesFromModelString(&model(), model().other_node(), |
| "1 2 3 f1:[ 4 5 f2:[ 6 ] ]"); |
| AddNodesFromModelString(&model(), model().account_other_node(), |
| "1 2 3 f1:[ 4 5 f2:[ 6 ] ]"); |
| EXPECT_EQ(tracker.GetChildrenCount(), 8u); |
| for (size_t i = 0; i < model().account_other_node()->children().size(); i++) { |
| const BookmarkNode* node = |
| model().account_other_node()->children()[i].get(); |
| EXPECT_EQ(tracker.GetIndexOf(node), i); |
| EXPECT_EQ(tracker.GetNodeAtIndex(i), node); |
| } |
| |
| size_t account_nodes_size = model().account_other_node()->children().size(); |
| ASSERT_EQ(account_nodes_size, 4u); |
| for (size_t i = 0; i < model().other_node()->children().size(); i++) { |
| const BookmarkNode* node = model().other_node()->children()[i].get(); |
| EXPECT_EQ(tracker.GetIndexOf(node), i + 4); |
| EXPECT_EQ(tracker.GetNodeAtIndex(i + 4), node); |
| } |
| |
| EXPECT_FALSE(tracker.IsNonDefaultOrderingTracked()); |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, OrderingCustomOrder) { |
| model().LoadEmptyForTest(); |
| model().CreateAccountPermanentFolders(); |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| AddNodesFromModelString(&model(), model().bookmark_bar_node(), |
| "A B C L1:[ D E L2:[ F ] ]"); |
| AddNodesFromModelString(&model(), model().account_bookmark_bar_node(), |
| "1 2 3 f1:[ 4 5 f2:[ 6 ] ]"); |
| |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(5); |
| tracker.Init(/*in_order_node_ids=*/ |
| {model().bookmark_bar_node()->children()[0]->id(), |
| model().account_bookmark_bar_node()->children()[0]->id(), |
| model().account_bookmark_bar_node()->children()[1]->id(), |
| model().account_bookmark_bar_node()->children()[2]->id(), |
| model().bookmark_bar_node()->children()[1]->id(), |
| model().bookmark_bar_node()->children()[2]->id(), |
| model().bookmark_bar_node()->children()[3]->id(), |
| model().account_bookmark_bar_node()->children()[3]->id()}); |
| ASSERT_THAT(tracker.GetUnderlyingPermanentNodes(), |
| UnorderedElementsAre(model().account_bookmark_bar_node(), |
| model().bookmark_bar_node())); |
| |
| EXPECT_THAT(tracker, |
| HasChildren(ElementsAre(IsUrlBookmark(u"A"), IsUrlBookmark(u"1"), |
| IsUrlBookmark(u"2"), IsUrlBookmark(u"3"), |
| IsUrlBookmark(u"B"), IsUrlBookmark(u"C"), |
| IsFolder(u"L1"), IsFolder(u"f1")))); |
| |
| // Insert local nodes. |
| model().AddURL(model().bookmark_bar_node(), 1, u"N1", |
| GURL("https://example.com")); |
| // {L0, L01, A0, A1, A2, L1, L2, L3, A3}. |
| EXPECT_THAT( |
| tracker, |
| HasChildren(ElementsAre( |
| IsUrlBookmark(u"A"), IsUrlBookmark(u"N1"), IsUrlBookmark(u"1"), |
| IsUrlBookmark(u"2"), IsUrlBookmark(u"3"), IsUrlBookmark(u"B"), |
| IsUrlBookmark(u"C"), IsFolder(u"L1"), IsFolder(u"f1")))); |
| |
| model().AddURL(model().bookmark_bar_node(), 3, u"N2", |
| GURL("https://example.com")); |
| EXPECT_THAT(tracker, |
| HasChildren(ElementsAre(IsUrlBookmark(u"A"), IsUrlBookmark(u"N1"), |
| IsUrlBookmark(u"1"), IsUrlBookmark(u"2"), |
| IsUrlBookmark(u"3"), IsUrlBookmark(u"B"), |
| IsUrlBookmark(u"N2"), IsUrlBookmark(u"C"), |
| IsFolder(u"L1"), IsFolder(u"f1")))); |
| |
| // Insert account nodes. |
| model().AddURL(model().account_bookmark_bar_node(), 0, u"N3", |
| GURL("https://example.com")); |
| EXPECT_THAT( |
| tracker, |
| HasChildren(ElementsAre( |
| IsUrlBookmark(u"A"), IsUrlBookmark(u"N1"), IsUrlBookmark(u"N3"), |
| IsUrlBookmark(u"1"), IsUrlBookmark(u"2"), IsUrlBookmark(u"3"), |
| IsUrlBookmark(u"B"), IsUrlBookmark(u"N2"), IsUrlBookmark(u"C"), |
| IsFolder(u"L1"), IsFolder(u"f1")))); |
| |
| model().AddURL(model().account_bookmark_bar_node(), 4, u"N4", |
| GURL("https://example.com")); |
| EXPECT_THAT( |
| tracker, |
| HasChildren(ElementsAre( |
| IsUrlBookmark(u"A"), IsUrlBookmark(u"N1"), IsUrlBookmark(u"N3"), |
| IsUrlBookmark(u"1"), IsUrlBookmark(u"2"), IsUrlBookmark(u"3"), |
| IsUrlBookmark(u"N4"), IsUrlBookmark(u"B"), IsUrlBookmark(u"N2"), |
| IsUrlBookmark(u"C"), IsFolder(u"L1"), IsFolder(u"f1")))); |
| |
| EXPECT_TRUE(tracker.IsNonDefaultOrderingTracked()); |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, OrderingLocalOnly) { |
| model().LoadEmptyForTest(); |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged); |
| tracker.Init(/*in_order_node_ids=*/{}); |
| ASSERT_THAT(tracker.GetUnderlyingPermanentNodes(), |
| UnorderedElementsAre(model().bookmark_bar_node())); |
| AddNodesFromModelString(&model(), model().bookmark_bar_node(), |
| "1 2 3 f1:[ 4 5 f2:[ 6 ] ]"); |
| |
| EXPECT_EQ(tracker.GetChildrenCount(), |
| model().bookmark_bar_node()->children().size()); |
| for (size_t i = 0; i < model().bookmark_bar_node()->children().size(); i++) { |
| const BookmarkNode* node = model().bookmark_bar_node()->children()[i].get(); |
| EXPECT_EQ(tracker.GetIndexOf(node), i); |
| EXPECT_EQ(tracker.GetNodeAtIndex(i), node); |
| } |
| |
| // Remove node. |
| model().Remove(model().bookmark_bar_node()->children()[1].get(), |
| bookmarks::metrics::BookmarkEditSource::kOther, FROM_HERE); |
| |
| // Add node. |
| model().AddURL(model().bookmark_bar_node(), 1, u"Title", |
| GURL("https://example.com")); |
| EXPECT_EQ(tracker.GetChildrenCount(), |
| model().bookmark_bar_node()->children().size()); |
| for (size_t i = 0; i < model().bookmark_bar_node()->children().size(); i++) { |
| const BookmarkNode* node = model().bookmark_bar_node()->children()[i].get(); |
| EXPECT_EQ(tracker.GetIndexOf(node), i); |
| EXPECT_EQ(tracker.GetNodeAtIndex(i), node); |
| } |
| EXPECT_FALSE(tracker.IsNonDefaultOrderingTracked()); |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, OrderingAccountOnly) { |
| model().LoadEmptyForTest(); |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(2); |
| tracker.Init(/*in_order_node_ids=*/{}); |
| model().CreateAccountPermanentFolders(); |
| ASSERT_THAT(tracker.GetUnderlyingPermanentNodes(), |
| UnorderedElementsAre(model().account_bookmark_bar_node(), |
| model().bookmark_bar_node())); |
| AddNodesFromModelString(&model(), model().account_bookmark_bar_node(), |
| "1 2 3 f1:[ 4 5 f2:[ 6 ] ]"); |
| |
| EXPECT_EQ(tracker.GetChildrenCount(), |
| model().account_bookmark_bar_node()->children().size()); |
| for (size_t i = 0; i < model().account_bookmark_bar_node()->children().size(); |
| i++) { |
| const BookmarkNode* node = |
| model().account_bookmark_bar_node()->children()[i].get(); |
| EXPECT_EQ(tracker.GetIndexOf(node), i); |
| EXPECT_EQ(tracker.GetNodeAtIndex(i), node); |
| } |
| |
| // Remove node. |
| model().Remove(model().account_bookmark_bar_node()->children()[1].get(), |
| bookmarks::metrics::BookmarkEditSource::kOther, FROM_HERE); |
| |
| // Add node. |
| model().AddURL(model().account_bookmark_bar_node(), 1, u"Title", |
| GURL("https://example.com")); |
| EXPECT_EQ(tracker.GetChildrenCount(), |
| model().account_bookmark_bar_node()->children().size()); |
| for (size_t i = 0; i < model().account_bookmark_bar_node()->children().size(); |
| i++) { |
| const BookmarkNode* node = |
| model().account_bookmark_bar_node()->children()[i].get(); |
| EXPECT_EQ(tracker.GetIndexOf(node), i); |
| EXPECT_EQ(tracker.GetNodeAtIndex(i), node); |
| } |
| EXPECT_FALSE(tracker.IsNonDefaultOrderingTracked()); |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, OrderingExistingLocal) { |
| model().LoadEmptyForTest(); |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(6); |
| tracker.Init(/*in_order_node_ids=*/{}); |
| model().CreateAccountPermanentFolders(); |
| ASSERT_THAT(tracker.GetUnderlyingPermanentNodes(), |
| UnorderedElementsAre(model().account_bookmark_bar_node(), |
| model().bookmark_bar_node())); |
| AddNodesFromModelString(&model(), model().bookmark_bar_node(), |
| "1 2 3 f1:[ 4 5 f2:[ 6 ] ]"); |
| EXPECT_EQ(tracker.GetChildrenCount(), |
| model().bookmark_bar_node()->children().size()); |
| |
| // Add first account bookmark. |
| const BookmarkNode* node = |
| model().AddURL(model().account_bookmark_bar_node(), 0, u"Title x", |
| GURL("https://example.com")); |
| EXPECT_EQ(tracker.GetIndexOf(node), 0u); |
| EXPECT_EQ(tracker.GetNodeAtIndex(0), node); |
| |
| node = model().AddURL(model().account_bookmark_bar_node(), 1, u"Title y", |
| GURL("https://example.com")); |
| EXPECT_EQ(tracker.GetIndexOf(node), 1u); |
| EXPECT_EQ(tracker.GetNodeAtIndex(1), node); |
| |
| EXPECT_EQ( |
| tracker.GetIndexOf(model().bookmark_bar_node()->children()[0].get()), 2u); |
| // Insert local nodes. |
| node = model().AddURL(model().bookmark_bar_node(), 0, u"Title z", |
| GURL("https://example.com")); |
| EXPECT_EQ(tracker.GetIndexOf(node), 2u); |
| EXPECT_EQ(tracker.GetNodeAtIndex(2), node); |
| |
| node = model().AddURL(model().bookmark_bar_node(), 4, u"Title w", |
| GURL("https://example.com")); |
| EXPECT_EQ(tracker.GetIndexOf(node), 6u); |
| EXPECT_EQ(tracker.GetNodeAtIndex(6), node); |
| EXPECT_EQ(tracker.GetChildrenCount(), |
| model().bookmark_bar_node()->children().size() + |
| model().account_bookmark_bar_node()->children().size()); |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, OrderingAccountThenLocal) { |
| model().LoadEmptyForTest(); |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(2); |
| tracker.Init(/*in_order_node_ids=*/{}); |
| |
| model().CreateAccountPermanentFolders(); |
| ASSERT_THAT(tracker.GetUnderlyingPermanentNodes(), |
| UnorderedElementsAre(model().account_bookmark_bar_node(), |
| model().bookmark_bar_node())); |
| AddNodesFromModelString(&model(), model().account_bookmark_bar_node(), |
| "1 2 3 f1:[ 4 5 f2:[ 6 ] ]"); |
| Mock::VerifyAndClearExpectations(delegate()); |
| |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(AtLeast(3)); |
| // Add local bookmarks. |
| const BookmarkNode* node = model().AddURL( |
| model().bookmark_bar_node(), 0, u"Title x", GURL("https://example.com")); |
| EXPECT_EQ(tracker.GetIndexOf(node), 4u); |
| EXPECT_EQ(tracker.GetNodeAtIndex(4), node); |
| |
| node = model().AddURL(model().bookmark_bar_node(), 1, u"Title y", |
| GURL("https://example.com")); |
| EXPECT_EQ(tracker.GetIndexOf(node), 5u); |
| EXPECT_EQ(tracker.GetNodeAtIndex(5), node); |
| |
| EXPECT_EQ(tracker.GetIndexOf( |
| model().account_bookmark_bar_node()->children()[0].get()), |
| 0u); |
| // Insert account nodes. |
| node = model().AddURL(model().account_bookmark_bar_node(), 0, u"Title z", |
| GURL("https://example.com")); |
| EXPECT_EQ(tracker.GetIndexOf(node), 0u); |
| EXPECT_EQ(tracker.GetNodeAtIndex(0), node); |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, BookmarkAllUserNodesRemoved) { |
| model().LoadEmptyForTest(); |
| model().CreateAccountPermanentFolders(); |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::OTHER_NODE, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(5); |
| tracker.Init(/*in_order_node_ids=*/{}); |
| ASSERT_THAT( |
| tracker.GetUnderlyingPermanentNodes(), |
| UnorderedElementsAre(model().account_other_node(), model().other_node())); |
| AddNodesFromModelString(&model(), model().other_node(), |
| "1 2 3 f1:[ 4 5 f2:[ 6 ] ]"); |
| AddNodesFromModelString(&model(), model().account_other_node(), |
| "1 2 3 f1:[ 4 5 f2:[ 6 ] ]"); |
| Mock::VerifyAndClearExpectations(delegate()); |
| |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged); |
| model().RemoveAllUserBookmarks(FROM_HERE); |
| const BookmarkNode* node = model().AddURL(model().other_node(), 0, u"Title x", |
| GURL("https://example.com")); |
| EXPECT_EQ(tracker.GetIndexOf(node), 0u); |
| EXPECT_EQ(tracker.GetNodeAtIndex(0), node); |
| EXPECT_EQ(tracker.GetChildrenCount(), 1u); |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, RemoveAccountPermanentFolders) { |
| model().LoadEmptyForTest(); |
| model().CreateAccountPermanentFolders(); |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::OTHER_NODE, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(5); |
| tracker.Init(/*in_order_node_ids=*/{}); |
| ASSERT_THAT( |
| tracker.GetUnderlyingPermanentNodes(), |
| UnorderedElementsAre(model().account_other_node(), model().other_node())); |
| AddNodesFromModelString(&model(), model().other_node(), |
| "1 2 3 f1:[ 4 5 f2:[ 6 ] ]"); |
| AddNodesFromModelString(&model(), model().account_other_node(), |
| "1 2 3 f1:[ 4 5 f2:[ 6 ] ]"); |
| |
| const BookmarkNode* node = model().other_node()->children()[0].get(); |
| EXPECT_EQ(tracker.GetIndexOf(node), |
| model().account_other_node()->children().size()); |
| EXPECT_EQ( |
| tracker.GetNodeAtIndex(model().account_other_node()->children().size()), |
| node); |
| |
| Mock::VerifyAndClearExpectations(delegate()); |
| |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged); |
| model().RemoveAccountPermanentFolders(); |
| EXPECT_THAT(tracker.GetUnderlyingPermanentNodes(), |
| UnorderedElementsAre(model().other_node())); |
| EXPECT_EQ(tracker.GetIndexOf(node), 0u); |
| EXPECT_EQ(tracker.GetNodeAtIndex(0), node); |
| EXPECT_EQ(tracker.GetChildrenCount(), |
| model().other_node()->children().size()); |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, |
| BookmarkMovedOldParentNonTrackedNode) { |
| model().LoadEmptyForTest(); |
| model().CreateAccountPermanentFolders(); |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged); |
| tracker.Init(/*in_order_node_ids=*/{}); |
| AddNodesFromModelString(&model(), model().other_node(), |
| "1 2 3 f1:[ 4 5 f2:[ 6 ] ]"); |
| AddNodesFromModelString(&model(), model().bookmark_bar_node(), |
| "1 2 3 f1:[ 4 5 f2:[ 6 ] ]"); |
| |
| const BookmarkNode* node = model().bookmark_bar_node()->children()[0].get(); |
| EXPECT_EQ(tracker.GetIndexOf(node), 0u); |
| Mock::VerifyAndClearExpectations(delegate()); |
| |
| // Move node from non-tracked `other_node` to `bookmark_bar_node()`. |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(AtLeast(1)); |
| const BookmarkNode* node_to_be_moved = |
| model().other_node()->children()[1].get(); |
| model().Move(node_to_be_moved, model().bookmark_bar_node(), 0u); |
| EXPECT_EQ(tracker.GetIndexOf(node_to_be_moved), 0u); |
| EXPECT_EQ(tracker.GetIndexOf(node), 1u); |
| |
| // Move node from non-tracked `other_node` to `account_bar_node()`. |
| node_to_be_moved = model().bookmark_bar_node()->children()[1].get(); |
| model().Move(node_to_be_moved, model().account_bookmark_bar_node(), 0u); |
| EXPECT_EQ(tracker.GetIndexOf(node_to_be_moved), 0u); |
| EXPECT_EQ( |
| tracker.GetIndexOf(model().bookmark_bar_node()->children()[0].get()), |
| model().account_bookmark_bar_node()->children().size()); |
| |
| // Move another node. |
| node_to_be_moved = model().bookmark_bar_node()->children()[0].get(); |
| model().Move(node_to_be_moved, model().account_bookmark_bar_node(), 1u); |
| EXPECT_EQ(tracker.GetIndexOf(node_to_be_moved), 1u); |
| EXPECT_EQ( |
| tracker.GetIndexOf(model().bookmark_bar_node()->children()[0].get()), |
| model().account_bookmark_bar_node()->children().size()); |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, |
| BookmarkMovedNewParentNonTrackedNode) { |
| model().LoadEmptyForTest(); |
| model().CreateAccountPermanentFolders(); |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(5); |
| tracker.Init(/*in_order_node_ids=*/{}); |
| AddNodesFromModelString(&model(), model().account_bookmark_bar_node(), |
| "1 2 "); |
| AddNodesFromModelString(&model(), model().bookmark_bar_node(), |
| "1 2 3 f1:[ 4 5 f2:[ 6 ] ]"); |
| EXPECT_EQ( |
| tracker.GetIndexOf(model().bookmark_bar_node()->children()[0].get()), |
| model().account_bookmark_bar_node()->children().size()); |
| Mock::VerifyAndClearExpectations(delegate()); |
| |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged); |
| model().Move(model().account_bookmark_bar_node()->children()[0].get(), |
| model().other_node(), 0u); |
| EXPECT_EQ( |
| tracker.GetIndexOf(model().bookmark_bar_node()->children()[0].get()), 1u); |
| Mock::VerifyAndClearExpectations(delegate()); |
| |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged); |
| model().Move(model().account_bookmark_bar_node()->children()[0].get(), |
| model().other_node(), 0u); |
| EXPECT_EQ( |
| tracker.GetIndexOf(model().bookmark_bar_node()->children()[0].get()), 0u); |
| Mock::VerifyAndClearExpectations(delegate()); |
| |
| // No more bookmark bar account nodes, no ordering change. |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(0); |
| const BookmarkNode* node = model().bookmark_bar_node()->children()[1].get(); |
| EXPECT_EQ(tracker.GetIndexOf(node), 1u); |
| model().Move(model().bookmark_bar_node()->children()[0].get(), |
| model().other_node(), 0u); |
| EXPECT_EQ(tracker.GetIndexOf(node), 0u); |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, |
| BookmarkMovedOldAndNewParentTrackedNodes) { |
| model().LoadEmptyForTest(); |
| model().CreateAccountPermanentFolders(); |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(4); |
| tracker.Init(/*in_order_node_ids=*/{}); |
| AddNodesFromModelString(&model(), model().account_bookmark_bar_node(), |
| "1 2 3 "); |
| AddNodesFromModelString(&model(), model().bookmark_bar_node(), "1 2 3 "); |
| Mock::VerifyAndClearExpectations(delegate()); |
| |
| // Move node from tracked node to another tracked node. |
| |
| const BookmarkNode* node_to_be_moved = |
| model().bookmark_bar_node()->children()[0].get(); |
| EXPECT_EQ(tracker.GetIndexOf(node_to_be_moved), 3u); |
| |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(AtLeast(1)); |
| model().Move(node_to_be_moved, model().account_bookmark_bar_node(), 1u); |
| EXPECT_EQ(tracker.GetIndexOf(node_to_be_moved), 1u); |
| Mock::VerifyAndClearExpectations(delegate()); |
| |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(AtLeast(1)); |
| model().Move(node_to_be_moved, model().bookmark_bar_node(), 0u); |
| EXPECT_EQ(tracker.GetIndexOf(node_to_be_moved), 3u); |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, BookmarkMovedCustomOrder) { |
| model().LoadEmptyForTest(); |
| model().CreateAccountPermanentFolders(); |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| AddNodesFromModelString(&model(), model().bookmark_bar_node(), |
| "A B C L1:[ D E L2:[ F ] ]"); |
| AddNodesFromModelString(&model(), model().account_bookmark_bar_node(), |
| "1 2 3 f1:[ 4 5 f2:[ 6 ] ]"); |
| AddNodesFromModelString(&model(), model().other_node(), "X Y Z "); |
| |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(AtLeast(1)); |
| // {A, 1, 2, 3, B, C, L1, f1}. |
| tracker.Init(/*in_order_node_ids=*/ |
| {model().bookmark_bar_node()->children()[0]->id(), |
| model().account_bookmark_bar_node()->children()[0]->id(), |
| model().account_bookmark_bar_node()->children()[1]->id(), |
| model().account_bookmark_bar_node()->children()[2]->id(), |
| model().bookmark_bar_node()->children()[1]->id(), |
| model().bookmark_bar_node()->children()[2]->id(), |
| model().bookmark_bar_node()->children()[3]->id(), |
| model().account_bookmark_bar_node()->children()[3]->id()}); |
| ASSERT_THAT(tracker.GetUnderlyingPermanentNodes(), |
| UnorderedElementsAre(model().account_bookmark_bar_node(), |
| model().bookmark_bar_node())); |
| |
| // Move to a tracked node. |
| const BookmarkNode* node_to_be_moved = |
| model().other_node()->children()[0].get(); |
| model().Move(node_to_be_moved, model().bookmark_bar_node(), 1u); |
| // Inserted at the end of an existing block. |
| // {L0, X, A0, A1, A2, L1, L2, L3, A3}. |
| EXPECT_EQ(tracker.GetIndexOf(node_to_be_moved), 1u); |
| |
| node_to_be_moved = model().other_node()->children()[0].get(); |
| model().Move(node_to_be_moved, model().account_bookmark_bar_node(), 0u); |
| // Inserted at the beginning of an existing block. |
| // {L0, X(L), Y(A), A0, A1, A2, L1, L2, L3, A3}. |
| EXPECT_EQ(tracker.GetIndexOf(node_to_be_moved), 2u); |
| |
| node_to_be_moved = model().other_node()->children()[0].get(); |
| model().Move(node_to_be_moved, model().bookmark_bar_node(), 3u); |
| // Inserted at the middle of an existing block. |
| // {L0, X(L), Y(A), A0, A1, A2, L1, Z(L), L2, L3, A3}. |
| EXPECT_EQ(tracker.GetIndexOf(node_to_be_moved), 7u); |
| |
| // Move from `bookmark_bar_node` to `account_bookmark_bar_node`. |
| model().Move(node_to_be_moved, model().account_bookmark_bar_node(), |
| model().account_bookmark_bar_node()->children().size()); |
| // {L0, X(L), Y(A), A0, A1, A2, L1, L2, L3, A3, Z(A)}. |
| EXPECT_EQ(tracker.GetIndexOf(node_to_be_moved), 10u); |
| |
| // Move within `account_bookmark_bar_node`. |
| model().Move(node_to_be_moved, model().account_bookmark_bar_node(), 0u); |
| // {L0, X(L), Z(A), Y(A), A0, A1, A2, L1, L2, L3, A3}. |
| EXPECT_EQ(tracker.GetIndexOf(node_to_be_moved), 2u); |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, MoveToReorderTrackedNodes) { |
| model().LoadEmptyForTest(); |
| model().CreateAccountPermanentFolders(); |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(5); |
| tracker.Init(/*in_order_node_ids=*/{}); |
| AddNodesFromModelString(&model(), model().account_bookmark_bar_node(), |
| "A1 A2 "); |
| AddNodesFromModelString(&model(), model().bookmark_bar_node(), |
| "1 2 3 f1:[ 4 5 f2:[ 6 ] ]"); |
| Mock::VerifyAndClearExpectations(delegate()); |
| |
| { |
| // Move node `3` |
| const BookmarkNode* node = model().bookmark_bar_node()->children()[2].get(); |
| // {A1 A2 1 2 3 f1 } |
| EXPECT_EQ(tracker.GetIndexOf(node), 4u); |
| // Move to the end of the list. |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(AtLeast(1)); |
| EXPECT_THAT(tracker.MoveToIndex(node, 6u), Optional(5u)); |
| // {A1 A2 1 2 f1 3 } |
| EXPECT_EQ(tracker.GetIndexOf(node), 5u); |
| EXPECT_EQ(node->parent(), model().bookmark_bar_node()); |
| EXPECT_EQ(node->parent()->GetIndexOf(node), 3u); |
| Mock::VerifyAndClearExpectations(delegate()); |
| } |
| |
| { |
| // Move `A1` to the end. |
| const BookmarkNode* node = |
| model().account_bookmark_bar_node()->children()[0].get(); |
| // {A1 A2 1 2 f1 3 } |
| EXPECT_EQ(tracker.GetIndexOf(node), 0u); |
| // Move to the end of the list. |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(AtLeast(1)); |
| EXPECT_THAT(tracker.MoveToIndex(node, 6u), Optional(5u)); |
| // {A2 1 2 f1 3 A1 } |
| EXPECT_EQ(tracker.GetIndexOf(node), 5u); |
| EXPECT_EQ(node->parent(), model().account_bookmark_bar_node()); |
| EXPECT_EQ(node->parent()->GetIndexOf(node), 1u); |
| Mock::VerifyAndClearExpectations(delegate()); |
| } |
| |
| { |
| // Move `f1` to the beginning of the list. |
| const BookmarkNode* node = model().bookmark_bar_node()->children()[2].get(); |
| // {A2 1 2 f1 3 A1 } |
| EXPECT_EQ(tracker.GetIndexOf(node), 3u); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(AtLeast(1)); |
| EXPECT_THAT(tracker.MoveToIndex(node, 0u), Optional(0u)); |
| EXPECT_EQ(tracker.GetIndexOf(node), 0u); |
| // {f1 A2 1 2 3 A1 } |
| EXPECT_EQ(node->parent()->GetIndexOf(node), 0u); |
| Mock::VerifyAndClearExpectations(delegate()); |
| } |
| |
| { |
| // Move `2` in the middle to the right (only in storage move is required). |
| const BookmarkNode* node = model().bookmark_bar_node()->children()[2].get(); |
| // {f1 A2 1 2 3 A1 } |
| EXPECT_EQ(tracker.GetIndexOf(node), 3u); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(AtLeast(1)); |
| EXPECT_THAT(tracker.MoveToIndex(node, 5u), Optional(4u)); |
| // {f1 A2 1 3 2 A1 } |
| EXPECT_EQ(tracker.GetIndexOf(node), 4u); |
| EXPECT_EQ(node->parent()->GetIndexOf(node), 3u); |
| |
| // Move `2` to the right (in storage move not needed). |
| EXPECT_THAT(tracker.MoveToIndex(node, 6u), Optional(5u)); |
| // {f1 A2 1 3 A1 2} |
| EXPECT_EQ(tracker.GetIndexOf(node), 5u); |
| EXPECT_EQ(node->parent()->GetIndexOf(node), 3u); |
| Mock::VerifyAndClearExpectations(delegate()); |
| } |
| |
| { |
| // Move `A1` to the left |
| const BookmarkNode* node = |
| model().account_bookmark_bar_node()->children()[1].get(); |
| // {f1 A2 1 3 A1 2} |
| EXPECT_EQ(tracker.GetIndexOf(node), 4u); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(AtLeast(1)); |
| EXPECT_THAT(tracker.MoveToIndex(node, 1u), Optional(1u)); |
| // {f1 A1 A2 1 3 2} |
| EXPECT_EQ(tracker.GetIndexOf(node), 1u); |
| EXPECT_EQ(node->parent()->GetIndexOf(node), 0u); |
| Mock::VerifyAndClearExpectations(delegate()); |
| } |
| |
| { |
| // No Reorder is needed. |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(0); |
| const BookmarkNode* node = |
| model().account_bookmark_bar_node()->children()[1].get(); |
| // {f1 A1 A2 1 3 2} |
| EXPECT_EQ(tracker.GetIndexOf(node), 2u); |
| EXPECT_THAT(tracker.MoveToIndex(node, 3u), std::nullopt); |
| EXPECT_EQ(tracker.GetIndexOf(node), 2u); |
| EXPECT_THAT(tracker.MoveToIndex(node, 2u), std::nullopt); |
| EXPECT_EQ(tracker.GetIndexOf(node), 2u); |
| } |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, MoveAddsNewAccountTrackedNodes) { |
| model().LoadEmptyForTest(); |
| model().CreateAccountPermanentFolders(); |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(AtLeast(1)); |
| tracker.Init(/*in_order_node_ids=*/{}); |
| AddNodesFromModelString(&model(), model().account_other_node(), "X Y Z W "); |
| AddNodesFromModelString(&model(), model().bookmark_bar_node(), "1 2 "); |
| EXPECT_EQ(tracker.GetChildrenCount(), 2u); |
| { |
| const BookmarkNode* node = |
| model().account_other_node()->children()[0].get(); |
| // {1 2 } |
| EXPECT_THAT(tracker.MoveToIndex(node, 1u), Optional(1u)); |
| // {1 X 2 } |
| EXPECT_EQ(tracker.GetIndexOf(node), 1u); |
| EXPECT_EQ(node->parent(), model().account_bookmark_bar_node()); |
| EXPECT_EQ(node->parent()->GetIndexOf(node), 0u); |
| } |
| |
| { |
| // Move `Y` to the beginning of the list. |
| const BookmarkNode* node = |
| model().account_other_node()->children()[0].get(); |
| // {1 X 2 } |
| EXPECT_THAT(tracker.MoveToIndex(node, 0u), Optional(0u)); |
| // {Y 1 X 2 } |
| EXPECT_EQ(tracker.GetIndexOf(node), 0u); |
| EXPECT_EQ(node->parent(), model().account_bookmark_bar_node()); |
| EXPECT_EQ(node->parent()->GetIndexOf(node), 0u); |
| } |
| |
| { |
| // Move `Z` to the end of the list. |
| const BookmarkNode* node = |
| model().account_other_node()->children()[0].get(); |
| // {Y 1 X 2 } |
| EXPECT_THAT(tracker.MoveToIndex(node, 4u), Optional(4u)); |
| // {Y 1 X 2 Z } |
| EXPECT_EQ(tracker.GetIndexOf(node), 4u); |
| EXPECT_EQ(node->parent(), model().account_bookmark_bar_node()); |
| EXPECT_EQ(node->parent()->GetIndexOf(node), 2u); |
| } |
| |
| { |
| // Move `W` to be before `Z`. |
| const BookmarkNode* node = |
| model().account_other_node()->children()[0].get(); |
| // {Y 1 X 2 Z } |
| EXPECT_THAT(tracker.MoveToIndex(node, 4u), Optional(4u)); |
| // {Y 1 X 2 W Z } |
| EXPECT_EQ(tracker.GetIndexOf(node), 4u); |
| EXPECT_EQ(node->parent(), model().account_bookmark_bar_node()); |
| EXPECT_EQ(node->parent()->GetIndexOf(node), 2u); |
| } |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, MoveAddsNewLocalTrackedNodes) { |
| model().LoadEmptyForTest(); |
| model().CreateAccountPermanentFolders(); |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(AtLeast(1)); |
| tracker.Init(/*in_order_node_ids=*/{}); |
| AddNodesFromModelString(&model(), model().other_node(), "X Y Z "); |
| AddNodesFromModelString(&model(), model().account_bookmark_bar_node(), |
| "A1 A2 "); |
| EXPECT_EQ(tracker.GetChildrenCount(), 2u); |
| |
| const BookmarkNode* node = model().other_node()->children()[0].get(); |
| // {A1 A2 } |
| EXPECT_THAT(tracker.MoveToIndex(node, 1u), Optional(1u)); |
| // {A1 X A2 } |
| EXPECT_EQ(tracker.GetIndexOf(node), 1u); |
| EXPECT_EQ(node->parent(), model().bookmark_bar_node()); |
| EXPECT_EQ(node->parent()->GetIndexOf(node), 0u); |
| |
| node = model().other_node()->children()[1].get(); |
| // {1 X 2 } |
| EXPECT_THAT(tracker.MoveToIndex(node, 3u), Optional(3u)); |
| // {1 X 2 Z } |
| EXPECT_EQ(tracker.GetIndexOf(node), 3u); |
| EXPECT_EQ(node->parent(), model().bookmark_bar_node()); |
| EXPECT_EQ(node->parent()->GetIndexOf(node), 1u); |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, MoveToLocalOrderingNotTracked) { |
| model().LoadEmptyForTest(); |
| model().CreateAccountPermanentFolders(); |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(AtLeast(1)); |
| tracker.Init(/*in_order_node_ids=*/{}); |
| AddNodesFromModelString(&model(), model().other_node(), |
| "1 2 3 f1:[ 4 5 f2:[ 6 ] ]"); |
| |
| EXPECT_EQ(tracker.GetChildrenCount(), 0u); |
| const BookmarkNode* node = model().other_node()->children()[0].get(); |
| EXPECT_THAT(tracker.MoveToIndex(node, 0), Optional(0u)); |
| // { 1 } |
| EXPECT_EQ(tracker.GetChildrenCount(), 1u); |
| EXPECT_EQ(node->parent(), model().bookmark_bar_node()); |
| EXPECT_EQ(tracker.GetNodeAtIndex(0), node); |
| |
| node = model().other_node()->children()[0].get(); |
| EXPECT_THAT(tracker.MoveToIndex(node, 0), Optional(0u)); |
| // { 2 1 } |
| EXPECT_EQ(tracker.GetChildrenCount(), 2u); |
| EXPECT_EQ(node->parent(), model().bookmark_bar_node()); |
| EXPECT_EQ(tracker.GetNodeAtIndex(0), node); |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, MoveToAccountOrderingNotTracked) { |
| model().LoadEmptyForTest(); |
| model().CreateAccountPermanentFolders(); |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(AtLeast(1)); |
| tracker.Init(/*in_order_node_ids=*/{}); |
| AddNodesFromModelString(&model(), model().account_other_node(), "A1 A2 "); |
| |
| EXPECT_EQ(tracker.GetChildrenCount(), 0u); |
| const BookmarkNode* node = model().account_other_node()->children()[0].get(); |
| EXPECT_THAT(tracker.MoveToIndex(node, 0), Optional(0u)); |
| // { A1 } |
| EXPECT_EQ(tracker.GetChildrenCount(), 1u); |
| EXPECT_EQ(node->parent(), model().account_bookmark_bar_node()); |
| EXPECT_EQ(tracker.GetNodeAtIndex(0), node); |
| |
| node = model().account_other_node()->children()[0].get(); |
| EXPECT_THAT(tracker.MoveToIndex(node, 1), Optional(1u)); |
| // { A1 A2 } |
| EXPECT_EQ(tracker.GetChildrenCount(), 2u); |
| EXPECT_EQ(node->parent(), model().account_bookmark_bar_node()); |
| EXPECT_EQ(tracker.GetNodeAtIndex(1), node); |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, CopySingleNodeToMiddle) { |
| model().LoadEmptyForTest(); |
| model().CreateAccountPermanentFolders(); |
| |
| AddNodesFromModelString(&model(), model().account_bookmark_bar_node(), |
| "X Y Z W "); |
| AddNodesFromModelString(&model(), model().bookmark_bar_node(), "1 2 "); |
| AddNodesFromModelString(&model(), model().other_node(), "O1 O2 O3 "); |
| |
| std::vector<BookmarkNodeData::Element> new_nodes; |
| new_nodes.emplace_back(model().other_node()->children()[1].get()); |
| |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(AtLeast(1)); |
| tracker.Init(/*in_order_node_ids=*/{}); |
| tracker.AddNodesAsCopiesOfNodeData(new_nodes, 2); |
| EXPECT_EQ(ModelStringFromNode(model().account_bookmark_bar_node()), |
| "X Y O2 Z W "); |
| EXPECT_EQ(tracker.GetNodeAtIndex(2), |
| model().account_bookmark_bar_node()->children()[2u].get()); |
| Mock::VerifyAndClearExpectations(delegate()); |
| |
| // Custom order: "X 1 Y O2 Z W 2 " |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(AtLeast(1)); |
| EXPECT_THAT( |
| tracker.MoveToIndex(model().bookmark_bar_node()->children()[0].get(), 1u), |
| Optional(1u)); |
| EXPECT_EQ(tracker.GetNodeAtIndex(1), |
| model().bookmark_bar_node()->children()[0].get()); |
| Mock::VerifyAndClearExpectations(delegate()); |
| |
| new_nodes.clear(); |
| new_nodes.emplace_back(model().other_node()->children()[0].get()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(AtLeast(1)); |
| // Move O1 to index 3. |
| tracker.AddNodesAsCopiesOfNodeData(new_nodes, 3); |
| // Expected order: "X 1 Y O1 O2 Z W 2 " |
| EXPECT_EQ(ModelStringFromNode(model().account_bookmark_bar_node()), |
| "X Y O1 O2 Z W "); |
| EXPECT_EQ(tracker.GetNodeAtIndex(3), |
| model().account_bookmark_bar_node()->children()[2u].get()); |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, CopySingleNodeToBeginning) { |
| model().LoadEmptyForTest(); |
| model().CreateAccountPermanentFolders(); |
| |
| AddNodesFromModelString(&model(), model().account_bookmark_bar_node(), |
| "X Y Z W "); |
| AddNodesFromModelString(&model(), model().bookmark_bar_node(), "1 2 "); |
| AddNodesFromModelString(&model(), model().other_node(), "O1 O2 O3 "); |
| |
| std::vector<BookmarkNodeData::Element> new_nodes; |
| new_nodes.emplace_back(model().other_node()->children()[0].get()); |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(AtLeast(1)); |
| tracker.Init(/*in_order_node_ids=*/{}); |
| tracker.AddNodesAsCopiesOfNodeData(new_nodes, 0); |
| EXPECT_EQ(ModelStringFromNode(model().account_bookmark_bar_node()), |
| "O1 X Y Z W "); |
| EXPECT_EQ(tracker.GetNodeAtIndex(0), |
| model().account_bookmark_bar_node()->children()[0].get()); |
| |
| // Custom order: "1 O1 X Y Z W 2 " |
| EXPECT_THAT( |
| tracker.MoveToIndex(model().bookmark_bar_node()->children()[0].get(), 0u), |
| Optional(0u)); |
| EXPECT_EQ(tracker.GetNodeAtIndex(0), |
| model().bookmark_bar_node()->children()[0].get()); |
| |
| new_nodes.clear(); |
| new_nodes.emplace_back(model().other_node()->children()[1].get()); |
| tracker.AddNodesAsCopiesOfNodeData(new_nodes, 0); |
| EXPECT_EQ(ModelStringFromNode(model().account_bookmark_bar_node()), |
| "O2 O1 X Y Z W "); |
| EXPECT_EQ(tracker.GetNodeAtIndex(0), |
| model().account_bookmark_bar_node()->children()[0u].get()); |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, CopySingleNodeToEnd) { |
| model().LoadEmptyForTest(); |
| model().CreateAccountPermanentFolders(); |
| |
| AddNodesFromModelString(&model(), model().account_bookmark_bar_node(), |
| "X Y Z W "); |
| AddNodesFromModelString(&model(), model().bookmark_bar_node(), "1 2 "); |
| AddNodesFromModelString(&model(), model().other_node(), "O1 O2 O3 "); |
| |
| std::vector<BookmarkNodeData::Element> new_nodes; |
| new_nodes.emplace_back(model().other_node()->children()[0].get()); |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(AtLeast(1)); |
| tracker.Init(/*in_order_node_ids=*/{}); |
| tracker.AddNodesAsCopiesOfNodeData(new_nodes, 6); |
| EXPECT_EQ(ModelStringFromNode(model().account_bookmark_bar_node()), |
| "X Y Z W O1 "); |
| EXPECT_EQ(tracker.GetNodeAtIndex(6), |
| model().account_bookmark_bar_node()->children().back().get()); |
| |
| // Custom order: "X Y Z W 1 2 O1" |
| new_nodes.clear(); |
| new_nodes.emplace_back(model().other_node()->children()[1].get()); |
| tracker.AddNodesAsCopiesOfNodeData(new_nodes, 7u); |
| EXPECT_EQ(ModelStringFromNode(model().account_bookmark_bar_node()), |
| "X Y Z W O1 O2 "); |
| EXPECT_EQ(tracker.GetNodeAtIndex(7), |
| model().account_bookmark_bar_node()->children().back().get()); |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, CopyMultipleNodesToMiddle) { |
| model().LoadEmptyForTest(); |
| model().CreateAccountPermanentFolders(); |
| |
| AddNodesFromModelString(&model(), model().account_bookmark_bar_node(), |
| "X Y Z W "); |
| AddNodesFromModelString(&model(), model().bookmark_bar_node(), "1 2 "); |
| AddNodesFromModelString(&model(), model().other_node(), "O1 O2 O3 O4 O5 "); |
| |
| std::vector<BookmarkNodeData::Element> new_nodes; |
| new_nodes.emplace_back(model().other_node()->children()[0].get()); |
| new_nodes.emplace_back(model().other_node()->children()[1].get()); |
| new_nodes.emplace_back(model().other_node()->children()[2].get()); |
| |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(AtLeast(1)); |
| tracker.Init(/*in_order_node_ids=*/{}); |
| tracker.AddNodesAsCopiesOfNodeData(new_nodes, 1); |
| EXPECT_EQ(ModelStringFromNode(model().account_bookmark_bar_node()), |
| "X O1 O2 O3 Y Z W "); |
| EXPECT_THAT( |
| tracker, |
| HasChildren(ElementsAre( |
| IsUrlBookmark(u"X"), IsUrlBookmark(u"O1"), IsUrlBookmark(u"O2"), |
| IsUrlBookmark(u"O3"), IsUrlBookmark(u"Y"), IsUrlBookmark(u"Z"), |
| IsUrlBookmark(u"W"), IsUrlBookmark(u"1"), IsUrlBookmark(u"2")))); |
| Mock::VerifyAndClearExpectations(delegate()); |
| |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(AtLeast(1)); |
| EXPECT_THAT( |
| tracker.MoveToIndex(model().bookmark_bar_node()->children()[0].get(), 0u), |
| Optional(0u)); |
| EXPECT_THAT( |
| tracker, |
| HasChildren(ElementsAre( |
| IsUrlBookmark(u"1"), IsUrlBookmark(u"X"), IsUrlBookmark(u"O1"), |
| IsUrlBookmark(u"O2"), IsUrlBookmark(u"O3"), IsUrlBookmark(u"Y"), |
| IsUrlBookmark(u"Z"), IsUrlBookmark(u"W"), IsUrlBookmark(u"2")))); |
| Mock::VerifyAndClearExpectations(delegate()); |
| |
| new_nodes.clear(); |
| new_nodes.emplace_back(model().other_node()->children()[3].get()); |
| new_nodes.emplace_back(model().other_node()->children()[4].get()); |
| |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(AtLeast(1)); |
| tracker.AddNodesAsCopiesOfNodeData(new_nodes, 6); |
| EXPECT_EQ(ModelStringFromNode(model().account_bookmark_bar_node()), |
| "X O1 O2 O3 Y O4 O5 Z W "); |
| EXPECT_THAT( |
| tracker, |
| HasChildren(ElementsAre( |
| IsUrlBookmark(u"1"), IsUrlBookmark(u"X"), IsUrlBookmark(u"O1"), |
| IsUrlBookmark(u"O2"), IsUrlBookmark(u"O3"), IsUrlBookmark(u"Y"), |
| IsUrlBookmark(u"O4"), IsUrlBookmark(u"O5"), IsUrlBookmark(u"Z"), |
| IsUrlBookmark(u"W"), IsUrlBookmark(u"2")))); |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, CopyMultipleNodesToBeginning) { |
| model().LoadEmptyForTest(); |
| model().CreateAccountPermanentFolders(); |
| |
| AddNodesFromModelString(&model(), model().account_bookmark_bar_node(), |
| "X Y Z W "); |
| AddNodesFromModelString(&model(), model().bookmark_bar_node(), "1 2 "); |
| AddNodesFromModelString(&model(), model().other_node(), "O1 O2 O3 O4 O5 "); |
| |
| std::vector<BookmarkNodeData::Element> new_nodes; |
| new_nodes.emplace_back(model().other_node()->children()[0].get()); |
| new_nodes.emplace_back(model().other_node()->children()[1].get()); |
| new_nodes.emplace_back(model().other_node()->children()[2].get()); |
| |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(AtLeast(1)); |
| tracker.Init(/*in_order_node_ids=*/{}); |
| tracker.AddNodesAsCopiesOfNodeData(new_nodes, 0); |
| EXPECT_EQ(ModelStringFromNode(model().account_bookmark_bar_node()), |
| "O1 O2 O3 X Y Z W "); |
| for (size_t i = 0; i < model().account_bookmark_bar_node()->children().size(); |
| i++) { |
| EXPECT_EQ(tracker.GetNodeAtIndex(i), |
| model().account_bookmark_bar_node()->children()[i].get()); |
| } |
| |
| // Custom order: "1 O1 O2 O3 X Y Z W 2 " |
| EXPECT_THAT( |
| tracker.MoveToIndex(model().bookmark_bar_node()->children()[0].get(), 0u), |
| Optional(0u)); |
| EXPECT_EQ(tracker.GetNodeAtIndex(0), |
| model().bookmark_bar_node()->children()[0].get()); |
| |
| new_nodes.clear(); |
| new_nodes.emplace_back(model().other_node()->children()[3].get()); |
| new_nodes.emplace_back(model().other_node()->children()[4].get()); |
| |
| // Expected order: "O4 O5 1 O1 O2 O3 X Y Z W 2 " |
| tracker.AddNodesAsCopiesOfNodeData(new_nodes, 0); |
| EXPECT_EQ(ModelStringFromNode(model().account_bookmark_bar_node()), |
| "O4 O5 O1 O2 O3 X Y Z W "); |
| EXPECT_EQ(tracker.GetNodeAtIndex(0), |
| model().account_bookmark_bar_node()->children()[0].get()); |
| EXPECT_EQ(tracker.GetNodeAtIndex(1), |
| model().account_bookmark_bar_node()->children()[1].get()); |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, CopyMultipleNodesToEnd) { |
| model().LoadEmptyForTest(); |
| model().CreateAccountPermanentFolders(); |
| |
| AddNodesFromModelString(&model(), model().account_bookmark_bar_node(), |
| "X Y Z W "); |
| AddNodesFromModelString(&model(), model().bookmark_bar_node(), "1 2 "); |
| AddNodesFromModelString(&model(), model().other_node(), "O1 O2 O3 O4 O5 "); |
| |
| std::vector<BookmarkNodeData::Element> new_nodes; |
| new_nodes.emplace_back(model().other_node()->children()[0].get()); |
| new_nodes.emplace_back(model().other_node()->children()[1].get()); |
| new_nodes.emplace_back(model().other_node()->children()[2].get()); |
| |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(AtLeast(1)); |
| tracker.Init(/*in_order_node_ids=*/{}); |
| tracker.AddNodesAsCopiesOfNodeData(new_nodes, tracker.GetChildrenCount()); |
| EXPECT_EQ(ModelStringFromNode(model().account_bookmark_bar_node()), |
| "X Y Z W O1 O2 O3 "); |
| size_t account_children_count = |
| model().account_bookmark_bar_node()->children().size(); |
| for (size_t i = 1; i <= new_nodes.size(); i++) { |
| EXPECT_EQ(tracker.GetNodeAtIndex(tracker.GetChildrenCount() - i), |
| model() |
| .account_bookmark_bar_node() |
| ->children()[account_children_count - i] |
| .get()); |
| } |
| |
| // Custom order |
| new_nodes.clear(); |
| new_nodes.emplace_back(model().other_node()->children()[3].get()); |
| new_nodes.emplace_back(model().other_node()->children()[4].get()); |
| |
| // Expected order: "X Y Z W 1 2 O1 O2 O3 O4 O5 " |
| tracker.AddNodesAsCopiesOfNodeData(new_nodes, tracker.GetChildrenCount()); |
| EXPECT_EQ(ModelStringFromNode(model().account_bookmark_bar_node()), |
| "X Y Z W O1 O2 O3 O4 O5 "); |
| account_children_count = |
| model().account_bookmark_bar_node()->children().size(); |
| for (size_t i = 1; i <= new_nodes.size(); i++) { |
| EXPECT_EQ(tracker.GetNodeAtIndex(tracker.GetChildrenCount() - i), |
| model() |
| .account_bookmark_bar_node() |
| ->children()[account_children_count - i] |
| .get()); |
| } |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, CopyNodesFirstAccountChildNode) { |
| model().LoadEmptyForTest(); |
| model().CreateAccountPermanentFolders(); |
| AddNodesFromModelString(&model(), model().bookmark_bar_node(), "1 2 3 "); |
| AddNodesFromModelString(&model(), model().other_node(), "O1 O2 O3 O4 O5 "); |
| |
| // Copy single node. |
| std::vector<BookmarkNodeData::Element> new_nodes; |
| new_nodes.emplace_back(model().other_node()->children()[0].get()); |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(AtLeast(1)); |
| tracker.Init(/*in_order_node_ids=*/{}); |
| tracker.AddNodesAsCopiesOfNodeData(new_nodes, 2); |
| EXPECT_EQ(ModelStringFromNode(model().account_bookmark_bar_node()), "O1 "); |
| EXPECT_EQ(tracker.GetNodeAtIndex(2), |
| model().account_bookmark_bar_node()->children()[0].get()); |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, CopyNodesNoAccountNodes) { |
| model().LoadEmptyForTest(); |
| AddNodesFromModelString(&model(), model().bookmark_bar_node(), "1 2 3 "); |
| AddNodesFromModelString(&model(), model().other_node(), "O1 O2 O3 O4 O5 "); |
| |
| // Copy single node. |
| std::vector<BookmarkNodeData::Element> new_nodes; |
| new_nodes.emplace_back(model().other_node()->children()[0].get()); |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(AtLeast(1)); |
| tracker.Init(/*in_order_node_ids=*/{}); |
| tracker.AddNodesAsCopiesOfNodeData(new_nodes, 2); |
| EXPECT_EQ(ModelStringFromNode(model().bookmark_bar_node()), "1 2 O1 3 "); |
| EXPECT_EQ(tracker.GetNodeAtIndex(2), |
| model().bookmark_bar_node()->children()[2].get()); |
| |
| // Copy multiple nodes. |
| new_nodes.clear(); |
| new_nodes.emplace_back(model().other_node()->children()[1].get()); |
| new_nodes.emplace_back(model().other_node()->children()[2].get()); |
| tracker.AddNodesAsCopiesOfNodeData(new_nodes, 0); |
| EXPECT_EQ(ModelStringFromNode(model().bookmark_bar_node()), |
| "O2 O3 1 2 O1 3 "); |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, |
| AccountBookmarkNodeChildrenReorderedDefaultOrder) { |
| model().LoadEmptyForTest(); |
| model().CreateAccountPermanentFolders(); |
| const BookmarkNode* local_bb_node = model().bookmark_bar_node(); |
| const BookmarkNode* account_bb_node = model().account_bookmark_bar_node(); |
| AddNodesFromModelString(&model(), local_bb_node, "1 2 3 "); |
| AddNodesFromModelString(&model(), account_bb_node, "A B C D "); |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(2); |
| tracker.Init(/*in_order_node_ids=*/{}); |
| ASSERT_THAT(tracker, |
| HasChildren(ElementsAre(IsUrlBookmark(u"A"), IsUrlBookmark(u"B"), |
| IsUrlBookmark(u"C"), IsUrlBookmark(u"D"), |
| IsUrlBookmark(u"1"), IsUrlBookmark(u"2"), |
| IsUrlBookmark(u"3")))); |
| |
| model().ReorderChildren(account_bb_node, |
| {account_bb_node->children()[3].get(), |
| account_bb_node->children()[2].get(), |
| account_bb_node->children()[1].get(), |
| account_bb_node->children()[0].get()}); |
| EXPECT_THAT(tracker, |
| HasChildren(ElementsAre(IsUrlBookmark(u"D"), IsUrlBookmark(u"C"), |
| IsUrlBookmark(u"B"), IsUrlBookmark(u"A"), |
| IsUrlBookmark(u"1"), IsUrlBookmark(u"2"), |
| IsUrlBookmark(u"3")))); |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, |
| LocalBookmarkNodeChildrenReorderedDefaultOrder) { |
| model().LoadEmptyForTest(); |
| model().CreateAccountPermanentFolders(); |
| const BookmarkNode* local_bb_node = model().bookmark_bar_node(); |
| const BookmarkNode* account_bb_node = model().account_bookmark_bar_node(); |
| AddNodesFromModelString(&model(), local_bb_node, "1 2 3 "); |
| AddNodesFromModelString(&model(), account_bb_node, "A B C D "); |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(2); |
| tracker.Init(/*in_order_node_ids=*/{}); |
| ASSERT_THAT(tracker, |
| HasChildren(ElementsAre(IsUrlBookmark(u"A"), IsUrlBookmark(u"B"), |
| IsUrlBookmark(u"C"), IsUrlBookmark(u"D"), |
| IsUrlBookmark(u"1"), IsUrlBookmark(u"2"), |
| IsUrlBookmark(u"3")))); |
| |
| model().ReorderChildren(local_bb_node, {local_bb_node->children()[2].get(), |
| local_bb_node->children()[1].get(), |
| local_bb_node->children()[0].get()}); |
| EXPECT_THAT(tracker, |
| HasChildren(ElementsAre(IsUrlBookmark(u"A"), IsUrlBookmark(u"B"), |
| IsUrlBookmark(u"C"), IsUrlBookmark(u"D"), |
| IsUrlBookmark(u"3"), IsUrlBookmark(u"2"), |
| IsUrlBookmark(u"1")))); |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, |
| LocalNodeChildrenReorderedNodeMovedToTheBack) { |
| model().LoadEmptyForTest(); |
| model().CreateAccountPermanentFolders(); |
| const BookmarkNode* local_bb_node = model().bookmark_bar_node(); |
| const BookmarkNode* account_bb_node = model().account_bookmark_bar_node(); |
| AddNodesFromModelString(&model(), local_bb_node, "1 2 3 "); |
| AddNodesFromModelString(&model(), account_bb_node, "A B C D "); |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(2); |
| tracker.Init( |
| {local_bb_node->children()[0]->id(), account_bb_node->children()[0]->id(), |
| account_bb_node->children()[1]->id(), local_bb_node->children()[1]->id(), |
| local_bb_node->children()[2]->id(), account_bb_node->children()[2]->id(), |
| account_bb_node->children()[3]->id()}); |
| ASSERT_THAT(tracker, |
| HasChildren(ElementsAre(IsUrlBookmark(u"1"), IsUrlBookmark(u"A"), |
| IsUrlBookmark(u"B"), IsUrlBookmark(u"2"), |
| IsUrlBookmark(u"3"), IsUrlBookmark(u"C"), |
| IsUrlBookmark(u"D")))); |
| |
| // Move 1 to the end: "1, 2, 3" -> "2, 3, 1". |
| model().ReorderChildren(local_bb_node, {local_bb_node->children()[1].get(), |
| local_bb_node->children()[2].get(), |
| local_bb_node->children()[0].get()}); |
| EXPECT_THAT(tracker, |
| HasChildren(ElementsAre(IsUrlBookmark(u"A"), IsUrlBookmark(u"B"), |
| IsUrlBookmark(u"2"), IsUrlBookmark(u"3"), |
| IsUrlBookmark(u"1"), IsUrlBookmark(u"C"), |
| IsUrlBookmark(u"D")))); |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, |
| AccountNodeChildrenReorderedNodeMovedToTheBack) { |
| model().LoadEmptyForTest(); |
| model().CreateAccountPermanentFolders(); |
| const BookmarkNode* local_bb_node = model().bookmark_bar_node(); |
| const BookmarkNode* account_bb_node = model().account_bookmark_bar_node(); |
| AddNodesFromModelString(&model(), local_bb_node, "1 2 3 "); |
| AddNodesFromModelString(&model(), account_bb_node, "A B C D "); |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(2); |
| // Initial setup: "1, A, B, 2, 3, C, D". |
| tracker.Init( |
| /*in_order_node_ids=*/{local_bb_node->children()[0]->id(), |
| account_bb_node->children()[0]->id(), |
| account_bb_node->children()[1]->id(), |
| local_bb_node->children()[1]->id(), |
| local_bb_node->children()[2]->id(), |
| account_bb_node->children()[2]->id(), |
| account_bb_node->children()[3]->id()}); |
| ASSERT_THAT(tracker, |
| HasChildren(ElementsAre(IsUrlBookmark(u"1"), IsUrlBookmark(u"A"), |
| IsUrlBookmark(u"B"), IsUrlBookmark(u"2"), |
| IsUrlBookmark(u"3"), IsUrlBookmark(u"C"), |
| IsUrlBookmark(u"D")))); |
| |
| // Move A to the end: "A, B, C, D" -> "B, C, D, A". |
| model().ReorderChildren(account_bb_node, |
| {account_bb_node->children()[1].get(), |
| account_bb_node->children()[2].get(), |
| account_bb_node->children()[3].get(), |
| account_bb_node->children()[0].get()}); |
| EXPECT_THAT(tracker, |
| HasChildren(ElementsAre(IsUrlBookmark(u"1"), IsUrlBookmark(u"B"), |
| IsUrlBookmark(u"2"), IsUrlBookmark(u"3"), |
| IsUrlBookmark(u"C"), IsUrlBookmark(u"D"), |
| IsUrlBookmark(u"A")))); |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, |
| AccountNodeChildrenReorderedNodeMovedToTheFront) { |
| model().LoadEmptyForTest(); |
| model().CreateAccountPermanentFolders(); |
| const BookmarkNode* local_bb_node = model().bookmark_bar_node(); |
| const BookmarkNode* account_bb_node = model().account_bookmark_bar_node(); |
| AddNodesFromModelString(&model(), local_bb_node, "1 2 3 "); |
| AddNodesFromModelString(&model(), account_bb_node, "A B C D "); |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(2); |
| // "1, A, B, 2, 3, C, D". |
| tracker.Init( |
| {local_bb_node->children()[0]->id(), account_bb_node->children()[0]->id(), |
| account_bb_node->children()[1]->id(), local_bb_node->children()[1]->id(), |
| local_bb_node->children()[2]->id(), account_bb_node->children()[2]->id(), |
| account_bb_node->children()[3]->id()}); |
| ASSERT_THAT(tracker, |
| HasChildren(ElementsAre(IsUrlBookmark(u"1"), IsUrlBookmark(u"A"), |
| IsUrlBookmark(u"B"), IsUrlBookmark(u"2"), |
| IsUrlBookmark(u"3"), IsUrlBookmark(u"C"), |
| IsUrlBookmark(u"D")))); |
| |
| // Move D to the front: "A, B, C, D" -> D, A, B, C". |
| model().ReorderChildren(account_bb_node, |
| {account_bb_node->children()[3].get(), |
| account_bb_node->children()[0].get(), |
| account_bb_node->children()[1].get(), |
| account_bb_node->children()[2].get()}); |
| EXPECT_THAT(tracker, |
| HasChildren(ElementsAre(IsUrlBookmark(u"1"), IsUrlBookmark(u"D"), |
| IsUrlBookmark(u"A"), IsUrlBookmark(u"B"), |
| IsUrlBookmark(u"2"), IsUrlBookmark(u"3"), |
| IsUrlBookmark(u"C")))); |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, |
| LocalNodeChildrenReorderedNodeMovedToTheFront) { |
| model().LoadEmptyForTest(); |
| model().CreateAccountPermanentFolders(); |
| const BookmarkNode* local_bb_node = model().bookmark_bar_node(); |
| const BookmarkNode* account_bb_node = model().account_bookmark_bar_node(); |
| AddNodesFromModelString(&model(), local_bb_node, "1 2 3 "); |
| AddNodesFromModelString(&model(), account_bb_node, "A B C D "); |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(2); |
| // "1, A, B, 2, 3, C, D". |
| tracker.Init( |
| {local_bb_node->children()[0]->id(), account_bb_node->children()[0]->id(), |
| account_bb_node->children()[1]->id(), local_bb_node->children()[1]->id(), |
| local_bb_node->children()[2]->id(), account_bb_node->children()[2]->id(), |
| account_bb_node->children()[3]->id()}); |
| ASSERT_THAT(tracker, |
| HasChildren(ElementsAre(IsUrlBookmark(u"1"), IsUrlBookmark(u"A"), |
| IsUrlBookmark(u"B"), IsUrlBookmark(u"2"), |
| IsUrlBookmark(u"3"), IsUrlBookmark(u"C"), |
| IsUrlBookmark(u"D")))); |
| |
| // Move 3 to the front: "1, 2, 3" -> "3, 1, 2". |
| model().ReorderChildren(local_bb_node, {local_bb_node->children()[2].get(), |
| local_bb_node->children()[0].get(), |
| local_bb_node->children()[1].get()}); |
| EXPECT_THAT(tracker, |
| HasChildren(ElementsAre(IsUrlBookmark(u"3"), IsUrlBookmark(u"1"), |
| IsUrlBookmark(u"A"), IsUrlBookmark(u"B"), |
| IsUrlBookmark(u"2"), IsUrlBookmark(u"C"), |
| IsUrlBookmark(u"D")))); |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, |
| AccountNodeChildrenReorderedReverseOrder) { |
| model().LoadEmptyForTest(); |
| model().CreateAccountPermanentFolders(); |
| const BookmarkNode* local_bb_node = model().bookmark_bar_node(); |
| const BookmarkNode* account_bb_node = model().account_bookmark_bar_node(); |
| AddNodesFromModelString(&model(), local_bb_node, "1 2 3 "); |
| AddNodesFromModelString(&model(), account_bb_node, "A B C D "); |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(2); |
| tracker.Init( |
| {local_bb_node->children()[0]->id(), account_bb_node->children()[0]->id(), |
| account_bb_node->children()[1]->id(), local_bb_node->children()[1]->id(), |
| local_bb_node->children()[2]->id(), account_bb_node->children()[2]->id(), |
| account_bb_node->children()[3]->id()}); |
| ASSERT_THAT(tracker, |
| HasChildren(ElementsAre(IsUrlBookmark(u"1"), IsUrlBookmark(u"A"), |
| IsUrlBookmark(u"B"), IsUrlBookmark(u"2"), |
| IsUrlBookmark(u"3"), IsUrlBookmark(u"C"), |
| IsUrlBookmark(u"D")))); |
| // Reverse the order : "A, B, C, D" -> "D, C, B, A". |
| model().ReorderChildren(account_bb_node, |
| {account_bb_node->children()[3].get(), |
| account_bb_node->children()[2].get(), |
| account_bb_node->children()[1].get(), |
| account_bb_node->children()[0].get()}); |
| // Note: this is not the best order, but given the run time complexity |
| // constraints, this is acceptable. |
| EXPECT_THAT(tracker, |
| HasChildren(ElementsAre(IsUrlBookmark(u"1"), IsUrlBookmark(u"D"), |
| IsUrlBookmark(u"2"), IsUrlBookmark(u"3"), |
| IsUrlBookmark(u"C"), IsUrlBookmark(u"B"), |
| IsUrlBookmark(u"A")))); |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, |
| LocalNodeChildrenReorderedReverseOrder) { |
| model().LoadEmptyForTest(); |
| model().CreateAccountPermanentFolders(); |
| const BookmarkNode* local_bb_node = model().bookmark_bar_node(); |
| const BookmarkNode* account_bb_node = model().account_bookmark_bar_node(); |
| AddNodesFromModelString(&model(), local_bb_node, "1 2 3 "); |
| AddNodesFromModelString(&model(), account_bb_node, "A B C D "); |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(2); |
| tracker.Init( |
| {local_bb_node->children()[0]->id(), account_bb_node->children()[0]->id(), |
| account_bb_node->children()[1]->id(), local_bb_node->children()[1]->id(), |
| local_bb_node->children()[2]->id(), account_bb_node->children()[2]->id(), |
| account_bb_node->children()[3]->id()}); |
| ASSERT_THAT(tracker, |
| HasChildren(ElementsAre(IsUrlBookmark(u"1"), IsUrlBookmark(u"A"), |
| IsUrlBookmark(u"B"), IsUrlBookmark(u"2"), |
| IsUrlBookmark(u"3"), IsUrlBookmark(u"C"), |
| IsUrlBookmark(u"D")))); |
| |
| // Reverse the order : "1, 2, 3" -> "3, 2, 1". |
| model().ReorderChildren(local_bb_node, {local_bb_node->children()[2].get(), |
| local_bb_node->children()[1].get(), |
| local_bb_node->children()[0].get()}); |
| // Note: this is not the best order, but given the run time complexity |
| // constraints, this is acceptable. |
| EXPECT_THAT(tracker, |
| HasChildren(ElementsAre(IsUrlBookmark(u"3"), IsUrlBookmark(u"A"), |
| IsUrlBookmark(u"B"), IsUrlBookmark(u"2"), |
| IsUrlBookmark(u"1"), IsUrlBookmark(u"C"), |
| IsUrlBookmark(u"D")))); |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, |
| BookmarkNodeChildrenReorderedOrderingNotTracked) { |
| model().LoadEmptyForTest(); |
| model().CreateAccountPermanentFolders(); |
| const BookmarkNode* local_bb_node = model().bookmark_bar_node(); |
| AddNodesFromModelString(&model(), local_bb_node, "1 2 3 "); |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged); |
| tracker.Init(/*in_order_node_ids=*/{}); |
| |
| model().ReorderChildren(local_bb_node, {local_bb_node->children()[2].get(), |
| local_bb_node->children()[1].get(), |
| local_bb_node->children()[0].get()}); |
| EXPECT_THAT(tracker, |
| HasChildren(ElementsAre(IsUrlBookmark(u"3"), IsUrlBookmark(u"2"), |
| IsUrlBookmark(u"1")))); |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, |
| ReconcileLoadedNodeIdsNewNodesAdded) { |
| model().LoadEmptyForTest(); |
| model().CreateAccountPermanentFolders(); |
| const BookmarkNode* local_bb_node = model().bookmark_bar_node(); |
| const BookmarkNode* account_bb_node = model().account_bookmark_bar_node(); |
| AddNodesFromModelString(&model(), local_bb_node, "1 2 3 "); |
| AddNodesFromModelString(&model(), account_bb_node, "A B C D "); |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged); |
| // "1, B, 2, C". |
| tracker.Init({local_bb_node->children()[0]->id(), |
| account_bb_node->children()[1]->id(), |
| local_bb_node->children()[1]->id(), |
| account_bb_node->children()[2]->id()}); |
| |
| EXPECT_THAT(tracker, |
| HasChildren(ElementsAre(IsUrlBookmark(u"1"), IsUrlBookmark(u"A"), |
| IsUrlBookmark(u"B"), IsUrlBookmark(u"2"), |
| IsUrlBookmark(u"3"), IsUrlBookmark(u"C"), |
| IsUrlBookmark(u"D")))); |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, ReconcileLoadedNodeIdsNodesRemoved) { |
| model().LoadEmptyForTest(); |
| model().CreateAccountPermanentFolders(); |
| const BookmarkNode* local_bb_node = model().bookmark_bar_node(); |
| const BookmarkNode* account_bb_node = model().account_bookmark_bar_node(); |
| AddNodesFromModelString(&model(), local_bb_node, "1 2 3 "); |
| AddNodesFromModelString(&model(), account_bb_node, "A B C D "); |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged); |
| tracker.Init({2000, local_bb_node->children()[0]->id(), |
| account_bb_node->children()[0]->id(), |
| account_bb_node->children()[1]->id(), 5000, |
| local_bb_node->children()[1]->id(), |
| local_bb_node->children()[2]->id(), |
| account_bb_node->children()[2]->id(), |
| account_bb_node->children()[3]->id(), 3000}); |
| |
| EXPECT_THAT(tracker, |
| HasChildren(ElementsAre(IsUrlBookmark(u"1"), IsUrlBookmark(u"A"), |
| IsUrlBookmark(u"B"), IsUrlBookmark(u"2"), |
| IsUrlBookmark(u"3"), IsUrlBookmark(u"C"), |
| IsUrlBookmark(u"D")))); |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, |
| ReconcileLoadedNodeIdsAllAccountNodesInvalid) { |
| model().LoadEmptyForTest(); |
| model().CreateAccountPermanentFolders(); |
| const BookmarkNode* local_bb_node = model().bookmark_bar_node(); |
| const BookmarkNode* account_bb_node = model().account_bookmark_bar_node(); |
| AddNodesFromModelString(&model(), local_bb_node, "1 2 3 "); |
| AddNodesFromModelString(&model(), account_bb_node, "A B C D "); |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged); |
| tracker.Init({2000, local_bb_node->children()[0]->id(), 5000, |
| local_bb_node->children()[1]->id(), |
| local_bb_node->children()[2]->id(), 6000, 7000, 3000}); |
| // Resets to default. |
| EXPECT_THAT(tracker, |
| HasChildren(ElementsAre(IsUrlBookmark(u"A"), IsUrlBookmark(u"B"), |
| IsUrlBookmark(u"C"), IsUrlBookmark(u"D"), |
| IsUrlBookmark(u"1"), IsUrlBookmark(u"2"), |
| IsUrlBookmark(u"3")))); |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, |
| ReconcileLoadedNodeIdsAllLocalNodesInvalid) { |
| model().LoadEmptyForTest(); |
| model().CreateAccountPermanentFolders(); |
| const BookmarkNode* local_bb_node = model().bookmark_bar_node(); |
| const BookmarkNode* account_bb_node = model().account_bookmark_bar_node(); |
| AddNodesFromModelString(&model(), local_bb_node, "1 2 3 "); |
| AddNodesFromModelString(&model(), account_bb_node, "A B C D "); |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged); |
| tracker.Init({account_bb_node->children()[0]->id(), |
| account_bb_node->children()[1]->id(), 5000, 7000, |
| account_bb_node->children()[2]->id(), 4000, |
| account_bb_node->children()[3]->id(), 8000}); |
| // Resets to default. |
| EXPECT_THAT(tracker, |
| HasChildren(ElementsAre(IsUrlBookmark(u"A"), IsUrlBookmark(u"B"), |
| IsUrlBookmark(u"C"), IsUrlBookmark(u"D"), |
| IsUrlBookmark(u"1"), IsUrlBookmark(u"2"), |
| IsUrlBookmark(u"3")))); |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, ReconcileLoadedNodeIdsAllInvalid) { |
| model().LoadEmptyForTest(); |
| model().CreateAccountPermanentFolders(); |
| const BookmarkNode* local_bb_node = model().bookmark_bar_node(); |
| const BookmarkNode* account_bb_node = model().account_bookmark_bar_node(); |
| AddNodesFromModelString(&model(), local_bb_node, "1 2 3 "); |
| AddNodesFromModelString(&model(), account_bb_node, "A B C D "); |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged); |
| tracker.Init({5000, 7000, 4000, 8000, 9000, 2000, 1000}); |
| // Resets to default. |
| EXPECT_THAT(tracker, |
| HasChildren(ElementsAre(IsUrlBookmark(u"A"), IsUrlBookmark(u"B"), |
| IsUrlBookmark(u"C"), IsUrlBookmark(u"D"), |
| IsUrlBookmark(u"1"), IsUrlBookmark(u"2"), |
| IsUrlBookmark(u"3")))); |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, |
| ReconcileLoadedNodeIdsAccountNodeRemoved) { |
| model().LoadEmptyForTest(); |
| const BookmarkNode* local_bb_node = model().bookmark_bar_node(); |
| AddNodesFromModelString(&model(), local_bb_node, "1 2 3 "); |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged); |
| tracker.Init({2000, local_bb_node->children()[0]->id(), 5000, |
| local_bb_node->children()[1]->id(), |
| local_bb_node->children()[2]->id(), 6000, 7000, 3000}); |
| |
| EXPECT_THAT(tracker, |
| HasChildren(ElementsAre(IsUrlBookmark(u"1"), IsUrlBookmark(u"2"), |
| IsUrlBookmark(u"3")))); |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, ReconcileLoadedNodeIdsReordered) { |
| model().LoadEmptyForTest(); |
| model().CreateAccountPermanentFolders(); |
| const BookmarkNode* local_bb_node = model().bookmark_bar_node(); |
| const BookmarkNode* account_bb_node = model().account_bookmark_bar_node(); |
| AddNodesFromModelString(&model(), local_bb_node, "1 2 3 "); |
| AddNodesFromModelString(&model(), account_bb_node, "A B C D "); |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(AtLeast(1)); |
| // 3, B, C, 1, 2, D, A. |
| tracker.Init( |
| {local_bb_node->children()[2]->id(), account_bb_node->children()[1]->id(), |
| account_bb_node->children()[2]->id(), local_bb_node->children()[0]->id(), |
| local_bb_node->children()[1]->id(), account_bb_node->children()[3]->id(), |
| account_bb_node->children()[0]->id()}); |
| |
| EXPECT_THAT(tracker, |
| HasChildren(ElementsAre(IsUrlBookmark(u"A"), IsUrlBookmark(u"B"), |
| IsUrlBookmark(u"C"), IsUrlBookmark(u"1"), |
| IsUrlBookmark(u"2"), IsUrlBookmark(u"3"), |
| IsUrlBookmark(u"D")))); |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, ReconcileLoadedNodeIdsCombined) { |
| model().LoadEmptyForTest(); |
| model().CreateAccountPermanentFolders(); |
| const BookmarkNode* local_bb_node = model().bookmark_bar_node(); |
| const BookmarkNode* account_bb_node = model().account_bookmark_bar_node(); |
| AddNodesFromModelString(&model(), local_bb_node, "0 1 2 3 4 "); |
| AddNodesFromModelString(&model(), account_bb_node, "A B C K D E "); |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(AtLeast(1)); |
| // 3, B, D, 1, 2, E, A. |
| tracker.Init( |
| {local_bb_node->children()[2]->id(), 6000, |
| account_bb_node->children()[1]->id(), |
| account_bb_node->children()[2]->id(), local_bb_node->children()[0]->id(), |
| local_bb_node->children()[1]->id(), account_bb_node->children()[3]->id(), |
| account_bb_node->children()[0]->id()}); |
| |
| EXPECT_THAT(tracker, |
| HasChildren(ElementsAre( |
| IsUrlBookmark(u"A"), IsUrlBookmark(u"B"), IsUrlBookmark(u"C"), |
| IsUrlBookmark(u"0"), IsUrlBookmark(u"1"), IsUrlBookmark(u"2"), |
| IsUrlBookmark(u"3"), IsUrlBookmark(u"4"), IsUrlBookmark(u"K"), |
| IsUrlBookmark(u"D"), IsUrlBookmark(u"E")))); |
| } |
| |
| TEST_F(PermanentFolderOrderingTrackerTest, |
| ReconcileLoadedNodeIdsBookmarkModelNotLoaded) { |
| PermanentFolderOrderingTracker tracker(&model(), BookmarkNode::BOOKMARK_BAR, |
| delegate()); |
| EXPECT_CALL(*delegate(), TrackedOrderingChanged).Times(AtLeast(1)); |
| tracker.Init({6, 5, 7, 8, 9, 10}); |
| ASSERT_FALSE(model().loaded()); |
| |
| model().LoadEmptyForTest(); |
| model().CreateAccountPermanentFolders(); |
| const BookmarkNode* local_bb_node = model().bookmark_bar_node(); |
| const BookmarkNode* account_bb_node = model().account_bookmark_bar_node(); |
| AddNodesFromModelString(&model(), local_bb_node, "1 2 3 "); |
| AddNodesFromModelString(&model(), account_bb_node, "A B C "); |
| |
| EXPECT_THAT(tracker, HasChildren(ElementsAre( |
| IsUrlBookmark(u"A"), IsUrlBookmark(u"B"), |
| IsUrlBookmark(u"C"), IsUrlBookmark(u"1"), |
| IsUrlBookmark(u"2"), IsUrlBookmark(u"3")))); |
| } |
| |
| } // namespace |
