blob: b7ab581ee7c1429611079d48da6daa8ad248ce85 [file] [log] [blame]
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "net/socket/ssl_client_socket.h"
#include <errno.h>
#include <string.h>
#include <algorithm>
#include <utility>
#include "base/bind.h"
#include "base/callback_helpers.h"
#include "base/files/file_util.h"
#include "base/location.h"
#include "base/memory/ref_counted.h"
#include "base/run_loop.h"
#include "base/single_thread_task_runner.h"
#include "base/stl_util.h"
#include "base/strings/stringprintf.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/test/scoped_feature_list.h"
#include "base/threading/thread_task_runner_handle.h"
#include "base/time/time.h"
#include "base/values.h"
#include "build/build_config.h"
#include "crypto/rsa_private_key.h"
#include "net/base/address_list.h"
#include "net/base/completion_once_callback.h"
#include "net/base/features.h"
#include "net/base/io_buffer.h"
#include "net/base/ip_address.h"
#include "net/base/ip_endpoint.h"
#include "net/base/net_errors.h"
#include "net/base/test_completion_callback.h"
#include "net/cert/asn1_util.h"
#include "net/cert/ct_policy_enforcer.h"
#include "net/cert/ct_policy_status.h"
#include "net/cert/ct_verifier.h"
#include "net/cert/do_nothing_ct_verifier.h"
#include "net/cert/mock_cert_verifier.h"
#include "net/cert/signed_certificate_timestamp_and_status.h"
#include "net/cert/test_root_certs.h"
#include "net/cert/x509_util.h"
#include "net/der/input.h"
#include "net/der/parser.h"
#include "net/der/tag.h"
#include "net/dns/host_resolver.h"
#include "net/http/transport_security_state.h"
#include "net/http/transport_security_state_test_util.h"
#include "net/log/net_log_event_type.h"
#include "net/log/net_log_source.h"
#include "net/log/test_net_log.h"
#include "net/log/test_net_log_entry.h"
#include "net/log/test_net_log_util.h"
#include "net/socket/client_socket_factory.h"
#include "net/socket/client_socket_handle.h"
#include "net/socket/socket_test_util.h"
#include "net/socket/ssl_server_socket.h"
#include "net/socket/stream_socket.h"
#include "net/socket/tcp_client_socket.h"
#include "net/socket/tcp_server_socket.h"
#include "net/ssl/ssl_cert_request_info.h"
#include "net/ssl/ssl_client_session_cache.h"
#include "net/ssl/ssl_config_service.h"
#include "net/ssl/ssl_connection_status_flags.h"
#include "net/ssl/ssl_info.h"
#include "net/ssl/ssl_server_config.h"
#include "net/ssl/test_ssl_private_key.h"
#include "net/test/cert_test_util.h"
#include "net/test/embedded_test_server/embedded_test_server.h"
#include "net/test/embedded_test_server/http_request.h"
#include "net/test/embedded_test_server/http_response.h"
#include "net/test/gtest_util.h"
#include "net/test/spawned_test_server/spawned_test_server.h"
#include "net/test/test_data_directory.h"
#include "net/test/test_with_scoped_task_environment.h"
#include "net/traffic_annotation/network_traffic_annotation_test_helper.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/platform_test.h"
#include "third_party/boringssl/src/include/openssl/bio.h"
#include "third_party/boringssl/src/include/openssl/evp.h"
#include "third_party/boringssl/src/include/openssl/pem.h"
using net::test::IsError;
using net::test::IsOk;
using testing::_;
using testing::AnyOf;
using testing::Return;
using testing::Truly;
namespace net {
class NetLogWithSource;
namespace {
// When passed to |MakeHashValueVector|, this will generate a key pin that is
// sha256/AA...=, and hence will cause pin validation success with the TestSPKI
// pin from transport_security_state_static.pins. ("A" is the 0th element of the
// base-64 alphabet.)
const uint8_t kGoodHashValueVectorInput = 0;
// When passed to |MakeHashValueVector|, this will generate a key pin that is
// not sha256/AA...=, and hence will cause pin validation failure with the
// TestSPKI pin.
const uint8_t kBadHashValueVectorInput = 3;
// ReadBufferingStreamSocket is a wrapper for an existing StreamSocket that
// will ensure a certain amount of data is internally buffered before
// satisfying a Read() request. It exists to mimic OS-level internal
// buffering, but in a way to guarantee that X number of bytes will be
// returned to callers of Read(), regardless of how quickly the OS receives
// them from the TestServer.
class ReadBufferingStreamSocket : public WrappedStreamSocket {
public:
explicit ReadBufferingStreamSocket(std::unique_ptr<StreamSocket> transport);
~ReadBufferingStreamSocket() override = default;
// Socket implementation:
int Read(IOBuffer* buf,
int buf_len,
CompletionOnceCallback callback) override;
int ReadIfReady(IOBuffer* buf,
int buf_len,
CompletionOnceCallback callback) override;
// Sets the internal buffer to |size|. This must not be greater than
// the largest value supplied to Read() - that is, it does not handle
// having "leftovers" at the end of Read().
// Each call to Read() will be prevented from completion until at least
// |size| data has been read.
// Set to 0 to turn off buffering, causing Read() to transparently
// read via the underlying transport.
void SetBufferSize(int size);
private:
enum State {
STATE_NONE,
STATE_READ,
STATE_READ_COMPLETE,
};
int DoLoop(int result);
int DoRead();
int DoReadComplete(int result);
void OnReadCompleted(int result);
State state_;
scoped_refptr<GrowableIOBuffer> read_buffer_;
int buffer_size_;
scoped_refptr<IOBuffer> user_read_buf_;
CompletionOnceCallback user_read_callback_;
};
ReadBufferingStreamSocket::ReadBufferingStreamSocket(
std::unique_ptr<StreamSocket> transport)
: WrappedStreamSocket(std::move(transport)),
read_buffer_(base::MakeRefCounted<GrowableIOBuffer>()),
buffer_size_(0) {}
void ReadBufferingStreamSocket::SetBufferSize(int size) {
DCHECK(!user_read_buf_);
buffer_size_ = size;
read_buffer_->SetCapacity(size);
}
int ReadBufferingStreamSocket::Read(IOBuffer* buf,
int buf_len,
CompletionOnceCallback callback) {
DCHECK(!user_read_buf_);
if (buffer_size_ == 0)
return transport_->Read(buf, buf_len, std::move(callback));
int rv = ReadIfReady(buf, buf_len, std::move(callback));
if (rv == ERR_IO_PENDING)
user_read_buf_ = buf;
return rv;
}
int ReadBufferingStreamSocket::ReadIfReady(IOBuffer* buf,
int buf_len,
CompletionOnceCallback callback) {
DCHECK(!user_read_buf_);
if (buffer_size_ == 0)
return transport_->ReadIfReady(buf, buf_len, std::move(callback));
if (read_buffer_->RemainingCapacity() == 0) {
memcpy(buf->data(), read_buffer_->StartOfBuffer(),
read_buffer_->capacity());
read_buffer_->set_offset(0);
return read_buffer_->capacity();
}
if (buf_len < buffer_size_)
return ERR_UNEXPECTED;
state_ = STATE_READ;
int rv = DoLoop(OK);
if (rv == ERR_IO_PENDING)
user_read_callback_ = std::move(callback);
return rv;
}
int ReadBufferingStreamSocket::DoLoop(int result) {
int rv = result;
do {
State current_state = state_;
state_ = STATE_NONE;
switch (current_state) {
case STATE_READ:
rv = DoRead();
break;
case STATE_READ_COMPLETE:
rv = DoReadComplete(rv);
break;
case STATE_NONE:
default:
NOTREACHED() << "Unexpected state: " << current_state;
rv = ERR_UNEXPECTED;
break;
}
} while (rv != ERR_IO_PENDING && state_ != STATE_NONE);
return rv;
}
int ReadBufferingStreamSocket::DoRead() {
state_ = STATE_READ_COMPLETE;
return transport_->Read(
read_buffer_.get(), read_buffer_->RemainingCapacity(),
base::Bind(&ReadBufferingStreamSocket::OnReadCompleted,
base::Unretained(this)));
}
int ReadBufferingStreamSocket::DoReadComplete(int result) {
state_ = STATE_NONE;
if (result <= 0)
return result;
read_buffer_->set_offset(read_buffer_->offset() + result);
if (read_buffer_->RemainingCapacity() > 0) {
state_ = STATE_READ;
return OK;
}
// If ReadIfReady() is called by the user and this is an asynchronous
// completion, notify the user that read can be retried.
if (user_read_buf_ == nullptr)
return OK;
memcpy(user_read_buf_->data(),
read_buffer_->StartOfBuffer(),
read_buffer_->capacity());
read_buffer_->set_offset(0);
return read_buffer_->capacity();
}
void ReadBufferingStreamSocket::OnReadCompleted(int result) {
DCHECK_NE(ERR_IO_PENDING, result);
DCHECK(user_read_callback_);
result = DoLoop(result);
if (result == ERR_IO_PENDING)
return;
user_read_buf_ = nullptr;
std::move(user_read_callback_).Run(result);
}
// Simulates synchronously receiving an error during Read() or Write()
class SynchronousErrorStreamSocket : public WrappedStreamSocket {
public:
explicit SynchronousErrorStreamSocket(std::unique_ptr<StreamSocket> transport)
: WrappedStreamSocket(std::move(transport)) {}
~SynchronousErrorStreamSocket() override = default;
// Socket implementation:
int Read(IOBuffer* buf,
int buf_len,
CompletionOnceCallback callback) override;
int ReadIfReady(IOBuffer* buf,
int buf_len,
CompletionOnceCallback callback) override;
int Write(IOBuffer* buf,
int buf_len,
CompletionOnceCallback callback,
const NetworkTrafficAnnotationTag& traffic_annotation) override;
// Sets the next Read() call and all future calls to return |error|.
// If there is already a pending asynchronous read, the configured error
// will not be returned until that asynchronous read has completed and Read()
// is called again.
void SetNextReadError(int error) {
DCHECK_GE(0, error);
have_read_error_ = true;
pending_read_error_ = error;
}
// Sets the next Write() call and all future calls to return |error|.
// If there is already a pending asynchronous write, the configured error
// will not be returned until that asynchronous write has completed and
// Write() is called again.
void SetNextWriteError(int error) {
DCHECK_GE(0, error);
have_write_error_ = true;
pending_write_error_ = error;
}
private:
bool have_read_error_ = false;
int pending_read_error_ = OK;
bool have_write_error_ = false;
int pending_write_error_ = OK;
DISALLOW_COPY_AND_ASSIGN(SynchronousErrorStreamSocket);
};
int SynchronousErrorStreamSocket::Read(IOBuffer* buf,
int buf_len,
CompletionOnceCallback callback) {
if (have_read_error_)
return pending_read_error_;
return transport_->Read(buf, buf_len, std::move(callback));
}
int SynchronousErrorStreamSocket::ReadIfReady(IOBuffer* buf,
int buf_len,
CompletionOnceCallback callback) {
if (have_read_error_)
return pending_read_error_;
return transport_->ReadIfReady(buf, buf_len, std::move(callback));
}
int SynchronousErrorStreamSocket::Write(
IOBuffer* buf,
int buf_len,
CompletionOnceCallback callback,
const NetworkTrafficAnnotationTag& traffic_annotation) {
if (have_write_error_)
return pending_write_error_;
return transport_->Write(buf, buf_len, std::move(callback),
traffic_annotation);
}
// FakeBlockingStreamSocket wraps an existing StreamSocket and simulates the
// underlying transport needing to complete things asynchronously in a
// deterministic manner (e.g.: independent of the TestServer and the OS's
// semantics).
class FakeBlockingStreamSocket : public WrappedStreamSocket {
public:
explicit FakeBlockingStreamSocket(std::unique_ptr<StreamSocket> transport)
: WrappedStreamSocket(std::move(transport)) {}
~FakeBlockingStreamSocket() override = default;
// Socket implementation:
int Read(IOBuffer* buf,
int buf_len,
CompletionOnceCallback callback) override;
int ReadIfReady(IOBuffer* buf,
int buf_len,
CompletionOnceCallback callback) override;
int Write(IOBuffer* buf,
int buf_len,
CompletionOnceCallback callback,
const NetworkTrafficAnnotationTag& traffic_annotation) override;
int pending_read_result() const { return pending_read_result_; }
IOBuffer* pending_read_buf() const { return pending_read_buf_.get(); }
// Blocks read results on the socket. Reads will not complete until
// UnblockReadResult() has been called and a result is ready from the
// underlying transport. Note: if BlockReadResult() is called while there is a
// hanging asynchronous Read(), that Read is blocked.
void BlockReadResult();
void UnblockReadResult();
// Replaces the pending read with |data|. Returns true on success or false if
// the caller's reads were too small.
bool ReplaceReadResult(const std::string& data);
// Waits for the blocked Read() call to be complete at the underlying
// transport.
void WaitForReadResult();
// Causes the next call to Write() to return ERR_IO_PENDING, not beginning the
// underlying transport until UnblockWrite() has been called. Note: if there
// is a pending asynchronous write, it is NOT blocked. For purposes of
// blocking writes, data is considered to have reached the underlying
// transport as soon as Write() is called.
void BlockWrite();
void UnblockWrite();
// Waits for the blocked Write() call to be scheduled.
void WaitForWrite();
private:
// Handles completion from the underlying transport read.
void OnReadCompleted(int result);
// Handles async completion of ReadIfReady().
void CompleteReadIfReady(scoped_refptr<IOBuffer> buffer, int rv);
// Finishes the current read.
void ReturnReadResult();
// Callback for writes.
void CallPendingWriteCallback(int result);
// True if read callbacks are blocked.
bool should_block_read_ = false;
// Used to buffer result returned by a completed ReadIfReady().
std::string read_if_ready_buf_;
// Non-null if there is a pending ReadIfReady().
CompletionOnceCallback read_if_ready_callback_;
// The buffer for the pending read, or NULL if not consumed.
scoped_refptr<IOBuffer> pending_read_buf_;
// The size of the pending read buffer, or -1 if not set.
int pending_read_buf_len_ = -1;
// The user callback for the pending read call.
CompletionOnceCallback pending_read_callback_;
// The result for the blocked read callback, or ERR_IO_PENDING if not
// completed.
int pending_read_result_ = ERR_IO_PENDING;
// WaitForReadResult() wait loop.
std::unique_ptr<base::RunLoop> read_loop_;
// True if write calls are blocked.
bool should_block_write_ = false;
// The buffer for the pending write, or NULL if not scheduled.
scoped_refptr<IOBuffer> pending_write_buf_;
// The callback for the pending write call.
CompletionOnceCallback pending_write_callback_;
// The length for the pending write, or -1 if not scheduled.
int pending_write_len_ = -1;
// WaitForWrite() wait loop.
std::unique_ptr<base::RunLoop> write_loop_;
};
int FakeBlockingStreamSocket::Read(IOBuffer* buf,
int len,
CompletionOnceCallback callback) {
DCHECK(!pending_read_buf_);
DCHECK(pending_read_callback_.is_null());
DCHECK_EQ(ERR_IO_PENDING, pending_read_result_);
DCHECK(!callback.is_null());
int rv =
transport_->Read(buf, len,
base::Bind(&FakeBlockingStreamSocket::OnReadCompleted,
base::Unretained(this)));
if (rv == ERR_IO_PENDING || should_block_read_) {
// Save the callback to be called later.
pending_read_buf_ = buf;
pending_read_buf_len_ = len;
pending_read_callback_ = std::move(callback);
// Save the read result.
if (rv != ERR_IO_PENDING) {
OnReadCompleted(rv);
rv = ERR_IO_PENDING;
}
}
return rv;
}
int FakeBlockingStreamSocket::ReadIfReady(IOBuffer* buf,
int len,
CompletionOnceCallback callback) {
if (!read_if_ready_buf_.empty()) {
// If ReadIfReady() is used, asynchronous reads with a large enough buffer
// and no BlockReadResult() are supported by this class. Explicitly check
// that |should_block_read_| doesn't apply and |len| is greater than the
// size of the buffered data.
CHECK(!should_block_read_);
CHECK_GE(len, static_cast<int>(read_if_ready_buf_.size()));
int rv = read_if_ready_buf_.size();
memcpy(buf->data(), read_if_ready_buf_.data(), rv);
read_if_ready_buf_.clear();
return rv;
}
scoped_refptr<IOBuffer> buf_copy = base::MakeRefCounted<IOBuffer>(len);
int rv = Read(buf_copy.get(), len,
base::Bind(&FakeBlockingStreamSocket::CompleteReadIfReady,
base::Unretained(this), buf_copy));
if (rv > 0)
memcpy(buf->data(), buf_copy->data(), rv);
if (rv == ERR_IO_PENDING)
read_if_ready_callback_ = std::move(callback);
return rv;
}
int FakeBlockingStreamSocket::Write(
IOBuffer* buf,
int len,
CompletionOnceCallback callback,
const NetworkTrafficAnnotationTag& traffic_annotation) {
DCHECK(buf);
DCHECK_LE(0, len);
if (!should_block_write_)
return transport_->Write(buf, len, std::move(callback), traffic_annotation);
// Schedule the write, but do nothing.
DCHECK(!pending_write_buf_.get());
DCHECK_EQ(-1, pending_write_len_);
DCHECK(pending_write_callback_.is_null());
DCHECK(!callback.is_null());
pending_write_buf_ = buf;
pending_write_len_ = len;
pending_write_callback_ = std::move(callback);
// Stop the write loop, if any.
if (write_loop_)
write_loop_->Quit();
return ERR_IO_PENDING;
}
void FakeBlockingStreamSocket::BlockReadResult() {
DCHECK(!should_block_read_);
should_block_read_ = true;
}
void FakeBlockingStreamSocket::UnblockReadResult() {
DCHECK(should_block_read_);
should_block_read_ = false;
// If the operation has since completed, return the result to the caller.
if (pending_read_result_ != ERR_IO_PENDING)
ReturnReadResult();
}
bool FakeBlockingStreamSocket::ReplaceReadResult(const std::string& data) {
DCHECK(should_block_read_);
DCHECK_NE(ERR_IO_PENDING, pending_read_result_);
DCHECK(pending_read_buf_);
DCHECK_NE(-1, pending_read_buf_len_);
if (static_cast<size_t>(pending_read_buf_len_) < data.size())
return false;
memcpy(pending_read_buf_->data(), data.data(), data.size());
pending_read_result_ = data.size();
return true;
}
void FakeBlockingStreamSocket::WaitForReadResult() {
DCHECK(should_block_read_);
DCHECK(!read_loop_);
if (pending_read_result_ != ERR_IO_PENDING)
return;
read_loop_.reset(new base::RunLoop);
read_loop_->Run();
read_loop_.reset();
DCHECK_NE(ERR_IO_PENDING, pending_read_result_);
}
void FakeBlockingStreamSocket::BlockWrite() {
DCHECK(!should_block_write_);
should_block_write_ = true;
}
void FakeBlockingStreamSocket::CallPendingWriteCallback(int rv) {
std::move(pending_write_callback_).Run(rv);
}
void FakeBlockingStreamSocket::UnblockWrite() {
DCHECK(should_block_write_);
should_block_write_ = false;
// Do nothing if UnblockWrite() was called after BlockWrite(),
// without a Write() in between.
if (!pending_write_buf_.get())
return;
int rv = transport_->Write(
pending_write_buf_.get(), pending_write_len_,
base::BindOnce(&FakeBlockingStreamSocket::CallPendingWriteCallback,
base::Unretained(this)),
TRAFFIC_ANNOTATION_FOR_TESTS);
pending_write_buf_ = nullptr;
pending_write_len_ = -1;
if (rv != ERR_IO_PENDING) {
std::move(pending_write_callback_).Run(rv);
}
}
void FakeBlockingStreamSocket::WaitForWrite() {
DCHECK(should_block_write_);
DCHECK(!write_loop_);
if (pending_write_buf_.get())
return;
write_loop_.reset(new base::RunLoop);
write_loop_->Run();
write_loop_.reset();
DCHECK(pending_write_buf_.get());
}
void FakeBlockingStreamSocket::OnReadCompleted(int result) {
DCHECK_EQ(ERR_IO_PENDING, pending_read_result_);
DCHECK(!pending_read_callback_.is_null());
pending_read_result_ = result;
if (should_block_read_) {
// Defer the result until UnblockReadResult is called.
if (read_loop_)
read_loop_->Quit();
return;
}
ReturnReadResult();
}
void FakeBlockingStreamSocket::CompleteReadIfReady(scoped_refptr<IOBuffer> buf,
int rv) {
DCHECK(read_if_ready_callback_);
DCHECK(read_if_ready_buf_.empty());
DCHECK(!should_block_read_);
if (rv > 0)
read_if_ready_buf_ = std::string(buf->data(), buf->data() + rv);
std::move(read_if_ready_callback_).Run(rv > 0 ? OK : rv);
}
void FakeBlockingStreamSocket::ReturnReadResult() {
int result = pending_read_result_;
pending_read_result_ = ERR_IO_PENDING;
pending_read_buf_ = nullptr;
pending_read_buf_len_ = -1;
std::move(pending_read_callback_).Run(result);
}
// CountingStreamSocket wraps an existing StreamSocket and maintains a count of
// reads and writes on the socket.
class CountingStreamSocket : public WrappedStreamSocket {
public:
explicit CountingStreamSocket(std::unique_ptr<StreamSocket> transport)
: WrappedStreamSocket(std::move(transport)),
read_count_(0),
write_count_(0) {}
~CountingStreamSocket() override = default;
// Socket implementation:
int Read(IOBuffer* buf,
int buf_len,
CompletionOnceCallback callback) override {
read_count_++;
return transport_->Read(buf, buf_len, std::move(callback));
}
int Write(IOBuffer* buf,
int buf_len,
CompletionOnceCallback callback,
const NetworkTrafficAnnotationTag& traffic_annotation) override {
write_count_++;
return transport_->Write(buf, buf_len, std::move(callback),
traffic_annotation);
}
int read_count() const { return read_count_; }
int write_count() const { return write_count_; }
private:
int read_count_;
int write_count_;
};
// A helper class that will delete |socket| when the callback is invoked.
class DeleteSocketCallback : public TestCompletionCallbackBase {
public:
explicit DeleteSocketCallback(StreamSocket* socket) : socket_(socket) {}
~DeleteSocketCallback() override = default;
CompletionOnceCallback callback() {
return base::BindOnce(&DeleteSocketCallback::OnComplete,
base::Unretained(this));
}
private:
void OnComplete(int result) {
if (socket_) {
delete socket_;
socket_ = nullptr;
} else {
ADD_FAILURE() << "Deleting socket twice";
}
SetResult(result);
}
StreamSocket* socket_;
DISALLOW_COPY_AND_ASSIGN(DeleteSocketCallback);
};
// A mock ExpectCTReporter that remembers the latest violation that was
// reported and the number of violations reported.
class MockExpectCTReporter : public TransportSecurityState::ExpectCTReporter {
public:
MockExpectCTReporter() : num_failures_(0) {}
~MockExpectCTReporter() override = default;
void OnExpectCTFailed(const HostPortPair& host_port_pair,
const GURL& report_uri,
base::Time expiration,
const X509Certificate* validated_certificate_chain,
const X509Certificate* served_certificate_chain,
const SignedCertificateTimestampAndStatusList&
signed_certificate_timestamps) override {
num_failures_++;
host_port_pair_ = host_port_pair;
report_uri_ = report_uri;
served_certificate_chain_ = served_certificate_chain;
validated_certificate_chain_ = validated_certificate_chain;
signed_certificate_timestamps_ = signed_certificate_timestamps;
}
const HostPortPair& host_port_pair() { return host_port_pair_; }
const GURL& report_uri() { return report_uri_; }
uint32_t num_failures() { return num_failures_; }
const X509Certificate* served_certificate_chain() {
return served_certificate_chain_;
}
const X509Certificate* validated_certificate_chain() {
return validated_certificate_chain_;
}
const SignedCertificateTimestampAndStatusList&
signed_certificate_timestamps() {
return signed_certificate_timestamps_;
}
private:
HostPortPair host_port_pair_;
GURL report_uri_;
uint32_t num_failures_;
const X509Certificate* served_certificate_chain_;
const X509Certificate* validated_certificate_chain_;
SignedCertificateTimestampAndStatusList signed_certificate_timestamps_;
};
// A mock CTVerifier that records every call to Verify but doesn't verify
// anything.
class MockCTVerifier : public CTVerifier {
public:
MOCK_METHOD6(Verify,
void(base::StringPiece,
X509Certificate*,
base::StringPiece,
base::StringPiece,
SignedCertificateTimestampAndStatusList*,
const NetLogWithSource&));
MOCK_METHOD1(SetObserver, void(CTVerifier::Observer*));
MOCK_CONST_METHOD0(GetObserver, CTVerifier::Observer*());
};
// A mock CTPolicyEnforcer that returns a custom verification result.
class MockCTPolicyEnforcer : public CTPolicyEnforcer {
public:
MOCK_METHOD3(CheckCompliance,
ct::CTPolicyCompliance(X509Certificate* cert,
const ct::SCTList&,
const NetLogWithSource&));
};
class MockRequireCTDelegate : public TransportSecurityState::RequireCTDelegate {
public:
MOCK_METHOD3(IsCTRequiredForHost,
CTRequirementLevel(const std::string& host,
const X509Certificate* chain,
const HashValueVector& hashes));
};
class SSLClientSocketTest : public PlatformTest,
public WithScopedTaskEnvironment {
public:
SSLClientSocketTest()
: socket_factory_(ClientSocketFactory::GetDefaultFactory()),
cert_verifier_(new MockCertVerifier),
transport_security_state_(new TransportSecurityState),
ct_verifier_(new DoNothingCTVerifier),
ct_policy_enforcer_(new MockCTPolicyEnforcer),
ssl_client_session_cache_(
new SSLClientSessionCache(SSLClientSessionCache::Config())),
context_(cert_verifier_.get(),
nullptr /* channel_id_service */,
transport_security_state_.get(),
ct_verifier_.get(),
ct_policy_enforcer_.get(),
ssl_client_session_cache_.get()) {
cert_verifier_->set_default_result(OK);
EXPECT_CALL(*ct_policy_enforcer_, CheckCompliance(_, _, _))
.WillRepeatedly(
Return(ct::CTPolicyCompliance::CT_POLICY_COMPLIES_VIA_SCTS));
}
protected:
// The address of the spawned test server, after calling StartTestServer().
const AddressList& addr() const { return addr_; }
// The SpawnedTestServer object, after calling StartTestServer().
const SpawnedTestServer* spawned_test_server() const {
return spawned_test_server_.get();
}
void SetCertVerifier(CertVerifier* cert_verifier) {
context_.cert_verifier = cert_verifier;
}
void SetCTVerifier(CTVerifier* ct_verifier) {
context_.cert_transparency_verifier = ct_verifier;
}
void SetCTPolicyEnforcer(CTPolicyEnforcer* policy_enforcer) {
context_.ct_policy_enforcer = policy_enforcer;
}
// Starts the test server with SSL configuration |ssl_options|. Returns true
// on success.
bool StartTestServer(const SpawnedTestServer::SSLOptions& ssl_options) {
spawned_test_server_.reset(new SpawnedTestServer(
SpawnedTestServer::TYPE_HTTPS, ssl_options, base::FilePath()));
if (!spawned_test_server_->Start()) {
LOG(ERROR) << "Could not start SpawnedTestServer";
return false;
}
if (!spawned_test_server_->GetAddressList(&addr_)) {
LOG(ERROR) << "Could not get SpawnedTestServer address list";
return false;
}
return true;
}
std::unique_ptr<SSLClientSocket> CreateSSLClientSocket(
std::unique_ptr<StreamSocket> transport_socket,
const HostPortPair& host_and_port,
const SSLConfig& ssl_config) {
return socket_factory_->CreateSSLClientSocket(
std::move(transport_socket), host_and_port, ssl_config, context_);
}
// Create an SSLClientSocket object and use it to connect to a test server,
// then wait for connection results. This must be called after a successful
// StartTestServer() call.
//
// |ssl_config| The SSL configuration to use.
// |host_port_pair| The hostname and port to use at the SSL layer. (The
// socket connection will still be made to |spawned_test_server_|.)
// |result| will retrieve the ::Connect() result value.
//
// Returns true on success, false otherwise. Success means that the SSL
// socket could be created and its Connect() was called, not that the
// connection itself was a success.
bool CreateAndConnectSSLClientSocketWithHost(
const SSLConfig& ssl_config,
const HostPortPair& host_port_pair,
int* result) {
std::unique_ptr<StreamSocket> transport(
new TCPClientSocket(addr_, nullptr, &log_, NetLogSource()));
int rv = callback_.GetResult(transport->Connect(callback_.callback()));
if (rv != OK) {
LOG(ERROR) << "Could not connect to SpawnedTestServer";
return false;
}
sock_ =
CreateSSLClientSocket(std::move(transport), host_port_pair, ssl_config);
EXPECT_FALSE(sock_->IsConnected());
*result = callback_.GetResult(sock_->Connect(callback_.callback()));
return true;
}
bool CreateAndConnectSSLClientSocket(const SSLConfig& ssl_config,
int* result) {
return CreateAndConnectSSLClientSocketWithHost(
ssl_config, spawned_test_server()->host_port_pair(), result);
}
// Adds the server certificate with provided cert status.
// Must be called after StartTestServer has been called.
void AddServerCertStatusToSSLConfig(CertStatus status,
SSLConfig* ssl_config) {
ASSERT_TRUE(spawned_test_server());
// Find out the certificate the server is using.
scoped_refptr<X509Certificate> server_cert =
spawned_test_server()->GetCertificate();
// Get the MockCertVerifier to verify it as an EV cert.
CertVerifyResult verify_result;
verify_result.cert_status = status;
verify_result.verified_cert = server_cert;
cert_verifier_->AddResultForCert(server_cert.get(), verify_result, OK);
}
ClientSocketFactory* socket_factory_;
std::unique_ptr<MockCertVerifier> cert_verifier_;
std::unique_ptr<TransportSecurityState> transport_security_state_;
std::unique_ptr<DoNothingCTVerifier> ct_verifier_;
std::unique_ptr<MockCTPolicyEnforcer> ct_policy_enforcer_;
std::unique_ptr<SSLClientSessionCache> ssl_client_session_cache_;
SSLClientSocketContext context_;
std::unique_ptr<SSLClientSocket> sock_;
TestNetLog log_;
private:
std::unique_ptr<SpawnedTestServer> spawned_test_server_;
TestCompletionCallback callback_;
AddressList addr_;
};
// If GetParam(), try ReadIfReady() and fall back to Read() if needed.
class SSLClientSocketReadTest : public SSLClientSocketTest,
public ::testing::WithParamInterface<bool> {
protected:
SSLClientSocketReadTest()
: SSLClientSocketTest(), read_if_ready_enabled_(GetParam()) {}
void SetUp() override {
if (!read_if_ready_enabled()) {
scoped_feature_list_.InitAndDisableFeature(
Socket::kReadIfReadyExperiment);
}
}
// Convienient wrapper to call Read()/ReadIfReady() depending on whether
// ReadyIfReady() is enabled.
int Read(StreamSocket* socket,
IOBuffer* buf,
int buf_len,
CompletionOnceCallback callback) {
if (read_if_ready_enabled())
return socket->ReadIfReady(buf, buf_len, std::move(callback));
return socket->Read(buf, buf_len, std::move(callback));
}
// Wait for Read()/ReadIfReady() to complete.
int WaitForReadCompletion(StreamSocket* socket,
IOBuffer* buf,
int buf_len,
TestCompletionCallback* callback,
int rv) {
if (!read_if_ready_enabled())
return callback->GetResult(rv);
while (rv == ERR_IO_PENDING) {
rv = callback->GetResult(rv);
if (rv != OK)
return rv;
rv = socket->ReadIfReady(buf, buf_len, callback->callback());
}
return rv;
}
// Calls Read()/ReadIfReady() and waits for it to return data.
int ReadAndWaitForCompletion(StreamSocket* socket,
IOBuffer* buf,
int buf_len) {
TestCompletionCallback callback;
int rv = Read(socket, buf, buf_len, callback.callback());
return WaitForReadCompletion(socket, buf, buf_len, &callback, rv);
}
bool read_if_ready_enabled() const { return read_if_ready_enabled_; }
private:
base::test::ScopedFeatureList scoped_feature_list_;
const bool read_if_ready_enabled_;
};
INSTANTIATE_TEST_SUITE_P(/* no prefix */,
SSLClientSocketReadTest,
::testing::Bool());
// Verifies the correctness of GetSSLCertRequestInfo.
class SSLClientSocketCertRequestInfoTest : public SSLClientSocketTest {
protected:
// Creates a test server with the given SSLOptions, connects to it and returns
// the SSLCertRequestInfo reported by the socket.
scoped_refptr<SSLCertRequestInfo> GetCertRequest(
SpawnedTestServer::SSLOptions ssl_options) {
SpawnedTestServer spawned_test_server(SpawnedTestServer::TYPE_HTTPS,
ssl_options, base::FilePath());
if (!spawned_test_server.Start())
return nullptr;
AddressList addr;
if (!spawned_test_server.GetAddressList(&addr))
return nullptr;
TestCompletionCallback callback;
TestNetLog log;
std::unique_ptr<StreamSocket> transport(
new TCPClientSocket(addr, nullptr, &log, NetLogSource()));
int rv = callback.GetResult(transport->Connect(callback.callback()));
EXPECT_THAT(rv, IsOk());
std::unique_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
std::move(transport), spawned_test_server.host_port_pair(),
SSLConfig()));
EXPECT_FALSE(sock->IsConnected());
rv = callback.GetResult(sock->Connect(callback.callback()));
EXPECT_THAT(rv, IsError(ERR_SSL_CLIENT_AUTH_CERT_NEEDED));
scoped_refptr<SSLCertRequestInfo> request_info = new SSLCertRequestInfo();
sock->GetSSLCertRequestInfo(request_info.get());
sock->Disconnect();
EXPECT_FALSE(sock->IsConnected());
EXPECT_TRUE(spawned_test_server.host_port_pair().Equals(
request_info->host_and_port));
return request_info;
}
};
class SSLClientSocketFalseStartTest : public SSLClientSocketTest {
protected:
// Creates an SSLClientSocket with |client_config| attached to a
// FakeBlockingStreamSocket, returning both in |*out_raw_transport| and
// |*out_sock|. The FakeBlockingStreamSocket is owned by the SSLClientSocket,
// so |*out_raw_transport| is a raw pointer.
//
// The client socket will begin a connect using |callback| but stop before the
// server's finished message is received. The finished message will be blocked
// in |*out_raw_transport|. To complete the handshake and successfully read
// data, the caller must unblock reads on |*out_raw_transport|. (Note that, if
// the client successfully false started, |callback.WaitForResult()| will
// return OK without unblocking transport reads. But Read() will still block.)
//
// Must be called after StartTestServer is called.
void CreateAndConnectUntilServerFinishedReceived(
const SSLConfig& client_config,
TestCompletionCallback* callback,
FakeBlockingStreamSocket** out_raw_transport,
std::unique_ptr<SSLClientSocket>* out_sock) {
CHECK(spawned_test_server());
std::unique_ptr<StreamSocket> real_transport(
new TCPClientSocket(addr(), nullptr, nullptr, NetLogSource()));
std::unique_ptr<FakeBlockingStreamSocket> transport(
new FakeBlockingStreamSocket(std::move(real_transport)));
int rv = callback->GetResult(transport->Connect(callback->callback()));
EXPECT_THAT(rv, IsOk());
FakeBlockingStreamSocket* raw_transport = transport.get();
std::unique_ptr<SSLClientSocket> sock = CreateSSLClientSocket(
std::move(transport), spawned_test_server()->host_port_pair(),
client_config);
// Connect. Stop before the client processes the first server leg
// (ServerHello, etc.)
raw_transport->BlockReadResult();
rv = sock->Connect(callback->callback());
EXPECT_THAT(rv, IsError(ERR_IO_PENDING));
raw_transport->WaitForReadResult();
// Release the ServerHello and wait for the client to write
// ClientKeyExchange, etc. (A proxy for waiting for the entirety of the
// server's leg to complete, since it may span multiple reads.)
EXPECT_FALSE(callback->have_result());
raw_transport->BlockWrite();
raw_transport->UnblockReadResult();
raw_transport->WaitForWrite();
// And, finally, release that and block the next server leg
// (ChangeCipherSpec, Finished).
raw_transport->BlockReadResult();
raw_transport->UnblockWrite();
*out_raw_transport = raw_transport;
*out_sock = std::move(sock);
}
void TestFalseStart(const SpawnedTestServer::SSLOptions& server_options,
const SSLConfig& client_config,
bool expect_false_start) {
ASSERT_TRUE(StartTestServer(server_options));
TestCompletionCallback callback;
FakeBlockingStreamSocket* raw_transport = nullptr;
std::unique_ptr<SSLClientSocket> sock;
ASSERT_NO_FATAL_FAILURE(CreateAndConnectUntilServerFinishedReceived(
client_config, &callback, &raw_transport, &sock));
if (expect_false_start) {
// When False Starting, the handshake should complete before receiving the
// Change Cipher Spec and Finished messages.
//
// Note: callback.have_result() may not be true without waiting. The NSS
// state machine sometimes lives on a separate thread, so this thread may
// not yet have processed the signal that the handshake has completed.
int rv = callback.WaitForResult();
EXPECT_THAT(rv, IsOk());
EXPECT_TRUE(sock->IsConnected());
const char request_text[] = "GET / HTTP/1.0\r\n\r\n";
static const int kRequestTextSize =
static_cast<int>(base::size(request_text) - 1);
scoped_refptr<IOBuffer> request_buffer =
base::MakeRefCounted<IOBuffer>(kRequestTextSize);
memcpy(request_buffer->data(), request_text, kRequestTextSize);
// Write the request.
rv = callback.GetResult(sock->Write(request_buffer.get(),
kRequestTextSize, callback.callback(),
TRAFFIC_ANNOTATION_FOR_TESTS));
EXPECT_EQ(kRequestTextSize, rv);
// The read will hang; it's waiting for the peer to complete the
// handshake, and the handshake is still blocked.
scoped_refptr<IOBuffer> buf = base::MakeRefCounted<IOBuffer>(4096);
rv = sock->Read(buf.get(), 4096, callback.callback());
// After releasing reads, the connection proceeds.
raw_transport->UnblockReadResult();
rv = callback.GetResult(rv);
EXPECT_LT(0, rv);
} else {
// False Start is not enabled, so the handshake will not complete because
// the server second leg is blocked.
base::RunLoop().RunUntilIdle();
EXPECT_FALSE(callback.have_result());
}
}
};
// Provides a response to the 0RTT request indicating whether it was received
// as early data.
class ZeroRTTResponse : public test_server::HttpResponse {
public:
ZeroRTTResponse(bool zero_rtt) : zero_rtt_(zero_rtt) {}
~ZeroRTTResponse() override {}
void SendResponse(const test_server::SendBytesCallback& send,
const test_server::SendCompleteCallback& done) override {
std::string response;
if (zero_rtt_) {
response = "1";
} else {
response = "0";
}
// Since the EmbeddedTestServer doesn't keep the socket open by default, it
// is explicitly kept alive to allow the remaining leg of the 0RTT handshake
// to be received after the early data.
send.Run(response, base::BindRepeating([]() {}));
}
private:
bool zero_rtt_;
DISALLOW_COPY_AND_ASSIGN(ZeroRTTResponse);
};
std::unique_ptr<test_server::HttpResponse> HandleZeroRTTRequest(
const test_server::HttpRequest& request) {
if (request.GetURL().path() != "/zerortt")
return nullptr;
bool zero_rtt = false;
if (request.headers.find("Early-Data") != request.headers.end()) {
if (request.headers.at("Early-Data") == "1") {
zero_rtt = true;
}
}
return std::unique_ptr<ZeroRTTResponse>(new ZeroRTTResponse(zero_rtt));
}
class SSLClientSocketZeroRTTTest : public SSLClientSocketTest {
protected:
SSLClientSocketZeroRTTTest() : SSLClientSocketTest() {}
bool StartServer() {
test_server_.reset(
new EmbeddedTestServer(net::EmbeddedTestServer::TYPE_HTTPS));
SSLServerConfig server_config;
server_config.early_data_enabled = true;
server_config.version_max = SSL_PROTOCOL_VERSION_TLS1_3;
test_server_->AddDefaultHandlers(base::FilePath());
test_server_->RegisterRequestHandler(
base::BindRepeating(&HandleZeroRTTRequest));
test_server_->SetSSLConfig(net::EmbeddedTestServer::CERT_OK, server_config);
if (!test_server_->Start()) {
LOG(ERROR) << "Could not start EmbeddedTestServer";
return false;
}
if (!test_server_->GetAddressList(&address_)) {
LOG(ERROR) << "Could not get EmbeddedTestServer address list";
return false;
}
return true;
}
void SetServerConfig(SSLServerConfig server_config) {
test_server_->ResetSSLConfig(net::EmbeddedTestServer::CERT_OK,
server_config);
}
FakeBlockingStreamSocket* MakeClient(bool early_data_enabled) {
SSLConfig ssl_config;
ssl_config.version_max = SSL_PROTOCOL_VERSION_TLS1_3;
ssl_config.early_data_enabled = early_data_enabled;
real_transport_.reset(
new TCPClientSocket(address_, nullptr, nullptr, NetLogSource()));
std::unique_ptr<FakeBlockingStreamSocket> transport(
new FakeBlockingStreamSocket(std::move(real_transport_)));
FakeBlockingStreamSocket* raw_transport = transport.get();
int rv = callback_.GetResult(transport->Connect(callback_.callback()));
EXPECT_THAT(rv, IsOk());
ssl_socket_ = CreateSSLClientSocket(
std::move(transport), test_server_->host_port_pair(), ssl_config);
EXPECT_FALSE(ssl_socket_->IsConnected());
return raw_transport;
}
int Connect() {
return callback_.GetResult(ssl_socket_->Connect(callback_.callback()));
}
int WriteAndWait(base::StringPiece request) {
scoped_refptr<IOBuffer> request_buffer =
base::MakeRefCounted<IOBuffer>(request.size());
memcpy(request_buffer->data(), request.data(), request.size());
return callback_.GetResult(
ssl_socket_->Write(request_buffer.get(), request.size(),
callback_.callback(), TRAFFIC_ANNOTATION_FOR_TESTS));
}
int ReadAndWait(IOBuffer* buf, size_t len) {
return callback_.GetResult(
ssl_socket_->Read(buf, len, callback_.callback()));
}
bool GetSSLInfo(SSLInfo* ssl_info) {
return ssl_socket_->GetSSLInfo(ssl_info);
}
bool RunInitialConnection() {
if (MakeClient(true) == nullptr)
return false;
EXPECT_THAT(Connect(), IsOk());
// Use the socket for an HTTP request to ensure we've processed the
// post-handshake TLS 1.3 ticket.
constexpr base::StringPiece kRequest = "GET / HTTP/1.0\r\n\r\n";
if (kRequest.size() != WriteAndWait(kRequest))
return false;
scoped_refptr<IOBuffer> buf = base::MakeRefCounted<IOBuffer>(4096);
if (ReadAndWait(buf.get(), 4096) <= 0)
return false;
SSLInfo ssl_info;
EXPECT_TRUE(GetSSLInfo(&ssl_info));
return SSLInfo::HANDSHAKE_FULL == ssl_info.handshake_type;
}
SSLClientSocket* ssl_socket() { return ssl_socket_.get(); }
private:
std::unique_ptr<EmbeddedTestServer> test_server_;
AddressList address_;
TestCompletionCallback callback_;
std::unique_ptr<StreamSocket> real_transport_;
std::unique_ptr<SSLClientSocket> ssl_socket_;
};
// Returns a serialized unencrypted TLS 1.2 alert record for the given alert
// value.
std::string FormatTLS12Alert(uint8_t alert) {
std::string ret;
// ContentType.alert
ret.push_back(21);
// Record-layer version. Assume TLS 1.2.
ret.push_back(0x03);
ret.push_back(0x03);
// Record length.
ret.push_back(0);
ret.push_back(2);
// AlertLevel.fatal.
ret.push_back(2);
// The alert itself.
ret.push_back(alert);
return ret;
}
// A CertVerifier that never returns on any requests.
class HangingCertVerifier : public CertVerifier {
public:
int num_active_requests() const { return num_active_requests_; }
void WaitForRequest() {
if (!num_active_requests_) {
run_loop_.Run();
}
}
int Verify(const RequestParams& params,
CertVerifyResult* verify_result,
CompletionOnceCallback callback,
std::unique_ptr<Request>* out_req,
const NetLogWithSource& net_log) override {
*out_req = std::make_unique<HangingRequest>(this);
return ERR_IO_PENDING;
}
void SetConfig(const Config& config) override {}
private:
class HangingRequest : public Request {
public:
explicit HangingRequest(HangingCertVerifier* verifier)
: verifier_(verifier) {
verifier_->num_active_requests_++;
verifier_->run_loop_.Quit();
}
~HangingRequest() override { verifier_->num_active_requests_--; }
private:
HangingCertVerifier* verifier_;
};
base::RunLoop run_loop_;
int num_active_requests_ = 0;
};
} // namespace
TEST_F(SSLClientSocketTest, Connect) {
ASSERT_TRUE(StartTestServer(SpawnedTestServer::SSLOptions()));
TestCompletionCallback callback;
TestNetLog log;
std::unique_ptr<StreamSocket> transport(
new TCPClientSocket(addr(), nullptr, &log, NetLogSource()));
int rv = callback.GetResult(transport->Connect(callback.callback()));
EXPECT_THAT(rv, IsOk());
std::unique_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
std::move(transport), spawned_test_server()->host_port_pair(),
SSLConfig()));
EXPECT_FALSE(sock->IsConnected());
rv = sock->Connect(callback.callback());
TestNetLogEntry::List entries;
log.GetEntries(&entries);
EXPECT_TRUE(LogContainsBeginEvent(entries, 5, NetLogEventType::SSL_CONNECT));
if (rv == ERR_IO_PENDING)
rv = callback.WaitForResult();
EXPECT_THAT(rv, IsOk());
EXPECT_TRUE(sock->IsConnected());
log.GetEntries(&entries);
EXPECT_TRUE(LogContainsEndEvent(entries, -1, NetLogEventType::SSL_CONNECT));
sock->Disconnect();
EXPECT_FALSE(sock->IsConnected());
}
TEST_F(SSLClientSocketTest, ConnectAsyncVerify) {
ASSERT_TRUE(StartTestServer(SpawnedTestServer::SSLOptions()));
cert_verifier_->set_async(true);
int rv;
ASSERT_TRUE(CreateAndConnectSSLClientSocket(SSLConfig(), &rv));
EXPECT_THAT(rv, IsError(OK));
}
TEST_F(SSLClientSocketTest, ConnectExpired) {
SpawnedTestServer::SSLOptions ssl_options(
SpawnedTestServer::SSLOptions::CERT_EXPIRED);
ASSERT_TRUE(StartTestServer(ssl_options));
cert_verifier_->set_default_result(ERR_CERT_DATE_INVALID);
int rv;
ASSERT_TRUE(CreateAndConnectSSLClientSocket(SSLConfig(), &rv));
EXPECT_THAT(rv, IsError(ERR_CERT_DATE_INVALID));
// Rather than testing whether or not the underlying socket is connected,
// test that the handshake has finished. This is because it may be
// desirable to disconnect the socket before showing a user prompt, since
// the user may take indefinitely long to respond.
TestNetLogEntry::List entries;
log_.GetEntries(&entries);
EXPECT_TRUE(LogContainsEndEvent(entries, -1, NetLogEventType::SSL_CONNECT));
}
TEST_F(SSLClientSocketTest, ConnectExpiredAsyncVerify) {
SpawnedTestServer::SSLOptions ssl_options(
SpawnedTestServer::SSLOptions::CERT_EXPIRED);
ASSERT_TRUE(StartTestServer(ssl_options));
cert_verifier_->set_default_result(ERR_CERT_DATE_INVALID);
cert_verifier_->set_async(true);
int rv;
ASSERT_TRUE(CreateAndConnectSSLClientSocket(SSLConfig(), &rv));
EXPECT_THAT(rv, IsError(ERR_CERT_DATE_INVALID));
}
// Test that SSLClientSockets may be destroyed while waiting on a certificate
// verification.
TEST_F(SSLClientSocketTest, SocketDestroyedDuringVerify) {
ASSERT_TRUE(StartTestServer(SpawnedTestServer::SSLOptions()));
HangingCertVerifier verifier;
SetCertVerifier(&verifier);
TestCompletionCallback callback;
auto transport =
std::make_unique<TCPClientSocket>(addr(), nullptr, &log_, NetLogSource());
int rv = callback.GetResult(transport->Connect(callback.callback()));
ASSERT_THAT(rv, IsOk());
std::unique_ptr<SSLClientSocket> sock = CreateSSLClientSocket(
std::move(transport), spawned_test_server()->host_port_pair(),
SSLConfig());
rv = sock->Connect(callback.callback());
EXPECT_THAT(rv, IsError(ERR_IO_PENDING));
// The socket should attempt a certificate verification.
verifier.WaitForRequest();
EXPECT_EQ(1, verifier.num_active_requests());
// Destroying the socket should cancel it.
sock = nullptr;
EXPECT_EQ(0, verifier.num_active_requests());
}
TEST_F(SSLClientSocketTest, ConnectMismatched) {
SpawnedTestServer::SSLOptions ssl_options(
SpawnedTestServer::SSLOptions::CERT_MISMATCHED_NAME);
ASSERT_TRUE(StartTestServer(ssl_options));
cert_verifier_->set_default_result(ERR_CERT_COMMON_NAME_INVALID);
int rv;
ASSERT_TRUE(CreateAndConnectSSLClientSocket(SSLConfig(), &rv));
EXPECT_THAT(rv, IsError(ERR_CERT_COMMON_NAME_INVALID));
// Rather than testing whether or not the underlying socket is connected,
// test that the handshake has finished. This is because it may be
// desirable to disconnect the socket before showing a user prompt, since
// the user may take indefinitely long to respond.
TestNetLogEntry::List entries;
log_.GetEntries(&entries);
EXPECT_TRUE(LogContainsEndEvent(entries, -1, NetLogEventType::SSL_CONNECT));
}
// Tests that certificates parsable by SSLClientSocket's internal SSL
// implementation, but not X509Certificate are treated as fatal connection
// errors. This is a regression test for https://crbug.com/91341.
TEST_F(SSLClientSocketTest, ConnectBadValidity) {
SpawnedTestServer::SSLOptions ssl_options(
SpawnedTestServer::SSLOptions::CERT_BAD_VALIDITY);
ASSERT_TRUE(StartTestServer(ssl_options));
cert_verifier_->set_default_result(ERR_CERT_DATE_INVALID);
SSLConfig ssl_config;
int rv;
ASSERT_TRUE(CreateAndConnectSSLClientSocket(ssl_config, &rv));
EXPECT_THAT(rv, IsError(ERR_CERT_DATE_INVALID));
}
// Ignoring the certificate error from an invalid certificate should
// allow a complete connection.
TEST_F(SSLClientSocketTest, ConnectBadValidityIgnoreCertErrors) {
SpawnedTestServer::SSLOptions ssl_options(
SpawnedTestServer::SSLOptions::CERT_BAD_VALIDITY);
ASSERT_TRUE(StartTestServer(ssl_options));
cert_verifier_->set_default_result(ERR_CERT_DATE_INVALID);
SSLConfig ssl_config;
ssl_config.ignore_certificate_errors = true;
int rv;
CreateAndConnectSSLClientSocket(ssl_config, &rv);
EXPECT_THAT(rv, IsOk());
EXPECT_TRUE(sock_->IsConnected());
}
// Attempt to connect to a page which requests a client certificate. It should
// return an error code on connect.
TEST_F(SSLClientSocketTest, ConnectClientAuthCertRequested) {
SpawnedTestServer::SSLOptions ssl_options;
ssl_options.request_client_certificate = true;
ASSERT_TRUE(StartTestServer(ssl_options));
int rv;
ASSERT_TRUE(CreateAndConnectSSLClientSocket(SSLConfig(), &rv));
EXPECT_THAT(rv, IsError(ERR_SSL_CLIENT_AUTH_CERT_NEEDED));
TestNetLogEntry::List entries;
log_.GetEntries(&entries);
EXPECT_TRUE(LogContainsEndEvent(entries, -1, NetLogEventType::SSL_CONNECT));
EXPECT_FALSE(sock_->IsConnected());
}
// Connect to a server requesting optional client authentication. Send it a
// null certificate. It should allow the connection.
//
// TODO(davidben): Also test providing an actual certificate.
TEST_F(SSLClientSocketTest, ConnectClientAuthSendNullCert) {
SpawnedTestServer::SSLOptions ssl_options;
ssl_options.request_client_certificate = true;
ASSERT_TRUE(StartTestServer(ssl_options));
// Our test server accepts certificate-less connections.
// TODO(davidben): Add a test which requires them and verify the error.
SSLConfig ssl_config;
ssl_config.send_client_cert = true;
ssl_config.client_cert = nullptr;
int rv;
ASSERT_TRUE(CreateAndConnectSSLClientSocket(ssl_config, &rv));
EXPECT_THAT(rv, IsOk());
// We responded to the server's certificate request with a Certificate
// message with no client certificate in it. ssl_info.client_cert_sent
// should be false in this case.
SSLInfo ssl_info;
sock_->GetSSLInfo(&ssl_info);
EXPECT_FALSE(ssl_info.client_cert_sent);
sock_->Disconnect();
EXPECT_FALSE(sock_->IsConnected());
}
// TODO(wtc): Add unit tests for IsConnectedAndIdle:
// - Server closes an SSL connection (with a close_notify alert message).
// - Server closes the underlying TCP connection directly.
// - Server sends data unexpectedly.
// Tests that the socket can be read from successfully. Also test that a peer's
// close_notify alert is successfully processed without error.
TEST_P(SSLClientSocketReadTest, Read) {
ASSERT_TRUE(StartTestServer(SpawnedTestServer::SSLOptions()));
TestCompletionCallback callback;
std::unique_ptr<StreamSocket> transport(
new TCPClientSocket(addr(), nullptr, nullptr, NetLogSource()));
EXPECT_EQ(0, transport->GetTotalReceivedBytes());
int rv = callback.GetResult(transport->Connect(callback.callback()));
EXPECT_THAT(rv, IsOk());
std::unique_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
std::move(transport), spawned_test_server()->host_port_pair(),
SSLConfig()));
EXPECT_EQ(0, sock->GetTotalReceivedBytes());
rv = callback.GetResult(sock->Connect(callback.callback()));
EXPECT_THAT(rv, IsOk());
// Number of network bytes received should increase because of SSL socket
// establishment.
EXPECT_GT(sock->GetTotalReceivedBytes(), 0);
const char request_text[] = "GET / HTTP/1.0\r\n\r\n";
scoped_refptr<IOBuffer> request_buffer =
base::MakeRefCounted<IOBuffer>(base::size(request_text) - 1);
memcpy(request_buffer->data(), request_text, base::size(request_text) - 1);
rv = callback.GetResult(
sock->Write(request_buffer.get(), base::size(request_text) - 1,
callback.callback(), TRAFFIC_ANNOTATION_FOR_TESTS));
EXPECT_EQ(static_cast<int>(base::size(request_text) - 1), rv);
scoped_refptr<IOBuffer> buf = base::MakeRefCounted<IOBuffer>(4096);
int64_t unencrypted_bytes_read = 0;
int64_t network_bytes_read_during_handshake = sock->GetTotalReceivedBytes();
do {
rv = ReadAndWaitForCompletion(sock.get(), buf.get(), 4096);
EXPECT_GE(rv, 0);
if (rv >= 0) {
unencrypted_bytes_read += rv;
}
} while (rv > 0);
EXPECT_GT(unencrypted_bytes_read, 0);
// Reading the payload should increase the number of bytes on network layer.
EXPECT_GT(sock->GetTotalReceivedBytes(), network_bytes_read_during_handshake);
// Number of bytes received on the network after the handshake should be
// higher than the number of encrypted bytes read.
EXPECT_GE(sock->GetTotalReceivedBytes() - network_bytes_read_during_handshake,
unencrypted_bytes_read);
// The peer should have cleanly closed the connection with a close_notify.
EXPECT_EQ(0, rv);
}
// Tests that SSLClientSocket properly handles when the underlying transport
// synchronously fails a transport write in during the handshake.
TEST_F(SSLClientSocketTest, Connect_WithSynchronousError) {
ASSERT_TRUE(StartTestServer(SpawnedTestServer::SSLOptions()));
TestCompletionCallback callback;
std::unique_ptr<StreamSocket> real_transport(
new TCPClientSocket(addr(), nullptr, nullptr, NetLogSource()));
std::unique_ptr<SynchronousErrorStreamSocket> transport(
new SynchronousErrorStreamSocket(std::move(real_transport)));
int rv = callback.GetResult(transport->Connect(callback.callback()));
EXPECT_THAT(rv, IsOk());
// Disable TLS False Start to avoid handshake non-determinism.
SSLConfig ssl_config;
ssl_config.false_start_enabled = false;
SynchronousErrorStreamSocket* raw_transport = transport.get();
std::unique_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
std::move(transport), spawned_test_server()->host_port_pair(),
ssl_config));
raw_transport->SetNextWriteError(ERR_CONNECTION_RESET);
rv = callback.GetResult(sock->Connect(callback.callback()));
EXPECT_THAT(rv, IsError(ERR_CONNECTION_RESET));
EXPECT_FALSE(sock->IsConnected());
}
// Tests that the SSLClientSocket properly handles when the underlying transport
// synchronously returns an error code - such as if an intermediary terminates
// the socket connection uncleanly.
// This is a regression test for http://crbug.com/238536
TEST_P(SSLClientSocketReadTest, Read_WithSynchronousError) {
ASSERT_TRUE(StartTestServer(SpawnedTestServer::SSLOptions()));
TestCompletionCallback callback;
std::unique_ptr<StreamSocket> real_transport(
new TCPClientSocket(addr(), nullptr, nullptr, NetLogSource()));
std::unique_ptr<SynchronousErrorStreamSocket> transport(
new SynchronousErrorStreamSocket(std::move(real_transport)));
int rv = callback.GetResult(transport->Connect(callback.callback()));
EXPECT_THAT(rv, IsOk());
// Disable TLS False Start to avoid handshake non-determinism.
SSLConfig ssl_config;
ssl_config.false_start_enabled = false;
SynchronousErrorStreamSocket* raw_transport = transport.get();
std::unique_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
std::move(transport), spawned_test_server()->host_port_pair(),
ssl_config));
rv = callback.GetResult(sock->Connect(callback.callback()));
EXPECT_THAT(rv, IsOk());
EXPECT_TRUE(sock->IsConnected());
const char request_text[] = "GET / HTTP/1.0\r\n\r\n";
static const int kRequestTextSize =
static_cast<int>(base::size(request_text) - 1);
scoped_refptr<IOBuffer> request_buffer =
base::MakeRefCounted<IOBuffer>(kRequestTextSize);
memcpy(request_buffer->data(), request_text, kRequestTextSize);
rv = callback.GetResult(sock->Write(request_buffer.get(), kRequestTextSize,
callback.callback(),
TRAFFIC_ANNOTATION_FOR_TESTS));
EXPECT_EQ(kRequestTextSize, rv);
// Simulate an unclean/forcible shutdown.
raw_transport->SetNextReadError(ERR_CONNECTION_RESET);
scoped_refptr<IOBuffer> buf = base::MakeRefCounted<IOBuffer>(4096);
// Note: This test will hang if this bug has regressed. Simply checking that
// rv != ERR_IO_PENDING is insufficient, as ERR_IO_PENDING is a legitimate
// result when using a dedicated task runner for NSS.
rv = ReadAndWaitForCompletion(sock.get(), buf.get(), 4096);
EXPECT_THAT(rv, IsError(ERR_CONNECTION_RESET));
}
// Tests that the SSLClientSocket properly handles when the underlying transport
// asynchronously returns an error code while writing data - such as if an
// intermediary terminates the socket connection uncleanly.
// This is a regression test for http://crbug.com/249848
TEST_F(SSLClientSocketTest, Write_WithSynchronousError) {
ASSERT_TRUE(StartTestServer(SpawnedTestServer::SSLOptions()));
TestCompletionCallback callback;
std::unique_ptr<StreamSocket> real_transport(
new TCPClientSocket(addr(), nullptr, nullptr, NetLogSource()));
// Note: |error_socket|'s ownership is handed to |transport|, but a pointer
// is retained in order to configure additional errors.
std::unique_ptr<SynchronousErrorStreamSocket> error_socket(
new SynchronousErrorStreamSocket(std::move(real_transport)));
SynchronousErrorStreamSocket* raw_error_socket = error_socket.get();
std::unique_ptr<FakeBlockingStreamSocket> transport(
new FakeBlockingStreamSocket(std::move(error_socket)));
FakeBlockingStreamSocket* raw_transport = transport.get();
int rv = callback.GetResult(transport->Connect(callback.callback()));
EXPECT_THAT(rv, IsOk());
// Disable TLS False Start to avoid handshake non-determinism.
SSLConfig ssl_config;
ssl_config.false_start_enabled = false;
std::unique_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
std::move(transport), spawned_test_server()->host_port_pair(),
ssl_config));
rv = callback.GetResult(sock->Connect(callback.callback()));
EXPECT_THAT(rv, IsOk());
EXPECT_TRUE(sock->IsConnected());
const char request_text[] = "GET / HTTP/1.0\r\n\r\n";
static const int kRequestTextSize =
static_cast<int>(base::size(request_text) - 1);
scoped_refptr<IOBuffer> request_buffer =
base::MakeRefCounted<IOBuffer>(kRequestTextSize);
memcpy(request_buffer->data(), request_text, kRequestTextSize);
// Simulate an unclean/forcible shutdown on the underlying socket.
// However, simulate this error asynchronously.
raw_error_socket->SetNextWriteError(ERR_CONNECTION_RESET);
raw_transport->BlockWrite();
// This write should complete synchronously, because the TLS ciphertext
// can be created and placed into the outgoing buffers independent of the
// underlying transport.
rv = callback.GetResult(sock->Write(request_buffer.get(), kRequestTextSize,
callback.callback(),
TRAFFIC_ANNOTATION_FOR_TESTS));
EXPECT_EQ(kRequestTextSize, rv);
scoped_refptr<IOBuffer> buf = base::MakeRefCounted<IOBuffer>(4096);
rv = sock->Read(buf.get(), 4096, callback.callback());
EXPECT_THAT(rv, IsError(ERR_IO_PENDING));
// Now unblock the outgoing request, having it fail with the connection
// being reset.
raw_transport->UnblockWrite();
// Note: This will cause an inifite loop if this bug has regressed. Simply
// checking that rv != ERR_IO_PENDING is insufficient, as ERR_IO_PENDING
// is a legitimate result when using a dedicated task runner for NSS.
rv = callback.GetResult(rv);
EXPECT_THAT(rv, IsError(ERR_CONNECTION_RESET));
}
// If there is a Write failure at the transport with no follow-up Read, although
// the write error will not be returned to the client until a future Read or
// Write operation, SSLClientSocket should not spin attempting to re-write on
// the socket. This is a regression test for part of https://crbug.com/381160.
TEST_F(SSLClientSocketTest, Write_WithSynchronousErrorNoRead) {
ASSERT_TRUE(StartTestServer(SpawnedTestServer::SSLOptions()));
TestCompletionCallback callback;
std::unique_ptr<StreamSocket> real_transport(
new TCPClientSocket(addr(), nullptr, nullptr, NetLogSource()));
// Note: intermediate sockets' ownership are handed to |sock|, but a pointer
// is retained in order to query them.
std::unique_ptr<SynchronousErrorStreamSocket> error_socket(
new SynchronousErrorStreamSocket(std::move(real_transport)));
SynchronousErrorStreamSocket* raw_error_socket = error_socket.get();
std::unique_ptr<CountingStreamSocket> counting_socket(
new CountingStreamSocket(std::move(error_socket)));
CountingStreamSocket* raw_counting_socket = counting_socket.get();
int rv = callback.GetResult(counting_socket->Connect(callback.callback()));
ASSERT_THAT(rv, IsOk());
// Disable TLS False Start to avoid handshake non-determinism.
SSLConfig ssl_config;
ssl_config.false_start_enabled = false;
std::unique_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
std::move(counting_socket), spawned_test_server()->host_port_pair(),
ssl_config));
rv = callback.GetResult(sock->Connect(callback.callback()));
ASSERT_THAT(rv, IsOk());
ASSERT_TRUE(sock->IsConnected());
// Simulate an unclean/forcible shutdown on the underlying socket.
raw_error_socket->SetNextWriteError(ERR_CONNECTION_RESET);
const char request_text[] = "GET / HTTP/1.0\r\n\r\n";
static const int kRequestTextSize =
static_cast<int>(base::size(request_text) - 1);
scoped_refptr<IOBuffer> request_buffer =
base::MakeRefCounted<IOBuffer>(kRequestTextSize);
memcpy(request_buffer->data(), request_text, kRequestTextSize);
// This write should complete synchronously, because the TLS ciphertext
// can be created and placed into the outgoing buffers independent of the
// underlying transport.
rv = callback.GetResult(sock->Write(request_buffer.get(), kRequestTextSize,
callback.callback(),
TRAFFIC_ANNOTATION_FOR_TESTS));
ASSERT_EQ(kRequestTextSize, rv);
// Let the event loop spin for a little bit of time. Even on platforms where
// pumping the state machine involve thread hops, there should be no further
// writes on the transport socket.
//
// TODO(davidben): Avoid the arbitrary timeout?
int old_write_count = raw_counting_socket->write_count();
base::RunLoop loop;
base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(
FROM_HERE, loop.QuitClosure(), base::TimeDelta::FromMilliseconds(100));
loop.Run();
EXPECT_EQ(old_write_count, raw_counting_socket->write_count());
}
// Test the full duplex mode, with Read and Write pending at the same time.
// This test also serves as a regression test for http://crbug.com/29815.
TEST_P(SSLClientSocketReadTest, Read_FullDuplex) {
ASSERT_TRUE(StartTestServer(SpawnedTestServer::SSLOptions()));
int rv;
ASSERT_TRUE(CreateAndConnectSSLClientSocket(SSLConfig(), &rv));
EXPECT_THAT(rv, IsOk());
// Issue a "hanging" Read first.
TestCompletionCallback callback;
scoped_refptr<IOBuffer> buf = base::MakeRefCounted<IOBuffer>(4096);
rv = Read(sock_.get(), buf.get(), 4096, callback.callback());
// We haven't written the request, so there should be no response yet.
ASSERT_THAT(rv, IsError(ERR_IO_PENDING));
// Write the request.
// The request is padded with a User-Agent header to a size that causes the
// memio circular buffer (4k bytes) in SSLClientSocketNSS to wrap around.
// This tests the fix for http://crbug.com/29815.
std::string request_text = "GET / HTTP/1.1\r\nUser-Agent: long browser name ";
for (int i = 0; i < 3770; ++i)
request_text.push_back('*');
request_text.append("\r\n\r\n");
scoped_refptr<IOBuffer> request_buffer =
base::MakeRefCounted<StringIOBuffer>(request_text);
TestCompletionCallback callback2; // Used for Write only.
rv = callback2.GetResult(
sock_->Write(request_buffer.get(), request_text.size(),
callback2.callback(), TRAFFIC_ANNOTATION_FOR_TESTS));
EXPECT_EQ(static_cast<int>(request_text.size()), rv);
// Now get the Read result.
rv = WaitForReadCompletion(sock_.get(), buf.get(), 4096, &callback, rv);
EXPECT_GT(rv, 0);
}
// Attempts to Read() and Write() from an SSLClientSocketNSS in full duplex
// mode when the underlying transport is blocked on sending data. When the
// underlying transport completes due to an error, it should invoke both the
// Read() and Write() callbacks. If the socket is deleted by the Read()
// callback, the Write() callback should not be invoked.
// Regression test for http://crbug.com/232633
TEST_P(SSLClientSocketReadTest, Read_DeleteWhilePendingFullDuplex) {
ASSERT_TRUE(StartTestServer(SpawnedTestServer::SSLOptions()));
TestCompletionCallback callback;
std::unique_ptr<StreamSocket> real_transport(
new TCPClientSocket(addr(), nullptr, nullptr, NetLogSource()));
// Note: |error_socket|'s ownership is handed to |transport|, but a pointer
// is retained in order to configure additional errors.
std::unique_ptr<SynchronousErrorStreamSocket> error_socket(
new SynchronousErrorStreamSocket(std::move(real_transport)));
SynchronousErrorStreamSocket* raw_error_socket = error_socket.get();
std::unique_ptr<FakeBlockingStreamSocket> transport(
new FakeBlockingStreamSocket(std::move(error_socket)));
FakeBlockingStreamSocket* raw_transport = transport.get();
int rv = callback.GetResult(transport->Connect(callback.callback()));
EXPECT_THAT(rv, IsOk());
// Disable TLS False Start to avoid handshake non-determinism.
SSLConfig ssl_config;
ssl_config.false_start_enabled = false;
std::unique_ptr<SSLClientSocket> sock = CreateSSLClientSocket(
std::move(transport), spawned_test_server()->host_port_pair(),
ssl_config);
rv = callback.GetResult(sock->Connect(callback.callback()));
EXPECT_THAT(rv, IsOk());
EXPECT_TRUE(sock->IsConnected());
std::string request_text = "GET / HTTP/1.1\r\nUser-Agent: long browser name ";
request_text.append(20 * 1024, '*');
request_text.append("\r\n\r\n");
scoped_refptr<DrainableIOBuffer> request_buffer =
base::MakeRefCounted<DrainableIOBuffer>(
base::MakeRefCounted<StringIOBuffer>(request_text),
request_text.size());
// Simulate errors being returned from the underlying Read() and Write() ...
raw_error_socket->SetNextReadError(ERR_CONNECTION_RESET);
raw_error_socket->SetNextWriteError(ERR_CONNECTION_RESET);
// ... but have those errors returned asynchronously. Because the Write() will
// return first, this will trigger the error.
raw_transport->BlockReadResult();
raw_transport->BlockWrite();
// Enqueue a Read() before calling Write(), which should "hang" due to
// the ERR_IO_PENDING caused by SetReadShouldBlock() and thus return.
SSLClientSocket* raw_sock = sock.get();
DeleteSocketCallback read_callback(sock.release());
scoped_refptr<IOBuffer> read_buf = base::MakeRefCounted<IOBuffer>(4096);
rv = Read(raw_sock, read_buf.get(), 4096, read_callback.callback());
// Ensure things didn't complete synchronously, otherwise |sock| is invalid.
ASSERT_THAT(rv, IsError(ERR_IO_PENDING));
ASSERT_FALSE(read_callback.have_result());
// Attempt to write the remaining data. OpenSSL will return that its blocked
// because the underlying transport is blocked.
rv = raw_sock->Write(request_buffer.get(), request_buffer->BytesRemaining(),
callback.callback(), TRAFFIC_ANNOTATION_FOR_TESTS);
ASSERT_THAT(rv, IsError(ERR_IO_PENDING));
ASSERT_FALSE(callback.have_result());
// Now unblock Write(), which will invoke OnSendComplete and (eventually)
// call the Read() callback, deleting the socket and thus aborting calling
// the Write() callback.
raw_transport->UnblockWrite();
// |read_callback| deletes |sock| so if ReadIfReady() is used, we will get OK
// asynchronously but can't continue reading because the socket is gone.
rv = read_callback.WaitForResult();
if (read_if_ready_enabled()) {
EXPECT_THAT(rv, IsOk());
} else {
EXPECT_THAT(rv, IsError(ERR_CONNECTION_RESET));
}
// The Write callback should not have been called.
EXPECT_FALSE(callback.have_result());
}
// Tests that the SSLClientSocket does not crash if data is received on the
// transport socket after a failing write. This can occur if we have a Write
// error in a SPDY socket.
// Regression test for http://crbug.com/335557
TEST_P(SSLClientSocketReadTest, Read_WithWriteError) {
ASSERT_TRUE(StartTestServer(SpawnedTestServer::SSLOptions()));
TestCompletionCallback callback;
std::unique_ptr<StreamSocket> real_transport(
new TCPClientSocket(addr(), nullptr, nullptr, NetLogSource()));
// Note: |error_socket|'s ownership is handed to |transport|, but a pointer
// is retained in order to configure additional errors.
std::unique_ptr<SynchronousErrorStreamSocket> error_socket(
new SynchronousErrorStreamSocket(std::move(real_transport)));
SynchronousErrorStreamSocket* raw_error_socket = error_socket.get();
std::unique_ptr<FakeBlockingStreamSocket> transport(
new FakeBlockingStreamSocket(std::move(error_socket)));
FakeBlockingStreamSocket* raw_transport = transport.get();
int rv = callback.GetResult(transport->Connect(callback.callback()));
EXPECT_THAT(rv, IsOk());
// Disable TLS False Start to avoid handshake non-determinism.
SSLConfig ssl_config;
ssl_config.false_start_enabled = false;
std::unique_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
std::move(transport), spawned_test_server()->host_port_pair(),
ssl_config));
rv = callback.GetResult(sock->Connect(callback.callback()));
EXPECT_THAT(rv, IsOk());
EXPECT_TRUE(sock->IsConnected());
// Send a request so there is something to read from the socket.
const char request_text[] = "GET / HTTP/1.0\r\n\r\n";
static const int kRequestTextSize =
static_cast<int>(base::size(request_text) - 1);
scoped_refptr<IOBuffer> request_buffer =
base::MakeRefCounted<IOBuffer>(kRequestTextSize);
memcpy(request_buffer->data(), request_text, kRequestTextSize);
rv = callback.GetResult(sock->Write(request_buffer.get(), kRequestTextSize,
callback.callback(),
TRAFFIC_ANNOTATION_FOR_TESTS));
EXPECT_EQ(kRequestTextSize, rv);
// Start a hanging read.
TestCompletionCallback read_callback;
raw_transport->BlockReadResult();
scoped_refptr<IOBuffer> buf = base::MakeRefCounted<IOBuffer>(4096);
rv = Read(sock.get(), buf.get(), 4096, read_callback.callback());
EXPECT_THAT(rv, IsError(ERR_IO_PENDING));
// Perform another write, but have it fail. Write a request larger than the
// internal socket buffers so that the request hits the underlying transport
// socket and detects the error.
std::string long_request_text =
"GET / HTTP/1.1\r\nUser-Agent: long browser name ";
long_request_text.append(20 * 1024, '*');
long_request_text.append("\r\n\r\n");
scoped_refptr<DrainableIOBuffer> long_request_buffer =
base::MakeRefCounted<DrainableIOBuffer>(
base::MakeRefCounted<StringIOBuffer>(long_request_text),
long_request_text.size());
raw_error_socket->SetNextWriteError(ERR_CONNECTION_RESET);
// Write as much data as possible until hitting an error.
do {
rv = callback.GetResult(sock->Write(
long_request_buffer.get(), long_request_buffer->BytesRemaining(),
callback.callback(), TRAFFIC_ANNOTATION_FOR_TESTS));
if (rv > 0) {
long_request_buffer->DidConsume(rv);
// Abort if the entire input is ever consumed. The input is larger than
// the SSLClientSocket's write buffers.
ASSERT_LT(0, long_request_buffer->BytesRemaining());
}
} while (rv > 0);
EXPECT_THAT(rv, IsError(ERR_CONNECTION_RESET));
// At this point the Read result is available. Transport write errors are
// surfaced through Writes. See https://crbug.com/249848.
rv = WaitForReadCompletion(sock.get(), buf.get(), 4096, &read_callback, rv);
EXPECT_THAT(rv, IsError(ERR_CONNECTION_RESET));
// Release the read. This does not cause a crash.
raw_transport->UnblockReadResult();
base::RunLoop().RunUntilIdle();
}
// Tests that SSLClientSocket fails the handshake if the underlying
// transport is cleanly closed.
TEST_F(SSLClientSocketTest, Connect_WithZeroReturn) {
ASSERT_TRUE(StartTestServer(SpawnedTestServer::SSLOptions()));
TestCompletionCallback callback;
std::unique_ptr<StreamSocket> real_transport(
new TCPClientSocket(addr(), nullptr, nullptr, NetLogSource()));
std::unique_ptr<SynchronousErrorStreamSocket> transport(
new SynchronousErrorStreamSocket(std::move(real_transport)));
int rv = callback.GetResult(transport->Connect(callback.callback()));
EXPECT_THAT(rv, IsOk());
SynchronousErrorStreamSocket* raw_transport = transport.get();
std::unique_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
std::move(transport), spawned_test_server()->host_port_pair(),
SSLConfig()));
raw_transport->SetNextReadError(0);
rv = callback.GetResult(sock->Connect(callback.callback()));
EXPECT_THAT(rv, IsError(ERR_CONNECTION_CLOSED));
EXPECT_FALSE(sock->IsConnected());
}
// Tests that SSLClientSocket returns a Read of size 0 if the underlying socket
// is cleanly closed, but the peer does not send close_notify.
// This is a regression test for https://crbug.com/422246
TEST_P(SSLClientSocketReadTest, Read_WithZeroReturn) {
ASSERT_TRUE(StartTestServer(SpawnedTestServer::SSLOptions()));
TestCompletionCallback callback;
std::unique_ptr<StreamSocket> real_transport(
new TCPClientSocket(addr(), nullptr, nullptr, NetLogSource()));
std::unique_ptr<SynchronousErrorStreamSocket> transport(
new SynchronousErrorStreamSocket(std::move(real_transport)));
int rv = callback.GetResult(transport->Connect(callback.callback()));
EXPECT_THAT(rv, IsOk());
// Disable TLS False Start to ensure the handshake has completed.
SSLConfig ssl_config;
ssl_config.false_start_enabled = false;
SynchronousErrorStreamSocket* raw_transport = transport.get();
std::unique_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
std::move(transport), spawned_test_server()->host_port_pair(),
ssl_config));
rv = callback.GetResult(sock->Connect(callback.callback()));
EXPECT_THAT(rv, IsOk());
EXPECT_TRUE(sock->IsConnected());
raw_transport->SetNextReadError(0);
scoped_refptr<IOBuffer> buf = base::MakeRefCounted<IOBuffer>(4096);
rv = ReadAndWaitForCompletion(sock.get(), buf.get(), 4096);
EXPECT_EQ(0, rv);
}
// Tests that SSLClientSocket cleanly returns a Read of size 0 if the
// underlying socket is cleanly closed asynchronously.
// This is a regression test for https://crbug.com/422246
TEST_P(SSLClientSocketReadTest, Read_WithAsyncZeroReturn) {
ASSERT_TRUE(StartTestServer(SpawnedTestServer::SSLOptions()));
TestCompletionCallback callback;
std::unique_ptr<StreamSocket> real_transport(
new TCPClientSocket(addr(), nullptr, nullptr, NetLogSource()));
std::unique_ptr<SynchronousErrorStreamSocket> error_socket(
new SynchronousErrorStreamSocket(std::move(real_transport)));
SynchronousErrorStreamSocket* raw_error_socket = error_socket.get();
std::unique_ptr<FakeBlockingStreamSocket> transport(
new FakeBlockingStreamSocket(std::move(error_socket)));
FakeBlockingStreamSocket* raw_transport = transport.get();
int rv = callback.GetResult(transport->Connect(callback.callback()));
EXPECT_THAT(rv, IsOk());
// Disable TLS False Start to ensure the handshake has completed.
SSLConfig ssl_config;
ssl_config.false_start_enabled = false;
std::unique_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
std::move(transport), spawned_test_server()->host_port_pair(),
ssl_config));
rv = callback.GetResult(sock->Connect(callback.callback()));
EXPECT_THAT(rv, IsOk());
EXPECT_TRUE(sock->IsConnected());
raw_error_socket->SetNextReadError(0);
raw_transport->BlockReadResult();
scoped_refptr<IOBuffer> buf = base::MakeRefCounted<IOBuffer>(4096);
TestCompletionCallback read_callback;
rv = Read(sock.get(), buf.get(), 4096, read_callback.callback());
EXPECT_THAT(rv, IsError(ERR_IO_PENDING));
raw_transport->UnblockReadResult();
rv = WaitForReadCompletion(sock.get(), buf.get(), 4096, &read_callback, rv);
EXPECT_EQ(0, rv);
}
// Tests that fatal alerts from the peer are processed. This is a regression
// test for https://crbug.com/466303.
TEST_P(SSLClientSocketReadTest, Read_WithFatalAlert) {
SpawnedTestServer::SSLOptions ssl_options;
ssl_options.alert_after_handshake = true;
ASSERT_TRUE(StartTestServer(ssl_options));
int rv;
ASSERT_TRUE(CreateAndConnectSSLClientSocket(SSLConfig(), &rv));
EXPECT_THAT(rv, IsOk());
// Receive the fatal alert.
TestCompletionCallback callback;
scoped_refptr<IOBuffer> buf = base::MakeRefCounted<IOBuffer>(4096);
EXPECT_EQ(ERR_SSL_PROTOCOL_ERROR,
ReadAndWaitForCompletion(sock_.get(), buf.get(), 4096));
}
TEST_P(SSLClientSocketReadTest, Read_SmallChunks) {
ASSERT_TRUE(StartTestServer(SpawnedTestServer::SSLOptions()));
int rv;
ASSERT_TRUE(CreateAndConnectSSLClientSocket(SSLConfig(), &rv));
EXPECT_THAT(rv, IsOk());
const char request_text[] = "GET / HTTP/1.0\r\n\r\n";
scoped_refptr<IOBuffer> request_buffer =
base::MakeRefCounted<IOBuffer>(base::size(request_text) - 1);
memcpy(request_buffer->data(), request_text, base::size(request_text) - 1);
TestCompletionCallback callback;
rv = callback.GetResult(
sock_->Write(request_buffer.get(), base::size(request_text) - 1,
callback.callback(), TRAFFIC_ANNOTATION_FOR_TESTS));
EXPECT_EQ(static_cast<int>(base::size(request_text) - 1), rv);
scoped_refptr<IOBuffer> buf = base::MakeRefCounted<IOBuffer>(1);
do {
rv = ReadAndWaitForCompletion(sock_.get(), buf.get(), 1);
EXPECT_GE(rv, 0);
} while (rv > 0);
}
TEST_P(SSLClientSocketReadTest, Read_ManySmallRecords) {
ASSERT_TRUE(StartTestServer(SpawnedTestServer::SSLOptions()));
TestCompletionCallback callback;
std::unique_ptr<StreamSocket> real_transport(
new TCPClientSocket(addr(), nullptr, nullptr, NetLogSource()));
std::unique_ptr<ReadBufferingStreamSocket> transport(
new ReadBufferingStreamSocket(std::move(real_transport)));
ReadBufferingStreamSocket* raw_transport = transport.get();
int rv = callback.GetResult(transport->Connect(callback.callback()));
ASSERT_THAT(rv, IsOk());
std::unique_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
std::move(transport), spawned_test_server()->host_port_pair(),
SSLConfig()));
rv = callback.GetResult(sock->Connect(callback.callback()));
ASSERT_THAT(rv, IsOk());
ASSERT_TRUE(sock->IsConnected());
const char request_text[] = "GET /ssl-many-small-records HTTP/1.0\r\n\r\n";
scoped_refptr<IOBuffer> request_buffer =
base::MakeRefCounted<IOBuffer>(base::size(request_text) - 1);
memcpy(request_buffer->data(), request_text, base::size(request_text) - 1);
rv = callback.GetResult(
sock->Write(request_buffer.get(), base::size(request_text) - 1,
callback.callback(), TRAFFIC_ANNOTATION_FOR_TESTS));
ASSERT_GT(rv, 0);
ASSERT_EQ(static_cast<int>(base::size(request_text) - 1), rv);
// Note: This relies on SSLClientSocketNSS attempting to read up to 17K of
// data (the max SSL record size) at a time. Ensure that at least 15K worth
// of SSL data is buffered first. The 15K of buffered data is made up of
// many smaller SSL records (the TestServer writes along 1350 byte
// plaintext boundaries), although there may also be a few records that are
// smaller or larger, due to timing and SSL False Start.
// 15K was chosen because 15K is smaller than the 17K (max) read issued by
// the SSLClientSocket implementation, and larger than the minimum amount
// of ciphertext necessary to contain the 8K of plaintext requested below.
raw_transport->SetBufferSize(15000);
scoped_refptr<IOBuffer> buffer = base::MakeRefCounted<IOBuffer>(8192);
rv = ReadAndWaitForCompletion(sock.get(), buffer.get(), 8192);
ASSERT_EQ(rv, 8192);
}
TEST_P(SSLClientSocketReadTest, Read_Interrupted) {
ASSERT_TRUE(StartTestServer(SpawnedTestServer::SSLOptions()));
int rv;
ASSERT_TRUE(CreateAndConnectSSLClientSocket(SSLConfig(), &rv));
EXPECT_THAT(rv, IsOk());
const char request_text[] = "GET / HTTP/1.0\r\n\r\n";
scoped_refptr<IOBuffer> request_buffer =
base::MakeRefCounted<IOBuffer>(base::size(request_text) - 1);
memcpy(request_buffer->data(), request_text, base::size(request_text) - 1);
TestCompletionCallback callback;
rv = callback.GetResult(
sock_->Write(request_buffer.get(), base::size(request_text) - 1,
callback.callback(), TRAFFIC_ANNOTATION_FOR_TESTS));
EXPECT_EQ(static_cast<int>(base::size(request_text) - 1), rv);
// Do a partial read and then exit. This test should not crash!
scoped_refptr<IOBuffer> buf = base::MakeRefCounted<IOBuffer>(512);
rv = ReadAndWaitForCompletion(sock_.get(), buf.get(), 512);
EXPECT_GT(rv, 0);
}
TEST_P(SSLClientSocketReadTest, Read_FullLogging) {
ASSERT_TRUE(StartTestServer(SpawnedTestServer::SSLOptions()));
TestCompletionCallback callback;
TestNetLog log;
log.SetCaptureMode(NetLogCaptureMode::IncludeSocketBytes());
std::unique_ptr<StreamSocket> transport(
new TCPClientSocket(addr(), nullptr, &log, NetLogSource()));
int rv = callback.GetResult(transport->Connect(callback.callback()));
EXPECT_THAT(rv, IsOk());
std::unique_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
std::move(transport), spawned_test_server()->host_port_pair(),
SSLConfig()));
rv = callback.GetResult(sock->Connect(callback.callback()));
EXPECT_THAT(rv, IsOk());
EXPECT_TRUE(sock->IsConnected());
const char request_text[] = "GET / HTTP/1.0\r\n\r\n";
scoped_refptr<IOBuffer> request_buffer =
base::MakeRefCounted<IOBuffer>(base::size(request_text) - 1);
memcpy(request_buffer->data(), request_text, base::size(request_text) - 1);
rv = callback.GetResult(
sock->Write(request_buffer.get(), base::size(request_text) - 1,
callback.callback(), TRAFFIC_ANNOTATION_FOR_TESTS));
EXPECT_EQ(static_cast<int>(base::size(request_text) - 1), rv);
TestNetLogEntry::List entries;
log.GetEntries(&entries);
size_t last_index = ExpectLogContainsSomewhereAfter(
entries, 5, NetLogEventType::SSL_SOCKET_BYTES_SENT,
NetLogEventPhase::NONE);
scoped_refptr<IOBuffer> buf = base::MakeRefCounted<IOBuffer>(4096);
for (;;) {
rv = ReadAndWaitForCompletion(sock.get(), buf.get(), 4096);
EXPECT_GE(rv, 0);
if (rv <= 0)
break;
log.GetEntries(&entries);
last_index = ExpectLogContainsSomewhereAfter(
entries, last_index + 1, NetLogEventType::SSL_SOCKET_BYTES_RECEIVED,
NetLogEventPhase::NONE);
}
}
// Regression test for http://crbug.com/42538
TEST_F(SSLClientSocketTest, PrematureApplicationData) {
ASSERT_TRUE(StartTestServer(SpawnedTestServer::SSLOptions()));
static const unsigned char application_data[] = {
0x17, 0x03, 0x01, 0x00, 0x4a, 0x02, 0x00, 0x00, 0x46, 0x03, 0x01, 0x4b,
0xc2, 0xf8, 0xb2, 0xc1, 0x56, 0x42, 0xb9, 0x57, 0x7f, 0xde, 0x87, 0x46,
0xf7, 0xa3, 0x52, 0x42, 0x21, 0xf0, 0x13, 0x1c, 0x9c, 0x83, 0x88, 0xd6,
0x93, 0x0c, 0xf6, 0x36, 0x30, 0x05, 0x7e, 0x20, 0xb5, 0xb5, 0x73, 0x36,
0x53, 0x83, 0x0a, 0xfc, 0x17, 0x63, 0xbf, 0xa0, 0xe4, 0x42, 0x90, 0x0d,
0x2f, 0x18, 0x6d, 0x20, 0xd8, 0x36, 0x3f, 0xfc, 0xe6, 0x01, 0xfa, 0x0f,
0xa5, 0x75, 0x7f, 0x09, 0x00, 0x04, 0x00, 0x16, 0x03, 0x01, 0x11, 0x57,
0x0b, 0x00, 0x11, 0x53, 0x00, 0x11, 0x50, 0x00, 0x06, 0x22, 0x30, 0x82,
0x06, 0x1e, 0x30, 0x82, 0x05, 0x06, 0xa0, 0x03, 0x02, 0x01, 0x02, 0x02,
0x0a};
// All reads and writes complete synchronously (async=false).
MockRead data_reads[] = {
MockRead(SYNCHRONOUS, reinterpret_cast<const char*>(application_data),
base::size(application_data)),
MockRead(SYNCHRONOUS, OK),
};
StaticSocketDataProvider data(data_reads, base::span<MockWrite>());
TestCompletionCallback callback;
std::unique_ptr<StreamSocket> transport(
new MockTCPClientSocket(addr(), nullptr, &data));
int rv = callback.GetResult(transport->Connect(callback.callback()));
EXPECT_THAT(rv, IsOk());
std::unique_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
std::move(transport), spawned_test_server()->host_port_pair(),
SSLConfig()));
rv = callback.GetResult(sock->Connect(callback.callback()));
EXPECT_THAT(rv, IsError(ERR_SSL_PROTOCOL_ERROR));
}
TEST_F(SSLClientSocketTest, CipherSuiteDisables) {
// Rather than exhaustively disabling every AES_128_CBC ciphersuite defined at
// http://www.iana.org/assignments/tls-parameters/tls-parameters.xml, only
// disabling those cipher suites that the test server actually implements.
const uint16_t kCiphersToDisable[] = {
0x002f, // TLS_RSA_WITH_AES_128_CBC_SHA
0x0033, // TLS_DHE_RSA_WITH_AES_128_CBC_SHA
0xc013, // TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA
};
SpawnedTestServer::SSLOptions ssl_options;
// Enable only AES_128_CBC on the test server.
ssl_options.bulk_ciphers = SpawnedTestServer::SSLOptions::BULK_CIPHER_AES128;
ASSERT_TRUE(StartTestServer(ssl_options));
SSLConfig ssl_config;
for (size_t i = 0; i < base::size(kCiphersToDisable); ++i)
ssl_config.disabled_cipher_suites.push_back(kCiphersToDisable[i]);
int rv;
ASSERT_TRUE(CreateAndConnectSSLClientSocket(ssl_config, &rv));
EXPECT_THAT(rv, IsError(ERR_SSL_VERSION_OR_CIPHER_MISMATCH));
}
// When creating an SSLClientSocket, it is allowed to pass in a
// ClientSocketHandle that is not obtained from a client socket pool.
// Here we verify that such a simple ClientSocketHandle, not associated with any
// client socket pool, can be destroyed safely.
TEST_F(SSLClientSocketTest, ClientSocketHandleNotFromPool) {
ASSERT_TRUE(StartTestServer(SpawnedTestServer::SSLOptions()));
TestCompletionCallback callback;
std::unique_ptr<StreamSocket> transport(
new TCPClientSocket(addr(), nullptr, nullptr, NetLogSource()));
int rv = callback.GetResult(transport->Connect(callback.callback()));
EXPECT_THAT(rv, IsOk());
std::unique_ptr<SSLClientSocket> sock(socket_factory_->CreateSSLClientSocket(
std::move(transport), spawned_test_server()->host_port_pair(),
SSLConfig(), context_));
EXPECT_FALSE(sock->IsConnected());
rv = callback.GetResult(sock->Connect(callback.callback()));
EXPECT_THAT(rv, IsOk());
}
// Verifies that SSLClientSocket::ExportKeyingMaterial return a success
// code and different keying label results in different keying material.
TEST_F(SSLClientSocketTest, ExportKeyingMaterial) {
ASSERT_TRUE(StartTestServer(SpawnedTestServer::SSLOptions()));
int rv;
ASSERT_TRUE(CreateAndConnectSSLClientSocket(SSLConfig(), &rv));
EXPECT_THAT(rv, IsOk());
EXPECT_TRUE(sock_->IsConnected());
const int kKeyingMaterialSize = 32;
const char kKeyingLabel1[] = "client-socket-test-1";
const char kKeyingContext1[] = "";
unsigned char client_out1[kKeyingMaterialSize];
memset(client_out1, 0, sizeof(client_out1));
rv = sock_->ExportKeyingMaterial(kKeyingLabel1, false, kKeyingContext1,
client_out1, sizeof(client_out1));
EXPECT_EQ(rv, OK);
const char kKeyingLabel2[] = "client-socket-test-2";
unsigned char client_out2[kKeyingMaterialSize];
memset(client_out2, 0, sizeof(client_out2));
rv = sock_->ExportKeyingMaterial(kKeyingLabel2, false, kKeyingContext1,
client_out2, sizeof(client_out2));
EXPECT_EQ(rv, OK);
EXPECT_NE(memcmp(client_out1, client_out2, kKeyingMaterialSize), 0);
const char kKeyingContext2[] = "context";
rv = sock_->ExportKeyingMaterial(kKeyingLabel1, true, kKeyingContext2,
client_out2, sizeof(client_out2));
EXPECT_EQ(rv, OK);
EXPECT_NE(memcmp(client_out1, client_out2, kKeyingMaterialSize), 0);
// Using an empty context should give different key material from not using a
// context at all.
memset(client_out2, 0, sizeof(client_out2));
rv = sock_->ExportKeyingMaterial(kKeyingLabel1, true, kKeyingContext1,
client_out2, sizeof(client_out2));
EXPECT_EQ(rv, OK);
EXPECT_NE(memcmp(client_out1, client_out2, kKeyingMaterialSize), 0);
}
TEST(SSLClientSocket, SerializeNextProtos) {
NextProtoVector next_protos;
next_protos.push_back(kProtoHTTP11);
next_protos.push_back(kProtoHTTP2);
static std::vector<uint8_t> serialized =
SSLClientSocket::SerializeNextProtos(next_protos);
ASSERT_EQ(12u, serialized.size());
EXPECT_EQ(8, serialized[0]); // length("http/1.1")
EXPECT_EQ('h', serialized[1]);
EXPECT_EQ('t', serialized[2]);
EXPECT_EQ('t', serialized[3]);
EXPECT_EQ('p', serialized[4]);
EXPECT_EQ('/', serialized[5]);
EXPECT_EQ('1', serialized[6]);
EXPECT_EQ('.', serialized[7]);
EXPECT_EQ('1', serialized[8]);
EXPECT_EQ(2, serialized[9]); // length("h2")
EXPECT_EQ('h', serialized[10]);
EXPECT_EQ('2', serialized[11]);
}
// Test that the server certificates are properly retrieved from the underlying
// SSL stack.
TEST_F(SSLClientSocketTest, VerifyServerChainProperlyOrdered) {
// The connection does not have to be successful.
cert_verifier_->set_default_result(ERR_CERT_INVALID);
// Set up a test server with CERT_CHAIN_WRONG_ROOT.
// This makes the server present redundant-server-chain.pem, which contains
// intermediate certificates.
SpawnedTestServer::SSLOptions ssl_options(
SpawnedTestServer::SSLOptions::CERT_CHAIN_WRONG_ROOT);
ASSERT_TRUE(StartTestServer(ssl_options));
int rv;
ASSERT_TRUE(CreateAndConnectSSLClientSocket(SSLConfig(), &rv));
EXPECT_THAT(rv, IsError(ERR_CERT_INVALID));
EXPECT_FALSE(sock_->IsConnected());
// When given option CERT_CHAIN_WRONG_ROOT, SpawnedTestServer will present
// certs from redundant-server-chain.pem.
CertificateList server_certs =
CreateCertificateListFromFile(GetTestCertsDirectory(),
"redundant-server-chain.pem",
X509Certificate::FORMAT_AUTO);
// Get the server certificate as received client side.
SSLInfo ssl_info;
ASSERT_TRUE(sock_->GetSSLInfo(&ssl_info));
scoped_refptr<X509Certificate> server_certificate = ssl_info.unverified_cert;
// Get the intermediates as received client side.
const auto& server_intermediates = server_certificate->intermediate_buffers();
// Check that the unverified server certificate chain is properly retrieved
// from the underlying ssl stack.
ASSERT_EQ(4U, server_certs.size());
EXPECT_TRUE(x509_util::CryptoBufferEqual(server_certificate->cert_buffer(),
server_certs[0]->cert_buffer()));
ASSERT_EQ(3U, server_intermediates.size());
EXPECT_TRUE(x509_util::CryptoBufferEqual(server_intermediates[0].get(),
server_certs[1]->cert_buffer()));
EXPECT_TRUE(x509_util::CryptoBufferEqual(server_intermediates[1].get(),
server_certs[2]->cert_buffer()));
EXPECT_TRUE(x509_util::CryptoBufferEqual(server_intermediates[2].get(),
server_certs[3]->cert_buffer()));
sock_->Disconnect();
EXPECT_FALSE(sock_->IsConnected());
}
// This tests that SSLInfo contains a properly re-constructed certificate
// chain. That, in turn, verifies that GetSSLInfo is giving us the chain as
// verified, not the chain as served by the server. (They may be different.)
//
// CERT_CHAIN_WRONG_ROOT is redundant-server-chain.pem. It contains A
// (end-entity) -> B -> C, and C is signed by D. redundant-validated-chain.pem
// contains a chain of A -> B -> C2, where C2 is the same public key as C, but
// a self-signed root. Such a situation can occur when a new root (C2) is
// cross-certified by an old root (D) and has two different versions of its
// floating around. Servers may supply C2 as an intermediate, but the
// SSLClientSocket should return the chain that was verified, from
// verify_result, instead.
TEST_F(SSLClientSocketTest, VerifyReturnChainProperlyOrdered) {
// By default, cause the CertVerifier to treat all certificates as
// expired.
cert_verifier_->set_default_result(ERR_CERT_DATE_INVALID);
CertificateList unverified_certs = CreateCertificateListFromFile(
GetTestCertsDirectory(), "redundant-server-chain.pem",
X509Certificate::FORMAT_AUTO);
ASSERT_EQ(4u, unverified_certs.size());
// We will expect SSLInfo to ultimately contain this chain.
CertificateList certs =
CreateCertificateListFromFile(GetTestCertsDirectory(),
"redundant-validated-chain.pem",
X509Certificate::FORMAT_AUTO);
ASSERT_EQ(3U, certs.size());
ASSERT_TRUE(certs[0]->EqualsExcludingChain(unverified_certs[0].get()));
std::vector<bssl::UniquePtr<CRYPTO_BUFFER>> temp_intermediates;
temp_intermediates.push_back(bssl::UpRef(certs[1]->cert_buffer()));
temp_intermediates.push_back(bssl::UpRef(certs[2]->cert_buffer()));
CertVerifyResult verify_result;
verify_result.verified_cert = X509Certificate::CreateFromBuffer(
bssl::UpRef(certs[0]->cert_buffer()), std::move(temp_intermediates));
ASSERT_TRUE(verify_result.verified_cert);
// Add a rule that maps the server cert (A) to the chain of A->B->C2
// rather than A->B->C.
cert_verifier_->AddResultForCert(certs[0].get(), verify_result, OK);
// Load and install the root for the validated chain.
scoped_refptr<X509Certificate> root_cert = ImportCertFromFile(
GetTestCertsDirectory(), "redundant-validated-chain-root.pem");
ASSERT_NE(static_cast<X509Certificate*>(nullptr), root_cert.get());
ScopedTestRoot scoped_root(root_cert.get());
// Set up a test server with CERT_CHAIN_WRONG_ROOT.
SpawnedTestServer::SSLOptions ssl_options(
SpawnedTestServer::SSLOptions::CERT_CHAIN_WRONG_ROOT);
ASSERT_TRUE(StartTestServer(ssl_options));
int rv;
ASSERT_TRUE(CreateAndConnectSSLClientSocket(SSLConfig(), &rv));
EXPECT_THAT(rv, IsOk());
EXPECT_TRUE(sock_->IsConnected());
TestNetLogEntry::List entries;
log_.GetEntries(&entries);
EXPECT_TRUE(LogContainsEndEvent(entries, -1, NetLogEventType::SSL_CONNECT));
SSLInfo ssl_info;
ASSERT_TRUE(sock_->GetSSLInfo(&ssl_info));
// Verify that SSLInfo contains the corrected re-constructed chain A -> B
// -> C2.
ASSERT_TRUE(ssl_info.cert);
const auto& intermediates = ssl_info.cert->intermediate_buffers();
ASSERT_EQ(2U, intermediates.size());
EXPECT_TRUE(x509_util::CryptoBufferEqual(ssl_info.cert->cert_buffer(),
certs[0]->cert_buffer()));
EXPECT_TRUE(x509_util::CryptoBufferEqual(intermediates[0].get(),
certs[1]->cert_buffer()));
EXPECT_TRUE(x509_util::CryptoBufferEqual(intermediates[1].get(),
certs[2]->cert_buffer()));
// Verify that SSLInfo also contains the chain as received from the server.
ASSERT_TRUE(ssl_info.unverified_cert);
const auto& served_intermediates =
ssl_info.unverified_cert->intermediate_buffers();
ASSERT_EQ(3U, served_intermediates.size());
EXPECT_TRUE(x509_util::CryptoBufferEqual(ssl_info.cert->cert_buffer(),
unverified_certs[0]->cert_buffer()));
EXPECT_TRUE(x509_util::CryptoBufferEqual(served_intermediates[0].get(),
unverified_certs[1]->cert_buffer()));
EXPECT_TRUE(x509_util::CryptoBufferEqual(served_intermediates[1].get(),
unverified_certs[2]->cert_buffer()));
EXPECT_TRUE(x509_util::CryptoBufferEqual(served_intermediates[2].get(),
unverified_certs[3]->cert_buffer()));
sock_->Disconnect();
EXPECT_FALSE(sock_->IsConnected());
}
TEST_F(SSLClientSocketCertRequestInfoTest,
DontRequestClientCertsIfServerCertInvalid) {
SpawnedTestServer::SSLOptions ssl_options(
SpawnedTestServer::SSLOptions::CERT_EXPIRED);
ssl_options.request_client_certificate = true;
ASSERT_TRUE(StartTestServer(ssl_options));
cert_verifier_->set_default_result(ERR_CERT_DATE_INVALID);
int rv;
ASSERT_TRUE(CreateAndConnectSSLClientSocket(SSLConfig(), &rv));
EXPECT_THAT(rv, IsError(ERR_CERT_DATE_INVALID));
}
TEST_F(SSLClientSocketCertRequestInfoTest, NoAuthorities) {
SpawnedTestServer::SSLOptions ssl_options;