Google Git
Sign in
chromium / chromium / src / af8be5d3c27e043120d548f5959fe73463a7d7d6
commitaf8be5d3c27e043120d548f5959fe73463a7d7d6[log] [tgz]
authorPiotr Kotynia <piotrkotynia@google.com>Fri Jan 31 10:19:35 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Jan 31 10:19:35 2025
treef0bedfabf0d632d835991946dc6c675aa3e7fa88
parent70c98c67f89bb4b16b10822b45c3be4a294a5d7f [diff]
Improve `StructuredAddressesRegExProvider` readability

This CL improves the readability of the
`StructuredAddressesRegExProvider` by making the following changes:

- Replaced kOptional... regexes with non-optional versions,
using the `MatchQuantifier::kOptional` argument instead.

- Created `CaptureTypeWithPatternOptional` and
`NoCapturePatternOptional` wrappers and used them where applicable.

- Removed duplicate entries from the LastNamePrefix regex and
improved the comprehensiveness of the Dutch regexes by adding
missing prefixes such as "von der".

Bug: 386916943
Change-Id: I9756d1e9663266e3ab1519af5c450e2a40dbfb1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6218544
Commit-Queue: Piotr Kotynia <piotrkotynia@google.com>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Norge Vizcay <vizcay@google.com>
Cr-Commit-Position: refs/heads/main@{#1413983}
4 files changed
tree: f0bedfabf0d632d835991946dc6c675aa3e7fa88
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.