[iOS][Translate] Fix translate infobar's language tab spinner animation
Use UIView's alpha property instead of hidden to hide the button and show
the spinner on translate infobar's language tab.
As opposed to hidden, alpha is an animatable UIView property:
https://developer.apple.com/library/archive/documentation/WindowsViews/Conceptual/ViewPG_iPhoneOS/AnimatingViews/AnimatingViews.html
Bug: 910994
Change-Id: I35a853f52f4f7291412a51cacbd61a13e3c00087
Reviewed-on: https://chromium-review.googlesource.com/c/1448773
Auto-Submit: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628187}diff --git a/ios/chrome/browser/ui/translate/translate_infobar_language_tab_view.mm b/ios/chrome/browser/ui/translate/translate_infobar_language_tab_view.mm
index c67aff5..955bf22 100644
--- a/ios/chrome/browser/ui/translate/translate_infobar_language_tab_view.mm
+++ b/ios/chrome/browser/ui/translate/translate_infobar_language_tab_view.mm
@@ -75,12 +75,12 @@
// the ripple effect on the button won't be seen.
[UIView animateWithDuration:kActivityIndicatorVisbilityAnimationDuration
animations:^{
- self.activityIndicator.hidden = NO;
- self.button.hidden = YES;
+ self.activityIndicator.alpha = 1.0;
+ self.button.alpha = 0.0;
}];
} else {
- self.button.hidden = NO;
- self.activityIndicator.hidden = YES;
+ self.button.alpha = 1.0;
+ self.activityIndicator.alpha = 0.0;
[self.activityIndicator stopAnimating];
[self.button setTitleColor:[self titleColor] forState:UIControlStateNormal];
@@ -96,7 +96,7 @@
self.activityIndicator.cycleColors =
@[ [[MDCPalette cr_bluePalette] tint500] ];
[self.activityIndicator setRadius:kActivityIndicatorRadius];
- self.activityIndicator.hidden = YES; // Initially hidden.
+ self.activityIndicator.alpha = 0.0; // Initially hidden.
[self addSubview:self.activityIndicator];
[NSLayoutConstraint activateConstraints:@[
