commit c023fa24de14f77906b984a7bf1d3e4238539f09
author maksim.sisov <maksim.sisov@intel.com> Thu Sep 22 04:16:32 2016
committer Commit bot <commit-bot@chromium.org> Thu Sep 22 04:18:45 2016
tree 2af23328d58822a3db8057755517bd2aff70b4ec
parent 263ef059c1d64c6828a4da24bfda2b0cb9f95ffc

Adjust callers and networking delegates in remoting/ to modified APIs

Use modified Read and delegate methods from the following
CL- https://codereview.chromium.org/2262653003/

BUG=423484

Review-Url: https://codereview.chromium.org/2267643002
Cr-Commit-Position: refs/heads/master@{#420262}

remoting/host/token_validator_base.cc

diff --git a/remoting/host/token_validator_base.cc b/remoting/host/token_validator_base.cc
index 9979642..0160dd4 100644
--- a/remoting/host/token_validator_base.cc
+++ b/remoting/host/token_validator_base.cc
@@ -85,33 +85,36 @@
 }
 
 // URLFetcherDelegate interface.
-void TokenValidatorBase::OnResponseStarted(net::URLRequest* source) {
+void TokenValidatorBase::OnResponseStarted(net::URLRequest* source,
+                                           int net_result) {
+  DCHECK_NE(net_result, net::ERR_IO_PENDING);
   DCHECK_EQ(request_.get(), source);
 
-  int bytes_read = 0;
-  request_->Read(buffer_.get(), kBufferSize, &bytes_read);
-  OnReadCompleted(request_.get(), bytes_read);
+  if (net_result != net::OK)
+    return;
+
+  int bytes_read = request_->Read(buffer_.get(), kBufferSize);
+  if (bytes_read > 0)
+    OnReadCompleted(request_.get(), bytes_read);
 }
 
 void TokenValidatorBase::OnReadCompleted(net::URLRequest* source,
-                                         int bytes_read) {
+                                         int net_result) {
+  DCHECK_NE(net_result, net::ERR_IO_PENDING);
   DCHECK_EQ(request_.get(), source);
 
-  do {
-    if (!request_->status().is_success() || bytes_read <= 0)
-      break;
-
-    data_.append(buffer_->data(), bytes_read);
-  } while (request_->Read(buffer_.get(), kBufferSize, &bytes_read));
-
-  const net::URLRequestStatus status = request_->status();
-
-  if (!status.is_io_pending()) {
-    retrying_request_ = false;
-    std::string shared_token = ProcessResponse();
-    request_.reset();
-    on_token_validated_.Run(shared_token);
+  while (net_result > 0) {
+    data_.append(buffer_->data(), net_result);
+    net_result = request_->Read(buffer_.get(), kBufferSize);
   }
+
+  if (net_result == net::ERR_IO_PENDING)
+    return;
+
+  retrying_request_ = false;
+  std::string shared_token = ProcessResponse(net_result);
+  request_.reset();
+  on_token_validated_.Run(shared_token);
 }
 
 void TokenValidatorBase::OnReceivedRedirect(
@@ -190,19 +193,17 @@
   return token_scope == token_scope_;
 }
 
-std::string TokenValidatorBase::ProcessResponse() {
+std::string TokenValidatorBase::ProcessResponse(int net_result) {
   // Verify that we got a successful response.
-  net::URLRequestStatus status = request_->status();
-  if (!status.is_success()) {
-    LOG(ERROR) << "Error validating token, status=" << status.status()
-               << " err=" << status.error();
+  if (net_result != net::OK) {
+    LOG(ERROR) << "Error validating token, err=" << net_result;
     return std::string();
   }
 
   int response = request_->GetResponseCode();
   if (response != 200) {
-    LOG(ERROR)
-        << "Error " << response << " validating token: '" << data_ << "'";
+    LOG(ERROR) << "Error " << response << " validating token: '" << data_
+               << "'";
     return std::string();
   }
 
@@ -217,8 +218,8 @@
   std::string token_scope;
   dict->GetStringWithoutPathExpansion("scope", &token_scope);
   if (!IsValidScope(token_scope)) {
-    LOG(ERROR) << "Invalid scope: '" << token_scope
-               << "', expected: '" << token_scope_ <<"'.";
+    LOG(ERROR) << "Invalid scope: '" << token_scope << "', expected: '"
+               << token_scope_ << "'.";
     return std::string();
   }
 

remoting/host/token_validator_base.h

diff --git a/remoting/host/token_validator_base.h b/remoting/host/token_validator_base.h
index eab3064a..7707b6c 100644
--- a/remoting/host/token_validator_base.h
+++ b/remoting/host/token_validator_base.h
@@ -43,8 +43,8 @@
   const std::string& token_scope() const override;
 
   // URLRequest::Delegate interface.
-  void OnResponseStarted(net::URLRequest* source) override;
-  void OnReadCompleted(net::URLRequest* source, int bytes_read) override;
+  void OnResponseStarted(net::URLRequest* source, int net_result) override;
+  void OnReadCompleted(net::URLRequest* source, int net_result) override;
   void OnReceivedRedirect(net::URLRequest* request,
                           const net::RedirectInfo& redirect_info,
                           bool* defer_redirect) override;
@@ -58,7 +58,7 @@
 
   virtual void StartValidateRequest(const std::string& token) = 0;
   virtual bool IsValidScope(const std::string& token_scope);
-  std::string ProcessResponse();
+  std::string ProcessResponse(int net_result);
 
   // Constructor parameters.
   ThirdPartyAuthConfig third_party_auth_config_;