commit c16fb58b2bca1bba7248ac509dde60ececf94d63
author Dan Elphick <delphick@chromium.org> Tue Apr 23 10:48:22 2019
committer Commit Bot <commit-bot@chromium.org> Tue Apr 23 10:48:22 2019
tree 91f3af86ccb0f52a30c63d854402e778c1c6e322
parent 5c7c5d31ac0fea5a0a186e094dc5f54bbe3783e1

[v8] Fix use of deprecated Object::Set in renderer

Uses the context version of Set and checks the return value (which
cannot actually fail in this case but the API requires it).

Bug: v8:7283
Change-Id: I1c8b5d0daf846579cb429ef4c71c2a37681a5c46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576571
Auto-Submit: Dan Elphick <delphick@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653124}

chrome/renderer/sandbox_status_extension_android.cc

diff --git a/chrome/renderer/sandbox_status_extension_android.cc b/chrome/renderer/sandbox_status_extension_android.cc
index 1181442..321cb43 100644
--- a/chrome/renderer/sandbox_status_extension_android.cc
+++ b/chrome/renderer/sandbox_status_extension_android.cc
@@ -83,8 +83,11 @@
           ->GetFunction(context)
           .ToLocal(&function);
   if (success) {
-    success = chrome->Set(
-        gin::StringToSymbol(isolate, "getAndroidSandboxStatus"), function);
+    success = chrome
+                  ->Set(context,
+                        gin::StringToSymbol(isolate, "getAndroidSandboxStatus"),
+                        function)
+                  .IsJust();
   }
   DCHECK(success);
 }

content/renderer/java/gin_java_bridge_object.cc

diff --git a/content/renderer/java/gin_java_bridge_object.cc b/content/renderer/java/gin_java_bridge_object.cc
index 03af04d..6afc798 100644
--- a/content/renderer/java/gin_java_bridge_object.cc
+++ b/content/renderer/java/gin_java_bridge_object.cc
@@ -38,7 +38,9 @@
   if (controller.IsEmpty())
     return NULL;
 
-  global->Set(gin::StringToV8(isolate, object_name), controller.ToV8());
+  global->Set(context, gin::StringToV8(isolate, object_name), controller.ToV8())
+      .Check();
+
   return object;
 }