Google Git
Sign in
chromium / chromium / src / e9e6c1240fe6781acfecf6be2075afcddffb8a0f
commite9e6c1240fe6781acfecf6be2075afcddffb8a0f[log] [tgz]
authorCarlos IL <carlosil@chromium.org>Fri Apr 22 18:20:10 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Apr 22 18:20:10 2022
tree0016d63da5db9b4ca117702d220e23574abd6100
parent4b891e849b02d2165124d0f058bf445c5e8fbd3e [diff]
Remove WaitForInterstitial method in tests

This method is no longer required with committed interstitials (it now
only asserts an interstitial is shown, then runs
WaitForRenderFrameReady), since the regular navigation wait works for
committed interstitials. It seems the WaitForRenderFrameReady was also
causing flaky tests due to timeouts (e.g. crbug.com/1287661) if it
happened to be called after the RenderFrameReady event happened.
This replaces the method with an assertion that an interstitial is
shown in all callsites (except where an assertion would be redundant
due to an existing similar assertion).

Bug: 1287661
Change-Id: Ie54c5b63634215c1f7bfb07c92bfdfb51e9913ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3596203
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>
Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Auto-Submit: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/main@{#995272}
8 files changed
tree: 0016d63da5db9b4ca117702d220e23574abd6100
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.