blob: e0000b835d4e8111ac45716b9ae2d9d3de1912b2 [file] [log] [blame]
// Copyright 2018 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/chromeos/crostini/crostini_share_path.h"
#include "base/atomic_ref_count.h"
#include "base/bind.h"
#include "base/files/file_util.h"
#include "base/optional.h"
#include "base/task/post_task.h"
#include "chrome/browser/chromeos/crostini/crostini_manager.h"
#include "chrome/browser/chromeos/crostini/crostini_pref_names.h"
#include "chrome/browser/chromeos/crostini/crostini_share_path_factory.h"
#include "chrome/browser/chromeos/crostini/crostini_util.h"
#include "chrome/browser/chromeos/drive/drive_integration_service.h"
#include "chrome/browser/chromeos/file_manager/path_util.h"
#include "chrome/browser/chromeos/file_manager/volume_manager.h"
#include "chrome/browser/profiles/profile.h"
#include "chromeos/components/drivefs/mojom/drivefs.mojom.h"
#include "chromeos/constants/chromeos_features.h"
#include "chromeos/dbus/concierge/service.pb.h"
#include "chromeos/dbus/dbus_thread_manager.h"
#include "chromeos/dbus/seneschal_client.h"
#include "components/prefs/pref_service.h"
#include "components/prefs/scoped_user_pref_update.h"
#include "content/public/browser/browser_task_traits.h"
#include "content/public/browser/browser_thread.h"
#include "storage/browser/fileapi/external_mount_points.h"
#include "storage/browser/fileapi/file_system_url.h"
#include "url/gurl.h"
namespace {
void OnSeneschalSharePathResponse(
crostini::CrostiniSharePath::SharePathCallback callback,
base::Optional<vm_tools::seneschal::SharePathResponse> response) {
if (!response) {
std::move(callback).Run(base::FilePath(), false, "System error");
return;
}
std::move(callback).Run(base::FilePath(response.value().path()),
response.value().success(),
response.value().failure_reason());
}
void OnVmRestartedForSeneschal(
Profile* profile,
const std::string& vm_name,
crostini::CrostiniSharePath::SharePathCallback callback,
vm_tools::seneschal::SharePathRequest request,
crostini::CrostiniResult result) {
auto* crostini_manager = crostini::CrostiniManager::GetForProfile(profile);
base::Optional<crostini::VmInfo> vm_info =
crostini_manager->GetVmInfo(vm_name);
if (!vm_info || vm_info->state != crostini::VmState::STARTED) {
std::move(callback).Run(base::FilePath(), false, "VM could not be started");
return;
}
request.set_handle(vm_info->info.seneschal_server_handle());
chromeos::DBusThreadManager::Get()->GetSeneschalClient()->SharePath(
request,
base::BindOnce(&OnSeneschalSharePathResponse, std::move(callback)));
}
void OnSeneschalUnsharePathResponse(
base::OnceCallback<void(bool, std::string)> callback,
base::Optional<vm_tools::seneschal::UnsharePathResponse> response) {
if (!response) {
std::move(callback).Run(false, "System error");
return;
}
std::move(callback).Run(response.value().success(),
response.value().failure_reason());
}
void LogErrorResult(const std::string& operation,
const base::FilePath& cros_path,
const base::FilePath& container_path,
bool result,
std::string failure_reason) {
if (!result) {
LOG(WARNING) << "Error " << operation << " " << cros_path << ": "
<< failure_reason;
}
}
// Barrier Closure that captures the first instance of error.
class ErrorCapture {
public:
ErrorCapture(int num_callbacks_left,
base::OnceCallback<void(bool, std::string)> callback)
: num_callbacks_left_(num_callbacks_left),
callback_(std::move(callback)) {
DCHECK_GE(num_callbacks_left, 0);
if (num_callbacks_left == 0)
std::move(callback_).Run(true, "");
}
void Run(const base::FilePath& cros_path,
const base::FilePath& container_path,
bool success,
std::string failure_reason) {
if (!success) {
LOG(WARNING) << "Error SharePath=" << cros_path.value()
<< ", FailureReason=" << failure_reason;
if (success_) {
success_ = false;
first_failure_reason_ = failure_reason;
}
}
if (!--num_callbacks_left_)
std::move(callback_).Run(success_, first_failure_reason_);
}
private:
int num_callbacks_left_;
base::OnceCallback<void(bool, std::string)> callback_;
bool success_ = true;
std::string first_failure_reason_;
}; // class
void RemovePersistedPathFromPrefs(base::DictionaryValue* shared_paths,
const std::string& vm_name,
const base::FilePath& path) {
// |shared_paths| format is {'path': ['vm1', vm2']}.
// If |path| exists, remove |vm_name| from list of VMs.
base::Value* found = shared_paths->FindKey(path.value());
if (!found) {
LOG(WARNING) << "Path not in prefs to ushare path " << path.value()
<< " for VM " << vm_name;
return;
}
auto& vms = found->GetList();
auto it = std::find(vms.begin(), vms.end(), base::Value(vm_name));
if (it == vms.end()) {
LOG(WARNING) << "VM not in prefs to ushare path " << path.value()
<< " for VM " << vm_name;
return;
}
vms.erase(it);
// If VM list is now empty, remove |path| from |shared_paths|.
if (vms.size() == 0) {
shared_paths->RemoveKey(path.value());
}
}
} // namespace
namespace crostini {
SharedPathInfo::SharedPathInfo(const std::string& vm_name) {
vm_names.insert(vm_name);
}
SharedPathInfo::SharedPathInfo(SharedPathInfo&&) = default;
SharedPathInfo::~SharedPathInfo() = default;
CrostiniSharePath* CrostiniSharePath::GetForProfile(Profile* profile) {
return CrostiniSharePathFactory::GetForProfile(profile);
}
CrostiniSharePath::CrostiniSharePath(Profile* profile)
: profile_(profile),
sequenced_task_runner_(base::CreateSequencedTaskRunnerWithTraits(
{base::MayBlock(), base::TaskPriority::USER_VISIBLE})),
mount_event_seneschal_callback_(base::BindRepeating(LogErrorResult)) {
if (auto* vmgr = file_manager::VolumeManager::Get(profile_)) {
vmgr->AddObserver(this);
}
// We receive notifications from DriveFS about any deleted paths so
// that we can remove any that are shared paths.
if (auto* integration_service =
drive::DriveIntegrationServiceFactory::FindForProfile(profile_)) {
if (integration_service->GetDriveFsHost()) {
integration_service->GetDriveFsHost()->AddObserver(this);
}
}
}
CrostiniSharePath::~CrostiniSharePath() {
for (auto& shared_path : shared_paths_) {
if (shared_path.second.watcher) {
sequenced_task_runner_->DeleteSoon(FROM_HERE,
shared_path.second.watcher.release());
}
}
}
void CrostiniSharePath::AddObserver(Observer* obs) {
observers_.AddObserver(obs);
}
void CrostiniSharePath::CallSeneschalSharePath(const std::string& vm_name,
const base::FilePath& path,
bool persist,
SharePathCallback callback) {
// Verify path is in one of the allowable mount points.
// This logic is similar to DownloadPrefs::SanitizeDownloadTargetPath().
if (!path.IsAbsolute() || path.ReferencesParent()) {
std::move(callback).Run(base::FilePath(), false, "Path must be absolute");
return;
}
vm_tools::seneschal::SharePathRequest request;
base::FilePath drivefs_path;
base::FilePath relative_path;
drive::DriveIntegrationService* integration_service = nullptr;
if (base::FeatureList::IsEnabled(chromeos::features::kDriveFs)) {
integration_service =
drive::DriveIntegrationServiceFactory::GetForProfile(profile_);
}
base::FilePath drivefs_mount_point_path;
base::FilePath drivefs_mount_name;
// Allow MyFiles|Downloads directory and subdirs.
bool allowed_path = false;
base::FilePath my_files =
file_manager::util::GetMyFilesFolderForProfile(profile_);
base::FilePath android_files(file_manager::util::kAndroidFilesPath);
base::FilePath removable_media(file_manager::util::kRemovableMediaPath);
if (my_files == path || my_files.AppendRelativePath(path, &relative_path)) {
allowed_path = true;
if (base::FeatureList::IsEnabled(chromeos::features::kMyFilesVolume)) {
request.set_storage_location(
vm_tools::seneschal::SharePathRequest::MY_FILES);
} else {
request.set_storage_location(
vm_tools::seneschal::SharePathRequest::DOWNLOADS);
}
request.set_owner_id(CryptohomeIdForProfile(profile_));
} else if (base::FeatureList::IsEnabled(chromeos::features::kDriveFs) &&
integration_service &&
(drivefs_mount_point_path =
integration_service->GetMountPointPath())
.AppendRelativePath(path, &drivefs_path) &&
base::FilePath("/media/fuse")
.AppendRelativePath(drivefs_mount_point_path,
&drivefs_mount_name)) {
// Allow subdirs of DriveFS except .Trash.
request.set_drivefs_mount_name(drivefs_mount_name.value());
base::FilePath root("root");
base::FilePath team_drives("team_drives");
base::FilePath computers("Computers");
base::FilePath trash(".Trash"); // Not to be shared!
if (root == drivefs_path ||
root.AppendRelativePath(drivefs_path, &relative_path)) {
// My Drive and subdirs.
allowed_path = true;
request.set_storage_location(
vm_tools::seneschal::SharePathRequest::DRIVEFS_MY_DRIVE);
} else if (team_drives == drivefs_path ||
team_drives.AppendRelativePath(drivefs_path, &relative_path)) {
// Team Drives and subdirs.
allowed_path = true;
request.set_storage_location(
vm_tools::seneschal::SharePathRequest::DRIVEFS_TEAM_DRIVES);
} else if (computers == drivefs_path ||
computers.AppendRelativePath(drivefs_path, &relative_path)) {
// Computers and subdirs.
allowed_path = true;
request.set_storage_location(
vm_tools::seneschal::SharePathRequest::DRIVEFS_COMPUTERS);
// TODO(crbug.com/917920): Do not allow Computers Grand Root, or single
// Computer Root to be shared until DriveFS enforces allowed write paths.
std::vector<base::FilePath::StringType> components;
relative_path.GetComponents(&components);
if (components.size() < 2) {
allowed_path = false;
}
} else if (trash == drivefs_path || trash.IsParent(drivefs_path)) {
// Note: Do not expose .Trash which would allow linux apps to make
// permanent deletes from Drive. This branch is not especially required,
// but is included to make it explicit that .Trash should not be shared.
allowed_path = false;
}
} else if (path == android_files ||
android_files.AppendRelativePath(path, &relative_path)) {
// Allow Android files and subdirs.
allowed_path = true;
request.set_storage_location(
vm_tools::seneschal::SharePathRequest::PLAY_FILES);
} else if (removable_media.AppendRelativePath(path, &relative_path)) {
// Allow subdirs of /media/removable.
allowed_path = true;
request.set_storage_location(
vm_tools::seneschal::SharePathRequest::REMOVABLE);
}
if (!allowed_path) {
std::move(callback).Run(base::FilePath(), false, "Path is not allowed");
return;
}
// We will not make a blocking call to verify the path exists since
// we don't want to block, and seneschal must verify this regardless.
// Even if VM is not running, save to prefs now.
if (persist) {
RegisterPersistedPath(vm_name, path);
}
RegisterSharedPath(vm_name, path);
request.mutable_shared_path()->set_path(relative_path.value());
request.mutable_shared_path()->set_writable(true);
// Restart VM if not currently running.
auto* crostini_manager = crostini::CrostiniManager::GetForProfile(profile_);
base::Optional<crostini::VmInfo> vm_info =
crostini_manager->GetVmInfo(vm_name);
if (!vm_info || vm_info->state != crostini::VmState::STARTED) {
crostini_manager->RestartCrostini(
vm_name, crostini::kCrostiniDefaultContainerName,
base::BindOnce(&OnVmRestartedForSeneschal, profile_, vm_name,
std::move(callback), std::move(request)));
return;
}
request.set_handle(vm_info->info.seneschal_server_handle());
chromeos::DBusThreadManager::Get()->GetSeneschalClient()->SharePath(
request,
base::BindOnce(&OnSeneschalSharePathResponse, std::move(callback)));
}
void CrostiniSharePath::CallSeneschalUnsharePath(
const std::string& vm_name,
const base::FilePath& path,
base::OnceCallback<void(bool, std::string)> callback) {
// Return success if VM is not currently running.
auto* crostini_manager = crostini::CrostiniManager::GetForProfile(profile_);
base::Optional<crostini::VmInfo> vm_info =
crostini_manager->GetVmInfo(vm_name);
if (!vm_info || vm_info->state != crostini::VmState::STARTED) {
std::move(callback).Run(true, "VM not running");
return;
}
// Convert path to a virtual path relative to one of the external mounts,
// then get it as a FilesSystemURL to convert to a path inside crostini,
// then remove /mnt/chromeos/ base dir prefix to get the path to unshare.
storage::ExternalMountPoints* mount_points =
storage::ExternalMountPoints::GetSystemInstance();
base::FilePath virtual_path;
base::FilePath inside;
bool result = mount_points->GetVirtualPath(path, &virtual_path);
if (result) {
storage::FileSystemURL url = mount_points->CreateCrackedFileSystemURL(
url::Origin(), storage::kFileSystemTypeExternal, virtual_path);
result = file_manager::util::ConvertFileSystemURLToPathInsideCrostini(
profile_, url, &inside);
}
base::FilePath unshare_path;
if (!result || !crostini::ContainerChromeOSBaseDirectory().AppendRelativePath(
inside, &unshare_path)) {
std::move(callback).Run(false, "Invalid path to unshare");
return;
}
vm_tools::seneschal::UnsharePathRequest request;
request.set_handle(vm_info->info.seneschal_server_handle());
request.set_path(unshare_path.value());
chromeos::DBusThreadManager::Get()->GetSeneschalClient()->UnsharePath(
request,
base::BindOnce(&OnSeneschalUnsharePathResponse, std::move(callback)));
}
void CrostiniSharePath::SharePath(const std::string& vm_name,
const base::FilePath& path,
bool persist,
SharePathCallback callback) {
DCHECK(callback);
CallSeneschalSharePath(vm_name, path, persist, std::move(callback));
}
void CrostiniSharePath::SharePaths(
const std::string& vm_name,
std::vector<base::FilePath> paths,
bool persist,
base::OnceCallback<void(bool, std::string)> callback) {
base::RepeatingCallback<void(const base::FilePath&, const base::FilePath&,
bool, std::string)>
barrier = base::BindRepeating(
&ErrorCapture::Run,
base::Owned(new ErrorCapture(paths.size(), std::move(callback))));
for (const auto& path : paths) {
CallSeneschalSharePath(vm_name, path, persist,
base::BindOnce(barrier, std::move(path)));
}
}
void CrostiniSharePath::UnsharePath(
const std::string& vm_name,
const base::FilePath& path,
bool unpersist,
base::OnceCallback<void(bool, std::string)> callback) {
if (auto* info = FindSharedPathInfo(path)) {
info->vm_names.erase(vm_name);
if (info->vm_names.empty()) {
if (info->watcher) {
sequenced_task_runner_->DeleteSoon(FROM_HERE, info->watcher.release());
}
shared_paths_.erase(path);
}
}
if (unpersist) {
PrefService* pref_service = profile_->GetPrefs();
DictionaryPrefUpdate update(pref_service,
crostini::prefs::kGuestOSPathsSharedToVms);
base::DictionaryValue* shared_paths = update.Get();
RemovePersistedPathFromPrefs(shared_paths, vm_name, path);
}
CallSeneschalUnsharePath(vm_name, path, std::move(callback));
for (Observer& observer : observers_) {
observer.OnUnshare(vm_name, path);
}
}
bool CrostiniSharePath::GetAndSetFirstForSession() {
bool result = first_for_session_;
first_for_session_ = false;
return result;
}
std::vector<base::FilePath> CrostiniSharePath::GetPersistedSharedPaths(
const std::string& vm_name) {
std::vector<base::FilePath> result;
// |shared_paths| format is {'path': ['vm1', vm2']}.
const base::DictionaryValue* shared_paths =
profile_->GetPrefs()->GetDictionary(prefs::kGuestOSPathsSharedToVms);
for (const auto& it : shared_paths->DictItems()) {
base::FilePath path(it.first);
auto& vms = it.second.GetList();
for (const auto& vm : vms) {
// Register all shared paths for all VMs since we want FilePathWatchers
// to start immediately.
RegisterSharedPath(vm.GetString(), path);
// Only add to result if path is shared with specified |vm_name|.
if (vm.GetString() == vm_name) {
result.emplace_back(path);
}
}
}
return result;
}
void CrostiniSharePath::SharePersistedPaths(
const std::string& vm_name,
base::OnceCallback<void(bool, std::string)> callback) {
SharePaths(vm_name, GetPersistedSharedPaths(vm_name),
/*persist=*/false, std::move(callback));
}
void CrostiniSharePath::RegisterPersistedPath(const std::string& vm_name,
const base::FilePath& path) {
PrefService* pref_service = profile_->GetPrefs();
DictionaryPrefUpdate update(pref_service,
crostini::prefs::kGuestOSPathsSharedToVms);
base::DictionaryValue* shared_paths = update.Get();
// Check if path is already shared so we know whether we need to add it.
bool already_shared = false;
// Remove any paths that are children of this path.
// E.g. if path /foo/bar is already shared, and then we share /foo, we
// remove /foo/bar from the list since it will be shared as part of /foo.
std::vector<base::FilePath> children;
for (const auto& it : shared_paths->DictItems()) {
base::FilePath shared(it.first);
auto& vms = it.second.GetList();
auto vm_matches =
std::find(vms.begin(), vms.end(), base::Value(vm_name)) != vms.end();
if (path == shared) {
already_shared = true;
if (!vm_matches) {
vms.emplace_back(vm_name);
}
} else if (path.IsParent(shared) && vm_matches) {
children.emplace_back(shared);
}
}
for (const auto& child : children) {
RemovePersistedPathFromPrefs(shared_paths, vm_name, child);
}
if (!already_shared) {
base::Value vms(base::Value::Type::LIST);
vms.GetList().emplace_back(base::Value(vm_name));
shared_paths->SetKey(path.value(), std::move(vms));
}
}
void CrostiniSharePath::MigratePersistedPathsToMultiVM(
PrefService* profile_prefs) {
const base::ListValue* shared_paths =
profile_prefs->GetList(prefs::kCrostiniSharedPaths);
if (shared_paths->GetSize() == 0) {
return;
}
// Convert ['foo', 'bar'] to {'foo':['termina'], 'bar':['termina']}.
base::Value dict(base::Value::Type::DICTIONARY);
for (const auto& shared_path : *shared_paths) {
base::Value termina(base::Value::Type::LIST);
termina.GetList().emplace_back(base::Value(kCrostiniDefaultVmName));
dict.SetKey(shared_path.GetString(), std::move(termina));
}
profile_prefs->Set(prefs::kGuestOSPathsSharedToVms, std::move(dict));
profile_prefs->ClearPref(prefs::kCrostiniSharedPaths);
}
void CrostiniSharePath::OnVolumeMounted(chromeos::MountError error_code,
const file_manager::Volume& volume) {
if (error_code != chromeos::MountError::MOUNT_ERROR_NONE) {
return;
}
// Check if any persisted paths match volume.mount_path() or are children
// of it then share them with any running VMs.
const base::DictionaryValue* shared_paths =
profile_->GetPrefs()->GetDictionary(prefs::kGuestOSPathsSharedToVms);
for (const auto& it : shared_paths->DictItems()) {
base::FilePath path(it.first);
if (path != volume.mount_path() && !volume.mount_path().IsParent(path)) {
continue;
}
const auto& vms = it.second.GetList();
for (const auto& vm : vms) {
RegisterSharedPath(vm.GetString(), path);
if (CrostiniManager::GetForProfile(profile_)->IsVmRunning(
vm.GetString())) {
CallSeneschalSharePath(vm.GetString(), path, false,
base::BindOnce(mount_event_seneschal_callback_,
"share-on-mount", path));
}
}
}
}
void CrostiniSharePath::OnVolumeUnmounted(chromeos::MountError error_code,
const file_manager::Volume& volume) {
if (error_code != chromeos::MountError::MOUNT_ERROR_NONE) {
return;
}
for (auto it = shared_paths_.begin(); it != shared_paths_.end();) {
// Defensive copy of path since unsharing modifies shared_paths_.
base::FilePath path(it->first);
if (path == volume.mount_path() || volume.mount_path().IsParent(path)) {
// Defensive copy of vm_names for same reason.
const std::set<std::string> vm_names(it->second.vm_names);
++it;
for (auto& vm_name : vm_names) {
// Unshare with unpersist=false since we still want the path
// to be persisted when volume is next mounted.
UnsharePath(vm_name, path, false /* unpersist */,
base::BindOnce(mount_event_seneschal_callback_,
"unshare-on-unmount", path, path));
}
} else {
++it;
}
}
}
void CrostiniSharePath::StartFileWatcher(const base::FilePath& path) {
auto* info = FindSharedPathInfo(path);
if (!info || info->watcher) {
return;
}
info->watcher = std::make_unique<base::FilePathWatcher>();
info->watcher->Watch(path, false,
base::BindRepeating(&CrostiniSharePath::OnFileChanged,
base::Unretained(this)));
}
void CrostiniSharePath::RegisterSharedPath(const std::string& vm_name,
const base::FilePath& path) {
// Paths may be called to be shared multiple times for the same or different
// vm. If path is already registered, add vm_name to list of VMs shared with
// and return.
if (auto* info = FindSharedPathInfo(path)) {
info->vm_names.insert(vm_name);
return;
}
shared_paths_.emplace(path, SharedPathInfo(vm_name));
if (!no_file_watchers_for_testing_) {
sequenced_task_runner_->PostTask(
FROM_HERE, base::BindOnce(&CrostiniSharePath::StartFileWatcher,
base::Unretained(this), path));
}
}
void CrostiniSharePath::OnFileChanged(const base::FilePath& path, bool error) {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
if (shared_paths_.find(path) == shared_paths_.end()) {
return;
}
if (error) {
shared_paths_.erase(path);
return;
}
base::PostTaskWithTraits(
FROM_HERE, {content::BrowserThread::IO},
base::BindOnce(&CrostiniSharePath::CheckIfPathDeletedOnIOThread,
base::Unretained(this), path));
}
void CrostiniSharePath::CheckIfPathDeletedOnIOThread(
const base::FilePath& path) {
DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
if (base::PathExists(path)) {
return;
}
// If we can't find the path, check if the volume was unmounted.
// FileWatchers may fire before VolumeManager::OnVolumeUnmounted.
bool volume_still_mounted = false;
const std::vector<base::WeakPtr<file_manager::Volume>>& volume_list =
file_manager::VolumeManager::Get(profile_)->GetVolumeList();
for (const auto& volume : volume_list) {
if ((path == volume->mount_path() || volume->mount_path().IsParent(path)) &&
base::PathExists(volume->mount_path())) {
volume_still_mounted = true;
break;
}
}
if (!volume_still_mounted) {
return;
}
base::PostTaskWithTraits(FROM_HERE, {content::BrowserThread::UI},
base::BindOnce(&CrostiniSharePath::PathDeleted,
base::Unretained(this), path));
}
void CrostiniSharePath::PathDeleted(const base::FilePath& path) {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
auto* info = FindSharedPathInfo(path);
if (!info) {
return;
}
// Defensive copy of vm_names since unsharing modifies shared_paths_.
const std::set<std::string> vm_names(info->vm_names);
for (auto& vm_name : vm_names) {
UnsharePath(vm_name, path, true /* unpersist */,
base::BindOnce(mount_event_seneschal_callback_,
"unshare-on-delete", path, path));
}
}
void CrostiniSharePath::OnFilesChanged(
const std::vector<drivefs::mojom::FileChange>& changes) {
auto* integration_service =
drive::DriveIntegrationServiceFactory::FindForProfile(profile_);
if (!integration_service) {
return;
}
// Paths come as absolute from the drivefs mount point. E.g. /root/folder.
base::FilePath root("/");
for (const auto& change : changes) {
base::FilePath path = integration_service->GetMountPointPath();
if (change.type == drivefs::mojom::FileChange_Type::kDelete &&
root.AppendRelativePath(change.path, &path)) {
PathDeleted(path);
}
}
}
SharedPathInfo* CrostiniSharePath::FindSharedPathInfo(
const base::FilePath& path) {
auto it = shared_paths_.find(path);
if (it == shared_paths_.end()) {
return nullptr;
}
return &it->second;
}
} // namespace crostini