| // Copyright 2021 The Chromium Authors |
| // Use of this source code is governed by a BSD-style license that can be |
| // found in the LICENSE file. |
| |
| #import "ios/chrome/browser/ui/authentication/signin/consistency_promo_signin/consistency_promo_signin_mediator.h" |
| |
| #import <UIKit/UIKit.h> |
| |
| #import "base/strings/sys_string_conversions.h" |
| #import "base/test/ios/wait_util.h" |
| #import "base/test/metrics/histogram_tester.h" |
| #import "components/signin/public/identity_manager/accounts_in_cookie_jar_info.h" |
| #import "components/signin/public/identity_manager/objc/identity_manager_observer_bridge.h" |
| #import "components/sync_preferences/testing_pref_service_syncable.h" |
| #import "ios/chrome/browser/prefs/pref_names.h" |
| #import "ios/chrome/browser/shared/model/application_context/application_context.h" |
| #import "ios/chrome/browser/shared/model/browser_state/test_chrome_browser_state.h" |
| #import "ios/chrome/browser/signin/authentication_service.h" |
| #import "ios/chrome/browser/signin/authentication_service_factory.h" |
| #import "ios/chrome/browser/signin/chrome_account_manager_service_factory.h" |
| #import "ios/chrome/browser/signin/fake_authentication_service_delegate.h" |
| #import "ios/chrome/browser/signin/fake_system_identity.h" |
| #import "ios/chrome/browser/signin/fake_system_identity_manager.h" |
| #import "ios/chrome/browser/signin/identity_manager_factory.h" |
| #import "ios/chrome/browser/ui/authentication/authentication_flow.h" |
| #import "ios/chrome/browser/ui/authentication/signin/signin_completion_info.h" |
| #import "ios/chrome/test/ios_chrome_scoped_testing_local_state.h" |
| #import "ios/web/public/test/web_task_environment.h" |
| #import "testing/platform_test.h" |
| #import "third_party/ocmock/OCMock/OCMock.h" |
| #import "third_party/ocmock/gtest_support.h" |
| |
| #if !defined(__has_feature) || !__has_feature(objc_arc) |
| #error "This file requires ARC support." |
| #endif |
| |
| // Subclass of ConsistencyPromoSigninMediator to override |
| // `signinTimeoutDurationSeconds` property. |
| @interface TestConsistencyPromoSigninMediator : ConsistencyPromoSigninMediator |
| |
| @property(nonatomic, assign) NSInteger signinTimeoutDurationSeconds; |
| |
| @end |
| |
| @implementation TestConsistencyPromoSigninMediator |
| @end |
| |
| class ConsistencyPromoSigninMediatorTest : public PlatformTest { |
| public: |
| void SetUp() override { |
| PlatformTest::SetUp(); |
| authentication_flow_ = OCMStrictClassMock([AuthenticationFlow class]); |
| identity1_ = [FakeSystemIdentity fakeIdentity1]; |
| identity2_ = [FakeSystemIdentity fakeIdentity2]; |
| GetSystemIdentityManager()->AddIdentity(identity1_); |
| GetSystemIdentityManager()->AddIdentity(identity2_); |
| TestChromeBrowserState::Builder builder; |
| builder.AddTestingFactory( |
| AuthenticationServiceFactory::GetInstance(), |
| AuthenticationServiceFactory::GetDefaultFactory()); |
| browser_state_ = builder.Build(); |
| AuthenticationServiceFactory::CreateAndInitializeForBrowserState( |
| browser_state_.get(), |
| std::make_unique<FakeAuthenticationServiceDelegate>()); |
| PrefRegistrySimple* registry = pref_service_.registry(); |
| registry->RegisterIntegerPref(prefs::kSigninWebSignDismissalCount, 0); |
| |
| mediator_delegate_mock_ = OCMStrictProtocolMock( |
| @protocol(ConsistencyPromoSigninMediatorDelegate)); |
| } |
| |
| void TearDown() override { |
| EXPECT_OCMOCK_VERIFY((id)mediator_delegate_mock_); |
| EXPECT_OCMOCK_VERIFY((id)authentication_flow_); |
| PlatformTest::TearDown(); |
| } |
| |
| signin::IdentityManager* GetIdentityManager() { |
| return IdentityManagerFactory::GetForBrowserState(browser_state_.get()); |
| } |
| |
| FakeSystemIdentityManager* GetSystemIdentityManager() { |
| return FakeSystemIdentityManager::FromSystemIdentityManager( |
| GetApplicationContext()->GetSystemIdentityManager()); |
| } |
| |
| AuthenticationService* GetAuthenticationService() { |
| return AuthenticationServiceFactory::GetForBrowserState( |
| browser_state_.get()); |
| } |
| |
| TestConsistencyPromoSigninMediator* GetConsistencyPromoSigninMediator() { |
| ChromeAccountManagerService* chromeAccountManagerService = |
| ChromeAccountManagerServiceFactory::GetForBrowserState( |
| browser_state_.get()); |
| TestConsistencyPromoSigninMediator* mediator = |
| [[TestConsistencyPromoSigninMediator alloc] |
| initWithAccountManagerService:chromeAccountManagerService |
| authenticationService:GetAuthenticationService() |
| identityManager:GetIdentityManager() |
| userPrefService:&pref_service_ |
| accessPoint:signin_metrics::AccessPoint:: |
| ACCESS_POINT_WEB_SIGNIN]; |
| mediator.delegate = mediator_delegate_mock_; |
| return mediator; |
| } |
| |
| // Signs in and simulates cookies being added on the web. |
| void SigninAndSimulateCookies(ConsistencyPromoSigninMediator* mediator, |
| id<SystemIdentity> identity) { |
| GetAuthenticationService()->SignIn(identity); |
| OCMExpect([mediator_delegate_mock_ |
| consistencyPromoSigninMediatorSignInDone:mediator |
| withIdentity:identity]); |
| id<IdentityManagerObserverBridgeDelegate> |
| identityManagerObserverBridgeDelegate = |
| (id<IdentityManagerObserverBridgeDelegate>)mediator; |
| struct signin::AccountsInCookieJarInfo cookieJarInfo; |
| gaia::ListedAccount account; |
| account.id = |
| CoreAccountId::FromGaiaId(base::SysNSStringToUTF8(identity.gaiaID)); |
| cookieJarInfo.signed_in_accounts.push_back(account); |
| const GoogleServiceAuthError error(GoogleServiceAuthError::State::NONE); |
| [identityManagerObserverBridgeDelegate |
| onAccountsInCookieUpdated:cookieJarInfo |
| error:error]; |
| } |
| |
| // Signs in and simulates a cookie error. |
| void SigninAndSimulateError(ConsistencyPromoSigninMediator* mediator, |
| id<SystemIdentity> identity) { |
| GetAuthenticationService()->SignIn(identity); |
| __block BOOL error_did_happen_called = NO; |
| OCMExpect( |
| [mediator_delegate_mock_ |
| consistencyPromoSigninMediator:mediator |
| errorDidHappen: |
| ConsistencyPromoSigninMediatorErrorGeneric]) |
| .andDo(^(NSInvocation*) { |
| error_did_happen_called = YES; |
| }); |
| id<IdentityManagerObserverBridgeDelegate> |
| identityManagerObserverBridgeDelegate = |
| (id<IdentityManagerObserverBridgeDelegate>)mediator; |
| struct signin::AccountsInCookieJarInfo cookieJarInfo; |
| gaia::ListedAccount account; |
| account.id = |
| CoreAccountId::FromGaiaId(base::SysNSStringToUTF8(identity.gaiaID)); |
| cookieJarInfo.signed_in_accounts.push_back(account); |
| const GoogleServiceAuthError error( |
| GoogleServiceAuthError::State::INVALID_GAIA_CREDENTIALS); |
| [identityManagerObserverBridgeDelegate |
| onAccountsInCookieUpdated:cookieJarInfo |
| error:error]; |
| EXPECT_TRUE(base::test::ios::WaitUntilConditionOrTimeout( |
| base::test::ios::kWaitForActionTimeout, ^bool { |
| base::RunLoop().RunUntilIdle(); |
| return error_did_happen_called; |
| })); |
| } |
| |
| void SigninWithMediator(ConsistencyPromoSigninMediator* mediator, |
| id<SystemIdentity> identity, |
| BOOL signin_success) { |
| OCMStub([authentication_flow_ identity]).andReturn(identity); |
| __block signin_ui::CompletionCallback completion_block = nil; |
| OCMExpect([authentication_flow_ |
| startSignInWithCompletion:[OCMArg checkWithBlock:^BOOL( |
| signin_ui::CompletionCallback |
| callback) { |
| completion_block = callback; |
| return YES; |
| }]]); |
| [mediator signinWithAuthenticationFlow:authentication_flow_]; |
| if (!signin_success) { |
| OCMExpect([mediator_delegate_mock_ |
| consistencyPromoSigninMediator:mediator |
| errorDidHappen: |
| ConsistencyPromoSigninMediatorErrorFailedToSignin]); |
| } |
| completion_block(signin_success); |
| } |
| |
| protected: |
| // Needed for test browser state created by TestChromeBrowserState(). |
| web::WebTaskEnvironment task_environment_; |
| IOSChromeScopedTestingLocalState scoped_testing_local_state_; |
| std::unique_ptr<TestChromeBrowserState> browser_state_; |
| sync_preferences::TestingPrefServiceSyncable pref_service_; |
| |
| AuthenticationFlow* authentication_flow_ = nil; |
| FakeSystemIdentity* identity1_ = nil; |
| FakeSystemIdentity* identity2_ = nil; |
| |
| id<ConsistencyPromoSigninMediatorDelegate> mediator_delegate_mock_ = nil; |
| }; |
| |
| // Tests start and cancel by user. |
| TEST_F(ConsistencyPromoSigninMediatorTest, StartAndStopForCancel) { |
| base::HistogramTester histogram_tester; |
| ConsistencyPromoSigninMediator* mediator = |
| GetConsistencyPromoSigninMediator(); |
| [mediator disconnectWithResult:SigninCoordinatorResultCanceledByUser]; |
| |
| histogram_tester.ExpectTotalCount( |
| "Signin.AccountConsistencyPromoAction.Shown", 1); |
| histogram_tester.ExpectBucketCount( |
| "Signin.AccountConsistencyPromoAction.Shown", |
| signin_metrics::AccessPoint::ACCESS_POINT_WEB_SIGNIN, 1); |
| histogram_tester.ExpectTotalCount( |
| "Signin.AccountConsistencyPromoAction.DismissedButton", 1); |
| histogram_tester.ExpectBucketCount( |
| "Signin.AccountConsistencyPromoAction.DismissedButton", |
| signin_metrics::AccessPoint::ACCESS_POINT_WEB_SIGNIN, 1); |
| } |
| |
| // Tests start and interrupt. |
| TEST_F(ConsistencyPromoSigninMediatorTest, StartAndStopForInterrupt) { |
| base::HistogramTester histogram_tester; |
| ConsistencyPromoSigninMediator* mediator = |
| GetConsistencyPromoSigninMediator(); |
| [mediator disconnectWithResult:SigninCoordinatorResultInterrupted]; |
| |
| histogram_tester.ExpectTotalCount( |
| "Signin.AccountConsistencyPromoAction.Shown", 1); |
| histogram_tester.ExpectBucketCount( |
| "Signin.AccountConsistencyPromoAction.Shown", |
| signin_metrics::AccessPoint::ACCESS_POINT_WEB_SIGNIN, 1); |
| histogram_tester.ExpectTotalCount( |
| "Signin.AccountConsistencyPromoAction.DismissedOther", 1); |
| histogram_tester.ExpectBucketCount( |
| "Signin.AccountConsistencyPromoAction.DismissedOther", |
| signin_metrics::AccessPoint::ACCESS_POINT_WEB_SIGNIN, 1); |
| } |
| |
| // Tests start and sign-in with default identity. |
| TEST_F(ConsistencyPromoSigninMediatorTest, |
| SigninCoordinatorResultSuccessWithDefaultIdentity) { |
| base::HistogramTester histogram_tester; |
| pref_service_.SetInteger(prefs::kSigninWebSignDismissalCount, 1); |
| ConsistencyPromoSigninMediator* mediator = |
| GetConsistencyPromoSigninMediator(); |
| OCMExpect([mediator_delegate_mock_ |
| consistencyPromoSigninMediatorSigninStarted:mediator]); |
| SigninWithMediator(mediator, identity1_, /*signin_success=*/YES); |
| SigninAndSimulateCookies(mediator, identity1_); |
| EXPECT_EQ(0, pref_service_.GetInteger(prefs::kSigninWebSignDismissalCount)); |
| [mediator disconnectWithResult:SigninCoordinatorResultSuccess]; |
| |
| histogram_tester.ExpectTotalCount( |
| "Signin.AccountConsistencyPromoAction.Shown", 1); |
| histogram_tester.ExpectBucketCount( |
| "Signin.AccountConsistencyPromoAction.Shown", |
| signin_metrics::AccessPoint::ACCESS_POINT_WEB_SIGNIN, 1); |
| histogram_tester.ExpectTotalCount( |
| "Signin.AccountConsistencyPromoAction.SignedInWithDefaultAccount", 1); |
| histogram_tester.ExpectBucketCount( |
| "Signin.AccountConsistencyPromoAction.SignedInWithDefaultAccount", |
| signin_metrics::AccessPoint::ACCESS_POINT_WEB_SIGNIN, 1); |
| } |
| |
| // Tests start and sign-in with secondary identity. |
| TEST_F(ConsistencyPromoSigninMediatorTest, |
| SigninCoordinatorResultSuccessWithSecondaryIdentity) { |
| base::HistogramTester histogram_tester; |
| ConsistencyPromoSigninMediator* mediator = |
| GetConsistencyPromoSigninMediator(); |
| OCMExpect([mediator_delegate_mock_ |
| consistencyPromoSigninMediatorSigninStarted:mediator]); |
| SigninWithMediator(mediator, identity2_, /*signin_success=*/YES); |
| SigninAndSimulateCookies(mediator, identity2_); |
| [mediator disconnectWithResult:SigninCoordinatorResultSuccess]; |
| |
| histogram_tester.ExpectTotalCount( |
| "Signin.AccountConsistencyPromoAction.Shown", 1); |
| histogram_tester.ExpectBucketCount( |
| "Signin.AccountConsistencyPromoAction.Shown", |
| signin_metrics::AccessPoint::ACCESS_POINT_WEB_SIGNIN, 1); |
| histogram_tester.ExpectTotalCount( |
| "Signin.AccountConsistencyPromoAction.SignedInWithNonDefaultAccount", 1); |
| histogram_tester.ExpectBucketCount( |
| "Signin.AccountConsistencyPromoAction.SignedInWithNonDefaultAccount", |
| signin_metrics::AccessPoint::ACCESS_POINT_WEB_SIGNIN, 1); |
| } |
| |
| // Tests start and sign-in with an added identity. |
| TEST_F(ConsistencyPromoSigninMediatorTest, |
| SigninCoordinatorResultSuccessWithAddedIdentity) { |
| base::HistogramTester histogram_tester; |
| FakeSystemIdentity* identity3 = |
| [FakeSystemIdentity identityWithEmail:@"foo3@gmail.com" |
| gaiaID:@"foo1ID3" |
| name:@"Fake Foo 3"]; |
| GetSystemIdentityManager()->AddIdentity(identity3); |
| ConsistencyPromoSigninMediator* mediator = |
| GetConsistencyPromoSigninMediator(); |
| OCMExpect([mediator_delegate_mock_ |
| consistencyPromoSigninMediatorSigninStarted:mediator]); |
| SigninWithMediator(mediator, identity3, /*signin_success=*/YES); |
| [mediator systemIdentityAdded:identity3]; |
| SigninAndSimulateCookies(mediator, identity3); |
| [mediator disconnectWithResult:SigninCoordinatorResultSuccess]; |
| |
| histogram_tester.ExpectTotalCount( |
| "Signin.AccountConsistencyPromoAction.Shown", 1); |
| histogram_tester.ExpectBucketCount( |
| "Signin.AccountConsistencyPromoAction.Shown", |
| signin_metrics::AccessPoint::ACCESS_POINT_WEB_SIGNIN, 1); |
| histogram_tester.ExpectTotalCount( |
| "Signin.AccountConsistencyPromoAction.SignedInWithAddedAccount", 1); |
| histogram_tester.ExpectBucketCount( |
| "Signin.AccountConsistencyPromoAction.SignedInWithAddedAccount", |
| signin_metrics::AccessPoint::ACCESS_POINT_WEB_SIGNIN, 1); |
| } |
| |
| // Tests start and sign-in with an error. |
| TEST_F(ConsistencyPromoSigninMediatorTest, SigninCoordinatorWithError) { |
| base::HistogramTester histogram_tester; |
| ConsistencyPromoSigninMediator* mediator = |
| GetConsistencyPromoSigninMediator(); |
| OCMExpect([mediator_delegate_mock_ |
| consistencyPromoSigninMediatorSigninStarted:mediator]); |
| SigninWithMediator(mediator, identity1_, /*signin_success=*/YES); |
| SigninAndSimulateError(mediator, identity1_); |
| [mediator disconnectWithResult:SigninCoordinatorResultCanceledByUser]; |
| |
| histogram_tester.ExpectTotalCount( |
| "Signin.AccountConsistencyPromoAction.Shown", 1); |
| histogram_tester.ExpectBucketCount( |
| "Signin.AccountConsistencyPromoAction.Shown", |
| signin_metrics::AccessPoint::ACCESS_POINT_WEB_SIGNIN, 1); |
| histogram_tester.ExpectTotalCount( |
| "Signin.AccountConsistencyPromoAction.DismissedButton", 1); |
| histogram_tester.ExpectBucketCount( |
| "Signin.AccountConsistencyPromoAction.DismissedButton", |
| signin_metrics::AccessPoint::ACCESS_POINT_WEB_SIGNIN, 1); |
| histogram_tester.ExpectTotalCount( |
| "Signin.AccountConsistencyPromoAction.GenericErrorShown", 1); |
| histogram_tester.ExpectBucketCount( |
| "Signin.AccountConsistencyPromoAction.GenericErrorShown", |
| signin_metrics::AccessPoint::ACCESS_POINT_WEB_SIGNIN, 1); |
| } |
| |
| // Tests timeout error. |
| TEST_F(ConsistencyPromoSigninMediatorTest, SigninCoordinatorWithTimeoutError) { |
| base::HistogramTester histogram_tester; |
| TestConsistencyPromoSigninMediator* mediator = |
| GetConsistencyPromoSigninMediator(); |
| // Sets the timeout duration to 0, to trigger the timeout error without |
| // waiting. |
| mediator.signinTimeoutDurationSeconds = 0; |
| // Starts sign-in for the mediator. |
| OCMExpect([mediator_delegate_mock_ |
| consistencyPromoSigninMediatorSigninStarted:mediator]); |
| SigninWithMediator(mediator, identity1_, /*signin_success=*/YES); |
| // Expects timeout. |
| OCMExpect([mediator_delegate_mock_ |
| consistencyPromoSigninMediator:mediator |
| errorDidHappen: |
| ConsistencyPromoSigninMediatorErrorTimeout]); |
| // Wait for the time trigger. |
| base::RunLoop().RunUntilIdle(); |
| |
| // Expects show metric. |
| histogram_tester.ExpectTotalCount( |
| "Signin.AccountConsistencyPromoAction.Shown", 1); |
| histogram_tester.ExpectBucketCount( |
| "Signin.AccountConsistencyPromoAction.Shown", |
| signin_metrics::AccessPoint::ACCESS_POINT_WEB_SIGNIN, 1); |
| // Expects timeout metric. |
| histogram_tester.ExpectTotalCount( |
| "Signin.AccountConsistencyPromoAction.TimeoutErrorShown", 1); |
| histogram_tester.ExpectBucketCount( |
| "Signin.AccountConsistencyPromoAction.TimeoutErrorShown", |
| signin_metrics::AccessPoint::ACCESS_POINT_WEB_SIGNIN, 1); |
| // Closes the sign-in dialog. |
| [mediator disconnectWithResult:SigninCoordinatorResultCanceledByUser]; |
| // Expects dismiss metric. |
| histogram_tester.ExpectTotalCount( |
| "Signin.AccountConsistencyPromoAction.DismissedButton", 1); |
| histogram_tester.ExpectBucketCount( |
| "Signin.AccountConsistencyPromoAction.DismissedButton", |
| signin_metrics::AccessPoint::ACCESS_POINT_WEB_SIGNIN, 1); |
| } |
| |
| // Tests sign-in failed. |
| TEST_F(ConsistencyPromoSigninMediatorTest, SigninFailed) { |
| base::HistogramTester histogram_tester; |
| TestConsistencyPromoSigninMediator* mediator = |
| GetConsistencyPromoSigninMediator(); |
| // Sets the timeout duration to 0, to trigger the timeout error without |
| // waiting. |
| mediator.signinTimeoutDurationSeconds = 0; |
| // Starts sign-in for the mediator. |
| OCMExpect([mediator_delegate_mock_ |
| consistencyPromoSigninMediatorSigninStarted:mediator]); |
| SigninWithMediator(mediator, identity1_, /*signin_success=*/NO); |
| // Wait for the time trigger. |
| base::RunLoop().RunUntilIdle(); |
| |
| // Expects show metric. |
| histogram_tester.ExpectTotalCount( |
| "Signin.AccountConsistencyPromoAction.Shown", 1); |
| histogram_tester.ExpectBucketCount( |
| "Signin.AccountConsistencyPromoAction.Shown", |
| signin_metrics::AccessPoint::ACCESS_POINT_WEB_SIGNIN, 1); |
| // Expects sign-in failure metric. |
| histogram_tester.ExpectTotalCount( |
| "Signin.AccountConsistencyPromoAction.SignInFailed", 1); |
| histogram_tester.ExpectBucketCount( |
| "Signin.AccountConsistencyPromoAction.SignInFailed", |
| signin_metrics::AccessPoint::ACCESS_POINT_WEB_SIGNIN, 1); |
| // Closes the sign-in dialog. |
| [mediator disconnectWithResult:SigninCoordinatorResultCanceledByUser]; |
| // Expects dismiss metric. |
| histogram_tester.ExpectTotalCount( |
| "Signin.AccountConsistencyPromoAction.DismissedButton", 1); |
| histogram_tester.ExpectBucketCount( |
| "Signin.AccountConsistencyPromoAction.DismissedButton", |
| signin_metrics::AccessPoint::ACCESS_POINT_WEB_SIGNIN, 1); |
| } |
