Google Git
Sign in
chromium / chromium / src / f88f47ecdb2153427e00d227f1567d30f757ae06
commitf88f47ecdb2153427e00d227f1567d30f757ae06[log] [tgz]
authorThomas Lukaszewicz <tluk@chromium.org>Mon Aug 19 04:21:31 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Aug 19 04:21:31 2024
tree9ed21d791b5fd868a7413d78071b62c58e23f9dc
parentfc89f37fcdf2d5a890e3c8c506e38152cfbe6bf3 [diff]
[lens] Prevent crash navigating to lens WebUI in browser tab

LensUntrustedUI currently assumes that the LensOverlayControllerGlue
has been set on the WebContents hosting the WebUI when it's loaded.

The glue is set when creating the overlay view however it is not done
for browser tab WebContents objects. This results in invariant
violations and segfault crashes when loading lens in a browser tab.

The ideal behavior would be to suppress loading WebUI in unsupported
contexts, however the existing WebUI machinery makes this difficult.

Follow up work will tighten restrictions on WebUI instantiation and
improve context guarantees.

Bug: 360710001, 360724768
Change-Id: Ief01d04747aa06aaf1e9b58fe44a0d6a6def012f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5793562
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1343326}
3 files changed
tree: 9ed21d791b5fd868a7413d78071b62c58e23f9dc
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. CRYPTO_OWNERS
  78. DEPS
  79. DIR_METADATA
  80. LICENSE
  81. LICENSE.chromium_os
  82. OWNERS
  83. PRESUBMIT.py
  84. PRESUBMIT_test.py
  85. PRESUBMIT_test_mocks.py
  86. README.md
  87. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.