commit c403d6c9b54d50637f04243b4bebe73b5da4b0fe
author Svend Larsen <svend@chromium.org> Thu Mar 27 16:43:45 2025
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Mar 27 16:43:45 2025
tree 4dd69633051dd952c5c715b45c212d288086e04f
parent 62811a083a057f58a40d05963a04664dcf43f3b9

Revert "[BTM] Refactor BtmNavigationFlowDetector to use BtmPageVisitObserver"

This reverts commit c7a6ec453e84f63372c016272a68113f90e69acc.

Reason for revert: Crashing in canary (https://crbug.com/406738552)

Original change's description:
> [BTM] Refactor BtmNavigationFlowDetector to use BtmPageVisitObserver
>
> Mostly a no-op for BtmNavigationFlowDetector's behavior, except
> BtmPageVisitObserver is a more robust observer of some of the WCO events
> that BtmNavigationFlowDetector previously observed (especially late
> notifications for cookie accesses in navigations), so
> BtmNavigationFlowDetector should now be less flaky. For this reason,
> this CL also reenables most of the BtmNavigationFlowDetector
> browsertests that were disabled for flakiness. There's still one flaky
> browsertest this CL does not reenable, because its flakes have an
> unrelated source.
>
> I tried to limit the changes to BtmNavigationFlowDetector to only those
> necessary to switch its datasource from WebContentsObserver to
> BtmPageVisitObserver. There is likely further simplification made
> possible by the datasource change, but I wanted to keep this CL doing as
> close to just one thing as possible.
>
> Bug: 388718419
> Change-Id: I2fe2bc96bcd4d54a8ae7b85b538616971607c8ea
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6349857
> Reviewed-by: Giovanni Ortuno Urquidi <ortuno@chromium.org>
> Commit-Queue: Svend Larsen <svend@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1438155}

Bug: 388718419
Change-Id: Id16941827efc03347a6666ec98fa6bbf8d750982
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6403493
Auto-Submit: Svend Larsen <svend@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Andrew Liu <liu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1438820}