commit | d7bad14dd02723f22388c195885bad4646069cfe | [log] [tgz] |
---|---|---|
author | Tibor Goldschwendt <tiborg@chromium.org> | Mon Jun 17 20:32:02 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Jun 17 20:32:02 2019 |
tree | f43bbff7b4c9036e5cb4a7a807f536c243b24d58 | |
parent | 2e8b9b6ba018303475d25a227aecc08a08280fb9 [diff] |
[build] Remove <uses-sdk> and specify [min|target|max]SdkVersion in GN GN already has the concept of a minSdkVersion. This CL adds target- and maxSdkVersion and makes GN the source of truth by removing the <uses-sdk> element from all manifests. There are three steps that require [min|target|max]SdkVersion: linting, manifest merging and resource compilation. Each of these steps get the versions passed from GN. Furthermore, manifest merging removes the SDK version from the output manifest so that GN stays the source of truth. + Add a manifest_utils to unify manifest parsing, rewriting, etc. in a single place. + Move manifest verification to compile resources steps, where the final manifest is written. This CL adds some temporary workarounds to keep downstream working. Those will be removed once downstream is updated. Bug: 891996 Change-Id: If24be69d9c6b03a0d2423fad830a4da375d68505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650265 Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by: Simeon Anfinrud <sanfin@chromium.org> Reviewed-by: Yuchen Liu <yucliu@chromium.org> Reviewed-by: Misha Efimov <mef@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Eric Stevenson <estevenson@chromium.org> Reviewed-by: Peter Wen <wnwen@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#669810} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 95db95d387baeeb6544eb1193310eb5603c30ebc
Note: the canonical copy of the boundary interfaces lives in the chromium repository; this subdirectory of chromium is mirrored into the Android project for use by the webkit AndroidX module.
If you‘re reading this file in the Android repository, don’t make changes in this folder. Please make changes in chromium, or contact the OWNERS in frameworks/support/webkit/
.
If you're reading this file in the chromium repository, you should feel free to make changes. Please be aware that this folder has strict import requirements (enforced by DEPS
), because it must continue to build when mirrored into Android.