commit | 142fb062381a465b074fc02f4c4aea56ac58961d | [log] [tgz] |
---|---|---|
author | Hiroki Nakagawa <nhiroki@chromium.org> | Thu Aug 16 07:02:08 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Aug 16 07:02:08 2018 |
tree | b8ff48671ed0eac38ef800b1a7eca6be87f773ba | |
parent | ff56b3eb5c1af347f18904aba50cabd2c817f0d4 [diff] |
Revert "Whitelist the run loop mode that AppKit uses to animate the menu in fullscreen." This reverts commit b22ea1fa7081741279cfffeed61c0c19da4c0a23. Reason for revert: Let me speculatively revert for test failures on the mac bots. https://crbug.com/874716 Apparently this CL passes all try bots on the review page, but it fails some experimental fyi tests. See "browser_tests on (none) GPU on Mac (with patch, experimental)": https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_chromium_rel_ng/118766 I'll reland this CL if this is not relevant. Bug: 874716 Original change's description: > Whitelist the run loop mode that AppKit uses to animate the menu in fullscreen. > > This stops UI animation and video from freezing during the animation. > Also move some constants to test-accessible location and delete the > duplicates in the tests. > > Bug: 554993 > Change-Id: Ie4585fa405b32e8bdae984d5a4ffac700c1375ab > Reviewed-on: https://chromium-review.googlesource.com/1166169 > Reviewed-by: Mark Mentovai <mark@chromium.org> > Commit-Queue: Sidney San MartÃn <sdy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583361} TBR=sdy@chromium.org,mark@chromium.org Change-Id: I3fc77024fb7d82a8c79bad1b357475fb900d87d9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 554993 Reviewed-on: https://chromium-review.googlesource.com/1176903 Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#583568} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 3fbd268b75c69b6c755cfcf59fab7ec731116b4b