commit | 2d4f1ba831452c8a836fda2abdd513b8a778610c | [log] [tgz] |
---|---|---|
author | Michael Tang <tangm@microsoft.com> | Tue Nov 05 00:17:46 2024 |
committer | Copybara-Service <copybara-worker@google.com> | Tue Nov 05 00:20:24 2024 |
tree | 299f4e85308890b1b9380dfb5828e052f1766733 | |
parent | bc7378de0c5777fbb51b03f7f98b0a0ef5849f46 [diff] |
Revert "win: Remove special check for 10.0.22621.2428 Win SDK version" This reverts commit c05affe022794ad95bf28445501e10b27ff4debd. Reason for revert: We need this check again after the upgrade to 26100 was rolled back, https://chromium-review.googlesource.com/c/chromium/src/+/5972668 Original change's description: > win: Remove special check for 10.0.22621.2428 Win SDK version > > We added this check in crrev.com/c/5738088 since we needed a specific > patch version of 22621 with no simple way to check for it. We've now > updated past 22621 to 26100 in crrev.com/c/5898835, so we can remove > this check entirely. > > Bug: 40150597 > Bug: 325004812 > Change-Id: I3de129feaeb2dc0392508604260c9361995521bf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5949425 > Reviewed-by: Alan Zhao <ayzhao@google.com> > Commit-Queue: Michael Tang <tangm@microsoft.com> > Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com> > Cr-Commit-Position: refs/heads/main@{#1371682} Bug: 40150597 Bug: 325004812 Change-Id: I804f039ebf715c474f8e471ae55a7a3762100d32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5989717 Reviewed-by: Alan Zhao <ayzhao@google.com> Auto-Submit: Michael Tang <tangm@microsoft.com> Commit-Queue: Michael Tang <tangm@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1378013} NOKEYCHECK=True GitOrigin-RevId: 5d984f21325a0e66d659b89163cffd650aa7f339
//build
contains:
Since this directory is DEPS'ed in by some other repositories (webrtc, pdfium, v8, etc), it should be kept as self-contained as possible by not referring to files outside of it. Some exceptions exist (//testing
, select //third_party
subdirectories), but new dependencies tend to break these other projects, and so should be avoided.
Changes to //build
should be landed in the Chromium repo. They will then be replicated to the stand-alone build repo by the gsubtreed tool. Note: You can find all directories already available through gsubtreed in the list of all chromium repos.
//build/config
- Common templates via .gni
files.//build/toolchain
- GN toolchain definitions.Other .py files
- Some are used by GN/Ninja. Some by gclient hooks, some are just random utilities.Files referenced by //.gn
:
//build/BUILDCONFIG.gn
- Included by all BUILD.gn
files.//build/secondary
- An overlay for BUILD.gn
files. Enables adding BUILD.gn
to directories that live in sub-repositories.//build_overrides
- Refer to //build_overrides/README.md.