commit	7ff4b0206b94e56c015473ca832a8001c2e7f080	[log] [tgz]
author	Devon Loehr <dloehr@google.com>	Fri Apr 04 16:59:44 2025
committer	Copybara-Service <copybara-worker@google.com>	Fri Apr 04 17:03:29 2025
tree	c8ef7a654f462be4b2fa1bbd1f4c373fb751ebf5
parent	08b8024e34ac97351539582904ffa3adda6b0eb3 [diff]

Patch d3dcompiler_47.dll in Windows Toolchain.

On the previous roll (https://chromium-review.googlesource.com/c/chromium/src/+/6252774), Rafael Cintron pointed out that the d3dcompiler_47.dll included in Windows SDK 26100 was still attempting to dynamically link the UCRT, preventing it from being used on very old versions of Windows. We didn't catch it earlier because we updated our builders to a newer Windows version since the last attempt.

This CL switches our toolchain package to one that includes a previous of d3dcompiler_47.dll, from SDK version 10.0.22621.2428. It is otherwise identical to the previous package (version 10.0.26100.3323).

-----------------------------------------------------------------
Instructions to reproduce:
1. First, follow the instructions on the previous update to produce a toolchain package with hash 076960eda6: https://chromium-review.googlesource.com/c/chromium/src/+/6252774
2. On the VM used to create the package, unzip it to the desktop.
3. Download and install SDK version 10.0.22621.2428 from the SDK archive: https://developer.microsoft.com/en-us/windows/downloads/sdk-archive/
4. Copy over the dll as follows:
$ copy "C:\Program Files (x86)\Windows Kits\10\bin\10.0.22621.0\x64\d3dcompiler_47.dll" "C:\Users\User\Desktop\076960eda6\Windows Kits\10\Redist\D3D\x64"
$ copy "C:\Program Files (x86)\Windows Kits\10\bin\10.0.22621.0\x64\d3dcompiler_47.dll" "C:\Users\User\Desktop\076960eda6\Windows Kits\10\bin\10.0.26100.0\x64"
5. Re-package the toolchain with
$ python3 C:\workspace\depot_tools\win_toolchain\package_from_installed.py --repackage=C:\Users\User\Desktop\076960eda6

This produced the current package with hash 68a20d6dee

Bug: 362650376
Change-Id: I415de399082c1304e2e0411d6c7536284cfffabe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6432407
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Devon Loehr <dloehr@google.com>
Cr-Commit-Position: refs/heads/main@{#1442732}
NOKEYCHECK=True
GitOrigin-RevId: ae8ba63ecf7de090c7e43463674ced660260217f

vs_toolchain.py[diff]

1 file changed

tree: c8ef7a654f462be4b2fa1bbd1f4c373fb751ebf5

README.md

About

//build contains:

Core GN templates and configuration
Core Python build scripts

Since this directory is DEPS'ed in by some other repositories (webrtc, pdfium, v8, etc), it should be kept as self-contained as possible by not referring to files outside of it. Some exceptions exist (//testing, select //third_party subdirectories), but new dependencies tend to break these other projects, and so should be avoided.

Changes to //build should be landed in the Chromium repo. They will then be replicated to the stand-alone build repo by the gsubtreed tool. Note: You can find all directories already available through gsubtreed in the list of all chromium repos.

//build/config - Common templates via .gni files.
//build/toolchain - GN toolchain definitions.
Other .py files - Some are used by GN/Ninja. Some by gclient hooks, some are just random utilities.

Files referenced by //.gn:

//build/BUILDCONFIG.gn - Included by all BUILD.gn files.
//build/secondary - An overlay for BUILD.gn files. Enables adding BUILD.gn to directories that live in sub-repositories.
//build_overrides - Refer to //build_overrides/README.md.

About

Contents

Docs