commit | 563f147c8543f957146dacf83facfbf43f8c57ba | [log] [tgz] |
---|---|---|
author | Peter Kotwicz <pkotwicz@chromium.org> | Mon Apr 12 01:50:28 2021 |
committer | Copybara-Service <copybara-worker@google.com> | Mon Apr 12 02:00:40 2021 |
tree | f8adaec746b3cdecbd390b20a09d31bf3be86e2e | |
parent | f16baccb33c0c664703cbb57d6c96426b944be8c [diff] |
Fix build_with_chromium=false Android webrtc build attempt #2 This CL: 1) Replaces GN variable used to filter //third_party/android_deps dependencies with a new GN variable - limit_android_deps The new GN variable is needed because: - angle does not use JUnit tests. The standalone angle checkout should not require //third_party/robolectric for "gn gen" to work. - webrtc does use JUnit tests and thus requires //third_party/robolectric This change fixes the standalone WebRTC breakage caused by https://chromium-review.googlesource.com/c/chromium/src/+/2812340 2) Removes build_with_chromium requirement for _generate_final_jni in android_apk_or_module() GN template. This change is needed because the standalone webrtc build uses JNI. Angle will set "generate_final_jni" GN variable to avoid //base dependency. WebRTC bug:12634 Change-Id: I4ad86f33dfea32cb2fb4632e83ab14c0f9f7f4b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2815530 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by: Mohamed Heikal <mheikal@chromium.org> Reviewed-by: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#871341} GitOrigin-RevId: f4d6a45f2164a47ff2249bcfc793840e5bd632aa
//build
contains:
Since this directory is DEPS'ed in by some other repositories (webrtc, pdfium, v8, etc), it should be kept as self-contained as possible by not referring to files outside of it. Some exceptions exist (//testing
, select //third_party
subdirectories), but new dependencies tend to break these other projects, and so should be avoided.
Changes to //build
should be landed in the Chromium repo. They will then be replicated to the stand-alone build repo by the gsubtreed tool. Note: You can find all directories already available through gsubtreed in the list of all chromium repos.
//build/config
- Common templates via .gni
files.//build/toolchain
- GN toolchain definitions.Other .py files
- Some are used by GN/Ninja. Some by gclient hooks, some are just random utilities.Files referenced by //.gn
:
//build/BUILDCONFIG.gn
- Included by all BUILD.gn
files.//build/secondary
- An overlay for BUILD.gn
files. Enables adding BUILD.gn
to directories that live in sub-repositories.//build_overrides
- Refer to //build_overrides/README.md.