commit | 003593080f335fedda571cc7d3656629bb0583ae | [log] [tgz] |
---|---|---|
author | Tom Anderson <thomasanderson@chromium.org> | Tue May 05 21:36:41 2020 |
committer | Commit Bot <commit-bot@chromium.org> | Tue May 05 21:36:41 2020 |
tree | c52902d80b2e4f92884602dd459f96decb66134e | |
parent | 91b9fe98f98b901e151b60fd870aa71cf5923570 [diff] |
Remove third_party/binutils" R=thakis CC=thestig Bug: 1067854 Change-Id: I5e20c17210111c2f2c74888f45f4eb72172bca94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181970 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Ben Pastene <bpastene@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#765766} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 9792bfb5d4373f1632bf064f8252eeccb314b4f0
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true
. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false
.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.