commit | 0b2190a86b6ba3f860c948e777f2a1a86478362c | [log] [tgz] |
---|---|---|
author | ricea <ricea@chromium.org> | Wed Dec 07 07:12:53 2016 |
committer | Commit bot <commit-bot@chromium.org> | Wed Dec 07 07:14:33 2016 |
tree | 277935b76e2a6fea1fd66c247a9d85640dd78ad8 | |
parent | 435eb4e915d9a9451f1bf44d4eadc859e4c23cd5 [diff] |
ReadableStream and WritableStream use some common string constants. Share them to avoid duplication. BUG= Review-Url: https://codereview.chromium.org/2498983002 Cr-Original-Commit-Position: refs/heads/master@{#436885} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: ef448f0b40803fb6ef2d79211148d9075bd9dfa2
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true
. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false
.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.