commit | 0c7acc7939e831b90954b92dbf558ac694b3002e | [log] [tgz] |
---|---|---|
author | Austin Eng <enga@chromium.org> | Wed Oct 16 18:06:10 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Oct 16 18:06:10 2019 |
tree | 4bdcbe6bc870c83e94700f604e1e67e087017d17 | |
parent | 2442067546e52f66908943e2961631040e1e58a3 [diff] |
Add dawn_jsoncpp_dir to build_overrides/dawn.gni jsoncpp will be added as a DEP of Dawn to dump perf test output Bug: dawn:208 Change-Id: I0cfc3d9caebbcffb6ff68ecd98f6bd1ad4cbf873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863356 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#706534} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 31526343b3f3eb05a68b420f2a14040a3bc7a5a9
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true
. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false
.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.