commit | 352b30aff55cadf0602ef184df2a32a87529c911 | [log] [tgz] |
---|---|---|
author | avi <avi@chromium.org> | Tue Nov 22 15:14:53 2016 |
committer | Commit bot <commit-bot@chromium.org> | Tue Nov 22 15:18:46 2016 |
tree | e774491fad0a7e2b412ff2a746441f06599b6b27 | |
parent | 841b94586791c30d5b67abe81b68e809b9151174 [diff] |
Revert of Remove unused build override (patchset #2 id:20001 of https://codereview.chromium.org/2498603002/ ) Reason for revert: This breaks all the Mac builds. /b/build/slave/ios-simulator/build/src/buildtools/mac/gn gen //out/Debug-iphonesimulator --check -> returned 1 ERROR at //build/config/mac/mac_sdk.gni:18:27: Undefined identifier mac_deployment_target = mac_deployment_target_build_override ^----------------------------------- See //build/toolchain/mac/BUILD.gn:14:1: whence it was imported. import("//build/config/mac/mac_sdk.gni") ^-------------------------------------- See //BUILD.gn:73:1: which caused the file to be included. group("gn_all") { ^---------------- GN gen failed: 1 Original issue's description: > Remove unused build override > > The only downstream project using this used to be WebRTC, where it's no > longer needed. > > BUG=webrtc:6431 > NOTRY=true > > Committed: https://crrev.com/6dd0024530bfa1d1f88840204633788bad70239e > Cr-Commit-Position: refs/heads/master@{#433856} TBR=dpranke@chromium.org,kjellander@chromium.org,kthelgason@webrtc.org,kthelgason@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6431 Review-Url: https://codereview.chromium.org/2520383002 Cr-Original-Commit-Position: refs/heads/master@{#433861} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 5638488a75f3e1424bedc0607e2183b9d0ad8f4a
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true
. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false
.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.