commit | 69a9760beefae554b444251ebc8f0f4c44a73207 | [log] [tgz] |
---|---|---|
author | Marijn Kruisselbrink <mek@chromium.org> | Wed Feb 16 18:54:18 2022 |
committer | Copybara-Service <copybara-worker@google.com> | Wed Feb 16 19:19:28 2022 |
tree | 2ede309130ec252cbc0370bac9a10290fa4b2d52 | |
parent | 9575ca26524c7c7de00e89d061f4df51c346ab69 [diff] |
Revert "Build libc++ and libc++abi with -std=c++20" This reverts commit aea3a572a01844fdf4b4137d2b0c1fad90f70aab. Reason for revert: Broke compile on linux-gcc-rel bot https://ci.chromium.org/ui/p/chromium/builders/ci/linux-gcc-rel/253851/overview g++: error: unrecognized command line option ‘-std=c++20’; did you mean ‘-std=c++03’? Original change's description: > Build libc++ and libc++abi with -std=c++20 > > This changed upstream a while ago > (https://github.com/llvm/llvm-project/commit/3b625060fc), and as of > this commit it's required to build libcxxabi: > > https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+/3359ae8b6165e0512446c0f6b3fe50da4e30c8cb > > Generally, we require the same -std= flag across all of chromium. > Given that this is a low-level external library, make an exception > for just this library. (It also used c++17 before the rest, for the > same reasons.) No other target should do this. > > Bug: 1298070 > Change-Id: I6767464dfea1ae3b61224563da96be5dd08bd702 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3469195 > Commit-Queue: Nico Weber <thakis@chromium.org> > Auto-Submit: Nico Weber <thakis@chromium.org> > Reviewed-by: Hans Wennborg <hans@chromium.org> > Commit-Queue: Hans Wennborg <hans@chromium.org> > Cr-Commit-Position: refs/heads/main@{#971961} Bug: 1298070 Change-Id: Ia1d1c7e7923af63ea409d128aa842c1140fc8a58 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3468986 Owners-Override: Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#971963} NOKEYCHECK=True GitOrigin-RevId: dca2c86a4bbb1664d65a810b856677c05f3e3ff1