Prepare to remove base::JSONReader::ReadDict's parsing option default
Callers should be explicit if they need to opt into non-compliant JSON
parsing that allows Chromium-specific extensions, e.g. comments. This
fixes instances included in a typical Linux developer build.
Bug: 446188265
Change-Id: Ibe3ebc195a5e8db8c54180be24e29ac42ceea1a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6976568
Owners-Override: Lei Zhang <thestig@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1519488}
NOKEYCHECK=True
GitOrigin-RevId: 6e52fa3a80b89ab58a8a79405baf00611331b329
diff --git a/feedback_common.cc b/feedback_common.cc
index 7449de3..42ea7c7 100644
--- a/feedback_common.cc
+++ b/feedback_common.cc
@@ -241,8 +241,8 @@
}
if (!ai_metadata_.empty()) {
// Add feedback data for each key/value pair.
- std::optional<base::Value::Dict> dict =
- base::JSONReader::ReadDict(ai_metadata_);
+ std::optional<base::Value::Dict> dict = base::JSONReader::ReadDict(
+ ai_metadata_, base::JSON_PARSE_CHROMIUM_EXTENSIONS);
CHECK(dict);
for (auto pair : dict.value()) {
AddFeedbackData(feedback_data, pair.first, pair.second.GetString());
