commit 0c5f6f81c11f9d452fa097ab97b44fc625236a07
author Liam McLoughlin <lmcloughlin@chromium.org> Tue Nov 05 20:36:55 2013
committer chrome-internal-fetch <chrome-internal-fetch@google.com> Thu Jan 23 01:50:52 2014
tree bcde29ff6ec3604132a5c78b808d043cc860103e
parent 72aace79c07b49df1daa123790bf52230e86d759

platform2: build with hidden visibility/noexecstack by default

By having people opt-in to visibility, it means people won't
realize and we won't get as much coverage as we otherwise might.
common.mk was forcing this by default, but we lost that with GYP.

BUG=chromium:313434
TEST=x86-generic-full/daisy-full trybots pass
CQ-DEPEND=CL:180953, CL:175751

Change-Id: I9161cea9a7093457ec67ccb1f1a5725d332f4337
Reviewed-on: https://chromium-review.googlesource.com/175752
Reviewed-by: Paul Stewart <pstew@chromium.org>
Tested-by: Liam McLoughlin <lmcloughlin@chromium.org>
Reviewed-by: Liam McLoughlin <lmcloughlin@chromium.org>
Commit-Queue: Liam McLoughlin <lmcloughlin@chromium.org>

common.gypi

diff --git a/common.gypi b/common.gypi
index 15ddb61..0e085b2 100644
--- a/common.gypi
+++ b/common.gypi
@@ -52,6 +52,8 @@
       '-ggdb3',
       '-fstack-protector-strong',
       '-Wformat=2',
+      '-fvisibility=internal',
+      '-Wa,--noexecstack',
     ],
     'cflags_c': [
       '<(external_cflags)',
@@ -63,6 +65,7 @@
       'ldflags': [
         '<(external_ldflags)',
         '-Wl,-z,relro',
+        '-Wl,-z,noexecstack',
         '-Wl,-z,now',
         '-Wl,--as-needed',
       ],