commit c55a3a7c01391baa58fc2c20648a0bc53ee81d1d
author Phoebe Wang <phoebewang@google.com> Thu Sep 30 10:18:10 2021
committer Commit Bot <commit-bot@chromium.org> Tue Oct 05 07:05:00 2021
tree fecdfff54111bec9c51f9a5473c304dc3a9b11ea
parent 2b1c575ef0f2eab21c8ab2f0e0bde6a4c3498645

factory_install: set gbb flag 0x39 via futility and flashrom

Originally, we set gbb flag using get_gbb_flags.sh. However, netboot
ramfs doesn't have this file and its dependencies. We thus set the
gbb flag via flashrom.

BUG=b:201604209
TEST=trigger tryjob

Change-Id: Iac2b563c1e02aee6475afb355f120db8d2c4f726
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/factory_installer/+/3195287
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Tested-by: Ting-Hsuan Wang <phoebewang@chromium.org>
Commit-Queue: Ting-Hsuan Wang <phoebewang@chromium.org>

factory_install.sh

diff --git a/factory_install.sh b/factory_install.sh
index c8cabe3..a7127df 100644
--- a/factory_install.sh
+++ b/factory_install.sh
@@ -122,6 +122,10 @@
   crossystem "mainfw_type?developer" 2>/dev/null
 }
 
+is_netboot() {
+  grep -qw cros_netboot /proc/cmdline
+}
+
 explain_cros_debug() {
   log "To debug with a shell, boot factory shim in developer firmware (Ctrl-U)
    or add 'cros_debug' to your kernel command line:
@@ -357,7 +361,7 @@
 
   clear_block_devmode
 
-  if grep -q cros_netboot /proc/cmdline; then
+  if is_netboot; then
     log "Device is network booted."
     return
   fi
@@ -803,11 +807,14 @@
   # VB2_GBB_FLAG_FORCE_DEV_BOOT_USB                0x00000010
   # VB2_GBB_FLAG_DISABLE_FW_ROLLBACK_CHECK         0x00000020
   flashrom -p host --wp-disable --wp-range 0,0 > /dev/null 2>&1
-  local flags new_flags
-  flags="$(/usr/share/vboot/bin/get_gbb_flags.sh 2>/dev/null \
-    | awk '/Chrome OS GBB set flags:/ {print $NF}')"
-  new_flags="$(printf '0x%x' "$(( flags | 0x39 ))")"
-  /usr/share/vboot/bin/set_gbb_flags.sh "${new_flags}" > /dev/null 2>&1
+  local tmp_file cur_flags new_flags
+  tmp_file="$(mktemp)"
+  flashrom -p host -i GBB -r "${tmp_file}"
+  cur_flags="$(futility gbb -g --flags "${tmp_file}")" # flags: %#x
+  new_flags=$(( "${cur_flags#flags: }" | 0x39))
+  futility gbb -s --flags "${new_flags}" "${tmp_file}"
+  flashrom -p host -i GBB -w "${tmp_file}"
+  rm "${tmp_file}"
 }
 
 test_ec_flash_presence() {