Google GitGoogle Git
Sign in
chromium/chromiumos/platform/tast-tests/HEAD
commit
cc682f7377794d8134dc6b3d2e2e0b1ccb03bef8
[log]
author
Andrew Luo <aluo@google.com>
Fri Oct 09 20:18:36 2026
committer
chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com>
Mon Oct 12 08:10:54 2026
tree
d7a1589a5259798571e45112b6885cedea400928
parent
a1c8e4324d0395b4867a14d7dffd29d36759258f [diff]
tast-tests: cros/remote/power: fix panic when power persona tests are skipped

In the PowerQual test execution, if all tests within a given persona
are skipped (e.g. because the DUT is a Chromebox and lacks a battery),
the `minutesBatteryLifeValues` slice remains empty. Previously, passing
this empty slice to `stat.HarmonicMean` resulted in an unhandled
panic (`floats: zero length slice`) crashing the entire test run.

This CL adds a safeguard to explicitly check if the length of
the slice is zero before invoking the math calculations, safely
skipping the persona's aggregation if no tests were run.

BUG=b:571949227
TEST=tast run <dut> meta.PowerQual.fw_qual (on a device without a battery)

Change-Id: I88e4628d2baa607c34f3e7b702553f880c1e05d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/8550436
Tast-Review: Yanye Li <yanyeli@google.com>
Reviewed-by: Jing Li <jingmuli@google.com>
Reviewed-by: Yanye Li <yanyeli@google.com>
Tested-by: Andrew Luo <aluo@chromium.org>
Commit-Queue: Andrew Luo <aluo@chromium.org>
1 file changed
tree: d7a1589a5259798571e45112b6885cedea400928
  1. android/
  2. helpers/
  3. src/
  4. tools/
  5. vars/
  6. cros ⇨ src/go.chromium.org/tast-tests/cros
  7. .gitignore
  8. DIR_METADATA
  9. LICENSE
  10. OWNERS
  11. OWNERS.tast
  12. PRESUBMIT.cfg
  13. PRESUBMIT.py
  14. README.md
  15. unblocked_terms.txt
README.md

Tast (tests)

This repository contains integration tests that are run by Tast.

Directory structure

  • helpers/ - Source code for binaries executed by tests.
    • local/ - Helpers for local tests that are compiled and installed to /usr/local/libexec/tast/helpers/local/cros by the tast-local-helpers-cros package.
  • src/go.chromium.org/tast-tests/cros/
    • local/ - Code related to local (i.e. on-device or “client”) tests.
      • bundles/ - Local test bundles.
        • cros/ - The “cros” local test bundle, containing standard ChromeOS tests. Tests are packaged by category.
      • ... - Packages used only by local tests.
    • remote/ - Code related to remote (i.e. off-device or “server”) tests.
      • bundles/ - Remote test bundles.
        • cros/ - The “cros” remote test bundle, containing standard ChromeOS tests. Tests are packaged by category.
      • ... - Packages used only by remote tests.

Shared code, the main tast executable, the local_test_runner and remote_test_runner executables responsible for running bundles, and documentation are located in the tast repository.

GoDoc