firmware.BootMode: Report ModeSwitcherType
This is to help us understand the logs for CQ runs.
When you open the logfiles for a DUT you're not familiar with, it's
helpful to know which switch-case branch the code is following.
BUG=b:169704069
TEST=firmware.BootMode.normal
Change-Id: I2e14109ab51c3ef6718b9b3b314c3fa6fe832162
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/2445806
Tested-by: Greg Edelston <gredelston@google.com>
Reviewed-by: Andrew Luo <aluo@chromium.org>
Commit-Queue: Greg Edelston <gredelston@google.com>
diff --git a/src/chromiumos/tast/remote/bundles/cros/firmware/boot_mode.go b/src/chromiumos/tast/remote/bundles/cros/firmware/boot_mode.go
index 533ae1f..ada897d 100644
--- a/src/chromiumos/tast/remote/bundles/cros/firmware/boot_mode.go
+++ b/src/chromiumos/tast/remote/bundles/cros/firmware/boot_mode.go
@@ -99,9 +99,15 @@
defer h.Close(ctx)
ms, err := firmware.NewModeSwitcher(ctx, h)
if err != nil {
- s.Fatal("creating mode switcher: ", err)
+ s.Fatal("Creating mode switcher: ", err)
}
+ // Report ModeSwitcherType, for debugging.
+ if err := h.RequireConfig(ctx); err != nil {
+ s.Fatal("Requiring config")
+ }
+ s.Log("Mode switcher type: ", h.Config.ModeSwitcherType)
+
// Ensure that DUT starts in normal mode.
if curr, err := h.Reporter.CurrentBootMode(ctx); err != nil {
s.Fatal("Checking boot mode at beginning of test: ", err)