commit 94d5f31a5fd159101760add24b2f990c0ab289c1
author Martin Sherburn <martin.sherburn@datapath.co.uk> Mon Apr 10 16:06:23 2017
committer Commit Bot <commit-bot@chromium.org> Wed Jun 03 22:06:08 2020
tree b27f526a1bdff6a4b7a713eadbd1a14159e33c7d
parent 4b02e35353e8387ac1e532635631b61c15fdde0e

glretrace: Fixed issue where state could be dumped before the requested call had been executed in a multithreaded trace.

For example when getting state for a particular Draw call, the
framebuffer could contain the contents prior to the Draw call.

Change-Id: I16e404f78dde37cf3fe521d14d491ca6de78e327
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/apitrace/+/2224542
Reviewed-by: Po-Hsien Wang <pwang@chromium.org>
Commit-Queue: Robert Tarasov <tutankhamen@chromium.org>
Tested-by: Robert Tarasov <tutankhamen@chromium.org>

retrace/retrace_main.cpp

diff --git a/retrace/retrace_main.cpp b/retrace/retrace_main.cpp
index a0e3fc4..9111d86 100644
--- a/retrace/retrace_main.cpp
+++ b/retrace/retrace_main.cpp
@@ -347,7 +347,8 @@
         }
     }
 
-    if (call->no >= dumpStateCallNo &&
+    // dumpStateCallNo is 0 when fetching default state
+    if ((call->no == dumpStateCallNo || dumpStateCallNo == 0) &&
         dumper->canDump()) {
         StateWriter *writer = stateWriterFactory(std::cout);
         dumper->dumpState(*writer);