Ignore misfiring lint. Tweak some comments.
diff --git a/analysis_options.yaml b/analysis_options.yaml index 79f0950..0b0a7b5 100644 --- a/analysis_options.yaml +++ b/analysis_options.yaml
@@ -1,7 +1,8 @@ include: package:lints/recommended.yaml analyzer: errors: - deprecated_member_use_from_same_package: ignore + deprecated_member_use_from_same_package: ignore # https://github.com/dart-lang/linter/issues/2703 + void_checks: ignore # https://github.com/dart-lang/linter/issues/2685 linter: rules: - avoid_unused_constructor_parameters
diff --git a/lib/isolate_runner.dart b/lib/isolate_runner.dart index 7d7e990..15e0f65 100644 --- a/lib/isolate_runner.dart +++ b/lib/isolate_runner.dart
@@ -247,9 +247,8 @@ /// the returned future will be completed after one second, /// using [ping] to check if the isolate is still alive. Future<void>? get onExit { - // TODO(lrn): Is there a way to see if an isolate is dead - // so we can close the receive port for this future? - // Using [ping] for now. + // Using [ping] to see if the isolate is dead. + // Can't distinguish that from a slow-to-answer isolate. if (_onExitFuture == null) { var channel = SingleResponseChannel<void>(); isolate.addOnExitListener(channel.port);
diff --git a/lib/src/errors.dart b/lib/src/errors.dart index 34d2555..4c76642 100644 --- a/lib/src/errors.dart +++ b/lib/src/errors.dart
@@ -2,7 +2,6 @@ // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. -// TODO(lrn): This should be in package:async? /// Helper functions for working with errors. /// /// The [MultiError] class combines multiple errors into one object,