Google Git
Sign in
chromium / infra / luci / luci-go / 04a118946d13ad326c44dba9a635116ff7f31c4e
commit04a118946d13ad326c44dba9a635116ff7f31c4e[log] [tgz]
authorGarrett Beaty <gbeaty@chromium.org>Tue Apr 19 15:47:57 2022
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Apr 19 15:47:57 2022
tree21845177126b0f1a40621f8c9be71f45829e03a0
parent8e587a4592d3467fad00a6516cf15f4793d5afec [diff]
Use the ref for the commit link for commits against tags.

Builders that build against the tag commits benefit from having the tag
ref displayed instead of a commit hash since the tag identifies what's
being built in a more human-recognizable form. Currently, the tag ref
will be used only if the output commit does not have an ID set. The
common depot tools code always sets the ID when setting the output
commit, so for chromium builders building against tags, additional
configuration is used to prevent them from setting the output commit.
Displaying the tag in that case will allow for chromium builders to
unconditionally set the output commit, which will simplify configuration
code and queries of builds.

Bug: 1174266
Change-Id: I1afdd25e96521ef3cef92a23e9e13e04bbeae16c
Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/3591176
Reviewed-by: Weiwei Lin <weiweilin@google.com>
Commit-Queue: Garrett Beaty <gbeaty@google.com>
1 file changed
tree: 21845177126b0f1a40621f8c9be71f45829e03a0
  1. appengine/
  2. auth/
  3. auth_service/
  4. build/
  5. buildbucket/
  6. casviewer/
  7. cipd/
  8. client/
  9. cmdrunner/
  10. common/
  11. config/
  12. cv/
  13. deploy/
  14. dm/
  15. examples/
  16. gae/
  17. gce/
  18. grpc/
  19. hacks/
  20. hardcoded/
  21. led/
  22. logdog/
  23. luci_notify/
  24. lucicfg/
  25. lucictx/
  26. luciexe/
  27. machine-db/
  28. mailer/
  29. milo/
  30. mmutex/
  31. provenance/
  32. resultdb/
  33. scheduler/
  34. scripts/
  35. server/
  36. starlark/
  37. swarming/
  38. tokenserver/
  39. tools/
  40. tumble/
  41. vpython/
  42. web/
  43. .gitallowed
  44. .gitattributes
  45. .golangci.yml
  46. AUTHORS
  47. codereview.settings
  48. CONTRIBUTING.md
  49. CONTRIBUTORS
  50. go.mod
  51. go.sum
  52. LICENSE
  53. OWNERS
  54. PRESUBMIT.py
  55. README.md
  56. tools.go
  57. WATCHLISTS
README.md

luci-go: LUCI services and tools in Go

GoDoc

Installing

LUCI Go code is meant to be worked on from an Chromium infra.git checkout, which enforces packages versions and Go toolchain version. First get fetch via depot_tools.git then run:

fetch infra
cd infra/go
eval `./env.py`
cd src/go.chromium.org/luci

Contributing

Contributing uses the same flow as Chromium contributions.