Google Git
Sign in
chromium / infra / luci / luci-go / 069bd1c43bf395b50bc00ae7f6066083e5e971a4
commit069bd1c43bf395b50bc00ae7f6066083e5e971a4[log] [tgz]
authorVadim Shtayura <vadimsh@chromium.org>Wed Nov 20 19:25:21 2024
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Nov 20 19:25:21 2024
treebe479c1371788270d2ff398634b2f355ab5332c2
parentd6477a5017b00f8b8c37624bdc8ed037f104a0b3 [diff]
[proto] Un-deprecate and modernize API of common/proto/mask.

Functionality it provides is actually still useful even when
using standard field masks.

In this CL:
1. Stop referencing deprecated protobuf v1 packages.
2. Make FromFieldMask use variadic options pattern for better
   readability (to avoid FromFieldMask(..., false, false, false)).
3. Remove "isFieldNameJSON == true" case: it was dead code and
   it's a wrong layer to deal with it (JSON name => proto name
   conversion happens when deserializing the JSON field mask).
4. Make all existing callers pass mask.AdvancedSemantics() option,
   in preparation for supporting standard masks. Some of these
   callers probably already use only standard masks. They'll be
   discovered later.

R=gregorynisbet@google.com
BUG=b/376137855

Change-Id: If8596df0eb5293736789e102dcb2cb39efd25dad
Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/6036409
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Gregory Nisbet <gregorynisbet@google.com>
17 files changed
tree: be479c1371788270d2ff398634b2f355ab5332c2
  1. analysis/
  2. appengine/
  3. auth/
  4. auth_service/
  5. bisection/
  6. build/
  7. buildbucket/
  8. casviewer/
  9. cipd/
  10. cipkg/
  11. client/
  12. common/
  13. config/
  14. config_service/
  15. cv/
  16. deploy/
  17. examples/
  18. gae/
  19. gce/
  20. grpc/
  21. hardcoded/
  22. led/
  23. logdog/
  24. luci_notify/
  25. lucicfg/
  26. lucictx/
  27. luciexe/
  28. mailer/
  29. milo/
  30. mmutex/
  31. provenance/
  32. recipes_py/
  33. resultdb/
  34. scheduler/
  35. scripts/
  36. server/
  37. source_index/
  38. standalone/
  39. starlark/
  40. swarming/
  41. teams/
  42. third_party/
  43. tokenserver/
  44. tools/
  45. tree_status/
  46. vpython/
  47. web/
  48. .gitallowed
  49. .gitattributes
  50. .gitignore
  51. .go-lintable
  52. AUTHORS
  53. codereview.settings
  54. CONTRIBUTING.md
  55. CONTRIBUTORS
  56. go.mod
  57. go.sum
  58. LICENSE
  59. OWNERS
  60. PRESUBMIT.py
  61. README.md
  62. staticcheck.conf
  63. tools.go
  64. WATCHLISTS
README.md

luci-go: LUCI services and tools in Go

GoReference

Installing

LUCI Go code is meant to be worked on from an Chromium infra.git checkout, which enforces packages versions and Go toolchain version. First get fetch via depot_tools.git then run:

fetch infra
cd infra/go
eval `./env.py`
cd src/go.chromium.org/luci

It is now possible to directly install tools with go install:

go install go.chromium.org/luci/auth/client/cmd/...@latest
go install go.chromium.org/luci/buildbucket/cmd/...@latest
go install go.chromium.org/luci/cipd/client/cmd/...@latest
go install go.chromium.org/luci/client/cmd/...@latest
go install go.chromium.org/luci/cv/cmd/...@latest
go install go.chromium.org/luci/gce/cmd/...@latest
go install go.chromium.org/luci/grpc/cmd/...@latest
go install go.chromium.org/luci/logdog/client/cmd/...@latest
go install go.chromium.org/luci/luci_notify/cmd/...@latest
go install go.chromium.org/luci/lucicfg/cmd/...@latest
go install go.chromium.org/luci/luciexe/legacy/cmd/...@latest
go install go.chromium.org/luci/mailer/cmd/...@latest
go install go.chromium.org/luci/mmutex/cmd/...@latest
go install go.chromium.org/luci/resultdb/cmd/...@latest
go install go.chromium.org/luci/server/cmd/...@latest
go install go.chromium.org/luci/swarming/cmd/...@latest
go install go.chromium.org/luci/tokenserver/cmd/...@latest
go install go.chromium.org/luci/tools/cmd/...@latest

Contributing

Contributing uses the same flow as Chromium contributions.