Google Git
Sign in
chromium / infra / luci / luci-go / 1059ba22c0951d36e5a23b02c024971dd34fd593
commit1059ba22c0951d36e5a23b02c024971dd34fd593[log] [tgz]
authorYuanjun Huang <yuanjunh@google.com>Thu Aug 11 22:56:55 2022
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Aug 11 22:56:55 2022
tree2320304ca645e6bc121a0d6e23e4bb3fae6bac88
parentbbc7f46f2fdadd5a676b6eb91848fc4f97b15375 [diff]
[bbagent] fix a bug - should pass fatalUpdateBuildErrorSlot as a pointer

Go is pass-by-value. So the fatalUpdateBuildErrorSlot should be passed
as a pointer. Otherwise, `si.stopEvents()` function cannot pass value
to main function via fatalUpdateBuildErrorSlot(demo-https://go.dev/play/p/rQDexA-A86F?v=goprev).

This is the root cause for https://screenshot.googleplex.com/5gjjy3GfS69qcaF

Change-Id: Ic44211ac863c74d4db11c158ee1f8b4745842738
Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/3827171
Commit-Queue: Yuanjun Huang <yuanjunh@google.com>
Reviewed-by: Chan Li <chanli@chromium.org>
Reviewed-by: Yulan Lin <yulanlin@google.com>
1 file changed
tree: 2320304ca645e6bc121a0d6e23e4bb3fae6bac88
  1. appengine/
  2. auth/
  3. auth_service/
  4. build/
  5. buildbucket/
  6. casviewer/
  7. cipd/
  8. client/
  9. cmdrunner/
  10. common/
  11. config/
  12. cv/
  13. deploy/
  14. examples/
  15. gae/
  16. gce/
  17. grpc/
  18. hacks/
  19. hardcoded/
  20. led/
  21. logdog/
  22. luci_notify/
  23. lucicfg/
  24. lucictx/
  25. luciexe/
  26. mailer/
  27. milo/
  28. mmutex/
  29. provenance/
  30. resultdb/
  31. scheduler/
  32. scripts/
  33. server/
  34. starlark/
  35. swarming/
  36. tokenserver/
  37. tools/
  38. vpython/
  39. web/
  40. .gitallowed
  41. .gitattributes
  42. .golangci.yml
  43. AUTHORS
  44. codereview.settings
  45. CONTRIBUTING.md
  46. CONTRIBUTORS
  47. go.mod
  48. go.sum
  49. LICENSE
  50. OWNERS
  51. PRESUBMIT.py
  52. README.md
  53. tools.go
  54. WATCHLISTS
README.md

luci-go: LUCI services and tools in Go

GoReference

Installing

LUCI Go code is meant to be worked on from an Chromium infra.git checkout, which enforces packages versions and Go toolchain version. First get fetch via depot_tools.git then run:

fetch infra
cd infra/go
eval `./env.py`
cd src/go.chromium.org/luci

It is now possible to directly install tools with go install:

go install go.chromium.org/luci/auth/client/cmd/...@latest
go install go.chromium.org/luci/buildbucket/cmd/...@latest
go install go.chromium.org/luci/cipd/client/cmd/...@latest
go install go.chromium.org/luci/client/cmd/...@latest
go install go.chromium.org/luci/cv/cmd/...@latest
go install go.chromium.org/luci/gce/cmd/...@latest
go install go.chromium.org/luci/grpc/cmd/...@latest
go install go.chromium.org/luci/logdog/client/cmd/...@latest
go install go.chromium.org/luci/luci_notify/cmd/...@latest
go install go.chromium.org/luci/lucicfg/cmd/...@latest
go install go.chromium.org/luci/luciexe/legacy/cmd/...@latest
go install go.chromium.org/luci/mailer/cmd/...@latest
go install go.chromium.org/luci/mmutex/cmd/...@latest
go install go.chromium.org/luci/resultdb/cmd/...@latest
go install go.chromium.org/luci/server/cmd/...@latest
go install go.chromium.org/luci/swarming/cmd/...@latest
go install go.chromium.org/luci/tokenserver/cmd/...@latest
go install go.chromium.org/luci/tools/cmd/...@latest

Contributing

Contributing uses the same flow as Chromium contributions.