commit 15ff92378096509924d3e14121090137920588d1
author Chan Li <chanli@chromium.org> Thu Oct 31 21:37:12 2024
committer LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Oct 31 21:37:12 2024
tree 43688e7c84a0eeb4a09be813fe718e38a6cded02
parent 9bc593e64417c7c6011536f7d0bd90a3b9ae0112

Revert "[buildbucket] Speculative fix for handling errors when batch scheduling."

This reverts commit d10db6f2b6c12903b5ebbfc49562803089d0937a.

Reason for revert: caused panics, so the assumption that ret and err have the same length appear to be wrong

Original change's description:
> [buildbucket] Speculative fix for handling errors when batch scheduling.
>
> This changes the error handling code to make sure that every item in
> the returned batch is either a Build or an error, with an error
> taking precedence.
>
> I'm not certain that this will actually fix the issue, but the code
> location in question seemed like it could have allowed a non-nil,
> but empty, build to override an error in the response.
>
> R=chanli
>
> Bug: 376505379
> Change-Id: I81944e5c689c228bb65d7cd21c1d3398074bc10b
> Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/5980790
> Reviewed-by: Chan Li <chanli@chromium.org>
> Commit-Queue: Chan Li <chanli@chromium.org>
> Auto-Submit: Robbie Iannucci <iannucci@chromium.org>

Bug: 376505379
Change-Id: If68cb0f9347a34804f99495bdb47636fff58a229
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/5983644
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Chan Li <chanli@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>