Google Git
Sign in
chromium / infra / luci / luci-go / 16c3255fb94ccdcf38496c89dc8317abbde687e6
commit16c3255fb94ccdcf38496c89dc8317abbde687e6[log] [tgz]
authorVadim Shtayura <vadimsh@chromium.org>Mon Sep 11 20:27:21 2023
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Sep 11 20:27:21 2023
tree787ea14756da89eb271da34bd1f746b7317400ab
parent367bab90d8cf157169125e566fbf41febbbb4ba9 [diff]
[swarming] Refactor the client, part 1.

This extracts common subcommands copy-pasted functionality into
a dedicated package. It also starts extraction of a "fat" client
into a separate package as well.

Ideally all of Swarming client functionality is available as
a separate package with a nice API and swarming CLI just wraps
this package.

Common subcommands functionality extracted into base/:
  * Setting up the root context with logging and cancellation.
  * Parsing arguments.
  * Creating the Swarming client.
  * Writing JSON output and/or console output.
  * Timing execution of commands.

The primary benefit is to standardize how swarming subcommands
behave (e.g. have a single `-json-output` flag that behaves
consistently across all subcommands instead of 4 differently named
variations with slightly different behavior).

Change-Id: I90df5291291fac477e884bf1987723fb226d363d
Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/4827858
Reviewed-by: Jonah Hooper <jonahhooper@google.com>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
31 files changed
tree: 787ea14756da89eb271da34bd1f746b7317400ab
  1. analysis/
  2. appengine/
  3. auth/
  4. auth_service/
  5. bisection/
  6. build/
  7. buildbucket/
  8. casviewer/
  9. cipd/
  10. cipkg/
  11. client/
  12. common/
  13. config/
  14. config_service/
  15. cv/
  16. deploy/
  17. examples/
  18. gae/
  19. gce/
  20. grpc/
  21. hardcoded/
  22. led/
  23. logdog/
  24. luci_notify/
  25. lucicfg/
  26. lucictx/
  27. luciexe/
  28. mailer/
  29. milo/
  30. mmutex/
  31. provenance/
  32. resultdb/
  33. scheduler/
  34. scripts/
  35. server/
  36. standalone/
  37. starlark/
  38. swarming/
  39. third_party/
  40. tokenserver/
  41. tools/
  42. tree_status/
  43. vpython/
  44. web/
  45. .gitallowed
  46. .gitattributes
  47. .gitignore
  48. .golangci.yml
  49. AUTHORS
  50. codereview.settings
  51. CONTRIBUTING.md
  52. CONTRIBUTORS
  53. go.mod
  54. go.sum
  55. LICENSE
  56. OWNERS
  57. PRESUBMIT.py
  58. README.md
  59. tools.go
  60. WATCHLISTS
README.md

luci-go: LUCI services and tools in Go

GoReference

Installing

LUCI Go code is meant to be worked on from an Chromium infra.git checkout, which enforces packages versions and Go toolchain version. First get fetch via depot_tools.git then run:

fetch infra
cd infra/go
eval `./env.py`
cd src/go.chromium.org/luci

It is now possible to directly install tools with go install:

go install go.chromium.org/luci/auth/client/cmd/...@latest
go install go.chromium.org/luci/buildbucket/cmd/...@latest
go install go.chromium.org/luci/cipd/client/cmd/...@latest
go install go.chromium.org/luci/client/cmd/...@latest
go install go.chromium.org/luci/cv/cmd/...@latest
go install go.chromium.org/luci/gce/cmd/...@latest
go install go.chromium.org/luci/grpc/cmd/...@latest
go install go.chromium.org/luci/logdog/client/cmd/...@latest
go install go.chromium.org/luci/luci_notify/cmd/...@latest
go install go.chromium.org/luci/lucicfg/cmd/...@latest
go install go.chromium.org/luci/luciexe/legacy/cmd/...@latest
go install go.chromium.org/luci/mailer/cmd/...@latest
go install go.chromium.org/luci/mmutex/cmd/...@latest
go install go.chromium.org/luci/resultdb/cmd/...@latest
go install go.chromium.org/luci/server/cmd/...@latest
go install go.chromium.org/luci/swarming/cmd/...@latest
go install go.chromium.org/luci/tokenserver/cmd/...@latest
go install go.chromium.org/luci/tools/cmd/...@latest

Contributing

Contributing uses the same flow as Chromium contributions.