Google Git
Sign in
chromium / infra / luci / luci-go / 16e25fa176cf00a248d7d3e159987754a4e91935
commit16e25fa176cf00a248d7d3e159987754a4e91935[log] [tgz]
authorGreg NISBET <gregorynisbet@google.com>Tue May 06 18:43:23 2025
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue May 06 18:43:23 2025
treeb63101c67e868e3cf436d7e3ae2ba7d9c60fca94
parentceb1c59e4b1285e52eec8d00cba123d46f187b72 [diff]
[testing] make typed.Diff / typed.Got internal.

I, personally, really like typed.Diff and typed.Got as ways of writing tests.
(I also wrote the first version of typed, but this is not relevant I swear.)

It is however one more way of writing a test in Go, and having more ways of writing
tests increases the burden on everyone.

We should standardize on FTT, so let's make typed an internal package.

I don't think we should *delete* typed just yet though.

It genuinely has some good ideas, and I want to take a stab at upstreaming those ideas
into https://github.com/google/go-cmp

Change-Id: Ie3c4ca30dc594283bd37e8b3c0a7ccb930a4432b
Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/6508313
Reviewed-by: Robbie Iannucci <iannucci@google.com>
Commit-Queue: Gregory Nisbet <gregorynisbet@google.com>
13 files changed
tree: b63101c67e868e3cf436d7e3ae2ba7d9c60fca94
  1. analysis/
  2. appengine/
  3. auth/
  4. auth_service/
  5. bisection/
  6. build/
  7. buildbucket/
  8. casviewer/
  9. cipd/
  10. cipkg/
  11. client/
  12. common/
  13. config/
  14. config_service/
  15. cv/
  16. deploy/
  17. examples/
  18. gae/
  19. gce/
  20. grpc/
  21. hardcoded/
  22. led/
  23. logdog/
  24. luci_notify/
  25. lucicfg/
  26. lucictx/
  27. luciexe/
  28. mailer/
  29. milo/
  30. mmutex/
  31. provenance/
  32. recipes_py/
  33. resultdb/
  34. scheduler/
  35. scripts/
  36. server/
  37. source_index/
  38. standalone/
  39. starlark/
  40. swarming/
  41. teams/
  42. third_party/
  43. tokenserver/
  44. tools/
  45. tree_status/
  46. vpython/
  47. web/
  48. .gitallowed
  49. .gitignore
  50. .go-lintable
  51. AUTHORS
  52. codereview.settings
  53. CONTRIBUTING.md
  54. CONTRIBUTORS
  55. go.mod
  56. go.sum
  57. LICENSE
  58. OWNERS
  59. PRESUBMIT.py
  60. README.md
  61. staticcheck.conf
  62. tools.go
  63. WATCHLISTS
README.md

luci-go: LUCI services and tools in Go

GoReference

Installing

LUCI Go code is meant to be worked on from an Chromium infra.git checkout, which enforces packages versions and Go toolchain version. First get fetch via depot_tools.git then run:

fetch infra
cd infra/go
eval `./env.py`
cd src/go.chromium.org/luci

It is now possible to directly install tools with go install:

go install go.chromium.org/luci/auth/client/cmd/...@latest
go install go.chromium.org/luci/buildbucket/cmd/...@latest
go install go.chromium.org/luci/cipd/client/cmd/...@latest
go install go.chromium.org/luci/client/cmd/...@latest
go install go.chromium.org/luci/cv/cmd/...@latest
go install go.chromium.org/luci/gce/cmd/...@latest
go install go.chromium.org/luci/grpc/cmd/...@latest
go install go.chromium.org/luci/logdog/client/cmd/...@latest
go install go.chromium.org/luci/luci_notify/cmd/...@latest
go install go.chromium.org/luci/lucicfg/cmd/...@latest
go install go.chromium.org/luci/luciexe/legacy/cmd/...@latest
go install go.chromium.org/luci/mailer/cmd/...@latest
go install go.chromium.org/luci/mmutex/cmd/...@latest
go install go.chromium.org/luci/resultdb/cmd/...@latest
go install go.chromium.org/luci/server/cmd/...@latest
go install go.chromium.org/luci/swarming/cmd/...@latest
go install go.chromium.org/luci/tokenserver/cmd/...@latest
go install go.chromium.org/luci/tools/cmd/...@latest

Contributing

Contributing uses the same flow as Chromium contributions.